)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"80e0a18ddebdf326819ed5d28f2221ac7d6c53eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add InspectInterface for node-introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I103433c9e4aee7dfa3bcc049e469c812162e9ac6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a930d6b_47447f49","line":9,"updated":"2015-01-27 12:42:42.000000000","message":"Please describe what this change does, eg:\n\nAdd base InspectInterface metaclass.\nAdd instance of InspectInterface to the \"fake\" driver, and minimal unit tests for it.\nAlso, add InspectInterface to the \"ilo\" driver.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4c1ca196bda7cdcdda5a9add48e06c5c993298f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add InspectInterface for node-introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint ironic-node-properties-discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I103433c9e4aee7dfa3bcc049e469c812162e9ac6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_9244ae75","line":9,"in_reply_to":"1a930d6b_47447f49","updated":"2015-01-28 07:11:42.000000000","message":"Ok.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"}],"ironic/common/exception.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f24930dccfd99c5685beb3693d30af6b514272c7","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"class HardwareInspectionFailure(IronicException):"},{"line_number":518,"context_line":"    message \u003d _(\"Failed to inspect hardware. \")"}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_fb77d79d","line":518,"updated":"2015-02-05 11:49:46.000000000","message":"I suspect we will needs some \u0027reason\u0027 (like above).\n\nalso redundant trailing whitespace.","commit_id":"4ceb78f23ce89d26b7a51343b8d9a357326fcd59"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"85defcb02bab06736d1d7c01defb291de827934f","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"class HardwareInspectionFailure(IronicException):"},{"line_number":518,"context_line":"    message \u003d _(\"Failed to inspect hardware. \")"}],"source_content_type":"text/x-python","patch_set":11,"id":"da86d52c_43946c8a","line":518,"in_reply_to":"da86d52c_fb77d79d","updated":"2015-02-05 16:51:02.000000000","message":"Ok Done.","commit_id":"4ceb78f23ce89d26b7a51343b8d9a357326fcd59"}],"ironic/drivers/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e9d8d00bab1ad4fe4e52578ae95e82f51a290b2a","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    @abc.abstractmethod"},{"line_number":630,"context_line":"    def inspect_hardware(self, task):"},{"line_number":631,"context_line":"        \"\"\"Inspect hardware."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        \"\"\""},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_7f55bbf8","line":632,"updated":"2015-01-26 09:01:58.000000000","message":":param task: + a short description what \"inspection\" is would be nice to have here","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"80e0a18ddebdf326819ed5d28f2221ac7d6c53eb","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    @abc.abstractmethod"},{"line_number":630,"context_line":"    def inspect_hardware(self, task):"},{"line_number":631,"context_line":"        \"\"\"Inspect hardware."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        \"\"\""},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_673fbbb4","line":632,"updated":"2015-01-27 12:42:42.000000000","message":"Please define what the returned data structure is, including examples, that all drivers will be able to utilize.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4c1ca196bda7cdcdda5a9add48e06c5c993298f8","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    @abc.abstractmethod"},{"line_number":630,"context_line":"    def inspect_hardware(self, task):"},{"line_number":631,"context_line":"        \"\"\"Inspect hardware."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        \"\"\""},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_7fdd4214","line":632,"in_reply_to":"1a930d6b_673fbbb4","updated":"2015-01-28 07:11:42.000000000","message":"This method doesnt return anything to its caller. I have added description for the errors etc in the subsequent patch.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4c1ca196bda7cdcdda5a9add48e06c5c993298f8","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    @abc.abstractmethod"},{"line_number":630,"context_line":"    def inspect_hardware(self, task):"},{"line_number":631,"context_line":"        \"\"\"Inspect hardware."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        \"\"\""},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_bfb09ade","line":632,"in_reply_to":"1a930d6b_7f55bbf8","updated":"2015-01-28 07:11:42.000000000","message":"Ok.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5771b2226cb0e9f87ee28f8d104f48d958a8facb","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    @abc.abstractmethod"},{"line_number":631,"context_line":"    def inspect_hardware(self, task):"},{"line_number":632,"context_line":"        \"\"\"Inspect hardware to obtain the hardware properties."},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_275e1f13","line":633,"updated":"2015-01-29 08:45:27.000000000","message":"I\u0027d prefer more details in this docstring, i.e. I have to get back to the spec to remember the details.","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"92ff1b571a47021501ed61c1b97a04b92dc81f97","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    @abc.abstractmethod"},{"line_number":631,"context_line":"    def inspect_hardware(self, task):"},{"line_number":632,"context_line":"        \"\"\"Inspect hardware to obtain the hardware properties."},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_2f6fa92c","line":633,"in_reply_to":"fa81d914_275e1f13","updated":"2015-01-30 04:23:00.000000000","message":"DO you think we should name hardware properties(mandatory ones)?","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5771b2226cb0e9f87ee28f8d104f48d958a8facb","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        \"\"\"Inspect hardware to obtain the hardware properties."},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"},{"line_number":637,"context_line":"        :returns: None if successful."},{"line_number":638,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_479cf3c0","line":635,"updated":"2015-01-29 08:45:27.000000000","message":"this patch should introduce this exception (and I suggest dropping \u0027Instance\u0027 from it\u0027s name).","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"92ff1b571a47021501ed61c1b97a04b92dc81f97","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        \"\"\"Inspect hardware to obtain the hardware properties."},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"},{"line_number":637,"context_line":"        :returns: None if successful."},{"line_number":638,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_8f72550f","line":635,"in_reply_to":"fa81d914_479cf3c0","updated":"2015-01-30 04:23:00.000000000","message":"ok.","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5771b2226cb0e9f87ee28f8d104f48d958a8facb","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"},{"line_number":637,"context_line":"        :returns: None if successful."},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_67781790","line":636,"updated":"2015-01-29 08:45:27.000000000","message":"Ilo exception should not be mentioned in abstract class","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"92ff1b571a47021501ed61c1b97a04b92dc81f97","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"},{"line_number":637,"context_line":"        :returns: None if successful."},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_af62b93b","line":636,"in_reply_to":"fa81d914_67781790","updated":"2015-01-30 04:23:00.000000000","message":"ok","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5771b2226cb0e9f87ee28f8d104f48d958a8facb","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"},{"line_number":637,"context_line":"        :returns: None if successful."},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_4775d396","line":637,"updated":"2015-01-29 08:45:27.000000000","message":"It always returns None, no need to mention it","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"92ff1b571a47021501ed61c1b97a04b92dc81f97","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        :param task: a task from TaskManager."},{"line_number":635,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":636,"context_line":"        :raises: IloOperationError"},{"line_number":637,"context_line":"        :returns: None if successful."},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa81d914_ef58318c","line":637,"in_reply_to":"fa81d914_4775d396","updated":"2015-01-30 04:23:00.000000000","message":"ok.","commit_id":"698857b20280292b74bbc77f083206cfe164244e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0232b9197b570d0bf5dce7fa8625618f07c5a2fc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    the interfaces are appropriate."},{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    core_interfaces \u003d []"},{"line_number":46,"context_line":"    standard_interfaces \u003d []"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    power \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_07be6e65","line":45,"updated":"2015-02-03 13:07:19.000000000","message":"The inspect interface should be added to the base driver, as an \u0027inspect\u0027 attribute set to None. Potentially it could be added to the list of standard drivers also.","commit_id":"35c42ee2c64a9ab21df06b6dafbc9ccaa4608612"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"297d5422cb0a8cdee94c85e8223691adff17d996","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    the interfaces are appropriate."},{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    core_interfaces \u003d []"},{"line_number":46,"context_line":"    standard_interfaces \u003d []"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    power \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_0c0bca7d","line":45,"in_reply_to":"da86d52c_07be6e65","updated":"2015-02-04 07:36:27.000000000","message":"+1 for both","commit_id":"35c42ee2c64a9ab21df06b6dafbc9ccaa4608612"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0232b9197b570d0bf5dce7fa8625618f07c5a2fc","unresolved":false,"context_lines":[{"line_number":631,"context_line":"    def inspect_hardware(self, task):"},{"line_number":632,"context_line":"        \"\"\"Inspect hardware to obtain the essential and additional"},{"line_number":633,"context_line":"        hardware properties as required by scheduler."},{"line_number":634,"context_line":"           "},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        :param task: a task from TaskManager."},{"line_number":637,"context_line":"        :raises: HardwareInspectionFailure if unable to get essential"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_6772cae6","line":634,"updated":"2015-02-03 13:07:19.000000000","message":"nit: Whitespace error and extra newline.","commit_id":"35c42ee2c64a9ab21df06b6dafbc9ccaa4608612"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b3061f754ab63880ad60fccf02559e8898739ee5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    A reference to an instance of :class:InspectInterface."},{"line_number":101,"context_line":"    May be None, if unsupported by a driver."},{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    standard_interfaces.append(\u0027inspect\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @abc.abstractmethod"},{"line_number":106,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_1cf7fc5a","line":103,"updated":"2015-02-13 14:44:38.000000000","message":"Hm, I wonder if this will make validate fail if inspect \u003d None, because it\u0027s an abstract class. Idk if tempest tests run this or not, if they do then I guess we\u0027re fine.\n\ne.g. /v1/nodes/uuid/validate","commit_id":"b027fa1c34e82570a5333e46c0828f97c8a92c39"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"726a37b39d6f10905020e16b39cd4e258cc1f5c6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    A reference to an instance of :class:InspectInterface."},{"line_number":101,"context_line":"    May be None, if unsupported by a driver."},{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    standard_interfaces.append(\u0027inspect\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @abc.abstractmethod"},{"line_number":106,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_0c18a11d","line":103,"in_reply_to":"da86d52c_1cf7fc5a","updated":"2015-02-13 21:55:23.000000000","message":"I am not sure if it really fails. I did node-validate, and it seemed to pass. It did show inspect and its value as None. I will tests again and update.","commit_id":"b027fa1c34e82570a5333e46c0828f97c8a92c39"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e9aff2e7bfa22e6c14121bdfeb8f6a3db1fa5e86","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        :param task: a task from TaskManager."},{"line_number":688,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":689,"context_line":"                 hardware properties."},{"line_number":690,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_1848f189","line":689,"updated":"2015-02-13 10:57:10.000000000","message":"IIRC it returns the resulting state, e.g. INSPECTED (or None) or INSPECTING","commit_id":"b027fa1c34e82570a5333e46c0828f97c8a92c39"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"70f736e96caf77534cbd912139addd1b3270f1c1","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        :param task: a task from TaskManager."},{"line_number":688,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":689,"context_line":"                 hardware properties."},{"line_number":690,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"da86d52c_41db4d21","line":689,"in_reply_to":"da86d52c_1848f189","updated":"2015-02-13 14:18:04.000000000","message":"Lets decide on this after discussing on this on IRC.","commit_id":"b027fa1c34e82570a5333e46c0828f97c8a92c39"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7494045452c18d07cc349101cfa44464495ea5b1","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        :param task: a task from TaskManager."},{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. INSPECTED,"},{"line_number":694,"context_line":"                  INSPECTFAIL or INSPECTING."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"da86d52c_78503a5e","line":693,"updated":"2015-02-19 14:54:57.000000000","message":"we no longer have INSPECTED and instead of returning INSPECTFAIL it can simply raise an IronicException. That leaves us with choice like None or INSPECTING...","commit_id":"58a7ef7a296bab1101c7d9fdb3c06260e8b5e57e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5360acb61d837ba79a6c7c8482fd926582bbbe80","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        :param task: a task from TaskManager."},{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. INSPECTED,"},{"line_number":694,"context_line":"                  INSPECTFAIL or INSPECTING."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_ef051215","line":693,"in_reply_to":"ba7be1f8_9c25b50c","updated":"2015-02-20 03:20:29.000000000","message":"Yes. This method will be polled until node has finished inspecting.(either successful or failure)","commit_id":"58a7ef7a296bab1101c7d9fdb3c06260e8b5e57e"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"873df54eeb6fecb685dfac26e63d8e8941940d10","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        :param task: a task from TaskManager."},{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. INSPECTED,"},{"line_number":694,"context_line":"                  INSPECTFAIL or INSPECTING."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_9c25b50c","line":693,"in_reply_to":"da86d52c_78503a5e","updated":"2015-02-20 00:13:53.000000000","message":"Dmitry, Nisha, am I taking Dmitry\u0027s comment correctly that this method will be polled until the node has finished inspecting?","commit_id":"58a7ef7a296bab1101c7d9fdb3c06260e8b5e57e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5360acb61d837ba79a6c7c8482fd926582bbbe80","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        :param task: a task from TaskManager."},{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. INSPECTED,"},{"line_number":694,"context_line":"                  INSPECTFAIL or INSPECTING."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_3274ed9b","line":693,"in_reply_to":"da86d52c_78503a5e","updated":"2015-02-20 03:20:29.000000000","message":"Yes. will remove the INSPECTED and INSPECTFAIL.\nI think then it means we dont return any state from this interface. When failure is returned then conductor code can do process_event for \u0027fail\u0027. if failure is not returned, and it has come back to conductor after executing this method, then conductor can assume that its successful and issue a process_event for \u0027done\u0027.\nAlternatively, this method can return the target state for INSPECTING i.e. MANAGEABLE and conductor can check for this state. either is fine. Dmitry can we discuss this in IRC today and come to conclusion?","commit_id":"58a7ef7a296bab1101c7d9fdb3c06260e8b5e57e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"79e2cdebfb24d610879dc34cdcd247b1fd34f34b","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":694,"context_line":"                  or None."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_4960cf35","line":694,"updated":"2015-02-20 12:13:31.000000000","message":"or states.INSPECTING","commit_id":"a52c96a83d524914082b55b0136a4b349e4ff2b4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8cd36c396ac005289f47c90b8c404ada302cd769","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":694,"context_line":"                  or None."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_b94a6781","line":694,"in_reply_to":"ba7be1f8_4960cf35","updated":"2015-02-20 18:51:00.000000000","message":"Ah... I will add this in subsequent inspection patch where it is being implemented. Is that fine? and remove None from it.","commit_id":"a52c96a83d524914082b55b0136a4b349e4ff2b4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59739e19664f1631b187d6c41ca0c8a38cbfdb2e","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":694,"context_line":"                  or None."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_b2308402","line":694,"in_reply_to":"ba7be1f8_4e9fe05f","updated":"2015-02-23 20:06:12.000000000","message":"If a HardwareInspectionFailure is raised, will the node be put in state INSPECTFAIL? If so, the return value seems odd. I don\u0027t see how states.MANAGEABLE could be returned -- that would be if this call is synchronous?","commit_id":"a52c96a83d524914082b55b0136a4b349e4ff2b4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b3896806498eef44c6ae7a53280fb8df2329311f","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":694,"context_line":"                  or None."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_286ed22f","line":694,"in_reply_to":"ba7be1f8_b2308402","updated":"2015-02-24 09:20:08.000000000","message":"the docstring is slightly outdated (and it fixed in the next patch): it returns  states.MANAGEABLE (sync aka OOB case) or states.INSPECTING (async aka in-band case)","commit_id":"a52c96a83d524914082b55b0136a4b349e4ff2b4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"002a3a0d06366737b3864711481b685726e77be2","unresolved":false,"context_lines":[{"line_number":691,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":692,"context_line":"                 hardware properties."},{"line_number":693,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":694,"context_line":"                  or None."},{"line_number":695,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_4e9fe05f","line":694,"in_reply_to":"ba7be1f8_b94a6781","updated":"2015-02-20 19:36:56.000000000","message":"It\u0027s fine to me.","commit_id":"a52c96a83d524914082b55b0136a4b349e4ff2b4"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e9d8d00bab1ad4fe4e52578ae95e82f51a290b2a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Inspect hardware."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_9f5a6728","line":55,"updated":"2015-01-26 09:01:58.000000000","message":"I would say you should add this file in a separate patch","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"80e0a18ddebdf326819ed5d28f2221ac7d6c53eb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Inspect hardware."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_275a132a","line":55,"updated":"2015-01-27 12:42:42.000000000","message":"This line is causing all tests to fail as it does not parse properly.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4c1ca196bda7cdcdda5a9add48e06c5c993298f8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Inspect hardware."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_b5d199cf","line":55,"in_reply_to":"1a930d6b_275a132a","updated":"2015-01-28 07:11:42.000000000","message":"ohk silly mistake done here deva. :(","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"674b472eef918b29dc3d8fd5a26eae95ea0a6a49","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Inspect hardware."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_b433b8a9","line":55,"in_reply_to":"1a930d6b_9f5a6728","updated":"2015-01-26 15:38:06.000000000","message":"Ok i will try if tests pass... :) I am not sure as this method is there in abstract class....so i think it needs to be implemented in the patch.... but i will surely try and update.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"194dcadd40b1fa6bce7ac0a337228afc052d713d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Inspect hardware."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_b4f57858","line":55,"in_reply_to":"1a930d6b_b433b8a9","updated":"2015-01-26 15:44:40.000000000","message":"I meant the whole file actually. So you can introduce just the basic class here and iLO stuff in the next patch (like we do with specs).","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4c1ca196bda7cdcdda5a9add48e06c5c993298f8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Inspect hardware."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        return pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_f5da31e8","line":55,"in_reply_to":"1a930d6b_b4f57858","updated":"2015-01-28 07:11:42.000000000","message":"Ok will put this in a seperate patch.","commit_id":"6467210defb07b33cdb3ea041f2ce831bc0e4a6b"}]}