)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-24 09:17:30 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hardware Inspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If9aab90accf5a60ad3febbfc1f5d367eed987c13"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a930d6b_bd29b08b","line":7,"updated":"2015-01-27 13:25:18.000000000","message":"Please describe the change.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-24 09:17:30 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hardware Inspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If9aab90accf5a60ad3febbfc1f5d367eed987c13"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa81d914_847e21e3","line":7,"in_reply_to":"1a930d6b_bd29b08b","updated":"2015-01-28 19:55:35.000000000","message":"Ok","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"added to the list of node-set-provision-state valid"},{"line_number":17,"context_line":"actions are being addressed by"},{"line_number":18,"context_line":"https://review.openstack.org/#/c/148804"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements : blueprint ironic-node-properties-discovery"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: If9aab90accf5a60ad3febbfc1f5d367eed987c13"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"ba7be1f8_324266ae","line":19,"updated":"2015-02-25 23:07:08.000000000","message":"I think we may have been negligent about this, and I\u0027m not totally sure what we\u0027re going to do with this flag, but I think we should add a DocImpact flag [1]\n\n[1] https://wiki.openstack.org/wiki/Documentation/DocImpact","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b410dda14f991be4ad66ca7b50023214cd4006f1","unresolved":false,"context_lines":[{"line_number":592,"context_line":"# when configdrive_use_swift is True. (string value)"},{"line_number":593,"context_line":"#configdrive_swift_container\u003dironic_configdrive_container"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"# Timeout (seconds) for waiting from node introspection."},{"line_number":596,"context_line":"# 0 - unlimited. (integer value)"},{"line_number":597,"context_line":"#inspect_timeout\u003d1800"},{"line_number":598,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da86d52c_7bc76796","line":595,"updated":"2015-02-05 12:03:06.000000000","message":"s/from/for/\ns/introspection/inspection/","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                           \u0027/power_state\u0027, \u0027/provision_state\u0027, \u0027/reservation\u0027,"},{"line_number":65,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":66,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":67,"context_line":"                           \u0027/last_inspected\u0027, \u0027inspection_started_at\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @staticmethod"},{"line_number":70,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_df66afec","line":67,"updated":"2015-01-26 09:17:24.000000000","message":"/inspection_started_at","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                           \u0027/power_state\u0027, \u0027/provision_state\u0027, \u0027/reservation\u0027,"},{"line_number":65,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":66,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":67,"context_line":"                           \u0027/last_inspected\u0027, \u0027inspection_started_at\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @staticmethod"},{"line_number":70,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_a45a4581","line":67,"in_reply_to":"1a930d6b_df66afec","updated":"2015-01-28 19:55:35.000000000","message":"i didnt get the comment Dmitry.... :(","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":426,"context_line":"    \"\"\"The UTC date and time of the last discovery state change\"\"\""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":429,"context_line":"    \"\"\"The UTC date and time of the last discovery initiated at\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5fa2bffd","line":426,"updated":"2015-01-26 09:17:24.000000000","message":"s/discovery/hardware inspection/","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":426,"context_line":"    \"\"\"The UTC date and time of the last discovery state change\"\"\""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":429,"context_line":"    \"\"\"The UTC date and time of the last discovery initiated at\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_64ee8d8d","line":426,"in_reply_to":"1a930d6b_5fa2bffd","updated":"2015-01-28 19:55:35.000000000","message":"done :)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    \"\"\"The UTC date and time of the last discovery state change\"\"\""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":429,"context_line":"    \"\"\"The UTC date and time of the last discovery initiated at\"\"\""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    maintenance \u003d types.boolean"},{"line_number":432,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7fa3fbff","line":429,"updated":"2015-01-26 09:17:24.000000000","message":"ditto","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    \"\"\"The UTC date and time of the last discovery state change\"\"\""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":429,"context_line":"    \"\"\"The UTC date and time of the last discovery initiated at\"\"\""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    maintenance \u003d types.boolean"},{"line_number":432,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_84f38172","line":429,"in_reply_to":"1a930d6b_7fa3fbff","updated":"2015-01-28 19:55:35.000000000","message":"done :)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":538,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":539,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":540,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":541,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":542,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":543,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_dfadcfea","line":540,"updated":"2015-01-26 09:17:24.000000000","message":"I know it\u0027s only for tests, but these 2 values contradict each other.. maybe inspection_started_at\u003dNone?","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":538,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":539,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":540,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":541,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":542,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":543,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_9d179444","line":540,"updated":"2015-01-27 13:25:18.000000000","message":"This sample data is used in generating the REST API documentation, not unit tests. The time value here is fine as it illustrates the data type.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":538,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":539,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":540,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":541,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":542,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":543,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_24fc953e","line":540,"in_reply_to":"1a930d6b_9d179444","updated":"2015-01-28 19:55:35.000000000","message":"I havent changed here anything in subsequent patch as per Deva\u0027s comment. If still it needs to be addressed, give it as a comment on subsequent patch again.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dd7c6e8f16d93b39e5919265cd5d7a6426ebae6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                           \u0027/power_state\u0027, \u0027/provision_state\u0027, \u0027/reservation\u0027,"},{"line_number":65,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":66,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":67,"context_line":"                           \u0027/last_inspected\u0027, \u0027inspection_started_at\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @staticmethod"},{"line_number":70,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_c7962394","line":67,"updated":"2015-01-29 08:50:49.000000000","message":"should not it be /inspection_started_at?","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fe565e982458db18c90dc620d55de539f5c48abb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                           \u0027/power_state\u0027, \u0027/provision_state\u0027, \u0027/reservation\u0027,"},{"line_number":65,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":66,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":67,"context_line":"                           \u0027/last_inspected\u0027, \u0027inspection_started_at\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @staticmethod"},{"line_number":70,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_cfa8cd8f","line":67,"in_reply_to":"fa81d914_c7962394","updated":"2015-01-30 04:16:15.000000000","message":"ohooo...sorry i couldnt understand your comment earlier :)","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                           \u0027/power_state\u0027, \u0027/provision_state\u0027, \u0027/reservation\u0027,"},{"line_number":86,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":87,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":88,"context_line":"                           \u0027/driver_internal_info\u0027, \u0027/last_inspected\u0027, "},{"line_number":89,"context_line":"                           \u0027/inspection_started_at\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_8d5dd87b","line":88,"updated":"2015-02-04 20:51:26.000000000","message":"nit: trailing whitespace","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                           \u0027/power_state\u0027, \u0027/provision_state\u0027, \u0027/reservation\u0027,"},{"line_number":86,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":87,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":88,"context_line":"                           \u0027/driver_internal_info\u0027, \u0027/last_inspected\u0027, "},{"line_number":89,"context_line":"                           \u0027/inspection_started_at\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_e242d53c","line":88,"in_reply_to":"da86d52c_8d5dd87b","updated":"2015-02-05 04:12:53.000000000","message":"yes","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":87,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":88,"context_line":"                           \u0027/driver_internal_info\u0027, \u0027/last_inspected\u0027, "},{"line_number":89,"context_line":"                           \u0027/inspection_started_at\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"},{"line_number":92,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_2dc94c26","line":89,"updated":"2015-02-04 20:51:26.000000000","message":"nit: Since a list, maybe end with a coma and put closing bracket on next line","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":87,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":88,"context_line":"                           \u0027/driver_internal_info\u0027, \u0027/last_inspected\u0027, "},{"line_number":89,"context_line":"                           \u0027/inspection_started_at\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"},{"line_number":92,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_c25a3129","line":89,"in_reply_to":"da86d52c_2dc94c26","updated":"2015-02-05 04:12:53.000000000","message":"But how does that matter? when a new field is added then comma can be added","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2ec31f131b08f95cb9f79d32656f2a23ffa3e8dc","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":87,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":88,"context_line":"                           \u0027/driver_internal_info\u0027, \u0027/last_inspected\u0027, "},{"line_number":89,"context_line":"                           \u0027/inspection_started_at\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"},{"line_number":92,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_c5cddbb8","line":89,"in_reply_to":"da86d52c_c25a3129","updated":"2015-02-05 05:08:58.000000000","message":"See: http://docs.openstack.org/developer/hacking/\n\nSection on dictionaries/lists.\n\nIf a dictionary (dict) or list object is longer than 80 characters, its items should be split with newlines. Embedded iterables should have their items indented. Additionally, the last item in the dictionary should have a trailing comma. This increases readability and simplifies future diffs.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"21e21b54e649ec1e8970dfecd6d6706c2f0a4ff1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                           \u0027/target_power_state\u0027, \u0027/target_provision_state\u0027,"},{"line_number":87,"context_line":"                           \u0027/provision_updated_at\u0027, \u0027/maintenance_reason\u0027,"},{"line_number":88,"context_line":"                           \u0027/driver_internal_info\u0027, \u0027/last_inspected\u0027, "},{"line_number":89,"context_line":"                           \u0027/inspection_started_at\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @staticmethod"},{"line_number":92,"context_line":"    def mandatory_attrs():"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_317c39b5","line":89,"in_reply_to":"da86d52c_c5cddbb8","updated":"2015-02-05 08:47:01.000000000","message":"ok will do. But it wasnt there earlier at the end. :)","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                    pecan.request.context, node_uuid, topic)"},{"line_number":397,"context_line":"        elif target \u003d\u003d ir_states.VERBS[\u0027inspect\u0027]:"},{"line_number":398,"context_line":"            pecan.request.rpcapi.inspect_hardware("},{"line_number":399,"context_line":"                    pecan.request.context, node_uuid, topic\u003dtopic)"},{"line_number":400,"context_line":"        elif target in ("},{"line_number":401,"context_line":"                ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]):"},{"line_number":402,"context_line":"            pecan.request.rpcapi.do_provisioning_action("}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_ad037c40","line":399,"updated":"2015-02-04 20:51:26.000000000","message":"nit: too much indentation","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":396,"context_line":"                    pecan.request.context, node_uuid, topic)"},{"line_number":397,"context_line":"        elif target \u003d\u003d ir_states.VERBS[\u0027inspect\u0027]:"},{"line_number":398,"context_line":"            pecan.request.rpcapi.inspect_hardware("},{"line_number":399,"context_line":"                    pecan.request.context, node_uuid, topic\u003dtopic)"},{"line_number":400,"context_line":"        elif target in ("},{"line_number":401,"context_line":"                ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]):"},{"line_number":402,"context_line":"            pecan.request.rpcapi.do_provisioning_action("}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_a21e1d5d","line":399,"in_reply_to":"da86d52c_ad037c40","updated":"2015-02-05 04:12:53.000000000","message":"yes. Will correct it. Need to run pep8.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8342601adfe4e5f2b14e96e5097ec477091baf11","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # v1.4 added the MANAGEABLE state and two verbs to move nodes into"},{"line_number":73,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":74,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":75,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]]):"},{"line_number":76,"context_line":"        raise exception.NotAcceptable()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_e6520934","line":75,"updated":"2015-02-11 11:54:45.000000000","message":"this should be modified to gate \u0027inspect\u0027 under a new version","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"882175b1d871ab37dffacd976ee24420f4f5f5be","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # v1.4 added the MANAGEABLE state and two verbs to move nodes into"},{"line_number":73,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":74,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":75,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]]):"},{"line_number":76,"context_line":"        raise exception.NotAcceptable()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_a9f6228d","line":75,"in_reply_to":"da86d52c_e6520934","updated":"2015-02-11 12:20:07.000000000","message":"oh i think this got added recently. I will modify.","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9564c03866f0257118feb7f81bde0262a61d5e34","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":74,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":75,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027],"},{"line_number":76,"context_line":"                     ir_states.VERBS[\u0027inspect\u0027]]):"},{"line_number":77,"context_line":"        raise exception.NotAcceptable()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_dd8432b3","line":76,"updated":"2015-02-23 17:18:16.000000000","message":"I guess we need a _separate_ version for inspecting, but I\u0027ll leave it for the others to weigh in","commit_id":"a6a34f28e36219de6c7cd3b880d0d1865a841202"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":75,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":76,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027],"},{"line_number":77,"context_line":"                     ir_states.VERBS[\u0027inspect\u0027]]):"},{"line_number":78,"context_line":"        raise exception.NotAcceptable()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_f51fd858","line":77,"updated":"2015-02-25 23:07:08.000000000","message":"Hmmm....\n\nThis is a new feature. A user can inspect a fake driver with this change. So I think we need to put this in a new microversion, 1.6 (or whatever it is by the time you update this.)\n\nYou do that by updating ironic/api/controllers/v1/__init__.py","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76c9bd8194ebbf1302595fae86c0757671743e43","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":75,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":76,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027],"},{"line_number":77,"context_line":"                     ir_states.VERBS[\u0027inspect\u0027]]):"},{"line_number":78,"context_line":"        raise exception.NotAcceptable()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_b45c627e","line":77,"in_reply_to":"ba7be1f8_88fbda45","updated":"2015-02-26 16:19:49.000000000","message":"I think we need to clarify how the microversions work. What this will allow is someone who wants to use the new node names (in v1.5) to use the verb \u0027inspect\u0027 as well.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"94a2c8099c5b86da1475ff0585f2610323762060","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":75,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":76,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027],"},{"line_number":77,"context_line":"                     ir_states.VERBS[\u0027inspect\u0027]]):"},{"line_number":78,"context_line":"        raise exception.NotAcceptable()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_8414854d","line":77,"in_reply_to":"ba7be1f8_b45c627e","updated":"2015-02-26 20:27:38.000000000","message":"Ok i will add teh microversioning.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":75,"context_line":"    if (pecan.request.version.minor \u003c 4 and"},{"line_number":76,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027],"},{"line_number":77,"context_line":"                     ir_states.VERBS[\u0027inspect\u0027]]):"},{"line_number":78,"context_line":"        raise exception.NotAcceptable()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_88fbda45","line":77,"in_reply_to":"ba7be1f8_f51fd858","updated":"2015-02-26 10:45:37.000000000","message":"I can do that then we will will land up with different microversions check for different features like zap, inspect etc. I think current condition is correct as it doesnt allow you to use the verb \u0027inspect\u0027 or create fake driver with version below 1.4.\n\nIn next patch i havent addressed this, may be we can discuss and see if it is really required.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    provision_updated_at \u003d datetime.datetime"},{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_752e88a6","line":519,"updated":"2015-02-25 23:07:08.000000000","message":"Now that I am looking at this and I see a \u0027provision_updated_at\u0027, my \u0027consistency\u0027 bell is ringing. What do you think about changing \u0027last_inspected\u0027 to eg \u0027inspection_ended_at\u0027?","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"453d86ca26e5e157af02a27aad8cb67b194977fe","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    provision_updated_at \u003d datetime.datetime"},{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_354dc99a","line":519,"in_reply_to":"ba7be1f8_74c2eae9","updated":"2015-02-26 16:37:23.000000000","message":"well, inspection_finished_at lgtm","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    provision_updated_at \u003d datetime.datetime"},{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_c8bf925f","line":519,"in_reply_to":"ba7be1f8_752e88a6","updated":"2015-02-26 10:45:37.000000000","message":"I can do that but will need consensus on this from other reviewers also as this was the field agreed upon in spec.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"06f9ee6c026710a76f14fb149352ef76828f8185","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    provision_updated_at \u003d datetime.datetime"},{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_2524d00b","line":519,"in_reply_to":"ba7be1f8_752e88a6","updated":"2015-02-26 08:51:30.000000000","message":"last_inspected_at. inspection_ended_at implies that it\u0027s updated on failure too, which is not the case","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76c9bd8194ebbf1302595fae86c0757671743e43","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    provision_updated_at \u003d datetime.datetime"},{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_74c2eae9","line":519,"in_reply_to":"ba7be1f8_c8bf925f","updated":"2015-02-26 16:19:49.000000000","message":"@Dmitry, \u0027last_inspected_at\u0027 actually confuses me. Without knowing about \u0027inspection_started_at\u0027, it makes me think that it could be the time when the last inspection started.\n\nAre you saying that after an inspection is started, if it fails, the last_inspected_at does not reflect the date/time of the failure? If that\u0027s the case, then \u0027inspection_finished_at\u0027 would be better. (If it failed, it didn\u0027t finish.) Or \u0027inspection_completed_at\u0027?","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":523,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection initiated at\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_5811bb50","line":520,"updated":"2015-02-25 23:07:08.000000000","message":"how about \u0027The UTC date and time when the last hardware inspection ended.\u0027","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":517,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":523,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection initiated at\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_28b90e79","line":520,"in_reply_to":"ba7be1f8_5811bb50","updated":"2015-02-26 10:45:37.000000000","message":"Ok.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":523,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection initiated at\"\"\""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    maintenance \u003d types.boolean"},{"line_number":526,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_583ffbb3","line":523,"updated":"2015-02-25 23:07:08.000000000","message":"how about \u0027The UTC date and time when the last hardware inspection was started\u0027.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection state change\"\"\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":523,"context_line":"    \"\"\"The UTC date and time of the last hardware inspection initiated at\"\"\""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    maintenance \u003d types.boolean"},{"line_number":526,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_68aea62f","line":523,"in_reply_to":"ba7be1f8_583ffbb3","updated":"2015-02-26 10:45:37.000000000","message":"ok.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":648,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":649,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":650,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":651,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":652,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":653,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_38c7a797","line":650,"updated":"2015-02-25 23:07:08.000000000","message":"Maybe use something a bit more realistic. The provision state was updated at \u0027time\u0027. I don\u0027t actually remember the interaction between last_inspected and inspection_started_at, but if an inspection had been done and finished, what values would these two have? inspection_started_at would be earlier than last_inspected? I think provision_updated_at would need to be equal or greater than last_inspected.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"06f9ee6c026710a76f14fb149352ef76828f8185","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":648,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":649,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":650,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":651,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":652,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":653,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_85cadc18","line":650,"in_reply_to":"ba7be1f8_38c7a797","updated":"2015-02-26 08:51:30.000000000","message":"inspection_started_at \u003d None, last_inspected \u003d date.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":648,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":649,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":650,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":651,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":652,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":653,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_e850d633","line":650,"in_reply_to":"ba7be1f8_38c7a797","updated":"2015-02-26 10:45:37.000000000","message":"the inspection_started_at is updated when inspection has been just initiated.\nlast_inspected gets updated only on successful inspection. This should be ideally same as that of provision_updated_at when inspection has just finished.\n\nI am not sure what do you mean by realistic here. should we have current date and time, is that what you mean?\n\nDo you mean what Dmitry has given?","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"94a2c8099c5b86da1475ff0585f2610323762060","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":648,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":649,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":650,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":651,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":652,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":653,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_441e0d71","line":650,"in_reply_to":"ba7be1f8_b7e9c4b8","updated":"2015-02-26 20:27:38.000000000","message":"1-\u003e correct.\n2.-\u003e at the time of start of inspection,\n       inspection_started_at and provision_updated_at will have same value.\n       at the time of inspection successful completion, \n       last_inspected and provision_updated_at will have same value.\n \n       at the time inspection fail,\n       last_inspected and inspection_started_at will be None.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76c9bd8194ebbf1302595fae86c0757671743e43","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                     \u0027cpus\u0027: \u00271\u0027}, updated_at\u003dtime, created_at\u003dtime,"},{"line_number":648,"context_line":"                     provision_updated_at\u003dtime, instance_info\u003d{},"},{"line_number":649,"context_line":"                     maintenance\u003dFalse, maintenance_reason\u003dNone,"},{"line_number":650,"context_line":"                     last_inspected\u003dtime, inspection_started_at\u003dtime,"},{"line_number":651,"context_line":"                     console_enabled\u003dFalse)"},{"line_number":652,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":653,"context_line":"        # _chassis_uuid variable:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_b7e9c4b8","line":650,"in_reply_to":"ba7be1f8_e850d633","updated":"2015-02-26 16:19:49.000000000","message":"Nisha, if you look at the example, the node was created at the same time that the provision state was updated. \n\n1. If no inspection happened, your two inspect* would be None.\n\n2. If an inspection happened, provision_updated_at should be more recent than node creation date, and your inspect* values would be what?\n\nSo choose which of the two you want the example to reflect. What you are using now doesn\u0027t make sense because I don\u0027t think that would ever happen and it might confuse someone that looks at it.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection"},{"line_number":521,"context_line":"    ended successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_178ff075","line":521,"updated":"2015-02-26 16:20:06.000000000","message":"OH geez, I didn\u0027t realize this, and it isn\u0027t clear in the spec that it is only for a successful run. Thanks for clarifying it here.\n\nHow about \u0027The UTC date and time when the last hardware inspection finished (successfully).\u0027","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    last_inspected \u003d datetime.datetime"},{"line_number":520,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection"},{"line_number":521,"context_line":"    ended successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_4b34594a","line":521,"in_reply_to":"ba7be1f8_178ff075","updated":"2015-02-26 20:28:07.000000000","message":"ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"369780917f6248cef4999611c11534bae79d66b8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]])"},{"line_number":77,"context_line":"            or (pecan.request.version.minor \u003c 6 and"},{"line_number":78,"context_line":"            verb \u003d\u003d ir_states.VERBS[\u0027inspect\u0027])):"},{"line_number":79,"context_line":"                raise exception.NotAcceptable()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def allow_logical_names():"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_0d87b510","line":79,"updated":"2015-02-27 12:14:02.000000000","message":"if you make another patch, please split into 2 if\u0027s. This variant is hard to read. And while you\u0027re here, could you add logging?","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]])"},{"line_number":77,"context_line":"            or (pecan.request.version.minor \u003c 6 and"},{"line_number":78,"context_line":"            verb \u003d\u003d ir_states.VERBS[\u0027inspect\u0027])):"},{"line_number":79,"context_line":"                raise exception.NotAcceptable()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def allow_logical_names():"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_c850d60c","line":79,"in_reply_to":"ba7be1f8_0d87b510","updated":"2015-03-02 17:54:25.000000000","message":"Ok will do.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    inspection_finished_at \u003d datetime.datetime"},{"line_number":521,"context_line":"    \"\"\"The UTC date and time when the last inspection finished successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_78f17bcc","line":521,"updated":"2015-03-02 16:57:20.000000000","message":"I am fine with this but I wanted to point out that \u0027hardware\u0027 is not in the description. I don\u0027t know if you think it is important or not to have it.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    \"\"\"The UTC date and time of the last provision state change\"\"\""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    inspection_finished_at \u003d datetime.datetime"},{"line_number":521,"context_line":"    \"\"\"The UTC date and time when the last inspection finished successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_486306dd","line":521,"in_reply_to":"ba7be1f8_78f17bcc","updated":"2015-03-02 17:54:25.000000000","message":"oh i think thats missed out.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    \"\"\"The UTC date and time when the last inspection finished successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    maintenance \u003d types.boolean"},{"line_number":527,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_98154fe7","line":524,"updated":"2015-03-02 16:57:20.000000000","message":"I had a suggestion in revision 25, I\u0027ll copy it here (because the above doesn\u0027t make sense):\n\nhow about \u0027The UTC date and time when the last hardware inspection was started\u0027.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ddc45939f332e8158bd56b9b43f5e83ef7d50db8","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    \"\"\"The UTC date and time when the last inspection finished successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    maintenance \u003d types.boolean"},{"line_number":527,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_efeafcaa","line":524,"in_reply_to":"ba7be1f8_283a52cd","updated":"2015-03-02 19:02:27.000000000","message":"\u0027date and time of the hardware when\u0027 is the part that doesn\u0027t make sense. I am fine if you don\u0027t put \u0027last\u0027, but it should be \u0027hardware inspection\u0027 or \u0027inspection\u0027. It isn\u0027t the date and time of the hardware.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    \"\"\"The UTC date and time when the last inspection finished successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    maintenance \u003d types.boolean"},{"line_number":527,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_283a52cd","line":524,"in_reply_to":"ba7be1f8_98154fe7","updated":"2015-03-02 17:54:25.000000000","message":"Ok I will make the follow up patch. I thought \u0027last\u0027 is redundant here as this field is relevant for current inspection always.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4e6115d77803b8f193f87fa91206cdc1864eff9c","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    \"\"\"The UTC date and time when the last inspection finished successfully.\"\"\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    inspection_started_at \u003d datetime.datetime"},{"line_number":524,"context_line":"    \"\"\"The UTC date and time of the hardware when inspection was started\"\"\""},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    maintenance \u003d types.boolean"},{"line_number":527,"context_line":"    \"\"\"Indicates whether the node is in maintenance mode.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_aa92b248","line":524,"in_reply_to":"ba7be1f8_efeafcaa","updated":"2015-03-02 19:11:52.000000000","message":"ok.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"}],"ironic/common/exception.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    message \u003d _(\"Failed to create a file system. \""},{"line_number":503,"context_line":"                \"File system %(fs)s is not supported.\")"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"class InstanceHardwareIntrospectionFailure(IronicException):"},{"line_number":506,"context_line":"    message \u003d _(\"Failed to inspect hardware. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_9f7fc765","line":505,"updated":"2015-01-26 09:17:24.000000000","message":"s/Instance//  s/Introspection/Inspection/","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    message \u003d _(\"Failed to create a file system. \""},{"line_number":503,"context_line":"                \"File system %(fs)s is not supported.\")"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"class InstanceHardwareIntrospectionFailure(IronicException):"},{"line_number":506,"context_line":"    message \u003d _(\"Failed to inspect hardware. \")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_e488bdc8","line":505,"in_reply_to":"1a930d6b_9f7fc765","updated":"2015-01-28 19:55:35.000000000","message":"done. :)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dd7c6e8f16d93b39e5919265cd5d7a6426ebae6","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"class InstanceHardwareInspectionFailure(IronicException):"},{"line_number":511,"context_line":"    message \u003d _(\"Failed to inspect hardware. \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_07bafb22","line":511,"updated":"2015-01-29 08:50:49.000000000","message":"this should go to the previous patch, because you mention it in docstring there. also please drop \u0027Instance\u0027 from the name","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fe565e982458db18c90dc620d55de539f5c48abb","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"class InstanceHardwareInspectionFailure(IronicException):"},{"line_number":511,"context_line":"    message \u003d _(\"Failed to inspect hardware. \")"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_0f866513","line":511,"in_reply_to":"fa81d914_07bafb22","updated":"2015-01-30 04:16:15.000000000","message":"Ok. Will add there.","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"}],"ironic/common/states.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_dd53dc14","line":101,"updated":"2015-01-27 13:25:18.000000000","message":"Dmitry is correct. \"inspecting\" is the name of the state, whereas \"inspect\" is the verb which is PUT in the REST API to initiate the state change.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_3feb3314","line":101,"updated":"2015-01-26 09:17:24.000000000","message":"IIRC action is called \u0027inspect\u0027, state is called \u0027inspecting\u0027","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_64bccd6d","line":101,"in_reply_to":"1a930d6b_3feb3314","updated":"2015-01-28 19:55:35.000000000","message":"yes, but for my unit tests i had to do this.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_6463ed1a","line":101,"in_reply_to":"1a930d6b_dd53dc14","updated":"2015-01-28 19:55:35.000000000","message":"Yes Deva, i can see these in https://review.openstack.org/#/c/150073/7. But till that code is in i will keep this for my tests. will rebase once the https://review.openstack.org/#/c/150073/7 is in ...\n\nIs that fine?","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dd7c6e8f16d93b39e5919265cd5d7a6426ebae6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_27e37f34","line":101,"updated":"2015-01-29 08:50:49.000000000","message":"reminder to change later on","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fe565e982458db18c90dc620d55de539f5c48abb","unresolved":false,"context_lines":[{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_8f717546","line":101,"in_reply_to":"fa81d914_27e37f34","updated":"2015-01-30 04:16:15.000000000","message":"yes...","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"11702a2c92c648a452d3cfb33328e5954f142619","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_e1169ca6","line":100,"updated":"2015-02-03 16:46:46.000000000","message":"Should this comment be deleted? Also maybe better to change it in initial patch where you\u0027re adding states?","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"INSPECTED \u003d \u0027inspected\u0027"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"#INSPECTING \u003d \u0027inspecting\u0027"},{"line_number":101,"context_line":"INSPECTING \u003d \u0027inspect\u0027"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"INSPECTFAIL \u003d \u0027inspectfail\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_9c28d987","line":100,"in_reply_to":"da86d52c_e1169ca6","updated":"2015-02-03 21:34:07.000000000","message":"Actually it should be inspecting. BUt for my tests from ironic-client i changed it to inspect. With Manageable code changes in place i think i will not need this chnage. Still need to verify how it works with new-state-model in place....","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"}],"ironic/conductor/manager.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"            node \u003d task.node"},{"line_number":1565,"context_line":"            if node.maintenance:"},{"line_number":1566,"context_line":"                raise exception.NodeInMaintenance(op\u003d_(\u0027provisioning\u0027),"},{"line_number":1567,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_dd2cbc9b","line":1567,"updated":"2015-01-27 13:25:18.000000000","message":"+1 to removing this check.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"            node \u003d task.node"},{"line_number":1565,"context_line":"            if node.maintenance:"},{"line_number":1566,"context_line":"                raise exception.NodeInMaintenance(op\u003d_(\u0027provisioning\u0027),"},{"line_number":1567,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5fd71f4b","line":1567,"updated":"2015-01-26 09:17:24.000000000","message":"I vote for removing this check. It\u0027s not completely invalid to inspect node in maintenance (e.g. to check something in the end of maintenance). E.g. we do allow power on/off during maintenance.\n\nYou may seek more opinions on this, however..","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.driver.power.validate(task)"},{"line_number":1571,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1572,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1573,"context_line":"                    exception.MissingParameterValue) as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_fd1fb858","line":1570,"updated":"2015-01-27 13:25:18.000000000","message":"Dmitry, I think the point here was to validate both power and inspect interfaces before starting work. makes sense to me.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.driver.power.validate(task)"},{"line_number":1571,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1572,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1573,"context_line":"                    exception.MissingParameterValue) as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7fc85ba8","line":1570,"updated":"2015-01-26 09:17:24.000000000","message":"s/power/inspect/","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.driver.power.validate(task)"},{"line_number":1571,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1572,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1573,"context_line":"                    exception.MissingParameterValue) as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_e40b5d29","line":1570,"in_reply_to":"1a930d6b_fd1fb858","updated":"2015-01-28 19:55:35.000000000","message":"Yes deva you are correct.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"45d8cd05809dec795fe16ba30b9c6410dab26bdd","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                                                  node\u003dnode.uuid)"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.driver.power.validate(task)"},{"line_number":1571,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1572,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1573,"context_line":"                    exception.MissingParameterValue) as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5d49ac2f","line":1570,"in_reply_to":"1a930d6b_fd1fb858","updated":"2015-01-29 08:51:17.000000000","message":"hmmm... validating power interface makes a lot of sense for in-band, but what\u0027s the use for OOB?","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1576,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1579,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1580,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1581,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1d23a4a7","line":1578,"updated":"2015-01-27 13:25:18.000000000","message":"This check isn\u0027t necessary - you\u0027ve already tried to access task.driver.inspect on line 1571.\n\nInstead, you should add an exception handler for AttributeError, which converts that into UnsupportedDriverExtension","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1576,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1579,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1580,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1581,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_c8d81920","line":1578,"in_reply_to":"1a930d6b_1d23a4a7","updated":"2015-01-28 19:55:35.000000000","message":"ok. I will rather move this check up before line 1570","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"            except exception.InvalidState:"},{"line_number":1592,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1593,"context_line":"                    \"Request received to %(what)s %(node)s, but \""},{"line_number":1594,"context_line":"                    \"this is not possible in the current state of \""},{"line_number":1595,"context_line":"                    \"\u0027%(state)s\u0027. \") % {\u0027what\u0027: event,"},{"line_number":1596,"context_line":"                                        \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_3d3dc0c4","line":1593,"updated":"2015-01-27 13:25:18.000000000","message":"This error message could probably be made more user-friendly. Something like:\n\n\"Inspection is not possible while node %node is in state %state.\"","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"            except exception.InvalidState:"},{"line_number":1592,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1593,"context_line":"                    \"Request received to %(what)s %(node)s, but \""},{"line_number":1594,"context_line":"                    \"this is not possible in the current state of \""},{"line_number":1595,"context_line":"                    \"\u0027%(state)s\u0027. \") % {\u0027what\u0027: event,"},{"line_number":1596,"context_line":"                                        \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_3f3973a4","line":1593,"updated":"2015-01-26 09:17:24.000000000","message":"event is a constant here, no need for interpolation","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"            except exception.InvalidState:"},{"line_number":1592,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1593,"context_line":"                    \"Request received to %(what)s %(node)s, but \""},{"line_number":1594,"context_line":"                    \"this is not possible in the current state of \""},{"line_number":1595,"context_line":"                    \"\u0027%(state)s\u0027. \") % {\u0027what\u0027: event,"},{"line_number":1596,"context_line":"                                        \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_5eddc06f","line":1593,"in_reply_to":"1a930d6b_3d3dc0c4","updated":"2015-01-28 19:55:35.000000000","message":"ok","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"            except exception.InvalidState:"},{"line_number":1592,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1593,"context_line":"                    \"Request received to %(what)s %(node)s, but \""},{"line_number":1594,"context_line":"                    \"this is not possible in the current state of \""},{"line_number":1595,"context_line":"                    \"\u0027%(state)s\u0027. \") % {\u0027what\u0027: event,"},{"line_number":1596,"context_line":"                                        \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_3ef9ece9","line":1593,"in_reply_to":"1a930d6b_3f3973a4","updated":"2015-01-28 19:55:35.000000000","message":"ok.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"        if not inspect_timeout:"},{"line_number":1605,"context_line":"            return"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"        filters \u003d {\u0027reserved\u0027: False,"},{"line_number":1608,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1609,"context_line":"                   \u0027maintenance\u0027: False,"},{"line_number":1610,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5d38ccd2","line":1607,"updated":"2015-01-27 13:25:18.000000000","message":"A new index should be added for this query. The index should be on (provision_state, inspection_started_at)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"        if not inspect_timeout:"},{"line_number":1605,"context_line":"            return"},{"line_number":1606,"context_line":""},{"line_number":1607,"context_line":"        filters \u003d {\u0027reserved\u0027: False,"},{"line_number":1608,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1609,"context_line":"                   \u0027maintenance\u0027: False,"},{"line_number":1610,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_9efc9840","line":1607,"in_reply_to":"1a930d6b_5d38ccd2","updated":"2015-01-28 19:55:35.000000000","message":"I didnt get this comment. Do you mean \u0027filters\u0027 shall be just two fields : provision_state and inspection_started_at?","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"        filters \u003d {\u0027reserved\u0027: False,"},{"line_number":1608,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1609,"context_line":"                   \u0027maintenance\u0027: False,"},{"line_number":1610,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout}"},{"line_number":1611,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1612,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1613,"context_line":"                                    columns\u003dcolumns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7d33c8f5","line":1610,"updated":"2015-01-27 13:25:18.000000000","message":"I believe Dmitry is correct","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"        filters \u003d {\u0027reserved\u0027: False,"},{"line_number":1608,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1609,"context_line":"                   \u0027maintenance\u0027: False,"},{"line_number":1610,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout}"},{"line_number":1611,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1612,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1613,"context_line":"                                    columns\u003dcolumns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_bf4c8343","line":1610,"updated":"2015-01-26 09:17:24.000000000","message":"won\u0027t it fetch only nodes where inspection_started_at \u003d\u003d inspect_timeout? You need nodes with inspection_started_at \u003c time.time() - inspect_timeout, maybe deserves a separate dbapi function.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"        filters \u003d {\u0027reserved\u0027: False,"},{"line_number":1608,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1609,"context_line":"                   \u0027maintenance\u0027: False,"},{"line_number":1610,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout}"},{"line_number":1611,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1612,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1613,"context_line":"                                    columns\u003dcolumns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_fe9af412","line":1610,"in_reply_to":"1a930d6b_7d33c8f5","updated":"2015-01-28 19:55:35.000000000","message":"ok","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1613,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1614,"context_line":"                                    filters\u003dfilters,"},{"line_number":1615,"context_line":"                                    sort_key\u003d\u0027provision_updated_at\u0027,"},{"line_number":1616,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"        workers_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_9d2eb48a","line":1615,"updated":"2015-01-27 13:25:18.000000000","message":"sort_key should be inspection_started_at","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"                    if (task.node.maintenance or"},{"line_number":1630,"context_line":"                            task.node.provision_state !\u003d states.INSPECTING):"},{"line_number":1631,"context_line":"                        continue"},{"line_number":1632,"context_line":"                    # timeout has been reached - fail the deploy"},{"line_number":1633,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1634,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1635,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1f5037d3","line":1632,"updated":"2015-01-26 09:17:24.000000000","message":"s/deploy/inspecting/","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"                    # timeout has been reached - fail the deploy"},{"line_number":1633,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1634,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1635,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"},{"line_number":1636,"context_line":"                                                  task),"},{"line_number":1637,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"},{"line_number":1638,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_bd50d00b","line":1635,"updated":"2015-01-27 13:25:18.000000000","message":"this is the deploy\u0027s cleanup method. should there be a different/new method for cleaning up after a failed inspection attempt?","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dd7c6e8f16d93b39e5919265cd5d7a6426ebae6","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"            event \u003d \u0027inspect\u0027"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.process_event(event,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_87cb4ba4","line":1567,"updated":"2015-01-29 08:50:49.000000000","message":"nit: redundant variable","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"72e3bce841e225ad8ecc99e3f70b5b418a55929f","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"            event \u003d \u0027inspect\u0027"},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"            try:"},{"line_number":1570,"context_line":"                task.process_event(event,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_4ff77d8b","line":1567,"in_reply_to":"fa81d914_87cb4ba4","updated":"2015-01-30 04:18:11.000000000","message":"why its redundant...i tried to keep it same as deploy....i have to actually test everything again as my code was working when new state model was not there....so will have to test again along with new things....","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dd7c6e8f16d93b39e5919265cd5d7a6426ebae6","unresolved":false,"context_lines":[{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"    @periodic_task.periodic_task("},{"line_number":1584,"context_line":"            spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1585,"context_line":"    def _check_inspection_timeout(self, context):"},{"line_number":1586,"context_line":"        inspect_timeout \u003d CONF.conductor.inspect_timeout"},{"line_number":1587,"context_line":"        if not inspect_timeout:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_27ba9f0a","line":1584,"updated":"2015-01-29 08:50:49.000000000","message":"this should be a separate config option","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fe565e982458db18c90dc620d55de539f5c48abb","unresolved":false,"context_lines":[{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"    @periodic_task.periodic_task("},{"line_number":1584,"context_line":"            spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1585,"context_line":"    def _check_inspection_timeout(self, context):"},{"line_number":1586,"context_line":"        inspect_timeout \u003d CONF.conductor.inspect_timeout"},{"line_number":1587,"context_line":"        if not inspect_timeout:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_efae7180","line":1584,"in_reply_to":"fa81d914_27ba9f0a","updated":"2015-01-30 04:16:15.000000000","message":"But at the end we manage the provision_state and target_provision_state, Correct? Thats the reason i kept it same...","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dd7c6e8f16d93b39e5919265cd5d7a6426ebae6","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"                    if (task.node.maintenance or"},{"line_number":1607,"context_line":"                            task.node.provision_state !\u003d states.INSPECTING):"},{"line_number":1608,"context_line":"                        continue"},{"line_number":1609,"context_line":"                    # timeout has been reached - fail the inspecting"},{"line_number":1610,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1611,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1612,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_a75ccfee","line":1609,"updated":"2015-01-29 08:50:49.000000000","message":"you don\u0027t check for actual timeout here :) I suggest creating a new dbapi function to fetch timeout nodes and use it instead of generic get_nodeinfo_list","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fe565e982458db18c90dc620d55de539f5c48abb","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"                    if (task.node.maintenance or"},{"line_number":1607,"context_line":"                            task.node.provision_state !\u003d states.INSPECTING):"},{"line_number":1608,"context_line":"                        continue"},{"line_number":1609,"context_line":"                    # timeout has been reached - fail the inspecting"},{"line_number":1610,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1611,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1612,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_2fd32905","line":1609,"in_reply_to":"fa81d914_a75ccfee","updated":"2015-01-30 04:16:15.000000000","message":"yes i know thats one item i was thinking how to do....I will consider your suggestion for creation of new dbapi function.","commit_id":"16bb331a312c6e3809c5c3ebef15bbab06229687"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        node.save()"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    return count"},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":1611,"context_line":"                                   exception.NodeLocked,"},{"line_number":1612,"context_line":"                                   exception.InstanceHardwareIntrospectionFailure,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_825fac40","line":1609,"updated":"2015-02-03 13:42:57.000000000","message":"I believe your merge/rebase has failed - the above deploy method is now a function outside of the conductor, which is presumably confusing git.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        node.save()"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    return count"},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":1611,"context_line":"                                   exception.NodeLocked,"},{"line_number":1612,"context_line":"                                   exception.InstanceHardwareIntrospectionFailure,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_99be2b64","line":1609,"in_reply_to":"da86d52c_825fac40","updated":"2015-02-03 21:34:07.000000000","message":"i actually didnt receive any merge/rebase error. Anyway the new patch will be based on new code.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2fd9fdd7b0c902b6ea40589c834e1ac5323ecafe","unresolved":false,"context_lines":[{"line_number":1606,"context_line":"        node.save()"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"    return count"},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":1611,"context_line":"                                   exception.NodeLocked,"},{"line_number":1612,"context_line":"                                   exception.InstanceHardwareIntrospectionFailure,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_27342849","line":1609,"in_reply_to":"da86d52c_99be2b64","updated":"2015-02-04 09:09:40.000000000","message":"Perhaps I should have been more clear - I believe the automatic merge logically succeeded but that the result is semantically and syntactically incorrect. The function above this method, do_sync_power_state, is no longer a method on the Conductor, but is a global function. The new methods must therefore be moved above these functions as they are not currently part of the ConductorManager class.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":1611,"context_line":"                                   exception.NodeLocked,"},{"line_number":1612,"context_line":"                                   exception.InstanceHardwareIntrospectionFailure,"},{"line_number":1613,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":1614,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1615,"context_line":"    def inspect_hardware(self, context, node_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_229a8014","line":1612,"updated":"2015-02-03 13:42:57.000000000","message":"The exception added in https://review.openstack.org/#q,I103433c9e4aee7dfa3bcc049e469c812162e9ac6,n,z was HardwareInspectionFailure.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":1611,"context_line":"                                   exception.NodeLocked,"},{"line_number":1612,"context_line":"                                   exception.InstanceHardwareIntrospectionFailure,"},{"line_number":1613,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":1614,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1615,"context_line":"    def inspect_hardware(self, context, node_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_d9b42384","line":1612,"in_reply_to":"da86d52c_229a8014","updated":"2015-02-03 21:34:07.000000000","message":"Yes. will change this.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"            try:"},{"line_number":1625,"context_line":"                task.driver.power.validate(task)"},{"line_number":1626,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1627,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1628,"context_line":"                    exception.MissingParameterValue) as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_22360004","line":1625,"updated":"2015-02-03 13:42:57.000000000","message":"Do we need to validate the power driver here?","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"            try:"},{"line_number":1625,"context_line":"                task.driver.power.validate(task)"},{"line_number":1626,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1627,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1628,"context_line":"                    exception.MissingParameterValue) as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_797c17b6","line":1625,"in_reply_to":"da86d52c_22360004","updated":"2015-02-03 21:34:07.000000000","message":"Yes for ilo driver it is needed.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1627,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1628,"context_line":"                    exception.MissingParameterValue) as e:"},{"line_number":1629,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1630,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1631,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1632,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_828a4cbd","line":1629,"updated":"2015-02-03 13:42:57.000000000","message":"Ditt. exception name.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":1626,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1627,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1628,"context_line":"                    exception.MissingParameterValue) as e:"},{"line_number":1629,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1630,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1631,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1632,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_f9472775","line":1629,"in_reply_to":"da86d52c_828a4cbd","updated":"2015-02-03 21:34:07.000000000","message":"will address in next patch","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":1641,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"            except exception.InvalidState:"},{"line_number":1644,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1645,"context_line":"                    \"Inspection is not possible while node %node\""},{"line_number":1646,"context_line":"                    \"is in state %state\") % {\u0027node\u0027: node,"},{"line_number":1647,"context_line":"                                             \u0027state\u0027: node.provision_state})"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_a28590ae","line":1644,"updated":"2015-02-03 13:42:57.000000000","message":"Ditto exception name.","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":1641,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":"            except exception.InvalidState:"},{"line_number":1644,"context_line":"                raise exception.InstanceHardwareIntrospectionFailure(_("},{"line_number":1645,"context_line":"                    \"Inspection is not possible while node %node\""},{"line_number":1646,"context_line":"                    \"is in state %state\") % {\u0027node\u0027: node,"},{"line_number":1647,"context_line":"                                             \u0027state\u0027: node.provision_state})"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_5956732b","line":1644,"in_reply_to":"da86d52c_a28590ae","updated":"2015-02-03 21:34:07.000000000","message":"ditto","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b410dda14f991be4ad66ca7b50023214cd4006f1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        cfg.IntOpt(\u0027inspect_timeout\u0027,"},{"line_number":166,"context_line":"                   default\u003d450,"},{"line_number":167,"context_line":"                   help\u003d\u0027Max time allowed to be elapsed during \u0027"},{"line_number":168,"context_line":"                        \u0027node inspection.\u0027),"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"]"},{"line_number":171,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_db6693ba","line":168,"updated":"2015-02-05 12:03:06.000000000","message":"you have a different help string and default in ironic.conf.sample and I like that version much more, than this one (especially 450 maybe not too much for in-band).","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b410dda14f991be4ad66ca7b50023214cd4006f1","unresolved":false,"context_lines":[{"line_number":1646,"context_line":"                                   exception.NodeLocked,"},{"line_number":1647,"context_line":"                                   exception.HardwareInspectionFailure,"},{"line_number":1648,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":1649,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1650,"context_line":"    def inspect_hardware(self, context, node_id):"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"        LOG.debug(\u0027RPC inspect_hardware called for node %s\u0027, node_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_5b29c335","line":1649,"updated":"2015-02-05 12:03:06.000000000","message":"also UnsupportedDriverExtension","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":1654,"context_line":"            node \u003d task.node"},{"line_number":1655,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1656,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1657,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"            try:"},{"line_number":1660,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_4d1920d6","line":1657,"updated":"2015-02-04 20:51:26.000000000","message":"nit: Too much indentation","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":1654,"context_line":"            node \u003d task.node"},{"line_number":1655,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1656,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1657,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"            try:"},{"line_number":1660,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_425d6114","line":1657,"in_reply_to":"da86d52c_4d1920d6","updated":"2015-02-05 04:12:53.000000000","message":"will correct it.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b410dda14f991be4ad66ca7b50023214cd4006f1","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"            try:"},{"line_number":1671,"context_line":"                task.process_event(event,"},{"line_number":1672,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1673,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1674,"context_line":"                                              self.conductor.id),"},{"line_number":1675,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1676,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_7bcda765","line":1673,"updated":"2015-02-05 12:03:06.000000000","message":"s/inspect_hardware/task.driver.inspect.inspect_hardware/ ?","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    @periodic_task.periodic_task("},{"line_number":1685,"context_line":"            spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1686,"context_line":"    def _check_inspection_timeout(self, context):"},{"line_number":1687,"context_line":"        inspect_timeout \u003d CONF.conductor.inspect_timeout"},{"line_number":1688,"context_line":"        if not inspect_timeout:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_cd24300f","line":1685,"updated":"2015-02-04 20:51:26.000000000","message":"nit: too much indentation","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    @periodic_task.periodic_task("},{"line_number":1685,"context_line":"            spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1686,"context_line":"    def _check_inspection_timeout(self, context):"},{"line_number":1687,"context_line":"        inspect_timeout \u003d CONF.conductor.inspect_timeout"},{"line_number":1688,"context_line":"        if not inspect_timeout:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_22606dce","line":1685,"in_reply_to":"da86d52c_cd24300f","updated":"2015-02-05 04:12:53.000000000","message":"will correct it.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout,"},{"line_number":1694,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1695,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1696,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1697,"context_line":"                                    filters\u003dfilters,"},{"line_number":1698,"context_line":"                                    sort_key\u003d\u0027inspection_started_at\u0027,"},{"line_number":1699,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_0dd648f1","line":1696,"updated":"2015-02-04 20:51:26.000000000","message":"nit: too much Indentation","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"                   \u0027inspection_started_at\u0027: inspect_timeout,"},{"line_number":1694,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1695,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1696,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1697,"context_line":"                                    filters\u003dfilters,"},{"line_number":1698,"context_line":"                                    sort_key\u003d\u0027inspection_started_at\u0027,"},{"line_number":1699,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_0267e9e9","line":1696,"in_reply_to":"da86d52c_0dd648f1","updated":"2015-02-05 04:12:53.000000000","message":"will correct it.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1720,"context_line":"                continue"},{"line_number":1721,"context_line":"            workers_count +\u003d 1"},{"line_number":1722,"context_line":"            if workers_count \u003d\u003d CONF.conductor.periodic_max_workers:"},{"line_number":1723,"context_line":"                break"},{"line_number":1724,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_2d622c3e","line":1722,"updated":"2015-02-04 20:51:26.000000000","message":"Should this be defensive and be \u003e\u003d ?","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1720,"context_line":"                continue"},{"line_number":1721,"context_line":"            workers_count +\u003d 1"},{"line_number":1722,"context_line":"            if workers_count \u003d\u003d CONF.conductor.periodic_max_workers:"},{"line_number":1723,"context_line":"                break"},{"line_number":1724,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_428ba167","line":1722,"in_reply_to":"da86d52c_2d622c3e","updated":"2015-02-05 04:12:53.000000000","message":"means? please explain","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2ec31f131b08f95cb9f79d32656f2a23ffa3e8dc","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1720,"context_line":"                continue"},{"line_number":1721,"context_line":"            workers_count +\u003d 1"},{"line_number":1722,"context_line":"            if workers_count \u003d\u003d CONF.conductor.periodic_max_workers:"},{"line_number":1723,"context_line":"                break"},{"line_number":1724,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_c544fb1c","line":1722,"in_reply_to":"da86d52c_428ba167","updated":"2015-02-05 05:08:58.000000000","message":"If the code uses \u0027\u003e\u003d\u0027 then if somehow the workers_count became greater than the max it would still break.  This would be \u0027defensive programming\u0027 in that the code handles a case that it wasn\u0027t expecting to be possible.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"21e21b54e649ec1e8970dfecd6d6706c2f0a4ff1","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1720,"context_line":"                continue"},{"line_number":1721,"context_line":"            workers_count +\u003d 1"},{"line_number":1722,"context_line":"            if workers_count \u003d\u003d CONF.conductor.periodic_max_workers:"},{"line_number":1723,"context_line":"                break"},{"line_number":1724,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_11a8151f","line":1722,"in_reply_to":"da86d52c_c544fb1c","updated":"2015-02-05 08:47:01.000000000","message":"ohk. I couldnt understand statement earlier. Thanks. it makes sense.","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8342601adfe4e5f2b14e96e5097ec477091baf11","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"                    if (task.node.maintenance or"},{"line_number":1425,"context_line":"                        task.node.provision_state !\u003d states.INSPECTING):"},{"line_number":1426,"context_line":"                        continue"},{"line_number":1427,"context_line":"                # timeout has been reached - fail the inspecting"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1430,"context_line":"                                       callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_26cee12e","line":1427,"updated":"2015-02-11 11:54:45.000000000","message":"nit: comment indentation","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"882175b1d871ab37dffacd976ee24420f4f5f5be","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"                    if (task.node.maintenance or"},{"line_number":1425,"context_line":"                        task.node.provision_state !\u003d states.INSPECTING):"},{"line_number":1426,"context_line":"                        continue"},{"line_number":1427,"context_line":"                # timeout has been reached - fail the inspecting"},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1430,"context_line":"                                       callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_c9c19630","line":1427,"in_reply_to":"da86d52c_26cee12e","updated":"2015-02-11 12:20:07.000000000","message":"ok.","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8342601adfe4e5f2b14e96e5097ec477091baf11","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"            handle_failure(e, task,"},{"line_number":1762,"context_line":"                _LW(\u0027Error in Hardware Inspection for node %(node)s: %(err)s\u0027),"},{"line_number":1763,"context_line":"                _(\"Failed to Introspect.Error: %s\"))"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1766,"context_line":"        if new_state \u003d\u003d states.INSPECTED:"},{"line_number":1767,"context_line":"            task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_46e675b1","line":1764,"updated":"2015-02-11 11:54:45.000000000","message":"code below is unreachable, as it\u0027s in `except` block and exception will be reraised by excutils.save_and_reraise_exception","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"97a8ca5ab266666be1ba6d3417aa629afc9d1dca","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"            handle_failure(e, task,"},{"line_number":1762,"context_line":"                _LW(\u0027Error in Hardware Inspection for node %(node)s: %(err)s\u0027),"},{"line_number":1763,"context_line":"                _(\"Failed to Introspect.Error: %s\"))"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1766,"context_line":"        if new_state \u003d\u003d states.INSPECTED:"},{"line_number":1767,"context_line":"            task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_690fca88","line":1764,"in_reply_to":"da86d52c_46e675b1","updated":"2015-02-11 12:25:29.000000000","message":"ohk. thanks for pointing it out.","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8342601adfe4e5f2b14e96e5097ec477091baf11","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"            LOG.info(_LI(\u0027Successfully Inspected node %(node)s \u0027),"},{"line_number":1769,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1770,"context_line":"        else:"},{"line_number":1771,"context_line":"            LOG.error(_LE(\u0027Unexpected state %(state)s returned while \u0027"},{"line_number":1772,"context_line":"                          \u0027inspecting node %(node)s.\u0027),"},{"line_number":1773,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1774,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_269c210f","line":1771,"updated":"2015-02-11 11:54:45.000000000","message":"INSPECTING is also a valid state to be returned, if in-band inspection is still in progress","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"97a8ca5ab266666be1ba6d3417aa629afc9d1dca","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"            LOG.info(_LI(\u0027Successfully Inspected node %(node)s \u0027),"},{"line_number":1769,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1770,"context_line":"        else:"},{"line_number":1771,"context_line":"            LOG.error(_LE(\u0027Unexpected state %(state)s returned while \u0027"},{"line_number":1772,"context_line":"                          \u0027inspecting node %(node)s.\u0027),"},{"line_number":1773,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1774,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_c9743600","line":1771,"in_reply_to":"da86d52c_269c210f","updated":"2015-02-11 12:25:29.000000000","message":"ok. Will add a check for it. But then do we expect any action on INSPECTING state when returned? WIth INSPECTED, we move it to MANAGEABLE using done. But how do we handle INSPECTING then?","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6cb1e40960c9121579ae669334fd1315d69fd7fc","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"            LOG.info(_LI(\u0027Successfully Inspected node %(node)s \u0027),"},{"line_number":1769,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1770,"context_line":"        else:"},{"line_number":1771,"context_line":"            LOG.error(_LE(\u0027Unexpected state %(state)s returned while \u0027"},{"line_number":1772,"context_line":"                          \u0027inspecting node %(node)s.\u0027),"},{"line_number":1773,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1774,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_296a32ee","line":1771,"in_reply_to":"da86d52c_c9743600","updated":"2015-02-11 12:30:18.000000000","message":"Ignore it. It\u0027s only for discoverd driver, and there will be a separate (async) code path for finishing it.","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9d3bf2c75e75a09708de7785f5f81fe41c9ee90d","unresolved":false,"context_lines":[{"line_number":1372,"context_line":"            node \u003d task.node"},{"line_number":1373,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1374,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1375,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"            try:"},{"line_number":1378,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_4a0e4f8d","line":1375,"updated":"2015-02-12 05:08:18.000000000","message":"nit: indentation","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"779ead1484a86d8bcb890e77bba0e4cb918d11dc","unresolved":false,"context_lines":[{"line_number":1372,"context_line":"            node \u003d task.node"},{"line_number":1373,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1374,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1375,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"            try:"},{"line_number":1378,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_4008eb27","line":1375,"in_reply_to":"da86d52c_4a0e4f8d","updated":"2015-02-12 09:22:16.000000000","message":"ok","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9d3bf2c75e75a09708de7785f5f81fe41c9ee90d","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1412,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1413,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1414,"context_line":"                                    filters\u003dfilters,"},{"line_number":1415,"context_line":"                                    sort_key\u003d\u0027inspection_started_at\u0027,"},{"line_number":1416,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"},{"line_number":1417,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_6a2873e2","line":1414,"updated":"2015-02-12 05:08:18.000000000","message":"nit: indentation","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"779ead1484a86d8bcb890e77bba0e4cb918d11dc","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1412,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1413,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1414,"context_line":"                                    filters\u003dfilters,"},{"line_number":1415,"context_line":"                                    sort_key\u003d\u0027inspection_started_at\u0027,"},{"line_number":1416,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"},{"line_number":1417,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_6d14084d","line":1414,"in_reply_to":"da86d52c_6a2873e2","updated":"2015-02-12 09:22:16.000000000","message":"this is below the brackets or rather brackets data was going beyond 79 characters. hence i dont see need to change it.","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"19aa2162444711ac182d0ef2dc220eb469415111","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"            try:"},{"line_number":1389,"context_line":"                task.process_event(event,"},{"line_number":1390,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1391,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1392,"context_line":"                                              self.conductor.id),"},{"line_number":1393,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1394,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_57ecef29","line":1391,"updated":"2015-02-13 14:51:18.000000000","message":"Though this works as expected, I find it confusing that the class and the module both have a method with the name \"inspect_hardware\", I\u0027d prefer if the module-level method was at least called \"_inspect_hardware\" (note the _ prefix).\n\nMaybe it\u0027s best for the module-level method to be in the class, to be consistent with other things like do_node_deploy.","commit_id":"98d8f8122e0aeb69b6d7879814380b01242f167b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4e611fa80236ba9b758852d9e5b90c59e35abb01","unresolved":false,"context_lines":[{"line_number":1388,"context_line":"            try:"},{"line_number":1389,"context_line":"                task.process_event(event,"},{"line_number":1390,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1391,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1392,"context_line":"                                              self.conductor.id),"},{"line_number":1393,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1394,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_221f125d","line":1391,"in_reply_to":"da86d52c_57ecef29","updated":"2015-02-15 16:58:44.000000000","message":"Initially it was _inspect_hardware() but all other methods like do_node_deploy etc also have been changed the same way.","commit_id":"98d8f8122e0aeb69b6d7879814380b01242f167b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e832e40a60fe45719026178a56f286a5ee29a76e","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1768,"context_line":"        task.process_event(\u0027inspect\u0027)"},{"line_number":1769,"context_line":"        task.node.save()"},{"line_number":1770,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":1771,"context_line":"        LOG.info(_LI(\u0027Successfully Inspected node %(node)s \u0027),"},{"line_number":1772,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1773,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_b871a5e0","line":1770,"updated":"2015-02-13 10:57:49.000000000","message":"inspection is not necessary done at this point. previously you had a check on return value from inspect_hardware, it makes sense to bring it back and only advance state machine if it\u0027s INSPECTED (or None)","commit_id":"98d8f8122e0aeb69b6d7879814380b01242f167b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"163b88fccfc9df2f42b32494413b3b5834e5d9e5","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1768,"context_line":"        task.process_event(\u0027inspect\u0027)"},{"line_number":1769,"context_line":"        task.node.save()"},{"line_number":1770,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":1771,"context_line":"        LOG.info(_LI(\u0027Successfully Inspected node %(node)s \u0027),"},{"line_number":1772,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1773,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_41d18d2e","line":1770,"in_reply_to":"da86d52c_b871a5e0","updated":"2015-02-13 14:18:37.000000000","message":"It will come here only when inspect is done , correct? \nIn-band discovery can come here even if it is not inspected successfully? \nFor OOB it is reached only in case it is successful.","commit_id":"98d8f8122e0aeb69b6d7879814380b01242f167b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b56cfe0f15b02b322e4cf7b832ef5df394011de5","unresolved":false,"context_lines":[{"line_number":1407,"context_line":""},{"line_number":1408,"context_line":"    @periodic_task.periodic_task("},{"line_number":1409,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1410,"context_line":"    def _check_inspect_timeouts(self, context):"},{"line_number":1411,"context_line":"        callback_timeout \u003d CONF.conductor.inspect_timeout"},{"line_number":1412,"context_line":"        if not callback_timeout:"},{"line_number":1413,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba7be1f8_b71c5215","line":1410,"updated":"2015-02-20 00:42:07.000000000","message":"this is almost line for line the same as _check_deploy_timeouts would be good to see if we could reduce the need to duplicate the code like this. Maybe make a common function both could use?","commit_id":"17e330f2f3511f8c9806305f777c949ce852d334"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e9c21fe71a8409dc0b76bde7c83515e2000c5449","unresolved":false,"context_lines":[{"line_number":1407,"context_line":""},{"line_number":1408,"context_line":"    @periodic_task.periodic_task("},{"line_number":1409,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1410,"context_line":"    def _check_inspect_timeouts(self, context):"},{"line_number":1411,"context_line":"        callback_timeout \u003d CONF.conductor.inspect_timeout"},{"line_number":1412,"context_line":"        if not callback_timeout:"},{"line_number":1413,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba7be1f8_32822d53","line":1410,"in_reply_to":"ba7be1f8_b71c5215","updated":"2015-02-20 03:22:12.000000000","message":"ok. i will do this and post a new patch.","commit_id":"17e330f2f3511f8c9806305f777c949ce852d334"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9fd43660eda7bb856be6bdb983830fcdceaf304d","unresolved":false,"context_lines":[{"line_number":1778,"context_line":"            LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1779,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1780,"context_line":"        elif new_state !\u003d states.INSPECTING:"},{"line_number":1781,"context_line":"            handle_failure(\"Unexpected state\", task,"},{"line_number":1782,"context_line":"                _LW(\"Error in Hardware Inspection for node \""},{"line_number":1783,"context_line":"                    \"%(node)s: %(err)s\"),"},{"line_number":1784,"context_line":"                _(\"Failed to Introspect.Error: %s\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba7be1f8_f4579d24","line":1781,"updated":"2015-02-20 08:40:45.000000000","message":"it\u0027s not a failure","commit_id":"17e330f2f3511f8c9806305f777c949ce852d334"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"157a60a5835d167a91b87ea485d8a0ac7df81b9a","unresolved":false,"context_lines":[{"line_number":1778,"context_line":"            LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1779,"context_line":"                     {\u0027node\u0027: node.uuid})"},{"line_number":1780,"context_line":"        elif new_state !\u003d states.INSPECTING:"},{"line_number":1781,"context_line":"            handle_failure(\"Unexpected state\", task,"},{"line_number":1782,"context_line":"                _LW(\"Error in Hardware Inspection for node \""},{"line_number":1783,"context_line":"                    \"%(node)s: %(err)s\"),"},{"line_number":1784,"context_line":"                _(\"Failed to Introspect.Error: %s\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba7be1f8_34185584","line":1781,"in_reply_to":"ba7be1f8_f4579d24","updated":"2015-02-20 08:42:51.000000000","message":"oh, it is, I didn\u0027t notice !\u003d states.INSPECTING","commit_id":"17e330f2f3511f8c9806305f777c949ce852d334"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_893ba7ea","line":1735,"updated":"2015-02-20 12:22:23.000000000","message":"actually logmsg and errmsg are the same for both cases, you can hardcode them here. I would even say you don\u0027t need this function, but as you wish :)","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4d606320442d9964bb092d01ddb62e7f62bc4088","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_0e5ec845","line":1735,"in_reply_to":"ba7be1f8_0bceba83","updated":"2015-02-20 19:50:49.000000000","message":"Now i understood your point.\n\nThe logmsg and errmsg are different.\n\nThe logmsg being sent is \"\"Error in Hardware Inspection for node \"\n                    \"%(node)s: %(err)s\"\"\nthe errmsg is \"Failed to Inspect.Error: %s\"","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3643b97e0689816d71ad012fe715cec1af716d10","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_e1aa65d3","line":1735,"in_reply_to":"ba7be1f8_0e5ec845","updated":"2015-02-20 19:57:17.000000000","message":"logmsg in first case (line #1749) is \"Error in Hardware Inspection for node %(node)s: %(err)s\"\n\nin the second case (line #1762) it\u0027s \"Error in Hardware Inspection for node %(node)s: %(err)s\"\n\nlooks the same to me :) the same with errmsg","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_cd0afdd1","line":1735,"in_reply_to":"ba7be1f8_893ba7ea","updated":"2015-02-20 17:24:02.000000000","message":"It is not same completely. I will like to keep this function.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"307162a8c6c9ccea4dbee0afe96c425c6a8c12cf","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_0bceba83","line":1735,"in_reply_to":"ba7be1f8_b988a723","updated":"2015-02-20 19:15:43.000000000","message":"Oh i think you talking about the second invocation of this function. I thought you are talking about the messages on the invocation of this function at both the places. Oh yes you are right its same. Even though its friday evening you have spotted correctly ;)\n\nI kept the function just because it do save also.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e578c2915c54a81040f52339c64404028006ab85","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_b988a723","line":1735,"in_reply_to":"ba7be1f8_cd0afdd1","updated":"2015-02-20 18:44:26.000000000","message":"hmm... I\u0027m ok with keeping the function, but I can\u0027t spot the difference between 2 cases in logmsg and errmsg. Maybe it\u0027s Friday evening, but could you have one more look?","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1739,"context_line":"        LOG.warning(logmsg, args)"},{"line_number":1740,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_4918cf84","line":1739,"updated":"2015-02-20 12:22:23.000000000","message":"s/warning/error/","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1739,"context_line":"        LOG.warning(logmsg, args)"},{"line_number":1740,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_cd659d46","line":1739,"in_reply_to":"ba7be1f8_4918cf84","updated":"2015-02-20 17:24:02.000000000","message":"Ok.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1739,"context_line":"        LOG.warning(logmsg, args)"},{"line_number":1740,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"},{"line_number":1743,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_a9bb0b71","line":1740,"updated":"2015-02-20 12:22:23.000000000","message":"node.save() should go here","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"307162a8c6c9ccea4dbee0afe96c425c6a8c12cf","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1739,"context_line":"        LOG.warning(logmsg, args)"},{"line_number":1740,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"},{"line_number":1743,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_4bad1288","line":1740,"in_reply_to":"ba7be1f8_0d2c1547","updated":"2015-02-20 19:15:43.000000000","message":"As process_event will save the node also, i will see if i can do this before calling process_event(\u0027fail\u0027)","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1738,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1739,"context_line":"        LOG.warning(logmsg, args)"},{"line_number":1740,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"},{"line_number":1743,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_0d2c1547","line":1740,"in_reply_to":"ba7be1f8_a9bb0b71","updated":"2015-02-20 17:24:02.000000000","message":"node.save is done as the final step under \u0027finally:\u0027. So it is called after the failure also.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"        except Exception as e:"},{"line_number":1747,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1748,"context_line":"                handle_failure(e, task,"},{"line_number":1749,"context_line":"                    _LW(\"Error in Hardware Inspection for node \""},{"line_number":1750,"context_line":"                        \"%(node)s: %(err)s\"),"},{"line_number":1751,"context_line":"                    _(\"Failed to Introspect.Error: %s\"))"},{"line_number":1752,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_694f5393","line":1749,"updated":"2015-02-20 12:22:23.000000000","message":"nit: lower case hardware inspection","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"        except Exception as e:"},{"line_number":1747,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1748,"context_line":"                handle_failure(e, task,"},{"line_number":1749,"context_line":"                    _LW(\"Error in Hardware Inspection for node \""},{"line_number":1750,"context_line":"                        \"%(node)s: %(err)s\"),"},{"line_number":1751,"context_line":"                    _(\"Failed to Introspect.Error: %s\"))"},{"line_number":1752,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_2d3f1927","line":1749,"in_reply_to":"ba7be1f8_694f5393","updated":"2015-02-20 17:24:02.000000000","message":"ok","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"                handle_failure(e, task,"},{"line_number":1749,"context_line":"                    _LW(\"Error in Hardware Inspection for node \""},{"line_number":1750,"context_line":"                        \"%(node)s: %(err)s\"),"},{"line_number":1751,"context_line":"                    _(\"Failed to Introspect.Error: %s\"))"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1754,"context_line":"        # since there may be local persistent state"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_696833f6","line":1751,"updated":"2015-02-20 12:22:23.000000000","message":"nit: \"Failed to inspect hardware: %s\"","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"                handle_failure(e, task,"},{"line_number":1749,"context_line":"                    _LW(\"Error in Hardware Inspection for node \""},{"line_number":1750,"context_line":"                        \"%(node)s: %(err)s\"),"},{"line_number":1751,"context_line":"                    _(\"Failed to Introspect.Error: %s\"))"},{"line_number":1752,"context_line":""},{"line_number":1753,"context_line":"        # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1754,"context_line":"        # since there may be local persistent state"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_cd175da2","line":1751,"in_reply_to":"ba7be1f8_696833f6","updated":"2015-02-20 17:24:02.000000000","message":":) ok. Thanks.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"        # since there may be local persistent state"},{"line_number":1755,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1758,"context_line":"            task.process_event(\u0027done\u0027)"},{"line_number":1759,"context_line":"            LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1760,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_899f2703","line":1757,"updated":"2015-02-20 12:22:23.000000000","message":"judging by inspect_hardware None is allowed as synonym to states.MANAGEABLE:\n\n if not new_state or new_state \u003d\u003d states.MANAGEABLE:","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e578c2915c54a81040f52339c64404028006ab85","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"        # since there may be local persistent state"},{"line_number":1755,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1758,"context_line":"            task.process_event(\u0027done\u0027)"},{"line_number":1759,"context_line":"            LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1760,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_b9dd0717","line":1757,"in_reply_to":"ba7be1f8_0db6d5d9","updated":"2015-02-20 18:44:26.000000000","message":"I\u0027m fine with both of these, do as you wish :)","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"        # since there may be local persistent state"},{"line_number":1755,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1758,"context_line":"            task.process_event(\u0027done\u0027)"},{"line_number":1759,"context_line":"            LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1760,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_0db6d5d9","line":1757,"in_reply_to":"ba7be1f8_899f2703","updated":"2015-02-20 17:24:02.000000000","message":"Is it OK to consider None for \u0027successful\u0027 case? that said we allow the driver to return nothing also in successful case. I think better to remove \u0027None\u0027 from InspectInterface inspect_hardware() for the successful case.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"307162a8c6c9ccea4dbee0afe96c425c6a8c12cf","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"        # since there may be local persistent state"},{"line_number":1755,"context_line":"        node.conductor_affinity \u003d conductor_id"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1758,"context_line":"            task.process_event(\u0027done\u0027)"},{"line_number":1759,"context_line":"            LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1760,"context_line":"                     {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_8be9ca1c","line":1757,"in_reply_to":"ba7be1f8_b9dd0717","updated":"2015-02-20 19:15:43.000000000","message":"Ok. I will remov ethe None as the return value and will add INSPECTING as valid return value for inband.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"    finally:"},{"line_number":1771,"context_line":"        task.node.save()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_2990fbeb","line":1771,"updated":"2015-02-20 12:22:23.000000000","message":"you don\u0027t seem to modify task.node other than on line #1740","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e578c2915c54a81040f52339c64404028006ab85","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"    finally:"},{"line_number":1771,"context_line":"        task.node.save()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_79c46f40","line":1771,"in_reply_to":"ba7be1f8_0d04157a","updated":"2015-02-20 18:44:26.000000000","message":"yeah, and it does save() too so you don\u0027t need it","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"    finally:"},{"line_number":1771,"context_line":"        task.node.save()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_0d04157a","line":1771,"in_reply_to":"ba7be1f8_2990fbeb","updated":"2015-02-20 17:24:02.000000000","message":"The process_event(done) will update the target_provision_state and provision_state of the node. That will need the save, correct?","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"307162a8c6c9ccea4dbee0afe96c425c6a8c12cf","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                          {\u0027state\u0027: new_state, \u0027node\u0027: node.uuid})"},{"line_number":1769,"context_line":""},{"line_number":1770,"context_line":"    finally:"},{"line_number":1771,"context_line":"        task.node.save()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_eb1406f7","line":1771,"in_reply_to":"ba7be1f8_79c46f40","updated":"2015-02-20 19:15:43.000000000","message":"ok. I will test and update accordingly.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3247eae13363f1a892878ab58829159086dffa5c","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                    if (task.node.maintenance or"},{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"},{"line_number":1415,"context_line":"                    # timeout has been reached - fail the inspecting"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_26caaf6e","line":1415,"updated":"2015-02-23 10:11:21.000000000","message":"s/the inspecting// as it\u0027s not only for inspecting\n\nI think you can well delete this comment, it should be pretty obvious","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5b00d073e65bdb872a757016983feb29d6d1ee46","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                    if (task.node.maintenance or"},{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"},{"line_number":1415,"context_line":"                    # timeout has been reached - fail the inspecting"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_6b59cbfd","line":1415,"in_reply_to":"ba7be1f8_26caaf6e","updated":"2015-02-23 16:26:16.000000000","message":"ok","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3247eae13363f1a892878ab58829159086dffa5c","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1738,"context_line":"        node.last_error \u003d errmsg % e"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_46a0839f","line":1735,"updated":"2015-02-23 10:11:21.000000000","message":"nit: you don\u0027t need to pass \u0027task\u0027 here, it\u0027s present on upper level\n\nnit2: logmsg and errmsg are still the same for both use cases, no need to pass them in\n\nso this function should be\n\n def handle_failure(e):","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5b00d073e65bdb872a757016983feb29d6d1ee46","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1738,"context_line":"        node.last_error \u003d errmsg % e"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_8bafdf93","line":1735,"in_reply_to":"ba7be1f8_46a0839f","updated":"2015-02-23 16:26:16.000000000","message":"ok. will see if it gives same result.","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3247eae13363f1a892878ab58829159086dffa5c","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1738,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1739,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1740,"context_line":"        LOG.error(logmsg, args)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_c6839302","line":1737,"updated":"2015-02-23 10:11:21.000000000","message":"nit: s/task.//","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5b00d073e65bdb872a757016983feb29d6d1ee46","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e, task, logmsg, errmsg):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e}"},{"line_number":1738,"context_line":"        node.last_error \u003d errmsg % e"},{"line_number":1739,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1740,"context_line":"        LOG.error(logmsg, args)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_cb90f750","line":1737,"in_reply_to":"ba7be1f8_c6839302","updated":"2015-02-23 16:26:16.000000000","message":"k","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3247eae13363f1a892878ab58829159086dffa5c","unresolved":false,"context_lines":[{"line_number":1747,"context_line":"            handle_failure(e, task,"},{"line_number":1748,"context_line":"                _LE(\"Error in hardware inspection for node \""},{"line_number":1749,"context_line":"                    \"%(node)s: %(err)s\"),"},{"line_number":1750,"context_line":"                _(\"Failed to inspect.Error: %s\"))"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1753,"context_line":"    # since there may be local persistent state"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_a6ba1fbe","line":1750,"updated":"2015-02-23 10:11:21.000000000","message":"nit: spaced needed after dot (also please move it inside handle_failure)","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5b00d073e65bdb872a757016983feb29d6d1ee46","unresolved":false,"context_lines":[{"line_number":1747,"context_line":"            handle_failure(e, task,"},{"line_number":1748,"context_line":"                _LE(\"Error in hardware inspection for node \""},{"line_number":1749,"context_line":"                    \"%(node)s: %(err)s\"),"},{"line_number":1750,"context_line":"                _(\"Failed to inspect.Error: %s\"))"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1753,"context_line":"    # since there may be local persistent state"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_0b9bef72","line":1750,"in_reply_to":"ba7be1f8_a6ba1fbe","updated":"2015-02-23 16:26:16.000000000","message":"ok","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3247eae13363f1a892878ab58829159086dffa5c","unresolved":false,"context_lines":[{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1753,"context_line":"    # since there may be local persistent state"},{"line_number":1754,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1755,"context_line":""},{"line_number":1756,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1757,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_a693ff4d","line":1754,"updated":"2015-02-23 10:11:21.000000000","message":"not sure if we need it here. I\u0027ll let the others judge...","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5b00d073e65bdb872a757016983feb29d6d1ee46","unresolved":false,"context_lines":[{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1753,"context_line":"    # since there may be local persistent state"},{"line_number":1754,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1755,"context_line":""},{"line_number":1756,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1757,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_6b9aab64","line":1754,"in_reply_to":"ba7be1f8_a693ff4d","updated":"2015-02-23 16:26:16.000000000","message":"Ok.","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56b3018b780b398f2923a34b46eeab3d121bff69","unresolved":false,"context_lines":[{"line_number":1758,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1759,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":1760,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1761,"context_line":"        handle_failure(\"Unexpected state\", task,"},{"line_number":1762,"context_line":"            _LE(\"Error in hardware inspection for node \""},{"line_number":1763,"context_line":"                \"%(node)s: %(err)s\"),"},{"line_number":1764,"context_line":"            _(\"Failed to inspect.Error: %s\"))"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_ff064e1f","line":1761,"updated":"2015-02-23 16:35:02.000000000","message":"this error message should be expanded, I found it pretty confusing during testing and thought it\u0027s related to state machine","commit_id":"cddf05c033f0c942f4638ee65036b17f339f52de"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9564c03866f0257118feb7f81bde0262a61d5e34","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        args \u003d {\u0027node\u0027: task.node.uuid}"},{"line_number":1738,"context_line":"        node.last_error \u003d e"},{"line_number":1739,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1740,"context_line":"        LOG.error(errmsg, args)"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"},{"line_number":1743,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba7be1f8_7d45066f","line":1740,"updated":"2015-02-23 17:18:16.000000000","message":"should be:\n\n LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"), {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e})","commit_id":"a6a34f28e36219de6c7cd3b880d0d1865a841202"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"af5726213d4ceb8052f7590922734859c4189c84","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e})"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"},{"line_number":1743,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_8256ab28","line":1740,"updated":"2015-02-24 15:58:53.000000000","message":"nit: task. not needed for node.uuid here.","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"99d9d2714a5fe2d9dd80a0a5b55aaac124198560","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: task.node.uuid, \u0027err\u0027: e})"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    try:"},{"line_number":1743,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_2d116b5d","line":1740,"in_reply_to":"ba7be1f8_8256ab28","updated":"2015-02-24 17:51:37.000000000","message":"done","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"413a3cc25ede059ce73248b2df509e38099c9b7f","unresolved":false,"context_lines":[{"line_number":1756,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":1757,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1758,"context_line":"        handle_failure(\"Driver returned unexpected state \""},{"line_number":1759,"context_line":"                       \"%s\" % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_19c5de8d","line":1759,"updated":"2015-02-24 10:25:56.000000000","message":"Wrong string interpolation here: either\n\n \"%s\" % new_state)\n\nor \n\n \"%(state)s\" % {\u0027state\u0027: new_state})","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"383ca0174ce983f4509d2394fd67a0665315f68b","unresolved":false,"context_lines":[{"line_number":1756,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":1757,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1758,"context_line":"        handle_failure(\"Driver returned unexpected state \""},{"line_number":1759,"context_line":"                       \"%s\" % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_ea482a89","line":1759,"in_reply_to":"ba7be1f8_19c5de8d","updated":"2015-02-24 11:54:32.000000000","message":"oh yes. i will correct and post the patch","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                                   exception.NodeLocked,"},{"line_number":1333,"context_line":"                                   exception.HardwareInspectionFailure,"},{"line_number":1334,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":1335,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":1336,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1337,"context_line":"    def inspect_hardware(self, context, node_id):"},{"line_number":1338,"context_line":"        \"\"\"Inspect hardware to obtain hardware properties."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_ada374fe","line":1335,"updated":"2015-02-25 13:31:46.000000000","message":"I think we don\u0027t raise either of exception.InvalidParameterValue or exception.MissingParameterValue from this method.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                                   exception.NodeLocked,"},{"line_number":1333,"context_line":"                                   exception.HardwareInspectionFailure,"},{"line_number":1334,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":1335,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":1336,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1337,"context_line":"    def inspect_hardware(self, context, node_id):"},{"line_number":1338,"context_line":"        \"\"\"Inspect hardware to obtain hardware properties."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_f0cc34bd","line":1335,"in_reply_to":"ba7be1f8_661439a0","updated":"2015-02-26 10:45:37.000000000","message":"done.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1332,"context_line":"                                   exception.NodeLocked,"},{"line_number":1333,"context_line":"                                   exception.HardwareInspectionFailure,"},{"line_number":1334,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":1335,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":1336,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1337,"context_line":"    def inspect_hardware(self, context, node_id):"},{"line_number":1338,"context_line":"        \"\"\"Inspect hardware to obtain hardware properties."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_661439a0","line":1335,"in_reply_to":"ba7be1f8_ada374fe","updated":"2015-02-25 14:27:14.000000000","message":"It is done as part of validate as i understand. Even iLO drivers return these errors as part of validation failure.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1337,"context_line":"    def inspect_hardware(self, context, node_id):"},{"line_number":1338,"context_line":"        \"\"\"Inspect hardware to obtain hardware properties."},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"        :param context: request context."},{"line_number":1341,"context_line":"        :param node_id: node id or uuid."},{"line_number":1342,"context_line":"        :raises: NodeLocked if node is locked by another conductor."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_6676e007","line":1339,"updated":"2015-02-25 23:07:08.000000000","message":"This is an async call right? Would be nice to add that to the docstring. (See eg vendor_passthru() or change_node_power_state())","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":1337,"context_line":"    def inspect_hardware(self, context, node_id):"},{"line_number":1338,"context_line":"        \"\"\"Inspect hardware to obtain hardware properties."},{"line_number":1339,"context_line":""},{"line_number":1340,"context_line":"        :param context: request context."},{"line_number":1341,"context_line":"        :param node_id: node id or uuid."},{"line_number":1342,"context_line":"        :raises: NodeLocked if node is locked by another conductor."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_d0c9f0ac","line":1339,"in_reply_to":"ba7be1f8_6676e007","updated":"2015-02-26 10:45:37.000000000","message":"done","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"            node \u003d task.node"},{"line_number":1355,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1356,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1357,"context_line":"                      river\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"            try:"},{"line_number":1360,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_8d895077","line":1357,"updated":"2015-02-25 13:31:46.000000000","message":"typo: driver","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87c823c700a1da552ccaecaeaa5cea67e67c4bd7","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"            node \u003d task.node"},{"line_number":1355,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1356,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1357,"context_line":"                      river\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"            try:"},{"line_number":1360,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_816597b6","line":1357,"in_reply_to":"ba7be1f8_8d895077","updated":"2015-02-25 14:20:14.000000000","message":"+1","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"            node \u003d task.node"},{"line_number":1355,"context_line":"            if not getattr(task.driver, \u0027inspect\u0027, None):"},{"line_number":1356,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1357,"context_line":"                      river\u003dtask.node.driver, extension\u003d\u0027inspect\u0027)"},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"            try:"},{"line_number":1360,"context_line":"                task.driver.power.validate(task)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_461bb5c9","line":1357,"in_reply_to":"ba7be1f8_8d895077","updated":"2015-02-25 14:27:14.000000000","message":"Thanks","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1362,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1363,"context_line":"                    exception.MissingParameterValue) as e:"},{"line_number":1364,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1365,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1366,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_8d65d0b6","line":1364,"updated":"2015-02-25 13:31:46.000000000","message":"exception.HardwareInspectionFailure(error\u003d\u003c\u003e).\n\nI guess the text \"RPC inspect_hardware failed to validate inspection or\" is redundant.\n\nThe below should be enough:\n  exception.HardwareInspectionFailure(error\u003de).","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1362,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1363,"context_line":"                    exception.MissingParameterValue) as e:"},{"line_number":1364,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1365,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1366,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_50bd0001","line":1364,"in_reply_to":"ba7be1f8_46e01596","updated":"2015-02-26 10:45:37.000000000","message":"done","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"                task.driver.inspect.validate(task)"},{"line_number":1362,"context_line":"            except (exception.InvalidParameterValue,"},{"line_number":1363,"context_line":"                    exception.MissingParameterValue) as e:"},{"line_number":1364,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1365,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1366,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1367,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_46e01596","line":1364,"in_reply_to":"ba7be1f8_8d65d0b6","updated":"2015-02-25 14:27:14.000000000","message":"This is to tell that inspection is not yet started. it has failed at the step of validation itself.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1366,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"            event \u003d \u0027inspect\u0027"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_ad0d34ea","line":1368,"updated":"2015-02-25 13:31:46.000000000","message":"nit: could be put inline.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1365,"context_line":"                    \"RPC inspect_hardware failed to validate inspection or \""},{"line_number":1366,"context_line":"                    \"power info. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"            event \u003d \u0027inspect\u0027"},{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_a69d510c","line":1368,"in_reply_to":"ba7be1f8_ad0d34ea","updated":"2015-02-25 14:27:14.000000000","message":"yeah but doesnt harm. anyway will put it inline.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"},{"line_number":1372,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1373,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1374,"context_line":"                                              self.conductor.id),"},{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_4decb8f3","line":1373,"updated":"2015-02-25 13:31:46.000000000","message":"Can we just rename this, there are two inspect_hardware here which seems confusing to me.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"},{"line_number":1372,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1373,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1374,"context_line":"                                              self.conductor.id),"},{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_467abc24","line":1373,"in_reply_to":"ba7be1f8_41463f50","updated":"2015-02-25 23:07:08.000000000","message":"Nisha, it is true that there are other methods with similar names so I understand why you did the same. That doesn\u0027t mean that they aren\u0027t confusing. It just means they got approved by people that may not have found them confusing. I would also vote to change the name. How about \u0027do_inspect_hardware\u0027 for the other one since that one seems to do stuff more related to inspecting hardware than this one does ;)\n\nThis is why it makes me sad that we shouldn\u0027t nit, because these things set a precedence for future things to be consistent with what I didn\u0027t like in the first place :-(","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"},{"line_number":1372,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1373,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1374,"context_line":"                                              self.conductor.id),"},{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_903a1897","line":1373,"in_reply_to":"ba7be1f8_467abc24","updated":"2015-02-26 10:45:37.000000000","message":"ok i have changed the async function name to _do_inspect_hardware()","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87c823c700a1da552ccaecaeaa5cea67e67c4bd7","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"},{"line_number":1372,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1373,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1374,"context_line":"                                              self.conductor.id),"},{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_465015d4","line":1373,"in_reply_to":"ba7be1f8_4decb8f3","updated":"2015-02-25 14:20:14.000000000","message":"+1","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"            try:"},{"line_number":1371,"context_line":"                task.process_event(event,"},{"line_number":1372,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":1373,"context_line":"                                   call_args\u003d(inspect_hardware, task,"},{"line_number":1374,"context_line":"                                              self.conductor.id),"},{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_41463f50","line":1373,"in_reply_to":"ba7be1f8_4decb8f3","updated":"2015-02-25 14:27:14.000000000","message":"initially it was different name and the same name was used as part of review comments. Infact even deploy, teardown and other functions also share the same name and it was done as part of a commit id.\nhttps://github.com/openstack/ironic/commit/13aee6165a21751105aa87dc6e6aecb4cb89b0e6","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"            except exception.InvalidState:"},{"line_number":1378,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1379,"context_line":"                    \"Inspection is not possible while node %(node)s\""},{"line_number":1380,"context_line":"                    \"is in state %(state)s\")"},{"line_number":1381,"context_line":"                    % {\u0027node\u0027: node, \u0027state\u0027: node.provision_state})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_ad80d4f7","line":1378,"updated":"2015-02-25 13:31:46.000000000","message":"exception.HardwareInspectionFailure(error\u003d\u003c\u003e)","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"            except exception.InvalidState:"},{"line_number":1378,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1379,"context_line":"                    \"Inspection is not possible while node %(node)s\""},{"line_number":1380,"context_line":"                    \"is in state %(state)s\")"},{"line_number":1381,"context_line":"                    % {\u0027node\u0027: node, \u0027state\u0027: node.provision_state})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_c1a86fdd","line":1378,"in_reply_to":"ba7be1f8_ad80d4f7","updated":"2015-02-25 14:27:14.000000000","message":"These are helper messages to know at which step did inspection failed and i think it should be kept along with Exception message.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"            except exception.InvalidState:"},{"line_number":1378,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1379,"context_line":"                    \"Inspection is not possible while node %(node)s\""},{"line_number":1380,"context_line":"                    \"is in state %(state)s\")"},{"line_number":1381,"context_line":"                    % {\u0027node\u0027: node, \u0027state\u0027: node.provision_state})"},{"line_number":1382,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_c60a2c89","line":1379,"updated":"2015-02-25 23:07:08.000000000","message":"need a space at the end here, or it\u0027ll look like \u0027... node \u003cuuid\u003eis in...\u0027","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"94a2c8099c5b86da1475ff0585f2610323762060","unresolved":false,"context_lines":[{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"            except exception.InvalidState:"},{"line_number":1378,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1379,"context_line":"                    \"Inspection is not possible while node %(node)s\""},{"line_number":1380,"context_line":"                    \"is in state %(state)s\")"},{"line_number":1381,"context_line":"                    % {\u0027node\u0027: node, \u0027state\u0027: node.provision_state})"},{"line_number":1382,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_5f089627","line":1379,"in_reply_to":"ba7be1f8_c60a2c89","updated":"2015-02-26 20:27:38.000000000","message":"done.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1378,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1379,"context_line":"                    \"Inspection is not possible while node %(node)s\""},{"line_number":1380,"context_line":"                    \"is in state %(state)s\")"},{"line_number":1381,"context_line":"                    % {\u0027node\u0027: node, \u0027state\u0027: node.provision_state})"},{"line_number":1382,"context_line":""},{"line_number":1383,"context_line":"    @periodic_task.periodic_task("},{"line_number":1384,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_8d3310aa","line":1381,"updated":"2015-02-25 13:31:46.000000000","message":"node.uuid","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1378,"context_line":"                raise exception.HardwareInspectionFailure(_("},{"line_number":1379,"context_line":"                    \"Inspection is not possible while node %(node)s\""},{"line_number":1380,"context_line":"                    \"is in state %(state)s\")"},{"line_number":1381,"context_line":"                    % {\u0027node\u0027: node, \u0027state\u0027: node.provision_state})"},{"line_number":1382,"context_line":""},{"line_number":1383,"context_line":"    @periodic_task.periodic_task("},{"line_number":1384,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_81891777","line":1381,"in_reply_to":"ba7be1f8_8d3310aa","updated":"2015-02-25 14:27:14.000000000","message":"ok.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        self._check_timeouts(context, callback_timeout, filters,"},{"line_number":1395,"context_line":"                             states.INSPECTING, sort_key)"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def _check_timeouts(self, context, callback_timeout, filters,"},{"line_number":1398,"context_line":"                        provision_state, sort_key):"},{"line_number":1399,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1400,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_7b575926","line":1397,"updated":"2015-02-25 23:07:08.000000000","message":"I was wondering why this was called _check_timeouts() when there is nothing in the code that deals with timeouts except this \u0027callback_timeout\u0027 (doesn\u0027t seem to be used?), and the comment below about \u0027timeout has been reached\u0027.\n\nI see two ways to clean it up:\n\n1. rename it something like _check_for_state(). Which is what it seems to be doing. If the node is in the passed provision_state it fails.\n2. use the callback_timeout. In addition to what you\u0027re passing, you may only need to pass the timeout_key and you could add that to the inputted filters (or create a new filters) via:\n    filters \u003d dict(filters) + {timeout_key: timeout_value}\n\nHmm, maybe 1 is better because 2 seems to be more work w/o much gain that I can see.\n\nIt would be nice to have docstrings here describing what this does, but I also realize that we don\u0027t tend to do that for internal methods.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"        self._check_timeouts(context, callback_timeout, filters,"},{"line_number":1395,"context_line":"                             states.INSPECTING, sort_key)"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def _check_timeouts(self, context, callback_timeout, filters,"},{"line_number":1398,"context_line":"                        provision_state, sort_key):"},{"line_number":1399,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1400,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_f0119404","line":1397,"in_reply_to":"ba7be1f8_7b575926","updated":"2015-02-26 10:45:37.000000000","message":"changed the name check_timeouts to _check_for_state(). It will accept the error handler and call back process as arguments.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"            if not self._mapped_to_this_conductor(node_uuid, driver):"},{"line_number":1409,"context_line":"                continue"},{"line_number":1410,"context_line":"            try:"},{"line_number":1411,"context_line":"                with task_manager.acquire(context, node_uuid) as task:"},{"line_number":1412,"context_line":"                    if (task.node.maintenance or"},{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_70286f86","line":1411,"updated":"2015-02-25 13:31:46.000000000","message":"Since we are going to change the state, should it be shared\u003dFalse ?","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"            if not self._mapped_to_this_conductor(node_uuid, driver):"},{"line_number":1409,"context_line":"                continue"},{"line_number":1410,"context_line":"            try:"},{"line_number":1411,"context_line":"                with task_manager.acquire(context, node_uuid) as task:"},{"line_number":1412,"context_line":"                    if (task.node.maintenance or"},{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_e1c5738e","line":1411,"in_reply_to":"ba7be1f8_70286f86","updated":"2015-02-25 14:27:14.000000000","message":"not very sure how that helps or matters. i can do it as shared\u003dFalse but not sure of the implications.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a10c116adad698fdf9494b194865cd30c4c0402","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"            if not self._mapped_to_this_conductor(node_uuid, driver):"},{"line_number":1409,"context_line":"                continue"},{"line_number":1410,"context_line":"            try:"},{"line_number":1411,"context_line":"                with task_manager.acquire(context, node_uuid) as task:"},{"line_number":1412,"context_line":"                    if (task.node.maintenance or"},{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_bc7f2065","line":1411,"in_reply_to":"ba7be1f8_e1c5738e","updated":"2015-02-25 14:32:38.000000000","message":"shared\u003dFalse is the default","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"},{"line_number":1415,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1419,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_98d5f3e6","line":1416,"updated":"2015-02-25 23:07:08.000000000","message":"No need for a blank line. (I think it is worse with the blank line; it makes it unclear what that comment is meant for.)","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1414,"context_line":"                        continue"},{"line_number":1415,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1419,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_301ecc0c","line":1416,"in_reply_to":"ba7be1f8_98d5f3e6","updated":"2015-02-26 10:45:37.000000000","message":"ok.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1419,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"},{"line_number":1420,"context_line":"                                                  task),"},{"line_number":1421,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"},{"line_number":1422,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_edb1ec8f","line":1419,"updated":"2015-02-25 13:31:46.000000000","message":"utils.cleanup_after_timeout() does a cleanup after deploy by calling task.driver.deploy.clean_up(task).  Does it fit in this context ? I don\u0027t think so. I think we should just fail it.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1419,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"},{"line_number":1420,"context_line":"                                                  task),"},{"line_number":1421,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"},{"line_number":1422,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_f80b4f7a","line":1419,"in_reply_to":"ba7be1f8_bcf640f7","updated":"2015-02-25 23:07:08.000000000","message":"Good catch Ramakrishnan. I think the callback args can be passed as a parameter to _check_timeouts(). It can default to None. task.process_event() handles that. Actually, would probably need to pass callback, callback_args, callback_kwargs and error_handler as parameters to this method.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a10c116adad698fdf9494b194865cd30c4c0402","unresolved":false,"context_lines":[{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1419,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"},{"line_number":1420,"context_line":"                                                  task),"},{"line_number":1421,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"},{"line_number":1422,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_bcf640f7","line":1419,"in_reply_to":"ba7be1f8_edb1ec8f","updated":"2015-02-25 14:32:38.000000000","message":"awesome catch +1","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":"                    task.process_event(\u0027fail\u0027,"},{"line_number":1418,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":1419,"context_line":"                                       call_args\u003d(utils.cleanup_after_timeout,"},{"line_number":1420,"context_line":"                                                  task),"},{"line_number":1421,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"},{"line_number":1422,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_e121f34d","line":1419,"in_reply_to":"ba7be1f8_edb1ec8f","updated":"2015-02-25 14:27:14.000000000","message":"hmmm good catch.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87c823c700a1da552ccaecaeaa5cea67e67c4bd7","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_c6d405bf","line":1735,"updated":"2015-02-25 14:20:14.000000000","message":"Mostly nit: I see this function is based on the handle_failure() from do_node_deploy(). Would make sense to actually just put it out of this function scope and use the same handle_failure for both?","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3177727a3b37080302e1082022341d05d4bd387d","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1733,"context_line":"    node \u003d task.node"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_01f7e78b","line":1735,"in_reply_to":"ba7be1f8_c6d405bf","updated":"2015-02-25 14:21:47.000000000","message":"they have different error messages and passing in error message looks ugly enough IMO...","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_b06ca7d1","line":1737,"updated":"2015-02-25 13:31:46.000000000","message":"I think we should have some proper note here for last_error and it should be translated string.\n\n_(\"Inspection failed with error: \u003c\u003e\")","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ce83375d7d032d4108726333074033393f40b63b","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_45d7394b","line":1737,"updated":"2015-02-25 09:04:56.000000000","message":"I wonder if we should use str(e) here...","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"104e0d195fb165692d0dfc7209a7ea45a21af831","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_7765c1b3","line":1737,"in_reply_to":"ba7be1f8_3c5df015","updated":"2015-02-25 14:53:15.000000000","message":"Ok i will do","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_1098e876","line":1737,"in_reply_to":"ba7be1f8_41ec7ff3","updated":"2015-02-26 10:45:37.000000000","message":"done","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_a197fb38","line":1737,"in_reply_to":"ba7be1f8_45d7394b","updated":"2015-02-25 14:27:14.000000000","message":"Dmitry, does that really matter? It is already a string.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8a10c116adad698fdf9494b194865cd30c4c0402","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_3c5df015","line":1737,"in_reply_to":"ba7be1f8_a197fb38","updated":"2015-02-25 14:32:38.000000000","message":"on line 1747 you pass an exception instance here","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87c823c700a1da552ccaecaeaa5cea67e67c4bd7","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_668a791c","line":1737,"in_reply_to":"ba7be1f8_b06ca7d1","updated":"2015-02-25 14:20:14.000000000","message":"+1","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"    def handle_failure(e):"},{"line_number":1736,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1737,"context_line":"        node.last_error \u003d e"},{"line_number":1738,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":1739,"context_line":"        LOG.error(_LE(\"Failed to inspect node %(node)s: %(err)s\"),"},{"line_number":1740,"context_line":"                  {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_41ec7ff3","line":1737,"in_reply_to":"ba7be1f8_b06ca7d1","updated":"2015-02-25 14:27:14.000000000","message":"The error message from driver will be displayed here as it is.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1756,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":1757,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1758,"context_line":"        handle_failure(\"Driver returned unexpected state \""},{"line_number":1759,"context_line":"                       \"%(state)s\" % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_30b7d73b","line":1758,"updated":"2015-02-25 13:31:46.000000000","message":"Add \"Driver returned unexpected state during inspection...\"","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1756,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":1757,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1758,"context_line":"        handle_failure(\"Driver returned unexpected state \""},{"line_number":1759,"context_line":"                       \"%(state)s\" % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_a180dbf7","line":1758,"in_reply_to":"ba7be1f8_30b7d73b","updated":"2015-02-25 14:27:14.000000000","message":"i can do that but the handle_failure already adds the note that it is failed during inspection. See above...","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027),"},{"line_number":1756,"context_line":"                 {\u0027node\u0027: node.uuid})"},{"line_number":1757,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1758,"context_line":"        handle_failure(\"Driver returned unexpected state \""},{"line_number":1759,"context_line":"                       \"%(state)s\" % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_30932c5c","line":1758,"in_reply_to":"ba7be1f8_a180dbf7","updated":"2015-02-26 10:45:37.000000000","message":"done","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                        \u0027data. Used when configdrive_use_swift is True.\u0027),"},{"line_number":165,"context_line":"        cfg.IntOpt(\u0027inspect_timeout\u0027,"},{"line_number":166,"context_line":"                   default\u003d1800,"},{"line_number":167,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting for node inspection.\u0027),"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"]"},{"line_number":170,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_722f613f","line":167,"updated":"2015-02-26 13:10:24.000000000","message":"From where is this string \" 0 - unlimited. \" coming in ironic.conf.sample ? I don\u0027t see it here.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                        \u0027data. Used when configdrive_use_swift is True.\u0027),"},{"line_number":165,"context_line":"        cfg.IntOpt(\u0027inspect_timeout\u0027,"},{"line_number":166,"context_line":"                   default\u003d1800,"},{"line_number":167,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting for node inspection.\u0027),"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"]"},{"line_number":170,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_e3937ea0","line":167,"in_reply_to":"ba7be1f8_722f613f","updated":"2015-02-26 16:13:57.000000000","message":"i have updated it here.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    @periodic_task.periodic_task("},{"line_number":1388,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1389,"context_line":"    def _check_inspect_timeouts(self, context):"},{"line_number":1390,"context_line":"        \"\"\"periodically checks if inspect_timeout has reached."},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"        :param: context: request context"},{"line_number":1393,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_222e748c","line":1390,"updated":"2015-02-26 16:20:06.000000000","message":"What does it do if the timeout was reached? (Sorry, I had to ask because that\u0027s the question I had after reading this.)","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bc937a8806f13557077a228c6977733e3eb29845","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    @periodic_task.periodic_task("},{"line_number":1388,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1389,"context_line":"    def _check_inspect_timeouts(self, context):"},{"line_number":1390,"context_line":"        \"\"\"periodically checks if inspect_timeout has reached."},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"        :param: context: request context"},{"line_number":1393,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_0276d005","line":1390,"updated":"2015-02-26 15:24:02.000000000","message":"nit: capital letter in the beginning","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    @periodic_task.periodic_task("},{"line_number":1388,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1389,"context_line":"    def _check_inspect_timeouts(self, context):"},{"line_number":1390,"context_line":"        \"\"\"periodically checks if inspect_timeout has reached."},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"        :param: context: request context"},{"line_number":1393,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_28a56bb5","line":1390,"in_reply_to":"ba7be1f8_222e748c","updated":"2015-02-26 20:28:07.000000000","message":"it will just fail.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"        self._check_for_state(context, callback_timeout, filters,"},{"line_number":1404,"context_line":"                             states.INSPECTING, sort_key)"},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_623dcc8e","line":1406,"updated":"2015-02-26 16:20:06.000000000","message":"I still don\u0027t see why you\u0027re passing callback_timeout. It isn\u0027t used anywhere (and shouldn\u0027t be).","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"        self._check_for_state(context, callback_timeout, filters,"},{"line_number":1404,"context_line":"                             states.INSPECTING, sort_key)"},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_9aa5bca3","line":1406,"in_reply_to":"ba7be1f8_623dcc8e","updated":"2015-02-26 20:28:07.000000000","message":"Oh yes.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_22ebd4dc","line":1409,"updated":"2015-02-26 16:20:06.000000000","message":"Huh?\n\nHow about \u0027Nodes that are in provision_state have failed\n\n\u0027filters\u0027 is used to retrieve a list of nodes that satisfy the filter constraints. Any of these nodes that are in the specified \u0027provision_state\u0027 (excluding nodes in maintenance) are deemed to have failed in their current provisioning activity.\n\nYou know what, after writing that, I think a better name for this method might be \u0027fail_if_in_state()\u0027. What do you think?","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bc937a8806f13557077a228c6977733e3eb29845","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_2271140c","line":1409,"updated":"2015-02-26 15:24:02.000000000","message":"nit: capital letter in the beginning","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f13a7f9ccaadc820c47cee6464ab01249c00ec3b","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_c2e2e600","line":1409,"in_reply_to":"ba7be1f8_1a154c9b","updated":"2015-02-26 21:59:04.000000000","message":"The idea of this method (for me) is that it is passed a filter which is used to select a list of nodes that satisfy the criteria. The fact that we\u0027re using it to timeout is encoded in that filter. Because the filter has the timeout information in it, all the nodes selected here will have timed out. If the filter had eg {\u0027reserved\u0027: False}, this method would be looking at all unlocked nodes, so it wouldn\u0027t make sense for it to be called \u0027fail_if_timeout_reached()\u0027. If you look at the code, it is checking the node\u0027s provision_state against the inputted provision state. There is nothing in this code that explicitly mentions any time outs.\n\nI suppose in the description you could add an example. Eg. \"\u0027filters\u0027 is used to retrieve a list of nodes that satisfy the filter constraints. For example, if filters[\u0027provisioned_before\u0027] \u003d 60, this would process nodes whose provision_updated_at field value was 60 or more seconds before \u0027now\u0027....\"","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_2314b6e7","line":1409,"in_reply_to":"ba7be1f8_2271140c","updated":"2015-02-26 16:13:57.000000000","message":"ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"    def _check_for_state(self, context, callback_timeout, filters,"},{"line_number":1407,"context_line":"                         provision_state, sort_key,"},{"line_number":1408,"context_line":"                         process_call_args\u003dNone, err_handler\u003dNone):"},{"line_number":1409,"context_line":"        \"\"\"checks if the spawned process has completed before the timeout."},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_1a154c9b","line":1409,"in_reply_to":"ba7be1f8_22ebd4dc","updated":"2015-02-26 20:28:07.000000000","message":":) \n\nwe dont fail if node is in a particular state without timeout being reached. May be \u0027fail_if_timeout_reached()\u0027 will be better name in that case. What do you say?","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"},{"line_number":1413,"context_line":"        :param: filters: dictionary of keys which is used to retrieve the"},{"line_number":1414,"context_line":"                         node info list from the db."},{"line_number":1415,"context_line":"        :param: provision_state: provision_state on which filter needs"},{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_c2975846","line":1414,"updated":"2015-02-26 16:20:06.000000000","message":"how about \u0027desired list of nodes from the db.\u0027","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        :param: context: request context"},{"line_number":1412,"context_line":"        :param: callback_timeout: callback timeout"},{"line_number":1413,"context_line":"        :param: filters: dictionary of keys which is used to retrieve the"},{"line_number":1414,"context_line":"                         node info list from the db."},{"line_number":1415,"context_line":"        :param: provision_state: provision_state on which filter needs"},{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_5a8264c8","line":1414,"in_reply_to":"ba7be1f8_c2975846","updated":"2015-02-26 20:28:07.000000000","message":"yeah sounds better :)","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        :param: filters: dictionary of keys which is used to retrieve the"},{"line_number":1414,"context_line":"                         node info list from the db."},{"line_number":1415,"context_line":"        :param: provision_state: provision_state on which filter needs"},{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_62186cd3","line":1416,"updated":"2015-02-26 16:20:06.000000000","message":"I don\u0027t think that\u0027s quite right if we want this to be a generic method. This is the state that you\u0027re checking for. How about \u0027provision_state that the node is in, for the provisioning activity to have failed\u0027.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1413,"context_line":"        :param: filters: dictionary of keys which is used to retrieve the"},{"line_number":1414,"context_line":"                         node info list from the db."},{"line_number":1415,"context_line":"        :param: provision_state: provision_state on which filter needs"},{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_5a59848c","line":1416,"in_reply_to":"ba7be1f8_62186cd3","updated":"2015-02-26 20:28:07.000000000","message":"ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"        :param: provision_state: provision_state on which filter needs"},{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."},{"line_number":1420,"context_line":"        :param: err_handler: the error handler to be invoked."},{"line_number":1421,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_42bfe860","line":1418,"updated":"2015-02-26 16:20:06.000000000","message":"The nodes are retrieved based on what is in filters. This just specifies how to sort the list. How about \u0027the nodes are sorted based on this sort_key\u0027.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"        :param: provision_state: provision_state on which filter needs"},{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."},{"line_number":1420,"context_line":"        :param: err_handler: the error handler to be invoked."},{"line_number":1421,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_1acaac1a","line":1418,"in_reply_to":"ba7be1f8_42bfe860","updated":"2015-02-26 20:28:07.000000000","message":"ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."},{"line_number":1420,"context_line":"        :param: err_handler: the error handler to be invoked."},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_823ac0e4","line":1419,"updated":"2015-02-26 16:20:06.000000000","message":"I think this is the method to be called, so I suggest renaming it and describing it something like:\n\n:param: callback_method: the callback method to be invoked in a spawned thread, for a failed node. This method must take a :class:`TaskManager` as the first (and only required) parameter.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"                                 to be set."},{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."},{"line_number":1420,"context_line":"        :param: err_handler: the error handler to be invoked."},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_9addbce2","line":1419,"in_reply_to":"ba7be1f8_823ac0e4","updated":"2015-02-26 20:28:07.000000000","message":"ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."},{"line_number":1420,"context_line":"        :param: err_handler: the error handler to be invoked."},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        \"\"\""},{"line_number":1423,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_9d594137","line":1420,"updated":"2015-02-26 16:20:06.000000000","message":"how about \u0027The error handler to invoke if an error occurs trying to spawn a thread for a failed node.\u0027","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"        :param: sort_key: the key on which the node information"},{"line_number":1418,"context_line":"                          should be retrieved."},{"line_number":1419,"context_line":"        :param: process_call_args: the call back process to be invoked."},{"line_number":1420,"context_line":"        :param: err_handler: the error handler to be invoked."},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        \"\"\""},{"line_number":1423,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_fadeb8d8","line":1420,"in_reply_to":"ba7be1f8_9d594137","updated":"2015-02-26 20:28:07.000000000","message":"ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":1422,"context_line":"        \"\"\""},{"line_number":1423,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1424,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1425,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1426,"context_line":"                                    filters\u003dfilters,"},{"line_number":1427,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":1428,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_b20b997b","line":1425,"updated":"2015-02-26 13:10:24.000000000","message":"nit: indentation.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1422,"context_line":"        \"\"\""},{"line_number":1423,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027]"},{"line_number":1424,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list("},{"line_number":1425,"context_line":"                                    columns\u003dcolumns,"},{"line_number":1426,"context_line":"                                    filters\u003dfilters,"},{"line_number":1427,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":1428,"context_line":"                                    sort_dir\u003d\u0027asc\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_63ef8e1e","line":1425,"in_reply_to":"ba7be1f8_b20b997b","updated":"2015-02-26 16:13:57.000000000","message":"done","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"                        task.node.provision_state !\u003d provision_state):"},{"line_number":1438,"context_line":"                        continue"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1441,"context_line":"                    if process_call_args and err_handler:"},{"line_number":1442,"context_line":"                        task.process_event(\u0027fail\u0027,"},{"line_number":1443,"context_line":"                                           callback\u003dself._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_e2937ca0","line":1440,"updated":"2015-02-26 16:20:06.000000000","message":"This is checking for the state, there\u0027s nothing about timeout here, so this comment should be changed.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1438,"context_line":"                        continue"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1441,"context_line":"                    if process_call_args and err_handler:"},{"line_number":1442,"context_line":"                        task.process_event(\u0027fail\u0027,"},{"line_number":1443,"context_line":"                                           callback\u003dself._spawn_worker,"},{"line_number":1444,"context_line":"                                           call_args\u003d(process_call_args, task),"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_9da7810a","line":1441,"updated":"2015-02-26 16:20:06.000000000","message":"I think you should only do \u0027if process_call_args:\u0027. There could be a case where no err_handler is wanted (doubtful but who knows).","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1438,"context_line":"                        continue"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"                    # timeout has been reached - process the event \u0027fail\u0027"},{"line_number":1441,"context_line":"                    if process_call_args and err_handler:"},{"line_number":1442,"context_line":"                        task.process_event(\u0027fail\u0027,"},{"line_number":1443,"context_line":"                                           callback\u003dself._spawn_worker,"},{"line_number":1444,"context_line":"                                           call_args\u003d(process_call_args, task),"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_3af4d059","line":1441,"in_reply_to":"ba7be1f8_9da7810a","updated":"2015-02-26 20:28:07.000000000","message":"hmmm ok","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"                                           err_handler\u003derr_handler)"},{"line_number":1446,"context_line":"                    else:"},{"line_number":1447,"context_line":"                        last_error \u003d _(\"timeout reached while waiting \""},{"line_number":1448,"context_line":"                                       \"for callback\")"},{"line_number":1449,"context_line":"                        task.node.last_error \u003d last_error"},{"line_number":1450,"context_line":"                        task.process_event(\u0027fail\u0027)"},{"line_number":1451,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_bd56055a","line":1448,"updated":"2015-02-26 16:20:06.000000000","message":"This string should be passed in as a parameter, since this method is generic and shouldn\u0027t know about \u0027timeouts\u0027.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f13a7f9ccaadc820c47cee6464ab01249c00ec3b","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"                                           err_handler\u003derr_handler)"},{"line_number":1446,"context_line":"                    else:"},{"line_number":1447,"context_line":"                        last_error \u003d _(\"timeout reached while waiting \""},{"line_number":1448,"context_line":"                                       \"for callback\")"},{"line_number":1449,"context_line":"                        task.node.last_error \u003d last_error"},{"line_number":1450,"context_line":"                        task.process_event(\u0027fail\u0027)"},{"line_number":1451,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_02c07e29","line":1448,"in_reply_to":"ba7be1f8_ba8600b7","updated":"2015-02-26 21:59:04.000000000","message":"Well, \u0027make\u0027 a method pass error_str as an argument. They could send a null string but that would be up to the method. You could also change the logic so that if the error_str was None, then don\u0027t set last_error to anything.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"                                           err_handler\u003derr_handler)"},{"line_number":1446,"context_line":"                    else:"},{"line_number":1447,"context_line":"                        last_error \u003d _(\"timeout reached while waiting \""},{"line_number":1448,"context_line":"                                       \"for callback\")"},{"line_number":1449,"context_line":"                        task.node.last_error \u003d last_error"},{"line_number":1450,"context_line":"                        task.process_event(\u0027fail\u0027)"},{"line_number":1451,"context_line":"            except exception.NoFreeConductorWorker:"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_ba8600b7","line":1448,"in_reply_to":"ba7be1f8_bd56055a","updated":"2015-02-26 20:28:07.000000000","message":"ok. i agree but in case a method doesnt pass this as an argument then this method needs to set it here in last_error. So i have kept it under a condition. May be we can generalize it in that condition as the error message as \"error occured on node %s\" %node.uuid","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"                                       \"for callback\")"},{"line_number":1449,"context_line":"                        task.node.last_error \u003d last_error"},{"line_number":1450,"context_line":"                        task.process_event(\u0027fail\u0027)"},{"line_number":1451,"context_line":"            except exception.NoFreeConductorWorker:"},{"line_number":1452,"context_line":"                break"},{"line_number":1453,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1454,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_8d959a34","line":1451,"updated":"2015-02-26 13:10:24.000000000","message":"May be this was previous code and can be taken later, but why do we check only 3 exceptions here ? If something fails for this node, we should consider other nodes, right ?","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"                                       \"for callback\")"},{"line_number":1449,"context_line":"                        task.node.last_error \u003d last_error"},{"line_number":1450,"context_line":"                        task.process_event(\u0027fail\u0027)"},{"line_number":1451,"context_line":"            except exception.NoFreeConductorWorker:"},{"line_number":1452,"context_line":"                break"},{"line_number":1453,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1454,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_7d348d49","line":1451,"in_reply_to":"ba7be1f8_8d959a34","updated":"2015-02-26 16:20:06.000000000","message":"In this case, there are no more free conductor workers which means we can\u0027t spawn any more processes, so we can\u0027t handle any other nodes that failed that require spawning a thread. I suppose one could continue to other nodes in the hopes that a thread is released in the meantime but these are periodic tasks so they should be lower priority than other things that might require threads.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"                                       \"for callback\")"},{"line_number":1449,"context_line":"                        task.node.last_error \u003d last_error"},{"line_number":1450,"context_line":"                        task.process_event(\u0027fail\u0027)"},{"line_number":1451,"context_line":"            except exception.NoFreeConductorWorker:"},{"line_number":1452,"context_line":"                break"},{"line_number":1453,"context_line":"            except (exception.NodeLocked, exception.NodeNotFound):"},{"line_number":1454,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_e348de2e","line":1451,"in_reply_to":"ba7be1f8_8d959a34","updated":"2015-02-26 16:13:57.000000000","message":"May be we can scope it outside this spec as it is already existing thing.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1762,"context_line":"    node \u003d task.node"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"    def handle_failure(e):"},{"line_number":1765,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1766,"context_line":"        node.last_error \u003d e"},{"line_number":1767,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_72e041cd","line":1764,"updated":"2015-02-26 13:10:24.000000000","message":"handle_failure needn\u0027t raise exception if we are using with excutils.save_and_reraise_exception(). Either we use with excutils.save_and_reraise_exception() or raise the exception in handle_failure().","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1762,"context_line":"    node \u003d task.node"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"    def handle_failure(e):"},{"line_number":1765,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1766,"context_line":"        node.last_error \u003d e"},{"line_number":1767,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_8811f755","line":1764,"in_reply_to":"ba7be1f8_63530e17","updated":"2015-02-26 20:28:07.000000000","message":"I raised it because of error case at 1789. IMO we should raise error at 1789 too. I will try to handle exception there.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1762,"context_line":"    node \u003d task.node"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"    def handle_failure(e):"},{"line_number":1765,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1766,"context_line":"        node.last_error \u003d e"},{"line_number":1767,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_63530e17","line":1764,"in_reply_to":"ba7be1f8_72e041cd","updated":"2015-02-26 16:20:06.000000000","message":"I was looking at Lucas\u0027 comment about how this seems similar to another handle_failure(). If we aren\u0027t going to collapse them to be used for both, I think we should keep a similar flow, to make it easier to merge them both in the future. Ie, don\u0027t raise an exception here.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"    \"\"\"Prepare the environment and inspect a node.\"\"\""},{"line_number":1762,"context_line":"    node \u003d task.node"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"    def handle_failure(e):"},{"line_number":1765,"context_line":"        # NOTE(deva): there is no need to clear conductor_affinity"},{"line_number":1766,"context_line":"        node.last_error \u003d e"},{"line_number":1767,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_4361aaa7","line":1764,"in_reply_to":"ba7be1f8_72e041cd","updated":"2015-02-26 16:13:57.000000000","message":"done.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1778,"context_line":"            error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1779,"context_line":"            handle_failure(error)"},{"line_number":1780,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_1252a566","line":1777,"updated":"2015-02-26 13:10:24.000000000","message":"handle_failure raises exception so this needn\u0027t be excutils.save_and_reraise_exception()","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bc937a8806f13557077a228c6977733e3eb29845","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1778,"context_line":"            error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1779,"context_line":"            handle_failure(error)"},{"line_number":1780,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_4298c81b","line":1777,"in_reply_to":"ba7be1f8_1252a566","updated":"2015-02-26 15:24:02.000000000","message":"Maybe we don\u0027t need save_and_reraise_exception() here and we should always reraise it inside handle_failure as HardwareInspectionFailure","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1778,"context_line":"            error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1779,"context_line":"            handle_failure(error)"},{"line_number":1780,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_6364eeb8","line":1777,"in_reply_to":"ba7be1f8_1252a566","updated":"2015-02-26 16:13:57.000000000","message":"done.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bc937a8806f13557077a228c6977733e3eb29845","unresolved":false,"context_lines":[{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1778,"context_line":"            error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1779,"context_line":"            handle_failure(error)"},{"line_number":1780,"context_line":""},{"line_number":1781,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_e2ad3c32","line":1778,"updated":"2015-02-26 15:24:02.000000000","message":"just\n \n handle_failure(str(e))","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1778,"context_line":"            error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1779,"context_line":"            handle_failure(error)"},{"line_number":1780,"context_line":""},{"line_number":1781,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_03f092c7","line":1778,"in_reply_to":"ba7be1f8_e2ad3c32","updated":"2015-02-26 16:13:57.000000000","message":"dont we need to translate it...i just added so as to avoid the same comment again","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1780,"context_line":""},{"line_number":1781,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1782,"context_line":"    # since there may be local persistent state"},{"line_number":1783,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1786,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_0848b1ca","line":1783,"updated":"2015-02-26 16:20:06.000000000","message":"Why do we need to do that here. Or are you doing this in case it is ever needed?\n\nI am thinking that this should only be added if you need it. And if you need it,  _do_takeover() will need to be updated. I think that would be the time to add this in.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1780,"context_line":""},{"line_number":1781,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1782,"context_line":"    # since there may be local persistent state"},{"line_number":1783,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1786,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_a81b1b1b","line":1783,"in_reply_to":"ba7be1f8_0848b1ca","updated":"2015-02-26 20:28:07.000000000","message":"Ok i will remove it for now as i am not sure what it should do in do_takeover. \n@Dmitry, could you verify if in-band may need this _do_takeover to be called?","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1788,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1789,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1790,"context_line":"        error \u003d (_(\"Driver returned unexpected state during inspection\""},{"line_number":1791,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1792,"context_line":"        handle_failure(error)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_f2d35101","line":1790,"updated":"2015-02-26 13:10:24.000000000","message":"s/during/after","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1788,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1789,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1790,"context_line":"        error \u003d (_(\"Driver returned unexpected state during inspection\""},{"line_number":1791,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1792,"context_line":"        handle_failure(error)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_88cc978c","line":1790,"in_reply_to":"ba7be1f8_038fb275","updated":"2015-02-26 20:28:07.000000000","message":"in iLO drivers implementation either i raise exception or i return manageable. but yes it can be INSPECTFAIL if any driver implementation return inspectfail.\n\nAnyway i have changed it to \u0027in\u0027 inspection instead of \u0027during\u0027","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1788,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1789,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1790,"context_line":"        error \u003d (_(\"Driver returned unexpected state during inspection\""},{"line_number":1791,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1792,"context_line":"        handle_failure(error)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_036b3285","line":1790,"in_reply_to":"ba7be1f8_f2d35101","updated":"2015-02-26 16:13:57.000000000","message":"i have changed it to \u0027in\u0027 instead of after.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1788,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1789,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1790,"context_line":"        error \u003d (_(\"Driver returned unexpected state during inspection\""},{"line_number":1791,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1792,"context_line":"        handle_failure(error)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_038fb275","line":1790,"in_reply_to":"ba7be1f8_f2d35101","updated":"2015-02-26 16:20:06.000000000","message":"why is it \u0027after\u0027? Could this be states.INSPECTFAIL? Wouldn\u0027t that be \u0027during\u0027 inspection, something barfed?","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"22d1f541ac8d8d3da70218f460a7e520a1b02930","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1778,"context_line":"        handle_failure(error)"},{"line_number":1779,"context_line":""},{"line_number":1780,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba7be1f8_95a11548","line":1777,"updated":"2015-02-26 16:37:12.000000000","message":"no seriously, how do you expect people to translate %s? It\u0027s just a placeholder :)","commit_id":"d4118476fb046cfeae8f1eda75dcf12b6e910d15"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c1ca120e0ac197536994282d12d16cdd29d6051","unresolved":false,"context_lines":[{"line_number":1774,"context_line":"        new_state \u003d task.driver.inspect.inspect_hardware(task)"},{"line_number":1775,"context_line":""},{"line_number":1776,"context_line":"    except Exception as e:"},{"line_number":1777,"context_line":"        error \u003d (_(\u0027%s\u0027) % str(e))"},{"line_number":1778,"context_line":"        handle_failure(error)"},{"line_number":1779,"context_line":""},{"line_number":1780,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba7be1f8_8eb2e6e2","line":1777,"in_reply_to":"ba7be1f8_95a11548","updated":"2015-02-26 17:29:47.000000000","message":"ok.","commit_id":"d4118476fb046cfeae8f1eda75dcf12b6e910d15"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7995c199af6ba7af0a445af9debf956a33fbfb65","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1788,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1789,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1790,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1791,"context_line":"        handle_failure(error)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba7be1f8_a2525266","line":1790,"updated":"2015-02-26 22:01:21.000000000","message":"I should stop looking. You need a space before this (or at the end of the string above).\n\nIt might be better as \"While inspecting (or \u0027During inspection\u0027), driver returned unexpected state: \u0027%(state)s\u0027\".","commit_id":"d4118476fb046cfeae8f1eda75dcf12b6e910d15"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        cfg.IntOpt(\u0027inspect_timeout\u0027,"},{"line_number":166,"context_line":"                   default\u003d1800,"},{"line_number":167,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting for node inspection. \u0027"},{"line_number":168,"context_line":"                        \u00270 - unlimited. (integer value)\u0027),"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"]"},{"line_number":171,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_b8821350","line":168,"updated":"2015-03-02 16:57:20.000000000","message":"Don\u0027t need \u0027(integer value)\u0027. That will be generated. Take a look at ironic.conf.sample; it shows up twice now.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        cfg.IntOpt(\u0027inspect_timeout\u0027,"},{"line_number":166,"context_line":"                   default\u003d1800,"},{"line_number":167,"context_line":"                   help\u003d\u0027Timeout (seconds) for waiting for node inspection. \u0027"},{"line_number":168,"context_line":"                        \u00270 - unlimited. (integer value)\u0027),"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"]"},{"line_number":171,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_3e460822","line":168,"in_reply_to":"ba7be1f8_b8821350","updated":"2015-03-02 17:54:25.000000000","message":"ohk. will remove it in followup patch.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"369780917f6248cef4999611c11534bae79d66b8","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        callback_method \u003d utils.cleanup_after_timeout"},{"line_number":925,"context_line":"        err_handler \u003d provisioning_error_handler"},{"line_number":926,"context_line":"        self._fail_if_timeout_reached(context, filters, states.DEPLOYWAIT,"},{"line_number":927,"context_line":"                              sort_key, callback_method, err_handler)"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    def _do_takeover(self, task):"},{"line_number":930,"context_line":"        LOG.debug((\u0027Conductor %(cdr)s taking over node %(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_ed98a16c","line":927,"updated":"2015-02-27 12:14:02.000000000","message":"nit: indentation","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        callback_method \u003d utils.cleanup_after_timeout"},{"line_number":925,"context_line":"        err_handler \u003d provisioning_error_handler"},{"line_number":926,"context_line":"        self._fail_if_timeout_reached(context, filters, states.DEPLOYWAIT,"},{"line_number":927,"context_line":"                              sort_key, callback_method, err_handler)"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"    def _do_takeover(self, task):"},{"line_number":930,"context_line":"        LOG.debug((\u0027Conductor %(cdr)s taking over node %(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_68b9aa2d","line":927,"in_reply_to":"ba7be1f8_ed98a16c","updated":"2015-03-02 17:54:25.000000000","message":"I will do a followup patch and correct it","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c89754b895442dbc260b38213ea186de9319dc4d","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"                          \"%(node)s is in state %(state)s\")"},{"line_number":1447,"context_line":"                          % {\u0027node\u0027: node.uuid,"},{"line_number":1448,"context_line":"                             \u0027state\u0027: node.provision_state})"},{"line_number":1449,"context_line":"                raise exception.HardwareInspectionFailure(error\u003derror)"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"    @periodic_task.periodic_task("},{"line_number":1452,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_1f6257d8","line":1449,"updated":"2015-02-28 02:58:54.000000000","message":"May be better raise back exception.InvalidState as it makes more sense.  Might require changes to @messaging.expected_exceptions.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"64f9a299cf4fc3f8cfdc1eb1500a1a9084893645","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"                          \"%(node)s is in state %(state)s\")"},{"line_number":1447,"context_line":"                          % {\u0027node\u0027: node.uuid,"},{"line_number":1448,"context_line":"                             \u0027state\u0027: node.provision_state})"},{"line_number":1449,"context_line":"                raise exception.HardwareInspectionFailure(error\u003derror)"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"    @periodic_task.periodic_task("},{"line_number":1452,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_659393fa","line":1449,"in_reply_to":"ba7be1f8_1f6257d8","updated":"2015-03-02 17:13:25.000000000","message":"Ramakrishnan has a good point. Although maybe it should return exception.InvalidStateRequested(), since that\u0027s what deploy and teardown do.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"                          \"%(node)s is in state %(state)s\")"},{"line_number":1447,"context_line":"                          % {\u0027node\u0027: node.uuid,"},{"line_number":1448,"context_line":"                             \u0027state\u0027: node.provision_state})"},{"line_number":1449,"context_line":"                raise exception.HardwareInspectionFailure(error\u003derror)"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"    @periodic_task.periodic_task("},{"line_number":1452,"context_line":"        spacing\u003dCONF.conductor.check_provision_state_interval)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_48d8667f","line":1449,"in_reply_to":"ba7be1f8_659393fa","updated":"2015-03-02 17:54:25.000000000","message":"Should it raise or return? It should be raise, correct?","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"369780917f6248cef4999611c11534bae79d66b8","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1465,"context_line":"                   \u0027inspection_started_before\u0027: callback_timeout}"},{"line_number":1466,"context_line":"        sort_key \u003d \u0027inspection_started_at\u0027"},{"line_number":1467,"context_line":"        last_error \u003d _(\"timeout reached while waiting for callback\")"},{"line_number":1468,"context_line":"        self._fail_if_timeout_reached(context, filters, states.INSPECTING,"},{"line_number":1469,"context_line":"                                      sort_key, last_error\u003dlast_error)"},{"line_number":1470,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_8da9e57d","line":1467,"updated":"2015-02-27 12:14:02.000000000","message":"nit: it\u0027s the same as default value for last_error and can be omitted","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b0d7367b28b4f10e566ee444abaedfed9be12762","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1465,"context_line":"                   \u0027inspection_started_before\u0027: callback_timeout}"},{"line_number":1466,"context_line":"        sort_key \u003d \u0027inspection_started_at\u0027"},{"line_number":1467,"context_line":"        last_error \u003d _(\"timeout reached while waiting for callback\")"},{"line_number":1468,"context_line":"        self._fail_if_timeout_reached(context, filters, states.INSPECTING,"},{"line_number":1469,"context_line":"                                      sort_key, last_error\u003dlast_error)"},{"line_number":1470,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_b345bf44","line":1467,"in_reply_to":"ba7be1f8_4adbf61a","updated":"2015-03-03 00:52:56.000000000","message":"Do you mean keep the last_error parameter in the to-be-renamed-_fail_if_timeout_reached() method? Yes, you should still have this parameter.\n\nIn the method, I see two choices if last_error\u003dNone:\n1. don\u0027t set node.last_error, or\n2. set node.last_error \u003d something generic like \u0027A failure occurred for node \u003cnode\u003e while in state \u003cstate\u003e.\u0027","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ddc45939f332e8158bd56b9b43f5e83ef7d50db8","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1465,"context_line":"                   \u0027inspection_started_before\u0027: callback_timeout}"},{"line_number":1466,"context_line":"        sort_key \u003d \u0027inspection_started_at\u0027"},{"line_number":1467,"context_line":"        last_error \u003d _(\"timeout reached while waiting for callback\")"},{"line_number":1468,"context_line":"        self._fail_if_timeout_reached(context, filters, states.INSPECTING,"},{"line_number":1469,"context_line":"                                      sort_key, last_error\u003dlast_error)"},{"line_number":1470,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_8f1260b2","line":1467,"in_reply_to":"ba7be1f8_88c33e56","updated":"2015-03-02 19:02:27.000000000","message":"That is because I wanted _fail_if_timeout_reached to be called something generic like _fail_if_in_state(). In which case the error msg would be specific to why it would fail.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1465,"context_line":"                   \u0027inspection_started_before\u0027: callback_timeout}"},{"line_number":1466,"context_line":"        sort_key \u003d \u0027inspection_started_at\u0027"},{"line_number":1467,"context_line":"        last_error \u003d _(\"timeout reached while waiting for callback\")"},{"line_number":1468,"context_line":"        self._fail_if_timeout_reached(context, filters, states.INSPECTING,"},{"line_number":1469,"context_line":"                                      sort_key, last_error\u003dlast_error)"},{"line_number":1470,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_88c33e56","line":1467,"in_reply_to":"ba7be1f8_8da9e57d","updated":"2015-03-02 17:54:25.000000000","message":"I kept it as per Ruby\u0027s comment that the error message should be passed on as argument to _fail_if_timeout_reached().","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4e6115d77803b8f193f87fa91206cdc1864eff9c","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"                   \u0027provision_state\u0027: states.INSPECTING,"},{"line_number":1465,"context_line":"                   \u0027inspection_started_before\u0027: callback_timeout}"},{"line_number":1466,"context_line":"        sort_key \u003d \u0027inspection_started_at\u0027"},{"line_number":1467,"context_line":"        last_error \u003d _(\"timeout reached while waiting for callback\")"},{"line_number":1468,"context_line":"        self._fail_if_timeout_reached(context, filters, states.INSPECTING,"},{"line_number":1469,"context_line":"                                      sort_key, last_error\u003dlast_error)"},{"line_number":1470,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_4adbf61a","line":1467,"in_reply_to":"ba7be1f8_8f1260b2","updated":"2015-03-02 19:11:52.000000000","message":"so Ruby should i keep it after renaming the common function?","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"    def _fail_if_timeout_reached(self, context, filters, provision_state,"},{"line_number":1472,"context_line":"                                 sort_key, callback_method\u003dNone,"},{"line_number":1473,"context_line":"                                 err_handler\u003dNone, last_error\u003dNone):"},{"line_number":1474,"context_line":"        \"\"\"Checks if the async(background) process has reached timeout."},{"line_number":1475,"context_line":""},{"line_number":1476,"context_line":"        :param: context: request context"},{"line_number":1477,"context_line":"        :param: filters: criteria (as a dictionary) to get the desired"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_9350d0d5","line":1474,"updated":"2015-03-02 16:57:20.000000000","message":"How does this method know if a timeout has been reached? I don\u0027t see any code here related to dates/times?\n\nI am sad that you didn\u0027t understand my previous comments. Oh well.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4e6115d77803b8f193f87fa91206cdc1864eff9c","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"    def _fail_if_timeout_reached(self, context, filters, provision_state,"},{"line_number":1472,"context_line":"                                 sort_key, callback_method\u003dNone,"},{"line_number":1473,"context_line":"                                 err_handler\u003dNone, last_error\u003dNone):"},{"line_number":1474,"context_line":"        \"\"\"Checks if the async(background) process has reached timeout."},{"line_number":1475,"context_line":""},{"line_number":1476,"context_line":"        :param: context: request context"},{"line_number":1477,"context_line":"        :param: filters: criteria (as a dictionary) to get the desired"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_8addee16","line":1474,"in_reply_to":"ba7be1f8_2f689420","updated":"2015-03-02 19:11:52.000000000","message":"Yes. Ok will rename it. :)","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"    def _fail_if_timeout_reached(self, context, filters, provision_state,"},{"line_number":1472,"context_line":"                                 sort_key, callback_method\u003dNone,"},{"line_number":1473,"context_line":"                                 err_handler\u003dNone, last_error\u003dNone):"},{"line_number":1474,"context_line":"        \"\"\"Checks if the async(background) process has reached timeout."},{"line_number":1475,"context_line":""},{"line_number":1476,"context_line":"        :param: context: request context"},{"line_number":1477,"context_line":"        :param: filters: criteria (as a dictionary) to get the desired"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_e80f5adf","line":1474,"in_reply_to":"ba7be1f8_9350d0d5","updated":"2015-03-02 17:54:25.000000000","message":"Ruby, but the node filtering is based on timestamp, correct? isnt that relevant? I can still change the name as you suggested, but i just thought this makes more sense...","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ddc45939f332e8158bd56b9b43f5e83ef7d50db8","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"    def _fail_if_timeout_reached(self, context, filters, provision_state,"},{"line_number":1472,"context_line":"                                 sort_key, callback_method\u003dNone,"},{"line_number":1473,"context_line":"                                 err_handler\u003dNone, last_error\u003dNone):"},{"line_number":1474,"context_line":"        \"\"\"Checks if the async(background) process has reached timeout."},{"line_number":1475,"context_line":""},{"line_number":1476,"context_line":"        :param: context: request context"},{"line_number":1477,"context_line":"        :param: filters: criteria (as a dictionary) to get the desired"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_2f689420","line":1474,"in_reply_to":"ba7be1f8_e80f5adf","updated":"2015-03-02 19:02:27.000000000","message":"Nisha, if you just read this method as a stand alone method, is there enough description to give you an idea as to how timeouts are being done here?\n\nYou only know that timeouts are being done because that is how you are using this method. Except for the \u0027timeout\u0027 wordings here, this method could be used to fail on some other criteria.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1820,"context_line":"    # since there may be local persistent state"},{"line_number":1821,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1824,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_b87933fe","line":1821,"updated":"2015-03-02 16:57:20.000000000","message":"I thought you were going to remove this (see comments in revision 26). Was there a reason for having this code?","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ddc45939f332e8158bd56b9b43f5e83ef7d50db8","unresolved":false,"context_lines":[{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1820,"context_line":"    # since there may be local persistent state"},{"line_number":1821,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1824,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_caa52605","line":1821,"in_reply_to":"ba7be1f8_3e91a89a","updated":"2015-03-02 19:02:27.000000000","message":"Please, do NOT remove it from do_node_deploy. \n\nIf the conductor disappears for any reason, another conductor will take over the node. If that happens, we want to initialize the new conductor with whatever local information might be needed for handling that node. See _do_takeover(), where deploy information is being set up.\n\nI don\u0027t know if the conductor will have any local information related to the inspection process, so I think this should be removed until/if it is needed.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1820,"context_line":"    # since there may be local persistent state"},{"line_number":1821,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1824,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_3e91a89a","line":1821,"in_reply_to":"ba7be1f8_b87933fe","updated":"2015-03-02 17:54:25.000000000","message":"Actually i asked Dmitry if its needed for in-band somehow.  Secondly shouldnt this be same scenario as done in do_node_deploy()? or should we remove it from there too? (Line 1672)","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4e6115d77803b8f193f87fa91206cdc1864eff9c","unresolved":false,"context_lines":[{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    # Update conductor_affinity to reference this conductor\u0027s ID"},{"line_number":1820,"context_line":"    # since there may be local persistent state"},{"line_number":1821,"context_line":"    node.conductor_affinity \u003d conductor_id"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1824,"context_line":"        task.process_event(\u0027done\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_6aed1ab7","line":1821,"in_reply_to":"ba7be1f8_caa52605","updated":"2015-03-02 19:11:52.000000000","message":"Ok will remove from inspection.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"369780917f6248cef4999611c11534bae79d66b8","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1824,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":1825,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1826,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1827,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1828,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1829,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_0dec15c7","line":1826,"updated":"2015-02-27 12:14:02.000000000","message":"nit: s/%/,/","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"    if new_state \u003d\u003d states.MANAGEABLE:"},{"line_number":1824,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":1825,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1826,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1827,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1828,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1829,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_be2f583d","line":1826,"in_reply_to":"ba7be1f8_0dec15c7","updated":"2015-03-02 17:54:25.000000000","message":"i didnt understand this nit...:(","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1826,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1827,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1828,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1829,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1830,"context_line":"        handle_failure(error)"},{"line_number":1831,"context_line":"        raise exception.HardwareInspectionFailure(error\u003derror)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_98e0ef97","line":1828,"updated":"2015-03-02 16:57:20.000000000","message":"missing a blank space after \u0027inspection\u0027.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1825,"context_line":"        LOG.info(_LI(\u0027Successfully inspected node %(node)s\u0027)"},{"line_number":1826,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1827,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1828,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1829,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1830,"context_line":"        handle_failure(error)"},{"line_number":1831,"context_line":"        raise exception.HardwareInspectionFailure(error\u003derror)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_a804827e","line":1828,"in_reply_to":"ba7be1f8_98e0ef97","updated":"2015-03-02 17:54:25.000000000","message":"oh. :( will add","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1827,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1828,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1829,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1830,"context_line":"        handle_failure(error)"},{"line_number":1831,"context_line":"        raise exception.HardwareInspectionFailure(error\u003derror)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_78589b56","line":1829,"updated":"2015-03-02 16:57:20.000000000","message":"The way this is worded might be confusing, eg \"Driver returned unexpected state in inspection rebuild\".\n\nI suggest something like \u0027During inspection, driver returned unexpected state: \"%(state)s\"\u0027.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"                 % {\u0027node\u0027: node.uuid})"},{"line_number":1827,"context_line":"    elif new_state !\u003d states.INSPECTING:"},{"line_number":1828,"context_line":"        error \u003d (_(\"Driver returned unexpected state in inspection\""},{"line_number":1829,"context_line":"                   \"%(state)s\") % {\u0027state\u0027: new_state})"},{"line_number":1830,"context_line":"        handle_failure(error)"},{"line_number":1831,"context_line":"        raise exception.HardwareInspectionFailure(error\u003derror)"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_68db6a1b","line":1829,"in_reply_to":"ba7be1f8_78589b56","updated":"2015-03-02 17:54:25.000000000","message":"Ok will reword.","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        :param context: request context."},{"line_number":472,"context_line":"        :param node_id: node id or uuid."},{"line_number":473,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":474,"context_line":"        :raises: InstanceHardwareIntrospectionFailure"},{"line_number":475,"context_line":"        :raises: InvalidParameterValue if validation fails"},{"line_number":476,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":477,"context_line":"                 async task."}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_56b01943","line":474,"updated":"2015-02-03 13:42:57.000000000","message":"Exception name again :)","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        :param context: request context."},{"line_number":472,"context_line":"        :param node_id: node id or uuid."},{"line_number":473,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":474,"context_line":"        :raises: InstanceHardwareIntrospectionFailure"},{"line_number":475,"context_line":"        :raises: InvalidParameterValue if validation fails"},{"line_number":476,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":477,"context_line":"                 async task."}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_99f0eb68","line":474,"in_reply_to":"da86d52c_56b01943","updated":"2015-02-03 21:34:07.000000000","message":"Yes. :) will change","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4878f027ae0decdef230884384331b039a186fc4","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                 async task."},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.22\u0027)"},{"line_number":481,"context_line":"        return cctxt.call(context, \u0027inspect_hardware\u0027, node_id\u003dnode_id)"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_36464524","line":480,"updated":"2015-02-03 13:42:57.000000000","message":"Should this be 1.23?","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a1ed6ab982083cb311ad53fbf5e412efa4c3a147","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                 async task."},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.22\u0027)"},{"line_number":481,"context_line":"        return cctxt.call(context, \u0027inspect_hardware\u0027, node_id\u003dnode_id)"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_1904fb48","line":480,"in_reply_to":"da86d52c_36464524","updated":"2015-02-03 21:34:07.000000000","message":"Now this shud be 1.24","commit_id":"962a49834f125f72765e4a88b96363bc95ca94ca"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        :param context: request context."},{"line_number":492,"context_line":"        :param node_id: node id or uuid."},{"line_number":493,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":494,"context_line":"        :raises: InstanceHardwareIntrospectionFailure"},{"line_number":495,"context_line":"        :raises: InvalidParameterValue if validation fails"},{"line_number":496,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":497,"context_line":"                 async task."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_d0291b38","line":494,"updated":"2015-02-25 13:31:46.000000000","message":"I guess this is HardwareInspectionFailure.  As per the comment in conductor/manager, I don\u0027t think it can raise InvalidParameterValue now.  This should be same as  @messaging.expected_exceptions in conductor/manager.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        :param context: request context."},{"line_number":492,"context_line":"        :param node_id: node id or uuid."},{"line_number":493,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":494,"context_line":"        :raises: InstanceHardwareIntrospectionFailure"},{"line_number":495,"context_line":"        :raises: InvalidParameterValue if validation fails"},{"line_number":496,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":497,"context_line":"                 async task."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_01252708","line":494,"in_reply_to":"ba7be1f8_d0291b38","updated":"2015-02-25 14:27:14.000000000","message":"Thanks for Failure catch.\nIf it should be same as @messaging.expected_exceptions then InvalidParameterValue is expected  to be raised by validation method.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bc937a8806f13557077a228c6977733e3eb29845","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        :param node_id: node id or uuid."},{"line_number":493,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":494,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":495,"context_line":"        :raises: InstanceHardwareInspectionFailure"},{"line_number":496,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":497,"context_line":"                 async task."},{"line_number":498,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_424d2899","line":495,"updated":"2015-02-26 15:24:02.000000000","message":"s/Instance//","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"}],"ironic/db/sqlalchemy/alembic/versions/4022453f9f1d_add_inspection_started_at_and_last_.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"af5726213d4ceb8052f7590922734859c4189c84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_d5f05b00","line":1,"updated":"2015-02-24 15:58:53.000000000","message":"nit: year and company are incorrect.","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"99d9d2714a5fe2d9dd80a0a5b55aaac124198560","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_30561e07","line":1,"in_reply_to":"ba7be1f8_d5f05b00","updated":"2015-02-24 17:51:37.000000000","message":"This i copied from one of the already present db file. So the company shall be there?","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"}],"ironic/db/sqlalchemy/alembic/versions/441e0c8254ba_add_last_inspected_and_inspection_.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e7847c7e59b4034982e2ed46db9978d20aae0ee8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ### commands auto generated by Alembic - please adjust! ###"},{"line_number":19,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027inspection_started_at\u0027, sa.DateTime(), nullable\u003dTrue))"},{"line_number":20,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027last_inspected\u0027, sa.DateTime(), nullable\u003dTrue))"},{"line_number":21,"context_line":"    ### end Alembic commands ###"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_fd56d804","line":21,"updated":"2015-01-27 13:25:18.000000000","message":"Need to add a new index. See earlier comments.","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d338948e998af11fed132a52552cce515eed62b5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    ### commands auto generated by Alembic - please adjust! ###"},{"line_number":19,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027inspection_started_at\u0027, sa.DateTime(), nullable\u003dTrue))"},{"line_number":20,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027last_inspected\u0027, sa.DateTime(), nullable\u003dTrue))"},{"line_number":21,"context_line":"    ### end Alembic commands ###"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa81d914_8fdb801a","line":21,"in_reply_to":"1a930d6b_fd56d804","updated":"2015-01-28 19:55:35.000000000","message":"ok","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b410dda14f991be4ad66ca7b50023214cd4006f1","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            limit \u003d timeutils.utcnow() - datetime.timedelta("},{"line_number":190,"context_line":"                                         seconds\u003dfilters[\u0027provisioned_before\u0027])"},{"line_number":191,"context_line":"            query \u003d query.filter(models.Node.provision_updated_at \u003c limit)"},{"line_number":192,"context_line":"        if \u0027inspection_started_at\u0027 in filters:"},{"line_number":193,"context_line":"            limit \u003d timeutils.utcnow() - datetime.timedelta("},{"line_number":194,"context_line":"                                         seconds\u003dfilters[\u0027inspection_started_at\u0027])"},{"line_number":195,"context_line":"            query \u003d query.filter(models.Node.inspection_started_at \u003c limit)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_fbe0b7ce","line":192,"updated":"2015-02-05 12:03:06.000000000","message":"s/inspection_started_at/inspection_started_before/","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b410dda14f991be4ad66ca7b50023214cd4006f1","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            if \u0027inspection_started_at\u0027 in values:"},{"line_number":361,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":362,"context_line":"            if \u0027last_inspected\u0027 in values:"},{"line_number":363,"context_line":"                values[\u0027last_inspected\u0027] \u003d timeutils.utcnow()"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"            ref.update(values)"},{"line_number":366,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_9b3dfb2d","line":363,"updated":"2015-02-05 12:03:06.000000000","message":"that does not look correct. you should not change these values, if they\u0027re provided. you likely wanted:\n\n if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECT:\n   values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()\n\nI though that last_inspected should be updated (and inspection_started_at cleared) after inspection is finished by the driver","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8342601adfe4e5f2b14e96e5097ec477091baf11","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d None"},{"line_number":368,"context_line":"            if ((values.get(\u0027provision_state\u0027) !\u003d states.INSPECTING) and"},{"line_number":369,"context_line":"                 values.get(\u0027target_provision_state\u0027) \u003d\u003d states.INSPECTED):"},{"line_number":370,"context_line":"                    values[\u0027target_provision_state\u0027] \u003d None"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"            ref.update(values)"},{"line_number":373,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_86786dc5","line":370,"updated":"2015-02-11 11:54:45.000000000","message":"I don\u0027t understand why you need all this stuff. All you need should be\n\n if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:\n   values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()\n elif values.get(\u0027provision_state\u0027) in (states.INSPECTED, states.INSPECTFAIL):\n   values[\u0027inspection_started_at\u0027] \u003d None","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"882175b1d871ab37dffacd976ee24420f4f5f5be","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d None"},{"line_number":368,"context_line":"            if ((values.get(\u0027provision_state\u0027) !\u003d states.INSPECTING) and"},{"line_number":369,"context_line":"                 values.get(\u0027target_provision_state\u0027) \u003d\u003d states.INSPECTED):"},{"line_number":370,"context_line":"                    values[\u0027target_provision_state\u0027] \u003d None"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"            ref.update(values)"},{"line_number":373,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_89a4fea6","line":370,"in_reply_to":"da86d52c_86786dc5","updated":"2015-02-11 12:20:07.000000000","message":"Ok. I will change it.","commit_id":"359c858b968bdf2e0a01f91c5a1729d63cbf6d52"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"272f8b8c2e50778d7ff76cc9cf5f0caecfeb1106","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":379,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":380,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            ref.update(values)"},{"line_number":383,"context_line":"        return ref"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_94a57a06","line":381,"updated":"2015-02-20 12:22:23.000000000","message":"here:\n\n if ref.provision_state \u003d\u003d states.INSPECTING and values.get(\u0027provision_state\u0027) \u003d\u003d states.MANAGEABLE:\n   values[\u0027last_inspected\u0027] \u003d timeutils.utcnow()","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e578c2915c54a81040f52339c64404028006ab85","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":379,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":380,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            ref.update(values)"},{"line_number":383,"context_line":"        return ref"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_d9171ba2","line":381,"in_reply_to":"ba7be1f8_6de75141","updated":"2015-02-20 18:44:26.000000000","message":"just to clarify: I meant to add these lines, not replace what you\u0027re already adding.\n\nIt looks handy to update last_inspected here one state transition, why not? Will allow us to have less copy-pasted code.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":379,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":380,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            ref.update(values)"},{"line_number":383,"context_line":"        return ref"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_6de75141","line":381,"in_reply_to":"ba7be1f8_94a57a06","updated":"2015-02-20 17:24:02.000000000","message":"This is required to updated the inspection_started_at when inspection has just started. The suggestion provided looks like updation for the last_inspected when inspection has finished.\nThe last_inspected is updated by the driver after successful inspection.\nLet me know if you feel otherwise on this.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"307162a8c6c9ccea4dbee0afe96c425c6a8c12cf","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":379,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":380,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            ref.update(values)"},{"line_number":383,"context_line":"        return ref"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_abccce36","line":381,"in_reply_to":"ba7be1f8_d9171ba2","updated":"2015-02-20 19:15:43.000000000","message":"Ok i removed it from here after removal of INSPECTED state. I was confused about consequences of updating the field when provision_state is MANAGEABLE as the noe can be in manageable state with cleaning/deleting also.\n\nI will check the suggestion and honor the comment if it works only in case of INSPECTION, because updating based on  MANAGEABLE is little ambiguous here. If the same code can cause the node.last_inspected to be updated even if inspection is not issued, then i will not add it here.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":381,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":382,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_f557d8c7","line":380,"updated":"2015-02-25 23:07:08.000000000","message":"Maybe this is a nit, but the above if already checks if \u0027provision_state\u0027 in values, so why not put this as part of the above? Ie, indent this one more level and\n               if values[\u0027provision_state\u0027] \u003d\u003d states.INSPECTING...\n\nNow that I am looking at this code. We have a \u0027provision_updated_at\u0027 field already. Can\u0027t you use that instead of \u0027inspection_started_it\u0027? I think Dmitry would say \u0027no\u0027 because if I recall correctly, he wants to do inspection while the node is in a non-INSPECT provision state. hmm.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76c9bd8194ebbf1302595fae86c0757671743e43","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":381,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":382,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_c36f5a29","line":380,"in_reply_to":"ba7be1f8_3cb86d29","updated":"2015-02-26 16:19:49.000000000","message":"well, if inspection is all done while a node is in INSPECTING state, and if provision_updated_at is updated (and always equal to inspection_started_at), then your inspection code could use provision_updated_at.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"366e70a98b8f03ffbad4e2c9ce5d453b68fb562f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":381,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":382,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_02e15e9a","line":380,"in_reply_to":"ba7be1f8_5f409606","updated":"2015-02-26 21:58:38.000000000","message":"Don\u0027t remove it, it is in the spec and Dmitry would probably kill me.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"94a2c8099c5b86da1475ff0585f2610323762060","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":381,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":382,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_5f409606","line":380,"in_reply_to":"ba7be1f8_c36f5a29","updated":"2015-02-26 20:27:38.000000000","message":"Ytes, but i remember during spec review Dmitry wasnt in favor of using provision_updated_at as he required the new field to be used for timeout calculation.  \nI am not sure if we can use the same field \"provison_updated_at\" for both inspect_timeout and deploy_callback_timeout. I think we cannot use \u0027provision_updated_at\u0027 for both as timeout calculation is a periodic task and will be run for both at the same time. may be i am wrong.\n\nCan we first discuss if its ok to remove inspection_started_at before we actually remove it from code?","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"            if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":381,"context_line":"                values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":382,"context_line":"                values[\u0027last_inspected\u0027] \u003d None"},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_3cb86d29","line":380,"in_reply_to":"ba7be1f8_f557d8c7","updated":"2015-02-26 10:45:37.000000000","message":"We cant use the \"provision_updated_at\" field because this field is updated for any state transitions, while inspection_started_at and last_inspected are for inspection alone.\n\nRegarding the suggested code, i think it should be doable. but will need to test... will do as suggested for this if it works. :)","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":"                if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":380,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":381,"context_line":"                    values[\u0027last_inspected\u0027] \u003d None"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_63c22eea","line":379,"updated":"2015-02-26 16:20:06.000000000","message":"nit: at this point we know that provision_state exists, so it is clearer if you do values[\u0027provision_state\u0027].","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":"                if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":380,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":381,"context_line":"                    values[\u0027last_inspected\u0027] \u003d None"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_2b3565f7","line":379,"in_reply_to":"ba7be1f8_63c22eea","updated":"2015-02-26 20:28:07.000000000","message":"ok.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":"                if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":380,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":381,"context_line":"                    values[\u0027last_inspected\u0027] \u003d None"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_63f4ee5a","line":380,"updated":"2015-02-26 16:20:06.000000000","message":"yeah, see what I mean. same date/time as provision_updated_at. The only question is whether you\u0027d need this date/time still, after provision_updated_at gets changed.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f13a7f9ccaadc820c47cee6464ab01249c00ec3b","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":"                if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":380,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":381,"context_line":"                    values[\u0027last_inspected\u0027] \u003d None"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_62b5ba7d","line":380,"in_reply_to":"ba7be1f8_0e818f4d","updated":"2015-02-26 21:59:04.000000000","message":"If you didn\u0027t need this value for db filtering (time-outs), I\u0027d say put it in driver_internal_info, but anyway. Just leave it.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            if \u0027provision_state\u0027 in values:"},{"line_number":378,"context_line":"                values[\u0027provision_updated_at\u0027] \u003d timeutils.utcnow()"},{"line_number":379,"context_line":"                if values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTING:"},{"line_number":380,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d timeutils.utcnow()"},{"line_number":381,"context_line":"                    values[\u0027last_inspected\u0027] \u003d None"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"            if (ref.provision_state \u003d\u003d states.INSPECTING and"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_0e818f4d","line":380,"in_reply_to":"ba7be1f8_63f4ee5a","updated":"2015-02-26 20:28:07.000000000","message":"No we dont need this time after provision_updated_at has changed","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"71534ebae05c7e3995bcd2f19a2014a61a52ed7f","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d None"},{"line_number":387,"context_line":"            elif (ref.provision_state \u003d\u003d states.INSPECTING and"},{"line_number":388,"context_line":"                    values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTFAIL):"},{"line_number":389,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d None"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"            ref.update(values)"},{"line_number":392,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_f382ecfe","line":389,"updated":"2015-03-02 16:57:20.000000000","message":"nit: these could be indented under the \"if \u0027provision_state\u0027 in values:\" (line 377 above)","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"12a6fcd7940deb888ae8f45b48d0e1a0696d2959","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d None"},{"line_number":387,"context_line":"            elif (ref.provision_state \u003d\u003d states.INSPECTING and"},{"line_number":388,"context_line":"                    values.get(\u0027provision_state\u0027) \u003d\u003d states.INSPECTFAIL):"},{"line_number":389,"context_line":"                    values[\u0027inspection_started_at\u0027] \u003d None"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"            ref.update(values)"},{"line_number":392,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba7be1f8_deab2c87","line":389,"in_reply_to":"ba7be1f8_f382ecfe","updated":"2015-03-02 17:54:25.000000000","message":":) ok will improve in followup patch","commit_id":"6ecee36865a5ee49c162b20734aec5d4a146f9af"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"            # Retrieve the mandatory properties from above data"},{"line_number":66,"context_line":"            properties, macs \u003d self._mandatory_properties(health_data)"},{"line_number":67,"context_line":"            for key, val in properties.iteritems():"},{"line_number":68,"context_line":"                if val is None:"},{"line_number":69,"context_line":"                    state \u003d states.INSPECTFAIL"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7f0dbbe7","line":67,"updated":"2015-01-26 09:17:24.000000000","message":"s/iteritems/items/ (for Py3k compatibility)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                if val is None:"},{"line_number":69,"context_line":"                    state \u003d states.INSPECTFAIL"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"            if state !\u003d states.INSPECTFAIL:"},{"line_number":72,"context_line":"                task.node.properties \u003d properties"},{"line_number":73,"context_line":"                task.node.save()"},{"line_number":74,"context_line":"                if macs is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_5f339faa","line":71,"updated":"2015-01-26 09:17:24.000000000","message":"local variable state may be uninitialized here, only initialized on line 69 as far as I can see","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":82,"context_line":"                                              error\u003dilo_exception)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        LOG.debug((\"Node %s introspected.\") % task.node.uuid)"},{"line_number":85,"context_line":"        return state"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _delete_ports(self, macs, node_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_df1eaf0b","line":84,"updated":"2015-01-26 09:17:24.000000000","message":"s/%/,/","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        sql_dbapi\u003ddbapi.Connection()"},{"line_number":89,"context_line":"        list_ports \u003d sql_dbapi.get_ports_by_node_id(node_id)"},{"line_number":90,"context_line":"        for item in list_ports:"},{"line_number":91,"context_line":"            for key, val in item.iteritems():"},{"line_number":92,"context_line":"                if key \u003d\u003d \u0027uuid\u0027:"},{"line_number":93,"context_line":"                    port_uuid \u003d val"},{"line_number":94,"context_line":"                if key \u003d\u003d \u0027address\u0027 and val not in macs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_ff69ab8c","line":91,"updated":"2015-01-26 09:17:24.000000000","message":"s/iteritems/items/ (for Py3k compatibility)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                if key \u003d\u003d \u0027uuid\u0027:"},{"line_number":93,"context_line":"                    port_uuid \u003d val"},{"line_number":94,"context_line":"                if key \u003d\u003d \u0027address\u0027 and val not in macs:"},{"line_number":95,"context_line":"                    sql_dbapi.destory_port(port_uuid)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _create_ports(self, macs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_9fe0a7fb","line":95,"updated":"2015-01-26 09:17:24.000000000","message":"this all is something like\n\n if item[\u0027address\u0027] not in macs:\n   sql_dbapi.destroy_port(item[\u0027uuid\u0027])","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                port_dict \u003d {\u0027address\u0027 : mac, \u0027node_id\u0027 : node_id }"},{"line_number":103,"context_line":"                sql_dbapi.create_port(port_dict)"},{"line_number":104,"context_line":"            except:"},{"line_number":105,"context_line":"                continue"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _mandatory_properties(self, data):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1fc3d757","line":105,"updated":"2015-01-26 09:17:24.000000000","message":"ouch, please no except: continue in Ironic :)\n\n1. please catch Exception class or even database error specifically\n\n2. please log the failure\n\n3. if I remember the spec correctly, inspection should fail in this case","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            memory \u003d data[\u0027GET_EMBEDDED_HEALTH_DATA\u0027][\u0027MEMORY\u0027][\u0027MEMORY_DETAILS_SUMMARY\u0027]"},{"line_number":111,"context_line":"            memory_mb \u003d0"},{"line_number":112,"context_line":"            for key, val in memory.iteritems():"},{"line_number":113,"context_line":"                memsize \u003d val[\u0027TOTAL_MEMORY_SIZE\u0027][\u0027VALUE\u0027]"},{"line_number":114,"context_line":"                if memsize !\u003d \u0027N/A\u0027:"},{"line_number":115,"context_line":"                    mem \u003d memsize.split(\u0027 \u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7fa93b8f","line":112,"updated":"2015-01-26 09:17:24.000000000","message":"ditto about iteritems()","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    unit \u003d mem[1]"},{"line_number":118,"context_line":"            if unit \u003d\u003d \u0027GB\u0027:"},{"line_number":119,"context_line":"                memory_mb \u003d memory_mb * 1024"},{"line_number":120,"context_line":"        except:"},{"line_number":121,"context_line":"            memory_mb\u003d0"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_bf96434a","line":120,"updated":"2015-01-26 09:17:24.000000000","message":"please don\u0027t catch any exception, if you don\u0027t know which exceptions to catch","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            if unit \u003d\u003d \u0027GB\u0027:"},{"line_number":119,"context_line":"                memory_mb \u003d memory_mb * 1024"},{"line_number":120,"context_line":"        except:"},{"line_number":121,"context_line":"            memory_mb\u003d0"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            processor \u003d data[\u0027GET_EMBEDDED_HEALTH_DATA\u0027][\u0027PROCESSORS\u0027][\u0027PROCESSOR\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_df7a2f23","line":121,"updated":"2015-01-26 09:17:24.000000000","message":"memory_mb \u003d 0 is a bad default, better not set it at all (though IIRC we agreed on failing inspection in this case)","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                cpu_arch \u003d cpu_arch + \u0027x86\u0027"},{"line_number":133,"context_line":"            if \u002764-bit\u0027 in tech:"},{"line_number":134,"context_line":"                cpu_arch \u003d cpu_arch + \u0027_64\u0027"},{"line_number":135,"context_line":"        except:"},{"line_number":136,"context_line":"            cpu_arch \u003d \u0027\u0027"},{"line_number":137,"context_line":"            cpus \u003d 0"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_1f711744","line":135,"updated":"2015-01-26 09:17:24.000000000","message":"ditto about catching exception here and below","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                cpu_arch \u003d cpu_arch + \u0027_64\u0027"},{"line_number":135,"context_line":"        except:"},{"line_number":136,"context_line":"            cpu_arch \u003d \u0027\u0027"},{"line_number":137,"context_line":"            cpus \u003d 0"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            storage \u003d data[\u0027GET_EMBEDDED_HEALTH_DATA\u0027][\u0027STORAGE\u0027][\u0027CONTROLLER\u0027][\u0027LOGICAL_DRIVE\u0027][\u0027PHYSICAL_DRIVE\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_7f977b3a","line":137,"updated":"2015-01-26 09:17:24.000000000","message":"ditto about defaults here and below","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d58d804fca55c04029e1d57e4d50ba3e3033eda","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        except:"},{"line_number":165,"context_line":"            macs\u003d[]"},{"line_number":166,"context_line":"        return properties , macs"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_9f5b47f5","line":167,"updated":"2015-01-26 09:17:24.000000000","message":"As I suggested in previous patch, let us split away the ILO implementation, otherwise it\u0027s pretty hard to review..","commit_id":"234a6341d5064195a63a485bce30733921ccf2df"}],"ironic/objects/node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d08f9d1c0193b90950746fda1ba09db1bbca477f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            # Any error from the most recent (last) asynchronous transaction"},{"line_number":79,"context_line":"            # that started but failed to finish."},{"line_number":80,"context_line":"            \u0027last_error\u0027: obj_utils.str_or_none,"},{"line_number":81,"context_line":"            \u0027last_inspected\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":82,"context_line":"            \u0027inspection_started_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            \u0027extra\u0027: obj_utils.dict_or_none,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_756128d2","line":81,"updated":"2015-02-25 23:07:08.000000000","message":"There ought to be a blank line before this. Otherwise, it looks like last_inspected and inspection_started_at are used for errors.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6d51c7adae277bd295597cc9afa276028795816b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            # Any error from the most recent (last) asynchronous transaction"},{"line_number":79,"context_line":"            # that started but failed to finish."},{"line_number":80,"context_line":"            \u0027last_error\u0027: obj_utils.str_or_none,"},{"line_number":81,"context_line":"            \u0027last_inspected\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":82,"context_line":"            \u0027inspection_started_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            \u0027extra\u0027: obj_utils.dict_or_none,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_1c948989","line":81,"in_reply_to":"ba7be1f8_756128d2","updated":"2015-02-26 10:45:37.000000000","message":"ok.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bb4e5c1d4e3a69071ee7ada4eedf2ae15ffd00c1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            # Any error from the most recent (last) asynchronous transaction"},{"line_number":79,"context_line":"            # that started but failed to finish."},{"line_number":80,"context_line":"            \u0027last_error\u0027: obj_utils.str_or_none,"},{"line_number":81,"context_line":"            \u0027last_inspected\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":82,"context_line":"            \u0027inspection_started_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            \u0027extra\u0027: obj_utils.dict_or_none,"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_0357b226","line":81,"updated":"2015-02-26 16:20:06.000000000","message":"blank line before this?","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3f14dbeb53fd3c91e9e186cb698da306b981b521","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            # Any error from the most recent (last) asynchronous transaction"},{"line_number":79,"context_line":"            # that started but failed to finish."},{"line_number":80,"context_line":"            \u0027last_error\u0027: obj_utils.str_or_none,"},{"line_number":81,"context_line":"            \u0027last_inspected\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":82,"context_line":"            \u0027inspection_started_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            \u0027extra\u0027: obj_utils.dict_or_none,"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_2e2f33f8","line":81,"in_reply_to":"ba7be1f8_0357b226","updated":"2015-02-26 20:28:07.000000000","message":"ok removed a","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"}],"ironic/tests/api/v1/test_nodes.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ce33192f8e5bbfb3024cc96639d7518a0e20ce56","unresolved":false,"context_lines":[{"line_number":1486,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027update_node\u0027)"},{"line_number":1487,"context_line":"    def test_set_node_maintenance_mode_no_reason(self, mock_update, mock_get):"},{"line_number":1488,"context_line":"        self._test_set_node_maintenance_mode(mock_update, mock_get, None)"},{"line_number":1489,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_d20a1125","line":1489,"updated":"2015-02-04 20:51:26.000000000","message":"nit: line added","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8b917800978a004b6a7982c3641c5dc9400398ad","unresolved":false,"context_lines":[{"line_number":1486,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027update_node\u0027)"},{"line_number":1487,"context_line":"    def test_set_node_maintenance_mode_no_reason(self, mock_update, mock_get):"},{"line_number":1488,"context_line":"        self._test_set_node_maintenance_mode(mock_update, mock_get, None)"},{"line_number":1489,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_62eb4513","line":1489,"in_reply_to":"da86d52c_d20a1125","updated":"2015-02-05 04:12:53.000000000","message":"will remove","commit_id":"eae312d194c96e17a4cb0008750aa0ab15e4aa17"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"59b7c829adda6f7ac6725be4436e5b634a98b448","unresolved":false,"context_lines":[{"line_number":3013,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3014,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3017,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"},{"line_number":3018,"context_line":"        self._start_service()"},{"line_number":3019,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_30dbf31c","line":3016,"updated":"2015-02-20 15:32:47.000000000","message":"nit - better use mock.patch.object to be consistent with other tests added.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":3013,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3014,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3017,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"},{"line_number":3018,"context_line":"        self._start_service()"},{"line_number":3019,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_4d51ad61","line":3016,"in_reply_to":"ba7be1f8_30dbf31c","updated":"2015-02-20 17:24:02.000000000","message":"ok.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"5f503a3d7c240ed803441072d5b8edb70ac9e444","unresolved":false,"context_lines":[{"line_number":3013,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3014,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3017,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"},{"line_number":3018,"context_line":"        self._start_service()"},{"line_number":3019,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_d696ec93","line":3016,"in_reply_to":"ba7be1f8_4d51ad61","updated":"2015-02-22 18:10:10.000000000","message":"i tried the suggestion and it fails with error\n\"ironic.drivers.modules.fake.FakeInspect does not have the attribute \u0027inspect_hardware\u0027\". Anyway deploy also have the mock defined in the similar fashion so it shall be fine. So for now i havent changed anything in this.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"59b7c829adda6f7ac6725be4436e5b634a98b448","unresolved":false,"context_lines":[{"line_number":3029,"context_line":""},{"line_number":3030,"context_line":"    def test__check_inspect_timeouts(self):"},{"line_number":3031,"context_line":"        self._start_service()"},{"line_number":3032,"context_line":"        CONF.set_override(\u0027inspect_timeout\u0027, 1, group\u003d\u0027conductor\u0027)"},{"line_number":3033,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3034,"context_line":"                provision_state\u003dstates.INSPECTING,"},{"line_number":3035,"context_line":"                target_provision_state\u003dstates.MANAGEABLE,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_90c1ffe6","line":3032,"updated":"2015-02-20 15:32:47.000000000","message":"could also use self.config here.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"668142e9c8ee14a8d5cef59ab2a3c1e8ccdc1077","unresolved":false,"context_lines":[{"line_number":3029,"context_line":""},{"line_number":3030,"context_line":"    def test__check_inspect_timeouts(self):"},{"line_number":3031,"context_line":"        self._start_service()"},{"line_number":3032,"context_line":"        CONF.set_override(\u0027inspect_timeout\u0027, 1, group\u003d\u0027conductor\u0027)"},{"line_number":3033,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3034,"context_line":"                provision_state\u003dstates.INSPECTING,"},{"line_number":3035,"context_line":"                target_provision_state\u003dstates.MANAGEABLE,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba7be1f8_ad95c9e5","line":3032,"in_reply_to":"ba7be1f8_90c1ffe6","updated":"2015-02-20 17:24:02.000000000","message":"ok, agreed. But the above is also not wrong. I used it similar to what is there for deploy.","commit_id":"5725912a54e0c303852a1e3ed9f917fba50f5dcd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"413a3cc25ede059ce73248b2df509e38099c9b7f","unresolved":false,"context_lines":[{"line_number":3011,"context_line":""},{"line_number":3012,"context_line":"@_mock_record_keepalive"},{"line_number":3013,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3014,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3017,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_19cf9e80","line":3014,"updated":"2015-02-24 10:25:56.000000000","message":"nit: indentation","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"383ca0174ce983f4509d2394fd67a0665315f68b","unresolved":false,"context_lines":[{"line_number":3011,"context_line":""},{"line_number":3012,"context_line":"@_mock_record_keepalive"},{"line_number":3013,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3014,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3015,"context_line":""},{"line_number":3016,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3017,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_782fb188","line":3014,"in_reply_to":"ba7be1f8_19cf9e80","updated":"2015-02-24 11:54:32.000000000","message":"ok.","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"413a3cc25ede059ce73248b2df509e38099c9b7f","unresolved":false,"context_lines":[{"line_number":3108,"context_line":"        self.assertEqual(states.MANAGEABLE, node.target_provision_state)"},{"line_number":3109,"context_line":"        self.assertIsNotNone(node.last_error)"},{"line_number":3110,"context_line":"        self.assertTrue(mock_inspect.called)"},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":""},{"line_number":3113,"context_line":"@mock.patch.object(task_manager, \u0027acquire\u0027)"},{"line_number":3114,"context_line":"@mock.patch.object(manager.ConductorManager, \u0027_mapped_to_this_conductor\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_d9ac26a3","line":3111,"updated":"2015-02-24 10:25:56.000000000","message":"please add tests on inspect_hardware() returning: 1. INSPECTING; 2. unexpected state","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"383ca0174ce983f4509d2394fd67a0665315f68b","unresolved":false,"context_lines":[{"line_number":3108,"context_line":"        self.assertEqual(states.MANAGEABLE, node.target_provision_state)"},{"line_number":3109,"context_line":"        self.assertIsNotNone(node.last_error)"},{"line_number":3110,"context_line":"        self.assertTrue(mock_inspect.called)"},{"line_number":3111,"context_line":""},{"line_number":3112,"context_line":""},{"line_number":3113,"context_line":"@mock.patch.object(task_manager, \u0027acquire\u0027)"},{"line_number":3114,"context_line":"@mock.patch.object(manager.ConductorManager, \u0027_mapped_to_this_conductor\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_9828e587","line":3111,"in_reply_to":"ba7be1f8_d9ac26a3","updated":"2015-02-24 11:54:32.000000000","message":"ok","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ea8fef5700e4eb543f9ef6bcf86092afa2713de5","unresolved":false,"context_lines":[{"line_number":3012,"context_line":""},{"line_number":3013,"context_line":""},{"line_number":3014,"context_line":"@_mock_record_keepalive"},{"line_number":3015,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3016,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3017,"context_line":""},{"line_number":3018,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_10f7338c","line":3015,"updated":"2015-02-25 13:31:46.000000000","message":"nit: indentation.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":3012,"context_line":""},{"line_number":3013,"context_line":""},{"line_number":3014,"context_line":"@_mock_record_keepalive"},{"line_number":3015,"context_line":"class NodeInspectHardware(_ServiceSetUpMixin,"},{"line_number":3016,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3017,"context_line":""},{"line_number":3018,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_016c4734","line":3015,"in_reply_to":"ba7be1f8_10f7338c","updated":"2015-02-25 14:27:14.000000000","message":"k","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87c823c700a1da552ccaecaeaa5cea67e67c4bd7","unresolved":false,"context_lines":[{"line_number":3367,"context_line":"        self.assertEqual([mock.call(self.node.uuid, self.node.driver)] * 2,"},{"line_number":3368,"context_line":"                         mapped_mock.call_args_list)"},{"line_number":3369,"context_line":"        self.assertEqual([mock.call(self.context, self.node.uuid)] * 2,"},{"line_number":3370,"context_line":"                         acquire_mock.call_args_list)"},{"line_number":3371,"context_line":"        process_event_call \u003d mock.call("},{"line_number":3372,"context_line":"                \u0027fail\u0027,"},{"line_number":3373,"context_line":"                callback\u003dself.service._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_81f037ff","line":3370,"updated":"2015-02-25 14:20:14.000000000","message":"You can use call_count for that\n\n self.assertEqual(2, mapped_mock.call_count)\n self.assertEqual(2, acquire_mock.call_count)","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"104e0d195fb165692d0dfc7209a7ea45a21af831","unresolved":false,"context_lines":[{"line_number":3367,"context_line":"        self.assertEqual([mock.call(self.node.uuid, self.node.driver)] * 2,"},{"line_number":3368,"context_line":"                         mapped_mock.call_args_list)"},{"line_number":3369,"context_line":"        self.assertEqual([mock.call(self.context, self.node.uuid)] * 2,"},{"line_number":3370,"context_line":"                         acquire_mock.call_args_list)"},{"line_number":3371,"context_line":"        process_event_call \u003d mock.call("},{"line_number":3372,"context_line":"                \u0027fail\u0027,"},{"line_number":3373,"context_line":"                callback\u003dself.service._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_b77f3965","line":3370,"in_reply_to":"ba7be1f8_1c8e6c79","updated":"2015-02-25 14:53:15.000000000","message":"i agree with John","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":3367,"context_line":"        self.assertEqual([mock.call(self.node.uuid, self.node.driver)] * 2,"},{"line_number":3368,"context_line":"                         mapped_mock.call_args_list)"},{"line_number":3369,"context_line":"        self.assertEqual([mock.call(self.context, self.node.uuid)] * 2,"},{"line_number":3370,"context_line":"                         acquire_mock.call_args_list)"},{"line_number":3371,"context_line":"        process_event_call \u003d mock.call("},{"line_number":3372,"context_line":"                \u0027fail\u0027,"},{"line_number":3373,"context_line":"                callback\u003dself.service._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_81f59758","line":3370,"in_reply_to":"ba7be1f8_81f037ff","updated":"2015-02-25 14:27:14.000000000","message":"Agreed, but i kept the test case same as for deploy.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ac3d061427b749915b8f76264516f645f31f487c","unresolved":false,"context_lines":[{"line_number":3367,"context_line":"        self.assertEqual([mock.call(self.node.uuid, self.node.driver)] * 2,"},{"line_number":3368,"context_line":"                         mapped_mock.call_args_list)"},{"line_number":3369,"context_line":"        self.assertEqual([mock.call(self.context, self.node.uuid)] * 2,"},{"line_number":3370,"context_line":"                         acquire_mock.call_args_list)"},{"line_number":3371,"context_line":"        process_event_call \u003d mock.call("},{"line_number":3372,"context_line":"                \u0027fail\u0027,"},{"line_number":3373,"context_line":"                callback\u003dself.service._spawn_worker,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_1c8e6c79","line":3370,"in_reply_to":"ba7be1f8_81f037ff","updated":"2015-02-25 14:31:26.000000000","message":"But that doesn\u0027t check the arguments that were passed to the call.  Only that the call was called twice.","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"87c823c700a1da552ccaecaeaa5cea67e67c4bd7","unresolved":false,"context_lines":[{"line_number":3374,"context_line":"                call_args\u003d(conductor_utils.cleanup_after_timeout, self.task),"},{"line_number":3375,"context_line":"                err_handler\u003dmanager.provisioning_error_handler)"},{"line_number":3376,"context_line":"        self.assertEqual([process_event_call] * 2,"},{"line_number":3377,"context_line":"                         self.task.process_event.call_args_list)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_21e5cb37","line":3377,"updated":"2015-02-25 14:20:14.000000000","message":"ditto","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ea5c44c3c2260c7c99a81264f73eaecb248ae0fa","unresolved":false,"context_lines":[{"line_number":3374,"context_line":"                call_args\u003d(conductor_utils.cleanup_after_timeout, self.task),"},{"line_number":3375,"context_line":"                err_handler\u003dmanager.provisioning_error_handler)"},{"line_number":3376,"context_line":"        self.assertEqual([process_event_call] * 2,"},{"line_number":3377,"context_line":"                         self.task.process_event.call_args_list)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba7be1f8_21fa2b43","line":3377,"in_reply_to":"ba7be1f8_21e5cb37","updated":"2015-02-25 14:27:14.000000000","message":"ditto","commit_id":"6920c65b7f5e9e3ac7606fbc578fb0dec77a9932"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":3016,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3017,"context_line":""},{"line_number":3018,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3019,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"},{"line_number":3020,"context_line":"        self._start_service()"},{"line_number":3021,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3022,"context_line":"                                          provision_state\u003dstates.INSPECTING)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_923775fe","line":3019,"updated":"2015-02-26 13:10:24.000000000","message":"rename to test__do_inspect_hardware","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":3016,"context_line":"                                   tests_db_base.DbTestCase):"},{"line_number":3017,"context_line":""},{"line_number":3018,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3019,"context_line":"    def test_inspect_hardware_ok(self, mock_inspect):"},{"line_number":3020,"context_line":"        self._start_service()"},{"line_number":3021,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3022,"context_line":"                                          provision_state\u003dstates.INSPECTING)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_43e0cacc","line":3019,"in_reply_to":"ba7be1f8_923775fe","updated":"2015-02-26 16:13:57.000000000","message":"done","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":3030,"context_line":"        mock_inspect.assert_called_once_with(mock.ANY)"},{"line_number":3031,"context_line":""},{"line_number":3032,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3033,"context_line":"    def test_inspect_hardware_return_inspecting(self, mock_inspect):"},{"line_number":3034,"context_line":"        self._start_service()"},{"line_number":3035,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3036,"context_line":"                                          provision_state\u003dstates.INSPECTING)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_b23ab9e4","line":3033,"updated":"2015-02-26 13:10:24.000000000","message":"test__do_inspect_hardware","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":3030,"context_line":"        mock_inspect.assert_called_once_with(mock.ANY)"},{"line_number":3031,"context_line":""},{"line_number":3032,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3033,"context_line":"    def test_inspect_hardware_return_inspecting(self, mock_inspect):"},{"line_number":3034,"context_line":"        self._start_service()"},{"line_number":3035,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3036,"context_line":"                                          provision_state\u003dstates.INSPECTING)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_63e30ed9","line":3033,"in_reply_to":"ba7be1f8_b23ab9e4","updated":"2015-02-26 16:13:57.000000000","message":"done","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":3045,"context_line":""},{"line_number":3046,"context_line":"    @mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":3047,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3048,"context_line":"    def test_inspect_hardware_return_other_state(self, mock_inspect, log_mock):"},{"line_number":3049,"context_line":"        self._start_service()"},{"line_number":3050,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3051,"context_line":"                                          provision_state\u003dstates.INSPECTING)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_f227d1c7","line":3048,"updated":"2015-02-26 13:10:24.000000000","message":"test__do_inspect_hardware","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":3045,"context_line":""},{"line_number":3046,"context_line":"    @mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":3047,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeInspect.inspect_hardware\u0027)"},{"line_number":3048,"context_line":"    def test_inspect_hardware_return_other_state(self, mock_inspect, log_mock):"},{"line_number":3049,"context_line":"        self._start_service()"},{"line_number":3050,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":3051,"context_line":"                                          provision_state\u003dstates.INSPECTING)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_23c2f652","line":3048,"in_reply_to":"ba7be1f8_f227d1c7","updated":"2015-02-26 16:13:57.000000000","message":"done.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cb16b7ee5927cc6335ef7cef2668214a7a412604","unresolved":false,"context_lines":[{"line_number":3173,"context_line":"                columns\u003dself.columns, filters\u003dself.filters,"},{"line_number":3174,"context_line":"                sort_key\u003d\u0027inspection_started_at\u0027)"},{"line_number":3175,"context_line":""},{"line_number":3176,"context_line":"    def test_disabled_for_inspect(self, get_nodeinfo_mock, mapped_mock,"},{"line_number":3177,"context_line":"                      acquire_mock):"},{"line_number":3178,"context_line":"        self.config(inspect_timeout\u003d0, group\u003d\u0027conductor\u0027)"},{"line_number":3179,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_0d660aed","line":3176,"updated":"2015-02-26 13:10:24.000000000","message":"test__check_inspect_timeouts, ditto for all other tests.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6510733ed4ab81a03ac32554870ab7ef763690ba","unresolved":false,"context_lines":[{"line_number":3173,"context_line":"                columns\u003dself.columns, filters\u003dself.filters,"},{"line_number":3174,"context_line":"                sort_key\u003d\u0027inspection_started_at\u0027)"},{"line_number":3175,"context_line":""},{"line_number":3176,"context_line":"    def test_disabled_for_inspect(self, get_nodeinfo_mock, mapped_mock,"},{"line_number":3177,"context_line":"                      acquire_mock):"},{"line_number":3178,"context_line":"        self.config(inspect_timeout\u003d0, group\u003d\u0027conductor\u0027)"},{"line_number":3179,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba7be1f8_c3ccba6c","line":3176,"in_reply_to":"ba7be1f8_0d660aed","updated":"2015-02-26 16:13:57.000000000","message":"i have done it but then arguments doesnt fit in \u003c 80 character line and have to be doe as done in next patch.","commit_id":"35069d03d4382ca907103e61b56d94e0679387c0"}],"ironic/tests/db/test_nodes.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9d3bf2c75e75a09708de7785f5f81fe41c9ee90d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def test_get_nodeinfo_list_inspection(self, mock_utcnow):"},{"line_number":153,"context_line":"        past \u003d datetime.datetime(2000, 1, 1, 0, 0)"},{"line_number":154,"context_line":"        next \u003d past + datetime.timedelta(minutes\u003d8)"},{"line_number":155,"context_line":"        present \u003d past + datetime.timedelta(minutes\u003d10)"},{"line_number":156,"context_line":"        mock_utcnow.return_value \u003d past"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # node with provision_updated timeout"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_6a4153a8","line":155,"updated":"2015-02-12 05:08:18.000000000","message":"Maybe, but feel free to ignore:\n present \u003d next + datetime.timedelta(minutes\u003d2)\n\nJust a thought in case the \u0027next\u0027 line gets changed it would handle it automatically.","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"779ead1484a86d8bcb890e77bba0e4cb918d11dc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def test_get_nodeinfo_list_inspection(self, mock_utcnow):"},{"line_number":153,"context_line":"        past \u003d datetime.datetime(2000, 1, 1, 0, 0)"},{"line_number":154,"context_line":"        next \u003d past + datetime.timedelta(minutes\u003d8)"},{"line_number":155,"context_line":"        present \u003d past + datetime.timedelta(minutes\u003d10)"},{"line_number":156,"context_line":"        mock_utcnow.return_value \u003d past"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # node with provision_updated timeout"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_c08e9b78","line":155,"in_reply_to":"da86d52c_6a4153a8","updated":"2015-02-12 09:22:16.000000000","message":"yes, but we can do the way it is done right now.","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9d3bf2c75e75a09708de7785f5f81fe41c9ee90d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                       provision_state\u003dstates.INSPECTING)"},{"line_number":164,"context_line":"        # node without timeout"},{"line_number":165,"context_line":"        utils.create_test_node(uuid\u003dironic_utils.generate_uuid(),"},{"line_number":166,"context_line":"                            inspection_started_at\u003dnext)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        mock_utcnow.return_value \u003d present"},{"line_number":169,"context_line":"        res \u003d self.dbapi.get_nodeinfo_list("}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_ea062385","line":166,"updated":"2015-02-12 05:08:18.000000000","message":"nit: indentation","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"779ead1484a86d8bcb890e77bba0e4cb918d11dc","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                       provision_state\u003dstates.INSPECTING)"},{"line_number":164,"context_line":"        # node without timeout"},{"line_number":165,"context_line":"        utils.create_test_node(uuid\u003dironic_utils.generate_uuid(),"},{"line_number":166,"context_line":"                            inspection_started_at\u003dnext)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        mock_utcnow.return_value \u003d present"},{"line_number":169,"context_line":"        res \u003d self.dbapi.get_nodeinfo_list("}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_40f2ab06","line":166,"in_reply_to":"da86d52c_ea062385","updated":"2015-02-12 09:22:16.000000000","message":"ok","commit_id":"122fc84adb95f119c1a80b5b7355b552117265ea"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"af5726213d4ceb8052f7590922734859c4189c84","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        result \u003d res[\u0027inspection_started_at\u0027]"},{"line_number":394,"context_line":"        self.assertEqual(mocked_time,"},{"line_number":395,"context_line":"                         timeutils.normalize_time(result))"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_reserve_node(self):"},{"line_number":398,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":399,"context_line":"        uuid \u003d node.uuid"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_f881d6c3","line":396,"updated":"2015-02-24 15:58:53.000000000","message":"worth testing last_inspected is set?","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"99d9d2714a5fe2d9dd80a0a5b55aaac124198560","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        result \u003d res[\u0027inspection_started_at\u0027]"},{"line_number":394,"context_line":"        self.assertEqual(mocked_time,"},{"line_number":395,"context_line":"                         timeutils.normalize_time(result))"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_reserve_node(self):"},{"line_number":398,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":399,"context_line":"        uuid \u003d node.uuid"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_b0b76e39","line":396,"in_reply_to":"ba7be1f8_f881d6c3","updated":"2015-02-24 17:51:37.000000000","message":"Yes initially i was doing it in the driver. I will add a test case.","commit_id":"50898c9aed4a1f2b47c9e2e759b203bd52d3af37"}]}
