)]}'
{"ironic/api/controllers/v1/__init__.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3a702ac2fcd48223ae3936aa6717a3db18d212c","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"MIN_VER \u003d 0"},{"line_number":41,"context_line":"MAX_VER \u003d 2"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class MediaType(base.APIBase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_764c4243","line":41,"updated":"2015-02-03 11:44:15.000000000","message":"this is going to need a rebase right now...","commit_id":"a82bbecd77d8311d1662e70c16f15a0f9924e769"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58706d3bc8aee9c9fe2cd2da8d65b20657e41ce6","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":319,"context_line":"        :param target: The desired provision state of the node."},{"line_number":320,"context_line":"        :raises: NodeLocked if the node is currently locked."},{"line_number":321,"context_line":"        :raises: ClientSideError (HTTP 409) if the node is already being"},{"line_number":322,"context_line":"                 provisioned."},{"line_number":323,"context_line":"        :raises: InvalidStateRequested (HTTP 400) if the requested transition"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_b432b4a4","line":320,"updated":"2015-01-27 10:40:17.000000000","message":"Just to keep the consistency with the :raises: tags in docstring. NodeLocked will raise HTTP 409","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        :param node_uuid: UUID of a node."},{"line_number":319,"context_line":"        :param target: The desired provision state of the node."},{"line_number":320,"context_line":"        :raises: NodeLocked if the node is currently locked."},{"line_number":321,"context_line":"        :raises: ClientSideError (HTTP 409) if the node is already being"},{"line_number":322,"context_line":"                 provisioned."},{"line_number":323,"context_line":"        :raises: InvalidStateRequested (HTTP 400) if the requested transition"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_4d12ad63","line":320,"updated":"2015-01-27 19:05:16.000000000","message":"done","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e76e8fed592b4f19b1561200f11261f67f7dcfca","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        m \u003d ir_states.machine.copy()"},{"line_number":334,"context_line":"        m.initialize(rpc_node.provision_state)"},{"line_number":335,"context_line":"        if not m.is_valid_event(ir_states.VERBS.get(target, target)):"},{"line_number":336,"context_line":"            msg \u003d (_(\u0027The requested action \"%(action)s\" can not be performed \u0027"},{"line_number":337,"context_line":"                     \u0027on node \"%(node)s\" while it is in state \"%(state)s\".\u0027)"},{"line_number":338,"context_line":"                   % {\u0027action\u0027: target,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_cb66c350","line":335,"updated":"2015-01-27 09:00:35.000000000","message":"should we allow upper-case targets (like we ourselves commonly write in specs)?","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        m \u003d ir_states.machine.copy()"},{"line_number":334,"context_line":"        m.initialize(rpc_node.provision_state)"},{"line_number":335,"context_line":"        if not m.is_valid_event(ir_states.VERBS.get(target, target)):"},{"line_number":336,"context_line":"            msg \u003d (_(\u0027The requested action \"%(action)s\" can not be performed \u0027"},{"line_number":337,"context_line":"                     \u0027on node \"%(node)s\" while it is in state \"%(state)s\".\u0027)"},{"line_number":338,"context_line":"                   % {\u0027action\u0027: target,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_6d177152","line":335,"updated":"2015-01-27 19:05:16.000000000","message":"that\u0027s an interesting qeustion ... the spec spells all the verbs in lower case. I would make that change in a separate patch anyway, if we decide to do that.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b3ca4d4dc120d93f2530b8b4d4ad4da6813b824e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # v 1.2 added the MANAGEABLE state and two verbs to move nodes into"},{"line_number":65,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":66,"context_line":"    if (pecan.request.version.minor \u003c 2 and"},{"line_number":67,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]]):"},{"line_number":68,"context_line":"        raise exception.NotAcceptable()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_9fe2e79d","line":67,"updated":"2015-02-02 09:13:59.000000000","message":"do we need to log what exactly wen wrong?","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        :raises: ClientSideError (HTTP 409) if the node is already being"},{"line_number":343,"context_line":"                 provisioned."},{"line_number":344,"context_line":"        :raises: InvalidStateRequested (HTTP 400) if the requested transition"},{"line_number":345,"context_line":"                 is not possible from the current state."},{"line_number":346,"context_line":"        \"\"\""},{"line_number":347,"context_line":"        check_allow_management_verbs(target)"},{"line_number":348,"context_line":"        rpc_node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_5345a7b1","line":345,"updated":"2015-02-02 22:59:01.000000000","message":"check_allow_management_verbs() could raise NotAcceptable (HTTP 406)\n\n(btw, there\u0027s a TODO in exceptions.py for this exception: \u0027We need to set response headers in the API for this exception\u0027.)","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        :raises: ClientSideError (HTTP 409) if the node is already being"},{"line_number":343,"context_line":"                 provisioned."},{"line_number":344,"context_line":"        :raises: InvalidStateRequested (HTTP 400) if the requested transition"},{"line_number":345,"context_line":"                 is not possible from the current state."},{"line_number":346,"context_line":"        \"\"\""},{"line_number":347,"context_line":"        check_allow_management_verbs(target)"},{"line_number":348,"context_line":"        rpc_node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_6da0f243","line":345,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if rpc_node.reservation:"},{"line_number":352,"context_line":"            raise exception.NodeLocked(node\u003drpc_node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                       host\u003drpc_node[\u0027reservation\u0027])"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        m \u003d ir_states.machine.copy()"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_8da3664e","line":352,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if rpc_node.reservation:"},{"line_number":352,"context_line":"            raise exception.NodeLocked(node\u003drpc_node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                       host\u003drpc_node[\u0027reservation\u0027])"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        m \u003d ir_states.machine.copy()"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_13732fe8","line":352,"updated":"2015-02-02 22:59:01.000000000","message":"nit. Are we moving towards using rpc_node.uuid instead of rpc_node[\u0027uuid\u0027]? (and rpc_node.reservation instead of rpc_node[\u0027reservation\u0027] below).","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"6f3192bd5a3920f06d180fb86ddfa5753af387b2","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if rpc_node.reservation:"},{"line_number":352,"context_line":"            raise exception.NodeLocked(node\u003drpc_node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                       host\u003drpc_node[\u0027reservation\u0027])"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        m \u003d ir_states.machine.copy()"},{"line_number":356,"context_line":"        m.initialize(rpc_node.provision_state)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_51968cf1","line":353,"updated":"2015-02-02 17:54:01.000000000","message":"I wonder if this check is necessary? NodeLocked will be thrown from the manager if it is locked. This is a race-y check anyway as the reservation could be changed either before or after this check.","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if rpc_node.reservation:"},{"line_number":352,"context_line":"            raise exception.NodeLocked(node\u003drpc_node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                       host\u003drpc_node[\u0027reservation\u0027])"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        m \u003d ir_states.machine.copy()"},{"line_number":356,"context_line":"        m.initialize(rpc_node.provision_state)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ad890acc","line":353,"updated":"2015-02-03 10:28:29.000000000","message":"Yup, there\u0027s a small race, but it\u0027s also free since we have to fetch the node for the next step anyway, so why not pre-emptively check it here?","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"a6852b8eb6b8c4e1f74cef6faf081f40f86a0a0e","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        if rpc_node.reservation:"},{"line_number":352,"context_line":"            raise exception.NodeLocked(node\u003drpc_node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                       host\u003drpc_node[\u0027reservation\u0027])"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        m \u003d ir_states.machine.copy()"},{"line_number":356,"context_line":"        m.initialize(rpc_node.provision_state)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_79226e02","line":353,"in_reply_to":"da86d52c_ad890acc","updated":"2015-02-03 14:16:26.000000000","message":"Last release, we built in a retry mechanism around node locking to reduce the amount of NodeLocked exceptions we were getting. This bypasses that mechanism totally, and for no real benefit that I can perceive (except maybe less RPC calls, but very few).\n\nI think this is a pattern we should avoid (without a good reason) since we took steps to reduce such issues last release.","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3a702ac2fcd48223ae3936aa6717a3db18d212c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"def check_allow_management_verbs(verb):"},{"line_number":64,"context_line":"    # v 1.2 added the MANAGEABLE state and two verbs to move nodes into"},{"line_number":65,"context_line":"    # and out of that state. Reject requests to do this in older versions"},{"line_number":66,"context_line":"    if (pecan.request.version.minor \u003c 2 and"},{"line_number":67,"context_line":"            verb in [ir_states.VERBS[\u0027manage\u0027], ir_states.VERBS[\u0027provide\u0027]]):"},{"line_number":68,"context_line":"        raise exception.NotAcceptable()"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_d6516ed9","line":66,"updated":"2015-02-03 11:44:15.000000000","message":"I\u0027ve just approved patch https://review.openstack.org/#/c/150784/ using 1.2, so this should be 1.3","commit_id":"a82bbecd77d8311d1662e70c16f15a0f9924e769"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b3cec3a3d15916477798e3d100c05646279fb4f","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        # Normally, we let the task manager recognize and deal with"},{"line_number":361,"context_line":"        # NodeLocked exceptions. However, that isn\u0027t done until the RPC calls"},{"line_number":362,"context_line":"        # below. In order to main backward compatibility with our API HTTP"},{"line_number":363,"context_line":"        # response codes, we have this check here to deal with cases where"},{"line_number":364,"context_line":"        # a node is already being operated on (DEPLOYING or such) and we"},{"line_number":365,"context_line":"        # want to continue returning 409. Without it, we\u0027d return 400."}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_67bab724","line":362,"updated":"2015-02-03 20:34:38.000000000","message":"nit s/main/maintain/","commit_id":"b636cb2c496801d477911d5964d7708309bd6cfc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b3cec3a3d15916477798e3d100c05646279fb4f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        # below. In order to main backward compatibility with our API HTTP"},{"line_number":363,"context_line":"        # response codes, we have this check here to deal with cases where"},{"line_number":364,"context_line":"        # a node is already being operated on (DEPLOYING or such) and we"},{"line_number":365,"context_line":"        # want to continue returning 409. Without it, we\u0027d return 400."},{"line_number":366,"context_line":"        if rpc_node.reservation:"},{"line_number":367,"context_line":"            raise exception.NodeLocked(node\u003drpc_node.uuid,"},{"line_number":368,"context_line":"                                       host\u003drpc_node.reservation)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_f8bac66c","line":365,"updated":"2015-02-03 20:34:38.000000000","message":"I wondered how it would get 400. I think the 400 here is associated with an InvalidStateRequested exception -- might be useful to mention that.","commit_id":"b636cb2c496801d477911d5964d7708309bd6cfc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b3cec3a3d15916477798e3d100c05646279fb4f","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        m \u003d ir_states.machine.copy()"},{"line_number":371,"context_line":"        m.initialize(rpc_node.provision_state)"},{"line_number":372,"context_line":"        if not m.is_valid_event(ir_states.VERBS.get(target, target)):"},{"line_number":373,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":374,"context_line":"                    action\u003dtarget, node\u003dnode_uuid,"},{"line_number":375,"context_line":"                    state\u003drpc_node.provision_state)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_93bb6de4","line":372,"updated":"2015-02-03 20:34:38.000000000","message":"Before this change, we allowed \u0027active\u0027, \u0027deleted\u0027, \u0027rebuild\u0027. With this change (and in v1.0, not specifying a microversion), this will also allow \u0027delete\u0027 and \u0027deploy\u0027. Is that OK, or do we only allow those with v1.3+ ?","commit_id":"b636cb2c496801d477911d5964d7708309bd6cfc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b3cec3a3d15916477798e3d100c05646279fb4f","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    pecan.request.context, node_uuid, target, topic)"},{"line_number":400,"context_line":"        else:"},{"line_number":401,"context_line":"            msg \u003d (_(\u0027The requested action \"%(action)s\" could not be \u0027"},{"line_number":402,"context_line":"                     \u0027understood.\u0027) % {\u0027action\u0027: target})"},{"line_number":403,"context_line":"            raise exception.InvalidStateRequested(message\u003dmsg)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # Set the HTTP Location Header"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_eed59cb9","line":402,"updated":"2015-02-03 20:34:38.000000000","message":"A \u0027deploy\u0027 or \u0027delete\u0027 request (with or without v1.3) fails here.\n\nMaybe we should just delete the \u0027active\u0027 and \u0027deleted\u0027 entries in ir_states.VERBS from this patch.","commit_id":"b636cb2c496801d477911d5964d7708309bd6cfc"}],"ironic/common/states.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"VERBS \u003d {"},{"line_number":41,"context_line":"        \u0027active\u0027: \u0027deploy\u0027,"},{"line_number":42,"context_line":"        \u0027deleted\u0027: \u0027delete\u0027,"},{"line_number":43,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":44,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_10ffec02","line":43,"updated":"2015-01-27 19:05:16.000000000","message":"let me add a comment inline explaining what this does. We use a few different words to mean the same thing in a few places, and need a clearer mapping so we can test it.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e76e8fed592b4f19b1561200f11261f67f7dcfca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"VERBS \u003d {"},{"line_number":41,"context_line":"        \u0027active\u0027: \u0027deploy\u0027,"},{"line_number":42,"context_line":"        \u0027deleted\u0027: \u0027delete\u0027,"},{"line_number":43,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":44,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_2b70270a","line":43,"updated":"2015-01-27 09:00:35.000000000","message":"shouldn\u0027t it be \u0027manageable\u0027: \u0027manage\u0027?","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"It also provides mapping for backwards-compatible changes that were made"},{"line_number":57,"context_line":"necessary by the new-ironic-state-machine spec during the Kilo cycle."},{"line_number":58,"context_line":"The old verb for delete was \"deleted\", but the new one is \"delete\"."},{"line_number":59,"context_line":"\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"NOSTATE \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_2ed9a683","line":58,"updated":"2015-02-02 22:59:01.000000000","message":"you mean the internal verb, right? (The external verb will still be \u0027deleted\u0027.)","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"\"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"MANAGEABLE \u003d \u0027manageable\u0027"},{"line_number":69,"context_line":"\"\"\" Node is in a managed state."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This state indicates that Ironic has verified, at least once, that it had"},{"line_number":72,"context_line":"sufficient information to manage the hardware. While in this state, the node"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_8dba866c","line":69,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b3ca4d4dc120d93f2530b8b4d4ad4da6813b824e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"\"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"MANAGEABLE \u003d \u0027manageable\u0027"},{"line_number":69,"context_line":"\"\"\" Node is in a managed state."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"This state indicates that Ironic has verified, at least once, that it had"},{"line_number":72,"context_line":"sufficient information to manage the hardware. While in this state, the node"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_3f02db3e","line":69,"updated":"2015-02-02 09:13:59.000000000","message":"s/managed/manageable/ here too?","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b3cec3a3d15916477798e3d100c05646279fb4f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"It also provides mapping for backwards-compatible changes that were made"},{"line_number":57,"context_line":"necessary by the new-ironic-state-machine spec during the Kilo cycle."},{"line_number":58,"context_line":"The API expected the \"deleted\" verb to initiate a delete, and it now"},{"line_number":59,"context_line":"also accepts the \"delete\" verb, as defined in the Kilo spec."},{"line_number":60,"context_line":"\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"NOSTATE \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_0e7830c3","line":59,"updated":"2015-02-03 20:34:38.000000000","message":"I tried using \u0027deploy\u0027 or \u0027delete\u0027 as the verb in the API and it doesn\u0027t seem to work (see my comments in controllers/v1/node.py).","commit_id":"b636cb2c496801d477911d5964d7708309bd6cfc"}],"ironic/conductor/manager.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":711,"context_line":"    def do_provisioning_action(self, context, node_id, action):"},{"line_number":712,"context_line":"        \"\"\"RPC method to initiate certain provisioning state transitions."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        Validate driver specific informatino synchronously, and then"},{"line_number":715,"context_line":"        spawn a background worker to perform the requested action, if the"},{"line_number":716,"context_line":"        node\u0027s current state allows that action to be performed."},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_8d0bc52a","line":714,"updated":"2015-01-27 19:05:16.000000000","message":"done","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e76e8fed592b4f19b1561200f11261f67f7dcfca","unresolved":false,"context_lines":[{"line_number":711,"context_line":"    def do_provisioning_action(self, context, node_id, action):"},{"line_number":712,"context_line":"        \"\"\"RPC method to initiate certain provisioning state transitions."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        Validate driver specific informatino synchronously, and then"},{"line_number":715,"context_line":"        spawn a background worker to perform the requested action, if the"},{"line_number":716,"context_line":"        node\u0027s current state allows that action to be performed."},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_8bdf5bd5","line":714,"updated":"2015-01-27 09:00:35.000000000","message":"s/informatino/information/","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58706d3bc8aee9c9fe2cd2da8d65b20657e41ce6","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        :param node_id: the id or uuid of a node."},{"line_number":720,"context_line":"        :param action: an action. One of ironic.common.states.VERBS"},{"line_number":721,"context_line":"        :raises: InvalidParameterValue"},{"line_number":722,"context_line":"        :raises: InvalidState"},{"line_number":723,"context_line":"        :raises: NoFreeConductorWorker"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_9f0871db","line":722,"updated":"2015-01-27 10:40:17.000000000","message":"InvalidState is being handled and converted to InstanceDeployFailure. Tho see comment at L739, we may want to use a different exception for this failure.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        :param node_id: the id or uuid of a node."},{"line_number":720,"context_line":"        :param action: an action. One of ironic.common.states.VERBS"},{"line_number":721,"context_line":"        :raises: InvalidParameterValue"},{"line_number":722,"context_line":"        :raises: InvalidState"},{"line_number":723,"context_line":"        :raises: NoFreeConductorWorker"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_ad08892e","line":722,"updated":"2015-01-27 19:05:16.000000000","message":"Oh, right.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58706d3bc8aee9c9fe2cd2da8d65b20657e41ce6","unresolved":false,"context_lines":[{"line_number":728,"context_line":"                method \u003d None"},{"line_number":729,"context_line":"                callback \u003d self._spawn_worker"},{"line_number":730,"context_line":"                if action \u003d\u003d \u0027delete\u0027:"},{"line_number":731,"context_line":"                    method \u003d do_node_tear_down"},{"line_number":732,"context_line":"                if action in (\u0027manage\u0027, \u0027provide\u0027):"},{"line_number":733,"context_line":"                    callback \u003d None"},{"line_number":734,"context_line":"                task.process_event(action,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_3f669ded","line":731,"updated":"2015-01-27 10:40:17.000000000","message":"Since we are using it for delete, we should use it for deploy as well right?\n\nIf we do, we can make the provision() method from the API simpler by removing the logic to know what method to invoke based on the target state, and leave it just here.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":728,"context_line":"                method \u003d None"},{"line_number":729,"context_line":"                callback \u003d self._spawn_worker"},{"line_number":730,"context_line":"                if action \u003d\u003d \u0027delete\u0027:"},{"line_number":731,"context_line":"                    method \u003d do_node_tear_down"},{"line_number":732,"context_line":"                if action in (\u0027manage\u0027, \u0027provide\u0027):"},{"line_number":733,"context_line":"                    callback \u003d None"},{"line_number":734,"context_line":"                task.process_event(action,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_cd05bd15","line":731,"updated":"2015-01-27 19:05:16.000000000","message":"That\u0027s what I was trying to do, but it wasn\u0027t that simple on the first pass.\nAfter another look, I\u0027ve removed this. Refactorign the RPC calls can be done later.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6345d7e4adb0c97afc1ea2169e6ebe57a12332d8","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                                   call_args\u003d(method, task),"},{"line_number":737,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":738,"context_line":"            except exception.InvalidState:"},{"line_number":739,"context_line":"                raise exception.InstanceDeployFailure(_("},{"line_number":740,"context_line":"                    \u0027The requested action \"%(action)s\" can not be performed \u0027"},{"line_number":741,"context_line":"                    \u0027on node \"%(node)s\" while it is in state \"%(state)s\".\u0027)"},{"line_number":742,"context_line":"                    % {\u0027action\u0027: action,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_ed02810a","line":739,"updated":"2015-01-27 19:05:16.000000000","message":"I\u0027ll remove the delete logic from the conductor side of this RPC call to simplify things for now.\nAlso, I\u0027ve made some exception changes...","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e76e8fed592b4f19b1561200f11261f67f7dcfca","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                                   call_args\u003d(method, task),"},{"line_number":737,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":738,"context_line":"            except exception.InvalidState:"},{"line_number":739,"context_line":"                raise exception.InstanceDeployFailure(_("},{"line_number":740,"context_line":"                    \u0027The requested action \"%(action)s\" can not be performed \u0027"},{"line_number":741,"context_line":"                    \u0027on node \"%(node)s\" while it is in state \"%(state)s\".\u0027)"},{"line_number":742,"context_line":"                    % {\u0027action\u0027: action,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_eb9e1f06","line":739,"updated":"2015-01-27 09:00:35.000000000","message":"maybe we need a new exception here? it\u0027s not a deploy failure","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58706d3bc8aee9c9fe2cd2da8d65b20657e41ce6","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                                   call_args\u003d(method, task),"},{"line_number":737,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":738,"context_line":"            except exception.InvalidState:"},{"line_number":739,"context_line":"                raise exception.InstanceDeployFailure(_("},{"line_number":740,"context_line":"                    \u0027The requested action \"%(action)s\" can not be performed \u0027"},{"line_number":741,"context_line":"                    \u0027on node \"%(node)s\" while it is in state \"%(state)s\".\u0027)"},{"line_number":742,"context_line":"                    % {\u0027action\u0027: action,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_bf644db9","line":739,"in_reply_to":"1a930d6b_eb9e1f06","updated":"2015-01-27 10:40:17.000000000","message":"Yeah, looks like. I think InvalidStateRequested could be reused for this.","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        :raises: InstanceDeployFailure"},{"line_number":619,"context_line":"        :raises: NodeInMaintenance if the node is in maintenance mode."},{"line_number":620,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":621,"context_line":"                 async task."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        LOG.debug(\"RPC do_node_deploy called for node %s.\" % node_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ceff2a66","line":621,"updated":"2015-02-02 22:59:01.000000000","message":":raises: InvalidStateRequested...","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        :raises: InstanceDeployFailure"},{"line_number":619,"context_line":"        :raises: NodeInMaintenance if the node is in maintenance mode."},{"line_number":620,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":621,"context_line":"                 async task."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        LOG.debug(\"RPC do_node_deploy called for node %s.\" % node_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_cd847eb3","line":621,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            except exception.InvalidState:"},{"line_number":667,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":668,"context_line":"                        action\u003devent, node\u003dtask.node.uuid,"},{"line_number":669,"context_line":"                        state\u003dtask.node[\u0027provision_state\u0027])"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":672,"context_line":"                                   exception.NodeLocked,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ed9302f8","line":669,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            except exception.InvalidState:"},{"line_number":667,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":668,"context_line":"                        action\u003devent, node\u003dtask.node.uuid,"},{"line_number":669,"context_line":"                        state\u003dtask.node[\u0027provision_state\u0027])"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":672,"context_line":"                                   exception.NodeLocked,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ceb1eae2","line":669,"updated":"2015-02-02 22:59:01.000000000","message":"s/node[\u0027provision_state\u0027]/node.provision_state/","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        :param node_id: the id or uuid of a node."},{"line_number":683,"context_line":"        :raises: InstanceDeployFailure"},{"line_number":684,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":685,"context_line":"                 async task"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        \"\"\""},{"line_number":688,"context_line":"        LOG.debug(\"RPC do_node_tear_down called for node %s.\" % node_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ced2cad1","line":685,"updated":"2015-02-02 22:59:01.000000000","message":":raises InvalidStateRequested...","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        :param node_id: the id or uuid of a node."},{"line_number":683,"context_line":"        :raises: InstanceDeployFailure"},{"line_number":684,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":685,"context_line":"                 async task"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        \"\"\""},{"line_number":688,"context_line":"        LOG.debug(\"RPC do_node_tear_down called for node %s.\" % node_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_0d8f76cd","line":685,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":707,"context_line":"            except exception.InvalidState:"},{"line_number":708,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":709,"context_line":"                        action\u003d\u0027delete\u0027, node\u003dtask.node.uuid,"},{"line_number":710,"context_line":"                        state\u003dtask.node[\u0027provision_state\u0027])"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":713,"context_line":"                                   exception.NodeLocked,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_2dbd1a69","line":710,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":707,"context_line":"            except exception.InvalidState:"},{"line_number":708,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":709,"context_line":"                        action\u003d\u0027delete\u0027, node\u003dtask.node.uuid,"},{"line_number":710,"context_line":"                        state\u003dtask.node[\u0027provision_state\u0027])"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"},{"line_number":713,"context_line":"                                   exception.NodeLocked,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_2e69a625","line":710,"updated":"2015-02-02 22:59:01.000000000","message":"s/node[\u0027provision_state\u0027]/node.provision_state/","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        Validate driver specific information synchronously, and then"},{"line_number":721,"context_line":"        spawn a background worker to perform the requested action, if the"},{"line_number":722,"context_line":"        node\u0027s current state allows that action to be performed."},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        :param context: an admin context."},{"line_number":725,"context_line":"        :param node_id: the id or uuid of a node."}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_293d20bc","line":722,"updated":"2015-02-02 22:59:01.000000000","message":"Maybe I\u0027m missing something. Where is the information passed to task.process_event() to spawn a background worker etc.","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"        Validate driver specific information synchronously, and then"},{"line_number":721,"context_line":"        spawn a background worker to perform the requested action, if the"},{"line_number":722,"context_line":"        node\u0027s current state allows that action to be performed."},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        :param context: an admin context."},{"line_number":725,"context_line":"        :param node_id: the id or uuid of a node."}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_4dc08ee0","line":722,"updated":"2015-02-03 10:28:29.000000000","message":"woops - this comment is left over from a previous revision that did that. Fixed","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":735,"context_line":"            except exception.InvalidState:"},{"line_number":736,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":737,"context_line":"                        action\u003daction, node\u003dtask.node.uuid,"},{"line_number":738,"context_line":"                        state\u003dtask.node[\u0027provision_state\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    @periodic_task.periodic_task("},{"line_number":741,"context_line":"            spacing\u003dCONF.conductor.sync_power_state_interval)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_6db71287","line":738,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":735,"context_line":"            except exception.InvalidState:"},{"line_number":736,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":737,"context_line":"                        action\u003daction, node\u003dtask.node.uuid,"},{"line_number":738,"context_line":"                        state\u003dtask.node[\u0027provision_state\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    @periodic_task.periodic_task("},{"line_number":741,"context_line":"            spacing\u003dCONF.conductor.sync_power_state_interval)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_6ea63e55","line":738,"updated":"2015-02-02 22:59:01.000000000","message":"s/node[\u0027provision_state\u0027]/node.provision_state/","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58706d3bc8aee9c9fe2cd2da8d65b20657e41ce6","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        :raises: InvalidParameterValue"},{"line_number":312,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":313,"context_line":"                async task."},{"line_number":314,"context_line":"        :raises: InvalidState if the requested action can not be performed."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        This encapsulates some provisioning actions in a single call."},{"line_number":317,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_5f19a920","line":314,"updated":"2015-01-27 10:40:17.000000000","message":"ditto re InvalidState being handled (see comment at L739 in manager.py)","commit_id":"628916f96d167030d90bb2b3fd6bc66013f80116"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e3bb3091cb67517315426c325dc90d1edb1f63fb","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        :raises: InvalidParameterValue"},{"line_number":315,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":316,"context_line":"                async task."},{"line_number":317,"context_line":"        :raises: InvalidState if the requested action can not be performed."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        This encapsulates some provisioning actions in a single call."},{"line_number":320,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_adb02a8c","line":317,"updated":"2015-02-03 10:28:29.000000000","message":"done","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"94df8509b7690cc7689a7fe5b2a5880f310e6b6c","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        :raises: InvalidParameterValue"},{"line_number":315,"context_line":"        :raises: NoFreeConductorWorker when there is no free worker to start"},{"line_number":316,"context_line":"                async task."},{"line_number":317,"context_line":"        :raises: InvalidState if the requested action can not be performed."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        This encapsulates some provisioning actions in a single call."},{"line_number":320,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_ee714ee1","line":317,"updated":"2015-02-02 22:59:01.000000000","message":"s/InvalidState/InvalidStateRequested/","commit_id":"1f6fde79c88ef093ca0d456216e85013595e6155"}]}
