)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"45b61ecc918ecf6e483644ac823093a08420dd29","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to third_party_driver_mocks. This enables the ilo driver"},{"line_number":11,"context_line":"tests to use the proliantutils module when it is available, and"},{"line_number":12,"context_line":"use the mocks when proliantutils module is not available."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ief88b194374585c7cfc3c3804b4ea04620fe21e7"},{"line_number":15,"context_line":"Closes-bug: 1416421"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_fa269167","line":13,"updated":"2015-02-02 09:25:26.000000000","message":"I would mention test refactoring which you apparently did","commit_id":"d6c339856e31c35405d3d12279d2e4bce355c264"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"831ffc6155238b67f5b4d01eab7e7bbcaaf146ae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to third_party_driver_mocks. This enables the ilo driver"},{"line_number":11,"context_line":"tests to use the proliantutils module when it is available, and"},{"line_number":12,"context_line":"use the mocks when proliantutils module is not available."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ief88b194374585c7cfc3c3804b4ea04620fe21e7"},{"line_number":15,"context_line":"Closes-bug: 1416421"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_9ff8b0c4","line":13,"in_reply_to":"da86d52c_fa269167","updated":"2015-02-04 14:26:24.000000000","message":"Done","commit_id":"d6c339856e31c35405d3d12279d2e4bce355c264"}],"ironic/tests/drivers/third_party_driver_mocks.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"45b61ecc918ecf6e483644ac823093a08420dd29","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    # Avoid using \u0027Exception\u0027 below so that other exceptions are not"},{"line_number":92,"context_line":"    # caught when expecting the below exception.s"},{"line_number":93,"context_line":"    proliantutils.ilo.ribcl.IloError \u003d NotImplementedError"},{"line_number":94,"context_line":"    proliantutils.ilo.ribcl.IloCommandNotSupportedError \u003d NotImplementedError"},{"line_number":95,"context_line":"    if \u0027ironic.drivers.ilo\u0027 in sys.modules:"},{"line_number":96,"context_line":"        reload(sys.modules[\u0027ironic.drivers.ilo\u0027])"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_da0aadd1","line":94,"updated":"2015-02-02 09:25:26.000000000","message":"I would vote for a new type here:\n\n type(\u0027IloError\u0027, (Exception,), {})","commit_id":"d6c339856e31c35405d3d12279d2e4bce355c264"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"831ffc6155238b67f5b4d01eab7e7bbcaaf146ae","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    # Avoid using \u0027Exception\u0027 below so that other exceptions are not"},{"line_number":92,"context_line":"    # caught when expecting the below exception.s"},{"line_number":93,"context_line":"    proliantutils.ilo.ribcl.IloError \u003d NotImplementedError"},{"line_number":94,"context_line":"    proliantutils.ilo.ribcl.IloCommandNotSupportedError \u003d NotImplementedError"},{"line_number":95,"context_line":"    if \u0027ironic.drivers.ilo\u0027 in sys.modules:"},{"line_number":96,"context_line":"        reload(sys.modules[\u0027ironic.drivers.ilo\u0027])"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_5f5c78ed","line":94,"in_reply_to":"da86d52c_da0aadd1","updated":"2015-02-04 14:26:24.000000000","message":"Done","commit_id":"d6c339856e31c35405d3d12279d2e4bce355c264"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e4f9e4107715f43fdeb70c6906ce0788d7e8f80e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    proliantutils.ilo.ribcl.IloError \u003d type(\u0027IloError\u0027, (Exception,), {})"},{"line_number":92,"context_line":"    command_exception \u003d type(\u0027IloCommandNotSupportedError\u0027, (Exception,), {})"},{"line_number":93,"context_line":"    proliantutils.ilo.ribcl.IloCommandNotSupportedError \u003d command_exception"},{"line_number":94,"context_line":"    if \u0027ironic.drivers.ilo\u0027 in sys.modules:"},{"line_number":95,"context_line":"        reload(sys.modules[\u0027ironic.drivers.ilo\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_891eb55d","line":94,"updated":"2015-02-04 16:48:51.000000000","message":"Is this intentional that it got moved under the \u0027if not proliantutils\u0027?","commit_id":"c6f44319946c46bccf1ec030694290e1a449bed8"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"bf80a9269c03b23d740a7f999fee5134fc72345e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    proliantutils.ilo.ribcl.IloError \u003d type(\u0027IloError\u0027, (Exception,), {})"},{"line_number":92,"context_line":"    command_exception \u003d type(\u0027IloCommandNotSupportedError\u0027, (Exception,), {})"},{"line_number":93,"context_line":"    proliantutils.ilo.ribcl.IloCommandNotSupportedError \u003d command_exception"},{"line_number":94,"context_line":"    if \u0027ironic.drivers.ilo\u0027 in sys.modules:"},{"line_number":95,"context_line":"        reload(sys.modules[\u0027ironic.drivers.ilo\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_24e09095","line":94,"in_reply_to":"da86d52c_891eb55d","updated":"2015-02-04 17:23:15.000000000","message":"Yes, it made sense to reload the ironic.drivers.ilo only if we changed the sys.modules[\u0027proliantutils\u0027].","commit_id":"c6f44319946c46bccf1ec030694290e1a449bed8"}]}