)]}'
{"ironic/objects/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b497a9e62b949307073e3f2830ea210c11fa780f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                        object, e.g.: Node(context)"},{"line_number":235,"context_line":"        \"\"\""},{"line_number":236,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":237,"context_line":"        if \u0027driver\u0027 in updates and \u0027driver_internal_info\u0027 not in updates:"},{"line_number":238,"context_line":"            # Clean driver_internal_info when changes driver"},{"line_number":239,"context_line":"            self.driver_internal_info \u003d {}"},{"line_number":240,"context_line":"            updates \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b937cbaf","line":237,"updated":"2015-02-02 08:14:03.000000000","message":"\"\u0027driver_internal_info\u0027 not in updates\"  \u003c-- driver_internal_info is not expected to be in updates, is it?","commit_id":"12c6eecd6b51a9a86a658bd9ceb560c2f9ca45da"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"f33f4a8b0117f817f8e12b995ba38d0d01f12215","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                        object, e.g.: Node(context)"},{"line_number":235,"context_line":"        \"\"\""},{"line_number":236,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":237,"context_line":"        if \u0027driver\u0027 in updates and \u0027driver_internal_info\u0027 not in updates:"},{"line_number":238,"context_line":"            # Clean driver_internal_info when changes driver"},{"line_number":239,"context_line":"            self.driver_internal_info \u003d {}"},{"line_number":240,"context_line":"            updates \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_29f520cb","line":237,"in_reply_to":"da86d52c_1918d780","updated":"2015-02-02 23:05:39.000000000","message":"Since this is objects code, not API code, theoretically both could be here (though I don\u0027t see why someone would do that). I think this is fine here, being defensive is good.","commit_id":"12c6eecd6b51a9a86a658bd9ceb560c2f9ca45da"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"1070603882baa96eeda74efde2b4077d67c40e14","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                        object, e.g.: Node(context)"},{"line_number":235,"context_line":"        \"\"\""},{"line_number":236,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":237,"context_line":"        if \u0027driver\u0027 in updates and \u0027driver_internal_info\u0027 not in updates:"},{"line_number":238,"context_line":"            # Clean driver_internal_info when changes driver"},{"line_number":239,"context_line":"            self.driver_internal_info \u003d {}"},{"line_number":240,"context_line":"            updates \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1918d780","line":237,"in_reply_to":"da86d52c_b937cbaf","updated":"2015-02-02 08:35:37.000000000","message":"This is open for someone who want to change driver and driver_internal_info at once, but to be honest, I am also not quite sure about if this is necessary.","commit_id":"12c6eecd6b51a9a86a658bd9ceb560c2f9ca45da"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b497a9e62b949307073e3f2830ea210c11fa780f","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        if \u0027driver\u0027 in updates and \u0027driver_internal_info\u0027 not in updates:"},{"line_number":238,"context_line":"            # Clean driver_internal_info when changes driver"},{"line_number":239,"context_line":"            self.driver_internal_info \u003d {}"},{"line_number":240,"context_line":"            updates \u003d self.obj_get_changes()"},{"line_number":241,"context_line":"        self.dbapi.update_node(self.uuid, updates)"},{"line_number":242,"context_line":"        self.obj_reset_changes()"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_796c739d","line":240,"updated":"2015-02-02 08:14:03.000000000","message":"I think you do like updates[\u0027driver_internal_info\u0027] \u003d {}","commit_id":"12c6eecd6b51a9a86a658bd9ceb560c2f9ca45da"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"1070603882baa96eeda74efde2b4077d67c40e14","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        if \u0027driver\u0027 in updates and \u0027driver_internal_info\u0027 not in updates:"},{"line_number":238,"context_line":"            # Clean driver_internal_info when changes driver"},{"line_number":239,"context_line":"            self.driver_internal_info \u003d {}"},{"line_number":240,"context_line":"            updates \u003d self.obj_get_changes()"},{"line_number":241,"context_line":"        self.dbapi.update_node(self.uuid, updates)"},{"line_number":242,"context_line":"        self.obj_reset_changes()"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1941b75a","line":240,"in_reply_to":"da86d52c_796c739d","updated":"2015-02-02 08:35:37.000000000","message":"I try this at first, but node.driver_internal_info doesn\u0027t change immediately","commit_id":"12c6eecd6b51a9a86a658bd9ceb560c2f9ca45da"}]}
