)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3835ebc1ad29de7d87c9171c8691d62bb1de7d55","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Erhan Ekici \u003cerhan.ekici@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-03 22:52:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing Bug/1416298: f.write(password) -\u003e f.write(str(password))"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ironic.drivers.modules.ipmitool gives \"Failed to create the password file."},{"line_number":10,"context_line":"expected a character buffer object\" WARNING message and it causes \"Error:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_93ec44f5","line":7,"updated":"2015-02-04 00:33:54.000000000","message":"There\u0027s no need to mention the bug here, because that is mentioned below.","commit_id":"8ad2d2d1c462dc1ec89cbeacefced422068859e9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb4f02d620fb433ce379727f75ba0d9fcf104ec0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Erhan Ekici \u003cerhan.ekici@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-05 00:28:57 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BugFix - write() expects string but gets something else"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ironic.drivers.modules.ipmitool gives \"Failed to create the password file."},{"line_number":10,"context_line":"expected a character buffer object\" WARNING message and it causes \"Error:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da86d52c_31a8b976","line":7,"updated":"2015-02-05 08:34:17.000000000","message":"\"BugFix\" is not needed. I\u0027d better use something like:\n\n Cast IPMI password to string so that write() does not fail","commit_id":"ea70bb0cd47ff3213bb7a62d0a62f282fbf511b2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"20a54cceee4c781d18ccb29d344a4636cded4a50","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Erhan Ekici \u003cerhan.ekici@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-07 13:52:16 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BugFix - write() expects string but may get integer/numeric"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ironic.drivers.modules.ipmitool gives \"Failed to create the password file."},{"line_number":10,"context_line":"expected a character buffer object\" WARNING message and it causes \"Error:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da86d52c_391f5b0b","line":7,"updated":"2015-02-09 04:51:51.000000000","message":"Commit message could be more meaningful and could be related to the actual problem. And it crosses over 50 characters (don\u0027t know why it didn\u0027t get caught).","commit_id":"6dde4a7575abdb8c8d0507e527cd71922caf2703"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fb46a6329d75d813ba0bafea6dc2248d87f6bd92","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        fd, path \u003d tempfile.mkstemp()"},{"line_number":188,"context_line":"        os.fchmod(fd, stat.S_IRUSR | stat.S_IWUSR)"},{"line_number":189,"context_line":"        with os.fdopen(fd, \"w\") as f:"},{"line_number":190,"context_line":"            f.write(str(password))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        yield path"},{"line_number":193,"context_line":"        utils.delete_if_exists(path)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_6cd6e1f2","line":190,"updated":"2015-02-04 23:09:35.000000000","message":"Out of curiosity.  Do you know what type \u0027password\u0027 is?","commit_id":"ea70bb0cd47ff3213bb7a62d0a62f282fbf511b2"}],"ironic/tests/drivers/test_ipmitool.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb4f02d620fb433ce379727f75ba0d9fcf104ec0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":17,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\"\"\"Test class for IPMITool driver module.\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_31719944","line":19,"updated":"2015-02-05 08:34:17.000000000","message":"not need to change this","commit_id":"ea70bb0cd47ff3213bb7a62d0a62f282fbf511b2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"20a54cceee4c781d18ccb29d344a4636cded4a50","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            self.assertEqual(self.info.get(\u0027password\u0027), password)"},{"line_number":233,"context_line":"        self.assertFalse(os.path.isfile(del_chk_pw_file))"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test__make_password_file_with_numeric_password(self, mock_sleep):"},{"line_number":236,"context_line":"        numeric_password \u003d int(12345)"},{"line_number":237,"context_line":"        with ipmi._make_password_file(numeric_password) as pw_file:"},{"line_number":238,"context_line":"            del_chk_pw_file \u003d pw_file"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_b92b4b32","line":235,"updated":"2015-02-09 04:51:51.000000000","message":"Looks like we could refactor the above method and reuse most of the code there.","commit_id":"6dde4a7575abdb8c8d0507e527cd71922caf2703"}]}
