)]}'
{"ironic/common/driver_factory.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"48a37ea9a35c73f3b6dcfddf4770d34afc4232a1","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # NOTE(deva): if we were unable to load any configured driver, perhaps"},{"line_number":129,"context_line":"        #             because it is not present on the system, raise an error."},{"line_number":130,"context_line":"        if sorted(CONF.enabled_drivers) !\u003d sorted(cls._extension_manager.names()):"},{"line_number":131,"context_line":"            found \u003d cls._extension_manager.names()"},{"line_number":132,"context_line":"            names \u003d [n for n in CONF.enabled_drivers if n not in found]"},{"line_number":133,"context_line":"            # just in case more than one could not be found ..."}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_01c2ac58","line":130,"updated":"2015-02-04 11:52:44.000000000","message":"line too long","commit_id":"7d852741a914720ad517d454df8a79f2a8c115ce"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2322310d3760fd73a3687376d3b2e79615cd000d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if (sorted(CONF.enabled_drivers) !\u003d"},{"line_number":131,"context_line":"                sorted(cls._extension_manager.names())):"},{"line_number":132,"context_line":"            found \u003d cls._extension_manager.names()"},{"line_number":133,"context_line":"            names \u003d [n for n in CONF.enabled_drivers if n not in found]"},{"line_number":134,"context_line":"            # just in case more than one could not be found ..."},{"line_number":135,"context_line":"            names \u003d \u0027, \u0027.join(names)"},{"line_number":136,"context_line":"            raise exception.DriverNotFound(driver_name\u003dnames)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_85e4c3e1","line":133,"updated":"2015-02-05 05:26:01.000000000","message":"This is only an idea.  If those are list values, I think could do this:\n\n names \u003d set(CONF.enabled_drivers) - set(cls._extension_manager.names()) \n\nNo need to change though!","commit_id":"a53a00303054bcb40ca92722d6125fd5d0b4845a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8f9bbc33e75f2f420491f73186d5e34ac60ebc49","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if (sorted(CONF.enabled_drivers) !\u003d"},{"line_number":131,"context_line":"                sorted(cls._extension_manager.names())):"},{"line_number":132,"context_line":"            found \u003d cls._extension_manager.names()"},{"line_number":133,"context_line":"            names \u003d [n for n in CONF.enabled_drivers if n not in found]"},{"line_number":134,"context_line":"            # just in case more than one could not be found ..."},{"line_number":135,"context_line":"            names \u003d \u0027, \u0027.join(names)"},{"line_number":136,"context_line":"            raise exception.DriverNotFound(driver_name\u003dnames)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_116015ce","line":133,"in_reply_to":"da86d52c_85e4c3e1","updated":"2015-02-05 08:21:04.000000000","message":"I also usually prefer sets, though it does not deserve a new patchset on it\u0027s own","commit_id":"a53a00303054bcb40ca92722d6125fd5d0b4845a"}],"ironic/common/service.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"22f78efab8ba9d2c16fe3fd09904952ca650db35","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"},{"line_number":75,"context_line":"        self.rpcserver \u003d rpc.get_server(target, endpoints, serializer)"},{"line_number":76,"context_line":"        self.rpcserver.start()"},{"line_number":77,"context_line":"        self.manager.init_host()"},{"line_number":78,"context_line":"        LOG.info(_LI(\u0027Created RPC server for service %(service)s on host \u0027"},{"line_number":79,"context_line":"                     \u0027%(host)s.\u0027),"},{"line_number":80,"context_line":"                 {\u0027service\u0027: self.topic, \u0027host\u0027: self.host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_6f4fae6b","line":77,"updated":"2015-02-05 03:18:25.000000000","message":"good catch, thanks!","commit_id":"5bc188b311053201490b75c50bd901b7f19dd626"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2fe2a643b98cefffc9aed1ec0ef285b4b2363246","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"},{"line_number":75,"context_line":"        self.rpcserver \u003d rpc.get_server(target, endpoints, serializer)"},{"line_number":76,"context_line":"        self.rpcserver.start()"},{"line_number":77,"context_line":"        self.manager.init_host()"},{"line_number":78,"context_line":"        LOG.info(_LI(\u0027Created RPC server for service %(service)s on host \u0027"},{"line_number":79,"context_line":"                     \u0027%(host)s.\u0027),"},{"line_number":80,"context_line":"                 {\u0027service\u0027: self.topic, \u0027host\u0027: self.host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1c5773cb","line":77,"updated":"2015-02-04 12:13:00.000000000","message":"this is going to prevent driver-specific periodic tasks from starting in time. you have to move line #67 below this line","commit_id":"5bc188b311053201490b75c50bd901b7f19dd626"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2322310d3760fd73a3687376d3b2e79615cd000d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.rpcserver.start()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.manager.init_host()"},{"line_number":75,"context_line":"        self.tg.add_dynamic_timer("},{"line_number":76,"context_line":"                self.manager.periodic_tasks,"},{"line_number":77,"context_line":"                periodic_interval_max\u003dcfg.CONF.periodic_interval,"},{"line_number":78,"context_line":"                context\u003dadmin_context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_051ff308","line":75,"updated":"2015-02-05 05:26:01.000000000","message":"nit: indentation is too much","commit_id":"a53a00303054bcb40ca92722d6125fd5d0b4845a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5083a884c10314d0cc303508aa7117f55f827ebd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.rpcserver.start()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.manager.init_host()"},{"line_number":75,"context_line":"        self.tg.add_dynamic_timer("},{"line_number":76,"context_line":"                self.manager.periodic_tasks,"},{"line_number":77,"context_line":"                periodic_interval_max\u003dcfg.CONF.periodic_interval,"},{"line_number":78,"context_line":"                context\u003dadmin_context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_63e16229","line":75,"in_reply_to":"da86d52c_051ff308","updated":"2015-02-05 23:10:00.000000000","message":"John, people tend to indent 8 (or more) if it is a continuation to distinguish that from a different line of code.","commit_id":"a53a00303054bcb40ca92722d6125fd5d0b4845a"}],"ironic/conductor/manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2322310d3760fd73a3687376d3b2e79615cd000d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        \"\"\"Event for the keepalive thread.\"\"\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self._worker_pool \u003d greenpool.GreenPool("},{"line_number":209,"context_line":"                                size\u003dCONF.conductor.workers_pool_size)"},{"line_number":210,"context_line":"        \"\"\"GreenPool of background workers for performing tasks async.\"\"\""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.ring_manager \u003d hash.HashRingManager()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_45fe4baf","line":209,"updated":"2015-02-05 05:26:01.000000000","message":"nit: indentation is too much.","commit_id":"a53a00303054bcb40ca92722d6125fd5d0b4845a"}]}
