)]}'
{"ironic/common/exception.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    message \u003d _(\"Failed to deploy instance: %(reason)s\")"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"class InstanceCleanFailure(IronicException):"},{"line_number":191,"context_line":"    message \u003d _(\"Failed to clean instance: %(reason)s\")"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_7d871b10","line":190,"updated":"2015-02-20 02:33:26.000000000","message":"This exception doesn\u0027t seem to be used anywhere now.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    message \u003d _(\"Failed to deploy instance: %(reason)s\")"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"class InstanceCleanFailure(IronicException):"},{"line_number":191,"context_line":"    message \u003d _(\"Failed to clean instance: %(reason)s\")"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_5621f54b","line":190,"in_reply_to":"ba7be1f8_7d871b10","updated":"2015-02-23 23:00:41.000000000","message":"Done","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"}],"ironic/common/states.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e9f08da7cb02ca270836f49c066489a6dd7ea6d7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \u0027deleted\u0027: \u0027delete\u0027,"},{"line_number":44,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":45,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":46,"context_line":"        \u0027cleaned\u0027: \u0027clean\u0027"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"\"\"\" Mapping of state-changing events that are PUT to the REST API"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_46be27af","line":46,"updated":"2015-02-06 03:34:50.000000000","message":"nit: add trailing comma","commit_id":"b5a8b8d52e14a585920974f8d8ce06a0164fff90"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"fc6e01ba78f723ab2391300887523d69584365a6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \u0027deleted\u0027: \u0027delete\u0027,"},{"line_number":44,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":45,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":46,"context_line":"        \u0027cleaned\u0027: \u0027clean\u0027"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"\"\"\" Mapping of state-changing events that are PUT to the REST API"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_720bc97d","line":46,"in_reply_to":"da86d52c_46be27af","updated":"2015-02-07 01:22:32.000000000","message":"Ahh, that was a javascript-ism. Thanks!","commit_id":"b5a8b8d52e14a585920974f8d8ce06a0164fff90"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e9f08da7cb02ca270836f49c066489a6dd7ea6d7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Nodes may be put through cleaning from manageable, for example to ensure"},{"line_number":264,"context_line":"# a new node is ready for scheduling"},{"line_number":265,"context_line":"machine.add_transition(MANAGEABLE, CLEANFAIL, \u0027clean\u0027)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# An errored instance can be rebuilt"},{"line_number":268,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e6fabb73","line":265,"updated":"2015-02-06 03:34:50.000000000","message":"Just double checking.  This should be CLEANFAIL and not CLEANING?","commit_id":"b5a8b8d52e14a585920974f8d8ce06a0164fff90"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"fc6e01ba78f723ab2391300887523d69584365a6","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Nodes may be put through cleaning from manageable, for example to ensure"},{"line_number":264,"context_line":"# a new node is ready for scheduling"},{"line_number":265,"context_line":"machine.add_transition(MANAGEABLE, CLEANFAIL, \u0027clean\u0027)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# An errored instance can be rebuilt"},{"line_number":268,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_d221d5fd","line":265,"in_reply_to":"da86d52c_e6fabb73","updated":"2015-02-07 01:22:32.000000000","message":"Correct, it should have been cleaning. Fixed.","commit_id":"b5a8b8d52e14a585920974f8d8ce06a0164fff90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f7114343b18c2587c852217ddfd83a3c503b502a","unresolved":false,"context_lines":[{"line_number":259,"context_line":"machine.add_transition(CLEANING, AVAILABLE, \u0027provide\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":262,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"# An errored instance can be rebuilt"},{"line_number":265,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b9617dd5","line":262,"updated":"2015-02-09 12:48:01.000000000","message":"There\u0027s no transitions for CLEANED and I wonder if we need this state at all (also suggested dropping it from inspection).","commit_id":"8d6a448939b2da0ac558c0592f7904af41a270d6"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"e168c0ec86fe930f0d87b625294e618d6a7606dc","unresolved":false,"context_lines":[{"line_number":259,"context_line":"machine.add_transition(CLEANING, AVAILABLE, \u0027provide\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":262,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"# An errored instance can be rebuilt"},{"line_number":265,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_6b4d5572","line":262,"in_reply_to":"da86d52c_b9617dd5","updated":"2015-02-09 19:51:52.000000000","message":"I\u0027ll add a temporary no-op CLEANED transition that can be utilized later.","commit_id":"8d6a448939b2da0ac558c0592f7904af41a270d6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f595cfdbebf5f6bebc6a8cd263b820dda14c13da","unresolved":false,"context_lines":[{"line_number":126,"context_line":"\"\"\" Node cleaning was successful.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"CLEANFAIL \u003d \u0027clean failed\u0027"},{"line_number":129,"context_line":"\"\"\" Node failed to cleaning. This requires operator intervention to"},{"line_number":130,"context_line":"resolve."},{"line_number":131,"context_line":"\"\"\""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_50159de3","line":129,"updated":"2015-02-09 20:48:46.000000000","message":"s/failed to cleaning/failed cleaning/","commit_id":"04eaa113b6f00ba25a8199022623b079df8f71b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"629564bf3bac2194cacf6eeb958a4729f2afed1d","unresolved":false,"context_lines":[{"line_number":187,"context_line":"# From MANAGEABLE, a node may be made available"},{"line_number":188,"context_line":"# TODO(deva): add CLEAN* states to this path"},{"line_number":189,"context_line":"machine.add_transition(MANAGEABLE, AVAILABLE, \u0027provide\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":192,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_7c95013f","line":190,"updated":"2015-02-10 10:11:55.000000000","message":"The previous patch-set was addressing the path between MANAGEABLE and CLEANING, since the a node will go to available through cleaning. \n\nBut this patch-set removes that, any reasons for that? Are we going to address that path in a following up patch?\n\nRef: http://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html#proposed-change","commit_id":"04eaa113b6f00ba25a8199022623b079df8f71b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"629564bf3bac2194cacf6eeb958a4729f2afed1d","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Nodes may be put through cleaning from manageable, for example to ensure"},{"line_number":268,"context_line":"# a new node is ready for scheduling"},{"line_number":269,"context_line":"machine.add_transition(MANAGEABLE, CLEANFAIL, \u0027clean\u0027)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# An errored instance can be rebuilt"},{"line_number":272,"context_line":"# ironic/conductor/manager.py:do_node_deploy()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_bcf21998","line":269,"updated":"2015-02-10 10:11:55.000000000","message":"s/CLEANFAIL/CLEANING ?","commit_id":"04eaa113b6f00ba25a8199022623b079df8f71b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f69642a91a7e71278ff9c3a8eb309f19f476a100","unresolved":false,"context_lines":[{"line_number":260,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027provide\u0027)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# After cleaning of a manageable node, the node is available"},{"line_number":263,"context_line":"machine.add_transition(CLEANING, AVAILABLE, \u0027provide\u0027)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":266,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_61799581","line":263,"updated":"2015-02-11 16:28:53.000000000","message":"I believe it should be covered by #251, no? otherwise we have 2 paths: CLEANING -\u003e CLEANED -\u003e AVAILABLE (for clean action) and CLEANING -\u003e AVAILABLE (for provide action).","commit_id":"b4339143b9315138cc34897ef27dce3d75e41a49"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"83cbe93226f4bc54ee9c463d702a33cf5ca2f282","unresolved":false,"context_lines":[{"line_number":260,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027provide\u0027)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# After cleaning of a manageable node, the node is available"},{"line_number":263,"context_line":"machine.add_transition(CLEANING, AVAILABLE, \u0027provide\u0027)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":266,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_cdffd032","line":263,"in_reply_to":"da86d52c_61799581","updated":"2015-02-11 23:19:47.000000000","message":"Ah yes, this should have been removed. Good catch.","commit_id":"b4339143b9315138cc34897ef27dce3d75e41a49"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d036d236959c9ac91befcb2ccdce44198b05bba6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\"\"\" Node cleaning was successful.\"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"CLEANFAIL \u003d \u0027clean failed\u0027"},{"line_number":131,"context_line":"\"\"\" Node failed to cleaning. This requires operator intervention to"},{"line_number":132,"context_line":"resolve."},{"line_number":133,"context_line":"\"\"\""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_0b7430cd","line":131,"updated":"2015-02-13 20:25:27.000000000","message":"s/failed to cleaning/failed cleaning/","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc2f0e33c7e61691c98cec7e887f9e5c2d37f865","unresolved":false,"context_lines":[{"line_number":128,"context_line":"\"\"\" Node cleaning was successful.\"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"CLEANFAIL \u003d \u0027clean failed\u0027"},{"line_number":131,"context_line":"\"\"\" Node failed to cleaning. This requires operator intervention to"},{"line_number":132,"context_line":"resolve."},{"line_number":133,"context_line":"\"\"\""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_caf664f9","line":131,"in_reply_to":"da86d52c_0b7430cd","updated":"2015-02-16 22:48:40.000000000","message":"Done","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c4aeecae5f168abc752e4ca5b4da8bd32336477a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"machine.add_transition(DELETING, DELETED, \u0027verify\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Nodes go directly from deleted to cleaning, even if cleaning is a no-op"},{"line_number":250,"context_line":"machine.add_transition(DELETED, CLEANING, \u0027clean\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# If cleaning succeeds, it becomes CLEANED to allow a recheck"},{"line_number":253,"context_line":"machine.add_transition(CLEANING, CLEANED, \u0027verify\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_26ecaff3","line":250,"updated":"2015-02-13 13:49:22.000000000","message":"Hm, I think we were trying to get rid of this DELETED state; should we go straight from DELETING to CLEANING or am I missing something? (I see the \u0027verify\u0027 verb, I\u0027m not entirely sure why, though)","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc2f0e33c7e61691c98cec7e887f9e5c2d37f865","unresolved":false,"context_lines":[{"line_number":247,"context_line":"machine.add_transition(DELETING, DELETED, \u0027verify\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Nodes go directly from deleted to cleaning, even if cleaning is a no-op"},{"line_number":250,"context_line":"machine.add_transition(DELETED, CLEANING, \u0027clean\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# If cleaning succeeds, it becomes CLEANED to allow a recheck"},{"line_number":253,"context_line":"machine.add_transition(CLEANING, CLEANED, \u0027verify\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_4a8b5468","line":250,"in_reply_to":"da86d52c_26ecaff3","updated":"2015-02-16 22:48:40.000000000","message":"I misunderstood the direction here. We\u0027re going to drop it for this cycle, and possibly add it back next cycle (to allow verification after deleting, or something like that).","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7055580a349fee1eca579c7fba5c97062d84de28","unresolved":false,"context_lines":[{"line_number":247,"context_line":"machine.add_transition(DELETING, DELETED, \u0027verify\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Nodes go directly from deleted to cleaning, even if cleaning is a no-op"},{"line_number":250,"context_line":"machine.add_transition(DELETED, CLEANING, \u0027clean\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# If cleaning succeeds, it becomes CLEANED to allow a recheck"},{"line_number":253,"context_line":"machine.add_transition(CLEANING, CLEANED, \u0027verify\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_0a915c9a","line":250,"in_reply_to":"da86d52c_26ecaff3","updated":"2015-02-13 20:40:22.000000000","message":"The spec says DELET*\n\nhttp://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html\n\nWhich I think means it should have all three states.\n\n DELETED\n DELETING\n DELETEFAIL","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e47ff3568219dee276666f4e0d6435b2748d5b74","unresolved":false,"context_lines":[{"line_number":250,"context_line":"machine.add_transition(CLEANING, CLEANFAIL, \u0027fail\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# A node that fails cleaning may be put back through cleaning"},{"line_number":253,"context_line":"machine.add_transition(CLEANFAIL, CLEANING, \u0027clean\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# From MANAGEABLE, a node may be made available through cleaning"},{"line_number":256,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027clean\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_ef33ec10","line":253,"updated":"2015-02-17 10:46:04.000000000","message":"From CLEANFAIL the only way to pass it is going to CLEANING again. Is it a bit concerning? Should we be able to go from DEPLOYFAIL to MANAGEABLE in case we can\u0027t pass cleaning? (as a fallback)","commit_id":"70d33778db25adf0c546e9e51c3741a59af4d782"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"28f57826140fe29291b774348ebaa4aff8bfa83e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"machine.add_transition(CLEANING, CLEANFAIL, \u0027fail\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# A node that fails cleaning may be put back through cleaning"},{"line_number":253,"context_line":"machine.add_transition(CLEANFAIL, CLEANING, \u0027clean\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# From MANAGEABLE, a node may be made available through cleaning"},{"line_number":256,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027clean\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_b30791c8","line":253,"in_reply_to":"da86d52c_ef33ec10","updated":"2015-02-17 17:57:24.000000000","message":"That makes sense, I\u0027ll add.","commit_id":"70d33778db25adf0c546e9e51c3741a59af4d782"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e47ff3568219dee276666f4e0d6435b2748d5b74","unresolved":false,"context_lines":[{"line_number":253,"context_line":"machine.add_transition(CLEANFAIL, CLEANING, \u0027clean\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# From MANAGEABLE, a node may be made available through cleaning"},{"line_number":256,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027clean\u0027)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":259,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_4a5b06f6","line":256,"updated":"2015-02-17 10:46:04.000000000","message":"Isn\u0027t the verb here \"provide\" ? According to the state machine[1], it seems that users should call \"provide\" and if cleaning is enabled it will pass through cleaning as part of the process to move the machine from MANAGEABLE to AVAILABLE.\n\nI just want to avoid in having 2 actions that takes the node from A to B doing the same thing. (say \"clean\" takes it from MANAGEABLE to AVAILABLE... And \"provide\" also takes it from MANAGEABLE to AVAILABLE)\n\n[1] http://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html#proposed-change","commit_id":"70d33778db25adf0c546e9e51c3741a59af4d782"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"28f57826140fe29291b774348ebaa4aff8bfa83e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"machine.add_transition(CLEANFAIL, CLEANING, \u0027clean\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# From MANAGEABLE, a node may be made available through cleaning"},{"line_number":256,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027clean\u0027)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"},{"line_number":259,"context_line":"machine.add_transition(AVAILABLE, MANAGEABLE, \u0027manage\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_73a4394b","line":256,"in_reply_to":"da86d52c_4a5b06f6","updated":"2015-02-17 17:57:24.000000000","message":"I\u0027ll switch it because it\u0027s in the spec. It does seem odd to me that the actual transition is called \u0027provide\u0027 to CLEANING. I could see calling \u0027provide\u0027 in the API (though I switched that to cleaning as well, and will drop that).","commit_id":"70d33778db25adf0c546e9e51c3741a59af4d782"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"90ac00e1bac74d228a0a774d2e830d78358a4bb2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"# This state can also transition to error"},{"line_number":238,"context_line":"machine.add_transition(DELETING, ERROR, \u0027error\u0027)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# When finished deleting, a node is cleaned"},{"line_number":241,"context_line":"machine.add_transition(DELETING, CLEANING, \u0027clean\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# If cleaning succeeds, it becomes available for scheduling"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_84d92085","line":240,"updated":"2015-02-19 00:41:47.000000000","message":"s/a node is cleaned/a node will then be cleaned/","commit_id":"de0e96cb351bb09a680c7a1627bed77e10a3cf13"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cb78e70d65c1004d357d4c923d0d0e9adb96f103","unresolved":false,"context_lines":[{"line_number":237,"context_line":"# This state can also transition to error"},{"line_number":238,"context_line":"machine.add_transition(DELETING, ERROR, \u0027error\u0027)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# When finished deleting, a node is cleaned"},{"line_number":241,"context_line":"machine.add_transition(DELETING, CLEANING, \u0027clean\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# If cleaning succeeds, it becomes available for scheduling"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_841cc014","line":240,"in_reply_to":"da86d52c_84d92085","updated":"2015-02-19 01:10:05.000000000","message":"Done","commit_id":"de0e96cb351bb09a680c7a1627bed77e10a3cf13"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"90ac00e1bac74d228a0a774d2e830d78358a4bb2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"# outside-of-Ironic operations (like replacing hardware)"},{"line_number":254,"context_line":"machine.add_transition(CLEANFAIL, CLEANING, \u0027manage\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# From MANAGEABLE, a node may be made available through cleaning"},{"line_number":257,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027provide\u0027)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_0487f061","line":256,"updated":"2015-02-19 00:41:47.000000000","message":"s/made available through cleaning/moved to the cleaning state/","commit_id":"de0e96cb351bb09a680c7a1627bed77e10a3cf13"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cb78e70d65c1004d357d4c923d0d0e9adb96f103","unresolved":false,"context_lines":[{"line_number":253,"context_line":"# outside-of-Ironic operations (like replacing hardware)"},{"line_number":254,"context_line":"machine.add_transition(CLEANFAIL, CLEANING, \u0027manage\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# From MANAGEABLE, a node may be made available through cleaning"},{"line_number":257,"context_line":"machine.add_transition(MANAGEABLE, CLEANING, \u0027provide\u0027)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# From AVAILABLE, a node may be made unavailable by managing it"}],"source_content_type":"text/x-python","patch_set":15,"id":"da86d52c_e461fc39","line":256,"in_reply_to":"da86d52c_0487f061","updated":"2015-02-19 01:10:05.000000000","message":"Done","commit_id":"de0e96cb351bb09a680c7a1627bed77e10a3cf13"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"497929e976f6dca682519e07fd0a4a1ae9f18e77","unresolved":false,"context_lines":[{"line_number":247,"context_line":"machine.add_transition(DEPLOYFAIL, DELETING, \u0027delete\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# A delete may complete"},{"line_number":250,"context_line":"machine.add_transition(DELETING, AVAILABLE, \u0027done\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# This state can also transition to error"},{"line_number":253,"context_line":"machine.add_transition(DELETING, ERROR, \u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_f36dde05","side":"PARENT","line":250,"updated":"2015-02-20 18:10:32.000000000","message":"As per https://github.com/openstack/ironic-specs/blob/master/specs/kilo/new-ironic-state-machine.rst, there is a transition from DELETING -\u003e AVAILABLE..","commit_id":"20c79de1757329c0868968442b5e5e5dc2bedd55"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"35ef29d14356c66f03babbbd0a73812386c8cbc4","unresolved":false,"context_lines":[{"line_number":247,"context_line":"machine.add_transition(DEPLOYFAIL, DELETING, \u0027delete\u0027)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# A delete may complete"},{"line_number":250,"context_line":"machine.add_transition(DELETING, AVAILABLE, \u0027done\u0027)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"# This state can also transition to error"},{"line_number":253,"context_line":"machine.add_transition(DELETING, ERROR, \u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_19f9b3e9","side":"PARENT","line":250,"in_reply_to":"ba7be1f8_f36dde05","updated":"2015-02-20 18:35:48.000000000","message":"Ok i saw its already there above. Please ignore it.","commit_id":"20c79de1757329c0868968442b5e5e5dc2bedd55"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"35ef29d14356c66f03babbbd0a73812386c8cbc4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":45,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":46,"context_line":"        \u0027inspect\u0027: \u0027inspect\u0027,"},{"line_number":47,"context_line":"        \u0027fail\u0027: \u0027fail\u0027,"},{"line_number":48,"context_line":"        \u0027clean\u0027: \u0027clean\u0027,"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"\"\"\" Mapping of state-changing events that are PUT to the REST API"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_b94d0775","line":47,"updated":"2015-02-20 18:35:48.000000000","message":"fail should not come here. fail is a event already existing and it works without adding it here. IMO, only those verbs shall be added which need CLI interface and definitely fail doesnt need one. \nI think even \u0027clean\u0027 doesnt need CLI support as it is mainly triggered by \u0027deleted\u0027 which is already here.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc33ae0967e8101b3d78e8f5a143605628559c24","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":45,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":46,"context_line":"        \u0027inspect\u0027: \u0027inspect\u0027,"},{"line_number":47,"context_line":"        \u0027fail\u0027: \u0027fail\u0027,"},{"line_number":48,"context_line":"        \u0027clean\u0027: \u0027clean\u0027,"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"\"\"\" Mapping of state-changing events that are PUT to the REST API"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_b8778cd3","line":47,"in_reply_to":"ba7be1f8_4677a33a","updated":"2015-02-23 23:00:33.000000000","message":"Ahh, I misunderstood this dict\u0027s use then. I\u0027ll remove.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9ef8ffd0b20dca9ade959f85a47d1a8343eb9af2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \u0027manage\u0027: \u0027manage\u0027,"},{"line_number":45,"context_line":"        \u0027provide\u0027: \u0027provide\u0027,"},{"line_number":46,"context_line":"        \u0027inspect\u0027: \u0027inspect\u0027,"},{"line_number":47,"context_line":"        \u0027fail\u0027: \u0027fail\u0027,"},{"line_number":48,"context_line":"        \u0027clean\u0027: \u0027clean\u0027,"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"\"\"\" Mapping of state-changing events that are PUT to the REST API"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_4677a33a","line":47,"in_reply_to":"ba7be1f8_b94d0775","updated":"2015-02-23 10:13:41.000000000","message":"sounds correct, afaiui, this dict is to check if the requested target state is allowed to be requested. So requesting \u0027fail\u0027 is odd. \n\nThe \u0027clean\u0027 is automatically triggered from \u0027provide\u0027 and \u0027deleted\u0027 AFAIUI, so no need to be in the dict as well.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c251c1250293cf3b8b9646ef8ba55dc6aae62668","unresolved":false,"context_lines":[{"line_number":123,"context_line":"\"\"\" Node is being automatically cleaned to prepare it for provisioning. \"\"\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"CLEANFAIL \u003d \u0027clean failed\u0027"},{"line_number":126,"context_line":"\"\"\" Node failed cleaning. This requires operator intervention to"},{"line_number":127,"context_line":"resolve."},{"line_number":128,"context_line":"\"\"\""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_a3ec3fbc","line":126,"updated":"2015-02-26 06:18:34.000000000","message":"nit: no need to put resolve into next line i guess.","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"}],"ironic/conductor/manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"629564bf3bac2194cacf6eeb958a4729f2afed1d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"class ConductorManager(periodic_task.PeriodicTasks):"},{"line_number":172,"context_line":"    \"\"\"Ironic Conductor manager main class.\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # NOTE(rloo): This must be in sync with rpcapi.ConductorAPI\u0027s."},{"line_number":175,"context_line":"    RPC_API_VERSION \u003d \u00271.23\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    target \u003d messaging.Target(version\u003dRPC_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_3c8469d3","line":174,"updated":"2015-02-10 10:11:55.000000000","message":"we have to bump this version here since we are adding a new method","commit_id":"04eaa113b6f00ba25a8199022623b079df8f71b6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9780572020b8765f1ee7bffd6420ed1c04e5ce9f","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                    task.process_event(action)"},{"line_number":760,"context_line":"                except exception.InvalidState:"},{"line_number":761,"context_line":"                    raise exception.InvalidStateRequested("},{"line_number":762,"context_line":"                            action\u003daction, node\u003dtask.node.uuid,"},{"line_number":763,"context_line":"                            state\u003dtask.node.provision_state)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _do_provisioning_clean(self, task):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_a5ad4786","line":762,"updated":"2015-02-12 00:29:38.000000000","message":"nit: indentation, too much","commit_id":"b4339143b9315138cc34897ef27dce3d75e41a49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92a995438e5a0848100b5b65c2b006030cbb4808","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"        node.instance_info \u003d {}"},{"line_number":1557,"context_line":"        node.save()"},{"line_number":1558,"context_line":"    # Move the node into DELETED, then begin cleaning in the same worker."},{"line_number":1559,"context_line":"    # NOTE(JoshNang) we could"},{"line_number":1560,"context_line":"    task.process_event(\u0027verify\u0027)"},{"line_number":1561,"context_line":"    do_node_clean(task)"},{"line_number":1562,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_23e74648","line":1559,"updated":"2015-02-13 11:03:58.000000000","message":"unfinished comment?","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc2f0e33c7e61691c98cec7e887f9e5c2d37f865","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"        node.instance_info \u003d {}"},{"line_number":1557,"context_line":"        node.save()"},{"line_number":1558,"context_line":"    # Move the node into DELETED, then begin cleaning in the same worker."},{"line_number":1559,"context_line":"    # NOTE(JoshNang) we could"},{"line_number":1560,"context_line":"    task.process_event(\u0027verify\u0027)"},{"line_number":1561,"context_line":"    do_node_clean(task)"},{"line_number":1562,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_6ace58b9","line":1559,"in_reply_to":"da86d52c_23e74648","updated":"2015-02-16 22:48:40.000000000","message":"Ah yeah. But I don\u0027t need this transition without DELETED anymore.","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c4aeecae5f168abc752e4ca5b4da8bd32336477a","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"    # TODO(JoshNang) Implement"},{"line_number":1567,"context_line":"    task.process_event(\u0027clean\u0027)"},{"line_number":1568,"context_line":"    # Move to CLEANED"},{"line_number":1569,"context_line":"    task.process_event(\u0027verify\u0027)"},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"    # Move to AVAILABLE"},{"line_number":1572,"context_line":"    task.process_event(\u0027provide\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_86fc7b74","line":1569,"updated":"2015-02-13 13:49:22.000000000","message":"Is this necessary?","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc2f0e33c7e61691c98cec7e887f9e5c2d37f865","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"    # TODO(JoshNang) Implement"},{"line_number":1567,"context_line":"    task.process_event(\u0027clean\u0027)"},{"line_number":1568,"context_line":"    # Move to CLEANED"},{"line_number":1569,"context_line":"    task.process_event(\u0027verify\u0027)"},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"    # Move to AVAILABLE"},{"line_number":1572,"context_line":"    task.process_event(\u0027provide\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_8ad38c5e","line":1569,"in_reply_to":"da86d52c_86fc7b74","updated":"2015-02-16 22:48:40.000000000","message":"Done","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"075c049132706a6bad4b98ea71699f835a8eeae9","unresolved":false,"context_lines":[{"line_number":766,"context_line":"            task.process_event(\u0027clean\u0027)"},{"line_number":767,"context_line":"        except exception.InvalidState:"},{"line_number":768,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":769,"context_line":"                action\u003d\u0027clean\u0027, node\u003dtask.node.uuid,"},{"line_number":770,"context_line":"                state\u003dtask.node.provision_state)"},{"line_number":771,"context_line":"        self._do_node_clean(task)"},{"line_number":772,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_a92b6b80","line":769,"updated":"2015-02-18 18:09:02.000000000","message":"nit: node.uuid vs task.node.uuid, same nit on provision_state","commit_id":"2c0a9848649d121e5a359ee8118d01078f50fd46"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5fd84b7d4a6801233eb3ffdae4ca59867a175b1e","unresolved":false,"context_lines":[{"line_number":763,"context_line":"            node.save()"},{"line_number":764,"context_line":"        # Begin cleaning"},{"line_number":765,"context_line":"        try:"},{"line_number":766,"context_line":"            task.process_event(\u0027clean\u0027)"},{"line_number":767,"context_line":"        except exception.InvalidState:"},{"line_number":768,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":769,"context_line":"                action\u003d\u0027clean\u0027, node\u003dnode.uuid,"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_6a0dd33d","line":766,"updated":"2015-02-19 04:32:49.000000000","message":"Ditto as L814, can this raise exception ?","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":763,"context_line":"            node.save()"},{"line_number":764,"context_line":"        # Begin cleaning"},{"line_number":765,"context_line":"        try:"},{"line_number":766,"context_line":"            task.process_event(\u0027clean\u0027)"},{"line_number":767,"context_line":"        except exception.InvalidState:"},{"line_number":768,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":769,"context_line":"                action\u003d\u0027clean\u0027, node\u003dnode.uuid,"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_8c13e3b6","line":766,"in_reply_to":"da86d52c_6a0dd33d","updated":"2015-02-19 20:45:29.000000000","message":"It could raise InvalidState, which is already caught, or other exceptions like NoFreeWorkers, which should be handled by the provisioning_error_handler for this worker (though it looks like it doesn\u0027t handle everything yet. either way, not something to handle at this layer).","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5fd84b7d4a6801233eb3ffdae4ca59867a175b1e","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            task.driver.power.validate(task)"},{"line_number":780,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":781,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":782,"context_line":"            raise exception.InstanceCleanFailure(_("},{"line_number":783,"context_line":"                \"Failed to validate power driver interface. \""},{"line_number":784,"context_line":"                \"Can not clean instance. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":785,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_f527e8b3","line":782,"updated":"2015-02-19 04:32:49.000000000","message":"task.process_event(\u0027fail\u0027) and may be set node.last_error ??\n\nAlso exception.InstanceCleanFailure(reason\u003d_(.......))","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            task.driver.power.validate(task)"},{"line_number":780,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":781,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":782,"context_line":"            raise exception.InstanceCleanFailure(_("},{"line_number":783,"context_line":"                \"Failed to validate power driver interface. \""},{"line_number":784,"context_line":"                \"Can not clean instance. Error: %(msg)s\") % {\u0027msg\u0027: e})"},{"line_number":785,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_66640b22","line":782,"in_reply_to":"da86d52c_f527e8b3","updated":"2015-02-19 20:45:29.000000000","message":"I\u0027ll transition to cleanfail and not raise an exception. It will be easy to retry the cleaning then.","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5afebac0ce57416d7b8a2591aa783ee5402b6dba","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        \"\"\""},{"line_number":810,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dFalse) as task:"},{"line_number":811,"context_line":"            if (action \u003d\u003d \u0027provide\u0027 and"},{"line_number":812,"context_line":"                    task.node.provision_state \u003d\u003d states.MANAGEABLE):"},{"line_number":813,"context_line":"                try:"},{"line_number":814,"context_line":"                    task.process_event(\u0027provide\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_5d5a7f1e","line":811,"updated":"2015-02-19 17:27:47.000000000","message":"should this be:\n if (action \u003d\u003d states[\u0027provide\u0027] and\n\nIt seems somewhat redundant but I see it is done in:\n ironic/api/controllers/v1/node.py","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        \"\"\""},{"line_number":810,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dFalse) as task:"},{"line_number":811,"context_line":"            if (action \u003d\u003d \u0027provide\u0027 and"},{"line_number":812,"context_line":"                    task.node.provision_state \u003d\u003d states.MANAGEABLE):"},{"line_number":813,"context_line":"                try:"},{"line_number":814,"context_line":"                    task.process_event(\u0027provide\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_6c186fcd","line":811,"in_reply_to":"da86d52c_5d5a7f1e","updated":"2015-02-19 20:45:29.000000000","message":"Oh no, not redundant at all. If, for example, I spelled \u0027provide\u0027 wrong, it\u0027d be a semi-hard to track down error. Using constants like this is handy. (Not that \u0027provide\u0027 is hard to spell, but if you type \u0027decommissioning\u0027 20 times...)","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5fd84b7d4a6801233eb3ffdae4ca59867a175b1e","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            if (action \u003d\u003d \u0027provide\u0027 and"},{"line_number":812,"context_line":"                    task.node.provision_state \u003d\u003d states.MANAGEABLE):"},{"line_number":813,"context_line":"                try:"},{"line_number":814,"context_line":"                    task.process_event(\u0027provide\u0027,"},{"line_number":815,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":816,"context_line":"                                       call_args\u003d(self._do_node_clean, task),"},{"line_number":817,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_2a103b58","line":814,"updated":"2015-02-19 04:32:49.000000000","message":"Can this raise exception, given that we check the action and the current state before calling process_event ?","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            if (action \u003d\u003d \u0027provide\u0027 and"},{"line_number":812,"context_line":"                    task.node.provision_state \u003d\u003d states.MANAGEABLE):"},{"line_number":813,"context_line":"                try:"},{"line_number":814,"context_line":"                    task.process_event(\u0027provide\u0027,"},{"line_number":815,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":816,"context_line":"                                       call_args\u003d(self._do_node_clean, task),"},{"line_number":817,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_e672bb7a","line":814,"in_reply_to":"da86d52c_2a103b58","updated":"2015-02-19 20:45:29.000000000","message":"see above","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        # Begin cleaning"},{"line_number":771,"context_line":"        try:"},{"line_number":772,"context_line":"            task.process_event(\u0027clean\u0027)"},{"line_number":773,"context_line":"        except exception.InvalidState:"},{"line_number":774,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":775,"context_line":"                action\u003d\u0027clean\u0027, node\u003dnode.uuid,"},{"line_number":776,"context_line":"                state\u003dnode.provision_state)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_3d1763a5","line":773,"updated":"2015-02-20 02:33:26.000000000","message":"Again same question as in L824.  We know that we are at \u0027deleting\u0027 and we are about to start \u0027clean\u0027. I think there is no chance that this can throw exception","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        # Begin cleaning"},{"line_number":771,"context_line":"        try:"},{"line_number":772,"context_line":"            task.process_event(\u0027clean\u0027)"},{"line_number":773,"context_line":"        except exception.InvalidState:"},{"line_number":774,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":775,"context_line":"                action\u003d\u0027clean\u0027, node\u003dnode.uuid,"},{"line_number":776,"context_line":"                state\u003dnode.provision_state)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_32a1f447","line":773,"in_reply_to":"ba7be1f8_3d1763a5","updated":"2015-02-23 23:00:41.000000000","message":"We don\u0027t know that we\u0027re at deleting and we\u0027re about to start clean, though we most likely are. I can edit the DB and change the state (I\u0027ve unfortunately had to do this somewhat often). There\u0027s a call to the driver to do tear_down() and clean_up(). A downstream driver could change the state on us (they shouldn\u0027t, but could). The exception the fsm.py library raises has a pretty weak message (no node UUID), so in the unlikely case it does happen, we should catch it and give it a reasonable error message, so debugging this unlikely scenario is possible.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":803,"context_line":"                                   exception.MissingParameterValue,"},{"line_number":804,"context_line":"                                   exception.InvalidStateRequested,"},{"line_number":805,"context_line":"                                   exception.InstanceCleanFailure)"},{"line_number":806,"context_line":"    def do_provisioning_action(self, context, node_id, action):"},{"line_number":807,"context_line":"        \"\"\"RPC method to initiate certain provisioning state transitions."},{"line_number":808,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_bd919354","line":805,"updated":"2015-02-20 02:33:26.000000000","message":"This may be removed now.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":802,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":803,"context_line":"                                   exception.MissingParameterValue,"},{"line_number":804,"context_line":"                                   exception.InvalidStateRequested,"},{"line_number":805,"context_line":"                                   exception.InstanceCleanFailure)"},{"line_number":806,"context_line":"    def do_provisioning_action(self, context, node_id, action):"},{"line_number":807,"context_line":"        \"\"\"RPC method to initiate certain provisioning state transitions."},{"line_number":808,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_93dc5f14","line":805,"in_reply_to":"ba7be1f8_bd919354","updated":"2015-02-23 23:00:41.000000000","message":"Done","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":821,"context_line":"            if (action \u003d\u003d states.VERBS[\u0027provide\u0027] and"},{"line_number":822,"context_line":"                    task.node.provision_state \u003d\u003d states.MANAGEABLE):"},{"line_number":823,"context_line":"                try:"},{"line_number":824,"context_line":"                    task.process_event(\u0027provide\u0027,"},{"line_number":825,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":826,"context_line":"                                       call_args\u003d(self._do_node_clean, task),"},{"line_number":827,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_7dec7bc8","line":824,"updated":"2015-02-20 02:33:26.000000000","message":"My question in the previous patch was like this:\n\nWe have an if condition just above which checks if action \u003d\u003d \u0027provide\u0027 and current provision_state is manageable.  This is a valid transition with the current state (because we have already validated above), and I feel there is no chance of this throwing exception.InvalidState.  This is just like we calling task.process_event(\u0027done\u0027) without trying to catch the exception because we know that we are actually doing a valid transition.  Isn\u0027t this correct ?  Or may be I am missing something.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":821,"context_line":"            if (action \u003d\u003d states.VERBS[\u0027provide\u0027] and"},{"line_number":822,"context_line":"                    task.node.provision_state \u003d\u003d states.MANAGEABLE):"},{"line_number":823,"context_line":"                try:"},{"line_number":824,"context_line":"                    task.process_event(\u0027provide\u0027,"},{"line_number":825,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":826,"context_line":"                                       call_args\u003d(self._do_node_clean, task),"},{"line_number":827,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_934a9fc3","line":824,"in_reply_to":"ba7be1f8_7dec7bc8","updated":"2015-02-23 23:00:41.000000000","message":"This one I agree on. :)","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"35ef29d14356c66f03babbbd0a73812386c8cbc4","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            try:"},{"line_number":735,"context_line":"                task.process_event(\u0027delete\u0027,"},{"line_number":736,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":737,"context_line":"                                   call_args\u003d(self._do_node_tear_down, task),"},{"line_number":738,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":739,"context_line":"            except exception.InvalidState:"},{"line_number":740,"context_line":"                raise exception.InvalidStateRequested("}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_1e47d920","line":737,"updated":"2015-02-20 18:35:48.000000000","message":"Why is this change requied? Why the function needs to be part of class ConductorManager()","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc33ae0967e8101b3d78e8f5a143605628559c24","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            try:"},{"line_number":735,"context_line":"                task.process_event(\u0027delete\u0027,"},{"line_number":736,"context_line":"                                   callback\u003dself._spawn_worker,"},{"line_number":737,"context_line":"                                   call_args\u003d(self._do_node_tear_down, task),"},{"line_number":738,"context_line":"                                   err_handler\u003dprovisioning_error_handler)"},{"line_number":739,"context_line":"            except exception.InvalidState:"},{"line_number":740,"context_line":"                raise exception.InvalidStateRequested("}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_d37a57f0","line":737,"in_reply_to":"ba7be1f8_1e47d920","updated":"2015-02-23 23:00:33.000000000","message":"See below.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"35ef29d14356c66f03babbbd0a73812386c8cbc4","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                state\u003dnode.provision_state)"},{"line_number":777,"context_line":"        self._do_node_clean(task)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def _do_node_clean(self, task):"},{"line_number":780,"context_line":"        \"\"\"Internal RPC method to perform automated cleaning of a node.\"\"\""},{"line_number":781,"context_line":"        node \u003d task.node"},{"line_number":782,"context_line":"        LOG.debug(\u0027Starting cleaning for node %s\u0027 % node.uuid)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_3ee73d14","line":779,"updated":"2015-02-20 18:35:48.000000000","message":"This can be outside the class ConductorManager as the other spawned functions.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9ef8ffd0b20dca9ade959f85a47d1a8343eb9af2","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                state\u003dnode.provision_state)"},{"line_number":777,"context_line":"        self._do_node_clean(task)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def _do_node_clean(self, task):"},{"line_number":780,"context_line":"        \"\"\"Internal RPC method to perform automated cleaning of a node.\"\"\""},{"line_number":781,"context_line":"        node \u003d task.node"},{"line_number":782,"context_line":"        LOG.debug(\u0027Starting cleaning for node %s\u0027 % node.uuid)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_c6e8f3b6","line":779,"in_reply_to":"ba7be1f8_3ee73d14","updated":"2015-02-23 10:13:41.000000000","message":"Yeah just a nit but sounds more consistent indeed,  since all the others are also outside of this class scope","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc33ae0967e8101b3d78e8f5a143605628559c24","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                state\u003dnode.provision_state)"},{"line_number":777,"context_line":"        self._do_node_clean(task)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def _do_node_clean(self, task):"},{"line_number":780,"context_line":"        \"\"\"Internal RPC method to perform automated cleaning of a node.\"\"\""},{"line_number":781,"context_line":"        node \u003d task.node"},{"line_number":782,"context_line":"        LOG.debug(\u0027Starting cleaning for node %s\u0027 % node.uuid)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_96ba8d21","line":779,"in_reply_to":"ba7be1f8_c6e8f3b6","updated":"2015-02-23 23:00:33.000000000","message":"So it\u0027s hard to tell from this patch, because I haven\u0027t implemented the _do_node_clean bit until a later patch, but there will be a \"self._spawn_worker\" for each clean_step, which has to happen inside the ConductorManager. You can\u0027t really get back into the ConductorManager instance from the old way _do_node_tear_down() function was designed. I might be wrong here, but this seemed cleanest.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d30dff162ddf8cd5decc3d746743540e129b119","unresolved":false,"context_lines":[{"line_number":800,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":801,"context_line":"                                   exception.MissingParameterValue,"},{"line_number":802,"context_line":"                                   exception.InvalidStateRequested,"},{"line_number":803,"context_line":"                                   exception.InstanceCleanFailure)"},{"line_number":804,"context_line":"    def do_provisioning_action(self, context, node_id, action):"},{"line_number":805,"context_line":"        \"\"\"RPC method to initiate certain provisioning state transitions."},{"line_number":806,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_f8e556dc","line":803,"updated":"2015-02-24 15:56:03.000000000","message":"Seems not addressed from PS17.","commit_id":"f29ba7d97c4ef908411d6aa269acda5649c56190"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d30dff162ddf8cd5decc3d746743540e129b119","unresolved":false,"context_lines":[{"line_number":823,"context_line":"                                       callback\u003dself._spawn_worker,"},{"line_number":824,"context_line":"                                       call_args\u003d(self._do_node_clean, task),"},{"line_number":825,"context_line":"                                       err_handler\u003dprovisioning_error_handler)"},{"line_number":826,"context_line":"                except exception.InvalidState:"},{"line_number":827,"context_line":"                    raise exception.InvalidStateRequested("},{"line_number":828,"context_line":"                            action\u003d\u0027provide\u0027, node\u003dtask.node.uuid,"},{"line_number":829,"context_line":"                            state\u003dtask.node.provision_state)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_38744e67","line":826,"updated":"2015-02-24 15:56:03.000000000","message":"I think we agreed to remove this {try, except} in PS 17.","commit_id":"f29ba7d97c4ef908411d6aa269acda5649c56190"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eac147a9b889466f60be916699d395c5d4d12dc","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        except exception.InvalidState:"},{"line_number":775,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":776,"context_line":"                action\u003d\u0027clean\u0027, node\u003dnode.uuid,"},{"line_number":777,"context_line":"                state\u003dnode.provision_state)"},{"line_number":778,"context_line":"        self._do_node_clean(task)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def _do_node_clean(self, task):"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_768d9cd2","line":777,"updated":"2015-02-26 10:13:33.000000000","message":"why should this exception happen? and if it does, it\u0027s our fault, not user\u0027s (i.e. we messed state machine).","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"2aca204943778ada8222fe354f66e4c5c66f1638","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        except exception.InvalidState:"},{"line_number":775,"context_line":"            raise exception.InvalidStateRequested("},{"line_number":776,"context_line":"                action\u003d\u0027clean\u0027, node\u003dnode.uuid,"},{"line_number":777,"context_line":"                state\u003dnode.provision_state)"},{"line_number":778,"context_line":"        self._do_node_clean(task)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"    def _do_node_clean(self, task):"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_d5c70d43","line":777,"in_reply_to":"ba7be1f8_768d9cd2","updated":"2015-02-26 16:46:36.000000000","message":"Ramesh and I debated this before, so I\u0027m going to copy/paste my response: \n\nWe don\u0027t know that we\u0027re at deleting and we\u0027re about to start clean, though we most likely are. I can edit the DB and change the state (I\u0027ve unfortunately had to do this somewhat often). There\u0027s a call to the driver to do tear_down() and clean_up(). A downstream driver could change the state on us (they shouldn\u0027t, but could). The exception the fsm.py library raises has a pretty weak message (no node UUID), so in the unlikely case it does happen, we should catch it and give it a reasonable error message, so debugging this unlikely scenario is possible.","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c251c1250293cf3b8b9646ef8ba55dc6aae62668","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":789,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":790,"context_line":"            node.last_error \u003d (_(\u0027Failed to validate power driver interface. \u0027"},{"line_number":791,"context_line":"                               \u0027Can not clean instance. Error: %(msg)s\u0027) %"},{"line_number":792,"context_line":"                               {\u0027msg\u0027: e})"},{"line_number":793,"context_line":"            task.process_event(\u0027fail\u0027)"},{"line_number":794,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_e3cd5732","line":791,"updated":"2015-02-26 06:18:34.000000000","message":"nit: can be substitution with %s since only one substitution.","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eac147a9b889466f60be916699d395c5d4d12dc","unresolved":false,"context_lines":[{"line_number":788,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":789,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":790,"context_line":"            node.last_error \u003d (_(\u0027Failed to validate power driver interface. \u0027"},{"line_number":791,"context_line":"                               \u0027Can not clean instance. Error: %(msg)s\u0027) %"},{"line_number":792,"context_line":"                               {\u0027msg\u0027: e})"},{"line_number":793,"context_line":"            task.process_event(\u0027fail\u0027)"},{"line_number":794,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_d6b5687e","line":791,"in_reply_to":"ba7be1f8_e3cd5732","updated":"2015-02-26 10:13:33.000000000","message":"nit2: indentation","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"79c0bd2495a62888db0b14bbd39fca67286bcf52","unresolved":false,"context_lines":[{"line_number":794,"context_line":"            return"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        # TODO(JoshNang) Implement"},{"line_number":797,"context_line":"        # Move to AVAILABLE"},{"line_number":798,"context_line":"        LOG.debug(\u0027Cleaning complete for node %s\u0027 % node.uuid)"},{"line_number":799,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":800,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_669ecbba","line":797,"updated":"2015-02-26 16:51:24.000000000","message":"it\u0027s actually moving to available no?\n\nfrom states.py: \n machine.add_transition(CLEANING, AVAILABLE, \u0027done\u0027)","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eac147a9b889466f60be916699d395c5d4d12dc","unresolved":false,"context_lines":[{"line_number":795,"context_line":""},{"line_number":796,"context_line":"        # TODO(JoshNang) Implement"},{"line_number":797,"context_line":"        # Move to AVAILABLE"},{"line_number":798,"context_line":"        LOG.debug(\u0027Cleaning complete for node %s\u0027 % node.uuid)"},{"line_number":799,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    @messaging.expected_exceptions(exception.NoFreeConductorWorker,"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_16b38098","line":798,"updated":"2015-02-26 10:13:33.000000000","message":"nit: s/%/,/","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"629564bf3bac2194cacf6eeb958a4729f2afed1d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":73,"context_line":"    RPC_API_VERSION \u003d \u00271.23\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":76,"context_line":"        super(ConductorAPI, self).__init__()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_dc1b4dc8","line":73,"updated":"2015-02-10 10:11:55.000000000","message":"bump","commit_id":"04eaa113b6f00ba25a8199022623b079df8f71b6"}],"ironic/tests/api/v1/test_nodes.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c4aeecae5f168abc752e4ca5b4da8bd32336477a","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"        self.assertEqual(406, ret.status_code)"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027do_provisioning_action\u0027)"},{"line_number":1268,"context_line":"    def test_provide_from_manage(self, mock_dpa):"},{"line_number":1269,"context_line":"        self.node.provision_state \u003d states.MANAGEABLE"},{"line_number":1270,"context_line":"        self.node.save()"},{"line_number":1271,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_a6017f6c","line":1268,"updated":"2015-02-13 13:49:22.000000000","message":"Should probably change the test name as well :P","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc2f0e33c7e61691c98cec7e887f9e5c2d37f865","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"        self.assertEqual(406, ret.status_code)"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"    @mock.patch.object(rpcapi.ConductorAPI, \u0027do_provisioning_action\u0027)"},{"line_number":1268,"context_line":"    def test_provide_from_manage(self, mock_dpa):"},{"line_number":1269,"context_line":"        self.node.provision_state \u003d states.MANAGEABLE"},{"line_number":1270,"context_line":"        self.node.save()"},{"line_number":1271,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_aa3f7086","line":1268,"in_reply_to":"da86d52c_a6017f6c","updated":"2015-02-16 22:48:40.000000000","message":"Done","commit_id":"04feaf2caaff1789745200b0e57e6a7387359b62"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5fd84b7d4a6801233eb3ffdae4ca59867a175b1e","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"        # test when driver.deploy.tear_down raises exception"},{"line_number":1325,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":1326,"context_line":"                                      provision_state\u003dstates.DELETING,"},{"line_number":1327,"context_line":"                                      target_provision_state\u003dstates.CLEANING,"},{"line_number":1328,"context_line":"                                      instance_info\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_5b6f03c4","line":1327,"updated":"2015-02-19 04:32:49.000000000","message":"Shouldn\u0027t this be states.AVAILABLE ? Normalling we don\u0027t have target_provision_state as \"xxxxing\".","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"        # test when driver.deploy.tear_down raises exception"},{"line_number":1325,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":1326,"context_line":"                                      provision_state\u003dstates.DELETING,"},{"line_number":1327,"context_line":"                                      target_provision_state\u003dstates.CLEANING,"},{"line_number":1328,"context_line":"                                      instance_info\u003d{\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_f2827afd","line":1327,"in_reply_to":"da86d52c_5b6f03c4","updated":"2015-02-19 20:45:29.000000000","message":"Done","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5fd84b7d4a6801233eb3ffdae4ca59867a175b1e","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY)"},{"line_number":1362,"context_line":"        mock_clean.assert_called_once_with(mock.ANY)"},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.ConductorManager._do_node_clean\u0027)"},{"line_number":1365,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeDeploy.tear_down\u0027)"},{"line_number":1366,"context_line":"    def _test_do_node_tear_down_from_state(self, init_state, mock_tear_down,"},{"line_number":1367,"context_line":"                                           mock_clean):"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_1bd58b42","line":1364,"updated":"2015-02-19 04:32:49.000000000","message":"May be add a test case with _do_node_clean() throwing exception.InstanceCleanFailure","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY)"},{"line_number":1362,"context_line":"        mock_clean.assert_called_once_with(mock.ANY)"},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.ConductorManager._do_node_clean\u0027)"},{"line_number":1365,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeDeploy.tear_down\u0027)"},{"line_number":1366,"context_line":"    def _test_do_node_tear_down_from_state(self, init_state, mock_tear_down,"},{"line_number":1367,"context_line":"                                           mock_clean):"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_320fb22f","line":1364,"in_reply_to":"da86d52c_1bd58b42","updated":"2015-02-19 20:45:29.000000000","message":"See comments on manager.py about throwing errors in do_node_clean.","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5fd84b7d4a6801233eb3ffdae4ca59867a175b1e","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":1370,"context_line":"                                      uuid\u003dironic_utils.generate_uuid(),"},{"line_number":1371,"context_line":"                                      provision_state\u003dinit_state,"},{"line_number":1372,"context_line":"                                      target_provision_state\u003dstates.NOSTATE)"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"        self.service.do_node_tear_down(self.context, node.uuid)"},{"line_number":1375,"context_line":"        self.service._worker_pool.waitall()"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_9b925b9d","line":1372,"updated":"2015-02-19 04:32:49.000000000","message":"Shouldn\u0027t this be AVAILABLE now ?","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f4044ce14447a5282bd4710bddf232fdd14156c7","unresolved":false,"context_lines":[{"line_number":1369,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":1370,"context_line":"                                      uuid\u003dironic_utils.generate_uuid(),"},{"line_number":1371,"context_line":"                                      provision_state\u003dinit_state,"},{"line_number":1372,"context_line":"                                      target_provision_state\u003dstates.NOSTATE)"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"        self.service.do_node_tear_down(self.context, node.uuid)"},{"line_number":1375,"context_line":"        self.service._worker_pool.waitall()"}],"source_content_type":"text/x-python","patch_set":16,"id":"da86d52c_170d403e","line":1372,"in_reply_to":"da86d52c_9b925b9d","updated":"2015-02-19 20:45:29.000000000","message":"Done","commit_id":"7d8d7d5bd36557569ce88d6b2715a1a207a0f6e5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.ConductorManager._do_node_clean\u0027)"},{"line_number":1352,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeDeploy.tear_down\u0027)"},{"line_number":1353,"context_line":"    def test_do_node_tear_down_ok(self, mock_tear_down, mock_clean):"},{"line_number":1354,"context_line":"        # test when driver.deploy.tear_down returns DELETED"},{"line_number":1355,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":1356,"context_line":"                                      provision_state\u003dstates.DELETING,"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_dd2e47a5","line":1353,"updated":"2015-02-20 02:33:26.000000000","message":"Should be renamed to test__do_node_tear_down_ok. Ditto for other test cases.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        mock_tear_down.return_value \u003d states.DELETED"},{"line_number":1363,"context_line":"        self.service._do_node_tear_down(task)"},{"line_number":1364,"context_line":"        node.refresh()"},{"line_number":1365,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"},{"line_number":1366,"context_line":"        self.assertEqual(states.AVAILABLE, node.target_provision_state)"},{"line_number":1367,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":1368,"context_line":"        self.assertEqual({}, node.instance_info)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_3d368304","line":1365,"updated":"2015-02-20 02:33:26.000000000","message":"I was a little confused about why we would assert CLEANING here instead of AVAILABLE, then I found that we are mocking _do_node_clean() here entirely and it causes the state transition.  I suggest we don\u0027t mock _do_node_clean() here and just make it run so that it transitions to AVAILABLE.  We can mock the FakePower.validate instead.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        mock_tear_down.return_value \u003d states.DELETED"},{"line_number":1363,"context_line":"        self.service._do_node_tear_down(task)"},{"line_number":1364,"context_line":"        node.refresh()"},{"line_number":1365,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"},{"line_number":1366,"context_line":"        self.assertEqual(states.AVAILABLE, node.target_provision_state)"},{"line_number":1367,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":1368,"context_line":"        self.assertEqual({}, node.instance_info)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_d6908545","line":1365,"in_reply_to":"ba7be1f8_3d368304","updated":"2015-02-23 23:00:41.000000000","message":"No, because, _do_node_clean is going to do a lot more than just validate power in subsequent patches. I mocked _do_node_clean to keep this test self contained.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        self.service.do_node_tear_down(self.context, node.uuid)"},{"line_number":1383,"context_line":"        self.service._worker_pool.waitall()"},{"line_number":1384,"context_line":"        node.refresh()"},{"line_number":1385,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"},{"line_number":1386,"context_line":"        self.assertEqual(states.AVAILABLE, node.target_provision_state)"},{"line_number":1387,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":1388,"context_line":"        self.assertEqual({}, node.instance_info)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_bd08b32e","line":1385,"updated":"2015-02-20 02:33:26.000000000","message":"Ditto as above, to make a valid test case, I think we should check for states.AVAILABLE.  Asserting for states.CLEANING after calling _do_node_tear_down doesn\u0027t make logical sense and is confusing.","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY)"},{"line_number":1390,"context_line":"        mock_clean.assert_called_once_with(mock.ANY)"},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"    def test_do_node_tear_down_from_valid_states(self):"},{"line_number":1393,"context_line":"        valid_states \u003d [states.ACTIVE, states.DEPLOYWAIT, states.DEPLOYFAIL,"},{"line_number":1394,"context_line":"                        states.ERROR]"},{"line_number":1395,"context_line":"        self._start_service()"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_af679ae9","line":1392,"updated":"2015-02-20 02:33:26.000000000","message":"test__","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY)"},{"line_number":1390,"context_line":"        mock_clean.assert_called_once_with(mock.ANY)"},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"    def test_do_node_tear_down_from_valid_states(self):"},{"line_number":1393,"context_line":"        valid_states \u003d [states.ACTIVE, states.DEPLOYWAIT, states.DEPLOYFAIL,"},{"line_number":1394,"context_line":"                        states.ERROR]"},{"line_number":1395,"context_line":"        self._start_service()"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_964a8dc3","line":1392,"in_reply_to":"ba7be1f8_af679ae9","updated":"2015-02-23 23:00:41.000000000","message":"Done","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1cd7756fa244a278d0ba9cffa0a5cfd4c0d43b76","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"        mock_spawn.assert_called_with(self.service._do_node_clean, mock.ANY)"},{"line_number":1478,"context_line":""},{"line_number":1479,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakePower.validate\u0027)"},{"line_number":1480,"context_line":"    def test_do_node_clean_validate_fail(self, mock_validate):"},{"line_number":1481,"context_line":"        # InvalidParameterValue should be cause node to go to CLEANFAIL"},{"line_number":1482,"context_line":"        mock_validate.side_effect \u003d exception.InvalidParameterValue(\u0027error\u0027)"},{"line_number":1483,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_ef4a7254","line":1480,"updated":"2015-02-20 02:33:26.000000000","message":"test__","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"f44173a6749fd797cf2475a4e4b34a9a6a12cc79","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"        mock_spawn.assert_called_with(self.service._do_node_clean, mock.ANY)"},{"line_number":1478,"context_line":""},{"line_number":1479,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakePower.validate\u0027)"},{"line_number":1480,"context_line":"    def test_do_node_clean_validate_fail(self, mock_validate):"},{"line_number":1481,"context_line":"        # InvalidParameterValue should be cause node to go to CLEANFAIL"},{"line_number":1482,"context_line":"        mock_validate.side_effect \u003d exception.InvalidParameterValue(\u0027error\u0027)"},{"line_number":1483,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":17,"id":"ba7be1f8_f67d89e8","line":1480,"in_reply_to":"ba7be1f8_ef4a7254","updated":"2015-02-23 23:00:41.000000000","message":"Done","commit_id":"3859e33a1bf1c41f592910f3d473f4069d0a1612"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"35ef29d14356c66f03babbbd0a73812386c8cbc4","unresolved":false,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"},{"line_number":1361,"context_line":"        self._start_service()"},{"line_number":1362,"context_line":"        mock_tear_down.return_value \u003d states.DELETED"},{"line_number":1363,"context_line":"        self.service._do_node_tear_down(task)"},{"line_number":1364,"context_line":"        node.refresh()"},{"line_number":1365,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_3e773dd6","line":1362,"updated":"2015-02-20 18:35:48.000000000","message":"The state changes do not show any transition to DELETED state.\nThis line is not required any more with state model in place.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"cc33ae0967e8101b3d78e8f5a143605628559c24","unresolved":false,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        task \u003d task_manager.TaskManager(self.context, node.uuid)"},{"line_number":1361,"context_line":"        self._start_service()"},{"line_number":1362,"context_line":"        mock_tear_down.return_value \u003d states.DELETED"},{"line_number":1363,"context_line":"        self.service._do_node_tear_down(task)"},{"line_number":1364,"context_line":"        node.refresh()"},{"line_number":1365,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba7be1f8_32281434","line":1362,"in_reply_to":"ba7be1f8_3e773dd6","updated":"2015-02-23 23:00:33.000000000","message":"Ahh good catch. Updated throughout the file.","commit_id":"82d40f724b88d4f4cd50d7334abdb1076f853575"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d30dff162ddf8cd5decc3d746743540e129b119","unresolved":false,"context_lines":[{"line_number":1351,"context_line":""},{"line_number":1352,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.ConductorManager._do_node_clean\u0027)"},{"line_number":1353,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakeDeploy.tear_down\u0027)"},{"line_number":1354,"context_line":"    def test_do_node_tear_down_ok(self, mock_tear_down, mock_clean):"},{"line_number":1355,"context_line":"        # test when driver.deploy.tear_down returns DELETED"},{"line_number":1356,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":1357,"context_line":"                                      provision_state\u003dstates.DELETING,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_f8971638","line":1354,"updated":"2015-02-24 15:56:03.000000000","message":"Seems not addressed from PS17.","commit_id":"f29ba7d97c4ef908411d6aa269acda5649c56190"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d30dff162ddf8cd5decc3d746743540e129b119","unresolved":false,"context_lines":[{"line_number":1390,"context_line":"        mock_tear_down.assert_called_once_with(mock.ANY)"},{"line_number":1391,"context_line":"        mock_clean.assert_called_once_with(mock.ANY)"},{"line_number":1392,"context_line":""},{"line_number":1393,"context_line":"    def test_do_node_tear_down_from_valid_states(self):"},{"line_number":1394,"context_line":"        valid_states \u003d [states.ACTIVE, states.DEPLOYWAIT, states.DEPLOYFAIL,"},{"line_number":1395,"context_line":"                        states.ERROR]"},{"line_number":1396,"context_line":"        self._start_service()"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_58a2e299","line":1393,"updated":"2015-02-24 15:56:03.000000000","message":"Seems not addressed from PS17.","commit_id":"f29ba7d97c4ef908411d6aa269acda5649c56190"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d30dff162ddf8cd5decc3d746743540e129b119","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        mock_spawn.assert_called_with(self.service._do_node_clean, mock.ANY)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakePower.validate\u0027)"},{"line_number":1481,"context_line":"    def test_do_node_clean_validate_fail(self, mock_validate):"},{"line_number":1482,"context_line":"        # InvalidParameterValue should be cause node to go to CLEANFAIL"},{"line_number":1483,"context_line":"        mock_validate.side_effect \u003d exception.InvalidParameterValue(\u0027error\u0027)"},{"line_number":1484,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":22,"id":"ba7be1f8_1886aa13","line":1481,"updated":"2015-02-24 15:56:03.000000000","message":"Seems not addressed from PS17.","commit_id":"f29ba7d97c4ef908411d6aa269acda5649c56190"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c251c1250293cf3b8b9646ef8ba55dc6aae62668","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"        self._start_service()"},{"line_number":1471,"context_line":"        self.service.do_provisioning_action(self.context, node.uuid, \u0027provide\u0027)"},{"line_number":1472,"context_line":"        node.refresh()"},{"line_number":1473,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"},{"line_number":1474,"context_line":"        self.assertEqual(states.AVAILABLE, node.target_provision_state)"},{"line_number":1475,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":1476,"context_line":"        mock_spawn.assert_called_with(self.service._do_node_clean, mock.ANY)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_03442b72","line":1473,"updated":"2015-02-26 06:18:34.000000000","message":"i am still against this test case asserting the state CLEANING as the end state after doing cleaning (just because we mock _spawn_worker()","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"79c0bd2495a62888db0b14bbd39fca67286bcf52","unresolved":false,"context_lines":[{"line_number":1470,"context_line":"        self._start_service()"},{"line_number":1471,"context_line":"        self.service.do_provisioning_action(self.context, node.uuid, \u0027provide\u0027)"},{"line_number":1472,"context_line":"        node.refresh()"},{"line_number":1473,"context_line":"        self.assertEqual(states.CLEANING, node.provision_state)"},{"line_number":1474,"context_line":"        self.assertEqual(states.AVAILABLE, node.target_provision_state)"},{"line_number":1475,"context_line":"        self.assertIsNone(node.last_error)"},{"line_number":1476,"context_line":"        mock_spawn.assert_called_with(self.service._do_node_clean, mock.ANY)"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba7be1f8_a625235d","line":1473,"in_reply_to":"ba7be1f8_03442b72","updated":"2015-02-26 16:51:24.000000000","message":"+1 indeed it looks a bit misguiding","commit_id":"c4e808b5baf16cfb9f228577b6fdf1a5bd107e3a"}]}
