)]}'
{"ironic/common/exception.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8a2c5ac11ce78b54a23f02a2cc8503faae9232a8","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    message \u003d _(\"%(operation)s failed, error: %(error)s\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class IloOperationNotSupported(IronicException):"},{"line_number":450,"context_line":"    message \u003d _(\"%(operation)s not supported. error: %(error)s\")"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_062e3d43","line":449,"updated":"2015-02-11 11:38:34.000000000","message":"Seems that it should be moved to pxe_ilo driver change request as it is not used in this change.","commit_id":"3c1e40e695c35b4623ea4ff737bc146a5926a33b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8f37fd34cb3ed3c67ec6e53d72092b8815cfb59d","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    message \u003d _(\"%(operation)s failed, error: %(error)s\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class IloOperationNotSupported(IronicException):"},{"line_number":450,"context_line":"    message \u003d _(\"%(operation)s not supported. error: %(error)s\")"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_757f9c17","line":449,"in_reply_to":"da86d52c_062e3d43","updated":"2015-02-11 14:11:11.000000000","message":"Done","commit_id":"3c1e40e695c35b4623ea4ff737bc146a5926a33b"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    return os.path.join(get_root_dir(), PXE_CFG_DIR_NAME, mac_file_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def _get_pxe_ip_address_path(ip_address, hex_form\u003dFalse):"},{"line_number":127,"context_line":"    \"\"\"Convert an ipv4 address into a PXE config file name."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param ip_address: A valid IPv4 address string in the format \u0027n.n.n.n\u0027."}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_edd24b33","line":126,"updated":"2015-02-09 15:22:38.000000000","message":"If you\u0027re saying about backwards compatibility then maybe it\u0027s better to set the default to True?","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    return os.path.join(get_root_dir(), PXE_CFG_DIR_NAME, mac_file_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"def _get_pxe_ip_address_path(ip_address, hex_form\u003dFalse):"},{"line_number":127,"context_line":"    \"\"\"Convert an ipv4 address into a PXE config file name."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param ip_address: A valid IPv4 address string in the format \u0027n.n.n.n\u0027."}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_55403d35","line":126,"in_reply_to":"da86d52c_edd24b33","updated":"2015-02-09 16:31:02.000000000","message":"Have kept default as \u0027False\u0027 as going forward we wont be needing it. It is only for Juno release where UEFI bootloader was elilo. When user upgrades, we need this only to cleanup the files created by elilo, if they exist.\nIt would be called onlu once, in clean_up_pxe_config()","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                continue"},{"line_number":231,"context_line":"            utils.unlink_without_raise(ip_address_path)"},{"line_number":232,"context_line":"            # Cleaning up any files, if node were to be created during Juno"},{"line_number":233,"context_line":"            # is getiing tear doen in Kilo."},{"line_number":234,"context_line":"            utils.unlink_without_raise(hex_ip_path)"},{"line_number":235,"context_line":"    else:"},{"line_number":236,"context_line":"        for mac in driver_utils.get_node_mac_addresses(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3144b8b6","line":233,"updated":"2015-02-09 17:24:46.000000000","message":"it is getting torn down in Kilo\n\n??","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                continue"},{"line_number":231,"context_line":"            utils.unlink_without_raise(ip_address_path)"},{"line_number":232,"context_line":"            # Cleaning up any files, if node were to be created during Juno"},{"line_number":233,"context_line":"            # is getiing tear doen in Kilo."},{"line_number":234,"context_line":"            utils.unlink_without_raise(hex_ip_path)"},{"line_number":235,"context_line":"    else:"},{"line_number":236,"context_line":"        for mac in driver_utils.get_node_mac_addresses(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ba015d6c","line":233,"in_reply_to":"da86d52c_3144b8b6","updated":"2015-02-10 13:43:05.000000000","message":"Yes, we would be moving to grub2 instead of elilo. grub2 support secure boot and is kind of getting standardized.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":284,"context_line":"        rre \u003d re.compile(r\u0027ROOT_UUID\u0027)"},{"line_number":285,"context_line":"        dre \u003d re.compile(\u0027^set default\u003d.*$\u0027)"},{"line_number":286,"context_line":"        boot_line \u003d \u0027set default\u003d\\\"boot\\\"\u0027"},{"line_number":287,"context_line":"    else:"},{"line_number":288,"context_line":"        rre \u003d re.compile(r\u0027\\{\\{ ROOT \\}\\}\u0027)"},{"line_number":289,"context_line":"        pxe_cmd \u003d \u0027goto\u0027 if CONF.pxe.ipxe_enabled else \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_51a12ca8","line":286,"updated":"2015-02-09 17:24:46.000000000","message":"I don\u0027t think escaping the double-quotes is needed.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    try:"},{"line_number":308,"context_line":"        p_boot_mode \u003d ilo_object.get_pending_boot_mode()"},{"line_number":309,"context_line":"    except ilo_client.IloCommandNotSupportedError:"},{"line_number":310,"context_line":"        p_boot_mode \u003d DEFAULT_BOOT_MODE"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    if BOOT_MODE_ILO_TO_GENERIC[p_boot_mode.lower()] \u003d\u003d boot_mode:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_8821bdb6","line":309,"updated":"2015-02-09 15:22:38.000000000","message":"Should it be changed to ilo_error also?","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    try:"},{"line_number":308,"context_line":"        p_boot_mode \u003d ilo_object.get_pending_boot_mode()"},{"line_number":309,"context_line":"    except ilo_client.IloCommandNotSupportedError:"},{"line_number":310,"context_line":"        p_boot_mode \u003d DEFAULT_BOOT_MODE"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    if BOOT_MODE_ILO_TO_GENERIC[p_boot_mode.lower()] \u003d\u003d boot_mode:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d5818d4e","line":309,"in_reply_to":"da86d52c_8821bdb6","updated":"2015-02-09 16:31:02.000000000","message":"yes.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    boot_mode \u003d driver_utils.get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":340,"context_line":"    if boot_mode is not None:"},{"line_number":341,"context_line":"        LOG.debug(_LI(\"Node %(uuid)s boot mode is set to %(boot_mode)s\"),"},{"line_number":342,"context_line":"                 {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":343,"context_line":"        set_boot_mode(node, boot_mode)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_8180b38c","line":342,"updated":"2015-02-09 17:24:46.000000000","message":"nit: indentation, one more space needed.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    boot_mode \u003d driver_utils.get_node_capability(node, \u0027boot_mode\u0027)"},{"line_number":340,"context_line":"    if boot_mode is not None:"},{"line_number":341,"context_line":"        LOG.debug(_LI(\"Node %(uuid)s boot mode is set to %(boot_mode)s\"),"},{"line_number":342,"context_line":"                 {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":343,"context_line":"        set_boot_mode(node, boot_mode)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_6b8f1524","line":342,"in_reply_to":"da86d52c_8180b38c","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"44f9396753eee04860327e9e316f8b89771f8245","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    \"\"\""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    operation \u003d _(\"Get secure boot mode\")"},{"line_number":459,"context_line":"    LOG.debug(\"Retrive Secure Boot state for  Node %s.\", task.node.uuid)"},{"line_number":460,"context_line":"    secure_boot_state \u003d False"},{"line_number":461,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_582817e2","line":459,"updated":"2015-03-06 17:18:57.000000000","message":"super nit: dbl space after \"for\"","commit_id":"20a12dabcc2fe0097fe63aa5e7fd8da731bc6cd9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"34ba8163008bae6f19aae441f4c46e895981ee7c","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    \"\"\""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    operation \u003d _(\"Get secure boot mode\")"},{"line_number":459,"context_line":"    LOG.debug(\"Retrive Secure Boot state for  Node %s.\", task.node.uuid)"},{"line_number":460,"context_line":"    secure_boot_state \u003d False"},{"line_number":461,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"9a80dd14_727fa566","line":459,"in_reply_to":"9a80dd14_582817e2","updated":"2015-03-07 06:48:43.000000000","message":"Done","commit_id":"20a12dabcc2fe0097fe63aa5e7fd8da731bc6cd9"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"543979f1bc87dc7681901d139590e1dc0a4ae610","unresolved":false,"context_lines":[{"line_number":333,"context_line":"     This method updates the \u0027boot_mode\u0027 capability in node and sets"},{"line_number":334,"context_line":"     boot mode for next boot."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    :param task: Task object."},{"line_number":337,"context_line":"    \"\"\""},{"line_number":338,"context_line":"    node \u003d task.node"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_4f9ec6b9","line":336,"updated":"2015-03-12 06:28:04.000000000","message":":raises: IloOperationError  ? if set_boot_mode fails?","commit_id":"8f4c783477737e8885d60e4e1c7c73f9e0fbe6e2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"da7660e5f62690e879e520ad64299ec63686d3e2","unresolved":false,"context_lines":[{"line_number":333,"context_line":"     This method updates the \u0027boot_mode\u0027 capability in node and sets"},{"line_number":334,"context_line":"     boot mode for next boot."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    :param task: Task object."},{"line_number":337,"context_line":"    \"\"\""},{"line_number":338,"context_line":"    node \u003d task.node"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_71960c96","line":336,"in_reply_to":"9a80dd14_4f9ec6b9","updated":"2015-03-12 08:17:58.000000000","message":"Done","commit_id":"8f4c783477737e8885d60e4e1c7c73f9e0fbe6e2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b28767ebc63a446d440cd8207757b0ef9b5db4d4","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    try:"},{"line_number":494,"context_line":"        ilo_object.set_secure_boot_mode(flag)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":497,"context_line":"                  {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"}],"source_content_type":"text/x-python","patch_set":33,"id":"9a80dd14_13e0cf95","line":496,"updated":"2015-03-16 20:04:52.000000000","message":"this just looks odd to me, would it be easier to add node uuid to the above where you set operation (line 490) and use that for this log message?","commit_id":"378d452ffdcd4f7b0989c2e7411f485b1978f971"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"92d07b02117165d3b704bd8be9d45fed7a908854","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    try:"},{"line_number":494,"context_line":"        ilo_object.set_secure_boot_mode(flag)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":497,"context_line":"                  {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"}],"source_content_type":"text/x-python","patch_set":33,"id":"9a80dd14_32867b14","line":496,"in_reply_to":"9a80dd14_13e0cf95","updated":"2015-03-17 17:22:46.000000000","message":"Done","commit_id":"378d452ffdcd4f7b0989c2e7411f485b1978f971"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3299c46a2ec82693dfdc2b96440f5e1641ebcb0a","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        if current_boot_mode \u003d\u003d \u0027UEFI\u0027:"},{"line_number":467,"context_line":"            secure_boot_state \u003d ilo_object.get_secure_boot_mode()"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":470,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":471,"context_line":"                                                 error\u003dilo_exception)"},{"line_number":472,"context_line":"    except ilo_error.IloError as ilo_exception:"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_c650200d","line":469,"updated":"2015-03-17 09:21:32.000000000","message":"nit: \n\n  except (ilo_error.IloCommandNotSupportedError, ilo_error.IloError) as ilo_exception:","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"349dbd00d77ffc1af507ef05fc6e61f0e837608b","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        if current_boot_mode \u003d\u003d \u0027UEFI\u0027:"},{"line_number":467,"context_line":"            secure_boot_state \u003d ilo_object.get_secure_boot_mode()"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":470,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":471,"context_line":"                                                 error\u003dilo_exception)"},{"line_number":472,"context_line":"    except ilo_error.IloError as ilo_exception:"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_2c7abb25","line":469,"in_reply_to":"9a80dd14_c650200d","updated":"2015-03-17 09:59:48.000000000","message":"just noted exceptions are different, please ignore this comment.","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3299c46a2ec82693dfdc2b96440f5e1641ebcb0a","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    try:"},{"line_number":494,"context_line":"        ilo_object.set_secure_boot_mode(flag)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":497,"context_line":"                  {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_66493460","line":496,"updated":"2015-03-17 09:21:32.000000000","message":"Debug statement says setting, but seems like it has already set secure boot","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"db1140fd87993a8468847640a77a44981ef3cd63","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    try:"},{"line_number":494,"context_line":"        ilo_object.set_secure_boot_mode(flag)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":497,"context_line":"                  {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_40d6cbc4","line":496,"in_reply_to":"9a80dd14_66493460","updated":"2015-03-17 13:17:13.000000000","message":"Yes, the change would get effective in next boot only.","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3299c46a2ec82693dfdc2b96440f5e1641ebcb0a","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":497,"context_line":"                  {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":500,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":501,"context_line":"                                          error\u003dilo_exception)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_065b182f","line":499,"updated":"2015-03-17 09:21:32.000000000","message":"nit: ditto as above, can be combined.","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"349dbd00d77ffc1af507ef05fc6e61f0e837608b","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":497,"context_line":"                  {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":500,"context_line":"        raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":501,"context_line":"                                          error\u003dilo_exception)"},{"line_number":502,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_4c77ef3b","line":499,"in_reply_to":"9a80dd14_065b182f","updated":"2015-03-17 09:59:48.000000000","message":"just noted exceptions are different, please ignore this comment.","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"4877fb18c576bcc73fb7f2fea13233655a9b3d5d","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    :raises: IloOperationNotSupported if UEFI secure boot is not supported."},{"line_number":488,"context_line":"    \"\"\""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    operation \u003d _(\"Changing secure boot for Node %s.\") % task.node.uuid"},{"line_number":491,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a80dd14_0c886ec5","line":490,"updated":"2015-03-17 23:15:13.000000000","message":"nit: s/Changing/Setting/\n\nOnly needs addressing IF another patch is pushed up.","commit_id":"621c24329e53d9a304bdd1dedad99a252795a56a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ad257cda5fc4e9c9c45539032d7b2073d34db417","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    :raises: IloOperationNotSupported if UEFI secure boot is not supported."},{"line_number":488,"context_line":"    \"\"\""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    operation \u003d _(\"Changing secure boot for Node %s.\") % task.node.uuid"},{"line_number":491,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a80dd14_aa3d78df","line":490,"in_reply_to":"9a80dd14_0c886ec5","updated":"2015-03-18 07:55:28.000000000","message":"Done","commit_id":"621c24329e53d9a304bdd1dedad99a252795a56a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"251a61b75ed30cc3e7c2d8c768c84d9d4e4f1397","unresolved":false,"context_lines":[{"line_number":456,"context_line":"              on the node."},{"line_number":457,"context_line":"    \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    operation \u003d _(\"Get secure boot mode for node %s.\") % task.node.uuid"},{"line_number":460,"context_line":"    secure_boot_state \u003d False"},{"line_number":461,"context_line":"    ilo_object \u003d get_ilo_object(task.node)"},{"line_number":462,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_d4dc011b","line":459,"updated":"2015-03-18 13:46:50.000000000","message":"this is just a nit and I don\u0027t actually care, but I skimmed and noticed that  other operation strings were \u003cverb\u003eing, eg \u0027Getting\u0027. I\u0027m not sure how consistent that is, or if you want them to be consistent.","commit_id":"2fc79a771a4f0fcfd0202e4790cc758d9a70b671"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a90003f8eb9bb68fcb32c7bdbe4c24f260821109","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    Enable or disable UEFI Secure Boot for the next boot"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    :param task: a task from TaskManager."},{"line_number":486,"context_line":"    :param flag: Boolean value. True if the secure boot to be"},{"line_number":487,"context_line":"                       enabled in next boot."},{"line_number":488,"context_line":"    :raises: IloOperationError on an error from IloClient library."},{"line_number":489,"context_line":"    :raises: IloOperationNotSupported if UEFI secure boot is not supported."}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_4e3ec7db","line":486,"updated":"2015-03-18 11:13:10.000000000","message":"Maybe better to rename this parameter to \"mode\" or \"secure_boot\".","commit_id":"2fc79a771a4f0fcfd0202e4790cc758d9a70b671"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"251a61b75ed30cc3e7c2d8c768c84d9d4e4f1397","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    Enable or disable UEFI Secure Boot for the next boot"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    :param task: a task from TaskManager."},{"line_number":486,"context_line":"    :param flag: Boolean value. True if the secure boot to be"},{"line_number":487,"context_line":"                       enabled in next boot."},{"line_number":488,"context_line":"    :raises: IloOperationError on an error from IloClient library."},{"line_number":489,"context_line":"    :raises: IloOperationNotSupported if UEFI secure boot is not supported."}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_b4a78da6","line":486,"in_reply_to":"9a80dd14_4e3ec7db","updated":"2015-03-18 13:46:50.000000000","message":"or \u0027enabled\u0027. I haven\u0027t yet figured out the best name for this kind of parameter.","commit_id":"2fc79a771a4f0fcfd0202e4790cc758d9a70b671"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import tempfile"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from oslo.utils import importutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from ironic.common import boot_devices"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_bc19667b","line":20,"updated":"2015-02-09 15:22:38.000000000","message":"Please dont change it.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import tempfile"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"from oslo.utils import importutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from ironic.common import boot_devices"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_95fb9546","line":20,"in_reply_to":"da86d52c_bc19667b","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":238,"context_line":"    :raises: IloCommandNotSupportedError, if operation is not supported on iLO"},{"line_number":239,"context_line":"    :raises: IloOperationError, if some operation on iLO failed."},{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":"    cur_sec_state \u003d False"},{"line_number":242,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1c7c3272","line":239,"updated":"2015-02-09 15:22:38.000000000","message":"Could you add :returns: to docstring so it is more clear that it returns true if secure boot was successfully disabled and false otherwise.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":238,"context_line":"    :raises: IloCommandNotSupportedError, if operation is not supported on iLO"},{"line_number":239,"context_line":"    :raises: IloOperationError, if some operation on iLO failed."},{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":"    cur_sec_state \u003d False"},{"line_number":242,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_753b8138","line":239,"in_reply_to":"da86d52c_1c7c3272","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    \"\"\"Common preparatory steps for all iLO drivers."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    This method performs common preparatory steps required for all drivers."},{"line_number":261,"context_line":"    1. Puts off node"},{"line_number":262,"context_line":"    2. Disables secure boot, if it is in enabled state."},{"line_number":263,"context_line":"    3. Updates boot_mode capability to \u0027uefi\u0027 if secure boot is requested."},{"line_number":264,"context_line":"    4. Changes boot mode of the node if secure boot is disabled currently."}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e1e16fd1","line":261,"updated":"2015-02-09 17:24:46.000000000","message":"Does \u0027Puts off node\u0027 mean \u0027Turn off node\u0027?","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    \"\"\"Common preparatory steps for all iLO drivers."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    This method performs common preparatory steps required for all drivers."},{"line_number":261,"context_line":"    1. Puts off node"},{"line_number":262,"context_line":"    2. Disables secure boot, if it is in enabled state."},{"line_number":263,"context_line":"    3. Updates boot_mode capability to \u0027uefi\u0027 if secure boot is requested."},{"line_number":264,"context_line":"    4. Changes boot mode of the node if secure boot is disabled currently."}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_2bdb5d1c","line":261,"in_reply_to":"da86d52c_e1e16fd1","updated":"2015-02-10 13:43:05.000000000","message":"Changing it to \u0027Power off node\u0027 for clarity.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    # secure boot mode change and node boot mode cannot be changed together."},{"line_number":274,"context_line":"    change_boot_mode \u003d True"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Disable secure boot on the node during depoy."},{"line_number":277,"context_line":"    if _disable_secure_boot(task):"},{"line_number":278,"context_line":"        change_boot_mode \u003d False"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c1038b74","line":276,"updated":"2015-02-09 17:24:46.000000000","message":"s/depoy/deploy/","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    # secure boot mode change and node boot mode cannot be changed together."},{"line_number":274,"context_line":"    change_boot_mode \u003d True"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    # Disable secure boot on the node during depoy."},{"line_number":277,"context_line":"    if _disable_secure_boot(task):"},{"line_number":278,"context_line":"        change_boot_mode \u003d False"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ebf7858a","line":276,"in_reply_to":"da86d52c_c1038b74","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    \"\"\""},{"line_number":301,"context_line":"    if deploy_utils._is_secure_boot_requested(task):"},{"line_number":302,"context_line":"        task.driver.management.set_secure_boot_mode(task, flag)"},{"line_number":303,"context_line":"        LOG.info(\u0027Enabled secure boot for node %s\u0027, task.node.uuid)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def _enable_uefi_capability(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_dc5d3aee","line":303,"updated":"2015-02-09 15:22:38.000000000","message":"_LI","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    \"\"\""},{"line_number":301,"context_line":"    if deploy_utils._is_secure_boot_requested(task):"},{"line_number":302,"context_line":"        task.driver.management.set_secure_boot_mode(task, flag)"},{"line_number":303,"context_line":"        LOG.info(\u0027Enabled secure boot for node %s\u0027, task.node.uuid)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def _enable_uefi_capability(task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_75d701c0","line":303,"in_reply_to":"da86d52c_dc5d3aee","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            LOG.debug(\"Retrive Secure Boot state for  Node %s.\","},{"line_number":180,"context_line":"                      task.node.uuid)"},{"line_number":181,"context_line":"            secure_boot_state \u003d False"},{"line_number":182,"context_line":"            ilo_object \u003d ilo_common.get_ilo_object(task.node)"},{"line_number":183,"context_line":"            current_boot_mode \u003d ilo_object.get_current_boot_mode()"},{"line_number":184,"context_line":"            if current_boot_mode \u003d\u003d \u0027UEFI\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a1a9377d","line":181,"updated":"2015-02-09 17:24:46.000000000","message":"Should this and the line above be inside the try?","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            LOG.debug(\"Retrive Secure Boot state for  Node %s.\","},{"line_number":180,"context_line":"                      task.node.uuid)"},{"line_number":181,"context_line":"            secure_boot_state \u003d False"},{"line_number":182,"context_line":"            ilo_object \u003d ilo_common.get_ilo_object(task.node)"},{"line_number":183,"context_line":"            current_boot_mode \u003d ilo_object.get_current_boot_mode()"},{"line_number":184,"context_line":"            if current_boot_mode \u003d\u003d \u0027UEFI\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_465de814","line":181,"in_reply_to":"da86d52c_a1a9377d","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":190,"context_line":"                                                     error\u003dilo_exception)"},{"line_number":191,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":192,"context_line":"            operation \u003d _(\"Get secure boot mode\")"},{"line_number":193,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":194,"context_line":"                                              error\u003dilo_exception)"},{"line_number":195,"context_line":"        return secure_boot_state"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_5caf8a2b","line":192,"updated":"2015-02-09 15:22:38.000000000","message":"You can move operation\u003d_(...) out of except blocks","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":190,"context_line":"                                                     error\u003dilo_exception)"},{"line_number":191,"context_line":"        except ilo_error.IloError as ilo_exception:"},{"line_number":192,"context_line":"            operation \u003d _(\"Get secure boot mode\")"},{"line_number":193,"context_line":"            raise exception.IloOperationError(operation\u003doperation,"},{"line_number":194,"context_line":"                                              error\u003dilo_exception)"},{"line_number":195,"context_line":"        return secure_boot_state"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_cb5d6aee","line":192,"in_reply_to":"da86d52c_5caf8a2b","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            ilo_object.set_secure_boot_mode(flag)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":214,"context_line":"                 {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":217,"context_line":"            operation \u003d _(\"Setting secure boot mode to %s\") % flag"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_21870711","line":214,"updated":"2015-02-09 17:24:46.000000000","message":"nit: indentation","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            ilo_object.set_secure_boot_mode(flag)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            LOG.debug(\"Setting UEFI secure_boot:%(flag)s for Node %(uuid)s.\","},{"line_number":214,"context_line":"                 {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":217,"context_line":"            operation \u003d _(\"Setting secure boot mode to %s\") % flag"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_26b9d42e","line":214,"in_reply_to":"da86d52c_21870711","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                 {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":217,"context_line":"            operation \u003d _(\"Setting secure boot mode to %s\") % flag"},{"line_number":218,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":219,"context_line":"                                              error\u003dilo_exception)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_7c5a8e51","line":217,"updated":"2015-02-09 15:22:38.000000000","message":"ditto","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                 {\u0027flag\u0027: flag, \u0027uuid\u0027: task.node.uuid})"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        except ilo_error.IloCommandNotSupportedError as ilo_exception:"},{"line_number":217,"context_line":"            operation \u003d _(\"Setting secure boot mode to %s\") % flag"},{"line_number":218,"context_line":"            raise exception.IloOperationNotSupported(operation\u003doperation,"},{"line_number":219,"context_line":"                                              error\u003dilo_exception)"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_0b8302cd","line":217,"in_reply_to":"da86d52c_7c5a8e51","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/drivers/modules/pxe_grub_config.template":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"menuentry \"deploy\"  {"},{"line_number":6,"context_line":"linux {{ pxe_options.deployment_aki_path }} rootfstype\u003dramfs selinux\u003d0 disk\u003d{{ pxe_options.disk }} iscsi_target_iqn\u003d{{ pxe_options.iscsi_target_iqn }} deployment_id\u003d{{ pxe_options.deployment_id }} deployment_key\u003d{{ pxe_options.deployment_key }} ironic_api_url\u003d{{ pxe_options.ironic_api_url }} {{ pxe_options.pxe_append_params|default(\"\", true) }} boot_server\u003d{{pxe_options.tftp_server}}"},{"line_number":7,"context_line":"initrd {{ pxe_options.deployment_ari_path }} "},{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"menuentry \"boot\"  {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da86d52c_df252caf","line":7,"updated":"2015-02-09 15:22:38.000000000","message":"This space should be removed.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"menuentry \"deploy\"  {"},{"line_number":6,"context_line":"linux {{ pxe_options.deployment_aki_path }} rootfstype\u003dramfs selinux\u003d0 disk\u003d{{ pxe_options.disk }} iscsi_target_iqn\u003d{{ pxe_options.iscsi_target_iqn }} deployment_id\u003d{{ pxe_options.deployment_id }} deployment_key\u003d{{ pxe_options.deployment_key }} ironic_api_url\u003d{{ pxe_options.ironic_api_url }} {{ pxe_options.pxe_append_params|default(\"\", true) }} boot_server\u003d{{pxe_options.tftp_server}}"},{"line_number":7,"context_line":"initrd {{ pxe_options.deployment_ari_path }} "},{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"menuentry \"boot\"  {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da86d52c_f54e9195","line":7,"in_reply_to":"da86d52c_df252caf","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/drivers/utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    if secure_boot and secure_boot not in [\u0027true\u0027, \u0027false\u0027]:"},{"line_number":230,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid secure_boot \""},{"line_number":231,"context_line":"                          \"parameter \u0027%s\u0027.\") % secure_boot)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_01b4c3f0","line":231,"updated":"2015-02-09 17:24:46.000000000","message":"nit: indentation","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    if secure_boot and secure_boot not in [\u0027true\u0027, \u0027false\u0027]:"},{"line_number":230,"context_line":"        raise exception.InvalidParameterValue(_(\"Invalid secure_boot \""},{"line_number":231,"context_line":"                          \"parameter \u0027%s\u0027.\") % secure_boot)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_26be3400","line":231,"in_reply_to":"da86d52c_01b4c3f0","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/tests/drivers/ilo/test_common.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1002064153cc9ab2cf39294bb38ce7860d4fcb02","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":513,"context_line":"    def test_set_secure_boot_mode_IloOperationNotSupported(self,"},{"line_number":514,"context_line":"                                                          get_ilo_object_mock):"},{"line_number":515,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"},{"line_number":516,"context_line":"        exc \u003d ilo_error.IloCommandNotSupportedError(\u0027error\u0027)"},{"line_number":517,"context_line":"        ilo_mock_object.set_secure_boot_mode.side_effect \u003d exc"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_5e34bafa","line":514,"updated":"2015-03-12 04:34:11.000000000","message":"nit: indentation :)","commit_id":"f45b7f8972d8472bffab48da2695fddd8149b6f5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ee35145e2b220bc35048ae7bcd006cce498fc34d","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":513,"context_line":"    def test_set_secure_boot_mode_IloOperationNotSupported(self,"},{"line_number":514,"context_line":"                                                          get_ilo_object_mock):"},{"line_number":515,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"},{"line_number":516,"context_line":"        exc \u003d ilo_error.IloCommandNotSupportedError(\u0027error\u0027)"},{"line_number":517,"context_line":"        ilo_mock_object.set_secure_boot_mode.side_effect \u003d exc"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a80dd14_5461fba6","line":514,"in_reply_to":"9a80dd14_5e34bafa","updated":"2015-03-12 05:45:52.000000000","message":"Done","commit_id":"f45b7f8972d8472bffab48da2695fddd8149b6f5"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"543979f1bc87dc7681901d139590e1dc0a4ae610","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            ilo_object_mock.get_current_boot_mode.assert_called_once_with()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":460,"context_line":"    def test_get_secure_boot_mode_IloOperationError(self,"},{"line_number":461,"context_line":"                                                    get_ilo_object_mock):"},{"line_number":462,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"},{"line_number":463,"context_line":"        exc \u003d ilo_error.IloError(\u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_4fe086cc","line":460,"updated":"2015-03-12 06:28:04.000000000","message":":nit:  maybe rename the test_get_secure_boot_mode_IloOperationError to test_get_secure_boot_mode_fail to make consistent with other functions. just a suggestion :)","commit_id":"8f4c783477737e8885d60e4e1c7c73f9e0fbe6e2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"da7660e5f62690e879e520ad64299ec63686d3e2","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            ilo_object_mock.get_current_boot_mode.assert_called_once_with()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":460,"context_line":"    def test_get_secure_boot_mode_IloOperationError(self,"},{"line_number":461,"context_line":"                                                    get_ilo_object_mock):"},{"line_number":462,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"},{"line_number":463,"context_line":"        exc \u003d ilo_error.IloError(\u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_f1059cc2","line":460,"in_reply_to":"9a80dd14_4fe086cc","updated":"2015-03-12 08:17:58.000000000","message":"Done","commit_id":"8f4c783477737e8885d60e4e1c7c73f9e0fbe6e2"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"543979f1bc87dc7681901d139590e1dc0a4ae610","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        ilo_mock_object.get_current_boot_mode.assert_called_once_with()"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":474,"context_line":"    def test_get_secure_boot_mode_IloOperationNotSupported(self,"},{"line_number":475,"context_line":"                                                           ilo_object_mock):"},{"line_number":476,"context_line":"        ilo_mock_object \u003d ilo_object_mock.return_value"},{"line_number":477,"context_line":"        exc \u003d ilo_error.IloCommandNotSupportedError(\u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_2f5ef2e9","line":474,"updated":"2015-03-12 06:28:04.000000000","message":":nit: ditto, rename the test_get_secure_boot_mode_IloOperationNotSupported to test_get_secure_boot_mode_not_supported","commit_id":"8f4c783477737e8885d60e4e1c7c73f9e0fbe6e2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"da7660e5f62690e879e520ad64299ec63686d3e2","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        ilo_mock_object.get_current_boot_mode.assert_called_once_with()"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":474,"context_line":"    def test_get_secure_boot_mode_IloOperationNotSupported(self,"},{"line_number":475,"context_line":"                                                           ilo_object_mock):"},{"line_number":476,"context_line":"        ilo_mock_object \u003d ilo_object_mock.return_value"},{"line_number":477,"context_line":"        exc \u003d ilo_error.IloCommandNotSupportedError(\u0027error\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a80dd14_319ad463","line":474,"in_reply_to":"9a80dd14_2f5ef2e9","updated":"2015-03-12 08:17:58.000000000","message":"Done","commit_id":"8f4c783477737e8885d60e4e1c7c73f9e0fbe6e2"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3299c46a2ec82693dfdc2b96440f5e1641ebcb0a","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            ilo_object_mock.eject_virtual_media.assert_any_call(\u0027FLOPPY\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":439,"context_line":"    def test_get_secure_boot_mode(self,"},{"line_number":440,"context_line":"                                  get_ilo_object_mock):"},{"line_number":441,"context_line":"        ilo_object_mock \u003d get_ilo_object_mock.return_value"},{"line_number":442,"context_line":"        ilo_object_mock.get_current_boot_mode.return_value \u003d \u0027UEFI\u0027"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_66d93422","line":439,"updated":"2015-03-17 09:21:32.000000000","message":"nit: may be still fine, but the test cases test_get_secure_boot_mode and test_get_secure_boot_mode_bios doesn\u0027t exercise different code paths (w.r.t ironic)","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"183e995be345393b7cc0820707c6bc2decc93d4a","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            ilo_object_mock.eject_virtual_media.assert_any_call(\u0027FLOPPY\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":439,"context_line":"    def test_get_secure_boot_mode(self,"},{"line_number":440,"context_line":"                                  get_ilo_object_mock):"},{"line_number":441,"context_line":"        ilo_object_mock \u003d get_ilo_object_mock.return_value"},{"line_number":442,"context_line":"        ilo_object_mock.get_current_boot_mode.return_value \u003d \u0027UEFI\u0027"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_f26143a9","line":439,"in_reply_to":"9a80dd14_00ecd38e","updated":"2015-03-17 17:23:41.000000000","message":"Added assert for return value for testcase test_get_secure_boot_mode_bios","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"db1140fd87993a8468847640a77a44981ef3cd63","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            ilo_object_mock.eject_virtual_media.assert_any_call(\u0027FLOPPY\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":439,"context_line":"    def test_get_secure_boot_mode(self,"},{"line_number":440,"context_line":"                                  get_ilo_object_mock):"},{"line_number":441,"context_line":"        ilo_object_mock \u003d get_ilo_object_mock.return_value"},{"line_number":442,"context_line":"        ilo_object_mock.get_current_boot_mode.return_value \u003d \u0027UEFI\u0027"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a80dd14_00ecd38e","line":439,"in_reply_to":"9a80dd14_66d93422","updated":"2015-03-17 13:17:13.000000000","message":"They do. In bios, get_secure_boot_mode() will not get called.","commit_id":"ca407f6b5dc2c59b73e4123edb05cb9ebc37b96d"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":235,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":236,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":237,"context_line":"        self.assertEqual(False, returned_state)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @mock.patch.object(ilo_management.IloManagement, \u0027set_secure_boot_mode\u0027)"},{"line_number":240,"context_line":"    @mock.patch.object(ilo_management.IloManagement, \u0027get_secure_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_9f61f4d5","line":237,"updated":"2015-02-09 15:22:38.000000000","message":"assertFalse","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":235,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":236,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":237,"context_line":"        self.assertEqual(False, returned_state)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @mock.patch.object(ilo_management.IloManagement, \u0027set_secure_boot_mode\u0027)"},{"line_number":240,"context_line":"    @mock.patch.object(ilo_management.IloManagement, \u0027get_secure_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d0119bb0","line":237,"in_reply_to":"da86d52c_9f61f4d5","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":248,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":249,"context_line":"            func_set_secure_boot_mode.assert_called_once_with(task, False)"},{"line_number":250,"context_line":"        self.assertEqual(True, returned_state)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @mock.patch.object(ilo_deploy, \u0027exception\u0027)"},{"line_number":253,"context_line":"    @mock.patch.object(ilo_management.IloManagement, \u0027get_secure_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_df9a8cc4","line":250,"updated":"2015-02-09 15:22:38.000000000","message":"assertTrue","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":248,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":249,"context_line":"            func_set_secure_boot_mode.assert_called_once_with(task, False)"},{"line_number":250,"context_line":"        self.assertEqual(True, returned_state)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @mock.patch.object(ilo_deploy, \u0027exception\u0027)"},{"line_number":253,"context_line":"    @mock.patch.object(ilo_management.IloManagement, \u0027get_secure_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_f0169fa6","line":250,"in_reply_to":"da86d52c_df9a8cc4","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a138c2eeca1dac61e87963c83cd044221a62baa7","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            func_get_secure_boot_mode.side_effect \u003d Exception"},{"line_number":261,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":262,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":263,"context_line":"        self.assertEqual(False, returned_state)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode_capability\u0027)"},{"line_number":266,"context_line":"    @mock.patch.object(deploy_utils, \u0027_is_secure_boot_requested\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_3faac8d4","line":263,"updated":"2015-02-09 15:22:38.000000000","message":"ditto","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0766def58fd2257a3e92170e4e721ee8a4525b98","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            func_get_secure_boot_mode.side_effect \u003d Exception"},{"line_number":261,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":262,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":263,"context_line":"        self.assertEqual(False, returned_state)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode_capability\u0027)"},{"line_number":266,"context_line":"    @mock.patch.object(deploy_utils, \u0027_is_secure_boot_requested\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_d078bbfa","line":263,"in_reply_to":"da86d52c_3faac8d4","updated":"2015-02-09 16:31:02.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_disable_secure_boot\u0027)"},{"line_number":287,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":288,"context_line":"    def test__prepare_node_for_deploy_sec_boot_on(self,"},{"line_number":289,"context_line":"                                            func_node_power_action,"},{"line_number":290,"context_line":"                                            func_disable_secure_boot,"},{"line_number":291,"context_line":"                                            func_is_secure_boot_requested):"},{"line_number":292,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e1308fa0","line":289,"updated":"2015-02-09 17:24:46.000000000","message":"indentation","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_disable_secure_boot\u0027)"},{"line_number":287,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":288,"context_line":"    def test__prepare_node_for_deploy_sec_boot_on(self,"},{"line_number":289,"context_line":"                                            func_node_power_action,"},{"line_number":290,"context_line":"                                            func_disable_secure_boot,"},{"line_number":291,"context_line":"                                            func_is_secure_boot_requested):"},{"line_number":292,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a6ab0488","line":289,"in_reply_to":"da86d52c_e1308fa0","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_disable_secure_boot\u0027)"},{"line_number":305,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":306,"context_line":"    def test__prepare_node_for_deploy_sec_boot_req(self,"},{"line_number":307,"context_line":"                                        func_node_power_action,"},{"line_number":308,"context_line":"                                        func_disable_secure_boot,"},{"line_number":309,"context_line":"                                        func_is_secure_boot_requested,"},{"line_number":310,"context_line":"                                        func_enable_uefi_capability):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_61f57fca","line":307,"updated":"2015-02-09 17:24:46.000000000","message":"indentation","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_disable_secure_boot\u0027)"},{"line_number":305,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":306,"context_line":"    def test__prepare_node_for_deploy_sec_boot_req(self,"},{"line_number":307,"context_line":"                                        func_node_power_action,"},{"line_number":308,"context_line":"                                        func_disable_secure_boot,"},{"line_number":309,"context_line":"                                        func_is_secure_boot_requested,"},{"line_number":310,"context_line":"                                        func_enable_uefi_capability):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e67b3c27","line":307,"in_reply_to":"da86d52c_61f57fca","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":497,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_prepare_node_for_deploy\u0027)"},{"line_number":498,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":499,"context_line":"    def test_prepare(self, build_instance_info_mock,"},{"line_number":500,"context_line":"                           func_prepare_node_for_deploy):"},{"line_number":501,"context_line":"        deploy_opts \u003d {\u0027a\u0027: \u0027b\u0027}"},{"line_number":502,"context_line":"        build_instance_info_mock.return_value \u003d deploy_opts"},{"line_number":503,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_015843f9","line":500,"updated":"2015-02-09 17:24:46.000000000","message":"indentation?","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":497,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_prepare_node_for_deploy\u0027)"},{"line_number":498,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"},{"line_number":499,"context_line":"    def test_prepare(self, build_instance_info_mock,"},{"line_number":500,"context_line":"                           func_prepare_node_for_deploy):"},{"line_number":501,"context_line":"        deploy_opts \u003d {\u0027a\u0027: \u0027b\u0027}"},{"line_number":502,"context_line":"        build_instance_info_mock.return_value \u003d deploy_opts"},{"line_number":503,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_bca22298","line":500,"in_reply_to":"da86d52c_015843f9","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027continue_deploy\u0027)"},{"line_number":524,"context_line":"    @mock.patch.object(ilo_common, \u0027cleanup_vmedia_boot\u0027)"},{"line_number":525,"context_line":"    def test__continue_deploy_resume(self, cleanup_vmedia_boot_mock,"},{"line_number":526,"context_line":"                                           continue_deploy_mock,"},{"line_number":527,"context_line":"                                           get_boot_iso_mock,"},{"line_number":528,"context_line":"                                           setup_vmedia_mock,"},{"line_number":529,"context_line":"                                           func_update_boot_mode_capability,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c1362bb4","line":526,"updated":"2015-02-09 17:24:46.000000000","message":"fix indentation please","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":523,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027continue_deploy\u0027)"},{"line_number":524,"context_line":"    @mock.patch.object(ilo_common, \u0027cleanup_vmedia_boot\u0027)"},{"line_number":525,"context_line":"    def test__continue_deploy_resume(self, cleanup_vmedia_boot_mock,"},{"line_number":526,"context_line":"                                           continue_deploy_mock,"},{"line_number":527,"context_line":"                                           get_boot_iso_mock,"},{"line_number":528,"context_line":"                                           setup_vmedia_mock,"},{"line_number":529,"context_line":"                                           func_update_boot_mode_capability,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_46bfa8aa","line":526,"in_reply_to":"da86d52c_c1362bb4","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/tests/drivers/ilo/test_management.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    @mock.patch.object(ilo_management, \u0027ilo_error\u0027)"},{"line_number":219,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":220,"context_line":"    def test_get_secure_boot_mode_IloOperationError(self,"},{"line_number":221,"context_line":"                                                get_ilo_object_mock,"},{"line_number":222,"context_line":"                                                ilo_mgmt_mock):"},{"line_number":223,"context_line":"        ilo_mgmt_mock.IloError \u003d Exception"},{"line_number":224,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_460b312b","line":221,"updated":"2015-02-09 17:24:46.000000000","message":"nit: indentation","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    @mock.patch.object(ilo_management, \u0027ilo_error\u0027)"},{"line_number":219,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":220,"context_line":"    def test_get_secure_boot_mode_IloOperationError(self,"},{"line_number":221,"context_line":"                                                get_ilo_object_mock,"},{"line_number":222,"context_line":"                                                ilo_mgmt_mock):"},{"line_number":223,"context_line":"        ilo_mgmt_mock.IloError \u003d Exception"},{"line_number":224,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_2649d4d0","line":221,"in_reply_to":"da86d52c_460b312b","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    @mock.patch.object(ilo_management, \u0027ilo_error\u0027)"},{"line_number":235,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":236,"context_line":"    def test_get_secure_boot_mode_IloOperationNotSupported(self,"},{"line_number":237,"context_line":"                                                get_ilo_object_mock,"},{"line_number":238,"context_line":"                                                ilo_mgmt_mock):"},{"line_number":239,"context_line":"        ilo_mgmt_mock.IloCommandNotSupportedError \u003d Exception"},{"line_number":240,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a6022d09","line":237,"updated":"2015-02-09 17:24:46.000000000","message":"nit: indentation","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    @mock.patch.object(ilo_management, \u0027ilo_error\u0027)"},{"line_number":235,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027)"},{"line_number":236,"context_line":"    def test_get_secure_boot_mode_IloOperationNotSupported(self,"},{"line_number":237,"context_line":"                                                get_ilo_object_mock,"},{"line_number":238,"context_line":"                                                ilo_mgmt_mock):"},{"line_number":239,"context_line":"        ilo_mgmt_mock.IloCommandNotSupportedError \u003d Exception"},{"line_number":240,"context_line":"        ilo_mock_object \u003d get_ilo_object_mock.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_66602c36","line":237,"in_reply_to":"da86d52c_a6022d09","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/tests/drivers/test_fake.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_management_interface_get_secure_boot_mode(self):"},{"line_number":113,"context_line":"        expected \u003d False"},{"line_number":114,"context_line":"        self.assertEqual(expected,"},{"line_number":115,"context_line":"                      self.driver.management.get_secure_boot_mode(self.task))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_management_interface_set_secure_boot_mode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a147774a","line":114,"updated":"2015-02-09 17:24:46.000000000","message":"assertFalse I think and can get rid of expected","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def test_management_interface_get_secure_boot_mode(self):"},{"line_number":113,"context_line":"        expected \u003d False"},{"line_number":114,"context_line":"        self.assertEqual(expected,"},{"line_number":115,"context_line":"                      self.driver.management.get_secure_boot_mode(self.task))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_management_interface_set_secure_boot_mode(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_66bcac6d","line":114,"in_reply_to":"da86d52c_a147774a","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}],"ironic/tests/test_pxe_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def test__build_pxe_config_with_agent(self):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        rendered_template \u003d pxe_utils._build_pxe_config("},{"line_number":80,"context_line":"                self.agent_pxe_options,"},{"line_number":81,"context_line":"                CONF.agent.agent_pxe_config_template,"},{"line_number":82,"context_line":"                \u0027{{ ROOT }}\u0027)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_869289f4","line":80,"updated":"2015-02-09 17:24:46.000000000","message":"nit: indentation seems wrong.","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def test__build_pxe_config_with_agent(self):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        rendered_template \u003d pxe_utils._build_pxe_config("},{"line_number":80,"context_line":"                self.agent_pxe_options,"},{"line_number":81,"context_line":"                CONF.agent.agent_pxe_config_template,"},{"line_number":82,"context_line":"                \u0027{{ ROOT }}\u0027)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_26063421","line":80,"in_reply_to":"da86d52c_869289f4","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c30b35c9bb06aa5b216860b939566871f7404f27","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        unlink_calls \u003d ["},{"line_number":311,"context_line":"            mock.call(\u0027/tftpboot/10.10.0.1.conf\u0027),"},{"line_number":312,"context_line":"            mock.call(\u0027/tftpboot/0A0A0001.conf\u0027)"},{"line_number":313,"context_line":"        ]"},{"line_number":314,"context_line":"        unlink_mock.assert_has_calls(unlink_calls)"},{"line_number":315,"context_line":"        rmtree_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_2672bde5","line":312,"updated":"2015-02-09 17:24:46.000000000","message":"nit: add trailing comma","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"779b7c92d4f88af0478b8974b148e4d2e607c8f7","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        unlink_calls \u003d ["},{"line_number":311,"context_line":"            mock.call(\u0027/tftpboot/10.10.0.1.conf\u0027),"},{"line_number":312,"context_line":"            mock.call(\u0027/tftpboot/0A0A0001.conf\u0027)"},{"line_number":313,"context_line":"        ]"},{"line_number":314,"context_line":"        unlink_mock.assert_has_calls(unlink_calls)"},{"line_number":315,"context_line":"        rmtree_mock.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_ba579801","line":312,"in_reply_to":"da86d52c_2672bde5","updated":"2015-02-10 13:43:05.000000000","message":"Done","commit_id":"4dbb225e2584fd05902a0d3e97b865650a43e74d"}]}