)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8225157feee5ad5c36974ffefe50fa2dc5bfbb34","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":423,"context_line":"        # Node."},{"line_number":424,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":425,"context_line":"            LOG.info(_LI(\u0027Secure boot mode is not supported for node %s\u0027),"},{"line_number":426,"context_line":"                         task.node.uuid)"},{"line_number":427,"context_line":"        return states.DELETED"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9a80dd14_92418bab","line":425,"updated":"2015-03-06 20:37:23.000000000","message":"maybe log.warn here?","commit_id":"812b6402d068b907ef67ab1f72187e8861022ee4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"78b7ccc28b6e348e1676cbca10e93b386adac17e","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":423,"context_line":"        # Node."},{"line_number":424,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":425,"context_line":"            LOG.info(_LI(\u0027Secure boot mode is not supported for node %s\u0027),"},{"line_number":426,"context_line":"                         task.node.uuid)"},{"line_number":427,"context_line":"        return states.DELETED"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9a80dd14_351997d7","line":425,"in_reply_to":"9a80dd14_92418bab","updated":"2015-03-07 10:45:28.000000000","message":"Done","commit_id":"812b6402d068b907ef67ab1f72187e8861022ee4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"45e93e6532f5472df366065f0909822ce55e2d9d","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            props \u003d [\u0027kernel\u0027, \u0027ramdisk\u0027]"},{"line_number":372,"context_line":"        iscsi_deploy.validate_image_properties(task.context, d_info, props)"},{"line_number":373,"context_line":"        driver_utils.validate_boot_mode_capability(task.node)"},{"line_number":374,"context_line":"        driver_utils.validate_secure_boot_capability(task.node)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":377,"context_line":"    def deploy(self, task):"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a80dd14_5f30869e","line":374,"updated":"2015-03-10 17:50:01.000000000","message":"secure boot is not supported if boot_option \u003d\u003d \u0027local\u0027. Need to check in validate.","commit_id":"955e5413dbefeaa924a63ed8a8affd63047acc69"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c6df636652bc8b58ac0dfd17be387cfca56595c5","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        try:"},{"line_number":427,"context_line":"            _update_secure_boot_mode(task, False)"},{"line_number":428,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":429,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":430,"context_line":"        # to a node that does not have that capability and attempted deploy."},{"line_number":431,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":432,"context_line":"        # Node."}],"source_content_type":"text/x-python","patch_set":37,"id":"9a80dd14_922d67ab","line":429,"updated":"2015-03-17 17:42:12.000000000","message":"nit: s/User had/the user has/","commit_id":"3c099ff49d3e9bbe6bafd780ee9f8d851094bbc8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"477abf3e7ae696e3827895d927095ffeef57ed43","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        try:"},{"line_number":427,"context_line":"            _update_secure_boot_mode(task, False)"},{"line_number":428,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":429,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":430,"context_line":"        # to a node that does not have that capability and attempted deploy."},{"line_number":431,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":432,"context_line":"        # Node."}],"source_content_type":"text/x-python","patch_set":37,"id":"9a80dd14_e8bdd4d8","line":429,"in_reply_to":"9a80dd14_922d67ab","updated":"2015-03-17 17:59:14.000000000","message":"Done","commit_id":"3c099ff49d3e9bbe6bafd780ee9f8d851094bbc8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c6df636652bc8b58ac0dfd17be387cfca56595c5","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":429,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":430,"context_line":"        # to a node that does not have that capability and attempted deploy."},{"line_number":431,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":432,"context_line":"        # Node."},{"line_number":433,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":434,"context_line":"            LOG.warn(_LW(\u0027Secure boot mode is not supported for node %s\u0027),"}],"source_content_type":"text/x-python","patch_set":37,"id":"9a80dd14_b2534b38","line":431,"updated":"2015-03-17 17:42:12.000000000","message":"nit: s/Handlig/Handling/\n\ns/help user to/help the user to/","commit_id":"3c099ff49d3e9bbe6bafd780ee9f8d851094bbc8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"477abf3e7ae696e3827895d927095ffeef57ed43","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":429,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":430,"context_line":"        # to a node that does not have that capability and attempted deploy."},{"line_number":431,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":432,"context_line":"        # Node."},{"line_number":433,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":434,"context_line":"            LOG.warn(_LW(\u0027Secure boot mode is not supported for node %s\u0027),"}],"source_content_type":"text/x-python","patch_set":37,"id":"9a80dd14_48cc208b","line":431,"in_reply_to":"9a80dd14_b2534b38","updated":"2015-03-17 17:59:14.000000000","message":"Done","commit_id":"3c099ff49d3e9bbe6bafd780ee9f8d851094bbc8"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"c67004552a28de0aad496a7c0e8edcfc3f8b9e2c","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        :raises: IloOperationError, if some operation on iLO fails."},{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        node \u003d task.node"},{"line_number":395,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        iscsi_deploy.cache_instance_image(task.context, node)"},{"line_number":398,"context_line":"        iscsi_deploy.check_image_size(task)"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_49a94adc","side":"PARENT","line":395,"updated":"2015-03-18 18:42:28.000000000","message":"why is this removed? worth adding a comment in the commit message?","commit_id":"0554bb87e21421b2e90eda09ffb242f68d2fe030"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6a84b1f374511a02877fed0d5d787df380e27173","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        :raises: IloOperationError, if some operation on iLO fails."},{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        node \u003d task.node"},{"line_number":395,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        iscsi_deploy.cache_instance_image(task.context, node)"},{"line_number":398,"context_line":"        iscsi_deploy.check_image_size(task)"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_5ab8262a","side":"PARENT","line":395,"in_reply_to":"9a80dd14_3c0d3236","updated":"2015-03-18 19:46:44.000000000","message":"Updated commit message with rational given above.","commit_id":"0554bb87e21421b2e90eda09ffb242f68d2fe030"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"324ed0558c532948db35701b67e34a6ead5bc077","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        :raises: IloOperationError, if some operation on iLO fails."},{"line_number":393,"context_line":"        \"\"\""},{"line_number":394,"context_line":"        node \u003d task.node"},{"line_number":395,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        iscsi_deploy.cache_instance_image(task.context, node)"},{"line_number":398,"context_line":"        iscsi_deploy.check_image_size(task)"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_3c0d3236","side":"PARENT","line":395,"in_reply_to":"9a80dd14_49a94adc","updated":"2015-03-18 18:57:47.000000000","message":"This is being moved to _prepare_node_for_deploy() which now gets called in the prepare() method. \nThe rational to move it as first step in prepare() is:- If the iLO is by chance in POST, then it would not accept any RIBCL commands related to boot mode changes.","commit_id":"0554bb87e21421b2e90eda09ffb242f68d2fe030"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"c67004552a28de0aad496a7c0e8edcfc3f8b9e2c","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        iscsi_deploy.validate(task)"},{"line_number":371,"context_line":"        node \u003d task.node"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        if node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":376,"context_line":"            props \u003d []"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_090cb23a","line":373,"updated":"2015-03-18 18:42:28.000000000","message":"nit: as node var is being added to the method might be nice to update this line too.","commit_id":"0dfd1715c232fccdc0946a582447387046d47fba"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6a84b1f374511a02877fed0d5d787df380e27173","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        iscsi_deploy.validate(task)"},{"line_number":371,"context_line":"        node \u003d task.node"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        d_info \u003d _parse_deploy_info(task.node)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        if node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":376,"context_line":"            props \u003d []"}],"source_content_type":"text/x-python","patch_set":40,"id":"9a80dd14_7ae16a29","line":373,"in_reply_to":"9a80dd14_090cb23a","updated":"2015-03-18 19:46:44.000000000","message":"Done","commit_id":"0dfd1715c232fccdc0946a582447387046d47fba"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c6df636652bc8b58ac0dfd17be387cfca56595c5","unresolved":false,"context_lines":[{"line_number":726,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027continue_deploy\u0027)"},{"line_number":727,"context_line":"    @mock.patch.object(ilo_common, \u0027cleanup_vmedia_boot\u0027)"},{"line_number":728,"context_line":"    def _test_pass_deploy_info_localboot(self, cleanup_vmedia_boot_mock,"},{"line_number":729,"context_line":"                                        continue_deploy_mock,"},{"line_number":730,"context_line":"                                        func_update_boot_mode_capability,"},{"line_number":731,"context_line":"                                        func_update_secure_boot_mode,"},{"line_number":732,"context_line":"                                        set_boot_device_mock,"}],"source_content_type":"text/x-python","patch_set":37,"id":"9a80dd14_ad712e46","line":729,"updated":"2015-03-17 17:42:12.000000000","message":"nit: indentation, looks like it was correct before patch.","commit_id":"3c099ff49d3e9bbe6bafd780ee9f8d851094bbc8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"477abf3e7ae696e3827895d927095ffeef57ed43","unresolved":false,"context_lines":[{"line_number":726,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027continue_deploy\u0027)"},{"line_number":727,"context_line":"    @mock.patch.object(ilo_common, \u0027cleanup_vmedia_boot\u0027)"},{"line_number":728,"context_line":"    def _test_pass_deploy_info_localboot(self, cleanup_vmedia_boot_mock,"},{"line_number":729,"context_line":"                                        continue_deploy_mock,"},{"line_number":730,"context_line":"                                        func_update_boot_mode_capability,"},{"line_number":731,"context_line":"                                        func_update_secure_boot_mode,"},{"line_number":732,"context_line":"                                        set_boot_device_mock,"}],"source_content_type":"text/x-python","patch_set":37,"id":"9a80dd14_48a18094","line":729,"in_reply_to":"9a80dd14_ad712e46","updated":"2015-03-17 17:59:14.000000000","message":"Done","commit_id":"3c099ff49d3e9bbe6bafd780ee9f8d851094bbc8"}]}