)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8c8af946f5e3a1f89e4af8fae007e1c0c07631c3","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        if deploy_utils._is_secure_boot_requested(task):"},{"line_number":345,"context_line":"            try:"},{"line_number":346,"context_line":"                task.driver.management.set_secure_boot_mode(task, True)"},{"line_number":347,"context_line":"                LOG.info(\u0027Enabled secure boot for node %s\u0027, task.node.uuid)"},{"line_number":348,"context_line":"            except NotImplementedError:"},{"line_number":349,"context_line":"                LOG.debug(\u0027set_secure_boot_mode is not supported\u0027)"},{"line_number":350,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_8a05c311","line":347,"updated":"2015-02-18 14:53:43.000000000","message":"_LI","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32d9c3a9675bc02d04d88bd48b46853079c1a8c0","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        if deploy_utils._is_secure_boot_requested(task):"},{"line_number":345,"context_line":"            try:"},{"line_number":346,"context_line":"                task.driver.management.set_secure_boot_mode(task, True)"},{"line_number":347,"context_line":"                LOG.info(\u0027Enabled secure boot for node %s\u0027, task.node.uuid)"},{"line_number":348,"context_line":"            except NotImplementedError:"},{"line_number":349,"context_line":"                LOG.debug(\u0027set_secure_boot_mode is not supported\u0027)"},{"line_number":350,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_500d228e","line":347,"in_reply_to":"da86d52c_8a05c311","updated":"2015-02-19 04:52:34.000000000","message":"Done","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8c8af946f5e3a1f89e4af8fae007e1c0c07631c3","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                task.driver.management.set_secure_boot_mode(task, True)"},{"line_number":347,"context_line":"                LOG.info(\u0027Enabled secure boot for node %s\u0027, task.node.uuid)"},{"line_number":348,"context_line":"            except NotImplementedError:"},{"line_number":349,"context_line":"                LOG.debug(\u0027set_secure_boot_mode is not supported\u0027)"},{"line_number":350,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":351,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_ef08112f","line":349,"updated":"2015-02-18 14:53:43.000000000","message":"nit - you can add \u0027by management interface.\u0027","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32d9c3a9675bc02d04d88bd48b46853079c1a8c0","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                task.driver.management.set_secure_boot_mode(task, True)"},{"line_number":347,"context_line":"                LOG.info(\u0027Enabled secure boot for node %s\u0027, task.node.uuid)"},{"line_number":348,"context_line":"            except NotImplementedError:"},{"line_number":349,"context_line":"                LOG.debug(\u0027set_secure_boot_mode is not supported\u0027)"},{"line_number":350,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":351,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_70278612","line":349,"in_reply_to":"da86d52c_ef08112f","updated":"2015-02-19 04:52:34.000000000","message":"Done","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f251fd98f795f9df6b032c309af148d4e413a1ab","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                task.driver.management.set_secure_boot_mode(task, True)"},{"line_number":348,"context_line":"                LOG.info(_LI(\"Enabled secure boot for node %s\"),"},{"line_number":349,"context_line":"                         task.node.uuid)"},{"line_number":350,"context_line":"            except NotImplementedError:"},{"line_number":351,"context_line":"                LOG.debug(\"set_secure_boot_mode is not supported by\""},{"line_number":352,"context_line":"                          \"management interface\")"},{"line_number":353,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_e7864364","line":350,"updated":"2015-02-19 16:27:27.000000000","message":"And what about IloOperationNotSupported here?","commit_id":"18a7bbf98594a1af4e023d8578e62ba599f8f58d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3e52469a780adc4fea10e36d59ab730d83baf648","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                task.driver.management.set_secure_boot_mode(task, True)"},{"line_number":348,"context_line":"                LOG.info(_LI(\"Enabled secure boot for node %s\"),"},{"line_number":349,"context_line":"                         task.node.uuid)"},{"line_number":350,"context_line":"            except NotImplementedError:"},{"line_number":351,"context_line":"                LOG.debug(\"set_secure_boot_mode is not supported by\""},{"line_number":352,"context_line":"                          \"management interface\")"},{"line_number":353,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_c83684e7","line":350,"in_reply_to":"da86d52c_e7864364","updated":"2015-02-20 06:47:16.000000000","message":"We do not want to handle it here as user has configured node for secure boot. If operation fails we should not handle the exceptions related to that here.","commit_id":"18a7bbf98594a1af4e023d8578e62ba599f8f58d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f251fd98f795f9df6b032c309af148d4e413a1ab","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                LOG.info(_LI(\"Enabled secure boot for node %s\"),"},{"line_number":349,"context_line":"                         task.node.uuid)"},{"line_number":350,"context_line":"            except NotImplementedError:"},{"line_number":351,"context_line":"                LOG.debug(\"set_secure_boot_mode is not supported by\""},{"line_number":352,"context_line":"                          \"management interface\")"},{"line_number":353,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":354,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_27213b9e","line":351,"updated":"2015-02-19 16:27:27.000000000","message":"Space needed at eol.","commit_id":"18a7bbf98594a1af4e023d8578e62ba599f8f58d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3e52469a780adc4fea10e36d59ab730d83baf648","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                LOG.info(_LI(\"Enabled secure boot for node %s\"),"},{"line_number":349,"context_line":"                         task.node.uuid)"},{"line_number":350,"context_line":"            except NotImplementedError:"},{"line_number":351,"context_line":"                LOG.debug(\"set_secure_boot_mode is not supported by\""},{"line_number":352,"context_line":"                          \"management interface\")"},{"line_number":353,"context_line":"        manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":354,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba7be1f8_48529414","line":351,"in_reply_to":"da86d52c_27213b9e","updated":"2015-02-20 06:47:16.000000000","message":"Done","commit_id":"18a7bbf98594a1af4e023d8578e62ba599f8f58d"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8fb2d6ce3ecb7ce63fec00cc3d32a22d42b67bf6","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            _update_secure_boot_mode(task, False)"},{"line_number":466,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":467,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":468,"context_line":"        # to a node that do not have such capability and attempted deploy."},{"line_number":469,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":470,"context_line":"        # Node."},{"line_number":471,"context_line":"        except exception.IloOperationNotSupported:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_371a766f","line":468,"updated":"2015-02-11 20:11:34.000000000","message":"s/that do not have such capability/that does not have that capability/","commit_id":"21f41c74d7c15d671c275d106a61ab0e97fda535"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dd1688ea948b75dbe03b0a6bb80e4f804c5755b8","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            _update_secure_boot_mode(task, False)"},{"line_number":466,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":467,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":468,"context_line":"        # to a node that do not have such capability and attempted deploy."},{"line_number":469,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":470,"context_line":"        # Node."},{"line_number":471,"context_line":"        except exception.IloOperationNotSupported:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b5be4263","line":468,"in_reply_to":"da86d52c_371a766f","updated":"2015-02-12 13:06:31.000000000","message":"Done","commit_id":"21f41c74d7c15d671c275d106a61ab0e97fda535"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"408d763d68aba6df93121374125b8a7ad0c75a81","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            _update_secure_boot_mode(task, False)"},{"line_number":466,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":467,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":468,"context_line":"        # to a node that do not have such capability and attempted deploy."},{"line_number":469,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":470,"context_line":"        # Node."},{"line_number":471,"context_line":"        except exception.IloOperationNotSupported:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3148942c","line":468,"updated":"2015-02-12 17:59:07.000000000","message":"s/that do not have such capability/that does not have that capability/","commit_id":"a1793c21f9cf1dd103d013694330cb215d581d94"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be98581856287f05472c51746e64dfd184576041","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            _update_secure_boot_mode(task, False)"},{"line_number":466,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":467,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":468,"context_line":"        # to a node that do not have such capability and attempted deploy."},{"line_number":469,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":470,"context_line":"        # Node."},{"line_number":471,"context_line":"        except exception.IloOperationNotSupported:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b4737f7e","line":468,"in_reply_to":"da86d52c_3148942c","updated":"2015-02-13 03:32:39.000000000","message":"Done","commit_id":"a1793c21f9cf1dd103d013694330cb215d581d94"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"830129f7b1859688118bd60da0428576378d7644","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":505,"context_line":"        # Node."},{"line_number":506,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":507,"context_line":"            LOG.info(_LI(\u0027Secure boot mode is not supported for node %s\u0027),"},{"line_number":508,"context_line":"                         task.node.uuid)"},{"line_number":509,"context_line":"        return states.DELETED"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9a80dd14_d57e7bae","line":507,"updated":"2015-03-07 11:25:47.000000000","message":"This should be \u0027warn\u0027.","commit_id":"f56b92581f152ad817f39f9f8200a357ac71af4e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b9bb412e4a3f4b1549cee08a33fdf4df3521b1e4","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":513,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":514,"context_line":"        # to a node that do not have such capability and attempted deploy."},{"line_number":515,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":516,"context_line":"        # Node."},{"line_number":517,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":518,"context_line":"            LOG.warn(_LW(\u0027Secure boot mode is not supported for node %s\u0027),"}],"source_content_type":"text/x-python","patch_set":39,"id":"9a80dd14_c35fe073","line":515,"updated":"2015-03-18 16:40:28.000000000","message":"Nit: s/handlig/handling","commit_id":"cce676fbf3762308a8e0a2ac4ee350517ab5913c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"50f6cf98c5661099077ba8156c449a3eeaa16484","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        # We need to handle IloOperationNotSupported exception so that if"},{"line_number":513,"context_line":"        # User had incorrectly specified the Node capability \u0027secure_boot\u0027"},{"line_number":514,"context_line":"        # to a node that do not have such capability and attempted deploy."},{"line_number":515,"context_line":"        # Handlig this exception here, will help user to tear down such a"},{"line_number":516,"context_line":"        # Node."},{"line_number":517,"context_line":"        except exception.IloOperationNotSupported:"},{"line_number":518,"context_line":"            LOG.warn(_LW(\u0027Secure boot mode is not supported for node %s\u0027),"}],"source_content_type":"text/x-python","patch_set":39,"id":"9a80dd14_5ae4a6ab","line":515,"in_reply_to":"9a80dd14_c35fe073","updated":"2015-03-18 20:05:38.000000000","message":"Done","commit_id":"cce676fbf3762308a8e0a2ac4ee350517ab5913c"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"406d3706acec40fce76ea084ea4a08ddeb322f28","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"class IloVirtualMediaAgentVendorInterface(agent.AgentVendorInterface):"},{"line_number":556,"context_line":"    \"\"\"Interface for vendor passthru rateled actions.\"\"\""},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def reboot_to_instance(self, task, **kwargs):"},{"line_number":559,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":45,"id":"9a80dd14_9eed17f3","line":556,"updated":"2015-03-19 10:06:30.000000000","message":"s/rateled/related/","commit_id":"360e1b13f4fb625649e33baddb51b5c1b802e600"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"422d25dac6a01c9481e95d3cb0cbf752025744bf","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"class IloVirtualMediaAgentVendorInterface(agent.AgentVendorInterface):"},{"line_number":556,"context_line":"    \"\"\"Interface for vendor passthru rateled actions.\"\"\""},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"    def reboot_to_instance(self, task, **kwargs):"},{"line_number":559,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":45,"id":"1a6ced46_56095594","line":556,"in_reply_to":"9a80dd14_9eed17f3","updated":"2015-03-23 06:38:39.000000000","message":"Done","commit_id":"360e1b13f4fb625649e33baddb51b5c1b802e600"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8fb2d6ce3ecb7ce63fec00cc3d32a22d42b67bf6","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            update_secure_boot_mode_mock.side_effect \u003d Exception"},{"line_number":487,"context_line":"            returned_state \u003d task.driver.deploy.tear_down(task)"},{"line_number":488,"context_line":"            node_power_action_mock.assert_called_once_with(task,"},{"line_number":489,"context_line":"                    states.POWER_OFF)"},{"line_number":490,"context_line":"            update_secure_boot_mode_mock.assert_called_once_with(task, False)"},{"line_number":491,"context_line":"            self.assertEqual(states.DELETED, returned_state)"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_8c19558a","line":489,"updated":"2015-02-11 20:11:34.000000000","message":"nit: indentation","commit_id":"21f41c74d7c15d671c275d106a61ab0e97fda535"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dd1688ea948b75dbe03b0a6bb80e4f804c5755b8","unresolved":false,"context_lines":[{"line_number":486,"context_line":"            update_secure_boot_mode_mock.side_effect \u003d Exception"},{"line_number":487,"context_line":"            returned_state \u003d task.driver.deploy.tear_down(task)"},{"line_number":488,"context_line":"            node_power_action_mock.assert_called_once_with(task,"},{"line_number":489,"context_line":"                    states.POWER_OFF)"},{"line_number":490,"context_line":"            update_secure_boot_mode_mock.assert_called_once_with(task, False)"},{"line_number":491,"context_line":"            self.assertEqual(states.DELETED, returned_state)"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_757f6aab","line":489,"in_reply_to":"da86d52c_8c19558a","updated":"2015-02-12 13:06:31.000000000","message":"Done","commit_id":"21f41c74d7c15d671c275d106a61ab0e97fda535"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"33c10617b61a1f2255b6aebdadeeaeecc4c9a3e3","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            node_power_action_mock.assert_called_once_with(task,"},{"line_number":578,"context_line":"                                                           states.POWER_OFF)"},{"line_number":579,"context_line":"            update_secure_boot_mode_mock.assert_called_once_with(task, False)"},{"line_number":580,"context_line":"            self.assertEqual(states.DELETED, returned_state)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_prepare_node_for_deploy\u0027)"},{"line_number":583,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":39,"id":"9a80dd14_6c054113","line":580,"updated":"2015-03-18 17:39:36.000000000","message":"I would think testing that LOG.warn was called once would test that the exception was really handled.","commit_id":"cce676fbf3762308a8e0a2ac4ee350517ab5913c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"50f6cf98c5661099077ba8156c449a3eeaa16484","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            node_power_action_mock.assert_called_once_with(task,"},{"line_number":578,"context_line":"                                                           states.POWER_OFF)"},{"line_number":579,"context_line":"            update_secure_boot_mode_mock.assert_called_once_with(task, False)"},{"line_number":580,"context_line":"            self.assertEqual(states.DELETED, returned_state)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_prepare_node_for_deploy\u0027)"},{"line_number":583,"context_line":"    @mock.patch.object(agent, \u0027build_instance_info_for_deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":39,"id":"9a80dd14_f5cc8dbd","line":580,"in_reply_to":"9a80dd14_6c054113","updated":"2015-03-18 20:05:38.000000000","message":"Done","commit_id":"cce676fbf3762308a8e0a2ac4ee350517ab5913c"}],"ironic/tests/drivers/test_agent.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8c8af946f5e3a1f89e4af8fae007e1c0c07631c3","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    @mock.patch(\u0027ironic.conductor.utils.node_set_boot_device\u0027)"},{"line_number":208,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.agent.AgentVendorInterface\u0027"},{"line_number":209,"context_line":"                \u0027._check_deploy_success\u0027)"},{"line_number":210,"context_line":"    def test__reboot_to_instance(self, check_deploy_mock, bootdev_mock,"},{"line_number":211,"context_line":"                                 secure_boot_requested_mock,"},{"line_number":212,"context_line":"                                 set_secure_boot_mock,"},{"line_number":213,"context_line":"                                 power_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_eae39f02","line":210,"updated":"2015-02-18 14:53:43.000000000","message":"Why cange test name?","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32d9c3a9675bc02d04d88bd48b46853079c1a8c0","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    @mock.patch(\u0027ironic.conductor.utils.node_set_boot_device\u0027)"},{"line_number":208,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.agent.AgentVendorInterface\u0027"},{"line_number":209,"context_line":"                \u0027._check_deploy_success\u0027)"},{"line_number":210,"context_line":"    def test__reboot_to_instance(self, check_deploy_mock, bootdev_mock,"},{"line_number":211,"context_line":"                                 secure_boot_requested_mock,"},{"line_number":212,"context_line":"                                 set_secure_boot_mock,"},{"line_number":213,"context_line":"                                 power_mock):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_70dce6e4","line":210,"in_reply_to":"da86d52c_eae39f02","updated":"2015-02-19 04:52:34.000000000","message":"Done","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8c8af946f5e3a1f89e4af8fae007e1c0c07631c3","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            bootdev_mock.assert_called_once_with(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":229,"context_line":"            power_mock.assert_called_once_with(task, states.REBOOT)"},{"line_number":230,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":231,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027)"},{"line_number":234,"context_line":"    def test_deploy_is_done(self, mock_get_cmd):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_caa25b99","line":231,"updated":"2015-02-18 14:53:43.000000000","message":"Could you also add a test with set_secure_boot_mode throwing an exception?","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"32d9c3a9675bc02d04d88bd48b46853079c1a8c0","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            bootdev_mock.assert_called_once_with(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":229,"context_line":"            power_mock.assert_called_once_with(task, states.REBOOT)"},{"line_number":230,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":231,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027)"},{"line_number":234,"context_line":"    def test_deploy_is_done(self, mock_get_cmd):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_9b3b3b37","line":231,"in_reply_to":"da86d52c_caa25b99","updated":"2015-02-19 04:52:34.000000000","message":"Done","commit_id":"3681a42d892e72ac32d2c88cada986b56972c5f4"}]}
