)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a282a21b6e99558fe7d03ae195e85a28da1ebecc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"raid configuration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I42d1011f8d9923bbeeb986410eb1cc40db212feb"},{"line_number":15,"context_line":"Implements: blueprint ironic-generic-raid-interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"ba3cc151_f9e4340e","line":15,"updated":"2015-06-29 20:38:01.000000000","message":"I was looking for the spec - please update the launchpad link for the spec; it is pointing to the old kilo version that is no longer there.","commit_id":"9701cd43078819ee4517aa8ba14fa3765ff2d5bc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"04c2552c3c22133711d40718a3410d05d278546f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"raid configuration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I42d1011f8d9923bbeeb986410eb1cc40db212feb"},{"line_number":15,"context_line":"Implements: blueprint ironic-generic-raid-interface"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"ba3cc151_c3637219","line":15,"in_reply_to":"ba3cc151_f9e4340e","updated":"2015-06-30 04:17:32.000000000","message":"Done","commit_id":"9701cd43078819ee4517aa8ba14fa3765ff2d5bc"}],"ironic/api/controllers/v1/__init__.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed11dbd6b61fa7dca32743b11bbb8b3becc5dac0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# v1.5: Add logical node names"},{"line_number":63,"context_line":"# v1.6: Add INSPECT* states"},{"line_number":64,"context_line":"# v1.7: Add support for RAID"},{"line_number":65,"context_line":"MAX_VER_STR \u003d \u00271.7\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"MIN_VER \u003d base.Version({base.Version.string: MIN_VER_STR},"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_e3bdadb8","line":65,"updated":"2015-03-06 13:28:33.000000000","message":"hmm... thinking about bumping versions. does it have any effect? looks like we\u0027re adding new API\u0027s and maybe we don\u0027t need version bump for it. Otherwise you need to somehow prevent users from accessing API\u0027s with older clients...\n\n/me is never sure :(","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c1c704efbb26be1b4a5b7a8812167529db1c543c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# v1.5: Add logical node names"},{"line_number":63,"context_line":"# v1.6: Add INSPECT* states"},{"line_number":64,"context_line":"# v1.7: Add support for RAID"},{"line_number":65,"context_line":"MAX_VER_STR \u003d \u00271.7\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"MIN_VER \u003d base.Version({base.Version.string: MIN_VER_STR},"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_6b188b75","line":65,"in_reply_to":"9a80dd14_e3bdadb8","updated":"2015-03-08 06:49:04.000000000","message":"Looks like everyone has confusions around microversions.\n\nFor now, I will just follow what others did and add a check.","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"}],"ironic/api/controllers/v1/driver.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        :param driver_name: Name of the driver."},{"line_number":171,"context_line":"        :raises: UnsupportedDriverExtension if the driver doesn\u0027t"},{"line_number":172,"context_line":"            support raid configuration."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for_driver(driver_name)"},{"line_number":175,"context_line":"        return pecan.request.rpcapi.get_raid_logical_disk_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_235e667a","line":172,"updated":"2015-02-13 11:27:11.000000000","message":":returns: ?","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        :param driver_name: Name of the driver."},{"line_number":171,"context_line":"        :raises: UnsupportedDriverExtension if the driver doesn\u0027t"},{"line_number":172,"context_line":"            support raid configuration."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for_driver(driver_name)"},{"line_number":175,"context_line":"        return pecan.request.rpcapi.get_raid_logical_disk_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b0b42736","line":172,"in_reply_to":"da86d52c_235e667a","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    vendor_passthru \u003d DriverPassthruController()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    raid \u003d DriverRaidController()"},{"line_number":188,"context_line":"    \"\"\"Expose RAID management as a sub-element of drivers\"\"\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    _custom_actions \u003d {"},{"line_number":191,"context_line":"        \u0027properties\u0027: [\u0027GET\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_0412de61","line":188,"updated":"2015-02-17 14:53:30.000000000","message":"question: should this really be a docstring here?","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    vendor_passthru \u003d DriverPassthruController()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    raid \u003d DriverRaidController()"},{"line_number":188,"context_line":"    \"\"\"Expose RAID management as a sub-element of drivers\"\"\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    _custom_actions \u003d {"},{"line_number":191,"context_line":"        \u0027properties\u0027: [\u0027GET\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_15384a3c","line":188,"in_reply_to":"da86d52c_0412de61","updated":"2015-02-17 15:21:16.000000000","message":"All the sub-elments in node.py has one. So I thought we can add one too. :)\n\nhttps://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L768-L782","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"4a795551caf4bd75b3cc96246e751f675c6363d8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return wsme.api.Response(ret, status_code\u003dstatus_code)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class DriverRaidController(rest.RestController):"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    _custom_actions \u003d {"},{"line_number":164,"context_line":"        \u0027logical_disk_properties\u0027: [\u0027GET\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_2c6d5b33","line":161,"updated":"2015-03-04 20:46:34.000000000","message":"Need some micro version checks here as well.","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"29511227eaa39b685a38c179cf47308a75ff59c8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        return wsme.api.Response(ret, status_code\u003dstatus_code)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class DriverRaidController(rest.RestController):"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    _custom_actions \u003d {"},{"line_number":164,"context_line":"        \u0027logical_disk_properties\u0027: [\u0027GET\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_c4a7264e","line":161,"in_reply_to":"9a80dd14_2c6d5b33","updated":"2015-03-05 05:00:32.000000000","message":"Josh, I discussed with folks in the IRC two day\u0027s back regarding micro-version checks.  I still can\u0027t find a reason, why we should need micro-version check for new endpoints in our API (all the changes in RAID are adding a new API endpoint).  If someone is using some older clients which knows only older API versions, then they wouldn\u0027t anyway know something like /v1/drivers/fake/logical_disk_properties and hence they wouldn\u0027t be using this (I can\u0027t think of someone writing code to do /v1/drivers/fake/logical_disk_properties and expecting 404 errors for some reason).  I know it was added for all the commits after micro-versioning, but I am still inclined not to add it unless there is a good reasoning behind it.  Hence I didn\u0027t add it.  Let me know your thoughts.\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2015-03-03.log (2015-03-03T15:03:16)","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd07a363710adb8d3d94bf18f2046d7ac636e60a","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            zapping or introspection) and target RAID configuration"},{"line_number":780,"context_line":"            (configuration to be applied during next zapping)."},{"line_number":781,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":782,"context_line":"            support raid configuration."},{"line_number":783,"context_line":"        \"\"\""},{"line_number":784,"context_line":"        rpc_node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"},{"line_number":785,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_37169b59","line":782,"updated":"2015-02-13 15:35:46.000000000","message":"nit - RAID","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            zapping or introspection) and target RAID configuration"},{"line_number":780,"context_line":"            (configuration to be applied during next zapping)."},{"line_number":781,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":782,"context_line":"            support raid configuration."},{"line_number":783,"context_line":"        \"\"\""},{"line_number":784,"context_line":"        rpc_node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"},{"line_number":785,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b08b4767","line":782,"in_reply_to":"da86d52c_37169b59","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                pecan.request.context, node_uuid, disk_type\u003d\u0027logical_disks\u0027,"},{"line_number":788,"context_line":"                topic\u003dtopic)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, wtypes.text, status_code\u003d202)"},{"line_number":791,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":792,"context_line":"        \"\"\"Put the RAID configuration for a node."},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2348268a","line":790,"updated":"2015-02-13 11:27:11.000000000","message":"this requires additional \u0027raid_config\u0027 variable, that is not needed. use body\u003dtype instead. And \u0027type\u0027 probably should not be string, it\u0027s a JSON dict","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                pecan.request.context, node_uuid, disk_type\u003d\u0027logical_disks\u0027,"},{"line_number":788,"context_line":"                topic\u003dtopic)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, wtypes.text, status_code\u003d202)"},{"line_number":791,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":792,"context_line":"        \"\"\"Put the RAID configuration for a node."},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b0b98717","line":790,"in_reply_to":"da86d52c_2348268a","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":816,"context_line":"    configuration \u003d NodeRaidConfigurationController()"},{"line_number":817,"context_line":"    \"\"\"Expose the raid configuration as a sub-element of nodes\"\"\""},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    @wsme_pecan.wsexpose(wtypes.text, types.uuid)"},{"line_number":820,"context_line":"    def physical_disks(self, node_uuid):"},{"line_number":821,"context_line":"        \"\"\"Get the physical disks behind RAID controllers."},{"line_number":822,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_c3674a50","line":819,"updated":"2015-02-13 11:27:11.000000000","message":"return value is not text","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":816,"context_line":"    configuration \u003d NodeRaidConfigurationController()"},{"line_number":817,"context_line":"    \"\"\"Expose the raid configuration as a sub-element of nodes\"\"\""},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    @wsme_pecan.wsexpose(wtypes.text, types.uuid)"},{"line_number":820,"context_line":"    def physical_disks(self, node_uuid):"},{"line_number":821,"context_line":"        \"\"\"Get the physical disks behind RAID controllers."},{"line_number":822,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_10409306","line":819,"in_reply_to":"da86d52c_c3674a50","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eda03afe8907e17798f0609932a57ba3e80743b","unresolved":false,"context_lines":[{"line_number":764,"context_line":""},{"line_number":765,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @wsme_pecan.wsexpose(wtypes.DictType(wtypes.text, wtypes.text),"},{"line_number":768,"context_line":"                         types.uuid)"},{"line_number":769,"context_line":"    def get(self, node_uuid):"},{"line_number":770,"context_line":"        \"\"\"Get the RAID configuration of a node."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_f444ce1a","line":767,"updated":"2015-02-16 09:58:40.000000000","message":"I suspect you wanted to use {wtypes.text: types.jsontype} here, no?","commit_id":"995215a1feecc655ccea4d78c9505eb87da46ae6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ce8e40fbacbb98eeca4df41caec2d3e9fdc64b6a","unresolved":false,"context_lines":[{"line_number":764,"context_line":""},{"line_number":765,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @wsme_pecan.wsexpose(wtypes.DictType(wtypes.text, wtypes.text),"},{"line_number":768,"context_line":"                         types.uuid)"},{"line_number":769,"context_line":"    def get(self, node_uuid):"},{"line_number":770,"context_line":"        \"\"\"Get the RAID configuration of a node."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_970b947c","line":767,"in_reply_to":"da86d52c_f444ce1a","updated":"2015-02-16 11:16:53.000000000","message":"Done. Thanks I didn\u0027t notice this.","commit_id":"995215a1feecc655ccea4d78c9505eb87da46ae6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eda03afe8907e17798f0609932a57ba3e80743b","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                topic\u003dtopic)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid,"},{"line_number":792,"context_line":"                         body\u003dwtypes.DictType(wtypes.text, wtypes.text),"},{"line_number":793,"context_line":"                         status_code\u003d202)"},{"line_number":794,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":795,"context_line":"        \"\"\"Put the RAID configuration for a node."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_145402c9","line":792,"updated":"2015-02-16 09:58:40.000000000","message":"ditto","commit_id":"995215a1feecc655ccea4d78c9505eb87da46ae6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ce8e40fbacbb98eeca4df41caec2d3e9fdc64b6a","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                topic\u003dtopic)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid,"},{"line_number":792,"context_line":"                         body\u003dwtypes.DictType(wtypes.text, wtypes.text),"},{"line_number":793,"context_line":"                         status_code\u003d202)"},{"line_number":794,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":795,"context_line":"        \"\"\"Put the RAID configuration for a node."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_57783cf8","line":792,"in_reply_to":"da86d52c_145402c9","updated":"2015-02-16 11:16:53.000000000","message":"Done","commit_id":"995215a1feecc655ccea4d78c9505eb87da46ae6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faf23e9be09386adc8cc705a6316847c4b983760","unresolved":false,"context_lines":[{"line_number":764,"context_line":""},{"line_number":765,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid)"},{"line_number":768,"context_line":"    def get(self, node_uuid):"},{"line_number":769,"context_line":"        \"\"\"Get the RAID configuration of a node."},{"line_number":770,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_b41c8914","line":767,"updated":"2015-02-19 10:28:17.000000000","message":"Mostly a nit: The return says it returns a dict, but jsontype supports other primitives. For example a list or even a string are valid json\u0027s too.\n\n In [2]: json.dumps(\u0027aaa\u0027)\n Out[2]: \u0027\"aaa\"\u0027\n\n In [3]: json.dumps([1,2,3]) \n Out[3]: \u0027[1, 2, 3]\u0027\n\n...\n\nThat said, I think that\u0027s fine to keep as-is, usually before the jsontype we usually used wtypes.text as return value which could be anything as well, I just wanted to point out in case someone might have a better idea (like creating a DictType or something)","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"031f728df02ff9d7a2fbb771b66d299187fc665f","unresolved":false,"context_lines":[{"line_number":764,"context_line":""},{"line_number":765,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid)"},{"line_number":768,"context_line":"    def get(self, node_uuid):"},{"line_number":769,"context_line":"        \"\"\"Get the RAID configuration of a node."},{"line_number":770,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_386967be","line":767,"in_reply_to":"da86d52c_b41c8914","updated":"2015-02-19 12:50:05.000000000","message":"Done","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faf23e9be09386adc8cc705a6316847c4b983760","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                topic\u003dtopic)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, body\u003dtypes.jsontype,"},{"line_number":791,"context_line":"                         status_code\u003d202)"},{"line_number":792,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":793,"context_line":"        \"\"\"Put the RAID configuration for a node."},{"line_number":794,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_f4e9a1e3","line":791,"updated":"2015-02-19 10:28:17.000000000","message":"I see the spec says 202 for this operators. But it makes me wonder a bit, because all this operation does is save the configuration to the DB, it doesn\u0027t start any background task to actually apply the RAID (it will be part of the zapping). So it really looks we should return 200 (OK) here.\n\nWhat you think? When 202 is returned it sounds like \"it\u0027s doing something in the background\" / \"There\u0027s more to do as part of this request\", which is not true for this.","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"031f728df02ff9d7a2fbb771b66d299187fc665f","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                topic\u003dtopic)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, body\u003dtypes.jsontype,"},{"line_number":791,"context_line":"                         status_code\u003d202)"},{"line_number":792,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":793,"context_line":"        \"\"\"Put the RAID configuration for a node."},{"line_number":794,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_b838f7a0","line":791,"in_reply_to":"da86d52c_f4e9a1e3","updated":"2015-02-19 12:50:05.000000000","message":"Just keeping as reference for others eventhough we have discussed, w3.org says:\nhttp://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html\n\nThe 202 response is intentionally non-committal. Its purpose is to allow a server to accept a request for some other process (perhaps a batch-oriented process that is only run once per day) without requiring that the user agent\u0027s connection to the server persist until the process is completed.\n\n\"perhaps a batch-oriented process that is only run once per day\" says tasks could still run at some point of time later on with a batch process (zap has a list of zap tasks).  So I think it should be okay with 202 as well eventhough it is not normally used in the context of our apis.","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a85cd6e98c1cf4c54febe5b6918ebdf980228b6a","unresolved":false,"context_lines":[{"line_number":765,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid)"},{"line_number":768,"context_line":"    def get(self, node_uuid):"},{"line_number":769,"context_line":"        \"\"\"Get the RAID configuration of a node."},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        Returns the current and target RAID configuration for the node."}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8fcac79f","line":768,"updated":"2015-02-20 12:57:35.000000000","message":"some time ago we switched to supporting both names and UUID\u0027s (see examples above).","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94e2cddcdfca826703c2abd02bd35c2cd8ba3128","unresolved":false,"context_lines":[{"line_number":765,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid)"},{"line_number":768,"context_line":"    def get(self, node_uuid):"},{"line_number":769,"context_line":"        \"\"\"Get the RAID configuration of a node."},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        Returns the current and target RAID configuration for the node."}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_4b742399","line":768,"in_reply_to":"ba7be1f8_8fcac79f","updated":"2015-02-21 08:00:48.000000000","message":"Done","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a85cd6e98c1cf4c54febe5b6918ebdf980228b6a","unresolved":false,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, body\u003dtypes.jsontype,"},{"line_number":791,"context_line":"                         status_code\u003d202)"},{"line_number":792,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":793,"context_line":"        \"\"\"Put the RAID configuration for a node."},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        Validates and stores the RAID configuration for the node in"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_6f3cb394","line":792,"updated":"2015-02-20 12:57:35.000000000","message":"ditto","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94e2cddcdfca826703c2abd02bd35c2cd8ba3128","unresolved":false,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    @wsme_pecan.wsexpose(None, types.uuid, body\u003dtypes.jsontype,"},{"line_number":791,"context_line":"                         status_code\u003d202)"},{"line_number":792,"context_line":"    def put(self, node_uuid, raid_config):"},{"line_number":793,"context_line":"        \"\"\"Put the RAID configuration for a node."},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        Validates and stores the RAID configuration for the node in"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_6b6807bb","line":792,"in_reply_to":"ba7be1f8_6f3cb394","updated":"2015-02-21 08:00:48.000000000","message":"Done","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a85cd6e98c1cf4c54febe5b6918ebdf980228b6a","unresolved":false,"context_lines":[{"line_number":818,"context_line":"    \"\"\"Expose the RAID configuration as a sub-element of nodes\"\"\""},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid)"},{"line_number":821,"context_line":"    def physical_disks(self, node_uuid):"},{"line_number":822,"context_line":"        \"\"\"Get the physical disks behind RAID controllers."},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        Returns the information about physical disks that are behind"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8f41e70d","line":821,"updated":"2015-02-20 12:57:35.000000000","message":"ditto","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94e2cddcdfca826703c2abd02bd35c2cd8ba3128","unresolved":false,"context_lines":[{"line_number":818,"context_line":"    \"\"\"Expose the RAID configuration as a sub-element of nodes\"\"\""},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid)"},{"line_number":821,"context_line":"    def physical_disks(self, node_uuid):"},{"line_number":822,"context_line":"        \"\"\"Get the physical disks behind RAID controllers."},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        Returns the information about physical disks that are behind"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8b653be3","line":821,"in_reply_to":"ba7be1f8_8f41e70d","updated":"2015-02-21 08:00:48.000000000","message":"Done","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"4a795551caf4bd75b3cc96246e751f675c6363d8","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        self._set_maintenance(node_ident, False)"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid_or_name)"},{"line_number":782,"context_line":"    def get(self, node_ident):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_0c04177a","line":779,"updated":"2015-03-04 20:46:34.000000000","message":"Need some checks for the micro version.","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"29511227eaa39b685a38c179cf47308a75ff59c8","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        self._set_maintenance(node_ident, False)"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"class NodeRaidConfigurationController(rest.RestController):"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    @wsme_pecan.wsexpose(types.jsontype, types.uuid_or_name)"},{"line_number":782,"context_line":"    def get(self, node_ident):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_e4634a18","line":779,"in_reply_to":"9a80dd14_0c04177a","updated":"2015-03-05 05:00:32.000000000","message":"Ditto as comment on driver.py","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"}],"ironic/common/raid.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import json"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import jsonschema"},{"line_number":18,"context_line":"from jsonschema import exceptions as json_schema_exc"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3e291d8a","line":18,"updated":"2015-02-13 11:27:11.000000000","message":"is this a new requirement?","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import json"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import jsonschema"},{"line_number":18,"context_line":"from jsonschema import exceptions as json_schema_exc"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_30459717","line":18,"in_reply_to":"da86d52c_3e291d8a","updated":"2015-02-16 09:07:59.000000000","message":"Yes, this is a new requirement. pep8 says this is a 3rd party library, but it seems to be included by default (that\u0027s why I guess jenkins went through for this patchset). Should we do something in that case ?","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                        default\u003dpaths.basedir_def("},{"line_number":29,"context_line":"                            \u0027common/raid_config_schema.json\u0027),"},{"line_number":30,"context_line":"                        help\u003d\u0027JSON Schema file for validating RAID \u0027"},{"line_number":31,"context_line":"                             \u0027configuration.\u0027),"},{"line_number":32,"context_line":"            ]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1e4b7960","line":31,"updated":"2015-02-13 11:27:11.000000000","message":"I don\u0027t think we need it configurable. What is the use case?","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                        default\u003dpaths.basedir_def("},{"line_number":29,"context_line":"                            \u0027common/raid_config_schema.json\u0027),"},{"line_number":30,"context_line":"                        help\u003d\u0027JSON Schema file for validating RAID \u0027"},{"line_number":31,"context_line":"                             \u0027configuration.\u0027),"},{"line_number":32,"context_line":"            ]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_706d4f99","line":31,"in_reply_to":"da86d52c_1e4b7960","updated":"2015-02-16 09:07:59.000000000","message":"Yeah, I think we don\u0027t need it.  I can hardcode it.","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    internal_info[\u0027target_raid_configuration\u0027] \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":107,"context_line":"    root_logical_disk \u003d filter(lambda x: x[\u0027is_root_volume\u0027], logical_disks)"},{"line_number":108,"context_line":"    if root_logical_disk:"},{"line_number":109,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":110,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_be3b4dc7","line":107,"updated":"2015-02-13 11:27:11.000000000","message":"nit:\n\n root_logical_disk \u003d [x for x in logical_disks if x[\u0027is_root_volume\u0027]]","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    internal_info[\u0027target_raid_configuration\u0027] \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":107,"context_line":"    root_logical_disk \u003d filter(lambda x: x[\u0027is_root_volume\u0027], logical_disks)"},{"line_number":108,"context_line":"    if root_logical_disk:"},{"line_number":109,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":110,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_b067c7b6","line":107,"in_reply_to":"da86d52c_be3b4dc7","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":107,"context_line":"    root_logical_disk \u003d filter(lambda x: x[\u0027is_root_volume\u0027], logical_disks)"},{"line_number":108,"context_line":"    if root_logical_disk:"},{"line_number":109,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":110,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"},{"line_number":111,"context_line":"        root_raid_level \u003d root_logical_disk[\u0027raid_level\u0027]"},{"line_number":112,"context_line":"        root_disk_size \u003d root_logical_disk[\u0027size_gb\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_fe5ce51b","line":109,"updated":"2015-02-13 11:27:11.000000000","message":"1. handle IndexError here; 2. what if we have \u003e1?","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":107,"context_line":"    root_logical_disk \u003d filter(lambda x: x[\u0027is_root_volume\u0027], logical_disks)"},{"line_number":108,"context_line":"    if root_logical_disk:"},{"line_number":109,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":110,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"},{"line_number":111,"context_line":"        root_raid_level \u003d root_logical_disk[\u0027raid_level\u0027]"},{"line_number":112,"context_line":"        root_disk_size \u003d root_logical_disk[\u0027size_gb\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f0e05fce","line":109,"in_reply_to":"da86d52c_fe5ce51b","updated":"2015-02-16 09:07:59.000000000","message":"We are entering this block only if there is at least one root logical disk.  So IndexError is taken care.\n\nHaving \u003e1 root logical disk isn\u0027t actually a valid case, but we can take the first logical disk having that (which is done now).","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8cda54d175283d2dc93c6e0ef0fd456b6060696d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        node_properties[\u0027local_gb\u0027] \u003d root_disk_size"},{"line_number":114,"context_line":"        node_properties[\u0027root_device_hint\u0027] \u003d root_device_hint"},{"line_number":115,"context_line":"        capability \u003d \u0027raid_level:%s\u0027 % root_raid_level"},{"line_number":116,"context_line":"        existing_capability \u003d node_properties.get(\u0027capabilities\u0027, None)"},{"line_number":117,"context_line":"        if existing_capability:"},{"line_number":118,"context_line":"            capability \u003d (\"%(existing)s,%(new)s\" %"},{"line_number":119,"context_line":"                          {\u0027existing\u0027: existing_capability,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_1e99b9d0","line":116,"updated":"2015-02-13 11:27:11.000000000","message":"nit: None is redundant","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        node_properties[\u0027local_gb\u0027] \u003d root_disk_size"},{"line_number":114,"context_line":"        node_properties[\u0027root_device_hint\u0027] \u003d root_device_hint"},{"line_number":115,"context_line":"        capability \u003d \u0027raid_level:%s\u0027 % root_raid_level"},{"line_number":116,"context_line":"        existing_capability \u003d node_properties.get(\u0027capabilities\u0027, None)"},{"line_number":117,"context_line":"        if existing_capability:"},{"line_number":118,"context_line":"            capability \u003d (\"%(existing)s,%(new)s\" %"},{"line_number":119,"context_line":"                          {\u0027existing\u0027: existing_capability,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_10e6d3e8","line":116,"in_reply_to":"da86d52c_1e99b9d0","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2eda03afe8907e17798f0609932a57ba3e80743b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    internal_info[\u0027target_raid_configuration\u0027] \u003d None"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":98,"context_line":"    root_logical_disk \u003d filter(lambda x: x[\u0027is_root_volume\u0027], logical_disks)"},{"line_number":99,"context_line":"    root_logical_disk \u003d [x for x in logical_disks if x[\u0027is_root_volume\u0027]]"},{"line_number":100,"context_line":"    if root_logical_disk:"},{"line_number":101,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_146b2286","line":98,"updated":"2015-02-16 09:58:40.000000000","message":"this line should be deleted","commit_id":"995215a1feecc655ccea4d78c9505eb87da46ae6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ce8e40fbacbb98eeca4df41caec2d3e9fdc64b6a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    internal_info[\u0027target_raid_configuration\u0027] \u003d None"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":98,"context_line":"    root_logical_disk \u003d filter(lambda x: x[\u0027is_root_volume\u0027], logical_disks)"},{"line_number":99,"context_line":"    root_logical_disk \u003d [x for x in logical_disks if x[\u0027is_root_volume\u0027]]"},{"line_number":100,"context_line":"    if root_logical_disk:"},{"line_number":101,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_658e6629","line":98,"in_reply_to":"da86d52c_146b2286","updated":"2015-02-16 11:16:53.000000000","message":"Done","commit_id":"995215a1feecc655ccea4d78c9505eb87da46ae6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e0367c52e73c515acd9b92bf486abe2021ed854","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        using the schema fails."},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    if not raid_config_schema:"},{"line_number":43,"context_line":"        raid_schema_fobj \u003d open(RAID_CONFIG_SCHEMA, \u0027r\u0027)"},{"line_number":44,"context_line":"        raid_config_schema \u003d json.load(raid_schema_fobj)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_6469768b","line":43,"updated":"2015-02-19 14:34:18.000000000","message":"you\u0027d better close it:\n\n with open(RAID_CONFIG_SCHEMA, \u0027r\u0027) as fp:\n   raid_config_schema \u003d json.load(fp)","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f70e477f65835d5b96bad64a7e017df241022d98","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        using the schema fails."},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    if not raid_config_schema:"},{"line_number":43,"context_line":"        raid_schema_fobj \u003d open(RAID_CONFIG_SCHEMA, \u0027r\u0027)"},{"line_number":44,"context_line":"        raid_config_schema \u003d json.load(raid_schema_fobj)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_3bcb1ca5","line":43,"in_reply_to":"da86d52c_6469768b","updated":"2015-02-19 15:06:06.000000000","message":"Done","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e0367c52e73c515acd9b92bf486abe2021ed854","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    if not raid_config_schema:"},{"line_number":63,"context_line":"        raid_schema_fobj \u003d open(RAID_CONFIG_SCHEMA, \u0027r\u0027)"},{"line_number":64,"context_line":"        raid_config_schema \u003d json.load(raid_schema_fobj)"},{"line_number":65,"context_line":"    logical_disk_schema \u003d raid_config_schema[\u0027properties\u0027][\u0027logical_disks\u0027]"},{"line_number":66,"context_line":"    properties \u003d logical_disk_schema[\u0027items\u0027][\u0027properties\u0027]"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_640096ab","line":64,"updated":"2015-02-19 14:34:18.000000000","message":"ditto","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f70e477f65835d5b96bad64a7e017df241022d98","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":"    if not raid_config_schema:"},{"line_number":63,"context_line":"        raid_schema_fobj \u003d open(RAID_CONFIG_SCHEMA, \u0027r\u0027)"},{"line_number":64,"context_line":"        raid_config_schema \u003d json.load(raid_schema_fobj)"},{"line_number":65,"context_line":"    logical_disk_schema \u003d raid_config_schema[\u0027properties\u0027][\u0027logical_disks\u0027]"},{"line_number":66,"context_line":"    properties \u003d logical_disk_schema[\u0027items\u0027][\u0027properties\u0027]"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_1bc818a7","line":64,"in_reply_to":"da86d52c_640096ab","updated":"2015-02-19 15:06:06.000000000","message":"Done","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e0367c52e73c515acd9b92bf486abe2021ed854","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    internal_info[\u0027target_raid_configuration\u0027] \u003d None"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":98,"context_line":"    root_logical_disk \u003d [x for x in logical_disks if x[\u0027is_root_volume\u0027]]"},{"line_number":99,"context_line":"    if root_logical_disk:"},{"line_number":100,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":101,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_846e6a62","line":98,"updated":"2015-02-19 14:34:18.000000000","message":"Maybe I already asked, but don\u0027t we need to handle case (probably raise) when len(root_logical_disk) \u003e 1?","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f70e477f65835d5b96bad64a7e017df241022d98","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    internal_info[\u0027target_raid_configuration\u0027] \u003d None"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    logical_disks \u003d current_raid_config[\u0027logical_disks\u0027]"},{"line_number":98,"context_line":"    root_logical_disk \u003d [x for x in logical_disks if x[\u0027is_root_volume\u0027]]"},{"line_number":99,"context_line":"    if root_logical_disk:"},{"line_number":100,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":101,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_1b6c98cf","line":98,"in_reply_to":"da86d52c_846e6a62","updated":"2015-02-19 15:06:06.000000000","message":"Done. Will add a check here.  I thought it should be taken care in validation, but I think it should be taken care at both places. And I missed to do it in validation as well.","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e0367c52e73c515acd9b92bf486abe2021ed854","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":101,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"},{"line_number":102,"context_line":"        root_raid_level \u003d root_logical_disk[\u0027raid_level\u0027]"},{"line_number":103,"context_line":"        root_disk_size \u003d root_logical_disk[\u0027size_gb\u0027]"},{"line_number":104,"context_line":"        node_properties[\u0027local_gb\u0027] \u003d root_disk_size"},{"line_number":105,"context_line":"        node_properties[\u0027root_device_hint\u0027] \u003d root_device_hint"},{"line_number":106,"context_line":"        capability \u003d \u0027raid_level:%s\u0027 % root_raid_level"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_64c1762e","line":103,"updated":"2015-02-19 14:34:18.000000000","message":"really nit, but I would prefer less temporary variables here, they\u0027re hard to keep in brain local cache :)","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f70e477f65835d5b96bad64a7e017df241022d98","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        root_logical_disk \u003d root_logical_disk[0]"},{"line_number":101,"context_line":"        root_device_hint \u003d root_logical_disk[\u0027root_device_hint\u0027]"},{"line_number":102,"context_line":"        root_raid_level \u003d root_logical_disk[\u0027raid_level\u0027]"},{"line_number":103,"context_line":"        root_disk_size \u003d root_logical_disk[\u0027size_gb\u0027]"},{"line_number":104,"context_line":"        node_properties[\u0027local_gb\u0027] \u003d root_disk_size"},{"line_number":105,"context_line":"        node_properties[\u0027root_device_hint\u0027] \u003d root_device_hint"},{"line_number":106,"context_line":"        capability \u003d \u0027raid_level:%s\u0027 % root_raid_level"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_9bb6c83c","line":103,"in_reply_to":"da86d52c_64c1762e","updated":"2015-02-19 15:06:06.000000000","message":"Done","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e0367c52e73c515acd9b92bf486abe2021ed854","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if existing_capability:"},{"line_number":109,"context_line":"            capability \u003d (\"%(existing)s,%(new)s\" %"},{"line_number":110,"context_line":"                          {\u0027existing\u0027: existing_capability,"},{"line_number":111,"context_line":"                           \u0027new\u0027: capability})"},{"line_number":112,"context_line":"        node_properties[\u0027capabilities\u0027] \u003d capability"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    node.driver_internal_info \u003d internal_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_c4086293","line":111,"updated":"2015-02-19 14:34:18.000000000","message":"this code looks like it\u0027s going to stack new \u0027raid_level:x\u0027 each time. shouldn\u0027t we filter out existing \u0027raid_level\u0027?","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f70e477f65835d5b96bad64a7e017df241022d98","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if existing_capability:"},{"line_number":109,"context_line":"            capability \u003d (\"%(existing)s,%(new)s\" %"},{"line_number":110,"context_line":"                          {\u0027existing\u0027: existing_capability,"},{"line_number":111,"context_line":"                           \u0027new\u0027: capability})"},{"line_number":112,"context_line":"        node_properties[\u0027capabilities\u0027] \u003d capability"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    node.driver_internal_info \u003d internal_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_1bf1f800","line":111,"in_reply_to":"da86d52c_c4086293","updated":"2015-02-19 15:06:06.000000000","message":"Done","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a85cd6e98c1cf4c54febe5b6918ebdf980228b6a","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if capability_str:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            cap_dict \u003d dict([x.split(\u0027:\u0027) for x in capability_str.split(\u0027,\u0027)])"},{"line_number":111,"context_line":"        except ValueError:"},{"line_number":112,"context_line":"            # Capabilities can be filled by operator.  ValueError can"},{"line_number":113,"context_line":"            # occur in malformed capabilities like:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_ef6ee395","line":110,"updated":"2015-02-20 12:57:35.000000000","message":"x.split(\u0027:\u0027, 1) otherwise you\u0027re going to fail on things like x:y:z","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94e2cddcdfca826703c2abd02bd35c2cd8ba3128","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if capability_str:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            cap_dict \u003d dict([x.split(\u0027:\u0027) for x in capability_str.split(\u0027,\u0027)])"},{"line_number":111,"context_line":"        except ValueError:"},{"line_number":112,"context_line":"            # Capabilities can be filled by operator.  ValueError can"},{"line_number":113,"context_line":"            # occur in malformed capabilities like:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_abb91f30","line":110,"in_reply_to":"ba7be1f8_ef6ee395","updated":"2015-02-21 08:00:48.000000000","message":"Done","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a85cd6e98c1cf4c54febe5b6918ebdf980228b6a","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    cap_dict[capability_name] \u003d capability_value"},{"line_number":119,"context_line":"    return \u0027,\u0027.join([\u0027%(key)s:%(value)s\u0027 % {\u0027key\u0027: key, \u0027value\u0027: value}"},{"line_number":120,"context_line":"                            for key, value in six.iteritems(cap_dict)])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def update_raid_info(node, current_raid_config):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_8f5807fc","line":120,"updated":"2015-02-20 12:57:35.000000000","message":"nit: indendation","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94e2cddcdfca826703c2abd02bd35c2cd8ba3128","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    cap_dict[capability_name] \u003d capability_value"},{"line_number":119,"context_line":"    return \u0027,\u0027.join([\u0027%(key)s:%(value)s\u0027 % {\u0027key\u0027: key, \u0027value\u0027: value}"},{"line_number":120,"context_line":"                            for key, value in six.iteritems(cap_dict)])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def update_raid_info(node, current_raid_config):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_cb5f330d","line":120,"in_reply_to":"ba7be1f8_8f5807fc","updated":"2015-02-21 08:00:48.000000000","message":"Done","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a85cd6e98c1cf4c54febe5b6918ebdf980228b6a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        node_prop[\u0027root_device_hint\u0027] \u003d root_logical_disk[\u0027root_device_hint\u0027]"},{"line_number":163,"context_line":"        cap_str \u003d node_prop.get(\u0027capabilities\u0027, \u0027\u0027)"},{"line_number":164,"context_line":"        node_prop[\u0027capabilities\u0027] \u003d _add_or_update_capability_str(cap_str,"},{"line_number":165,"context_line":"                \u0027raid_level\u0027, root_logical_disk[\u0027raid_level\u0027])"},{"line_number":166,"context_line":"        node.properties \u003d node_prop"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    node.save()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_0f0337b9","line":165,"updated":"2015-02-20 12:57:35.000000000","message":"nit: I suspect the correct indentation should place cap_str on a new line","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"94e2cddcdfca826703c2abd02bd35c2cd8ba3128","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        node_prop[\u0027root_device_hint\u0027] \u003d root_logical_disk[\u0027root_device_hint\u0027]"},{"line_number":163,"context_line":"        cap_str \u003d node_prop.get(\u0027capabilities\u0027, \u0027\u0027)"},{"line_number":164,"context_line":"        node_prop[\u0027capabilities\u0027] \u003d _add_or_update_capability_str(cap_str,"},{"line_number":165,"context_line":"                \u0027raid_level\u0027, root_logical_disk[\u0027raid_level\u0027])"},{"line_number":166,"context_line":"        node.properties \u003d node_prop"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    node.save()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba7be1f8_2b7d2f6f","line":165,"in_reply_to":"ba7be1f8_0f0337b9","updated":"2015-02-21 08:00:48.000000000","message":"Done","commit_id":"f4dd90002c01be4d45f5c53cc16ab8432418fb83"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    Ironic default RAID configuration schema."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    :param raid_config_schema: A dictionary which is the schema to be used for"},{"line_number":69,"context_line":"        validation. (Optional)"},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":"    if not raid_config_schema:"},{"line_number":72,"context_line":"        with open(RAID_CONFIG_SCHEMA, \u0027r\u0027) as raid_schema_fobj:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_c16ffdc3","line":69,"updated":"2015-02-23 10:31:00.000000000","message":"nit: :return:","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    Ironic default RAID configuration schema."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    :param raid_config_schema: A dictionary which is the schema to be used for"},{"line_number":69,"context_line":"        validation. (Optional)"},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":"    if not raid_config_schema:"},{"line_number":72,"context_line":"        with open(RAID_CONFIG_SCHEMA, \u0027r\u0027) as raid_schema_fobj:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_3c771e3c","line":69,"in_reply_to":"ba7be1f8_c16ffdc3","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    :param capability_str: Current capability string of a node"},{"line_number":102,"context_line":"    :param capability_name: Name of the capability"},{"line_number":103,"context_line":"    :param capability_value: Value of the capability"},{"line_number":104,"context_line":"    :raises: InvalidParameterValue, if capability_str is malformed."},{"line_number":105,"context_line":"    \"\"\""},{"line_number":106,"context_line":"    cap_dict \u003d {}"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_414ced70","line":104,"updated":"2015-02-23 10:31:00.000000000","message":"nit: :return:","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    :param capability_str: Current capability string of a node"},{"line_number":102,"context_line":"    :param capability_name: Name of the capability"},{"line_number":103,"context_line":"    :param capability_value: Value of the capability"},{"line_number":104,"context_line":"    :raises: InvalidParameterValue, if capability_str is malformed."},{"line_number":105,"context_line":"    \"\"\""},{"line_number":106,"context_line":"    cap_dict \u003d {}"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_dc9d225b","line":104,"in_reply_to":"ba7be1f8_414ced70","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    if capability_str:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            cap_dict \u003d dict([x.split(\u0027:\u0027, 1)"},{"line_number":111,"context_line":"                             for x in capability_str.split(\u0027,\u0027)])"},{"line_number":112,"context_line":"        except ValueError:"},{"line_number":113,"context_line":"            # Capabilities can be filled by operator.  ValueError can"},{"line_number":114,"context_line":"            # occur in malformed capabilities like:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_2192999f","line":111,"updated":"2015-02-23 10:31:00.000000000","message":"nit: square brackets are redundant and somewhat suboptimal even","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    if capability_str:"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            cap_dict \u003d dict([x.split(\u0027:\u0027, 1)"},{"line_number":111,"context_line":"                             for x in capability_str.split(\u0027,\u0027)])"},{"line_number":112,"context_line":"        except ValueError:"},{"line_number":113,"context_line":"            # Capabilities can be filled by operator.  ValueError can"},{"line_number":114,"context_line":"            # occur in malformed capabilities like:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_bc9a2e61","line":111,"in_reply_to":"ba7be1f8_2192999f","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed11dbd6b61fa7dca32743b11bbb8b3becc5dac0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# TODO(rameshg87): There are some methods in ironic.drivers.utils -"},{"line_number":77,"context_line":"# add_node_capability and rm_node_capability which can achieve the same"},{"line_number":78,"context_line":"# But they cannot be invoked from here because of circular import issue."},{"line_number":79,"context_line":"# This code needs to merged with functionality in ironic.drivers.utils."},{"line_number":80,"context_line":"# Moving the code from ironic.driver.utils breaks a lot of things, hence"},{"line_number":81,"context_line":"# may be attempted later."}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_83f07192","line":78,"updated":"2015-03-06 13:28:33.000000000","message":"not sure what you mean here. why would ironic.drivers.utils import this file? I would highly prefer we don\u0027t have this code in several places","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c1c704efbb26be1b4a5b7a8812167529db1c543c","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# TODO(rameshg87): There are some methods in ironic.drivers.utils -"},{"line_number":77,"context_line":"# add_node_capability and rm_node_capability which can achieve the same"},{"line_number":78,"context_line":"# But they cannot be invoked from here because of circular import issue."},{"line_number":79,"context_line":"# This code needs to merged with functionality in ironic.drivers.utils."},{"line_number":80,"context_line":"# Moving the code from ironic.driver.utils breaks a lot of things, hence"},{"line_number":81,"context_line":"# may be attempted later."}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_6b2fab88","line":78,"in_reply_to":"9a80dd14_83f07192","updated":"2015-03-08 06:49:04.000000000","message":"I will put up another patch for refactor and then base this patch on that.","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"}],"ironic/common/raid_config_schema.json":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":10,"context_line":"                    \"raid_level\": {"},{"line_number":11,"context_line":"                        \"type\": \"string\","},{"line_number":12,"context_line":"                        \"enum\": [ \"0\", \"1\", \"2\", \"5\", \"6\", \"1+0\" ],"},{"line_number":13,"context_line":"                        \"description\": \"RAID level for the logical disk. Required.\""},{"line_number":14,"context_line":"                    },"},{"line_number":15,"context_line":"                    \"size_gb\": {"},{"line_number":16,"context_line":"                        \"type\": \"integer\","}],"source_content_type":"application/json","patch_set":7,"id":"da86d52c_0f38373c","line":13,"updated":"2015-02-17 14:53:30.000000000","message":"\"5+0\", \"6+0\"","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":10,"context_line":"                    \"raid_level\": {"},{"line_number":11,"context_line":"                        \"type\": \"string\","},{"line_number":12,"context_line":"                        \"enum\": [ \"0\", \"1\", \"2\", \"5\", \"6\", \"1+0\" ],"},{"line_number":13,"context_line":"                        \"description\": \"RAID level for the logical disk. Required.\""},{"line_number":14,"context_line":"                    },"},{"line_number":15,"context_line":"                    \"size_gb\": {"},{"line_number":16,"context_line":"                        \"type\": \"integer\","}],"source_content_type":"application/json","patch_set":7,"id":"da86d52c_d57b12f2","line":13,"in_reply_to":"da86d52c_0f38373c","updated":"2015-02-17 15:21:16.000000000","message":"Done","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"}],"ironic/conductor/manager.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd07a363710adb8d3d94bf18f2046d7ac636e60a","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"            node.save()"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"    @messaging.expected_exceptions(exception.UnsupportedDriverExtension)"},{"line_number":1378,"context_line":"    def get_raid_configuration(self, context, node_id, disk_type, topic\u003dNone):"},{"line_number":1379,"context_line":"        \"\"\"Get the RAID physical disks for the node."},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"        Gets the information about physical disks available in the node"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f776c23e","line":1378,"updated":"2015-02-13 15:35:46.000000000","message":"topic seems to be a copypaste here, it\u0027s not needed.","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"            node.save()"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"    @messaging.expected_exceptions(exception.UnsupportedDriverExtension)"},{"line_number":1378,"context_line":"    def get_raid_configuration(self, context, node_id, disk_type, topic\u003dNone):"},{"line_number":1379,"context_line":"        \"\"\"Get the RAID physical disks for the node."},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"        Gets the information about physical disks available in the node"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_70cc6f62","line":1378,"in_reply_to":"da86d52c_f776c23e","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bd07a363710adb8d3d94bf18f2046d7ac636e60a","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"            internal_info \u003d task.node.driver_internal_info"},{"line_number":1404,"context_line":"            current \u003d internal_info.get(\u0027current_raid_configuration\u0027, {})"},{"line_number":1405,"context_line":"            target \u003d internal_info.get(\u0027target_raid_configuration\u0027, {})"},{"line_number":1406,"context_line":"            last_updated \u003d current.get(\u0027last_updated\u0027, None)"},{"line_number":1407,"context_line":"            return_val \u003d {}"},{"line_number":1408,"context_line":"            return_val[\u0027last_updated\u0027] \u003d last_updated"},{"line_number":1409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_970ae677","line":1406,"updated":"2015-02-13 15:35:46.000000000","message":"None is the default.","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"be039369d3008027b1cfacb5262eeabb617b7f21","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"            internal_info \u003d task.node.driver_internal_info"},{"line_number":1404,"context_line":"            current \u003d internal_info.get(\u0027current_raid_configuration\u0027, {})"},{"line_number":1405,"context_line":"            target \u003d internal_info.get(\u0027target_raid_configuration\u0027, {})"},{"line_number":1406,"context_line":"            last_updated \u003d current.get(\u0027last_updated\u0027, None)"},{"line_number":1407,"context_line":"            return_val \u003d {}"},{"line_number":1408,"context_line":"            return_val[\u0027last_updated\u0027] \u003d last_updated"},{"line_number":1409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_70f38f9f","line":1406,"in_reply_to":"da86d52c_970ae677","updated":"2015-02-16 09:07:59.000000000","message":"Done","commit_id":"ccc3ba07942ef88e858989b75950161db52a33fb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faf23e9be09386adc8cc705a6316847c4b983760","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"        LOG.debug(\"RPC get_raid_physical_disks called for node %(node)s\","},{"line_number":1403,"context_line":"                  {\u0027node\u0027: node_id})"},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1406,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"},{"line_number":1407,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1408,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027raid\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_d4d81d20","line":1405,"updated":"2015-02-19 10:28:17.000000000","message":"with task_manager.acquire(..., shared\u003dTrue)\n\nIt\u0027s a get no need to get a lock for this.","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"031f728df02ff9d7a2fbb771b66d299187fc665f","unresolved":false,"context_lines":[{"line_number":1402,"context_line":"        LOG.debug(\"RPC get_raid_physical_disks called for node %(node)s\","},{"line_number":1403,"context_line":"                  {\u0027node\u0027: node_id})"},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1406,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"},{"line_number":1407,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1408,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027raid\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_d5e1f6d0","line":1405,"in_reply_to":"da86d52c_d4d81d20","updated":"2015-02-19 12:50:05.000000000","message":"Done","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"                  {\u0027node\u0027: node_id, \u0027raid_config\u0027: raid_config})"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        # TODO(rameshg87): Prevent the change during zap state."},{"line_number":1379,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1380,"context_line":"            node \u003d task.node"},{"line_number":1381,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"},{"line_number":1382,"context_line":"                raise exception.UnsupportedDriverExtension("}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_c1429d0f","line":1379,"updated":"2015-02-23 10:31:00.000000000","message":"This should probably be discussed outside of this patch, but do we REALLY need a lock (i.e. non-shared) here? Database should handle concurrent updates properly and out locks are pretty heavy-weight.","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"                  {\u0027node\u0027: node_id, \u0027raid_config\u0027: raid_config})"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"        # TODO(rameshg87): Prevent the change during zap state."},{"line_number":1379,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1380,"context_line":"            node \u003d task.node"},{"line_number":1381,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"},{"line_number":1382,"context_line":"                raise exception.UnsupportedDriverExtension("}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_9c99ea21","line":1379,"in_reply_to":"ba7be1f8_c1429d0f","updated":"2015-02-23 11:29:18.000000000","message":"Yeah, this doesn\u0027t require a lock essentially. But I am afraid things like below are not atomic:\n\n  driver_internal_info \u003d node.driver_internal_info\n  \u003cmodify driver_internal_info\u003e\n  node.driver_internal_info \u003d driver_internal_info\n  node.save\n\nWithout an atomic way to update the db, we would run into problems. We need a way for atomically updating node properties in database without locks\u000f.","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"4a795551caf4bd75b3cc96246e751f675c6363d8","unresolved":false,"context_lines":[{"line_number":1548,"context_line":"                  \u0027RAID configuration %(raid_config)s\u0027,"},{"line_number":1549,"context_line":"                  {\u0027node\u0027: node_id, \u0027raid_config\u0027: raid_config})"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        # TODO(rameshg87): Prevent the change during zap state."},{"line_number":1552,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1553,"context_line":"            node \u003d task.node"},{"line_number":1554,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_c9367103","line":1551,"updated":"2015-03-04 20:46:34.000000000","message":"Should this only be allowed in MANAGEABLE state, if its preparation for zapping?","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"29511227eaa39b685a38c179cf47308a75ff59c8","unresolved":false,"context_lines":[{"line_number":1548,"context_line":"                  \u0027RAID configuration %(raid_config)s\u0027,"},{"line_number":1549,"context_line":"                  {\u0027node\u0027: node_id, \u0027raid_config\u0027: raid_config})"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        # TODO(rameshg87): Prevent the change during zap state."},{"line_number":1552,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1553,"context_line":"            node \u003d task.node"},{"line_number":1554,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_24456270","line":1551,"in_reply_to":"9a80dd14_c9367103","updated":"2015-03-05 05:00:32.000000000","message":"Done.","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed11dbd6b61fa7dca32743b11bbb8b3becc5dac0","unresolved":false,"context_lines":[{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1564,"context_line":""},{"line_number":1565,"context_line":"            # Putting RAID configuration can be done only in MANAGEABLE state."},{"line_number":1566,"context_line":"            if task.node.provision_state !\u003d states.MANAGEABLE:"},{"line_number":1567,"context_line":"                action \u003d \u0027put_raid_configuration\u0027"},{"line_number":1568,"context_line":"                current_state \u003d task.node.provision_state"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_834791bb","line":1565,"updated":"2015-03-06 13:28:33.000000000","message":"note: in the future ENROLL should work too. maybe add a TODO?","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c1c704efbb26be1b4a5b7a8812167529db1c543c","unresolved":false,"context_lines":[{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        with task_manager.acquire(context, node_id) as task:"},{"line_number":1564,"context_line":""},{"line_number":1565,"context_line":"            # Putting RAID configuration can be done only in MANAGEABLE state."},{"line_number":1566,"context_line":"            if task.node.provision_state !\u003d states.MANAGEABLE:"},{"line_number":1567,"context_line":"                action \u003d \u0027put_raid_configuration\u0027"},{"line_number":1568,"context_line":"                current_state \u003d task.node.provision_state"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_ab2d2397","line":1565,"in_reply_to":"9a80dd14_834791bb","updated":"2015-03-08 06:49:04.000000000","message":"Done","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed11dbd6b61fa7dca32743b11bbb8b3becc5dac0","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"            # Putting RAID configuration can be done only in MANAGEABLE state."},{"line_number":1566,"context_line":"            if task.node.provision_state !\u003d states.MANAGEABLE:"},{"line_number":1567,"context_line":"                action \u003d \u0027put_raid_configuration\u0027"},{"line_number":1568,"context_line":"                current_state \u003d task.node.provision_state"},{"line_number":1569,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":1570,"context_line":"                    action\u003daction, node\u003dtask.node.uuid, state\u003dcurrent_state)"},{"line_number":1571,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_c37b49f3","line":1568,"updated":"2015-03-06 13:28:33.000000000","message":"nit: redundant variables","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c1c704efbb26be1b4a5b7a8812167529db1c543c","unresolved":false,"context_lines":[{"line_number":1565,"context_line":"            # Putting RAID configuration can be done only in MANAGEABLE state."},{"line_number":1566,"context_line":"            if task.node.provision_state !\u003d states.MANAGEABLE:"},{"line_number":1567,"context_line":"                action \u003d \u0027put_raid_configuration\u0027"},{"line_number":1568,"context_line":"                current_state \u003d task.node.provision_state"},{"line_number":1569,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":1570,"context_line":"                    action\u003daction, node\u003dtask.node.uuid, state\u003dcurrent_state)"},{"line_number":1571,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_eb239ba4","line":1568,"in_reply_to":"9a80dd14_c37b49f3","updated":"2015-03-08 06:49:04.000000000","message":"Done","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ed11dbd6b61fa7dca32743b11bbb8b3becc5dac0","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":1570,"context_line":"                    action\u003daction, node\u003dtask.node.uuid, state\u003dcurrent_state)"},{"line_number":1571,"context_line":""},{"line_number":1572,"context_line":"            node \u003d task.node"},{"line_number":1573,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"},{"line_number":1574,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1575,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027raid\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_436f592b","line":1572,"updated":"2015-03-06 13:28:33.000000000","message":"nit: if you put it higher, you can use it in the previous check too","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c1c704efbb26be1b4a5b7a8812167529db1c543c","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"                raise exception.InvalidStateRequested("},{"line_number":1570,"context_line":"                    action\u003daction, node\u003dtask.node.uuid, state\u003dcurrent_state)"},{"line_number":1571,"context_line":""},{"line_number":1572,"context_line":"            node \u003d task.node"},{"line_number":1573,"context_line":"            if not getattr(task.driver, \u0027raid\u0027, None):"},{"line_number":1574,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":1575,"context_line":"                            driver\u003dtask.node.driver, extension\u003d\u0027raid\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a80dd14_cb1ed75e","line":1572,"in_reply_to":"9a80dd14_436f592b","updated":"2015-03-08 06:49:04.000000000","message":"Done","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                          node_id\u003dnode_id, raid_config\u003draid_config)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def get_raid_configuration(self, context, node_id, disk_type, topic\u003dNone):"},{"line_number":507,"context_line":"        \"\"\"Get the RAID physical disks of the node."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        Gets the current and target RAID configuration for the given"},{"line_number":510,"context_line":"        node and returns it in dictionary format."}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_2fda5be9","line":507,"updated":"2015-02-17 14:53:30.000000000","message":"s/RAID//","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                          node_id\u003dnode_id, raid_config\u003draid_config)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def get_raid_configuration(self, context, node_id, disk_type, topic\u003dNone):"},{"line_number":507,"context_line":"        \"\"\"Get the RAID physical disks of the node."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        Gets the current and target RAID configuration for the given"},{"line_number":510,"context_line":"        node and returns it in dictionary format."}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_7576e607","line":507,"in_reply_to":"da86d52c_2fda5be9","updated":"2015-02-17 15:21:16.000000000","message":"Done","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"4a795551caf4bd75b3cc96246e751f675c6363d8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":75,"context_line":"    RPC_API_VERSION \u003d \u00271.24\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":78,"context_line":"        super(ConductorAPI, self).__init__()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_6993c5fa","line":75,"updated":"2015-03-04 20:46:34.000000000","message":"Should be 1.25","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"29511227eaa39b685a38c179cf47308a75ff59c8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":75,"context_line":"    RPC_API_VERSION \u003d \u00271.24\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":78,"context_line":"        super(ConductorAPI, self).__init__()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_645e7a47","line":75,"in_reply_to":"9a80dd14_6993c5fa","updated":"2015-03-05 05:00:32.000000000","message":"Done","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a282a21b6e99558fe7d03ae195e85a28da1ebecc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    driver_info \u003d Column(JSONEncodedDict)"},{"line_number":169,"context_line":"    driver_internal_info \u003d Column(JSONEncodedDict)"},{"line_number":170,"context_line":"    clean_step \u003d Column(JSONEncodedDict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    raid_config \u003d Column(JSONEncodedDict)"},{"line_number":173,"context_line":"    target_raid_config \u003d Column(JSONEncodedDict)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba3cc151_f923d403","line":171,"updated":"2015-06-29 20:38:01.000000000","message":"I don\u0027t mean to be picky, but why the blank line here when the stuff above don\u0027t have blank lines.","commit_id":"9701cd43078819ee4517aa8ba14fa3765ff2d5bc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"04c2552c3c22133711d40718a3410d05d278546f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    driver_info \u003d Column(JSONEncodedDict)"},{"line_number":169,"context_line":"    driver_internal_info \u003d Column(JSONEncodedDict)"},{"line_number":170,"context_line":"    clean_step \u003d Column(JSONEncodedDict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    raid_config \u003d Column(JSONEncodedDict)"},{"line_number":173,"context_line":"    target_raid_config \u003d Column(JSONEncodedDict)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba3cc151_03ab9a1e","line":171,"in_reply_to":"ba3cc151_f923d403","updated":"2015-06-30 04:17:32.000000000","message":"Will fix it in one of the next patches when I am addressing something. :)","commit_id":"9701cd43078819ee4517aa8ba14fa3765ff2d5bc"}],"ironic/drivers/base.py":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        Implementations of this interface are supposed to read the"},{"line_number":667,"context_line":"        RAID configuration from"},{"line_number":668,"context_line":"        node.driver_internal_info.target_raid_configuration. Driver"},{"line_number":669,"context_line":"        implementations of this method are supposed to call"},{"line_number":670,"context_line":"        ironic.common.raid.update_raid_info() with the current RAID"},{"line_number":671,"context_line":"        configuration after configuration RAID. Either of the two"},{"line_number":672,"context_line":"        arguments create_only_root_volume or create_only_nonroot_volumes"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_6f57f326","line":669,"updated":"2015-02-17 14:53:30.000000000","message":"This call are not necessarily supposed to call update_raid_info because it might be async.","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        Implementations of this interface are supposed to read the"},{"line_number":667,"context_line":"        RAID configuration from"},{"line_number":668,"context_line":"        node.driver_internal_info.target_raid_configuration. Driver"},{"line_number":669,"context_line":"        implementations of this method are supposed to call"},{"line_number":670,"context_line":"        ironic.common.raid.update_raid_info() with the current RAID"},{"line_number":671,"context_line":"        configuration after configuration RAID. Either of the two"},{"line_number":672,"context_line":"        arguments create_only_root_volume or create_only_nonroot_volumes"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_554e42c3","line":669,"in_reply_to":"da86d52c_6f57f326","updated":"2015-02-17 15:21:16.000000000","message":"Done","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        node.driver_internal_info.target_raid_configuration. Driver"},{"line_number":669,"context_line":"        implementations of this method are supposed to call"},{"line_number":670,"context_line":"        ironic.common.raid.update_raid_info() with the current RAID"},{"line_number":671,"context_line":"        configuration after configuration RAID. Either of the two"},{"line_number":672,"context_line":"        arguments create_only_root_volume or create_only_nonroot_volumes"},{"line_number":673,"context_line":"        may be set to True (only one of them should be set to True)."},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_af62cb13","line":671,"updated":"2015-02-17 14:53:30.000000000","message":"after configuration finished?","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        node.driver_internal_info.target_raid_configuration. Driver"},{"line_number":669,"context_line":"        implementations of this method are supposed to call"},{"line_number":670,"context_line":"        ironic.common.raid.update_raid_info() with the current RAID"},{"line_number":671,"context_line":"        configuration after configuration RAID. Either of the two"},{"line_number":672,"context_line":"        arguments create_only_root_volume or create_only_nonroot_volumes"},{"line_number":673,"context_line":"        may be set to True (only one of them should be set to True)."},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_35538e6d","line":671,"in_reply_to":"da86d52c_af62cb13","updated":"2015-02-17 15:21:16.000000000","message":"Done","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        \"\"\"Deletes RAID configuration on the given node."},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        Driver implementations of this method are supposed to call"},{"line_number":690,"context_line":"        ironic.common.raid.update_raid_info() after deleting RAID."},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        :param task: a TaskManager instance."},{"line_number":693,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_8f526733","line":690,"updated":"2015-02-17 14:53:30.000000000","message":"ditto","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        \"\"\"Deletes RAID configuration on the given node."},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        Driver implementations of this method are supposed to call"},{"line_number":690,"context_line":"        ironic.common.raid.update_raid_info() after deleting RAID."},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        :param task: a TaskManager instance."},{"line_number":693,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_9548bab4","line":690,"in_reply_to":"da86d52c_8f526733","updated":"2015-02-17 15:21:16.000000000","message":"Done","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e0367c52e73c515acd9b92bf486abe2021ed854","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    @abc.abstractmethod"},{"line_number":658,"context_line":"    def create_configuration(self, task,"},{"line_number":659,"context_line":"                             create_only_root_volume\u003dFalse,"},{"line_number":660,"context_line":"                             create_only_nonroot_volumes\u003dFalse):"},{"line_number":661,"context_line":"        \"\"\"Creates RAID configuration on the given node."},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        This method creates a RAID configuration on the given node."}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_e48006c1","line":660,"updated":"2015-02-19 14:34:18.000000000","message":"I imaging people calling create_only_root_volume\u003dTrue and create_only_nonroot_volumes\u003dTrue :) maybe we should drop _only_ and allow both to be created?","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f70e477f65835d5b96bad64a7e017df241022d98","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    @abc.abstractmethod"},{"line_number":658,"context_line":"    def create_configuration(self, task,"},{"line_number":659,"context_line":"                             create_only_root_volume\u003dFalse,"},{"line_number":660,"context_line":"                             create_only_nonroot_volumes\u003dFalse):"},{"line_number":661,"context_line":"        \"\"\"Creates RAID configuration on the given node."},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        This method creates a RAID configuration on the given node."}],"source_content_type":"text/x-python","patch_set":9,"id":"da86d52c_7b6e7497","line":660,"in_reply_to":"da86d52c_e48006c1","updated":"2015-02-19 15:06:06.000000000","message":"Do you mean to inverse the stuff here ?\n\ndef create_configuration(self, task, create_root_volume\u003dTrue, create_nonroot_volumes\u003dTrue)\n\nWe can do that ..","commit_id":"939be322f0d035c40433aac1c67d037b80cbebeb"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"4a795551caf4bd75b3cc96246e751f675c6363d8","unresolved":false,"context_lines":[{"line_number":789,"context_line":"    return decorator2"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"class RAIDInterface(object):"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @abc.abstractmethod"},{"line_number":795,"context_line":"    def create_configuration(self, task,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_97a7304f","line":792,"updated":"2015-03-04 20:46:34.000000000","message":"This should be BaseInterface if you want people to be able to do out of band RAID zapping.","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"29511227eaa39b685a38c179cf47308a75ff59c8","unresolved":false,"context_lines":[{"line_number":789,"context_line":"    return decorator2"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"class RAIDInterface(object):"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    @abc.abstractmethod"},{"line_number":795,"context_line":"    def create_configuration(self, task,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_a4587257","line":792,"in_reply_to":"9a80dd14_97a7304f","updated":"2015-03-05 05:00:32.000000000","message":"Done","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"4a795551caf4bd75b3cc96246e751f675c6363d8","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        :param task: a TaskManager instance."},{"line_number":842,"context_line":"        :raises: InvalidParameterValue, if the RAID configuration is invalid."},{"line_number":843,"context_line":"        \"\"\""},{"line_number":844,"context_line":"        raid.validate_configuration(raid_config)"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def get_logical_disk_properties(self):"},{"line_number":847,"context_line":"        \"\"\"Get the properties that can be specified for logical disks."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_17b180f8","line":844,"updated":"2015-03-04 20:46:34.000000000","message":"You should pass in the default schema you\u0027ve created right here, rather than having it default inside the method. It will be more apparent for people implementing this interface that when they want to add a custom RAID level or disk type or whatever, they\u0027ll need to create their own schema and pass it in. \n\nIt\u0027s somewhat obvious in this review, but not so much after it merges.","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"29511227eaa39b685a38c179cf47308a75ff59c8","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        :param task: a TaskManager instance."},{"line_number":842,"context_line":"        :raises: InvalidParameterValue, if the RAID configuration is invalid."},{"line_number":843,"context_line":"        \"\"\""},{"line_number":844,"context_line":"        raid.validate_configuration(raid_config)"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def get_logical_disk_properties(self):"},{"line_number":847,"context_line":"        \"\"\"Get the properties that can be specified for logical disks."}],"source_content_type":"text/x-python","patch_set":17,"id":"9a80dd14_c455661e","line":844,"in_reply_to":"9a80dd14_17b180f8","updated":"2015-03-05 05:00:32.000000000","message":"Done","commit_id":"5e862f9e694db205d706beba5a648e6d3810e07a"}],"ironic/tests/conductor/test_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"        self.driver.raid \u003d None"},{"line_number":1954,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":1955,"context_line":"                          self.service.put_raid_configuration,"},{"line_number":1956,"context_line":"                          self.context, node.uuid, raid_config)"},{"line_number":1957,"context_line":"        node.refresh()"},{"line_number":1958,"context_line":"        self.assertNotIn(\u0027target_raid_configuration\u0027,"},{"line_number":1959,"context_line":"                         node.driver_internal_info)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_a1d76922","line":1956,"updated":"2015-02-23 10:31:00.000000000","message":"would be nice to test actual exception","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":1953,"context_line":"        self.driver.raid \u003d None"},{"line_number":1954,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":1955,"context_line":"                          self.service.put_raid_configuration,"},{"line_number":1956,"context_line":"                          self.context, node.uuid, raid_config)"},{"line_number":1957,"context_line":"        node.refresh()"},{"line_number":1958,"context_line":"        self.assertNotIn(\u0027target_raid_configuration\u0027,"},{"line_number":1959,"context_line":"                         node.driver_internal_info)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_bc36ae50","line":1956,"in_reply_to":"ba7be1f8_a1d76922","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"        raid_config \u003d {\u0027logical_disks\u0027: [{\u0027raid_level\u0027: \u00271\u0027}]}"},{"line_number":1964,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":1965,"context_line":"                          self.service.put_raid_configuration,"},{"line_number":1966,"context_line":"                          self.context, node.uuid, raid_config)"},{"line_number":1967,"context_line":"        node.refresh()"},{"line_number":1968,"context_line":"        self.assertNotIn(\u0027target_raid_configuration\u0027,"},{"line_number":1969,"context_line":"                         node.driver_internal_info)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_c1de1d3f","line":1966,"updated":"2015-02-23 10:31:00.000000000","message":"ditto","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"        raid_config \u003d {\u0027logical_disks\u0027: [{\u0027raid_level\u0027: \u00271\u0027}]}"},{"line_number":1964,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":1965,"context_line":"                          self.service.put_raid_configuration,"},{"line_number":1966,"context_line":"                          self.context, node.uuid, raid_config)"},{"line_number":1967,"context_line":"        node.refresh()"},{"line_number":1968,"context_line":"        self.assertNotIn(\u0027target_raid_configuration\u0027,"},{"line_number":1969,"context_line":"                         node.driver_internal_info)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_fc3f4623","line":1966,"in_reply_to":"ba7be1f8_c1de1d3f","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":2002,"context_line":"                self.context, node.uuid, \u0027logical_disks\u0027)"},{"line_number":2003,"context_line":"        self.assertEqual({}, returned_val[\u0027current\u0027])"},{"line_number":2004,"context_line":"        self.assertEqual(target_config, returned_val[\u0027target\u0027])"},{"line_number":2005,"context_line":"        self.assertEqual(None, returned_val[\u0027last_updated\u0027])"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"    def test_get_raid_configuration_logical_disks_no_info(self):"},{"line_number":2008,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_21e37906","line":2005,"updated":"2015-02-23 10:31:00.000000000","message":"nit: self.assertIsNone","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":2002,"context_line":"                self.context, node.uuid, \u0027logical_disks\u0027)"},{"line_number":2003,"context_line":"        self.assertEqual({}, returned_val[\u0027current\u0027])"},{"line_number":2004,"context_line":"        self.assertEqual(target_config, returned_val[\u0027target\u0027])"},{"line_number":2005,"context_line":"        self.assertEqual(None, returned_val[\u0027last_updated\u0027])"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"    def test_get_raid_configuration_logical_disks_no_info(self):"},{"line_number":2008,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_dc02826e","line":2005,"in_reply_to":"ba7be1f8_21e37906","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":2010,"context_line":"                self.context, node.uuid, \u0027logical_disks\u0027)"},{"line_number":2011,"context_line":"        self.assertEqual({}, returned_val[\u0027current\u0027])"},{"line_number":2012,"context_line":"        self.assertEqual({}, returned_val[\u0027target\u0027])"},{"line_number":2013,"context_line":"        self.assertEqual(None, returned_val[\u0027last_updated\u0027])"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"    def test_get_raid_configuration_iface_not_supported(self):"},{"line_number":2016,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_41f22dd3","line":2013,"updated":"2015-02-23 10:31:00.000000000","message":"ditto","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":2010,"context_line":"                self.context, node.uuid, \u0027logical_disks\u0027)"},{"line_number":2011,"context_line":"        self.assertEqual({}, returned_val[\u0027current\u0027])"},{"line_number":2012,"context_line":"        self.assertEqual({}, returned_val[\u0027target\u0027])"},{"line_number":2013,"context_line":"        self.assertEqual(None, returned_val[\u0027last_updated\u0027])"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"    def test_get_raid_configuration_iface_not_supported(self):"},{"line_number":2016,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_fcf8267e","line":2013,"in_reply_to":"ba7be1f8_41f22dd3","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"        self.driver.raid \u003d None"},{"line_number":2018,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":2019,"context_line":"                          self.service.get_raid_configuration,"},{"line_number":2020,"context_line":"                          self.context, node.uuid, \u0027logical_disks\u0027)"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"    def test_get_raid_configuration_physical_disks(self):"},{"line_number":2023,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_e1b881e7","line":2020,"updated":"2015-02-23 10:31:00.000000000","message":"ditto about checking exception","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"        self.driver.raid \u003d None"},{"line_number":2018,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":2019,"context_line":"                          self.service.get_raid_configuration,"},{"line_number":2020,"context_line":"                          self.context, node.uuid, \u0027logical_disks\u0027)"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"    def test_get_raid_configuration_physical_disks(self):"},{"line_number":2023,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_3cf39e9f","line":2020,"in_reply_to":"ba7be1f8_e1b881e7","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":2048,"context_line":"        returned_val \u003d self.service.get_raid_configuration("},{"line_number":2049,"context_line":"                self.context, node.uuid, \u0027physical_disks\u0027)"},{"line_number":2050,"context_line":"        self.assertEqual([], returned_val[\u0027physical_disks\u0027])"},{"line_number":2051,"context_line":"        self.assertEqual(None, returned_val[\u0027last_updated\u0027])"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"    def test_get_raid_configuration_invalid_disk_type(self):"},{"line_number":2054,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_21ca996e","line":2051,"updated":"2015-02-23 10:31:00.000000000","message":"nit: self.assertIsNone","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":2048,"context_line":"        returned_val \u003d self.service.get_raid_configuration("},{"line_number":2049,"context_line":"                self.context, node.uuid, \u0027physical_disks\u0027)"},{"line_number":2050,"context_line":"        self.assertEqual([], returned_val[\u0027physical_disks\u0027])"},{"line_number":2051,"context_line":"        self.assertEqual(None, returned_val[\u0027last_updated\u0027])"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"    def test_get_raid_configuration_invalid_disk_type(self):"},{"line_number":2054,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_5cee92b5","line":2051,"in_reply_to":"ba7be1f8_21ca996e","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee6106a475936cc144c05da2f00abe28afd81cea","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"        self._start_service()"},{"line_number":2069,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":2070,"context_line":"                          self.service.get_raid_logical_disk_properties,"},{"line_number":2071,"context_line":"                          self.context, \u0027fake\u0027)"},{"line_number":2072,"context_line":""},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"class ManagerSpawnWorkerTestCase(tests_base.TestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_a1a5a9b6","line":2071,"updated":"2015-02-23 10:31:00.000000000","message":"ditto about checking exception","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"2261a8a8c07a572246ac440066f9ee765a546849","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"        self._start_service()"},{"line_number":2069,"context_line":"        self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":2070,"context_line":"                          self.service.get_raid_logical_disk_properties,"},{"line_number":2071,"context_line":"                          self.context, \u0027fake\u0027)"},{"line_number":2072,"context_line":""},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"class ManagerSpawnWorkerTestCase(tests_base.TestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba7be1f8_7c2c3603","line":2071,"in_reply_to":"ba7be1f8_a1a5a9b6","updated":"2015-02-23 11:29:18.000000000","message":"Done","commit_id":"53b88a7759e1185ac1c38372bf9db0c56f032179"}],"ironic/tests/drivers/test_base.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faf23e9be09386adc8cc705a6316847c4b983760","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def test_validate_configuration(self, validate_mock):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        raid \u003d MyRAIDInterface()"},{"line_number":119,"context_line":"        raid.validate_configuration(\u0027task\u0027, \u0027raid_config\u0027)"},{"line_number":120,"context_line":"        validate_mock.assert_called_once_with(\u0027raid_config\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch.object(raid, \u0027get_logical_disk_properties\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_745bf185","line":119,"updated":"2015-02-19 10:28:17.000000000","message":"it\u0027s overwriting the \u0027raid\u0027 import here.","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"031f728df02ff9d7a2fbb771b66d299187fc665f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def test_validate_configuration(self, validate_mock):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        raid \u003d MyRAIDInterface()"},{"line_number":119,"context_line":"        raid.validate_configuration(\u0027task\u0027, \u0027raid_config\u0027)"},{"line_number":120,"context_line":"        validate_mock.assert_called_once_with(\u0027raid_config\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch.object(raid, \u0027get_logical_disk_properties\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_95bcdeb6","line":119,"in_reply_to":"da86d52c_745bf185","updated":"2015-02-19 12:50:05.000000000","message":"Done","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faf23e9be09386adc8cc705a6316847c4b983760","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    @mock.patch.object(raid, \u0027get_logical_disk_properties\u0027)"},{"line_number":123,"context_line":"    def test_get_logical_disk_properties(self, get_properties_mock):"},{"line_number":124,"context_line":"        raid \u003d MyRAIDInterface()"},{"line_number":125,"context_line":"        raid.get_logical_disk_properties()"},{"line_number":126,"context_line":"        get_properties_mock.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_9455c551","line":125,"updated":"2015-02-19 10:28:17.000000000","message":"ditto","commit_id":"74b8f758511291cbb5288182350614c077de4db3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"031f728df02ff9d7a2fbb771b66d299187fc665f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    @mock.patch.object(raid, \u0027get_logical_disk_properties\u0027)"},{"line_number":123,"context_line":"    def test_get_logical_disk_properties(self, get_properties_mock):"},{"line_number":124,"context_line":"        raid \u003d MyRAIDInterface()"},{"line_number":125,"context_line":"        raid.get_logical_disk_properties()"},{"line_number":126,"context_line":"        get_properties_mock.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_b5de420f","line":125,"in_reply_to":"da86d52c_9455c551","updated":"2015-02-19 12:50:05.000000000","message":"Done","commit_id":"74b8f758511291cbb5288182350614c077de4db3"}],"ironic/tests/raid_constants.py":[{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"09275e84a1ba89ae50ddd34c41b262e65710c433","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  \"logical_disks\": ["},{"line_number":56,"context_line":"      {"},{"line_number":57,"context_line":"       \"size_gb\": 100,"},{"line_number":58,"context_line":"       \"raid_level\": \"3\""},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":"  ]"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_6a6b6185","line":58,"updated":"2015-02-17 14:53:30.000000000","message":"while it\u0027s not supported by the raid validation, this is not an invalid value for raid level. I would prefer a truly invalid value here like \"foo\".","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"1936aaa6cbfe6ad5a35ad3cd00361a24c105ee07","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  \"logical_disks\": ["},{"line_number":56,"context_line":"      {"},{"line_number":57,"context_line":"       \"size_gb\": 100,"},{"line_number":58,"context_line":"       \"raid_level\": \"3\""},{"line_number":59,"context_line":"      }"},{"line_number":60,"context_line":"  ]"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_f5d016cb","line":58,"in_reply_to":"da86d52c_6a6b6185","updated":"2015-02-17 15:21:16.000000000","message":"Done","commit_id":"94067e199bd9218cee5c07eb6353a98fcb0a84f3"}],"requirements.txt":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"9788f5552906152338fccfabb51f2cbcd4c0e394","unresolved":false,"context_lines":[{"line_number":36,"context_line":"oslo.messaging\u003e\u003d1.6.0  # Apache-2.0"},{"line_number":37,"context_line":"retrying\u003e\u003d1.2.3,!\u003d1.3.0 # Apache-2.0"},{"line_number":38,"context_line":"posix_ipc"},{"line_number":39,"context_line":"jsonschema\u003c3.0.0,\u003e\u003d2.0.0"}],"source_content_type":"text/plain","patch_set":19,"id":"9a80dd14_2d53153a","line":39,"updated":"2015-03-07 02:07:47.000000000","message":"Can not find it in global requiremnents[1], so we need to add into global-requirements.txt first.\n\n\n[1] https://github.com/openstack/requirements/blob/master/global-requirements.txt","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c1c704efbb26be1b4a5b7a8812167529db1c543c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"oslo.messaging\u003e\u003d1.6.0  # Apache-2.0"},{"line_number":37,"context_line":"retrying\u003e\u003d1.2.3,!\u003d1.3.0 # Apache-2.0"},{"line_number":38,"context_line":"posix_ipc"},{"line_number":39,"context_line":"jsonschema\u003c3.0.0,\u003e\u003d2.0.0"}],"source_content_type":"text/plain","patch_set":19,"id":"9a80dd14_2b3933d7","line":39,"in_reply_to":"9a80dd14_2d53153a","updated":"2015-03-08 06:49:04.000000000","message":"It\u0027s here\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L45\n\nBut the version check in reverse order. Will sync it.","commit_id":"c638c41e052e5bf81a6670388480f4f61c9f7eb6"}]}
