)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"72c8f505f5da06141953ca7bbac4fd55683f0a5e","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"#allow_insecure_clients\u003dfalse"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"[oslo_messaging_qpid]"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"#"},{"line_number":1150,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"9a80dd14_90b51fd2","side":"PARENT","line":1147,"updated":"2015-03-18 20:47:14.000000000","message":"I have asked Ghe to look at this change. I believe it is related to the resent oslo changes, just want to be sure.","commit_id":"c9f506a93c68ea642c893f0c35400564e125392f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c70d6a134b050547771c6bc723767b51114706c7","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"#allow_insecure_clients\u003dfalse"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"[oslo_messaging_qpid]"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"#"},{"line_number":1150,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"9a80dd14_20542053","side":"PARENT","line":1147,"in_reply_to":"9a80dd14_204b402c","updated":"2015-03-18 22:31:50.000000000","message":"Let me know if its required to regenerate conf file","commit_id":"c9f506a93c68ea642c893f0c35400564e125392f"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"178c921728562989894b689fadcea5fc3600ad31","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"#allow_insecure_clients\u003dfalse"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"[oslo_messaging_qpid]"},{"line_number":1148,"context_line":""},{"line_number":1149,"context_line":"#"},{"line_number":1150,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"9a80dd14_204b402c","side":"PARENT","line":1147,"in_reply_to":"9a80dd14_90b51fd2","updated":"2015-03-18 22:17:03.000000000","message":"Nothing wrong here. The config file was generated before all the oslo update. A simple \u0027tox -egenconfig\u0027 will update the config file and include the new grub_config_template option as the only change.","commit_id":"c9f506a93c68ea642c893f0c35400564e125392f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c92cd377b78c21d8a4634d9e66d0f87f79a45afa","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":1167,"context_line":"#qpid_hostname\u003dlocalhost"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"# Qpid broker port. (integer value)"},{"line_number":1170,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a80dd14_91519c32","line":1167,"updated":"2015-03-19 00:08:17.000000000","message":"I generated this .sample and wondered why this got changed. After discussing with Josh, it occurred to me that localhost is correct. Looks like it got changed to ironic in [1] so Ghe must have some magic up his sleeve ;)\n\nI think it is fine *not* to mention this in the commit. I don\u0027t really think it is worth submitting a patch just to address this. (But if someone does, please speak up soon!)\n\n[1] https://github.com/openstack/ironic/commit/9a8145cc22f9f19e04ac19c9eca522972dbc09e6","commit_id":"e4b31377e88cd389a8bdb4464ac0345d6259387a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c92cd377b78c21d8a4634d9e66d0f87f79a45afa","unresolved":false,"context_lines":[{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":1244,"context_line":"# (string value)"},{"line_number":1245,"context_line":"#rabbit_host\u003dlocalhost"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":1248,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a80dd14_b131400d","line":1245,"updated":"2015-03-19 00:08:17.000000000","message":"ditto","commit_id":"e4b31377e88cd389a8bdb4464ac0345d6259387a"}],"ironic/common/images.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"67fe15c590c53321fd292f045666b903fcdcb6ce","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027grub_conf_template\u0027,"},{"line_number":52,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":53,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_e025bbae","line":53,"updated":"2015-02-17 11:25:52.000000000","message":"help string is the same as in previous option\n\nalso I suggest s/conf/config/ for consistency","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a2102895abe515377d96d6213132566ce34a8257","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027grub_conf_template\u0027,"},{"line_number":52,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":53,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_6f761308","line":53,"in_reply_to":"da86d52c_e025bbae","updated":"2015-02-17 14:39:10.000000000","message":"ok.","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"67fe15c590c53321fd292f045666b903fcdcb6ce","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                      ramdisk: \u0027initrd\u0027,"},{"line_number":215,"context_line":"                      CONF.isolinux_bin: ISOLINUX_BIN,"},{"line_number":216,"context_line":"                     }"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":219,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":220,"context_line":"        # directory."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_60ae2be9","line":217,"updated":"2015-02-17 11:25:52.000000000","message":"I suggest splitting this function into several ones, it\u0027s too big now","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a2102895abe515377d96d6213132566ce34a8257","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                      ramdisk: \u0027initrd\u0027,"},{"line_number":215,"context_line":"                      CONF.isolinux_bin: ISOLINUX_BIN,"},{"line_number":216,"context_line":"                     }"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":219,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":220,"context_line":"        # directory."}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_0f5d9779","line":217,"in_reply_to":"da86d52c_60ae2be9","updated":"2015-02-17 14:39:10.000000000","message":"ok.","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"67fe15c590c53321fd292f045666b903fcdcb6ce","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                        grub_rel_path \u003d os.path.relpath(grub_path,"},{"line_number":238,"context_line":"                                                        tmpdir1)"},{"line_number":239,"context_line":"                        files_info[grub_path] \u003d grub_rel_path"},{"line_number":240,"context_line":"            except (OSError, IOError) as e:"},{"line_number":241,"context_line":"                LOG.exception(_LE(\"mounting the deploy iso failed.\"))"},{"line_number":242,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_60dc6b75","line":240,"updated":"2015-02-17 11:25:52.000000000","message":"(OSError, IOError) \u003d EnvironmentError","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a2102895abe515377d96d6213132566ce34a8257","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                        grub_rel_path \u003d os.path.relpath(grub_path,"},{"line_number":238,"context_line":"                                                        tmpdir1)"},{"line_number":239,"context_line":"                        files_info[grub_path] \u003d grub_rel_path"},{"line_number":240,"context_line":"            except (OSError, IOError) as e:"},{"line_number":241,"context_line":"                LOG.exception(_LE(\"mounting the deploy iso failed.\"))"},{"line_number":242,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_4f4eafc3","line":240,"in_reply_to":"da86d52c_60dc6b75","updated":"2015-02-17 14:39:10.000000000","message":"ok.","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"377652f91b8340747b1527e6208d3796c026df03","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                                        tmpdir1)"},{"line_number":239,"context_line":"                        files_info[grub_path] \u003d grub_rel_path"},{"line_number":240,"context_line":"            except (OSError, IOError) as e:"},{"line_number":241,"context_line":"                LOG.exception(_LE(\"mounting the deploy iso failed.\"))"},{"line_number":242,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"            # if either of these variables are not initialized then the"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_18af8a95","line":241,"updated":"2015-02-24 16:23:53.000000000","message":"seems that it should be save_and_reraise_exception here as log may also throw an exception and OSerror or IOerror will be lost","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8b1bcc46c1b83b159f783427b1b765a059065a3a","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                                        tmpdir1)"},{"line_number":239,"context_line":"                        files_info[grub_path] \u003d grub_rel_path"},{"line_number":240,"context_line":"            except (OSError, IOError) as e:"},{"line_number":241,"context_line":"                LOG.exception(_LE(\"mounting the deploy iso failed.\"))"},{"line_number":242,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"            # if either of these variables are not initialized then the"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5e748367","line":241,"in_reply_to":"ba7be1f8_0d33c763","updated":"2015-02-24 18:37:41.000000000","message":"If this LOG statement throws an exception for some reason, it will be raised and execution won\u0027t go to raising ImageCreationFailed (as there is no exception handling around log statement), thus original oserror or ioerror will be lost.","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"9ebfdf553e37994a92addf20a5508938ff71ea54","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                                        tmpdir1)"},{"line_number":239,"context_line":"                        files_info[grub_path] \u003d grub_rel_path"},{"line_number":240,"context_line":"            except (OSError, IOError) as e:"},{"line_number":241,"context_line":"                LOG.exception(_LE(\"mounting the deploy iso failed.\"))"},{"line_number":242,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"            # if either of these variables are not initialized then the"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_0d33c763","line":241,"in_reply_to":"ba7be1f8_18af8a95","updated":"2015-02-24 17:43:36.000000000","message":"the OSError and IOError wil not be lost, they are caught and raised as \u0027e\u0027 in below line along with custom Exception.","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"67fe15c590c53321fd292f045666b903fcdcb6ce","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            try:"},{"line_number":254,"context_line":"                _create_root_fs(tmpdir, files_info)"},{"line_number":255,"context_line":"            except (OSError, IOError) as e:"},{"line_number":256,"context_line":"                LOG.exception(_LE(\"Creating the filesystem root failed.\"))"},{"line_number":257,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_a0e66342","line":255,"updated":"2015-02-17 11:25:52.000000000","message":"ditto","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a2102895abe515377d96d6213132566ce34a8257","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            try:"},{"line_number":254,"context_line":"                _create_root_fs(tmpdir, files_info)"},{"line_number":255,"context_line":"            except (OSError, IOError) as e:"},{"line_number":256,"context_line":"                LOG.exception(_LE(\"Creating the filesystem root failed.\"))"},{"line_number":257,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_8f48a7b4","line":255,"in_reply_to":"da86d52c_a0e66342","updated":"2015-02-17 14:39:10.000000000","message":"ok.","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"377652f91b8340747b1527e6208d3796c026df03","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            try:"},{"line_number":254,"context_line":"                _create_root_fs(tmpdir, files_info)"},{"line_number":255,"context_line":"            except (OSError, IOError) as e:"},{"line_number":256,"context_line":"                LOG.exception(_LE(\"Creating the filesystem root failed.\"))"},{"line_number":257,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            cfg \u003d _generate_isolinux_cfg(kernel_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_789de665","line":256,"updated":"2015-02-24 16:23:53.000000000","message":"ditto","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"9ebfdf553e37994a92addf20a5508938ff71ea54","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            try:"},{"line_number":254,"context_line":"                _create_root_fs(tmpdir, files_info)"},{"line_number":255,"context_line":"            except (OSError, IOError) as e:"},{"line_number":256,"context_line":"                LOG.exception(_LE(\"Creating the filesystem root failed.\"))"},{"line_number":257,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            cfg \u003d _generate_isolinux_cfg(kernel_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_6d6fe32b","line":256,"in_reply_to":"ba7be1f8_789de665","updated":"2015-02-24 17:43:36.000000000","message":"ditto","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"377652f91b8340747b1527e6208d3796c026df03","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                                  tmpdir)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":291,"context_line":"                LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":292,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b88afe18","line":291,"updated":"2015-02-24 16:23:53.000000000","message":"ditto","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"9ebfdf553e37994a92addf20a5508938ff71ea54","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                                  tmpdir)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":291,"context_line":"                LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":292,"context_line":"                raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_8d6c1737","line":291,"in_reply_to":"ba7be1f8_b88afe18","updated":"2015-02-24 17:43:36.000000000","message":"ditto","commit_id":"4f99b5b526dc4c215ceb5982ecbea4a664ee7921"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027grub_conf_template\u0027,"},{"line_number":52,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":53,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_20ddc242","line":53,"updated":"2015-02-26 09:46:29.000000000","message":"May be need to change the help string.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027grub_conf_template\u0027,"},{"line_number":52,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":53,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_26c9cf79","line":53,"in_reply_to":"ba7be1f8_20ddc242","updated":"2015-02-28 16:28:34.000000000","message":"yes","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"45b11bed158abbca9953ba09c2fcff7b69e2ff53","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    return cfg"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def _generate_grub_cfg(kernel_params):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if not kernel_params:"},{"line_number":175,"context_line":"        kernel_params \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_b7ebb976","line":172,"updated":"2015-02-25 15:28:59.000000000","message":"Please add docstring.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    return cfg"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def _generate_grub_cfg(kernel_params):"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if not kernel_params:"},{"line_number":175,"context_line":"        kernel_params \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_e6b7b7f3","line":172,"in_reply_to":"ba7be1f8_b7ebb976","updated":"2015-02-28 16:28:34.000000000","message":"yes.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"45b11bed158abbca9953ba09c2fcff7b69e2ff53","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":219,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":220,"context_line":"        # directory."},{"line_number":221,"context_line":"        uefi_path_info \u003d {}"},{"line_number":222,"context_line":"        efiboot_present \u003d True"},{"line_number":223,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso, tmpdir)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_122d73a8","line":221,"updated":"2015-02-25 15:28:59.000000000","message":"Line not needed.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":219,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":220,"context_line":"        # directory."},{"line_number":221,"context_line":"        uefi_path_info \u003d {}"},{"line_number":222,"context_line":"        efiboot_present \u003d True"},{"line_number":223,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso, tmpdir)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_c6b473f4","line":221,"in_reply_to":"ba7be1f8_122d73a8","updated":"2015-02-28 16:28:34.000000000","message":"yeah. will remove","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"45b11bed158abbca9953ba09c2fcff7b69e2ff53","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":220,"context_line":"        # directory."},{"line_number":221,"context_line":"        uefi_path_info \u003d {}"},{"line_number":222,"context_line":"        efiboot_present \u003d True"},{"line_number":223,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso, tmpdir)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        e_img_rel_path \u003d uefi_path_info[\u0027e_img_rel_path\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_d2b11b90","line":222,"updated":"2015-02-25 15:28:59.000000000","message":"Looks like this line not needed (l234 or 236).","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":220,"context_line":"        # directory."},{"line_number":221,"context_line":"        uefi_path_info \u003d {}"},{"line_number":222,"context_line":"        efiboot_present \u003d True"},{"line_number":223,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso, tmpdir)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        e_img_rel_path \u003d uefi_path_info[\u0027e_img_rel_path\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_a6bdbfd9","line":222,"in_reply_to":"ba7be1f8_d2b11b90","updated":"2015-02-28 16:28:34.000000000","message":"ok i will check and remove as needed.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        grub_path \u003d uefi_path_info[\u0027grub_path\u0027]"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # if either of these variables are not initialized then the"},{"line_number":231,"context_line":"        # the bios deploy is continued."},{"line_number":232,"context_line":"        if e_img_rel_path and e_abs_path and grub_rel_path and grub_path:"},{"line_number":233,"context_line":"            files_info[grub_path] \u003d grub_rel_path"},{"line_number":234,"context_line":"            efiboot_present \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_82bd72da","line":231,"updated":"2015-02-26 09:46:29.000000000","message":"Presence of these things do not mean bios or uefio deploy. It just indicates given image is uefi cum bios or just bios capable right?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        grub_path \u003d uefi_path_info[\u0027grub_path\u0027]"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # if either of these variables are not initialized then the"},{"line_number":231,"context_line":"        # the bios deploy is continued."},{"line_number":232,"context_line":"        if e_img_rel_path and e_abs_path and grub_rel_path and grub_path:"},{"line_number":233,"context_line":"            files_info[grub_path] \u003d grub_rel_path"},{"line_number":234,"context_line":"            efiboot_present \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_661587e4","line":231,"in_reply_to":"ba7be1f8_82bd72da","updated":"2015-02-28 16:28:34.000000000","message":"hmm Yes. correct","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            efiboot_present \u003d False"},{"line_number":237,"context_line":"            # unmount the temporary directory mounted with deploy iso."},{"line_number":238,"context_line":"            utils.umount(uefi_path_info[\u0027tmpdir1\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        try:"},{"line_number":241,"context_line":"            _create_root_fs(tmpdir, files_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_46856e05","line":238,"updated":"2015-02-26 09:46:29.000000000","message":"can the key name be better than \u0027tmpdir1\u0027?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            efiboot_present \u003d False"},{"line_number":237,"context_line":"            # unmount the temporary directory mounted with deploy iso."},{"line_number":238,"context_line":"            utils.umount(uefi_path_info[\u0027tmpdir1\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        try:"},{"line_number":241,"context_line":"            _create_root_fs(tmpdir, files_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_a6d69f25","line":238,"in_reply_to":"ba7be1f8_46856e05","updated":"2015-02-28 16:28:34.000000000","message":"ok.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                utils.umount(uefi_path_info[\u0027tmpdir1\u0027])"},{"line_number":270,"context_line":"            else:"},{"line_number":271,"context_line":"                # Fall back to bios mode."},{"line_number":272,"context_line":"                utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","},{"line_number":273,"context_line":"                              \u0027-cache-inodes\u0027, \u0027-J\u0027, \u0027-l\u0027, \u0027-no-emul-boot\u0027,"},{"line_number":274,"context_line":"                              \u0027-boot-load-size\u0027, \u00274\u0027, \u0027-boot-info-table\u0027,"},{"line_number":275,"context_line":"                              \u0027-b\u0027, ISOLINUX_BIN, \u0027-o\u0027, output_file,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_cbb5c57e","line":272,"updated":"2015-02-26 09:46:29.000000000","message":"Why we need to add  VMEDIA_BOOT_ISO here?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                utils.umount(uefi_path_info[\u0027tmpdir1\u0027])"},{"line_number":270,"context_line":"            else:"},{"line_number":271,"context_line":"                # Fall back to bios mode."},{"line_number":272,"context_line":"                utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","},{"line_number":273,"context_line":"                              \u0027-cache-inodes\u0027, \u0027-J\u0027, \u0027-l\u0027, \u0027-no-emul-boot\u0027,"},{"line_number":274,"context_line":"                              \u0027-boot-load-size\u0027, \u00274\u0027, \u0027-boot-info-table\u0027,"},{"line_number":275,"context_line":"                              \u0027-b\u0027, ISOLINUX_BIN, \u0027-o\u0027, output_file,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_06e76b13","line":272,"in_reply_to":"ba7be1f8_cbb5c57e","updated":"2015-02-28 16:28:34.000000000","message":"its the label name correct? and the deploy iso created using DIB has the label name as VMEDIA_BOOT_ISO. Shouldnt these be same?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    :param output_filename: the absolute path of the output ISO file"},{"line_number":417,"context_line":"    :param kernel_uuid: glance uuid of the kernel to use"},{"line_number":418,"context_line":"    :param ramdisk_uuid: glance uuid of the ramdisk to use"},{"line_number":419,"context_line":"    :param root_uuid: uuid of the root filesystem (optional)"},{"line_number":420,"context_line":"    :param kernel_params: a string containing whitespace separated values"},{"line_number":421,"context_line":"        kernel cmdline arguments of the form K\u003dV or K (optional)."},{"line_number":422,"context_line":"    :raises: ImageCreationFailed, if creating boot ISO failed."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_e0348afd","line":419,"updated":"2015-02-26 09:46:29.000000000","message":"Add docstring for deploy_iso_uuid","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    :param output_filename: the absolute path of the output ISO file"},{"line_number":417,"context_line":"    :param kernel_uuid: glance uuid of the kernel to use"},{"line_number":418,"context_line":"    :param ramdisk_uuid: glance uuid of the ramdisk to use"},{"line_number":419,"context_line":"    :param root_uuid: uuid of the root filesystem (optional)"},{"line_number":420,"context_line":"    :param kernel_params: a string containing whitespace separated values"},{"line_number":421,"context_line":"        kernel cmdline arguments of the form K\u003dV or K (optional)."},{"line_number":422,"context_line":"    :raises: ImageCreationFailed, if creating boot ISO failed."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_46f163cc","line":419,"in_reply_to":"ba7be1f8_e0348afd","updated":"2015-02-28 16:28:34.000000000","message":"yes. will add","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027isolinux_config_template\u0027,"},{"line_number":49,"context_line":"                default\u003dpaths.basedir_def(\u0027common/isolinux_config.template\u0027),"},{"line_number":50,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027grub_conf_template\u0027,"},{"line_number":52,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":53,"context_line":"                help\u003d\u0027Template file for grub configuration file.\u0027),"},{"line_number":54,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_0d276c65","line":51,"updated":"2015-03-12 12:16:06.000000000","message":"I think we did in isolinux (btw i did it), but this is never going to change and needn\u0027t be provided as a user-configurable option. we can simply hardcode it.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"067b006cca5a85b8ac0303db987c1bc772681f2a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt(\u0027isolinux_config_template\u0027,"},{"line_number":49,"context_line":"                default\u003dpaths.basedir_def(\u0027common/isolinux_config.template\u0027),"},{"line_number":50,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027grub_conf_template\u0027,"},{"line_number":52,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":53,"context_line":"                help\u003d\u0027Template file for grub configuration file.\u0027),"},{"line_number":54,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b42d6eaa","line":51,"in_reply_to":"9a80dd14_0d276c65","updated":"2015-03-14 00:18:21.000000000","message":"means?","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    return cfg"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def _generate_grub_cfg(kernel_params):"},{"line_number":173,"context_line":"    \"\"\"Generates a grub configuration file."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    Given a given a list of strings containing kernel parameters, this method"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_2de190fe","line":172,"updated":"2015-03-12 12:16:06.000000000","message":"This method is exactly same as _generate_isolinux_cfg except for the path of the file.  We can combine these two.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"067b006cca5a85b8ac0303db987c1bc772681f2a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    return cfg"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def _generate_grub_cfg(kernel_params):"},{"line_number":173,"context_line":"    \"\"\"Generates a grub configuration file."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    Given a given a list of strings containing kernel parameters, this method"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_34b5fe7d","line":172,"in_reply_to":"9a80dd14_2de190fe","updated":"2015-03-14 00:18:21.000000000","message":"yeah","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def create_isolinux_image_for_uefi(output_file, deploy_iso, kernel, ramdisk,"},{"line_number":249,"context_line":"                                   kernel_params\u003dNone):"},{"line_number":250,"context_line":"    \"\"\"Creates an isolinux image on the specified file."},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_ed92184a","line":248,"updated":"2015-03-12 12:16:06.000000000","message":"Again this method has copy-paste of contents of create_isolinux_image_for_bios.  For uefi, we are creating a bios + uefi image.  Most of the things in the above can be reused.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"067b006cca5a85b8ac0303db987c1bc772681f2a","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def create_isolinux_image_for_uefi(output_file, deploy_iso, kernel, ramdisk,"},{"line_number":249,"context_line":"                                   kernel_params\u003dNone):"},{"line_number":250,"context_line":"    \"\"\"Creates an isolinux image on the specified file."},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_f4336611","line":248,"in_reply_to":"9a80dd14_ed92184a","updated":"2015-03-14 00:18:21.000000000","message":"Actually the function is looking same mostly because of comment part. The code is not same much. I dont see a better way of splitting them.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                      CONF.isolinux_bin: ISOLINUX_BIN,"},{"line_number":275,"context_line":"                     }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":278,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":279,"context_line":"        # directory."},{"line_number":280,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_a8900e96","line":277,"updated":"2015-03-12 12:16:06.000000000","message":"i think this block would have been better if:\n\n    temp_dir \u003d tempfile.tempdir()\n    _mount_deploy_iso(deploy_iso, tempdir)\n\n    try:\n        uefi_files_info \u003d _get_uefi_files_info(tempdir)\n        files_info.update(uefi_files_info)\n        try:\n            _create_root_fs(tmpdir, files_info)\n        except (OSError, IOError) as e:\n            LOG.exception(_LE(\"Creating the filesystem root failed.\"))\t\n            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)\n\n   finally:\n        utils.umount(temp_dir)","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"067b006cca5a85b8ac0303db987c1bc772681f2a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                      CONF.isolinux_bin: ISOLINUX_BIN,"},{"line_number":275,"context_line":"                     }"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":278,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":279,"context_line":"        # directory."},{"line_number":280,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_747936c7","line":277,"in_reply_to":"9a80dd14_a8900e96","updated":"2015-03-14 00:18:21.000000000","message":"we cannot umount before copying efiboot.img else opening up of the deploy iso purpose is defeated","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":278,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":279,"context_line":"        # directory."},{"line_number":280,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        e_img_rel_path \u003d uefi_path_info[\u0027e_img_rel_path\u0027]"},{"line_number":283,"context_line":"        e_img_path \u003d uefi_path_info[\u0027e_img_path\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_ad010008","line":280,"updated":"2015-03-12 12:16:06.000000000","message":"as per my comment on line 542, if proper dict was returned, we could just do\n\n  files_info.update(uefi_files_info)","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c4dc86323233de3866552c2b5403b8978f9a8547","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":278,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":279,"context_line":"        # directory."},{"line_number":280,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        e_img_rel_path \u003d uefi_path_info[\u0027e_img_rel_path\u0027]"},{"line_number":283,"context_line":"        e_img_path \u003d uefi_path_info[\u0027e_img_path\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_d2474dba","line":280,"in_reply_to":"9a80dd14_ad010008","updated":"2015-03-16 05:46:40.000000000","message":"We dont need to update the complete returned information in files info. We just need efiboot.img to be copied to correct location using returned information. rest is just needed to create the boot iso using mkisofs.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"067b006cca5a85b8ac0303db987c1bc772681f2a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":278,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":279,"context_line":"        # directory."},{"line_number":280,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        e_img_rel_path \u003d uefi_path_info[\u0027e_img_rel_path\u0027]"},{"line_number":283,"context_line":"        e_img_path \u003d uefi_path_info[\u0027e_img_path\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_d47ae2b8","line":280,"in_reply_to":"9a80dd14_ad010008","updated":"2015-03-14 00:18:21.000000000","message":"we done need everything in files_info. only part of deploy iso","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c4dc86323233de3866552c2b5403b8978f9a8547","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        # Open the deploy iso used to initiate deploy and copy the"},{"line_number":278,"context_line":"        # efiboot.img i.e. boot loader to the current temporary"},{"line_number":279,"context_line":"        # directory."},{"line_number":280,"context_line":"        uefi_path_info \u003d _mount_deploy_iso(deploy_iso)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        e_img_rel_path \u003d uefi_path_info[\u0027e_img_rel_path\u0027]"},{"line_number":283,"context_line":"        e_img_path \u003d uefi_path_info[\u0027e_img_path\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_7237814d","line":280,"in_reply_to":"9a80dd14_d47ae2b8","updated":"2015-03-16 05:46:40.000000000","message":"s/done/dont","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fe601d7b5e348d5c5498e45574b77ccfa67d2d05","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                          \u0027-o\u0027, output_file, tmpdir)"},{"line_number":324,"context_line":"            # Unmount the temporary directory on which deploy iso was"},{"line_number":325,"context_line":"            # mounted."},{"line_number":326,"context_line":"            utils.umount(uefi_path_info[\u0027mountdir\u0027])"},{"line_number":327,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":328,"context_line":"            LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":329,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_cfdad5e8","line":326,"updated":"2015-03-11 16:24:11.000000000","message":"Please do mount/umount on the same level.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"33a9f0b99f2d2dfed418961ee5ad341b754bf577","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                          \u0027-o\u0027, output_file, tmpdir)"},{"line_number":324,"context_line":"            # Unmount the temporary directory on which deploy iso was"},{"line_number":325,"context_line":"            # mounted."},{"line_number":326,"context_line":"            utils.umount(uefi_path_info[\u0027mountdir\u0027])"},{"line_number":327,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":328,"context_line":"            LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":329,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_be44ed1b","line":326,"in_reply_to":"9a80dd14_352f408a","updated":"2015-03-11 17:45:11.000000000","message":"ok","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"6c7b70b3687a8831f39e5673c273e379da9304af","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                          \u0027-o\u0027, output_file, tmpdir)"},{"line_number":324,"context_line":"            # Unmount the temporary directory on which deploy iso was"},{"line_number":325,"context_line":"            # mounted."},{"line_number":326,"context_line":"            utils.umount(uefi_path_info[\u0027mountdir\u0027])"},{"line_number":327,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":328,"context_line":"            LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":329,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_352f408a","line":326,"in_reply_to":"9a80dd14_cfdad5e8","updated":"2015-03-11 16:46:06.000000000","message":"And if execute mkisofs fails umount will not started, use finally:","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"33a9f0b99f2d2dfed418961ee5ad341b754bf577","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                          \u0027-o\u0027, output_file, tmpdir)"},{"line_number":324,"context_line":"            # Unmount the temporary directory on which deploy iso was"},{"line_number":325,"context_line":"            # mounted."},{"line_number":326,"context_line":"            utils.umount(uefi_path_info[\u0027mountdir\u0027])"},{"line_number":327,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":328,"context_line":"            LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":329,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_3eb9dd15","line":326,"in_reply_to":"9a80dd14_cfdad5e8","updated":"2015-03-11 17:45:11.000000000","message":"It is not possible to do unmount at the previous level as the copy of the efiboot.img is present in the mountdir. After we copy the efiboot.img, to the present temporary directory, unmount for deploy_iso mount dir has to be done.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fe601d7b5e348d5c5498e45574b77ccfa67d2d05","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    e_img_path \u003d None"},{"line_number":517,"context_line":"    grub_rel_path \u003d None"},{"line_number":518,"context_line":"    grub_path \u003d None"},{"line_number":519,"context_line":"    with utils.tempdir() as mountdir:"},{"line_number":520,"context_line":"        try:"},{"line_number":521,"context_line":"            utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":522,"context_line":"            for (dir, subdir, files) in os.walk(mountdir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_af0f6187","line":519,"updated":"2015-03-11 16:24:11.000000000","message":"Context manager try to remove mountdir before umount.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"087947064ded2c1d22bba56764c5ebaba3c94dc4","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    e_img_path \u003d None"},{"line_number":517,"context_line":"    grub_rel_path \u003d None"},{"line_number":518,"context_line":"    grub_path \u003d None"},{"line_number":519,"context_line":"    with utils.tempdir() as mountdir:"},{"line_number":520,"context_line":"        try:"},{"line_number":521,"context_line":"            utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":522,"context_line":"            for (dir, subdir, files) in os.walk(mountdir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_5ebcd16c","line":519,"in_reply_to":"9a80dd14_3e155de5","updated":"2015-03-11 17:51:18.000000000","message":"https://github.com/openstack/ironic/blob/master/ironic/common/utils.py#L387 Yes, no umount. We try to remove mounted dir.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"067b006cca5a85b8ac0303db987c1bc772681f2a","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    e_img_path \u003d None"},{"line_number":517,"context_line":"    grub_rel_path \u003d None"},{"line_number":518,"context_line":"    grub_path \u003d None"},{"line_number":519,"context_line":"    with utils.tempdir() as mountdir:"},{"line_number":520,"context_line":"        try:"},{"line_number":521,"context_line":"            utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":522,"context_line":"            for (dir, subdir, files) in os.walk(mountdir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_dbae0e98","line":519,"in_reply_to":"9a80dd14_5ebcd16c","updated":"2015-03-14 00:18:21.000000000","message":"Yes, thats why i implemented one-inside one temp directories in patch set 4. But when i splitted it into further functions as per review comments, i had to move this function out of create_isolinux_image(). Even if it is tried to be removed it doesnt umount/remove the directory as the paths are still available to the caller function.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    e_img_path \u003d None"},{"line_number":517,"context_line":"    grub_rel_path \u003d None"},{"line_number":518,"context_line":"    grub_path \u003d None"},{"line_number":519,"context_line":"    with utils.tempdir() as mountdir:"},{"line_number":520,"context_line":"        try:"},{"line_number":521,"context_line":"            utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":522,"context_line":"            for (dir, subdir, files) in os.walk(mountdir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_add660ef","line":519,"in_reply_to":"9a80dd14_5ebcd16c","updated":"2015-03-12 12:16:06.000000000","message":"yeah, we need to umount before removing the dir. otherwise the mount entry in the kernel will remain.  i think the way it works now is it fails to remove the directory because it is mounted. \n\ni think the caller should pass the tempdir to this method to work on and then umount it.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"33a9f0b99f2d2dfed418961ee5ad341b754bf577","unresolved":false,"context_lines":[{"line_number":516,"context_line":"    e_img_path \u003d None"},{"line_number":517,"context_line":"    grub_rel_path \u003d None"},{"line_number":518,"context_line":"    grub_path \u003d None"},{"line_number":519,"context_line":"    with utils.tempdir() as mountdir:"},{"line_number":520,"context_line":"        try:"},{"line_number":521,"context_line":"            utils.mount(deploy_iso, mountdir, \u0027-o\u0027, \u0027loop\u0027)"},{"line_number":522,"context_line":"            for (dir, subdir, files) in os.walk(mountdir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_3e155de5","line":519,"in_reply_to":"9a80dd14_af0f6187","updated":"2015-03-11 17:45:11.000000000","message":"i didnt get comment here. There is no umount here.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"075feacf8d7ed534aab18ade4d15605cec642a42","unresolved":false,"context_lines":[{"line_number":539,"context_line":"                      \u0027grub_rel_path\u0027: grub_rel_path,"},{"line_number":540,"context_line":"                      \u0027grub_path\u0027: grub_path,"},{"line_number":541,"context_line":"                      \u0027mountdir\u0027: mountdir}"},{"line_number":542,"context_line":"    return uefi_path_info"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_ed34d8fc","line":542,"updated":"2015-03-12 12:16:06.000000000","message":"why don\u0027t we just return a dict like below so that we can directly do files_info.update(\u003cdict returned\u003e)\n\n  {\n     e_img_rel_path:  e_img_path,\n     grub_rel_path: grub_path\n  }","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c4dc86323233de3866552c2b5403b8978f9a8547","unresolved":false,"context_lines":[{"line_number":539,"context_line":"                      \u0027grub_rel_path\u0027: grub_rel_path,"},{"line_number":540,"context_line":"                      \u0027grub_path\u0027: grub_path,"},{"line_number":541,"context_line":"                      \u0027mountdir\u0027: mountdir}"},{"line_number":542,"context_line":"    return uefi_path_info"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_3e2dc1a8","line":542,"in_reply_to":"9a80dd14_ed34d8fc","updated":"2015-03-16 05:46:40.000000000","message":"it is not updated in files_info","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"03a7c8dccaeef104962524db26671e8f09ef71ea","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_9daeaa7f","line":290,"updated":"2015-03-16 10:43:58.000000000","message":"It looks like that if not exception occurs, we are not umounting the ISO","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"07f49bfd45c5b55be1cf8eeaa179d8dcdeb21bcf","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_e51d3fbf","line":290,"in_reply_to":"9a80dd14_59bb58c3","updated":"2015-03-16 16:27:02.000000000","message":"yes will just update the patch.","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b4ef2e4a4a7ee4ea76285f097a0fa13f4ec9a674","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_59bb58c3","line":290,"in_reply_to":"9a80dd14_93793b95","updated":"2015-03-16 15:31:52.000000000","message":"I agree here, I think it makes sense to unmount the ISO as Lucas pointed out to avoid the \"resource busy\" conflict.","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"109db5bef605d9ee6b30711cf056e113d6a62439","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_b897fc38","line":290,"in_reply_to":"9a80dd14_9daeaa7f","updated":"2015-03-16 11:15:59.000000000","message":"its done when \u0027with\u0027 block ends.","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4fc632843c65f7fe33fa58420f692b261c2d436c","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"},{"line_number":293,"context_line":"            utils.execute(\u0027mkisofs\u0027, \u0027-r\u0027, \u0027-V\u0027, \"VMEDIA_BOOT_ISO\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_93793b95","line":290,"in_reply_to":"9a80dd14_b897fc38","updated":"2015-03-16 11:31:26.000000000","message":"This [1] ?\n\nIt doesn\u0027t look like it\u0027s umounting the patch, it\u0027s trying to remove the temporary dir. So after running this code what you see when you do:\n\n # losetup -a\n\n?\n\nI think the ISO will still be associated with the loop device there. I\u0027m not even sure that we would be able to delete the contents on the filesystem due \"resource being busy\" if you try to delete the mount point with the ISO mounted.\n\nSo check in ur logs see if you can see some \"Could not remove tmpdir\" error logs from the utils.tempdir() trying to remove the directory where the ISO has being mounted.\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/common/utils.py#L379-L389","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"03a7c8dccaeef104962524db26671e8f09ef71ea","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    return is_whole_disk_image"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"def _mount_deploy_iso(deploy_iso, mountdir):"},{"line_number":508,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    :param: deploy_iso: path to the deploy iso where its"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_fd78862c","line":507,"updated":"2015-03-16 10:43:58.000000000","message":"Tip: To be safe about mount points, can we make this function use the contextmanager so we guarantee that we are going to [try] umount when it\u0027s finished?\n\nfor e.g\n\n from contextlib import contextmanager\n\n def _mount_deploy_iso(...):\n     ...\n     try:\n         utils.mount(...)\n     except:\n          ...\n     finally:\n         utils.umount(...)\n\n\nSo on functions like create_isolinux_image_for_uefi() you can do:\n\n with _mount_deploy_iso() as iso:\n      ...","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"109db5bef605d9ee6b30711cf056e113d6a62439","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    return is_whole_disk_image"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"def _mount_deploy_iso(deploy_iso, mountdir):"},{"line_number":508,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    :param: deploy_iso: path to the deploy iso where its"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_d8b110e1","line":507,"in_reply_to":"9a80dd14_fd78862c","updated":"2015-03-16 11:15:59.000000000","message":"we cannot do umount here because the same is needed in create_isolinux_image_for_uefi for copying efiboot.img. That is the whole purpose of mounting deploy iso. if we umount it here that very purpose is lost.","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"3ed37af8f630e9f672fef9b7fbc1519014423030","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                          \u0027-e\u0027, e_img_rel_path, \u0027-no-emul-boot\u0027,"},{"line_number":298,"context_line":"                          \u0027-o\u0027, output_file, tmpdir)"},{"line_number":299,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":300,"context_line":"            utils.umount(mountdir)"},{"line_number":301,"context_line":"            LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":302,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_d3a9d7de","line":300,"updated":"2015-03-16 19:51:04.000000000","message":"this unmount is unneeded will be handled with the finally.","commit_id":"d350b16616efddd47dbba7f83e259c3a4c3d8513"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fd9d32e1f61c68d741b453d224f028899df242de","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                          \u0027-e\u0027, e_img_rel_path, \u0027-no-emul-boot\u0027,"},{"line_number":298,"context_line":"                          \u0027-o\u0027, output_file, tmpdir)"},{"line_number":299,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":300,"context_line":"            utils.umount(mountdir)"},{"line_number":301,"context_line":"            LOG.exception(_LE(\"Creating ISO image failed.\"))"},{"line_number":302,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":303,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_69075c19","line":300,"in_reply_to":"9a80dd14_d3a9d7de","updated":"2015-03-18 19:33:52.000000000","message":"ok","commit_id":"d350b16616efddd47dbba7f83e259c3a4c3d8513"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29cfb5d5a45894154c50a9f5f8ba0a79bd9b280","unresolved":false,"context_lines":[{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"GRUB_CONF_TEMPLATE \u003d os.path.join(os.path.dirname(__file__),"},{"line_number":56,"context_line":"                                  \u0027grub_conf.template\u0027)"},{"line_number":57,"context_line":"CONF \u003d cfg.CONF"},{"line_number":58,"context_line":"CONF.register_opts(image_opts)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_e34ce978","line":55,"updated":"2015-03-18 15:34:43.000000000","message":"This creates dependency between this module path and grub_conf.template path, better to use paths.basedir_def().","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"759a51d817bd66d7deda423d1343253e60bb9059","unresolved":false,"context_lines":[{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"GRUB_CONF_TEMPLATE \u003d os.path.join(os.path.dirname(__file__),"},{"line_number":56,"context_line":"                                  \u0027grub_conf.template\u0027)"},{"line_number":57,"context_line":"CONF \u003d cfg.CONF"},{"line_number":58,"context_line":"CONF.register_opts(image_opts)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_6c1c616b","line":55,"in_reply_to":"9a80dd14_e34ce978","updated":"2015-03-18 17:18:31.000000000","message":"ok","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29cfb5d5a45894154c50a9f5f8ba0a79bd9b280","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_fe7b9cf1","line":289,"updated":"2015-03-18 15:34:43.000000000","message":"Writes l283 and l289 probably should be in try block above.","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2b0fba1631467406f19a5010e1d0ee7aff2d7bd8","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_cc39cda4","line":289,"in_reply_to":"9a80dd14_fe7b9cf1","updated":"2015-03-18 19:33:28.000000000","message":"but utils.write_to_file() doesnt raise any exception. hence it makes no sense to include it in try block.","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"759a51d817bd66d7deda423d1343253e60bb9059","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":287,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":288,"context_line":"                                  GRUB_CONF_TEMPLATE, grub_options)"},{"line_number":289,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # Create the boot_iso."},{"line_number":292,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_0c0cc53a","line":289,"in_reply_to":"9a80dd14_fe7b9cf1","updated":"2015-03-18 17:18:31.000000000","message":"ok","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29cfb5d5a45894154c50a9f5f8ba0a79bd9b280","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    # return the dictionary containing information required for creation of"},{"line_number":541,"context_line":"    # correct boot iso."},{"line_number":542,"context_line":"    uefi_path_info \u003d {e_img_path: e_img_rel_path,"},{"line_number":543,"context_line":"                      grub_path: grub_rel_path}"},{"line_number":544,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_be99247b","line":541,"updated":"2015-03-18 15:34:43.000000000","message":"Should we check also that \u0027efiboot.img\u0027 and \u0027grub.cfg\u0027 found (are not None)?","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"759a51d817bd66d7deda423d1343253e60bb9059","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003de)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    # return the dictionary containing information required for creation of"},{"line_number":541,"context_line":"    # correct boot iso."},{"line_number":542,"context_line":"    uefi_path_info \u003d {e_img_path: e_img_rel_path,"},{"line_number":543,"context_line":"                      grub_path: grub_rel_path}"},{"line_number":544,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_71927af7","line":541,"in_reply_to":"9a80dd14_be99247b","updated":"2015-03-18 17:18:31.000000000","message":"ok.","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29cfb5d5a45894154c50a9f5f8ba0a79bd9b280","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    # correct boot iso."},{"line_number":542,"context_line":"    uefi_path_info \u003d {e_img_path: e_img_rel_path,"},{"line_number":543,"context_line":"                      grub_path: grub_rel_path}"},{"line_number":544,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_031bbd80","line":544,"updated":"2015-03-18 15:34:43.000000000","message":"Why this function returns e_img_rel_path and grub_rel_path twice? (in the tuple and in the dict)?","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"759a51d817bd66d7deda423d1343253e60bb9059","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    # correct boot iso."},{"line_number":542,"context_line":"    uefi_path_info \u003d {e_img_path: e_img_rel_path,"},{"line_number":543,"context_line":"                      grub_path: grub_rel_path}"},{"line_number":544,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a80dd14_310ba22c","line":544,"in_reply_to":"9a80dd14_031bbd80","updated":"2015-03-18 17:18:31.000000000","message":"The dictionary is directly used for updating files_info in caller function see L271. The rest two values are required later for mkisofs and to place grub.cfg. If we put it in a dictionary to return them only once then it will become ugly as in previous patch set. Just to make the code look clean and simpler, i returned it as a tuple.","commit_id":"d08abe9ced7061780e6a015388c9acde46e7af0f"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6e3f6da51f98bb66160112ba5206290b17ccb268","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027grub_config_template\u0027,"},{"line_number":53,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":54,"context_line":"                help\u003d\u0027Template file for grub configuration file.\u0027),"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_bf9d94bd","line":54,"updated":"2015-03-18 19:19:01.000000000","message":"this changes requires a new new ironic.conf.sample file to be generated.","commit_id":"897e99c38163c61ef6769b4b8304e7f283bc2cd4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"65313cfeb7c40ca85c62c76861da53dd843081f7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                help\u003d\u0027Template file for isolinux configuration file.\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027grub_config_template\u0027,"},{"line_number":53,"context_line":"                default\u003dpaths.basedir_def(\u0027common/grub_conf.template\u0027),"},{"line_number":54,"context_line":"                help\u003d\u0027Template file for grub configuration file.\u0027),"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_bfbe7462","line":54,"in_reply_to":"9a80dd14_bf9d94bd","updated":"2015-03-18 19:34:04.000000000","message":"ohk","commit_id":"897e99c38163c61ef6769b4b8304e7f283bc2cd4"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"6e3f6da51f98bb66160112ba5206290b17ccb268","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":297,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":298,"context_line":"                                  CONF.grub_config_template, grub_options)"},{"line_number":299,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Create the boot_iso."},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_dc6c160b","line":299,"updated":"2015-03-18 19:19:01.000000000","message":"I don\u0027t the changes from Yuriy\u0027s comment on patch set 11?","commit_id":"897e99c38163c61ef6769b4b8304e7f283bc2cd4"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"65313cfeb7c40ca85c62c76861da53dd843081f7","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        grub_cfg \u003d os.path.join(tmpdir, grub_rel_path)"},{"line_number":297,"context_line":"        grub_conf \u003d _generate_cfg(kernel_params,"},{"line_number":298,"context_line":"                                  CONF.grub_config_template, grub_options)"},{"line_number":299,"context_line":"        utils.write_to_file(grub_cfg, grub_conf)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Create the boot_iso."},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_5fe498ab","line":299,"in_reply_to":"9a80dd14_dc6c160b","updated":"2015-03-18 19:34:04.000000000","message":"write_to_files doesnt raise any error, hence i havent put this under try block.","commit_id":"897e99c38163c61ef6769b4b8304e7f283bc2cd4"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"72c8f505f5da06141953ca7bbac4fd55683f0a5e","unresolved":false,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    uefi_path_info \u003d {e_img_path: e_img_rel_path,"},{"line_number":564,"context_line":"                      grub_path: grub_rel_path}"},{"line_number":565,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_f0d3bbd2","line":565,"updated":"2015-03-18 20:47:14.000000000","message":"would be good to include the reply to yuriy on patch set 11 here as a # NOTE:","commit_id":"7f026c88d05ccdc83364a08f534f9c1cd39394e3"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c70d6a134b050547771c6bc723767b51114706c7","unresolved":false,"context_lines":[{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    uefi_path_info \u003d {e_img_path: e_img_rel_path,"},{"line_number":564,"context_line":"                      grub_path: grub_rel_path}"},{"line_number":565,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_40f59481","line":565,"in_reply_to":"9a80dd14_f0d3bbd2","updated":"2015-03-18 22:31:50.000000000","message":"ok","commit_id":"7f026c88d05ccdc83364a08f534f9c1cd39394e3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def create_isolinux_image_for_uefi(output_file, deploy_iso, kernel, ramdisk,"},{"line_number":238,"context_line":"                                   kernel_params\u003dNone):"},{"line_number":239,"context_line":"    \"\"\"Creates an isolinux image on the specified file."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    Copies the provided kernel, ramdisk, efiboot.img to a directory, creates"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_5531ab57","line":238,"updated":"2015-03-19 16:15:31.000000000","message":"I feel like there is quite a lot of commonality between this and create_isolinix_image_for_bios() above. Maybe an exercise for someone to clean up later.","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    :param deploy_iso: deploy iso used to initiate the deploy."},{"line_number":250,"context_line":"    :param kernel: the kernel to use."},{"line_number":251,"context_line":"    :param ramdisk: the ramdisk to use."},{"line_number":252,"context_line":"    :param kernel_params: a list of strings(each element being a string like"},{"line_number":253,"context_line":"        \u0027K\u003dV\u0027 or \u0027K\u0027 or combination of them like \u0027K1\u003dV1,K2,...\u0027) to be added"},{"line_number":254,"context_line":"        as the kernel cmdline."},{"line_number":255,"context_line":"    :raises: ImageCreationFailed, if image creation failed while copying files"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_5fb2aa96","line":252,"updated":"2015-03-19 16:15:31.000000000","message":"I suspect this was a copy/paste. s/strings(each/strings (each/","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    \"\"\"This function opens up the deploy iso used for deploy."},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    :param: deploy_iso: path to the deploy iso where its"},{"line_number":523,"context_line":"                        contents are fetched to."},{"line_number":524,"context_line":"    :raises: ImageCreationFailed if mount fails."},{"line_number":525,"context_line":"    :returns: a tuple consisting of - 1. a dictionary containing"},{"line_number":526,"context_line":"                                         the values as required"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_d26771b6","line":523,"updated":"2015-03-19 16:15:31.000000000","message":":param: mountdir?","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":526,"context_line":"                                         the values as required"},{"line_number":527,"context_line":"                                         by create_isolinux_image,"},{"line_number":528,"context_line":"                                      2. efiboot.img relative path, and"},{"line_number":529,"context_line":"                                      3. grub.cfg relative path."},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    \"\"\""},{"line_number":532,"context_line":"    e_img_rel_path \u003d None"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_72b5e5eb","line":529,"updated":"2015-03-19 16:15:31.000000000","message":"relative to mountdir, right?","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":549,"context_line":"            if \u0027grub.cfg\u0027 in files:"},{"line_number":550,"context_line":"                grub_path \u003d os.path.join(dir, \u0027grub.cfg\u0027)"},{"line_number":551,"context_line":"                grub_rel_path \u003d os.path.relpath(grub_path,"},{"line_number":552,"context_line":"                                                mountdir)"},{"line_number":553,"context_line":"    except (OSError, IOError) as e:"},{"line_number":554,"context_line":"        LOG.exception(_LE(\"examining the deploy iso failed.\"))"},{"line_number":555,"context_line":"        _umount_without_raise(mountdir)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_52e381d7","line":552,"updated":"2015-03-19 16:15:31.000000000","message":"I suppose once you find these two, you can exit the for loop, but not a big deal.","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    # check if the variables are assigned some values or not during"},{"line_number":559,"context_line":"    # walk of the mountdir."},{"line_number":560,"context_line":"    if not (e_img_path and e_img_rel_path and grub_path and grub_rel_path):"},{"line_number":561,"context_line":"        error \u003d (_(\"Deploy iso didn\u0027t contain efiboot.img or grub.cfg\"))"},{"line_number":562,"context_line":"        _umount_without_raise(mountdir)"},{"line_number":563,"context_line":"        raise exception.ImageCreationFailed(image_type\u003d\u0027iso\u0027, error\u003derror)"},{"line_number":564,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_d2721111","line":561,"updated":"2015-03-19 16:15:31.000000000","message":"Might be useful to be more specific about which ones are missing. But this might be good enough.","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d003d500d77379a815905d186163b2191b77f5","unresolved":false,"context_lines":[{"line_number":572,"context_line":"    # generate_cfg() to the same directory path structure where it was"},{"line_number":573,"context_line":"    # present in deploy iso. This path varies for different OS vendors."},{"line_number":574,"context_line":"    # e_img_rel_path: is required by mkisofs to generate boot iso."},{"line_number":575,"context_line":"    return uefi_path_info, e_img_rel_path, grub_rel_path"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_d5ed9bb9","line":575,"updated":"2015-03-19 16:15:31.000000000","message":"I\u0027d actually have preferred if you returned a tuple of 4, eg e_img_patch, e_img_rel_path, grub_path, grub_rel_patch, and generated the uefi_path_info dict where it is actually needed. This seems a bit messy -- you\u0027re returning stuff based on how the info is going to be used. To me, these return values don\u0027t make sense.","commit_id":"1bdafaabb30b54ca955b74ff31915dbd4271f34f"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return \u0027glance:%s\u0027 % boot_iso_uuid"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # NOTE(faizan) For uefi boot_mode, operator should provide efi capable"},{"line_number":108,"context_line":"    # boot-iso in glance"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if not kernel_uuid or not ramdisk_uuid:"},{"line_number":111,"context_line":"        LOG.error(_LE(\"Unable to find \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 in Glance \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_490ca13b","line":108,"updated":"2015-02-26 09:46:29.000000000","message":"Is this note still relevant?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return \u0027glance:%s\u0027 % boot_iso_uuid"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # NOTE(faizan) For uefi boot_mode, operator should provide efi capable"},{"line_number":108,"context_line":"    # boot-iso in glance"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if not kernel_uuid or not ramdisk_uuid:"},{"line_number":111,"context_line":"        LOG.error(_LE(\"Unable to find \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 in Glance \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_66c3c757","line":108,"in_reply_to":"ba7be1f8_490ca13b","updated":"2015-02-28 16:28:34.000000000","message":"no will remove.","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"fe601d7b5e348d5c5498e45574b77ccfa67d2d05","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ramdisk_href \u003d (task.node.instance_info.get(\u0027ramdisk\u0027) or"},{"line_number":130,"context_line":"                    image_properties.get(\u0027ramdisk_id\u0027))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    deploy_iso_uuid \u003d deploy_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":133,"context_line":"    if boot_iso_uuid:"},{"line_number":134,"context_line":"        LOG.debug(\"Found boot_iso %s in Glance\", boot_iso_uuid)"},{"line_number":135,"context_line":"        return boot_iso_uuid"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_8880d88c","line":132,"updated":"2015-03-11 16:24:11.000000000","message":"IMO better move this line under Option 3.","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"33a9f0b99f2d2dfed418961ee5ad341b754bf577","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    ramdisk_href \u003d (task.node.instance_info.get(\u0027ramdisk\u0027) or"},{"line_number":130,"context_line":"                    image_properties.get(\u0027ramdisk_id\u0027))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    deploy_iso_uuid \u003d deploy_info[\u0027ilo_deploy_iso\u0027]"},{"line_number":133,"context_line":"    if boot_iso_uuid:"},{"line_number":134,"context_line":"        LOG.debug(\"Found boot_iso %s in Glance\", boot_iso_uuid)"},{"line_number":135,"context_line":"        return boot_iso_uuid"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_de944146","line":132,"in_reply_to":"9a80dd14_8880d88c","updated":"2015-03-11 17:45:11.000000000","message":"ok","commit_id":"d00fc151145a6ff7b628eb980ff576e84e195f2c"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                         \u0027kernel_id\u0027: None,"},{"line_number":88,"context_line":"                                         \u0027ramdisk_id\u0027: None}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":91,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":92,"context_line":"            boot_iso_result \u003d ilo_deploy._get_boot_iso(task, \u0027root-uuid\u0027)"},{"line_number":93,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_89493933","line":90,"updated":"2015-02-26 09:46:29.000000000","message":"Why is boot_mode is removed in this testcase?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                         \u0027kernel_id\u0027: None,"},{"line_number":88,"context_line":"                                         \u0027ramdisk_id\u0027: None}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":91,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":92,"context_line":"            boot_iso_result \u003d ilo_deploy._get_boot_iso(task, \u0027root-uuid\u0027)"},{"line_number":93,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_2690ef4d","line":90,"in_reply_to":"ba7be1f8_89493933","updated":"2015-02-28 16:28:34.000000000","message":"it was not there when test cases were enhanced/modified. may be some patch has gone in. this patch is shown in merge conflict so may be these are added in those patches","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b961fbb2fca04f0258b0c773190d95e1446ec9f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                  create_boot_iso_mock, tempfile_mock):"},{"line_number":108,"context_line":"        CONF.keystone_authtoken.auth_uri \u003d \u0027http://authurl\u0027"},{"line_number":109,"context_line":"        CONF.ilo.swift_ilo_container \u003d \u0027ilo-cont\u0027"},{"line_number":110,"context_line":"        CONF.pxe.pxe_append_params \u003d \u0027boot_method\u003dvmedia\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        swift_obj_mock \u003d swift_api_mock.return_value"},{"line_number":113,"context_line":"        fileobj_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_a2e356d7","line":110,"updated":"2015-02-26 09:46:29.000000000","message":"Why do we need the boot_method\u003dvmedia for pxe ?","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2ff39cd9ebfd2ebcad4d2f853e2b1c1bbc15af48","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                  create_boot_iso_mock, tempfile_mock):"},{"line_number":108,"context_line":"        CONF.keystone_authtoken.auth_uri \u003d \u0027http://authurl\u0027"},{"line_number":109,"context_line":"        CONF.ilo.swift_ilo_container \u003d \u0027ilo-cont\u0027"},{"line_number":110,"context_line":"        CONF.pxe.pxe_append_params \u003d \u0027boot_method\u003dvmedia\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        swift_obj_mock \u003d swift_api_mock.return_value"},{"line_number":113,"context_line":"        fileobj_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_c6ab9387","line":110,"in_reply_to":"ba7be1f8_a2e356d7","updated":"2015-02-28 16:28:34.000000000","message":"i will change it","commit_id":"79c472c88223bcaefa4ba236ea093ac447339d45"}],"ironic/tests/test_images.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"03a7c8dccaeef104962524db26671e8f09ef71ea","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_create_isolinux_image_for_uefi(self, gen_cfg_mock,"},{"line_number":468,"context_line":"                                   tempdir_mock, mount_mock, execute_mock,"},{"line_number":469,"context_line":"                                   write_to_file_mock,"},{"line_number":470,"context_line":"                                   create_root_fs_mock, umount_mock):"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        files_info \u003d {"},{"line_number":473,"context_line":"                \u0027path/to/kernel\u0027: \u0027vmlinuz\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_1d471abd","line":470,"updated":"2015-03-16 10:43:58.000000000","message":"umount_mock is not being tested whether it\u0027s being called or not, I think it\u0027s important to us to make sure we are umounting it","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"109db5bef605d9ee6b30711cf056e113d6a62439","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_create_isolinux_image_for_uefi(self, gen_cfg_mock,"},{"line_number":468,"context_line":"                                   tempdir_mock, mount_mock, execute_mock,"},{"line_number":469,"context_line":"                                   write_to_file_mock,"},{"line_number":470,"context_line":"                                   create_root_fs_mock, umount_mock):"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        files_info \u003d {"},{"line_number":473,"context_line":"                \u0027path/to/kernel\u0027: \u0027vmlinuz\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_78df440d","line":470,"in_reply_to":"9a80dd14_1d471abd","updated":"2015-03-16 11:15:59.000000000","message":"thats the part of \u0027with\u0027 block in code i.e. utils.tempdir.","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4fc632843c65f7fe33fa58420f692b261c2d436c","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_create_isolinux_image_for_uefi(self, gen_cfg_mock,"},{"line_number":468,"context_line":"                                   tempdir_mock, mount_mock, execute_mock,"},{"line_number":469,"context_line":"                                   write_to_file_mock,"},{"line_number":470,"context_line":"                                   create_root_fs_mock, umount_mock):"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        files_info \u003d {"},{"line_number":473,"context_line":"                \u0027path/to/kernel\u0027: \u0027vmlinuz\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_b37abf74","line":470,"in_reply_to":"9a80dd14_78df440d","updated":"2015-03-16 11:31:26.000000000","message":"Right, following the comment on images.py. I don\u0027t see this happen on utils.tempdir()[1].\n\nThat\u0027s why we should check if the mock has being called.\n\numount_mock.assert_called_once_with() at the end of the process to make sure umounting is being called.\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/common/utils.py#L379-L389","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"07f49bfd45c5b55be1cf8eeaa179d8dcdeb21bcf","unresolved":false,"context_lines":[{"line_number":467,"context_line":"    def test_create_isolinux_image_for_uefi(self, gen_cfg_mock,"},{"line_number":468,"context_line":"                                   tempdir_mock, mount_mock, execute_mock,"},{"line_number":469,"context_line":"                                   write_to_file_mock,"},{"line_number":470,"context_line":"                                   create_root_fs_mock, umount_mock):"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        files_info \u003d {"},{"line_number":473,"context_line":"                \u0027path/to/kernel\u0027: \u0027vmlinuz\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_e5745fff","line":470,"in_reply_to":"9a80dd14_b37abf74","updated":"2015-03-16 16:27:02.000000000","message":"ok","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"379c369e84bc8b00c354dd35d32c7b039af2a518","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        mock_file_handle \u003d mock.MagicMock(spec\u003dfile)"},{"line_number":497,"context_line":"        mock_file_handle.__enter__.return_value \u003d \u0027tmpdir\u0027"},{"line_number":498,"context_line":"        mock_file_handle1 \u003d mock.MagicMock(spec\u003dfile)"},{"line_number":499,"context_line":"        mock_file_handle1.__enter__.return_value \u003d \u0027mountdir\u0027"},{"line_number":500,"context_line":"        tempdir_mock.side_effect \u003d [mock_file_handle,"},{"line_number":501,"context_line":"                                    mock_file_handle1]"},{"line_number":502,"context_line":"        mount_mock.return_value \u003d (uefi_path_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_bd5b6e84","line":499,"updated":"2015-03-16 10:46:17.000000000","message":"Btw, for files we better use mock_open()[1]\n\nmock_open(read_data\u003d\u0027mountdir\u0027)\n\n\n[1] http://mock.readthedocs.org/en/latest/helpers.html#mock-open","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"109db5bef605d9ee6b30711cf056e113d6a62439","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        mock_file_handle \u003d mock.MagicMock(spec\u003dfile)"},{"line_number":497,"context_line":"        mock_file_handle.__enter__.return_value \u003d \u0027tmpdir\u0027"},{"line_number":498,"context_line":"        mock_file_handle1 \u003d mock.MagicMock(spec\u003dfile)"},{"line_number":499,"context_line":"        mock_file_handle1.__enter__.return_value \u003d \u0027mountdir\u0027"},{"line_number":500,"context_line":"        tempdir_mock.side_effect \u003d [mock_file_handle,"},{"line_number":501,"context_line":"                                    mock_file_handle1]"},{"line_number":502,"context_line":"        mount_mock.return_value \u003d (uefi_path_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_381eacbb","line":499,"in_reply_to":"9a80dd14_bd5b6e84","updated":"2015-03-16 11:15:59.000000000","message":"but these are temp directories. could you elaborate more what is teh expectation from comment.","commit_id":"fc52c53eee846dcf0fbae5b39e9092d7f326493a"}]}
