)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e50cf4bba38baec20ff353daa5b5e5d729d71825","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chris Krelle \u003cnobodycam@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-24 14:32:52 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Root partition should be marked as bootable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instance are booted with \u0027boot_option\u0027 as \u0027local\u0027, Ironic"},{"line_number":10,"context_line":"installs boot loader (that is present within the image) and then"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_d46688ec","line":7,"updated":"2015-02-24 23:17:47.000000000","message":"Is this patch set doing more than just this now?","commit_id":"1ac229796b83934cca5e177a527df459826f30cc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15153e6cd22586180132eb8531a4a99c577b7fcd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chris Krelle \u003cnobodycam@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-24 14:32:52 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Root partition should be marked as bootable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instance are booted with \u0027boot_option\u0027 as \u0027local\u0027, Ironic"},{"line_number":10,"context_line":"installs boot loader (that is present within the image) and then"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_ea69dc8c","line":7,"in_reply_to":"ba7be1f8_d46688ec","updated":"2015-02-25 08:50:06.000000000","message":"It\u0027s just doing that much only.  It is doing this only for localboot.","commit_id":"1ac229796b83934cca5e177a527df459826f30cc"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"97c456139de99b61de48c4c6ecd684679e4ed588","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # partition until the end of the disk."},{"line_number":230,"context_line":"    LOG.debug(\"Add root partition (%(size)d MB) to device: %(dev)s\","},{"line_number":231,"context_line":"             {\u0027dev\u0027: dev, \u0027size\u0027: root_mb})"},{"line_number":232,"context_line":"    part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":233,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_51636d19","line":232,"updated":"2015-02-18 23:43:25.000000000","message":"this is getting set for all root partitions even if the node is pxe booted, this COULD lead to a case where the BIOS \"falls back\" to attempt a local disk boot. So I would like to see this set only for nodes that need local boot.","commit_id":"ee449d9861454c5950ffa244a4e3402516678db7"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"82d681a77d8019b11208cbb33fda5a593fc80f23","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # partition until the end of the disk."},{"line_number":230,"context_line":"    LOG.debug(\"Add root partition (%(size)d MB) to device: %(dev)s\","},{"line_number":231,"context_line":"             {\u0027dev\u0027: dev, \u0027size\u0027: root_mb})"},{"line_number":232,"context_line":"    part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":233,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c76f9a26","line":232,"in_reply_to":"da86d52c_51636d19","updated":"2015-02-19 01:53:58.000000000","message":"* Setting the bootable flag is just actually setting a byte in the partition table entry in MBR (http://en.wikipedia.org/wiki/Master_boot_record#Partition_table_entries)\n\n* Not all BIOS honour this - Lucas tested this on VMs and Dmitry tested on some bare metal where without this fix, the BIOS actually booted from the disk for localboot. So even if we don\u0027t set the root partition as bootable in netboot, still some hardware can boot from the disk if they managed to install a bootloader.\n\n* Even in a BIOS fallback on failing to do PXE boot, the system doesn\u0027t boot until a boot loader is installed and configured.  Again this requires somebody to install the boot loader, so they might set this entry as well.\n\nMore than all this, the value of boot_option needs to be passed down from deploy() -\u003e work_on_disk() -\u003e make_partitions().  Considering the above 3 points, I am of the opinion that it\u0027s not worth that overhead to set this only for localboot.","commit_id":"ee449d9861454c5950ffa244a4e3402516678db7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f3d12086cba0b4d7acda3cfcd2190a5478454426","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # partition until the end of the disk."},{"line_number":230,"context_line":"    LOG.debug(\"Add root partition (%(size)d MB) to device: %(dev)s\","},{"line_number":231,"context_line":"             {\u0027dev\u0027: dev, \u0027size\u0027: root_mb})"},{"line_number":232,"context_line":"    part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":233,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_d94bf6ae","line":232,"in_reply_to":"da86d52c_c76f9a26","updated":"2015-02-19 09:51:12.000000000","message":"Yeah, I think I\u0027m good with that because before we make the partitions we always clean up the beginning of the disk getting rid of the bootloader, so it won\u0027t boot anyway.","commit_id":"ee449d9861454c5950ffa244a4e3402516678db7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"cdf89d3775936bcac79b2e754f7aa97890073036","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # partition until the end of the disk."},{"line_number":230,"context_line":"    LOG.debug(\"Add root partition (%(size)d MB) to device: %(dev)s\","},{"line_number":231,"context_line":"             {\u0027dev\u0027: dev, \u0027size\u0027: root_mb})"},{"line_number":232,"context_line":"    part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":233,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e989acca","line":232,"in_reply_to":"da86d52c_d94bf6ae","updated":"2015-02-19 20:50:41.000000000","message":"My concern is not with actually booting from the disk, but attempting to and failing, leaving the node stuck, rather than repeatedly trying to PXE. Maybe it isn\u0027t worth it, but I think it\u0027s valuable to have a node try to PXE forever if the control plane is down, rather than dying by failure to find a bootloader.","commit_id":"ee449d9861454c5950ffa244a4e3402516678db7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c7c9091ed13dd09cfd4ddfb5f12d62d748e2810b","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    # partition until the end of the disk."},{"line_number":230,"context_line":"    LOG.debug(\"Add root partition (%(size)d MB) to device: %(dev)s\","},{"line_number":231,"context_line":"             {\u0027dev\u0027: dev, \u0027size\u0027: root_mb})"},{"line_number":232,"context_line":"    part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":233,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6e52f914","line":232,"in_reply_to":"da86d52c_e989acca","updated":"2015-02-20 11:17:00.000000000","message":"Jim, that will only happens if the node is set to boot from local disk right? If the boot device says to boot from network it won\u0027t try to boot from disk, unless it has a sort of weird fallback mechanism in the BIOS, but even if that\u0027s the case having the bootable flag set or not doesn\u0027t seem to be the cause of getting a node stuck trying to boot from disk.\n\nBut that said, let\u0027s mark the partition as bootable it only if local boot is set, I think it\u0027s slightly more correct too and sounds more safe across different hardwares.","commit_id":"ee449d9861454c5950ffa244a4e3402516678db7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7d0af15b700fad2acdeaa81dcee04e8965ec8eeb","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    if boot_option \u003d\u003d \"local\":"},{"line_number":234,"context_line":"        part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":235,"context_line":"    else:"},{"line_number":236,"context_line":"        part_num \u003d dp.add_partition(root_mb)"},{"line_number":237,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_28733281","line":236,"updated":"2015-02-24 09:10:11.000000000","message":"nit:\n\n part_num \u003d dp.add_partition(root_mb, bootable\u003d(boot_option \u003d\u003d \"local\"))","commit_id":"a9f3bc35f8fb3a670e637681d1cf4607f6bc54bf"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ccb9dd8e9919d4d0a67d4e0c38a8518aa636d0fd","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    if boot_option \u003d\u003d \"local\":"},{"line_number":234,"context_line":"        part_num \u003d dp.add_partition(root_mb, bootable\u003dTrue)"},{"line_number":235,"context_line":"    else:"},{"line_number":236,"context_line":"        part_num \u003d dp.add_partition(root_mb)"},{"line_number":237,"context_line":"    part_dict[\u0027root\u0027] \u003d part_template % part_num"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    if commit:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_ea747cff","line":236,"in_reply_to":"ba7be1f8_28733281","updated":"2015-02-25 08:49:57.000000000","message":"Done","commit_id":"a9f3bc35f8fb3a670e637681d1cf4607f6bc54bf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7d0af15b700fad2acdeaa81dcee04e8965ec8eeb","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        partition table has not changed)."},{"line_number":575,"context_line":"    :param configdrive: Optional. Base64 encoded Gzipped configdrive content"},{"line_number":576,"context_line":"                        or configdrive HTTP URL."},{"line_number":577,"context_line":"    :param boot_option: Can be \"local\" or \"netboot\". \"netboot\" by default."},{"line_number":578,"context_line":"    :returns: the UUID of the root partition."},{"line_number":579,"context_line":"    \"\"\""},{"line_number":580,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_082bce30","line":577,"updated":"2015-02-24 09:10:11.000000000","message":"nit: would be a bit easier to pass in local_boot\u003dtrue/false","commit_id":"a9f3bc35f8fb3a670e637681d1cf4607f6bc54bf"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ccb9dd8e9919d4d0a67d4e0c38a8518aa636d0fd","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        partition table has not changed)."},{"line_number":575,"context_line":"    :param configdrive: Optional. Base64 encoded Gzipped configdrive content"},{"line_number":576,"context_line":"                        or configdrive HTTP URL."},{"line_number":577,"context_line":"    :param boot_option: Can be \"local\" or \"netboot\". \"netboot\" by default."},{"line_number":578,"context_line":"    :returns: the UUID of the root partition."},{"line_number":579,"context_line":"    \"\"\""},{"line_number":580,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_ca6b381c","line":577,"in_reply_to":"ba7be1f8_082bce30","updated":"2015-02-25 08:49:57.000000000","message":"will keep this as boot_option as boot_option is used everywhere and don\u0027t know if some day later a new boot_option will be added.","commit_id":"a9f3bc35f8fb3a670e637681d1cf4607f6bc54bf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"97d0b146691bfadb136dacb4e25d1c2b5c6c232a","unresolved":false,"context_lines":[{"line_number":551,"context_line":"def deploy(address, port, iqn, lun, image_path,"},{"line_number":552,"context_line":"           root_mb, swap_mb, ephemeral_mb, ephemeral_format, node_uuid,"},{"line_number":553,"context_line":"           preserve_ephemeral\u003dFalse, configdrive\u003dNone,"},{"line_number":554,"context_line":"           boot_option\u003d\"netboot\"):"},{"line_number":555,"context_line":"    \"\"\"All-in-one function to deploy a node."},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    :param address: The iSCSI IP address."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_e07e5bae","line":554,"updated":"2015-02-25 09:48:02.000000000","message":"(Just a thought, nothing to be done here)\n\nI would say that it would be better to give this function the \"task\" or \"node\" object, every time we add something new that has to do with the deploy we pass very specific options to this function, like config_drive, preserve_ephemeral, node_uuid (and this one is just for logs!).\n\nHaving the \"task\" or \"node\" object would be much easier to extend it with additional future work \u003d\u003d less re factoring everything a new option is added.","commit_id":"dedb425770a6f91a54e990159843ac201dc2f1a5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"88d6fc6ba7efb22bade8eccb5004feddbc6c2568","unresolved":false,"context_lines":[{"line_number":551,"context_line":"def deploy(address, port, iqn, lun, image_path,"},{"line_number":552,"context_line":"           root_mb, swap_mb, ephemeral_mb, ephemeral_format, node_uuid,"},{"line_number":553,"context_line":"           preserve_ephemeral\u003dFalse, configdrive\u003dNone,"},{"line_number":554,"context_line":"           boot_option\u003d\"netboot\"):"},{"line_number":555,"context_line":"    \"\"\"All-in-one function to deploy a node."},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    :param address: The iSCSI IP address."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_0628e8e0","line":554,"in_reply_to":"ba7be1f8_e07e5bae","updated":"2015-02-25 10:08:01.000000000","message":"There is already work going on to separate portion of deploy_utils into a separate module. https://review.openstack.org/#/c/157636/\n\nIf we pass in node object or task object, it might affect the code after it is separated into a common shared library.  I think it\u0027s better if common shared library accepts these separate kwargs.","commit_id":"dedb425770a6f91a54e990159843ac201dc2f1a5"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e50cf4bba38baec20ff353daa5b5e5d729d71825","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                dev, root_mb, swap_mb, ephemeral_mb, configdrive_mb,"},{"line_number":196,"context_line":"                commit\u003dTrue, boot_option\u003dboot_option))"},{"line_number":197,"context_line":"        else:"},{"line_number":198,"context_line":"            # If no boot_option, the it should default to netboot."},{"line_number":199,"context_line":"            calls_expected.append(mock.call.make_partitions("},{"line_number":200,"context_line":"                dev, root_mb, swap_mb, ephemeral_mb, configdrive_mb,"},{"line_number":201,"context_line":"                commit\u003dTrue, boot_option\u003d\"netboot\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b6567b28","line":198,"updated":"2015-02-24 23:17:47.000000000","message":"nit: s/the it/then it/","commit_id":"1ac229796b83934cca5e177a527df459826f30cc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"15153e6cd22586180132eb8531a4a99c577b7fcd","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                dev, root_mb, swap_mb, ephemeral_mb, configdrive_mb,"},{"line_number":196,"context_line":"                commit\u003dTrue, boot_option\u003dboot_option))"},{"line_number":197,"context_line":"        else:"},{"line_number":198,"context_line":"            # If no boot_option, the it should default to netboot."},{"line_number":199,"context_line":"            calls_expected.append(mock.call.make_partitions("},{"line_number":200,"context_line":"                dev, root_mb, swap_mb, ephemeral_mb, configdrive_mb,"},{"line_number":201,"context_line":"                commit\u003dTrue, boot_option\u003d\"netboot\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_2a0774cb","line":198,"in_reply_to":"ba7be1f8_b6567b28","updated":"2015-02-25 08:50:06.000000000","message":"Done","commit_id":"1ac229796b83934cca5e177a527df459826f30cc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"97d0b146691bfadb136dacb4e25d1c2b5c6c232a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            parent_mock.attach_mock(mocker, name)"},{"line_number":154,"context_line":"        return parent_mock"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _test_deploy(self, boot_option\u003dNone):"},{"line_number":157,"context_line":"        \"\"\"Check loosely all functions are called with right args.\"\"\""},{"line_number":158,"context_line":"        address \u003d \u0027127.0.0.1\u0027"},{"line_number":159,"context_line":"        port \u003d 3306"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_600a6b7a","line":156,"updated":"2015-02-25 09:48:02.000000000","message":"Mostly a nit but, you could just give this guy the default value of \"netboot\" so you wouldn\u0027t need that \"if boot_option\" conditional on L193","commit_id":"dedb425770a6f91a54e990159843ac201dc2f1a5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"88d6fc6ba7efb22bade8eccb5004feddbc6c2568","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            parent_mock.attach_mock(mocker, name)"},{"line_number":154,"context_line":"        return parent_mock"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _test_deploy(self, boot_option\u003dNone):"},{"line_number":157,"context_line":"        \"\"\"Check loosely all functions are called with right args.\"\"\""},{"line_number":158,"context_line":"        address \u003d \u0027127.0.0.1\u0027"},{"line_number":159,"context_line":"        port \u003d 3306"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_a632bc5c","line":156,"in_reply_to":"ba7be1f8_600a6b7a","updated":"2015-02-25 10:08:01.000000000","message":"Now I have 3 test cases for this (222-230):\n\n* no boot_option\n* boot_option \u003d \"netboot\"\n* boot_option \u003d \"local\"\n\nTo achieve the first one, I had to pass no boot_option to make_partitions.  To do so, I needed to set a default for _test_deploy() as None.","commit_id":"dedb425770a6f91a54e990159843ac201dc2f1a5"}]}
