)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ff3b8198d30a8b2dbc43a044b0a91e28730afd49","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        \"\"\"Continues the iSCSI deployment from where ramdisk left off."},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        Continues the iSCSI deployment from the conductor node, finds the"},{"line_number":490,"context_line":"        boot ISO to boot the node, and sets the node to boot from boot ISO."},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":493,"context_line":"        :param kwargs: kwargs containing parameters for iSCSI deployment."}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c98308c9","line":490,"updated":"2015-02-19 20:57:39.000000000","message":"Might want to update this.","commit_id":"fd0298380b23c70f4670513e357befbcb6ad7055"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"76a98ebee0b4a8df2885cb73afff05ca8d78516f","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        \"\"\"Continues the iSCSI deployment from where ramdisk left off."},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        Continues the iSCSI deployment from the conductor node, finds the"},{"line_number":490,"context_line":"        boot ISO to boot the node, and sets the node to boot from boot ISO."},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":493,"context_line":"        :param kwargs: kwargs containing parameters for iSCSI deployment."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_c8d3125e","line":490,"in_reply_to":"da86d52c_c98308c9","updated":"2015-02-26 04:33:30.000000000","message":"Done","commit_id":"fd0298380b23c70f4670513e357befbcb6ad7055"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"a6523300f9a95eef239dc8c14af2ae89b5f33f17","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"                i_info \u003d node.instance_info"},{"line_number":520,"context_line":"                i_info[\u0027ilo_boot_iso\u0027] \u003d boot_iso"},{"line_number":521,"context_line":"                node.instance_info \u003d i_info"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"            deploy_utils.notify_deploy_complete(kwargs.get(\u0027address\u0027))"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_32eb3b79","line":521,"updated":"2015-02-26 03:15:39.000000000","message":"without calling node.save() does it actually save to the node instance info? or it doesn\u0027t need to get saved to node\u0027s instance info","commit_id":"5abe873a8593a75b70ba3c4c782b95f20c4c6180"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"96caf1d299b928d864b8ffbe7afcf6ac1f726505","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"                i_info \u003d node.instance_info"},{"line_number":520,"context_line":"                i_info[\u0027ilo_boot_iso\u0027] \u003d boot_iso"},{"line_number":521,"context_line":"                node.instance_info \u003d i_info"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"            deploy_utils.notify_deploy_complete(kwargs.get(\u0027address\u0027))"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_2d23e0a7","line":521,"in_reply_to":"ba7be1f8_32eb3b79","updated":"2015-02-26 03:20:20.000000000","message":"Anusha, it would get called in the below statement task.process_event(\u0027done\u0027).\n\nironic.conductor.task_manager() would do it for us.\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/task_manager.py#L314","commit_id":"5abe873a8593a75b70ba3c4c782b95f20c4c6180"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"00c8071e26a4cedf43c38859989a2a729b0dc7ea","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":440,"context_line":"        i_info \u003d self.node.instance_info"},{"line_number":441,"context_line":"        i_info[\u0027capabilities\u0027] \u003d \u0027{\"boot_option\": \"local\"}\u0027"},{"line_number":442,"context_line":"        self.node.instance_info \u003d i_info"},{"line_number":443,"context_line":"        self.node.save()"},{"line_number":444,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":445,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_75f0a6c9","line":442,"updated":"2015-02-17 15:35:20.000000000","message":"node.instance_info is empty dict before assignment, you can use one line:  \n\n self.node.instance_info \u003d {\u0027capabilities\u0027: \u0027{\"boot_option\": \"local\"}\u0027}","commit_id":"087c88e336d6bbb2c53a189dade865d9d769daba"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"cd0f27eb1bc3a98fc8264cdd33b6089a10ff3747","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        self.node.target_provision_state \u003d states.ACTIVE"},{"line_number":440,"context_line":"        i_info \u003d self.node.instance_info"},{"line_number":441,"context_line":"        i_info[\u0027capabilities\u0027] \u003d \u0027{\"boot_option\": \"local\"}\u0027"},{"line_number":442,"context_line":"        self.node.instance_info \u003d i_info"},{"line_number":443,"context_line":"        self.node.save()"},{"line_number":444,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":445,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c4a361af","line":442,"in_reply_to":"da86d52c_75f0a6c9","updated":"2015-02-17 15:55:37.000000000","message":"Done","commit_id":"087c88e336d6bbb2c53a189dade865d9d769daba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ff3b8198d30a8b2dbc43a044b0a91e28730afd49","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            continue_deploy_mock.assert_called_once_with(task, **kwargs)"},{"line_number":449,"context_line":"            set_boot_device_mock.assert_called_once_with(task,"},{"line_number":450,"context_line":"                                                         boot_devices.DISK,"},{"line_number":451,"context_line":"                                                         persistent\u003dTrue)"},{"line_number":452,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":453,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_9c1dd064","line":451,"updated":"2015-02-19 20:57:39.000000000","message":"I suppose you could also check that notify_deploy_complete_mock was called.","commit_id":"fd0298380b23c70f4670513e357befbcb6ad7055"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"76a98ebee0b4a8df2885cb73afff05ca8d78516f","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            continue_deploy_mock.assert_called_once_with(task, **kwargs)"},{"line_number":449,"context_line":"            set_boot_device_mock.assert_called_once_with(task,"},{"line_number":450,"context_line":"                                                         boot_devices.DISK,"},{"line_number":451,"context_line":"                                                         persistent\u003dTrue)"},{"line_number":452,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":453,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e8d6164e","line":451,"in_reply_to":"da86d52c_9c1dd064","updated":"2015-02-26 04:33:30.000000000","message":"Done","commit_id":"fd0298380b23c70f4670513e357befbcb6ad7055"}]}