)]}'
{"tools/states_to_dot.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f3be1a0dd70ef9deaf6afa933c45bed45e76fa1b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def map_color(text):"},{"line_number":39,"context_line":"    # If the text contains \u0027error\u0027 then we\u0027ll return red..."},{"line_number":40,"context_line":"    if \u0027error\u0027 in text:"},{"line_number":41,"context_line":"        return \u0027red\u0027"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_1f540220","line":40,"updated":"2015-02-23 16:35:09.000000000","message":"It\u0027d be nice to have \u0027fail\u0027 here too, so that the \u0027deploy failed\u0027 \u0026 \u0027inspectfail\u0027 are in red.\n\nWe should be consistent with those failed strings but that\u0027s outside the scope of this patch.","commit_id":"63e4dadf2867315b82348a605c33f975013dbe64"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9e51e9de1dba55927ad8eebd3fd52c40ee425e1a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def map_color(text):"},{"line_number":39,"context_line":"    # If the text contains \u0027error\u0027 then we\u0027ll return red..."},{"line_number":40,"context_line":"    if \u0027error\u0027 in text:"},{"line_number":41,"context_line":"        return \u0027red\u0027"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_22c0cd29","line":40,"in_reply_to":"ba7be1f8_1f540220","updated":"2015-02-23 16:49:10.000000000","message":"In case anyone was wondering, I submitted a patch to change \u0027inspectfail\u0027 to \u0027inspect failed\u0027 [1]\n\n[1] https://review.openstack.org/158351","commit_id":"63e4dadf2867315b82348a605c33f975013dbe64"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4c08edb9f3c23e622e5d43d04dd9c58a49cbb56b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    starts \u003d set(["},{"line_number":79,"context_line":"        format_state(source.start_state),"},{"line_number":80,"context_line":"        format_state(states.AVAILABLE),"},{"line_number":81,"context_line":"        format_state(states.MANAGEABLE),"},{"line_number":82,"context_line":"    ])"},{"line_number":83,"context_line":"    for (start_state, on_event, end_state) in source:"},{"line_number":84,"context_line":"        start_state \u003d format_state(start_state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b235e4db","line":81,"updated":"2015-02-23 19:44:22.000000000","message":"I\u0027m not sure we should colour these as green.\n\nI guess the question for me is \u0027why green for these\u0027?\n\nWe\u0027ve got the concept of a stable/passive state, and AVAILABLE, MANAGEABLE are stable. But so are ACTIVE and ERROR [1], and ERROR is red now. What do you get if you mix red and green?\n\n[1] https://github.com/openstack/ironic/commit/20c79de1757329c0868968442b5e5e5dc2bedd55#diff-8656525c5ed576955b5f1f68bad0cdfa","commit_id":"9eb04fd16db95513816f4d72fa0b40516662bfc3"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d0cdea9cde9ecf805b0075b06db456133171d709","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    starts \u003d set(["},{"line_number":79,"context_line":"        format_state(source.start_state),"},{"line_number":80,"context_line":"        format_state(states.AVAILABLE),"},{"line_number":81,"context_line":"        format_state(states.MANAGEABLE),"},{"line_number":82,"context_line":"    ])"},{"line_number":83,"context_line":"    for (start_state, on_event, end_state) in source:"},{"line_number":84,"context_line":"        start_state \u003d format_state(start_state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e05146d9","line":81,"in_reply_to":"ba7be1f8_b235e4db","updated":"2015-02-23 20:45:30.000000000","message":"Green for go :-P\n\nOr maybe blue; the start state stuff didn\u0027t look so nice when there were two entry states. Maybe I should just leave the color off...","commit_id":"9eb04fd16db95513816f4d72fa0b40516662bfc3"}]}
