)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8072b18f69698a33544b1e3f3e1034ed0353aef","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027used at deploy time. Required.\u0027),"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _time():"},{"line_number":69,"context_line":"    \"\"\"Broken out for testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a2a91de1","line":66,"updated":"2015-02-23 16:38:34.000000000","message":"do we need \u0027image_source\u0027 too?","commit_id":"c991bb2c846690bd360ab22ed678b7d99a38f7cc"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a2f44d12d7d33b9766733af8ad7c6e9f739621ba","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027used at deploy time. Required.\u0027),"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _time():"},{"line_number":69,"context_line":"    \"\"\"Broken out for testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_e2907550","line":66,"in_reply_to":"ba7be1f8_a2a91de1","updated":"2015-02-23 16:47:07.000000000","message":"There are driver_info parameters for driver configuration, see pxe driver for example https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L99-L104","commit_id":"c991bb2c846690bd360ab22ed678b7d99a38f7cc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0b7d73bb900cebf4e4b29ae7d47501272b5634d7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        \u0027used at deploy time. Required.\u0027),"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _time():"},{"line_number":69,"context_line":"    \"\"\"Broken out for testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_26c1b6e4","line":66,"in_reply_to":"ba7be1f8_e2907550","updated":"2015-02-23 22:04:59.000000000","message":"Yes, the properties are only wrt driver_info. I have wondered if we want a similar thing for instance_info.\n\nI was looking at the code, and in get_deploy_kr_info() there is a comment \u0027the values for these keys will look like \"glance://image-uuid\"\u0027. And I guess that is needed [1]. So maybe we should do something like s/from Glance/from Glance, of the form \"glance://UUID\"/?\n\n[1] https://github.com/openstack/ironic/commit/7c19286ed5e587301c1e2def9ad6b16d5f8ebcb0#diff-d791f3f509a1956db363966e37bd7183","commit_id":"c991bb2c846690bd360ab22ed678b7d99a38f7cc"}]}