)]}'
{"ironic/common/states.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5c9f55167cbeb415645f12bb068d653fd4d10236","unresolved":false,"context_lines":[{"line_number":57,"context_line":"may be used to support renaming these actions."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Note: The state value can be a maximum of 15 characters based on the database"},{"line_number":60,"context_line":"definition from models.py.  e.g. STATE_NAME \u003d \"state value\""},{"line_number":61,"context_line":"\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"NOSTATE \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a1691027","line":60,"updated":"2015-02-23 22:16:10.000000000","message":"Isn\u0027t this docstring describing the VERBS dictionary above?\n\nI don\u0027t think this note makes sense here.\n\nI think what we really need is a test that will fail if someone adds a string \u003e 15 chars. Because really, who reads documentation, especially if we put it at the top of all the states. Most people add new states to the bottom of the file.\n\nLooking through the documentation here, it seems like the only place where it would make sense to put this Note is at the top of the file, right after \u0027Mapping of ...\u0027. Seems like we could use a better \u0027intro\u0027 to this file.","commit_id":"8077658a84a49d247e0b5f828a2e7a296e31d598"}],"ironic/tests/test_states.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5976e1d2989de99057749515f03644aa499cab4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Copyright (C) 2014 Yahoo! Inc. All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_76919951","line":3,"updated":"2015-02-23 22:51:28.000000000","message":"I\u0027m fine with this but ... do you work for Yahoo? ;)","commit_id":"d77daed78cf66d4ee45986a1bf022a69e2514d42"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"255c33b2d4f2d14a2de4c79fca50e5482b28677f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class StatesTest(base.TestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_state_values(self):"},{"line_number":24,"context_line":"        for key, value in states.__dict__.iteritems():"},{"line_number":25,"context_line":"            # Assumption: A state variable name is all UPPERCASE and contents"},{"line_number":26,"context_line":"            # are a string.  It is okay that states which are equal to None"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_36b001f4","line":23,"updated":"2015-02-23 22:47:11.000000000","message":"I think this name could be better, maybe test_state_values_length or test_state_values_fit_in_db. More importantly, I think this should have a docstring explaining *why* a state value should be \u003c\u003d 15 characters.","commit_id":"d77daed78cf66d4ee45986a1bf022a69e2514d42"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d5976e1d2989de99057749515f03644aa499cab4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        for key, value in states.__dict__.iteritems():"},{"line_number":25,"context_line":"            # Assumption: A state variable name is all UPPERCASE and contents"},{"line_number":26,"context_line":"            # are a string.  It is okay that states which are equal to None"},{"line_number":27,"context_line":"            # won\u0027t be checked."},{"line_number":28,"context_line":"            if key.upper() \u003d\u003d key and isinstance(value, basestring):"},{"line_number":29,"context_line":"                self.assertTrue("},{"line_number":30,"context_line":"                    (len(value) \u003c\u003d 15),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_f6e109d1","line":27,"updated":"2015-02-23 22:51:28.000000000","message":"does this mean SOMESTATE\u003dNone? The test doesn\u0027t seem to accept that. Won\u0027t it try len(None)?","commit_id":"d77daed78cf66d4ee45986a1bf022a69e2514d42"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2d93365d6f3821edc4217049bf4e8b0cf20340fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        for key, value in states.__dict__.iteritems():"},{"line_number":25,"context_line":"            # Assumption: A state variable name is all UPPERCASE and contents"},{"line_number":26,"context_line":"            # are a string.  It is okay that states which are equal to None"},{"line_number":27,"context_line":"            # won\u0027t be checked."},{"line_number":28,"context_line":"            if key.upper() \u003d\u003d key and isinstance(value, basestring):"},{"line_number":29,"context_line":"                self.assertTrue("},{"line_number":30,"context_line":"                    (len(value) \u003c\u003d 15),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_b6731114","line":27,"in_reply_to":"ba7be1f8_f6e109d1","updated":"2015-02-23 22:55:25.000000000","message":"oops. the isinstance() will be False; missed that.","commit_id":"d77daed78cf66d4ee45986a1bf022a69e2514d42"}]}
