)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e9ad8427ae7264d7ae50ceb3f409bc4eab4319d7","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":652,"context_line":"                 hardware properties."},{"line_number":653,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":654,"context_line":"                  or None."},{"line_number":655,"context_line":"        \"\"\""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a813a2b6","line":654,"updated":"2015-02-24 09:18:35.000000000","message":"nit: s/None/states.INSPECTING/  (but it\u0027s also done by Nisha in another patch)","commit_id":"087fd82387e277243d96627007abc81ea29389b5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6d8413f2880bee449b0dd160e4fe6f2ea6e94391","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        :raises: HardwareInspectionFailure, if unable to get essential"},{"line_number":652,"context_line":"                 hardware properties."},{"line_number":653,"context_line":"        :returns: resulting state of the inspection i.e. states.MANAGEABLE"},{"line_number":654,"context_line":"                  or None."},{"line_number":655,"context_line":"        \"\"\""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f2f1f801","line":654,"in_reply_to":"ba7be1f8_a813a2b6","updated":"2015-02-24 14:30:30.000000000","message":"Yes, I didn\u0027t want to touch this because Nisha said she\u0027d address it. I also added a comment (in the original patch) because I wasn\u0027t sure this method was clear. eg if the exception is raised, what state will the node be in. Nor do I understand how this could return states.MANAGEABLE unless this method does the inspection synchronously/waits for it to be done. (And I\u0027m not sure it should be MANAGEABLE rather than INSPECTED but that\u0027s a different thing.)\n\nI am also curious as to how we classify properties as \u0027essential\u0027 or \u0027additional\u0027. We may want some API to eg \u0027get_essential_properties()\u0027, \u0027get_nonessential_properties()\u0027, but I\u0027m really digressing here.","commit_id":"087fd82387e277243d96627007abc81ea29389b5"}]}
