)]}'
{"tools/discovery/basediscovery.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"d2feb90232daae3e1faee80c89ddead9142a9131","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import abc"},{"line_number":4,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_2a52bf13","line":1,"updated":"2015-03-04 05:44:10.000000000","message":"I think this is base class to define some abstract interface methods, so the first line is not required, that is used for main scripts can be run in shell.\n\nAnd the Copyright and license information need here","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_353a9437","line":16,"updated":"2015-04-20 14:48:39.000000000","message":"A blank line required between import standard and third party lib.","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # auth token for chassis connection"},{"line_number":31,"context_line":"    token \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, username, password, host):"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_754fec92","line":31,"updated":"2015-04-20 14:48:39.000000000","message":"Vendors can use different auth methods, looks like this should not be in the base.","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self, username, password, host):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.username \u003d username"},{"line_number":36,"context_line":"        self.password \u003d password"},{"line_number":37,"context_line":"        self.host \u003d host"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_152670ce","line":35,"updated":"2015-04-20 14:48:39.000000000","message":"l35-37: ditto l31","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        Log in to the chassis and establish session"},{"line_number":44,"context_line":"        Set the auth token class variable for further access"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_5809bd2b","line":44,"updated":"2015-04-20 14:48:39.000000000","message":"ditto l31 about token.","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @abc.abstractmethod"},{"line_number":48,"context_line":"    def call_protocol(self, inner_url_member, chassis_ilo_ip):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        Contact chassis with specific protocol."}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_f83e51b7","line":48,"updated":"2015-04-20 14:48:39.000000000","message":"\"ilo\" is vendor specific.","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def get_driver_details(self, node):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        \"\"\""},{"line_number":114,"context_line":"        Set driver details such as address, username, password"},{"line_number":115,"context_line":"        for the specific Ironic power/deploy driver."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :param node: a single element from chassis_details"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_f8dad177","line":114,"updated":"2015-04-20 14:48:39.000000000","message":"Set?","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"}],"tools/discovery/chassis_discovery_tool.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4483327e8afd878dab16cbf4c47b27871c029b8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from optparse import OptionParser"},{"line_number":2,"context_line":"from chassis_enclosure import ChassisEnclosure"},{"line_number":3,"context_line":"from stevedore import driver"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ca192324","line":1,"updated":"2015-03-04 05:49:58.000000000","message":"Can we add below into first line? Then user can run this script directly without \u0027python \u0027 command required.\n\n  #!/usr/bin/python","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"d2feb90232daae3e1faee80c89ddead9142a9131","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from optparse import OptionParser"},{"line_number":2,"context_line":"from chassis_enclosure import ChassisEnclosure"},{"line_number":3,"context_line":"from stevedore import driver"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a708aa2e","line":1,"updated":"2015-03-04 05:44:10.000000000","message":"Copyright and license information need here","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"d2feb90232daae3e1faee80c89ddead9142a9131","unresolved":false,"context_lines":[{"line_number":39,"context_line":"elif options.action \u003d\u003d \"delete\":"},{"line_number":40,"context_line":"    chassis \u003d ChassisEnclosure(None, None, None, None, None,"},{"line_number":41,"context_line":"                               options.chassis_uuid)"},{"line_number":42,"context_line":"    chassis.delete_chassis()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_4a6e13cb","line":42,"updated":"2015-03-04 05:44:10.000000000","message":"Can we add more branch to cover the invalid action option input and show message to user?","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"507fb249f1020f169b272ae0c76a5d219f3a457c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# !/usr/local/bin/python"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from optparse import OptionParser"},{"line_number":19,"context_line":"from chassis_enclosure import ChassisEnclosure"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d0e63244","line":16,"updated":"2015-03-04 07:14:15.000000000","message":"Should we move this to the first line?\nAnd the below line should work with all Linux OS.\n\n  #!/usr/bin/python","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Load the Discovery Driver"},{"line_number":37,"context_line":"if options.discovery_driver:"},{"line_number":38,"context_line":"    discovery_driver \u003d driver.DriverManager("},{"line_number":39,"context_line":"                            namespace\u003d\u0027ironic.tools.discovery\u0027,"},{"line_number":40,"context_line":"                            name\u003doptions.discovery_driver,"},{"line_number":41,"context_line":"                            invoke_on_load\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_da094033","line":38,"updated":"2015-04-07 11:13:40.000000000","message":"You should add exception handling here too.","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"326315a9171d5570fd6455019f2a123de91c8d16","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from chassis_enclosure import ChassisEnclosure"},{"line_number":20,"context_line":"from ironic.common import exception"},{"line_number":21,"context_line":"from optparse import OptionParser"},{"line_number":22,"context_line":"from stevedore import driver"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_385de9e9","line":19,"updated":"2015-04-20 14:48:39.000000000","message":"These imports should be rearranged, as John wrote: http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"}],"tools/discovery/chassis_discovery_utils.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"d2feb90232daae3e1faee80c89ddead9142a9131","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"from ironicclient import client as irclient"},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e702a20a","line":2,"updated":"2015-03-04 05:44:10.000000000","message":"Copyright and license information need here","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"4483327e8afd878dab16cbf4c47b27871c029b8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"from ironicclient import client as irclient"},{"line_number":4,"context_line":"import os"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_0ad33b39","line":2,"updated":"2015-03-04 05:49:58.000000000","message":"ditto: first line is not required because this is not *main* script to be executed directly.","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"507fb249f1020f169b272ae0c76a5d219f3a457c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                {\u0027op\u0027: \u0027replace\u0027, \u0027path\u0027: chassis_update_path, \u0027value\u0027: value},"},{"line_number":95,"context_line":"            ]"},{"line_number":96,"context_line":"    print chassis_uuid"},{"line_number":97,"context_line":"    print chassis_update_path"},{"line_number":98,"context_line":"    ironic.chassis.update(chassis_uuid, patch)"},{"line_number":99,"context_line":"    print node_update_path"},{"line_number":100,"context_line":"    if node_update_path:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b0e37e04","line":97,"updated":"2015-03-04 07:14:15.000000000","message":"I understand this is used for debugging, so can we remove these *print* call.","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from ironicclient import client as irclient"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def get_client_handle():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_5d040a14","line":18,"updated":"2015-04-07 11:13:40.000000000","message":"nit - wrong import grouping.","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"}],"tools/discovery/chassis_enclosure.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"d2feb90232daae3e1faee80c89ddead9142a9131","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import chassis_discovery_utils"},{"line_number":2,"context_line":"import ConfigParser"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_0affbb02","line":1,"updated":"2015-03-04 05:44:10.000000000","message":"Copyright and license information need here","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import chassis_discovery_utils"},{"line_number":17,"context_line":"import ConfigParser"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ChassisEnclosure:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_5d79aa92","line":17,"updated":"2015-04-07 11:13:40.000000000","message":"nit - import grouping","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import ConfigParser"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ChassisEnclosure:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __init__(self, host\u003dNone, username\u003dNone, password\u003dNone,"},{"line_number":23,"context_line":"                 ironic_driver\u003dNone, discovery_driver\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_9d3172ef","line":20,"updated":"2015-04-07 11:13:40.000000000","message":"should be derived from object","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"}],"tools/discovery/moonshot_discovery_driver.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"d2feb90232daae3e1faee80c89ddead9142a9131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a80dd14_4a09b32b","updated":"2015-03-04 05:44:10.000000000","message":"Copyright and license information need here","commit_id":"bbbc31d0e17a990a7c60e9123263f403fae93981"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        details \u003d response.headers"},{"line_number":48,"context_line":"        MoonshotDiscovery.auth_token \u003d details[\u0027x-auth-token\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def call_protocol(inner_url_member, chassis_ilo_ip):"},{"line_number":51,"context_line":"        url \u003d \"https://\" + chassis_ilo_ip + inner_url_member"},{"line_number":52,"context_line":"        headers \u003d {\u0027content-type\u0027: \u0027application/json\u0027,"},{"line_number":53,"context_line":"                   \u0027x-auth-token\u0027: MoonshotDiscovery.auth_token}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1f00cea9","line":50,"updated":"2015-03-04 12:07:57.000000000","message":"Here and in several other places methods should have @staticmethod decorators. Also methods are inconsistent with base class - in base class all methods have self as first argument","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def convertGBtoMB(value):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        value_mb \u003d value * 1024"},{"line_number":63,"context_line":"        return value_mb"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def getTransitAddress(cartridgeSlot):"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_04e5e7a7","line":63,"updated":"2015-03-04 12:07:57.000000000","message":"just return value * 1024","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            chassis_link_details \u003d MoonshotDiscovery.call_protocol(url_member,"},{"line_number":84,"context_line":"                                   self.host)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Step 2 - Get the cartridges access layer"},{"line_number":87,"context_line":"        cartridges_url_member \u003d (chassis_link_details[\u0027links\u0027]"},{"line_number":88,"context_line":"                                [\u0027Cartridges\u0027][\u0027href\u0027])"},{"line_number":89,"context_line":"        cartridge_details \u003d MoonshotDiscovery.call_protocol("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_24902bec","line":86,"updated":"2015-03-04 12:07:57.000000000","message":"You\u0027re missing step 1 and 5 in this method :)","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        return chassis_details"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def get_node_details(self, node):"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        node_details \u003d dict()"},{"line_number":125,"context_line":"        node_details[\u0027memory_mb\u0027] \u003d node[\u0027memory_mb\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_9fe2fe01","line":122,"updated":"2015-03-04 12:07:57.000000000","message":"Why this and next two methods are not static?","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        node_details \u003d dict()"},{"line_number":125,"context_line":"        node_details[\u0027memory_mb\u0027] \u003d node[\u0027memory_mb\u0027]"},{"line_number":126,"context_line":"        node_details[\u0027cpu_arch\u0027] \u003d node[\u0027cpu_arch\u0027]"},{"line_number":127,"context_line":"        node_details[\u0027local_gb\u0027] \u003d 400"},{"line_number":128,"context_line":"        node_details[\u0027cpus\u0027] \u003d node[\u0027cpus\u0027]"},{"line_number":129,"context_line":"        node_details[\u0027mac_addr\u0027] \u003d node[\u0027mac_addr\u0027]"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a4bb3b71","line":127,"updated":"2015-03-04 12:07:57.000000000","message":"Why is this value hardcoded?","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        switch_details[\u0027hardware/interfaces/1/name\u0027] \u003d \"eth1\""},{"line_number":159,"context_line":"        switch_details[\u0027hardware/interfaces/1/switch_chassis_id\u0027] \u003d \"SwitchB\""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return switch_details"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_driver_details(self, node):"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e408d32f","line":161,"updated":"2015-03-04 12:07:57.000000000","message":"There are only 2 switches always?","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dab418ce5a84edbfefcd66e2631485c466b45fa1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        driver_details \u003d dict()"},{"line_number":166,"context_line":"        driver_details[\u0027ipmi_transit_address\u0027] \u003d (hex("},{"line_number":167,"context_line":"            MoonshotDiscovery.getTransitAddress(node[\u0027cartridge_slot\u0027])))"},{"line_number":168,"context_line":"        driver_details[\u0027ipmi_terminal_port\u0027] \u003d 9091"},{"line_number":169,"context_line":"        driver_details[\u0027ipmi_target_channel\u0027] \u003d 7"},{"line_number":170,"context_line":"        driver_details[\u0027ipmi_transit_channel\u0027] \u003d 0"},{"line_number":171,"context_line":"        driver_details[\u0027ipmi_local_address\u0027] \u003d \"0x20\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_84447775","line":168,"updated":"2015-03-04 12:07:57.000000000","message":"Are these 4 values always constant? Maybe make them global constants?","commit_id":"5fe937f26fbd4f00d936d845db0906bb39809326"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    IPMI_LOCAL_ADDRESS \u003d \"0x20\""},{"line_number":34,"context_line":"    IPMI_BRIDGING_TYPE \u003d \"dual\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, username, password, host):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        super(MoonshotDiscovery, self).__init__(username, password, host)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_9ad8581f","line":36,"updated":"2015-04-07 11:13:40.000000000","message":"Maybe you could remove abstractmethod decorator from base class (not sure why it\u0027s needed there), then you won\u0027t need this __init__ here.","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            properties and details."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            The connection protocol here is REST based querying"},{"line_number":48,"context_line":"            :return: token for further access"},{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":"        url_member \u003d \"/rest/v1/Sessions\""},{"line_number":51,"context_line":"        url \u003d \"https://\" + self.host + url_member"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_da6a601a","line":48,"updated":"2015-04-07 11:13:40.000000000","message":"It doesn\u0027t return anything, it adds it as a class member (should it be added as instance member, as it seems that there could be multiple chassis, right?).","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            MoonshotDiscovery.auth_token \u003d details[\u0027x-auth-token\u0027]"},{"line_number":59,"context_line":"        except KeyError as e:"},{"line_number":60,"context_line":"            raise e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @staticmethod"},{"line_number":63,"context_line":"    def call_protocol(inner_url_member, chassis_ilo_ip):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_1a5fa873","line":60,"updated":"2015-04-07 11:13:40.000000000","message":"If you want just to reraise it you don\u0027t need it, but I think it\u0027s better to log something here and/or convert it to some ironic exception.","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        except KeyError as e:"},{"line_number":60,"context_line":"            raise e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @staticmethod"},{"line_number":63,"context_line":"    def call_protocol(inner_url_member, chassis_ilo_ip):"},{"line_number":64,"context_line":"        url \u003d \"https://\" + chassis_ilo_ip + inner_url_member"},{"line_number":65,"context_line":"        headers \u003d {\u0027content-type\u0027: \u0027application/json\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_9d8df27d","line":62,"updated":"2015-04-07 11:13:40.000000000","message":"Again, this is inconsistent with base class. You should then add staticmethod decorators to base class.","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            raise e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @staticmethod"},{"line_number":63,"context_line":"    def call_protocol(inner_url_member, chassis_ilo_ip):"},{"line_number":64,"context_line":"        url \u003d \"https://\" + chassis_ilo_ip + inner_url_member"},{"line_number":65,"context_line":"        headers \u003d {\u0027content-type\u0027: \u0027application/json\u0027,"},{"line_number":66,"context_line":"                   \u0027x-auth-token\u0027: MoonshotDiscovery.auth_token}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_1dcfa2b1","line":63,"updated":"2015-04-07 11:13:40.000000000","message":"Maybe add some response validation here instead of catching KeyErrors afterwards?","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                        single_node[\u0027mac_addr2\u0027] \u003d (node_inner_details"},{"line_number":134,"context_line":"                                    [\u0027HostCorrelation\u0027][\u0027HostMACAddress\u0027][1])"},{"line_number":135,"context_line":"                    chassis_details.append(single_node)"},{"line_number":136,"context_line":"        except KeyError as e:"},{"line_number":137,"context_line":"            raise e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return chassis_details"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_7a37d4b0","line":136,"updated":"2015-04-07 11:13:40.000000000","message":"ditto reraising","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return chassis_details"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_node_details(self, node):"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        node_details \u003d dict()"},{"line_number":144,"context_line":"        node_details[\u0027memory_mb\u0027] \u003d node[\u0027memory_mb\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_bd5556c7","line":141,"updated":"2015-04-07 11:13:40.000000000","message":"Seems all 4 last methods can be made static.","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"618f1709a65cb82ce0b9bfd006dc3f5abe171737","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":"from basediscovery import BaseDiscovery"},{"line_number":19,"context_line":"from ironic.common import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ab451fb_899a6513","line":16,"updated":"2015-04-17 16:01:17.000000000","message":"http://docs.openstack.org/developer/hacking/#import-order-template\n\nAdd blank line after this line","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"618f1709a65cb82ce0b9bfd006dc3f5abe171737","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":"import requests"},{"line_number":18,"context_line":"from basediscovery import BaseDiscovery"},{"line_number":19,"context_line":"from ironic.common import exception"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ab451fb_94eef820","line":17,"updated":"2015-04-17 16:01:17.000000000","message":"add blank line after this line","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"}],"tools/discovery/node_update_path.ini":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d7b824938894c8f8d409daed4920c4869e08ec37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[node_parameters_path]\r"},{"line_number":2,"context_line":"username: /driver_info/ipmi_username\r"},{"line_number":3,"context_line":"password: /driver_info/ipmi_password\r"},{"line_number":4,"context_line":"host: /driver_info/ipmi_address\r"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9aa53dc9_7d2c6e4a","line":1,"updated":"2015-04-07 11:13:40.000000000","message":"Do you need \\r in this file?","commit_id":"a46db5bcec5cd272dbb29a516695f6560c81f270"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"618f1709a65cb82ce0b9bfd006dc3f5abe171737","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[node_parameters_path]\r"},{"line_number":2,"context_line":"username: /driver_info/ipmi_username\r"},{"line_number":3,"context_line":"password: /driver_info/ipmi_password\r"},{"line_number":4,"context_line":"host: /driver_info/ipmi_address\r"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3ab451fb_49d69dc6","line":1,"updated":"2015-04-17 16:01:17.000000000","message":"What is with the \\r ?  Was this edited on Windows?","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"}],"tools/discovery/setup.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"618f1709a65cb82ce0b9bfd006dc3f5abe171737","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from setuptools import setup, find_packages"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"setup("},{"line_number":4,"context_line":"    name\u003d\u0027discovery-driver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ab451fb_4911fdab","line":1,"updated":"2015-04-17 16:01:17.000000000","message":"nit: I think should be one import per line\n\nhttp://docs.openstack.org/developer/hacking/#real-world-import-order-examples","commit_id":"cdac8a2ab097492501566d23d8bac2cd5e094189"}]}
