)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b196c5efd94efc6cbf9a6f25a6fbbb50b53f6085","unresolved":false,"context_lines":[{"line_number":14,"context_line":"parameters that is already used by the Agent drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are also logging a warning when the \"pxe_\" namespaced parameters are"},{"line_number":17,"context_line":"used and also saying it\u0027s deprecated when get_options() is invoked via"},{"line_number":18,"context_line":"the API."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib2c4eba57bd5535310bf5b026a7ab01932ec4300"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_af1c8478","line":17,"updated":"2015-02-24 11:28:14.000000000","message":"Too many \"also\"\u0027s here, I will fix if I have to submit a new patch set","commit_id":"8e3bfa7e3d56cccc0292aea98ab3d3f526987c55"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9c019659fc19a1dce8dff37fe9b2d5de197d150","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are logging a warning when the \"pxe_\" namespaced parameters are used"},{"line_number":17,"context_line":"and also saying it\u0027s deprecated when get_options() is invoked via the API."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib2c4eba57bd5535310bf5b026a7ab01932ec4300"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_6c44081b","line":18,"updated":"2015-02-25 20:48:33.000000000","message":"I think we should have a DocImpact for this.","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d492957f59d0c22937b238e2b280c1c3b805505","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are logging a warning when the \"pxe_\" namespaced parameters are used"},{"line_number":17,"context_line":"and also saying it\u0027s deprecated when get_options() is invoked via the API."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib2c4eba57bd5535310bf5b026a7ab01932ec4300"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_561fb8b6","line":18,"in_reply_to":"ba7be1f8_6c44081b","updated":"2015-02-26 10:08:28.000000000","message":"Done","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"}],"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"705872cadce17115386b62c5ec7e7a74ac082ef8","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":"      ironic node-update $NODE_UUID add \\"},{"line_number":576,"context_line":"      driver_info/deploy_kernel\u003d$DEPLOY_VMLINUZ_UUID \\"},{"line_number":577,"context_line":"      driver_info/deploy_ramdisk\u003d$DEPLOY_INITRD_UUID \\"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"Setup the drivers for Bare Metal Service"},{"line_number":580,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_987eac68","line":577,"updated":"2015-02-26 16:51:26.000000000","message":"We need to put a note for juno, it is pxe_deploy_kernel etc.","commit_id":"4b7b123b2319e1e7dac3122ccfcf4a0fab9052b8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"705872cadce17115386b62c5ec7e7a74ac082ef8","unresolved":false,"context_lines":[{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    ironic node-update $NODE_UUID add \\"},{"line_number":943,"context_line":"    driver_info/deploy_kernel\u003d$DEPLOY_VMLINUZ_UUID \\"},{"line_number":944,"context_line":"    driver_info/deploy_ramdisk\u003d$DEPLOY_INITRD_UUID \\"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"#. You must also inform Ironic of the Network Interface Cards which are part of"},{"line_number":947,"context_line":"   the Node by creating a Port with each NIC\u0027s MAC address.  These MAC"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_98286c34","line":944,"updated":"2015-02-26 16:51:26.000000000","message":"here too. Things are starting to get ugly. At some point, we\u0027re going to need different install guides based on release.","commit_id":"4b7b123b2319e1e7dac3122ccfcf4a0fab9052b8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a2b17b5ef0700227632f71c91c23845783fd9e84","unresolved":false,"context_lines":[{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    ironic node-update $NODE_UUID add \\"},{"line_number":943,"context_line":"    driver_info/deploy_kernel\u003d$DEPLOY_VMLINUZ_UUID \\"},{"line_number":944,"context_line":"    driver_info/deploy_ramdisk\u003d$DEPLOY_INITRD_UUID \\"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"#. You must also inform Ironic of the Network Interface Cards which are part of"},{"line_number":947,"context_line":"   the Node by creating a Port with each NIC\u0027s MAC address.  These MAC"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_2b9fef04","line":944,"in_reply_to":"ba7be1f8_98286c34","updated":"2015-02-27 19:02:07.000000000","message":"I really wish docs were published by release + master.","commit_id":"4b7b123b2319e1e7dac3122ccfcf4a0fab9052b8"}],"doc/source/drivers/ilo.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"705872cadce17115386b62c5ec7e7a74ac082ef8","unresolved":false,"context_lines":[{"line_number":507,"context_line":"node::"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"  ironic node-create -d pxe_ilo ilo_address\u003d\u003cilo-ip-address\u003e -i ilo_username\u003d\u003cilo-username\u003e -i ilo_password\u003d\u003cilo-password\u003e -i deploy_kernel\u003d\u003cglance-uuid-of-pxe-deploy-kernel\u003e deploy_ramdisk\u003d\u003cglance-uuid-of-deploy-ramdisk\u003e"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"Boot modes"},{"line_number":512,"context_line":"~~~~~~~~~~"},{"line_number":513,"context_line":"Refer boot_mode_support_ for more information."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_d8cbc46f","line":510,"updated":"2015-02-26 16:51:26.000000000","message":"do we care here about mentioning juno it is pxe_*?","commit_id":"4b7b123b2319e1e7dac3122ccfcf4a0fab9052b8"}],"doc/source/drivers/seamicro.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"705872cadce17115386b62c5ec7e7a74ac082ef8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"- ``seamicro_username``: SeaMicro Username with administrator privileges."},{"line_number":86,"context_line":"- ``seamicro_password``: Password for the above SeaMicro user."},{"line_number":87,"context_line":"- ``deploy_kernel``: The Glance UUID of the deployment kernel."},{"line_number":88,"context_line":"- ``deploy_ramdisk``: The Glance UUID of the deployment ramdisk."},{"line_number":89,"context_line":"- ``seamicro_api_version``: (optional) SeaMicro API Version defaults to \"2\"."},{"line_number":90,"context_line":"- ``seamicro_terminal_port``: (optional) Node\u0027s UDP port for console access."},{"line_number":91,"context_line":"  Any unused port on the Ironic conductor node may be used."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba7be1f8_58a7d4bc","line":88,"updated":"2015-02-26 16:51:26.000000000","message":"oh boy. ditto.","commit_id":"4b7b123b2319e1e7dac3122ccfcf4a0fab9052b8"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9c019659fc19a1dce8dff37fe9b2d5de197d150","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                       \"Required.\"),"},{"line_number":105,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"UUID (from Glance) of the ramdisk that is \""},{"line_number":106,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":107,"context_line":"    \u0027pxe_deploy_kernel\u0027: _(\"DEPRECATED use deploy_kernel instead. UUID \""},{"line_number":108,"context_line":"                           \"(from Glance) of the deployment kernel. \""},{"line_number":109,"context_line":"                           \"Required.\"),"},{"line_number":110,"context_line":"    \u0027pxe_deploy_ramdisk\u0027: _(\"DEPRECATED use deploy_ramdisk instead. UUID \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_0c09ccdd","line":107,"updated":"2015-02-25 20:48:33.000000000","message":"nit: nice to have some sort of punctuation after DEPRECATED. How about \u0027DEPRECATED: \u0027.","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d492957f59d0c22937b238e2b280c1c3b805505","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                       \"Required.\"),"},{"line_number":105,"context_line":"    \u0027deploy_ramdisk\u0027: _(\"UUID (from Glance) of the ramdisk that is \""},{"line_number":106,"context_line":"                        \"mounted at boot time. Required.\"),"},{"line_number":107,"context_line":"    \u0027pxe_deploy_kernel\u0027: _(\"DEPRECATED use deploy_kernel instead. UUID \""},{"line_number":108,"context_line":"                           \"(from Glance) of the deployment kernel. \""},{"line_number":109,"context_line":"                           \"Required.\"),"},{"line_number":110,"context_line":"    \u0027pxe_deploy_ramdisk\u0027: _(\"DEPRECATED use deploy_ramdisk instead. UUID \""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_967cd0ed","line":107,"in_reply_to":"ba7be1f8_0c09ccdd","updated":"2015-02-26 10:08:28.000000000","message":"Done","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9c019659fc19a1dce8dff37fe9b2d5de197d150","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027pxe_deploy_kernel\u0027: _(\"DEPRECATED use deploy_kernel instead. UUID \""},{"line_number":108,"context_line":"                           \"(from Glance) of the deployment kernel. \""},{"line_number":109,"context_line":"                           \"Required.\"),"},{"line_number":110,"context_line":"    \u0027pxe_deploy_ramdisk\u0027: _(\"DEPRECATED use deploy_ramdisk instead. UUID \""},{"line_number":111,"context_line":"                            \"(from Glance) of the ramdisk that is \""},{"line_number":112,"context_line":"                            \"mounted at boot time. Required.\"),"},{"line_number":113,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_8cfcdcb9","line":110,"updated":"2015-02-25 20:48:33.000000000","message":"ditto","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d492957f59d0c22937b238e2b280c1c3b805505","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027pxe_deploy_kernel\u0027: _(\"DEPRECATED use deploy_kernel instead. UUID \""},{"line_number":108,"context_line":"                           \"(from Glance) of the deployment kernel. \""},{"line_number":109,"context_line":"                           \"Required.\"),"},{"line_number":110,"context_line":"    \u0027pxe_deploy_ramdisk\u0027: _(\"DEPRECATED use deploy_ramdisk instead. UUID \""},{"line_number":111,"context_line":"                            \"(from Glance) of the ramdisk that is \""},{"line_number":112,"context_line":"                            \"mounted at boot time. Required.\"),"},{"line_number":113,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_f6850ccf","line":110,"in_reply_to":"ba7be1f8_8cfcdcb9","updated":"2015-02-26 10:08:28.000000000","message":"Done","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9c019659fc19a1dce8dff37fe9b2d5de197d150","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    deploy_ramdisk \u003d info.get(\u0027deploy_ramdisk\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    # NOTE(lucasagomes): For backwards compatibility let\u0027s keep accepting"},{"line_number":135,"context_line":"    # pxe_deploy_{kernel, ramdisk}, should be removed in L."},{"line_number":136,"context_line":"    deprecated_msg \u003d _LW(\u0027The \"%(old_param)s\" parameter is deprecated. \u0027"},{"line_number":137,"context_line":"                         \u0027Please use \"%(new_param)s\" instead.\u0027)"},{"line_number":138,"context_line":"    if not deploy_kernel:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_ac1e000a","line":135,"updated":"2015-02-25 20:48:33.000000000","message":"s/L/Liberty/","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d492957f59d0c22937b238e2b280c1c3b805505","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    deploy_ramdisk \u003d info.get(\u0027deploy_ramdisk\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    # NOTE(lucasagomes): For backwards compatibility let\u0027s keep accepting"},{"line_number":135,"context_line":"    # pxe_deploy_{kernel, ramdisk}, should be removed in L."},{"line_number":136,"context_line":"    deprecated_msg \u003d _LW(\u0027The \"%(old_param)s\" parameter is deprecated. \u0027"},{"line_number":137,"context_line":"                         \u0027Please use \"%(new_param)s\" instead.\u0027)"},{"line_number":138,"context_line":"    if not deploy_kernel:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_b666344f","line":135,"in_reply_to":"ba7be1f8_ac1e000a","updated":"2015-02-26 10:08:28.000000000","message":"Done","commit_id":"d4a9093eb2bed9198e2b4f754bce37008f226d86"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f0c6488e8ba3bc099b48be4106ff47f2228ff71f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":154,"context_line":"                  \" missing in node\u0027s driver_info\")"},{"line_number":155,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    return d_info"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_f1106faa","line":156,"updated":"2015-03-11 11:15:27.000000000","message":"for parameter in (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027):\n     value \u003d info.get(parameter)\n     if not value:\n         value \u003d info.get(\u0027pxe_\u0027 + parameter)\n         if value:\n             LOG.warning(...\n     d_info[parameter] \u003d value","commit_id":"c1cc08bb6f4b8ee1b92b5b3f499bc0f363d24d1f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d0b307df2ea468e8a8327fac09d57c03b21f7e76","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":154,"context_line":"                  \" missing in node\u0027s driver_info\")"},{"line_number":155,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    return d_info"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_180a83d2","line":156,"in_reply_to":"9a80dd14_f1106faa","updated":"2015-03-11 11:50:55.000000000","message":"Looks like a nicer way to do it, thanks I will try it out","commit_id":"c1cc08bb6f4b8ee1b92b5b3f499bc0f363d24d1f"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"bb8f14ae89a1a7021375872ff6be7630f7330723","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            old_parameter \u003d \u0027pxe_\u0027 + parameter"},{"line_number":140,"context_line":"            value \u003d info.get(old_parameter)"},{"line_number":141,"context_line":"            if value:"},{"line_number":142,"context_line":"                LOG.warning(deprecated_msg, {\u0027old_param\u0027: old_parameter,"},{"line_number":143,"context_line":"                                             \u0027new_param\u0027: parameter})"},{"line_number":144,"context_line":"        d_info[parameter] \u003d value"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_633d87bb","line":142,"updated":"2015-03-11 15:52:37.000000000","message":"The message logged here does not contain the node UUID and thus is not helpful to an operator:\n\n  2015-03-11 08:51:29.108 28716 WARNING ironic.drivers.modules.pxe [-] The \"pxe_deploy_kernel\" parameter is deprecated. Please use \"deploy_kernel\" instead.","commit_id":"0516224b0dce30888fcdac984f480bc3292173d9"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a2b17b5ef0700227632f71c91c23845783fd9e84","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                                          driver_info\u003dold_drv_info)"},{"line_number":106,"context_line":"        info \u003d pxe._parse_driver_info(node)"},{"line_number":107,"context_line":"        self.assertIsNotNone(info.get(\u0027deploy_ramdisk\u0027))"},{"line_number":108,"context_line":"        self.assertIsNotNone(info.get(\u0027deploy_kernel\u0027))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class PXEPrivateMethodsTestCase(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_8b5a9b4e","line":108,"updated":"2015-02-27 19:02:07.000000000","message":"Worth asserting that we logged a deprecation message?\n\nmock_log.warning.assert_has_calls([mock.call(\u0027DEPRECATED...\u0027)])","commit_id":"4b7b123b2319e1e7dac3122ccfcf4a0fab9052b8"}]}