)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"13d3c580890952f51a0f34504a60133ddcf03faa","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        return self.host in ring.get_hosts(node_uuid)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    def find_nodes(self, columns\u003dNone, **kwargs):"},{"line_number":945,"context_line":"        \"\"\"Find nodes mapped to this conductor."},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"        Yields tuples (node_uuid, driver, ...) where ... is derived from"},{"line_number":948,"context_line":"        columns argument."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a381c3c4","line":945,"updated":"2015-02-25 13:51:26.000000000","message":"May be a proper docstring can help as it not as straightforward as it looks.","commit_id":"c3268c5ca22e7f5a3f0d9fbfea1ff45d4dc73672"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e28aaa8fc61ea1394f5ffefb963df37adb60465","unresolved":false,"context_lines":[{"line_number":950,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027] + (columns or [])"},{"line_number":951,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list(columns\u003dcolumns, **kwargs)"},{"line_number":952,"context_line":"        for result in node_list:"},{"line_number":953,"context_line":"            if not self._mapped_to_this_conductor(*result[:2]):"},{"line_number":954,"context_line":"                continue"},{"line_number":955,"context_line":"            yield result"},{"line_number":956,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_41a8ff76","line":953,"updated":"2015-02-25 14:24:34.000000000","message":"nit:\n if self....:\n   yield result\n\nOne less line of code, I think.\n\nAlso result[:2] is not obvious what that is for.  At least to me.","commit_id":"c3268c5ca22e7f5a3f0d9fbfea1ff45d4dc73672"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d1b6c4106900353c352c2ce4641d05b95dab859","unresolved":false,"context_lines":[{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        return self.host in ring.get_hosts(node_uuid)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def find_nodes(self, columns\u003dNone, **kwargs):"},{"line_number":948,"context_line":"        \"\"\"Find nodes mapped to this conductor."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        Requests node set from dbapi passing **kwargs there, then filters out"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_358b0920","line":947,"updated":"2015-02-26 16:31:04.000000000","message":"nit: may be something like find_nodes_mapped_to_this_conductor() (but feels like it is too long)","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559d7f3e55a7c64724ced8d84036c840a8c8e6c0","unresolved":false,"context_lines":[{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        return self.host in ring.get_hosts(node_uuid)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def find_nodes(self, columns\u003dNone, **kwargs):"},{"line_number":948,"context_line":"        \"\"\"Find nodes mapped to this conductor."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        Requests node set from dbapi passing **kwargs there, then filters out"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ed25015d","line":947,"in_reply_to":"ba7be1f8_141c31c1","updated":"2015-02-27 12:06:21.000000000","message":"can we agree on iter_nodes? :)","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"04a53d50afa917e8a4f3dd2707da4aa720caeea5","unresolved":false,"context_lines":[{"line_number":944,"context_line":""},{"line_number":945,"context_line":"        return self.host in ring.get_hosts(node_uuid)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def find_nodes(self, columns\u003dNone, **kwargs):"},{"line_number":948,"context_line":"        \"\"\"Find nodes mapped to this conductor."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        Requests node set from dbapi passing **kwargs there, then filters out"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_141c31c1","line":947,"in_reply_to":"ba7be1f8_358b0920","updated":"2015-02-27 02:35:50.000000000","message":"I don\u0027t really think the method name needs to reflect this conductor. It is mentioned in the docstring and since this is a conductor, I had assumed it would only be nodes of interest to this conductor ;)\n\nWould it be bad to call it something like \u0027node_generator\u0027 since it makes it more obvious that it is a generator? I\u0027m not fond of \u0027find\u0027, it is more like \u0027get\u0027 nodes that satisfy some criteria. Or heh \u0027my_nodes\u0027.","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"0d1b6c4106900353c352c2ce4641d05b95dab859","unresolved":false,"context_lines":[{"line_number":947,"context_line":"    def find_nodes(self, columns\u003dNone, **kwargs):"},{"line_number":948,"context_line":"        \"\"\"Find nodes mapped to this conductor."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        Requests node set from dbapi passing **kwargs there, then filters out"},{"line_number":951,"context_line":"        nodes that are not mapped to this conductor."},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        Yields tuples (node_uuid, driver, ...) where ... is derived from"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_5564fdb7","line":950,"updated":"2015-02-26 16:31:04.000000000","message":"nit: this can be in proper docstring format ? :)","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559d7f3e55a7c64724ced8d84036c840a8c8e6c0","unresolved":false,"context_lines":[{"line_number":947,"context_line":"    def find_nodes(self, columns\u003dNone, **kwargs):"},{"line_number":948,"context_line":"        \"\"\"Find nodes mapped to this conductor."},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        Requests node set from dbapi passing **kwargs there, then filters out"},{"line_number":951,"context_line":"        nodes that are not mapped to this conductor."},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        Yields tuples (node_uuid, driver, ...) where ... is derived from"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_8d1645f0","line":950,"in_reply_to":"ba7be1f8_5564fdb7","updated":"2015-02-27 12:06:21.000000000","message":"Done","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"04a53d50afa917e8a4f3dd2707da4aa720caeea5","unresolved":false,"context_lines":[{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        Yields tuples (node_uuid, driver, ...) where ... is derived from"},{"line_number":954,"context_line":"        columns argument, e.g.: columns\u003dNone means [\u0027uuid\u0027, \u0027driver\u0027],"},{"line_number":955,"context_line":"        columns\u003d[\u0027foo\u0027] means [\u0027uuid\u0027, \u0027driver\u0027, \u0027foo\u0027]."},{"line_number":956,"context_line":"        \"\"\""},{"line_number":957,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027] + (columns or [])"},{"line_number":958,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list(columns\u003dcolumns, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_54c069e0","line":955,"updated":"2015-02-27 02:35:50.000000000","message":"nit: A tuple is of the form (), yet your examples are []. Are the examples meant to be examples of the tuples, or the list of columns used \u0027internally\u0027?\n\nHmm. Maybe we should avoid the word \u0027column\u0027 here -- that\u0027s a db term. I think \u0027fields\u0027 might be a better parameter to this method, since these are the fields of the nodes, right?","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559d7f3e55a7c64724ced8d84036c840a8c8e6c0","unresolved":false,"context_lines":[{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        Yields tuples (node_uuid, driver, ...) where ... is derived from"},{"line_number":954,"context_line":"        columns argument, e.g.: columns\u003dNone means [\u0027uuid\u0027, \u0027driver\u0027],"},{"line_number":955,"context_line":"        columns\u003d[\u0027foo\u0027] means [\u0027uuid\u0027, \u0027driver\u0027, \u0027foo\u0027]."},{"line_number":956,"context_line":"        \"\"\""},{"line_number":957,"context_line":"        columns \u003d [\u0027uuid\u0027, \u0027driver\u0027] + (columns or [])"},{"line_number":958,"context_line":"        node_list \u003d self.dbapi.get_nodeinfo_list(columns\u003dcolumns, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_8ded65f2","line":955,"in_reply_to":"ba7be1f8_54c069e0","updated":"2015-02-27 12:06:21.000000000","message":"Good catch. Will change anything to tuples and will call it fields.","commit_id":"45e8191a940103bd453224d61851c855a6eb1fae"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"12ee9ab508360b23411913f8816ca6207d0d4002","unresolved":false,"context_lines":[{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        return self.host in ring.get_hosts(node_uuid)"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"    def iter_nodes(self, fields\u003dNone, **kwargs):"},{"line_number":1012,"context_line":"        \"\"\"Iterate over nodes mapped to this conductor."},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"        Requests node set from and filters out nodes that are not"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_be3751fe","line":1011,"updated":"2015-03-02 20:35:00.000000000","message":"Should there be a unittest for this function?","commit_id":"1df86809fc5a2040084da46d3c34862d165d261f"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8e612a079843fd4b6d7bae6379ae033f7daf2c00","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        fields argument, e.g.: fields\u003dNone means yielding (\u0027uuid\u0027, \u0027driver\u0027),"},{"line_number":1019,"context_line":"        fields\u003d[\u0027foo\u0027] means yielding (\u0027uuid\u0027, \u0027driver\u0027, \u0027foo\u0027)."},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        :param columns: list of fields to fetch in addition to uuid and driver"},{"line_number":1022,"context_line":"        :param kwargs: additional arguments to pass to dbapi when looking for"},{"line_number":1023,"context_line":"                       nodes"},{"line_number":1024,"context_line":"        :return: generator yielding tuples of requested fields"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_8498be1c","line":1021,"updated":"2015-02-28 02:32:13.000000000","message":"s/columns/fields","commit_id":"1df86809fc5a2040084da46d3c34862d165d261f"}]}
