)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a14ede2f7b033e2de31026604e6b73142b96a08a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and create a efi system partition. The efi system partition"},{"line_number":12,"context_line":"is used later by bootloader (which is installed from"},{"line_number":13,"context_line":"ramdisk)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint local-boot-support-with-partition-images"},{"line_number":16,"context_line":"Change-Id: I00ac31da325676ea4ea1ac4185f5ac3a52c5809a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_1a0ea93b","line":14,"updated":"2015-03-06 10:23:11.000000000","message":"This depends on a change on DIB, so we need to make sure that it gets merged there before we merge it in Ironic\n\nDepends-On: Idf7ac5987e14e1d31311834196ca7283deec15c6","commit_id":"99580569d72b9335ed0dc3bee9b10f1a1963bb07"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"72c8402e7601b5f9616540ef75a7682b1631f090","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and create a efi system partition. The efi system partition"},{"line_number":12,"context_line":"is used later by bootloader (which is installed from"},{"line_number":13,"context_line":"ramdisk)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint local-boot-support-with-partition-images"},{"line_number":16,"context_line":"Change-Id: I00ac31da325676ea4ea1ac4185f5ac3a52c5809a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_f21475ea","line":14,"in_reply_to":"9a80dd14_1a0ea93b","updated":"2015-03-07 06:59:40.000000000","message":"Done","commit_id":"99580569d72b9335ed0dc3bee9b10f1a1963bb07"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2d81bec8b4b79b6db6320e0a5cd6ef059e7ff79a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ramdisk)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Corresponding diskimage-builder change is here:"},{"line_number":16,"context_line":"Idf7ac5987e14e1d31311834196ca7283deec15c6"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint local-boot-support-with-partition-images"},{"line_number":19,"context_line":"Change-Id: I00ac31da325676ea4ea1ac4185f5ac3a52c5809a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_45f17d94","line":16,"updated":"2015-03-11 10:02:33.000000000","message":"You can use the \"Depends-On\" tag which sets a cross-project dependency:\n\nDepends-On: Idf7ac5987e14e1d31311834196ca7283deec15c6","commit_id":"7c2549f8e5cc4c28b5af4401581b8b946cf28b62"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"bd50b78d554a8aca2745e2cad20bbf821d28064b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ramdisk)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Corresponding diskimage-builder change is here:"},{"line_number":16,"context_line":"Idf7ac5987e14e1d31311834196ca7283deec15c6"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint local-boot-support-with-partition-images"},{"line_number":19,"context_line":"Change-Id: I00ac31da325676ea4ea1ac4185f5ac3a52c5809a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_e5ba716d","line":16,"in_reply_to":"9a80dd14_45f17d94","updated":"2015-03-11 10:52:11.000000000","message":"Oh I didn\u0027t know this, thanks :)","commit_id":"7c2549f8e5cc4c28b5af4401581b8b946cf28b62"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"286fdfa518331b96a6ce890a0cf46409f3d37843","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":18,"context_line":"#qpid_hostname\u003dironic"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Qpid broker port. (integer value)"},{"line_number":21,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a80dd14_2d8fe2cd","line":18,"updated":"2015-03-05 17:05:44.000000000","message":"Is this a related change?","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":18,"context_line":"#qpid_hostname\u003dironic"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Qpid broker port. (integer value)"},{"line_number":21,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a80dd14_23e1b39a","line":18,"in_reply_to":"9a80dd14_2d8fe2cd","updated":"2015-03-05 17:45:25.000000000","message":"it keeps coming and going. i think this depends on the current hostname of the system.\n\nanother review which switches it back: https://review.openstack.org/#/c/156562/12/etc/ironic/ironic.conf.sample","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"286fdfa518331b96a6ce890a0cf46409f3d37843","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"deploy_opts \u003d ["},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027efi_system_partition_size\u0027,"},{"line_number":50,"context_line":"               default\u003d200,"},{"line_number":51,"context_line":"               help\u003d\u0027Size of EFI system partition in MiB when configuring \u0027"},{"line_number":52,"context_line":"                    \u0027UEFI systems for local boot.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_6d355af6","line":50,"updated":"2015-03-05 17:05:44.000000000","message":"I tend to prefer 1 GB here, mainly to make it harder to run out of space in the face of kernel/initrd updates.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"deploy_opts \u003d ["},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027efi_system_partition_size\u0027,"},{"line_number":50,"context_line":"               default\u003d200,"},{"line_number":51,"context_line":"               help\u003d\u0027Size of EFI system partition in MiB when configuring \u0027"},{"line_number":52,"context_line":"                    \u0027UEFI systems for local boot.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a3168353","line":50,"in_reply_to":"9a80dd14_6d355af6","updated":"2015-03-05 17:45:25.000000000","message":"this is just a fat32 partition for the efi system firmware to load the boot loader. in case of grub (for which our ramdisk supports now), it just copies the grubx64.efi file here.  the rest of the things are still in the root partition.  \n\nrecommendation from ubuntu is 200mb.\nhttps://help.ubuntu.com/community/UEFI#Creating_an_EFI_partition","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d164f4b3929ba29894f116e1b739a0772a528e07","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    LOG.debug(\"Starting to partition the disk device: %(dev)s\","},{"line_number":214,"context_line":"              {\u0027dev\u0027: dev})"},{"line_number":215,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"},{"line_number":216,"context_line":"    part_dict \u003d {}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # For uefi localboot, switch partition table to gpt and create the efi"},{"line_number":219,"context_line":"    # system partition as the first partition."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_4a007c01","line":216,"updated":"2015-03-05 16:39:20.000000000","message":"Is there a check anywhere to make sure that boot_mode is valid?  Should there be?\n\n if boot_mode not in (\u0027bios\u0027, \u0027uefi\u0027):\n   raise SomeException()","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    LOG.debug(\"Starting to partition the disk device: %(dev)s\","},{"line_number":214,"context_line":"              {\u0027dev\u0027: dev})"},{"line_number":215,"context_line":"    part_template \u003d dev + \u0027-part%d\u0027"},{"line_number":216,"context_line":"    part_dict \u003d {}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # For uefi localboot, switch partition table to gpt and create the efi"},{"line_number":219,"context_line":"    # system partition as the first partition."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_fe4bae56","line":216,"in_reply_to":"9a80dd14_4a007c01","updated":"2015-03-05 17:45:25.000000000","message":"yeah we have it in deploy driver\u0027s validate method:\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L316\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L283","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d164f4b3929ba29894f116e1b739a0772a528e07","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        images.convert_image(src, dst, \u0027raw\u0027, True)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def mkfs(dev, format, label\u003dNone):"},{"line_number":293,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":294,"context_line":"    utils.mkfs(format, dev, label)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_6a30e09e","line":292,"updated":"2015-03-05 16:39:20.000000000","message":"s/format/fs/\n\nOr \u0027filesystem\u0027\n\nI suggested \u0027fs\u0027 because that is what utils.mkfs() uses.\n\nAlso to line up with utils.mkfs have it be mkfs(fs, dev, label\u003dNone).  Confusing to have different ordering of arguments.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        images.convert_image(src, dst, \u0027raw\u0027, True)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def mkfs(dev, format, label\u003dNone):"},{"line_number":293,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":294,"context_line":"    utils.mkfs(format, dev, label)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_feb9ee2e","line":292,"in_reply_to":"9a80dd14_6a30e09e","updated":"2015-03-05 17:45:25.000000000","message":"Done","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d164f4b3929ba29894f116e1b739a0772a528e07","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def mkfs(dev, format, label\u003dNone):"},{"line_number":293,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":294,"context_line":"    utils.mkfs(format, dev, label)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_8a835403","line":293,"updated":"2015-03-05 16:39:20.000000000","message":"Also, why not just call utils.mkfs directly?  What is this function helping with anymore?\n\nI think this function should be deleted.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def mkfs(dev, format, label\u003dNone):"},{"line_number":293,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":294,"context_line":"    utils.mkfs(format, dev, label)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_dee26a00","line":293,"in_reply_to":"9a80dd14_8a835403","updated":"2015-03-05 17:45:25.000000000","message":"I can think of only for ease of mocking.\nhttps://github.com/openstack/ironic/blob/master/ironic/tests/drivers/test_deploy_utils.py#L168-L184\n\nit has historically been there, but i am not sure of any other reason.\n\nbut i am not sure if this patch should take care of modifying all the tests if we just delete this method now.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2752392cf1bc59f6a550a7d17fad82ba9b549091","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    populate_image(image_path, root_part)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    if swap_part:"},{"line_number":561,"context_line":"        mkfs(swap_part, format\u003d\u0027swap\u0027, label\u003d\u0027swap1\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    if ephemeral_part and not preserve_ephemeral:"},{"line_number":564,"context_line":"        mkfs(ephemeral_part, format\u003dephemeral_format, label\u003d\"ephemeral0\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_da13edfe","line":561,"updated":"2015-03-04 00:12:15.000000000","message":"to be consistent with ephemeral part label maybe: label\u003d\u0027swap0\u0027","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0854efb03466d43801cd9678ea962d638a4e7623","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    populate_image(image_path, root_part)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    if swap_part:"},{"line_number":561,"context_line":"        mkfs(swap_part, format\u003d\u0027swap\u0027, label\u003d\u0027swap1\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    if ephemeral_part and not preserve_ephemeral:"},{"line_number":564,"context_line":"        mkfs(ephemeral_part, format\u003dephemeral_format, label\u003d\"ephemeral0\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_b3daa3e7","line":561,"in_reply_to":"9a80dd14_332cf34a","updated":"2015-03-04 10:48:26.000000000","message":"I also think we should keep the same it was before, just in case someone using Ironic is now relying on those labels to mount their partitions (like in the way they build their images, having \"swap1\" label on their /etc/fstab)\n\nAnd as a note, for future patches, I think we should try to avoid touching bits that are not really required to do to complete a task. Refactors are good but unless they are really necessary we should tackle them on different patches (we can have a series of patches, each one fiixng a specific thing). That\u0027s good because I think the patches will merge faster due reviews easier to do to (less code to review)","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"17385ea3d04c728240c22941bee72f92bd5bc3bd","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    populate_image(image_path, root_part)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    if swap_part:"},{"line_number":561,"context_line":"        mkfs(swap_part, format\u003d\u0027swap\u0027, label\u003d\u0027swap1\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    if ephemeral_part and not preserve_ephemeral:"},{"line_number":564,"context_line":"        mkfs(ephemeral_part, format\u003dephemeral_format, label\u003d\"ephemeral0\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_332cf34a","line":561,"in_reply_to":"ba7be1f8_da13edfe","updated":"2015-03-04 10:20:22.000000000","message":"Chris, it was \"swap1\" earlier, so I just used the same.  \n\nCan this be changed now ? Will someone be expecting to find the swap (for some reason) in /dev/disk/by-label of a provisioned instance ? \n\nChanging this is trivial, but I wanted to be sure I am not breaking anything since it changes a previous behaviour. (people could find swap in /dev/disk/by-label/swap1 earlier, but it will change to swap0 now).","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a14ede2f7b033e2de31026604e6b73142b96a08a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        images.convert_image(src, dst, \u0027raw\u0027, True)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def mkfs(fs, dev, label\u003dNone):"},{"line_number":293,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":294,"context_line":"    utils.mkfs(fs, dev, label)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_3ad0cdf5","line":292,"updated":"2015-03-06 10:23:11.000000000","message":"That\u0027s exactly like the utils.mkfs() function signature. No need to create this wrapper her then","commit_id":"99580569d72b9335ed0dc3bee9b10f1a1963bb07"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"72c8402e7601b5f9616540ef75a7682b1631f090","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        images.convert_image(src, dst, \u0027raw\u0027, True)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"def mkfs(fs, dev, label\u003dNone):"},{"line_number":293,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":294,"context_line":"    utils.mkfs(fs, dev, label)"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_b21e7d0a","line":292,"in_reply_to":"9a80dd14_3ad0cdf5","updated":"2015-03-07 06:59:40.000000000","message":"Yeah, I thought it\u0027s better to fix it in a follow-up patch sometime later.  There is similar method dd above as well.  The problem is it requires some test changes (which are not trivial) because of the way we mock and assert things in test_deploy_utils.  I will end up pulling a lot of unrelated changes ( I already pulled in some unfortunately :( ).","commit_id":"99580569d72b9335ed0dc3bee9b10f1a1963bb07"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"60bbf5bd05226e20342f7cff116a08503eadb675","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        # partition.  Create a fat filesystem on it."},{"line_number":546,"context_line":"        if boot_mode \u003d\u003d \"uefi\" and boot_option \u003d\u003d \"local\":"},{"line_number":547,"context_line":"            efi_system_part \u003d part_dict.get(\u0027efi system partition\u0027)"},{"line_number":548,"context_line":"            mkfs(dev\u003defi_system_part, fs\u003d\u0027vfat\u0027)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        if configdrive_part:"},{"line_number":551,"context_line":"            # Copy the configdrive content to the configdrive partition"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_4557bd26","line":548,"updated":"2015-03-11 10:05:41.000000000","message":"Btw, should we add a label for it? So that on the DIB patch you can just search for the label instead of picking the first partition? Sounds a bit more reliable.","commit_id":"7c2549f8e5cc4c28b5af4401581b8b946cf28b62"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"bd50b78d554a8aca2745e2cad20bbf821d28064b","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        # partition.  Create a fat filesystem on it."},{"line_number":546,"context_line":"        if boot_mode \u003d\u003d \"uefi\" and boot_option \u003d\u003d \"local\":"},{"line_number":547,"context_line":"            efi_system_part \u003d part_dict.get(\u0027efi system partition\u0027)"},{"line_number":548,"context_line":"            mkfs(dev\u003defi_system_part, fs\u003d\u0027vfat\u0027)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        if configdrive_part:"},{"line_number":551,"context_line":"            # Copy the configdrive content to the configdrive partition"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_bb86d663","line":548,"in_reply_to":"9a80dd14_4557bd26","updated":"2015-03-11 10:52:11.000000000","message":"Done","commit_id":"7c2549f8e5cc4c28b5af4401581b8b946cf28b62"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"123aaea939bb7fbc83a52a88abb506bc9171189f","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"def mkfs(fs, dev, label\u003dNone):"},{"line_number":295,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":296,"context_line":"    utils.mkfs(fs, dev, label)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def block_uuid(dev):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_a11f7fb6","line":296,"updated":"2015-03-11 14:28:52.000000000","message":"I do not see the point of having a wrapper this small -- it does not save any lines of code or set any defaults that anything else in this file actually use.","commit_id":"3b44d34de655107dc170c34f54ce313cc8146880"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1a8014289475acc7c824dda4a0d3914164ac78c","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"def mkfs(fs, dev, label\u003dNone):"},{"line_number":295,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":296,"context_line":"    utils.mkfs(fs, dev, label)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def block_uuid(dev):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_5931ef58","line":296,"in_reply_to":"9a80dd14_08f3080b","updated":"2015-03-13 10:55:56.000000000","message":"+1 yeah it\u0027s being pointed out a couple of times. I\u0027m good on fixing in a following patch","commit_id":"3b44d34de655107dc170c34f54ce313cc8146880"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"d51d651dde9c920d41154b94cd90714e8bea82ad","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"def mkfs(fs, dev, label\u003dNone):"},{"line_number":295,"context_line":"    \"\"\"Execute mkfs on a device.\"\"\""},{"line_number":296,"context_line":"    utils.mkfs(fs, dev, label)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def block_uuid(dev):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_08f3080b","line":296,"in_reply_to":"9a80dd14_a11f7fb6","updated":"2015-03-11 15:39:05.000000000","message":"i agree. but i would actually prefer it to do in another patch for 2 reasons:\n\n* we can change def dd which is similar above\n* this will require some more test changes than we would normally expect (because of the way we do mocking) and hence it will pull a lot of unrelated changes to this commit, making it difficult to understand the changes for the actual reason and changes due to refactoring.","commit_id":"3b44d34de655107dc170c34f54ce313cc8146880"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d164f4b3929ba29894f116e1b739a0772a528e07","unresolved":false,"context_lines":[{"line_number":235,"context_line":"              \u0027preserve_ephemeral\u0027: i_info[\u0027preserve_ephemeral\u0027],"},{"line_number":236,"context_line":"              \u0027node_uuid\u0027: node.uuid,"},{"line_number":237,"context_line":"              \u0027boot_option\u0027: get_boot_option(node),"},{"line_number":238,"context_line":"              \u0027boot_mode\u0027: _get_boot_mode(node)}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    missing \u003d [key for key in params if params[key] is None]"},{"line_number":241,"context_line":"    if missing:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_b63c04c1","line":238,"updated":"2015-03-05 16:39:20.000000000","message":"nit: Add trailing comma and put closing brace on new line.  So future patches will only impact one line and not two like this one.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":235,"context_line":"              \u0027preserve_ephemeral\u0027: i_info[\u0027preserve_ephemeral\u0027],"},{"line_number":236,"context_line":"              \u0027node_uuid\u0027: node.uuid,"},{"line_number":237,"context_line":"              \u0027boot_option\u0027: get_boot_option(node),"},{"line_number":238,"context_line":"              \u0027boot_mode\u0027: _get_boot_mode(node)}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    missing \u003d [key for key in params if params[key] is None]"},{"line_number":241,"context_line":"    if missing:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_3e90e642","line":238,"in_reply_to":"9a80dd14_b63c04c1","updated":"2015-03-05 17:45:25.000000000","message":"Done","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"286fdfa518331b96a6ce890a0cf46409f3d37843","unresolved":false,"context_lines":[{"line_number":235,"context_line":"              \u0027preserve_ephemeral\u0027: i_info[\u0027preserve_ephemeral\u0027],"},{"line_number":236,"context_line":"              \u0027node_uuid\u0027: node.uuid,"},{"line_number":237,"context_line":"              \u0027boot_option\u0027: get_boot_option(node),"},{"line_number":238,"context_line":"              \u0027boot_mode\u0027: _get_boot_mode(node)}"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    missing \u003d [key for key in params if params[key] is None]"},{"line_number":241,"context_line":"    if missing:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a05bd92c","line":238,"in_reply_to":"9a80dd14_b63c04c1","updated":"2015-03-05 17:05:44.000000000","message":"Sadly, doing that also can make pep8 whine about closing brace placement.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"60a424d9a46704ef3bdc7e9e3b195de10a9c7483","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        make_partitions_expected_args \u003d [dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":181,"context_line":"                                         configdrive_mb]"},{"line_number":182,"context_line":"        make_partitions_expected_kwargs \u003d {\u0027commit\u0027: True,"},{"line_number":183,"context_line":"                                           \u0027boot_mode\u0027: \u0027bios\u0027,"},{"line_number":184,"context_line":"                                           \u0027boot_option\u0027: \u0027netboot\u0027}"},{"line_number":185,"context_line":"        deploy_kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_541c9b77","line":182,"updated":"2015-03-05 20:53:23.000000000","message":"nit: I can\u0027t help but think this could be below the two if statements.\n\nSomething like this...\n\n if boot_option is None:\n   boot_option \u003d \u0027netboot\u0027\n make_partitions_expected_kwargs \u003d { \u0027boot_option\u0027: boot_option}\n\nPurely a nit though!","commit_id":"99580569d72b9335ed0dc3bee9b10f1a1963bb07"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"72c8402e7601b5f9616540ef75a7682b1631f090","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        make_partitions_expected_args \u003d [dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":181,"context_line":"                                         configdrive_mb]"},{"line_number":182,"context_line":"        make_partitions_expected_kwargs \u003d {\u0027commit\u0027: True,"},{"line_number":183,"context_line":"                                           \u0027boot_mode\u0027: \u0027bios\u0027,"},{"line_number":184,"context_line":"                                           \u0027boot_option\u0027: \u0027netboot\u0027}"},{"line_number":185,"context_line":"        deploy_kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_92e899e3","line":182,"in_reply_to":"9a80dd14_541c9b77","updated":"2015-03-07 06:59:40.000000000","message":"Done","commit_id":"99580569d72b9335ed0dc3bee9b10f1a1963bb07"}],"ironic/tests/drivers/test_iscsi_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d164f4b3929ba29894f116e1b739a0772a528e07","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                         \u0027disk\u0027: fake_disk,"},{"line_number":357,"context_line":"                         \u0027ironic_api_url\u0027: api_url,"},{"line_number":358,"context_line":"                         \u0027boot_option\u0027: expected_boot_option,"},{"line_number":359,"context_line":"                         \u0027boot_mode\u0027: expected_boot_mode}"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        if expected_root_device:"},{"line_number":362,"context_line":"            expected_opts[\u0027root_device\u0027] \u003d expected_root_device"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_bb078d1c","line":359,"updated":"2015-03-05 16:39:20.000000000","message":"nit: Add trailing comma and put closing brace on new line.  So future patches will only impact one line and not two like this one.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                         \u0027disk\u0027: fake_disk,"},{"line_number":357,"context_line":"                         \u0027ironic_api_url\u0027: api_url,"},{"line_number":358,"context_line":"                         \u0027boot_option\u0027: expected_boot_option,"},{"line_number":359,"context_line":"                         \u0027boot_mode\u0027: expected_boot_mode}"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        if expected_root_device:"},{"line_number":362,"context_line":"            expected_opts[\u0027root_device\u0027] \u003d expected_root_device"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_fead6e89","line":359,"in_reply_to":"9a80dd14_bb078d1c","updated":"2015-03-05 17:45:25.000000000","message":"Done","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"884344efdd63bf6baaffcb91cb475976fd99f2b4","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        mock_unlink.assert_called_once_with(\u0027/path/uuid/disk\u0027)"},{"line_number":340,"context_line":"        mock_rmtree.assert_called_once_with(\u0027/path/uuid\u0027)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _test_build_deploy_ramdisk_options(self, mock_alnum, api_url,"},{"line_number":343,"context_line":"                                           expected_root_device\u003dNone,"},{"line_number":344,"context_line":"                                           expected_boot_option\u003d\u0027netboot\u0027,"},{"line_number":345,"context_line":"                                           expected_boot_mode\u003d\u0027bios\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_4de6f217","line":342,"updated":"2015-03-11 15:30:09.000000000","message":"Not exactly related to this patch.  But is there any reason that mock_alnum could not have the patch decorator here and not on all the other functions?\n\nIt doesn\u0027t seem like the functions use mock_alnum except to pass it to here.","commit_id":"3b44d34de655107dc170c34f54ce313cc8146880"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"d51d651dde9c920d41154b94cd90714e8bea82ad","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        mock_unlink.assert_called_once_with(\u0027/path/uuid/disk\u0027)"},{"line_number":340,"context_line":"        mock_rmtree.assert_called_once_with(\u0027/path/uuid\u0027)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _test_build_deploy_ramdisk_options(self, mock_alnum, api_url,"},{"line_number":343,"context_line":"                                           expected_root_device\u003dNone,"},{"line_number":344,"context_line":"                                           expected_boot_option\u003d\u0027netboot\u0027,"},{"line_number":345,"context_line":"                                           expected_boot_mode\u003d\u0027bios\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_68f564ca","line":342,"in_reply_to":"9a80dd14_4de6f217","updated":"2015-03-11 15:39:05.000000000","message":"yeah, i don\u0027t see any reason too.  it can be mocked only here :)\n\nbut as i said in the other comment, i prefer to keep unrelated changes for another patch.","commit_id":"3b44d34de655107dc170c34f54ce313cc8146880"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d1a8014289475acc7c824dda4a0d3914164ac78c","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        mock_unlink.assert_called_once_with(\u0027/path/uuid/disk\u0027)"},{"line_number":340,"context_line":"        mock_rmtree.assert_called_once_with(\u0027/path/uuid\u0027)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _test_build_deploy_ramdisk_options(self, mock_alnum, api_url,"},{"line_number":343,"context_line":"                                           expected_root_device\u003dNone,"},{"line_number":344,"context_line":"                                           expected_boot_option\u003d\u0027netboot\u0027,"},{"line_number":345,"context_line":"                                           expected_boot_mode\u003d\u0027bios\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_798073bf","line":342,"in_reply_to":"9a80dd14_68f564ca","updated":"2015-03-13 10:55:56.000000000","message":"+1","commit_id":"3b44d34de655107dc170c34f54ce313cc8146880"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d164f4b3929ba29894f116e1b739a0772a528e07","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                            \u0027disk\u0027: \u0027fake-disk\u0027,"},{"line_number":166,"context_line":"                            \u0027ironic_api_url\u0027: \u0027fake-api-url\u0027,"},{"line_number":167,"context_line":"                            \u0027boot_option\u0027: \u0027netboot\u0027,"},{"line_number":168,"context_line":"                            \u0027boot_mode\u0027: \u0027bios\u0027}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        deploy_opts_mock.return_value \u003d fake_deploy_opts"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_bb206db1","line":168,"updated":"2015-03-05 16:39:20.000000000","message":"nit: Add trailing comma and put closing brace on new line.  So future patches will only impact one line and not two like this one.","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ac696a41966f05bfc5a400a55e71d8f363f51824","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                            \u0027disk\u0027: \u0027fake-disk\u0027,"},{"line_number":166,"context_line":"                            \u0027ironic_api_url\u0027: \u0027fake-api-url\u0027,"},{"line_number":167,"context_line":"                            \u0027boot_option\u0027: \u0027netboot\u0027,"},{"line_number":168,"context_line":"                            \u0027boot_mode\u0027: \u0027bios\u0027}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        deploy_opts_mock.return_value \u003d fake_deploy_opts"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_9eb472d2","line":168,"in_reply_to":"9a80dd14_bb206db1","updated":"2015-03-05 17:45:25.000000000","message":"Done","commit_id":"b9a8d775ee63cadd3164ffea9fc44fddaa0f2cfc"}]}
