)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85e091c142eb1c790f518d0c11589886a17a1a00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Josh Gachnang \u003cjosh@pcsforeducation.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-02 17:48:14 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nits in cleaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia881ab68eadc68c0446f6e4653d54912fb1feeac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_fb1374fe","line":7,"updated":"2015-03-03 14:24:17.000000000","message":"Josh, were the nits mentioned in some other patch? If so, might be good to put a link to that.","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"c0bb3256bbf376a23ed52d2f551ea3b65dabde7c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Josh Gachnang \u003cjosh@pcsforeducation.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-02 17:48:14 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nits in cleaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia881ab68eadc68c0446f6e4653d54912fb1feeac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_adb37498","line":7,"in_reply_to":"ba7be1f8_fb1374fe","updated":"2015-03-03 21:07:35.000000000","message":"Done","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4da7fd46d3d4d9777ad52369b277e660b2c2787e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nits in cleaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nits in https://review.openstack.org/#/c/157208/ and"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/153444/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia881ab68eadc68c0446f6e4653d54912fb1feeac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_06908feb","line":9,"updated":"2015-03-04 10:55:47.000000000","message":"It would be nice if we put the Change-Id or the git commit ID here because then it will able to search for previous commit by git log itself.   If we put the review link, developer will need to check online with the internet.","commit_id":"edee2afcb80f991f022fd8177bfe56c4ae496f16"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"daaab848057f0dbff0b83391a1744c33482779e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nits in cleaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nits in https://review.openstack.org/#/c/157208/ and"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/153444/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia881ab68eadc68c0446f6e4653d54912fb1feeac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_640a23d4","line":9,"in_reply_to":"9a80dd14_06908feb","updated":"2015-03-04 11:37:17.000000000","message":"+1\n\nI use the git hash, so that I can do a git show \u003chash\u003e locally, or just click on the link in gerrit :) work both ways","commit_id":"edee2afcb80f991f022fd8177bfe56c4ae496f16"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"259b8594c256d24b7fe2fd310c4b9e7c8cfd2e61","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nits in cleaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nits in https://review.openstack.org/#/c/157208/ and"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/153444/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia881ab68eadc68c0446f6e4653d54912fb1feeac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_6c883823","line":9,"in_reply_to":"9a80dd14_640a23d4","updated":"2015-03-04 19:16:25.000000000","message":"Ahh, I did links to reviews because the nits were all comments. I\u0027ll add the git hash as well.","commit_id":"edee2afcb80f991f022fd8177bfe56c4ae496f16"}],"ironic/conductor/manager.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ded221d1bd2173420067958eb5e5003135ab7a92","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            task.driver.power.validate(task)"},{"line_number":797,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":798,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":799,"context_line":"            node.last_error \u003d (_(\u0027Failed to validate power driver interface. \u0027"},{"line_number":800,"context_line":"                                 \u0027Can not clean instance. Error: %(msg)s\u0027),"},{"line_number":801,"context_line":"                               {\u0027msg\u0027: e})"},{"line_number":802,"context_line":"            task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_24298737","line":799,"updated":"2015-03-03 02:36:32.000000000","message":"Does this work ?\n\n  \u003e\u003e\u003e from ironic.common.i18n import _\n  \u003e\u003e\u003e e \u003d \"foo\"\n  \u003e\u003e\u003e error \u003d (_(\u0027Failed to validate power driver interface. Can not clean instance. Error: %(msg)s\u0027), {\u0027msg\u0027: e})\n  \u003e\u003e\u003e error\n  (u\u0027Failed to validate power driver interface. Can not clean instance. Error: %(msg)s\u0027, {\u0027msg\u0027: \u0027foo\u0027}) \n\nI think it has to be like:\n\n  \u003e\u003e\u003e error \u003d _(\u0027Failed to validate power driver interface. Can not clean instance. Error: %(msg)s\u0027 % {\u0027msg\u0027: e})\n  \u003e\u003e\u003e error\n  u\u0027Failed to validate power driver interface. Can not clean instance. Error: foo\u0027","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85e091c142eb1c790f518d0c11589886a17a1a00","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            task.driver.power.validate(task)"},{"line_number":797,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":798,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":799,"context_line":"            node.last_error \u003d (_(\u0027Failed to validate power driver interface. \u0027"},{"line_number":800,"context_line":"                                 \u0027Can not clean instance. Error: %(msg)s\u0027),"},{"line_number":801,"context_line":"                               {\u0027msg\u0027: e})"},{"line_number":802,"context_line":"            task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_9b77d8d3","line":799,"in_reply_to":"ba7be1f8_24298737","updated":"2015-03-03 14:24:17.000000000","message":"No, it shouldn\u0027t work. The string has to be interpolated. With logging, we can pass the arguments in so that the string interpolation is done later (or not done at all).","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"c0bb3256bbf376a23ed52d2f551ea3b65dabde7c","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            task.driver.power.validate(task)"},{"line_number":797,"context_line":"        except (exception.InvalidParameterValue,"},{"line_number":798,"context_line":"                exception.MissingParameterValue) as e:"},{"line_number":799,"context_line":"            node.last_error \u003d (_(\u0027Failed to validate power driver interface. \u0027"},{"line_number":800,"context_line":"                                 \u0027Can not clean instance. Error: %(msg)s\u0027),"},{"line_number":801,"context_line":"                               {\u0027msg\u0027: e})"},{"line_number":802,"context_line":"            task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f2a0df91","line":799,"in_reply_to":"ba7be1f8_9b77d8d3","updated":"2015-03-03 21:07:35.000000000","message":"Done","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"}],"ironic/drivers/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"85e091c142eb1c790f518d0c11589886a17a1a00","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return self.clean_steps"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def execute_clean_step(self, task, step):"},{"line_number":153,"context_line":"        \"\"\"Execute a the clean step on task.node."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        Clean steps should take a single argument: a TaskManager object."},{"line_number":156,"context_line":"        Steps can be executed synchronously or asynchronously. Steps should"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_bbcbbc70","line":153,"updated":"2015-03-03 14:24:17.000000000","message":"if you\u0027re fixing nits anyway... s/a //","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"c0bb3256bbf376a23ed52d2f551ea3b65dabde7c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return self.clean_steps"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def execute_clean_step(self, task, step):"},{"line_number":153,"context_line":"        \"\"\"Execute a the clean step on task.node."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        Clean steps should take a single argument: a TaskManager object."},{"line_number":156,"context_line":"        Steps can be executed synchronously or asynchronously. Steps should"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_0d8720b6","line":153,"in_reply_to":"ba7be1f8_bbcbbc70","updated":"2015-03-03 21:07:35.000000000","message":"Done","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"47b7c878d377e60c63fbfb43451f203e3935c3e1","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param task: A TaskManager object"},{"line_number":164,"context_line":"        :param step: A CleanStep object to execute"},{"line_number":165,"context_line":"        :returns: None if the method is complete, or states.CLEANING if"},{"line_number":166,"context_line":"            the step will continue to execute asynchronously."},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        return getattr(self, step.get(\u0027step\u0027))(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_091e5e5f","line":165,"updated":"2015-03-03 01:55:01.000000000","message":"if we\u0027re going to modify this, I think we could improve the expressiveness of this docstring.  How about the following?\n\n:returns: None if this method has completed synchronously, or states.CLEANING if the step will continue to execute asynchronously.\n\nor \n\n:returns: None if this clean step has completed synchronously, or states.CLEANING if it will continue to execute asynchronously.","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"ded221d1bd2173420067958eb5e5003135ab7a92","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param task: A TaskManager object"},{"line_number":164,"context_line":"        :param step: A CleanStep object to execute"},{"line_number":165,"context_line":"        :returns: None if the method is complete, or states.CLEANING if"},{"line_number":166,"context_line":"            the step will continue to execute asynchronously."},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        return getattr(self, step.get(\u0027step\u0027))(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6470df72","line":165,"in_reply_to":"ba7be1f8_091e5e5f","updated":"2015-03-03 02:36:32.000000000","message":"+1 for the first. :)","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"c0bb3256bbf376a23ed52d2f551ea3b65dabde7c","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param task: A TaskManager object"},{"line_number":164,"context_line":"        :param step: A CleanStep object to execute"},{"line_number":165,"context_line":"        :returns: None if the method is complete, or states.CLEANING if"},{"line_number":166,"context_line":"            the step will continue to execute asynchronously."},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        return getattr(self, step.get(\u0027step\u0027))(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4d8d98d2","line":165,"in_reply_to":"ba7be1f8_6470df72","updated":"2015-03-03 21:07:35.000000000","message":"Done","commit_id":"72b9d548b90a59457dbde8071773d145c4981af3"}]}
