)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"207f01c08a9e510f9503e6ff4088f0f0f2f281cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladyslav Drok \u003cvdrok@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-03 12:50:31 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments on Iec8e1f862d29639363b71c67d60e711d35d2ed94"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Addresses some comments that were posted on last patch set."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_893eb589","line":7,"updated":"2015-03-03 14:03:28.000000000","message":"Better \"Fix nits for supporting non-glance images\"\n\nGerrit ID\u0027s are nice in Gerrit UI, but useless in git log","commit_id":"cb85325250bdd6e673c665d56b76206b439f4044"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52bf6e909008a5d07df846dac408e7c4b3cce2e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix nits for supporting non-glance images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Addresses some comments that were posted on last patch set."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Idf35eb1a603714973dd0522f8e1207c8894f349b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_263dec2b","line":9,"updated":"2015-03-03 16:21:03.000000000","message":"What patch set was that? Please provide the change-id of it so I can reference it.","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"}],"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"207f01c08a9e510f9503e6ff4088f0f0f2f281cc","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"    ironic node-update $NODE_UUID add instance_info/image_checksum\u003d$MD5HASH"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"   When local boot support for drivers that use PXE deploy is ready, you will"},{"line_number":1099,"context_line":"   be able omit kernel and ramdisk fields if you specify ``boot_option\u003dlocal``"},{"line_number":1100,"context_line":"   in node\u0027s ``instance_info/capabilities``."},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"#. Validate that all parameters are correct::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba7be1f8_a9a7f909","line":1099,"updated":"2015-03-03 14:03:28.000000000","message":"nit: \"be able to omit\"","commit_id":"cb85325250bdd6e673c665d56b76206b439f4044"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52bf6e909008a5d07df846dac408e7c4b3cce2e5","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      It will work with PXE boot without any manual config editing, as all the"},{"line_number":1012,"context_line":"      DHCP options needed for it remain the same after switching PXE"},{"line_number":1013,"context_line":"      configuration to use instance images when deployment is done."},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"If you don\u0027t use Glance, it\u0027s possible to provide images to Ironic via hrefs."},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_e6e914b8","line":1013,"updated":"2015-03-03 16:21:03.000000000","message":"nits. It isn\u0027t clear what \u0027it\u0027 means, and I don\u0027t think both uses of \u0027it\u0027 refer to the same thing.\n\nI think the first \u0027it\u0027 \u003d\u003d disabling Neutron; second \u0027it\u0027 \u003d\u003d pxe booting?","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52bf6e909008a5d07df846dac408e7c4b3cce2e5","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    ironic node-update $NODE_UUID add instance_info/image_checksum\u003d$MD5HASH"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"   When local boot support for drivers that use PXE deploy is ready, you will"},{"line_number":1099,"context_line":"   be able to omit kernel and ramdisk fields if you specify"},{"line_number":1100,"context_line":"   ``boot_option\u003dlocal`` in node\u0027s ``instance_info/capabilities``."},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_66ec44bc","line":1098,"updated":"2015-03-03 16:21:03.000000000","message":"What do you mean by \u0027is ready\u0027?","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9120ea16d0334bd9b80e26329b7e557e9a35e6b","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    ironic node-update $NODE_UUID add instance_info/image_checksum\u003d$MD5HASH"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"   When local boot support for drivers that use PXE deploy is ready, you will"},{"line_number":1099,"context_line":"   be able to omit kernel and ramdisk fields if you specify"},{"line_number":1100,"context_line":"   ``boot_option\u003dlocal`` in node\u0027s ``instance_info/capabilities``."},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_8f278bb5","line":1098,"in_reply_to":"ba7be1f8_49c1132e","updated":"2015-03-03 16:59:56.000000000","message":"Oh. This seems confusing. I think we should only update this when it is valid. Otherwise, how is someone going to know when it \u0027is ready\u0027 or not?","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0b5d9af4d41da9d2397c63debae84792adf9ba92","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    ironic node-update $NODE_UUID add instance_info/image_checksum\u003d$MD5HASH"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"   When local boot support for drivers that use PXE deploy is ready, you will"},{"line_number":1099,"context_line":"   be able to omit kernel and ramdisk fields if you specify"},{"line_number":1100,"context_line":"   ``boot_option\u003dlocal`` in node\u0027s ``instance_info/capabilities``."},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_49c1132e","line":1098,"in_reply_to":"ba7be1f8_66ec44bc","updated":"2015-03-03 16:43:55.000000000","message":"Yes, I don\u0027t know if I should include it here, at the moment you still have to specify kernel and ramdisk when doing local boot. https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L425-L426","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3fc7f78f081017d6f028c0e0cc3413d6804cd8f2","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    ironic node-update $NODE_UUID add instance_info/image_checksum\u003d$MD5HASH"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"   When local boot support for drivers that use PXE deploy is ready, you will"},{"line_number":1099,"context_line":"   be able to omit kernel and ramdisk fields if you specify"},{"line_number":1100,"context_line":"   ``boot_option\u003dlocal`` in node\u0027s ``instance_info/capabilities``."},{"line_number":1101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_4fee73ee","line":1098,"in_reply_to":"ba7be1f8_8f278bb5","updated":"2015-03-03 17:02:57.000000000","message":"Done","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a68414daeb245f2d44b14853844fea30346f93f0","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    dhcp_provider\u003dnone"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      After disabling Neutron PXE boot will still work without any manual"},{"line_number":1012,"context_line":"      config editing, as all the DHCP options needed for PXE booting remain the"},{"line_number":1013,"context_line":"      same after switching PXE configuration to use instance images when"},{"line_number":1014,"context_line":"      deployment is done."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_6ca4254b","line":1011,"updated":"2015-03-03 17:00:04.000000000","message":"nit, comma after \u0027Neutron\u0027.","commit_id":"a5c9234658dd240dc1c544c19c3741d6b077c6e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"731068011d1f6f6a5e495445ba4ed76fdb4ac2ab","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    dhcp_provider\u003dnone"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      After disabling Neutron PXE boot will still work without any manual"},{"line_number":1012,"context_line":"      config editing, as all the DHCP options needed for PXE booting remain the"},{"line_number":1013,"context_line":"      same after switching PXE configuration to use instance images when"},{"line_number":1014,"context_line":"      deployment is done."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba7be1f8_8fd4eb20","line":1011,"in_reply_to":"ba7be1f8_6ca4254b","updated":"2015-03-03 17:04:13.000000000","message":"Done","commit_id":"a5c9234658dd240dc1c544c19c3741d6b077c6e2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fbb0740f888fe1de929b755b509f0595a3d0b4c7","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    dhcp_provider\u003dnone"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      If there are no two conductors that support the same driver, you can"},{"line_number":1012,"context_line":"      configure your network so that after disabling Neutron, PXE boot will"},{"line_number":1013,"context_line":"      still work without any manual config editing, as all the DHCP options"},{"line_number":1014,"context_line":"      needed for PXE booting remain the same after switching PXE configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_462e558d","line":1011,"updated":"2015-03-03 19:36:21.000000000","message":"how about \u0027If a driver is supported by at most one conductor, you can ...\u0027\n\nThis becomes a really long sentence.\n\nWhat do you mean by \u0027you can configure your network\u0027 -- they can, or they should? And you you mean that the network needs to be configured so that PXE booting etc will work?","commit_id":"c99fc7774d7f803c1e14c04603cfc4bb394a0db2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ffed8b3c61e595d0ac3bcc92e28c41e9c0fcf000","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    dhcp_provider\u003dnone"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      If there are no two conductors that support the same driver, you can"},{"line_number":1012,"context_line":"      configure your network so that after disabling Neutron, PXE boot will"},{"line_number":1013,"context_line":"      still work without any manual config editing, as all the DHCP options"},{"line_number":1014,"context_line":"      needed for PXE booting remain the same after switching PXE configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a80dd14_c9504861","line":1011,"in_reply_to":"ba7be1f8_462e558d","updated":"2015-03-04 11:24:11.000000000","message":"Done","commit_id":"c99fc7774d7f803c1e14c04603cfc4bb394a0db2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fbb0740f888fe1de929b755b509f0595a3d0b4c7","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"      configure your network so that after disabling Neutron, PXE boot will"},{"line_number":1013,"context_line":"      still work without any manual config editing, as all the DHCP options"},{"line_number":1014,"context_line":"      needed for PXE booting remain the same after switching PXE configuration"},{"line_number":1015,"context_line":"      to use instance images when deployment is done. If it\u0027s not the case,"},{"line_number":1016,"context_line":"      then for each node you\u0027ll need to specify tftp-server that it\u0027s going to"},{"line_number":1017,"context_line":"      use, as it\u0027s unknown beforehand to which conductor the node will be"},{"line_number":1018,"context_line":"      mapped to."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba7be1f8_662d1946","line":1015,"updated":"2015-03-03 19:36:21.000000000","message":"Might want to be more explicit here about what \u0027the case\u0027 is. Eg:\n\nHowever, if a driver is supported by two or more conductors, the following must also be done if Neutron is disabled. For each node, you\u0027ll need to specify the tftp-server (how?) ...","commit_id":"c99fc7774d7f803c1e14c04603cfc4bb394a0db2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ffed8b3c61e595d0ac3bcc92e28c41e9c0fcf000","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"      configure your network so that after disabling Neutron, PXE boot will"},{"line_number":1013,"context_line":"      still work without any manual config editing, as all the DHCP options"},{"line_number":1014,"context_line":"      needed for PXE booting remain the same after switching PXE configuration"},{"line_number":1015,"context_line":"      to use instance images when deployment is done. If it\u0027s not the case,"},{"line_number":1016,"context_line":"      then for each node you\u0027ll need to specify tftp-server that it\u0027s going to"},{"line_number":1017,"context_line":"      use, as it\u0027s unknown beforehand to which conductor the node will be"},{"line_number":1018,"context_line":"      mapped to."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a80dd14_0955001d","line":1015,"in_reply_to":"ba7be1f8_662d1946","updated":"2015-03-04 11:24:11.000000000","message":"I changed this part, as I think manual configuration in this case would be very inconvenient (something like start deployment - fail - determine which conductor node is mapped to - change tftp server in dhcp config - rebuild; same problems after takeover)","commit_id":"c99fc7774d7f803c1e14c04603cfc4bb394a0db2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9f21350fc6a0e1caa67f0187762daa99f2d49246","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    dhcp_provider\u003dnone"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      If you disabled Neutron and diver that you use is supported by at most"},{"line_number":1012,"context_line":"      one conductor, PXE boot will still work for your nodes without any"},{"line_number":1013,"context_line":"      manual config editing. This is beacause you know all the DHCP options"},{"line_number":1014,"context_line":"      that will be used for deployment and can set up your DHCP server"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_828d4234","line":1011,"updated":"2015-03-04 14:58:33.000000000","message":"s/diver/the driver/","commit_id":"90ed361b6496813f4c6952cd69c7dfd00a2b1839"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9f21350fc6a0e1caa67f0187762daa99f2d49246","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      If you disabled Neutron and diver that you use is supported by at most"},{"line_number":1012,"context_line":"      one conductor, PXE boot will still work for your nodes without any"},{"line_number":1013,"context_line":"      manual config editing. This is beacause you know all the DHCP options"},{"line_number":1014,"context_line":"      that will be used for deployment and can set up your DHCP server"},{"line_number":1015,"context_line":"      appropriately."},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_e27b5e27","line":1013,"updated":"2015-03-04 14:58:33.000000000","message":"s/beacause/because/","commit_id":"90ed361b6496813f4c6952cd69c7dfd00a2b1839"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9f21350fc6a0e1caa67f0187762daa99f2d49246","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"      that will be used for deployment and can set up your DHCP server"},{"line_number":1015,"context_line":"      appropriately."},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"      If you have multiple conductors per driver, you\u0027d better use Neutron, it"},{"line_number":1018,"context_line":"      will do all dynamically changing configuration for you."},{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"If you don\u0027t use Glance, it\u0027s possible to provide images to Ironic via hrefs."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_02ff9235","line":1017,"updated":"2015-03-04 14:58:33.000000000","message":"how about \u0027..., it would be better to use Neutron since it will do all the dynamically changing configurations for you\u0027.","commit_id":"90ed361b6496813f4c6952cd69c7dfd00a2b1839"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6c2dc44a19fdd387833482f9a0cf1b13ebcd0081","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"    dhcp_provider\u003dnone"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"   .. note::"},{"line_number":1011,"context_line":"      If you disabled Neutron and driver that you use is supported by at most"},{"line_number":1012,"context_line":"      one conductor, PXE boot will still work for your nodes without any"},{"line_number":1013,"context_line":"      manual config editing. This is because you know all the DHCP options"},{"line_number":1014,"context_line":"      that will be used for deployment and can set up your DHCP server"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a80dd14_c5b65f8a","line":1011,"updated":"2015-03-04 16:36:45.000000000","message":"nit: s/driver/the driver/","commit_id":"69963c14ddfbf3364b1639526896fa2ce034b881"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"52bf6e909008a5d07df846dac408e7c4b3cce2e5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            except exception.ImageRefValidationFailed:"},{"line_number":109,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":110,"context_line":"                    LOG.error(_LE(\"Virtual media deploy accepts only Glance \""},{"line_number":111,"context_line":"                                  \"images or HTTP(S) URLs as \u0027ilo_boot_iso\u0027. \""},{"line_number":112,"context_line":"                                  \"Either %s is not a valid HTTP(S) URL or is \""},{"line_number":113,"context_line":"                                  \"not reachable.\"), boot_iso)"},{"line_number":114,"context_line":"        return task.node.instance_info[\u0027ilo_boot_iso\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_e6283435","line":111,"updated":"2015-03-03 16:21:03.000000000","message":"would it be clearer as instance_info[\u0027ilo_boot_iso\u0027]?","commit_id":"29c0d77f780c2101cc2e4c8c94c88618425565ff"}]}