)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"289b77afb21a6e1cc9bd60dd90be65e813716f0d","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        :raises: InvalidParameterValue, if any of the parameters have invalid"},{"line_number":520,"context_line":"            value."},{"line_number":521,"context_line":"        \"\"\""},{"line_number":522,"context_line":"        if method \u003d\u003d \u0027pass_deploy_info\u0027:"},{"line_number":523,"context_line":"            iscsi_deploy.get_deploy_info(task.node, **kwargs)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def _configure_vmedia_boot(self, task, root_uuid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_db68e589","line":522,"updated":"2015-03-11 12:11:10.000000000","message":"This addition seems to be not tested.","commit_id":"9f3c0dbb6ea673dd80d9293e91015cc1304bd130"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"26fa0a49a5557415878b2debcb0d970b49e7aec5","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        :raises: InvalidParameterValue, if any of the parameters have invalid"},{"line_number":520,"context_line":"            value."},{"line_number":521,"context_line":"        \"\"\""},{"line_number":522,"context_line":"        if method \u003d\u003d \u0027pass_deploy_info\u0027:"},{"line_number":523,"context_line":"            iscsi_deploy.get_deploy_info(task.node, **kwargs)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def _configure_vmedia_boot(self, task, root_uuid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f194d345","line":522,"in_reply_to":"9a80dd14_db68e589","updated":"2015-03-11 19:54:33.000000000","message":"Done","commit_id":"9f3c0dbb6ea673dd80d9293e91015cc1304bd130"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"63ed4588a4e8b6df189e468186ec35966c2a81ba","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        super(IloPXEVendorPassthru, self)._continue_deploy(task, **kwargs)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"class VendorPassthru(agent_base_vendor.BaseAgentVendor):"},{"line_number":506,"context_line":"    \"\"\"Vendor-specific interfaces for iLO deploy drivers.\"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_052df38e","line":505,"updated":"2015-03-16 16:22:33.000000000","message":"why switch the base class?\n\nthis will affect the IloVirtualMediaIscsiDriver class, when the IloVirtualMediaAgentDriver is already using the agent\u0027s vendor interface.","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa1932210d114d4cd817e1de5cd23ad53f1563b0","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        super(IloPXEVendorPassthru, self)._continue_deploy(task, **kwargs)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"class VendorPassthru(agent_base_vendor.BaseAgentVendor):"},{"line_number":506,"context_line":"    \"\"\"Vendor-specific interfaces for iLO deploy drivers.\"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a073357e","line":505,"in_reply_to":"9a80dd14_052df38e","updated":"2015-03-16 16:34:17.000000000","message":"Ah, I misunderstood -- this makes sense now.","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b03f1369c62c0c29b1222a1752391f8b47780f96","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        super(IloPXEVendorPassthru, self)._continue_deploy(task, **kwargs)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"class VendorPassthru(agent_base_vendor.BaseAgentVendor):"},{"line_number":506,"context_line":"    \"\"\"Vendor-specific interfaces for iLO deploy drivers.\"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_a5550751","line":505,"in_reply_to":"9a80dd14_052df38e","updated":"2015-03-16 16:34:15.000000000","message":"This allows IloVirtualMediaIscsiDriver to do iSCSI with the IPA ramdisk, like we did for pxe_*","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"63ed4588a4e8b6df189e468186ec35966c2a81ba","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":596,"context_line":"    def continue_deploy(self, task, **kwargs):"},{"line_number":597,"context_line":"        \"\"\"Method invoked when deployed with the IPA ramdisk."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        This method is invoked during a heartbeat from an agent when"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_05133301","line":596,"updated":"2015-03-16 16:22:33.000000000","message":"having a method named \u0027continue_deploy\u0027 that is not exposed to the vendor interface AND is unrelated to the method \u0027_continue_deploy\u0027 (which is exposed) -- this is very confusing ... can you clean this up?","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b03f1369c62c0c29b1222a1752391f8b47780f96","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":596,"context_line":"    def continue_deploy(self, task, **kwargs):"},{"line_number":597,"context_line":"        \"\"\"Method invoked when deployed with the IPA ramdisk."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        This method is invoked during a heartbeat from an agent when"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_858483d3","line":596,"in_reply_to":"9a80dd14_05133301","updated":"2015-03-16 16:34:15.000000000","message":"This is exposed in the base class.","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"fa1932210d114d4cd817e1de5cd23ad53f1563b0","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":596,"context_line":"    def continue_deploy(self, task, **kwargs):"},{"line_number":597,"context_line":"        \"\"\"Method invoked when deployed with the IPA ramdisk."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        This method is invoked during a heartbeat from an agent when"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e017edeb","line":596,"in_reply_to":"9a80dd14_05133301","updated":"2015-03-16 16:34:17.000000000","message":"still weird to have these two different methods with almost the same name. I\u0027ll not -1 this patch for it, but I would like to see a follow-on patch that fixes this is both classes that now duplicate this method name","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2f89265bd8f856ec4555c34ba9814840f954989b","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        else:"},{"line_number":620,"context_line":"            # Agent vendorpassthru are made without auth token."},{"line_number":621,"context_line":"            # We require auth_token to talk to glance while building boot iso."},{"line_number":622,"context_line":"            task.context.auth_token \u003d keystone.get_admin_auth_token()"},{"line_number":623,"context_line":"            self._configure_vmedia_boot(task, root_uuid)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        self.reboot_and_finish_deploy(task)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_603f7d87","line":622,"updated":"2015-03-16 16:34:44.000000000","message":"I think we should be checking auth_strategy conf setting here. We could be set to noauth. https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L203","commit_id":"9ff84accee42c5e50ba2be359fa320b239dceb7a"}]}