)]}'
{"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3917eb492641adb9a78a77b151ab72a165a4100f","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate\u0027)"},{"line_number":249,"context_line":"    def _test_validate(self, validate_mock, deploy_info_mock,"},{"line_number":250,"context_line":"                       validate_prop_mock, validate_boot_mode_mock,"},{"line_number":251,"context_line":"                       props_expected):"},{"line_number":252,"context_line":"        d_info \u003d {\u0027image_source\u0027: \u0027uuid\u0027}"},{"line_number":253,"context_line":"        deploy_info_mock.return_value \u003d d_info"},{"line_number":254,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8aa79e4f","line":251,"updated":"2015-03-13 00:26:04.000000000","message":"Am I missing something here.  It doesn\u0027t seem like props_expected is used.","commit_id":"2cbaf290ec6c3056d9545cd8216f8ad3fe9b4e21"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"086c7dcb26256d43d779d005074a2944cef20aee","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate\u0027)"},{"line_number":249,"context_line":"    def _test_validate(self, validate_mock, deploy_info_mock,"},{"line_number":250,"context_line":"                       validate_prop_mock, validate_boot_mode_mock,"},{"line_number":251,"context_line":"                       props_expected):"},{"line_number":252,"context_line":"        d_info \u003d {\u0027image_source\u0027: \u0027uuid\u0027}"},{"line_number":253,"context_line":"        deploy_info_mock.return_value \u003d d_info"},{"line_number":254,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_05072119","line":251,"in_reply_to":"9a80dd14_8aa79e4f","updated":"2015-03-13 01:25:14.000000000","message":"Thanks a lot for pointing it out. I think I implemented things only partially.","commit_id":"2cbaf290ec6c3056d9545cd8216f8ad3fe9b4e21"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3917eb492641adb9a78a77b151ab72a165a4100f","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            validate_boot_mode_mock.assert_called_once_with(task.node)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_validate_partition_image(self):"},{"line_number":264,"context_line":"        self._test_validate(props_expected\u003d[\u0027kernel_id\u0027, \u0027ramdisk_id\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def test_validate_whole_disk_image(self):"},{"line_number":267,"context_line":"        self._test_validate(props_expected\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8a7ebead","line":264,"updated":"2015-03-13 00:26:04.000000000","message":"I don\u0027t understand these tests.","commit_id":"2cbaf290ec6c3056d9545cd8216f8ad3fe9b4e21"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"086c7dcb26256d43d779d005074a2944cef20aee","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            validate_boot_mode_mock.assert_called_once_with(task.node)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_validate_partition_image(self):"},{"line_number":264,"context_line":"        self._test_validate(props_expected\u003d[\u0027kernel_id\u0027, \u0027ramdisk_id\u0027])"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def test_validate_whole_disk_image(self):"},{"line_number":267,"context_line":"        self._test_validate(props_expected\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_851a316d","line":264,"in_reply_to":"9a80dd14_8a7ebead","updated":"2015-03-13 01:25:14.000000000","message":"Thanks a lot for pointing it out. I think I implemented things only partially.","commit_id":"2cbaf290ec6c3056d9545cd8216f8ad3fe9b4e21"}]}