)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"143de747e7e70b7bfaa3a0cbfe85c56b9c604833","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        return"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    # Find invalid hints for logging"},{"line_number":377,"context_line":"    invalid_hints \u003d set(root_device) - set(VALID_ROOT_DEVICE)"},{"line_number":378,"context_line":"    if invalid_hints:"},{"line_number":379,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":380,"context_line":"            _(\u0027The following hints: \"%(invalid_hints)s\" are invalid. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_5d074d1d","line":377,"updated":"2015-03-12 14:09:26.000000000","message":"You can define VALID_ROOT_DEVICE as set in l76.","commit_id":"ee4e13e33ff9d41c0c6e333b9d193d31512dd481"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"9d1c73b5cabe95922f9773e31e5e65d553dd8f4d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"CONF \u003d cfg.CONF"},{"line_number":74,"context_line":"CONF.register_opts(pxe_opts, group\u003d\u0027pxe\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"VALID_ROOT_DEVICE \u003d set((\u0027size\u0027, \u0027model\u0027, \u0027wwn\u0027, \u0027serial\u0027, \u0027vendor\u0027))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"@image_cache.cleanup(priority\u003d50)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_a85c537e","line":76,"updated":"2015-03-13 12:49:01.000000000","message":"s/VALID_ROOT_DEVICE/VALID_ROOT_DEVICE_HINTS","commit_id":"b6fd95e9de89c3c9b45e8eace68cd8420069bd16"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3fed93828d7916d2b86c1e6454aae9d132493ebd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"CONF \u003d cfg.CONF"},{"line_number":74,"context_line":"CONF.register_opts(pxe_opts, group\u003d\u0027pxe\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"VALID_ROOT_DEVICE \u003d set((\u0027size\u0027, \u0027model\u0027, \u0027wwn\u0027, \u0027serial\u0027, \u0027vendor\u0027))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"@image_cache.cleanup(priority\u003d50)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_3f31765a","line":76,"in_reply_to":"9a80dd14_a85c537e","updated":"2015-03-13 13:27:14.000000000","message":"Done","commit_id":"b6fd95e9de89c3c9b45e8eace68cd8420069bd16"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"9d1c73b5cabe95922f9773e31e5e65d553dd8f4d","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    invalid_hints \u003d set(root_device) - VALID_ROOT_DEVICE"},{"line_number":378,"context_line":"    if invalid_hints:"},{"line_number":379,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":380,"context_line":"            _(\u0027The following hints: \"%(invalid_hints)s\" are invalid. \u0027"},{"line_number":381,"context_line":"              \u0027Valid hints are: \"%(valid_hints)s\"\u0027) %"},{"line_number":382,"context_line":"            {\u0027invalid_hints\u0027: \u0027, \u0027.join(invalid_hints),"},{"line_number":383,"context_line":"             \u0027valid_hints\u0027: \u0027, \u0027.join(VALID_ROOT_DEVICE)})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_11b85ee4","line":380,"updated":"2015-03-13 12:49:01.000000000","message":"i guess : is not required. May be\n\n  _(\u0027The hints \"%(invalid_hints)s\" are invalid. \u0027)","commit_id":"b6fd95e9de89c3c9b45e8eace68cd8420069bd16"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3fed93828d7916d2b86c1e6454aae9d132493ebd","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    invalid_hints \u003d set(root_device) - VALID_ROOT_DEVICE"},{"line_number":378,"context_line":"    if invalid_hints:"},{"line_number":379,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":380,"context_line":"            _(\u0027The following hints: \"%(invalid_hints)s\" are invalid. \u0027"},{"line_number":381,"context_line":"              \u0027Valid hints are: \"%(valid_hints)s\"\u0027) %"},{"line_number":382,"context_line":"            {\u0027invalid_hints\u0027: \u0027, \u0027.join(invalid_hints),"},{"line_number":383,"context_line":"             \u0027valid_hints\u0027: \u0027, \u0027.join(VALID_ROOT_DEVICE)})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ffeb5ea1","line":380,"in_reply_to":"9a80dd14_11b85ee4","updated":"2015-03-13 13:27:14.000000000","message":"Done","commit_id":"b6fd95e9de89c3c9b45e8eace68cd8420069bd16"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2ff07295aa01b9a9f61623de0d72a5be31bf56b1","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            _(\u0027The hints \"%(invalid_hints)s\" are invalid. \u0027"},{"line_number":403,"context_line":"              \u0027Valid hints are: \"%(valid_hints)s\"\u0027) %"},{"line_number":404,"context_line":"            {\u0027invalid_hints\u0027: \u0027, \u0027.join(invalid_hints),"},{"line_number":405,"context_line":"             \u0027valid_hints\u0027: \u0027, \u0027.join(VALID_ROOT_DEVICE_HINTS)})"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    if \u0027size\u0027 in root_device:"},{"line_number":408,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_b83d6adf","line":405,"updated":"2015-03-13 19:49:18.000000000","message":"Nit: would be nice to have node.uuid here.","commit_id":"1eb724138fe2c4a34f87ccd887d18cdbee7a98c5"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"cbf3d3a5ef1b713437139da502c4322d4a4f01f3","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            _(\u0027The hints \"%(invalid_hints)s\" are invalid. \u0027"},{"line_number":403,"context_line":"              \u0027Valid hints are: \"%(valid_hints)s\"\u0027) %"},{"line_number":404,"context_line":"            {\u0027invalid_hints\u0027: \u0027, \u0027.join(invalid_hints),"},{"line_number":405,"context_line":"             \u0027valid_hints\u0027: \u0027, \u0027.join(VALID_ROOT_DEVICE_HINTS)})"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    if \u0027size\u0027 in root_device:"},{"line_number":408,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_8e5bfb52","line":405,"in_reply_to":"9a80dd14_b83d6adf","updated":"2015-03-13 23:09:08.000000000","message":"if I\u0027m reading correctly, these should bubble up through driver.deploy.validate(), making them visible in association with the node uuid already.\n\nso I think adding it to the message will be duplicative.","commit_id":"1eb724138fe2c4a34f87ccd887d18cdbee7a98c5"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2ff07295aa01b9a9f61623de0d72a5be31bf56b1","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            int(root_device[\u0027size\u0027])"},{"line_number":410,"context_line":"        except ValueError:"},{"line_number":411,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":412,"context_line":"                _(\u0027Root device hint \"size\" is not an integer value.\u0027))"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    hints \u003d []"},{"line_number":415,"context_line":"    for key, value in root_device.items():"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_182cb6ab","line":412,"updated":"2015-03-13 19:49:18.000000000","message":"ditto","commit_id":"1eb724138fe2c4a34f87ccd887d18cdbee7a98c5"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"9d1c73b5cabe95922f9773e31e5e65d553dd8f4d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        boot_option \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        # Validate the root device hints"},{"line_number":325,"context_line":"        iscsi_deploy.parse_root_device_hints(node)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # NOTE(lucasagomes): We don\u0027t support UEFI + localboot because"},{"line_number":328,"context_line":"        # we do not support creating an EFI boot partition, including the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_68cdfb30","line":325,"updated":"2015-03-13 12:49:01.000000000","message":"Better if we move this to iscsi_deploy.validate as it rightfully belongs there are ilo drivers can make use of it.","commit_id":"b6fd95e9de89c3c9b45e8eace68cd8420069bd16"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3fed93828d7916d2b86c1e6454aae9d132493ebd","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        boot_option \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        # Validate the root device hints"},{"line_number":325,"context_line":"        iscsi_deploy.parse_root_device_hints(node)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # NOTE(lucasagomes): We don\u0027t support UEFI + localboot because"},{"line_number":328,"context_line":"        # we do not support creating an EFI boot partition, including the"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1f611239","line":325,"in_reply_to":"9a80dd14_68cdfb30","updated":"2015-03-13 13:27:14.000000000","message":"So I don\u0027t really want to do that, because root device hints should work with IPA too and IPA doesn\u0027t use iscsi_deploy. The next patch on this series is moving parse_root_device_hints() to deploy_utils.py which is a common module for all drivers","commit_id":"b6fd95e9de89c3c9b45e8eace68cd8420069bd16"}]}