)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7459e182fc4f425518e1df002d66258d0fd1cfda","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \u0027pxe_append_params\u0027: CONF.agent.agent_pxe_append_params,"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    root_device \u003d deploy_utils.parse_root_device_hints(node)"},{"line_number":116,"context_line":"    if root_device:"},{"line_number":117,"context_line":"        agent_config_opts[\u0027root_device\u0027] \u003d root_device"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_886a2feb","line":115,"updated":"2015-03-13 12:54:31.000000000","message":"Can we move this build_agent_options so that agent_ilo driver can also use this.","commit_id":"43e4f59d07ebf071d000458de057a0f4843e24eb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d18b3f94bd95d9a2286a65627b3492dcad2fe609","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \u0027pxe_append_params\u0027: CONF.agent.agent_pxe_append_params,"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    root_device \u003d deploy_utils.parse_root_device_hints(node)"},{"line_number":116,"context_line":"    if root_device:"},{"line_number":117,"context_line":"        agent_config_opts[\u0027root_device\u0027] \u003d root_device"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1cb760d9","line":115,"in_reply_to":"9a80dd14_886a2feb","updated":"2015-03-13 13:05:09.000000000","message":"yes sir! moving it","commit_id":"43e4f59d07ebf071d000458de057a0f4843e24eb"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d9bc3441c165ffb04f3e0bd6652bcbd3263eb0a1","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            _(\u0027The hints \"%(invalid_hints)s\" are invalid. \u0027"},{"line_number":890,"context_line":"              \u0027Valid hints are: \"%(valid_hints)s\"\u0027) %"},{"line_number":891,"context_line":"            {\u0027invalid_hints\u0027: \u0027, \u0027.join(invalid_hints),"},{"line_number":892,"context_line":"             \u0027valid_hints\u0027: \u0027, \u0027.join(VALID_ROOT_DEVICE_HINTS)})"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    if \u0027size\u0027 in root_device:"},{"line_number":895,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d3268115","line":892,"updated":"2015-03-13 20:08:48.000000000","message":"Nit: would like to see node uuid here.","commit_id":"1b894936955fa6ac7cc9364457905dd09b586d9f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"49c84c17f03dd176cad6f0db1a38df90a19dbada","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            _(\u0027The hints \"%(invalid_hints)s\" are invalid. \u0027"},{"line_number":890,"context_line":"              \u0027Valid hints are: \"%(valid_hints)s\"\u0027) %"},{"line_number":891,"context_line":"            {\u0027invalid_hints\u0027: \u0027, \u0027.join(invalid_hints),"},{"line_number":892,"context_line":"             \u0027valid_hints\u0027: \u0027, \u0027.join(VALID_ROOT_DEVICE_HINTS)})"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    if \u0027size\u0027 in root_device:"},{"line_number":895,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_87949d37","line":892,"in_reply_to":"9a80dd14_d3268115","updated":"2015-03-16 09:49:53.000000000","message":"Hi Chris, these exceptions will bubble up on validate() of a specific node, these are not logged here, so I\u0027m running an exception without a node UUID because on a high level it will be logged and the log contains the node UUID. Adding it here will duplicate the information","commit_id":"1b894936955fa6ac7cc9364457905dd09b586d9f"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"d9bc3441c165ffb04f3e0bd6652bcbd3263eb0a1","unresolved":false,"context_lines":[{"line_number":896,"context_line":"            int(root_device[\u0027size\u0027])"},{"line_number":897,"context_line":"        except ValueError:"},{"line_number":898,"context_line":"            raise exception.InvalidParameterValue("},{"line_number":899,"context_line":"                _(\u0027Root device hint \"size\" is not an integer value.\u0027))"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    hints \u003d []"},{"line_number":902,"context_line":"    for key, value in root_device.items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_938089c0","line":899,"updated":"2015-03-13 20:08:48.000000000","message":"Nit: and here","commit_id":"1b894936955fa6ac7cc9364457905dd09b586d9f"}]}