)]}'
{"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5602bb304b1f29a13e4c8d7100c17825767f8f3f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":282,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":283,"context_line":"            task.node.properties \u003d properties"},{"line_number":284,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":285,"context_line":"                              task.driver.deploy.validate, task)"},{"line_number":286,"context_line":"            validate_mock.assert_called_once_with(task)"},{"line_number":287,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0b5c4b7c","line":284,"updated":"2015-03-15 09:01:51.000000000","message":"Also better to grep for boot_option in the exception message (to make sure we failed because of boot option).","commit_id":"5fc2f54bce7f71d13819bc8ec6771dee15830704"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fb0b6037128e1be24e20cbf94f959e14eecce597","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":282,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":283,"context_line":"            task.node.properties \u003d properties"},{"line_number":284,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":285,"context_line":"                              task.driver.deploy.validate, task)"},{"line_number":286,"context_line":"            validate_mock.assert_called_once_with(task)"},{"line_number":287,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ff8088f8","line":284,"in_reply_to":"9a80dd14_0b5c4b7c","updated":"2015-03-16 02:32:59.000000000","message":"Done","commit_id":"5fc2f54bce7f71d13819bc8ec6771dee15830704"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5602bb304b1f29a13e4c8d7100c17825767f8f3f","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                        deploy_info_mock,"},{"line_number":297,"context_line":"                                        validate_prop_mock):"},{"line_number":298,"context_line":"        d_info \u003d {\u0027image_source\u0027: \u0027uuid\u0027}"},{"line_number":299,"context_line":"        properties \u003d {\u0027capabilities\u0027: \u0027boot_mode:uefi,boot_option:foo\u0027}"},{"line_number":300,"context_line":"        deploy_info_mock.return_value \u003d d_info"},{"line_number":301,"context_line":"        props \u003d [\u0027kernel_id\u0027, \u0027ramdisk_id\u0027]"},{"line_number":302,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_8b703b09","line":299,"updated":"2015-03-15 09:01:51.000000000","message":"I think it should be boot_mode:foo,boot_option:local","commit_id":"5fc2f54bce7f71d13819bc8ec6771dee15830704"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fb0b6037128e1be24e20cbf94f959e14eecce597","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                        deploy_info_mock,"},{"line_number":297,"context_line":"                                        validate_prop_mock):"},{"line_number":298,"context_line":"        d_info \u003d {\u0027image_source\u0027: \u0027uuid\u0027}"},{"line_number":299,"context_line":"        properties \u003d {\u0027capabilities\u0027: \u0027boot_mode:uefi,boot_option:foo\u0027}"},{"line_number":300,"context_line":"        deploy_info_mock.return_value \u003d d_info"},{"line_number":301,"context_line":"        props \u003d [\u0027kernel_id\u0027, \u0027ramdisk_id\u0027]"},{"line_number":302,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1f847c09","line":299,"in_reply_to":"9a80dd14_8b703b09","updated":"2015-03-16 02:32:59.000000000","message":"Done","commit_id":"5fc2f54bce7f71d13819bc8ec6771dee15830704"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5602bb304b1f29a13e4c8d7100c17825767f8f3f","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                              task.driver.deploy.validate, task)"},{"line_number":307,"context_line":"            validate_mock.assert_called_once_with(task)"},{"line_number":308,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"},{"line_number":309,"context_line":"            validate_prop_mock.assert_called_once_with(task.context,"},{"line_number":310,"context_line":"                    d_info, props)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @mock.patch.object(service_utils, \u0027is_glance_image\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_4b51e360","line":309,"updated":"2015-03-15 09:01:51.000000000","message":"Ditto, better to grep for boot_mode in the exception message (to make sure we failed because of boot mode).","commit_id":"5fc2f54bce7f71d13819bc8ec6771dee15830704"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fb0b6037128e1be24e20cbf94f959e14eecce597","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                              task.driver.deploy.validate, task)"},{"line_number":307,"context_line":"            validate_mock.assert_called_once_with(task)"},{"line_number":308,"context_line":"            deploy_info_mock.assert_called_once_with(task.node)"},{"line_number":309,"context_line":"            validate_prop_mock.assert_called_once_with(task.context,"},{"line_number":310,"context_line":"                    d_info, props)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @mock.patch.object(service_utils, \u0027is_glance_image\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3f7ea019","line":309,"in_reply_to":"9a80dd14_4b51e360","updated":"2015-03-16 02:32:59.000000000","message":"Done","commit_id":"5fc2f54bce7f71d13819bc8ec6771dee15830704"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"771574560664d815bcc9cfbcffb0568ed847f64b","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.node \u003d obj_utils.create_test_node(self.context,"},{"line_number":252,"context_line":"                driver\u003d\u0027iscsi_ilo\u0027, driver_info\u003dINFO_DICT)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    @mock.patch.object(driver_utils, \u0027validate_boot_mode_capability\u0027)"},{"line_number":255,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_image_properties\u0027)"},{"line_number":256,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_parse_deploy_info\u0027)"},{"line_number":257,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b8cee1b5","line":254,"updated":"2015-03-17 11:18:49.000000000","message":"Two new tests are not necessary as it seems to me, it\u0027s tested in tests.drivers.test_utils, so maybe you can just mock validate_boot_option_capability here and check if it\u0027s called, and remove new test cases.","commit_id":"dd2e96dbdc634ebbc3f9cb451ccb9c240a1f0372"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a7c5d86189ec6b6e3a3ad4a6c7f31e0509b96d97","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.node \u003d obj_utils.create_test_node(self.context,"},{"line_number":252,"context_line":"                driver\u003d\u0027iscsi_ilo\u0027, driver_info\u003dINFO_DICT)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    @mock.patch.object(driver_utils, \u0027validate_boot_mode_capability\u0027)"},{"line_number":255,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_image_properties\u0027)"},{"line_number":256,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_parse_deploy_info\u0027)"},{"line_number":257,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_6fb809c8","line":254,"in_reply_to":"9a80dd14_b8cee1b5","updated":"2015-03-17 18:42:34.000000000","message":"These are added to capture specific exceptions for erroneous value in boot_option and boot_mode respectively.","commit_id":"dd2e96dbdc634ebbc3f9cb451ccb9c240a1f0372"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"771574560664d815bcc9cfbcffb0568ed847f64b","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                deploy_info_mock.assert_called_once_with(task.node)"},{"line_number":290,"context_line":"                validate_prop_mock.assert_called_once_with(task.context,"},{"line_number":291,"context_line":"                        d_info, props)"},{"line_number":292,"context_line":"            except exception.InvalidParameterValue as e:"},{"line_number":293,"context_line":"                self.assertIn(\u0027boot_option\u0027, str(e))"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_image_properties\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_5d2077b0","line":292,"updated":"2015-03-17 11:18:49.000000000","message":"With this, as I understand it, test won\u0027t fail if exception is not raised, so it\u0027s better to use assertRaises, and if you want to check exception message, you can do \u0027exc \u003d self.assertRaises ...\u0027","commit_id":"dd2e96dbdc634ebbc3f9cb451ccb9c240a1f0372"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a7c5d86189ec6b6e3a3ad4a6c7f31e0509b96d97","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                deploy_info_mock.assert_called_once_with(task.node)"},{"line_number":290,"context_line":"                validate_prop_mock.assert_called_once_with(task.context,"},{"line_number":291,"context_line":"                        d_info, props)"},{"line_number":292,"context_line":"            except exception.InvalidParameterValue as e:"},{"line_number":293,"context_line":"                self.assertIn(\u0027boot_option\u0027, str(e))"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_image_properties\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_6fa3a9b1","line":292,"in_reply_to":"9a80dd14_5d2077b0","updated":"2015-03-17 18:42:34.000000000","message":"Done","commit_id":"dd2e96dbdc634ebbc3f9cb451ccb9c240a1f0372"}]}