)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d0909733061f437440153dc6ceb3d21b68de2b9","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # TODO(sirushtim): Remove once IPA has support for partition images."},{"line_number":219,"context_line":"        if not is_whole_disk_image:"},{"line_number":220,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":221,"context_line":"                \"Node %s is configured to use the Agent Deploy \""},{"line_number":222,"context_line":"                \"driver which does not currently support deploying \""},{"line_number":223,"context_line":"                \"of partition images.\") % node.uuid)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_8bf59b52","line":221,"updated":"2015-03-15 09:28:55.000000000","message":"may-be-nit: For the operator, agent_ssh, agent_ipmitool might be familiar than \"Agent Deploy driver\". I think it\u0027s better if it was:\n\nNode xxx is configured to use agent_ipmitool driver which currently does not support deploying partition images.\n\n\nWe can get the driver name from task.node.driver","commit_id":"053c31643c958404c7327487d251e45a9dd722ef"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3ba4fedf69314468667046f54f9f4cb168d7a029","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        # TODO(sirushtim): Remove once IPA has support for partition images."},{"line_number":219,"context_line":"        if not is_whole_disk_image:"},{"line_number":220,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":221,"context_line":"                \"Node %s is configured to use the Agent Deploy \""},{"line_number":222,"context_line":"                \"driver which does not currently support deploying \""},{"line_number":223,"context_line":"                \"of partition images.\") % node.uuid)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a67616a2","line":221,"in_reply_to":"9a80dd14_8bf59b52","updated":"2015-03-15 10:39:07.000000000","message":"Done","commit_id":"053c31643c958404c7327487d251e45a9dd722ef"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4591686b8e97dd1765f60fa849c7fea8df46013e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        is_whole_disk_image \u003d node.driver_internal_info.get("},{"line_number":222,"context_line":"            \u0027is_whole_disk_image\u0027)"},{"line_number":223,"context_line":"        # TODO(sirushtim): Remove once IPA has support for partition images."},{"line_number":224,"context_line":"        if not is_whole_disk_image:"},{"line_number":225,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":226,"context_line":"                \"Node %(node)s is configured to use the %(driver)s driver \""},{"line_number":227,"context_line":"                \"which currently does not support deploying partition \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_30cc17bb","line":224,"updated":"2015-03-15 18:09:46.000000000","message":"I see that is_whole_disk image can be set to None, e.g. when call to Glance failed, and it does not mean that an image is not whole disk. So I think it\u0027s better to check if it is False, because \u0027not None\u0027 gives True in result.","commit_id":"46494fa09d41bb91b6999ac1ae5545419e25f3d2"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"914ac69e9dc8c47175b9901fe25dc3f9bcb77604","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        is_whole_disk_image \u003d node.driver_internal_info.get("},{"line_number":222,"context_line":"            \u0027is_whole_disk_image\u0027)"},{"line_number":223,"context_line":"        # TODO(sirushtim): Remove once IPA has support for partition images."},{"line_number":224,"context_line":"        if not is_whole_disk_image:"},{"line_number":225,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":226,"context_line":"                \"Node %(node)s is configured to use the %(driver)s driver \""},{"line_number":227,"context_line":"                \"which currently does not support deploying partition \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_61ff9e02","line":224,"in_reply_to":"9a80dd14_30cc17bb","updated":"2015-03-16 06:16:03.000000000","message":"Done","commit_id":"46494fa09d41bb91b6999ac1ae5545419e25f3d2"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d0909733061f437440153dc6ceb3d21b68de2b9","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            on encountering error while setting the boot device on the node."},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":"        node \u003d task.node"},{"line_number":365,"context_line":"        if not node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":366,"context_line":"            result \u003d self._client.install_bootloader(node, root_uuid)"},{"line_number":367,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":368,"context_line":"                msg \u003d (_(\"Failed to install a bootloader when \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ab65ff1e","line":365,"updated":"2015-03-15 09:28:55.000000000","message":"If we default root_uuid to None, it would mean to the caller that the function can still be called without having root_uuid and it will execute properly in all cases (it would lead to a failure if it\u0027s not a whole disk image and root uuid is None).\n\nAgain this one is may-be-nit for now (because there are no other use-cases), but I would suggest we have \n\n  if not node.driver_internal_info.get(\u0027is_whole_disk_image\u0027) and root_uuid:\n    result \u003d self._client.install_bootloader(node, root_uuid)\n\nAgain, we don\u0027t have such a case now where we pass root_uuid as None, so we might as well need a test case for it.\n\n(We pass disk identifier now: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L608)","commit_id":"053c31643c958404c7327487d251e45a9dd722ef"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3ba4fedf69314468667046f54f9f4cb168d7a029","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            on encountering error while setting the boot device on the node."},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":"        node \u003d task.node"},{"line_number":365,"context_line":"        if not node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":366,"context_line":"            result \u003d self._client.install_bootloader(node, root_uuid)"},{"line_number":367,"context_line":"            if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":368,"context_line":"                msg \u003d (_(\"Failed to install a bootloader when \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a639b6a5","line":365,"in_reply_to":"9a80dd14_ab65ff1e","updated":"2015-03-15 10:39:07.000000000","message":"Done. I\u0027ve also made it more clear in the function call as to what exactly we are passing. Please have a look.","commit_id":"053c31643c958404c7327487d251e45a9dd722ef"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4591686b8e97dd1765f60fa849c7fea8df46013e","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        is_whole_disk_image \u003d node.driver_internal_info[\u0027is_whole_disk_image\u0027]"},{"line_number":606,"context_line":"        if iscsi_deploy.get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":607,"context_line":"            # Install the boot loader"},{"line_number":608,"context_line":"            self.configure_local_boot(task, root_uuid\u003droot_uuid_or_disk_id)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"            # If it\u0027s going to boot from the local disk, get rid of"},{"line_number":611,"context_line":"            # the PXE configuration files used for the deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_d0601ba7","line":608,"updated":"2015-03-15 18:09:46.000000000","message":"nit - this change is not required","commit_id":"46494fa09d41bb91b6999ac1ae5545419e25f3d2"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"914ac69e9dc8c47175b9901fe25dc3f9bcb77604","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        is_whole_disk_image \u003d node.driver_internal_info[\u0027is_whole_disk_image\u0027]"},{"line_number":606,"context_line":"        if iscsi_deploy.get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":607,"context_line":"            # Install the boot loader"},{"line_number":608,"context_line":"            self.configure_local_boot(task, root_uuid\u003droot_uuid_or_disk_id)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"            # If it\u0027s going to boot from the local disk, get rid of"},{"line_number":611,"context_line":"            # the PXE configuration files used for the deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_2410544d","line":608,"in_reply_to":"9a80dd14_d0601ba7","updated":"2015-03-16 06:16:03.000000000","message":"I\u0027ve kept this just to make sure it\u0027s clear what we\u0027re exactly sending.","commit_id":"46494fa09d41bb91b6999ac1ae5545419e25f3d2"}],"ironic/tests/drivers/test_agent_base_vendor.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7d0909733061f437440153dc6ceb3d21b68de2b9","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027install_bootloader\u0027)"},{"line_number":348,"context_line":"    def test_configure_local_boot_whole_disk_image("},{"line_number":349,"context_line":"            self, install_bootloader_mock, try_set_boot_device_mock):"},{"line_number":350,"context_line":"        install_bootloader_mock.return_value \u003d {"},{"line_number":351,"context_line":"            \u0027command_status\u0027: \u0027SUCCESS\u0027, \u0027command_error\u0027: None}"},{"line_number":352,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_0b6febfc","line":350,"updated":"2015-03-15 09:28:55.000000000","message":"nit: line not required, we won\u0027t assert return value.","commit_id":"053c31643c958404c7327487d251e45a9dd722ef"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"3ba4fedf69314468667046f54f9f4cb168d7a029","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027install_bootloader\u0027)"},{"line_number":348,"context_line":"    def test_configure_local_boot_whole_disk_image("},{"line_number":349,"context_line":"            self, install_bootloader_mock, try_set_boot_device_mock):"},{"line_number":350,"context_line":"        install_bootloader_mock.return_value \u003d {"},{"line_number":351,"context_line":"            \u0027command_status\u0027: \u0027SUCCESS\u0027, \u0027command_error\u0027: None}"},{"line_number":352,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":353,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_06a7e20b","line":350,"in_reply_to":"9a80dd14_0b6febfc","updated":"2015-03-15 10:39:07.000000000","message":"Done","commit_id":"053c31643c958404c7327487d251e45a9dd722ef"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"a4e6bd4c07cb412b2c642c7ad1df4a8849aab49e","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            self.assertFalse(install_bootloader_mock.called)"},{"line_number":355,"context_line":"            try_set_boot_device_mock.assert_called_once_with("},{"line_number":356,"context_line":"                task, boot_devices.DISK)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027install_bootloader\u0027)"},{"line_number":359,"context_line":"    def test_configure_local_boot_boot_loader_install_fail("},{"line_number":360,"context_line":"            self, install_bootloader_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e6a9ee90","line":357,"updated":"2015-03-15 10:49:18.000000000","message":"Just and to make sure that we have unit tests covering all code paths, I suggest we add a test case test_configure_local_boot_no_root_uuid and call with \n\n  self.passthru.configure_local_boot(task, root_uuid\u003dNone)\n\n(and task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d True) and assert that we don\u0027t install boot loader.","commit_id":"568f31059efebbc70c79560a6403b3c2831b27ef"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"45577649ceba29e84d74e7d411bc7e3fe3f77c96","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            self, install_bootloader_mock, try_set_boot_device_mock):"},{"line_number":362,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":363,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":364,"context_line":"            self.passthru.configure_local_boot(task, root_uuid\u003dNone)"},{"line_number":365,"context_line":"            self.assertFalse(install_bootloader_mock.called)"},{"line_number":366,"context_line":"            try_set_boot_device_mock.assert_called_once_with("},{"line_number":367,"context_line":"                task, boot_devices.DISK)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_46a0fa8f","line":364,"updated":"2015-03-15 11:05:23.000000000","message":"I am sorry made a small mistake in my comment :(\n\nI meant we need \n\n  task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d False\n\nhere.\n\nOtherwise the code path exercised by test_configure_local_boot_whole_disk_image and test_configure_local_boot_whole_disk_no_root_uuid are exactly the same. :(","commit_id":"2a3f6e6dee651c78e1f0116e07a3e0a92436628d"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"ef7c0e540082f4b385a080b46df168d7f085a061","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            self, install_bootloader_mock, try_set_boot_device_mock):"},{"line_number":362,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":363,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":364,"context_line":"            self.passthru.configure_local_boot(task, root_uuid\u003dNone)"},{"line_number":365,"context_line":"            self.assertFalse(install_bootloader_mock.called)"},{"line_number":366,"context_line":"            try_set_boot_device_mock.assert_called_once_with("},{"line_number":367,"context_line":"                task, boot_devices.DISK)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_86bd92b3","line":364,"in_reply_to":"9a80dd14_46a0fa8f","updated":"2015-03-15 11:08:55.000000000","message":"Done","commit_id":"2a3f6e6dee651c78e1f0116e07a3e0a92436628d"}]}
