)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f9b7a9ab9c5ec67be9b4479ac5c4cc3b00d15e87","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements blueprint implement-cleaning-steps"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I4ed4fbc8c4d88988add953307f8871cbfa33971f"},{"line_number":24,"context_line":"Depends-On: Ia2500ed5afb72058b4c5e8f41307169381cbce48"},{"line_number":25,"context_line":"Depends-On: Ie04823c40efc08f887429a6b8e6219558c3e4efa"},{"line_number":26,"context_line":"Depends-On: I6e6abfb41c6896e0db826a444979c5a28a5463fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_f559ed35","line":23,"updated":"2015-03-18 19:59:44.000000000","message":"Should you tag the bug here?","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"849aed9585b6c8b45cd9117eacd5b77ee9cef4c4","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements blueprint implement-cleaning-steps"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I4ed4fbc8c4d88988add953307f8871cbfa33971f"},{"line_number":24,"context_line":"Depends-On: Ia2500ed5afb72058b4c5e8f41307169381cbce48"},{"line_number":25,"context_line":"Depends-On: Ie04823c40efc08f887429a6b8e6219558c3e4efa"},{"line_number":26,"context_line":"Depends-On: I6e6abfb41c6896e0db826a444979c5a28a5463fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_1b21989f","line":23,"in_reply_to":"9a80dd14_f559ed35","updated":"2015-03-23 23:35:56.000000000","message":"IMO the bug is already closed, we\u0027re just deciding if we\u0027re secure by default or not here.","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"1d232ff55e545f26634289682194b101118a6f2a","unresolved":false,"context_lines":[{"line_number":635,"context_line":"# documentation for details. NOTE: The introduction of the"},{"line_number":636,"context_line":"# cleaning operation causes instance deletion to take"},{"line_number":637,"context_line":"# significantly longer. In an environment where all tenants"},{"line_number":638,"context_line":"# are trusted (eg, becuse there is only one tenant), this"},{"line_number":639,"context_line":"# option should be disabled. (boolean value)"},{"line_number":640,"context_line":"#clean_nodes\u003dtrue"},{"line_number":641,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a80dd14_03c2b4e8","line":638,"updated":"2015-03-19 09:54:04.000000000","message":"s/becuse/because/","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"849aed9585b6c8b45cd9117eacd5b77ee9cef4c4","unresolved":false,"context_lines":[{"line_number":635,"context_line":"# documentation for details. NOTE: The introduction of the"},{"line_number":636,"context_line":"# cleaning operation causes instance deletion to take"},{"line_number":637,"context_line":"# significantly longer. In an environment where all tenants"},{"line_number":638,"context_line":"# are trusted (eg, becuse there is only one tenant), this"},{"line_number":639,"context_line":"# option should be disabled. (boolean value)"},{"line_number":640,"context_line":"#clean_nodes\u003dtrue"},{"line_number":641,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a6ced46_38a57a53","line":638,"in_reply_to":"9a80dd14_03c2b4e8","updated":"2015-03-23 23:35:56.000000000","message":"Done","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"660aef4d6e575d6915c1700bdae7b575cebf8fe1","unresolved":false,"context_lines":[{"line_number":518,"context_line":"# cleaning operation causes instance deletion to take"},{"line_number":519,"context_line":"# significantly longer. In an environment where all tenants"},{"line_number":520,"context_line":"# are trusted (eg, because there is only one tenant), this"},{"line_number":521,"context_line":"# option should be disabled. (boolean value)"},{"line_number":522,"context_line":"#clean_nodes\u003dtrue"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"da9b358b_fa2e12f9","line":521,"updated":"2015-03-31 15:48:46.000000000","message":"s/should/may/ maybe? \n\n1) many people think internal users can be trusted, I think this is false.\n2) Leaving data on a disk can break things in interesting ways -- say if a RAID superblock is left somewhere that an image doesn\u0027t overwrite, etc.","commit_id":"90580aa45373deb1bc37f43fddc5a2e613967c3e"}],"ironic/conductor/manager.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f9b7a9ab9c5ec67be9b4479ac5c4cc3b00d15e87","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                         \u0027NOTE: The introduction of the cleaning operation \u0027"},{"line_number":184,"context_line":"                         \u0027causes instance deletion to take significantly \u0027"},{"line_number":185,"context_line":"                         \u0027longer. In an environment where all tenants are \u0027"},{"line_number":186,"context_line":"                         \u0027trusted (eg, becuse there is only one tenant), this \u0027"},{"line_number":187,"context_line":"                         \u0027option should be disabled.\u0027),"},{"line_number":188,"context_line":"]"},{"line_number":189,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b54f7569","line":186,"updated":"2015-03-18 19:59:44.000000000","message":"nit: s/becuse/because/","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"849aed9585b6c8b45cd9117eacd5b77ee9cef4c4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                         \u0027NOTE: The introduction of the cleaning operation \u0027"},{"line_number":184,"context_line":"                         \u0027causes instance deletion to take significantly \u0027"},{"line_number":185,"context_line":"                         \u0027longer. In an environment where all tenants are \u0027"},{"line_number":186,"context_line":"                         \u0027trusted (eg, becuse there is only one tenant), this \u0027"},{"line_number":187,"context_line":"                         \u0027option should be disabled.\u0027),"},{"line_number":188,"context_line":"]"},{"line_number":189,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_f8c122e5","line":186,"in_reply_to":"9a80dd14_b54f7569","updated":"2015-03-23 23:35:56.000000000","message":"Done","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8648f6ceae1ad9086218d9068bc9f4e2e7895837","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                         \u0027causes instance deletion to take significantly \u0027"},{"line_number":185,"context_line":"                         \u0027longer. In an environment where all tenants are \u0027"},{"line_number":186,"context_line":"                         \u0027trusted (eg, becuse there is only one tenant), this \u0027"},{"line_number":187,"context_line":"                         \u0027option should be disabled.\u0027),"},{"line_number":188,"context_line":"]"},{"line_number":189,"context_line":"CONF \u003d cfg.CONF"},{"line_number":190,"context_line":"CONF.register_opts(conductor_opts, \u0027conductor\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1e1da762","line":187,"updated":"2015-03-19 10:01:55.000000000","message":"I\u0027m not against, but I don\u0027t think this note addition does any good, IMO cleaning is expected behavior even when tenants are trusted. Not cleaning disks can result in odd behaviors sometimes like label conflicting. For e.g\n\nThe default behavior of Ironic is to pick the fist disk for deployment, now if a machine has 2 disks and in the 1st deployment it picks disk A and deploy the image onto it. After deleting and not cleaning, the 2nd deployment picks disk B, now there are two disks present in the system with similar labels (config-2, ephemeral0, swap1, etc...)\n\nEven if it\u0027s not a full disk erase, I believe that cleaning at least the partition tables at the deleting, and we can have a cleaning function by default doing that is very beneficial (and will be fast too).","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"849aed9585b6c8b45cd9117eacd5b77ee9cef4c4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                         \u0027causes instance deletion to take significantly \u0027"},{"line_number":185,"context_line":"                         \u0027longer. In an environment where all tenants are \u0027"},{"line_number":186,"context_line":"                         \u0027trusted (eg, becuse there is only one tenant), this \u0027"},{"line_number":187,"context_line":"                         \u0027option should be disabled.\u0027),"},{"line_number":188,"context_line":"]"},{"line_number":189,"context_line":"CONF \u003d cfg.CONF"},{"line_number":190,"context_line":"CONF.register_opts(conductor_opts, \u0027conductor\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_785b7254","line":187,"in_reply_to":"9a80dd14_1e1da762","updated":"2015-03-23 23:35:56.000000000","message":"I agree personally (another example is left over RAID superblocks causing issues), but I\u0027ll leave the decision to Deva, as it\u0027s his addition.","commit_id":"c04fec15d32113c8e06f0f4a7f02aaa42b1c28cb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"22cd1411af8be7ce8b6c6c202a251e71271fd1c7","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                         \u0027causes instance deletion to take significantly \u0027"},{"line_number":185,"context_line":"                         \u0027longer. In an environment where all tenants are \u0027"},{"line_number":186,"context_line":"                         \u0027trusted (eg, because there is only one tenant), \u0027"},{"line_number":187,"context_line":"                         \u0027this option should be disabled.\u0027),"},{"line_number":188,"context_line":"]"},{"line_number":189,"context_line":"CONF \u003d cfg.CONF"},{"line_number":190,"context_line":"CONF.register_opts(conductor_opts, \u0027conductor\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_896ec8c7","line":187,"updated":"2015-04-02 19:16:49.000000000","message":"Do we really want to say \u0027should\u0027 instead of \u0027could be safely\u0027 or \u0027it should be safe to disable this option\u0027?","commit_id":"4e016a5430a3e4761cade39a1ad4a88581caa7d3"}]}