)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"999bbcbc68a89f977e974675ae610c06bbd1d661","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                                                                self._client)"},{"line_number":616,"context_line":"        root_uuid \u003d uuid_dict_returned.get(\u0027root uuid\u0027)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        if iscsi_deploy.get_boot_option(node) \u003d\u003d \"local\" or iwdi:"},{"line_number":619,"context_line":"            efi_system_part_uuid \u003d uuid_dict_returned.get("},{"line_number":620,"context_line":"                \u0027efi system partition uuid\u0027)"},{"line_number":621,"context_line":"            self.configure_local_boot("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_26e2f8d5","line":618,"updated":"2015-03-21 21:12:56.000000000","message":"nit - you can substitute iwdi here and avoid variable declaration","commit_id":"3a3baf2ccdc5ba07d26750aa57fc8d72383180c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3eb96b3af38d51e9c3a1160063689cfb64b06639","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                                                                self._client)"},{"line_number":616,"context_line":"        root_uuid \u003d uuid_dict_returned.get(\u0027root uuid\u0027)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        if iscsi_deploy.get_boot_option(node) \u003d\u003d \"local\" or iwdi:"},{"line_number":619,"context_line":"            efi_system_part_uuid \u003d uuid_dict_returned.get("},{"line_number":620,"context_line":"                \u0027efi system partition uuid\u0027)"},{"line_number":621,"context_line":"            self.configure_local_boot("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_5ed32738","line":618,"in_reply_to":"1a6ced46_26e2f8d5","updated":"2015-03-23 09:07:03.000000000","message":"Yeah, I can do that. But surely it will spill over to the next line.  I just thought this would be more readable (with same number of lines) :)","commit_id":"3a3baf2ccdc5ba07d26750aa57fc8d72383180c4"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"999bbdf66a2c6bf4c0aa151dd56bd25364fb7fe1","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        self.node.driver_internal_info \u003d {\u0027is_whole_disk_image\u0027: True}"},{"line_number":712,"context_line":"        self.node.save()"},{"line_number":713,"context_line":"        do_agent_iscsi_deploy_mock.return_value \u003d {"},{"line_number":714,"context_line":"            \u0027root uuid\u0027: \u0027some-root-uuid\u0027}"},{"line_number":715,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":716,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":717,"context_line":"            task.driver.vendor.continue_deploy(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0dbe2865","line":714,"updated":"2015-03-20 10:34:07.000000000","message":"Here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L337-L338 it says that it should return disk identifier in case of whole disk image.","commit_id":"aa84e405ba192ebf3f0435b4cf539111ef322d07"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5f95c0bb170c95ec59f71a4e17b69ff0450b0620","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        self.node.driver_internal_info \u003d {\u0027is_whole_disk_image\u0027: True}"},{"line_number":712,"context_line":"        self.node.save()"},{"line_number":713,"context_line":"        do_agent_iscsi_deploy_mock.return_value \u003d {"},{"line_number":714,"context_line":"            \u0027root uuid\u0027: \u0027some-root-uuid\u0027}"},{"line_number":715,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":716,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":717,"context_line":"            task.driver.vendor.continue_deploy(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_77ee8eee","line":714,"in_reply_to":"9a80dd14_0dbe2865","updated":"2015-03-20 11:40:20.000000000","message":"Oh yes, it should be disk identifier - even though we don\u0027t really consider it in continue_deploy. I will change it. :)","commit_id":"aa84e405ba192ebf3f0435b4cf539111ef322d07"}]}