)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"65eabf96a6b266ee099cf6ec910fcf069429e1a8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        cur_sec_state \u003d ilo_common.get_secure_boot_mode(task)"},{"line_number":280,"context_line":"    except exception.IloOperationNotSupported:"},{"line_number":281,"context_line":"        LOG.debug(\u0027Secure boot mode is not supported for node %s\u0027,"},{"line_number":282,"context_line":"                       task.node.uuid)"},{"line_number":283,"context_line":"        return False"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    if cur_sec_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a58d5433","line":282,"updated":"2015-03-19 17:32:17.000000000","message":"nit: indentation","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea488f395bf4786f2a2b92be5b6764b49a0b11f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        cur_sec_state \u003d ilo_common.get_secure_boot_mode(task)"},{"line_number":280,"context_line":"    except exception.IloOperationNotSupported:"},{"line_number":281,"context_line":"        LOG.debug(\u0027Secure boot mode is not supported for node %s\u0027,"},{"line_number":282,"context_line":"                       task.node.uuid)"},{"line_number":283,"context_line":"        return False"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    if cur_sec_state:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_56a6b5c2","line":282,"in_reply_to":"9a80dd14_a58d5433","updated":"2015-03-23 06:39:10.000000000","message":"Done","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c052a08a2939fc707fcc92971e5a847309d532f2","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @mock.patch.object(deploy_utils, \u0027is_secure_boot_requested\u0027)"},{"line_number":246,"context_line":"    @mock.patch.object(ilo_common, \u0027set_secure_boot_mode\u0027)"},{"line_number":247,"context_line":"    def test__update_secure_boot_passed_true(self,"},{"line_number":248,"context_line":"                                             func_set_secure_boot_mode,"},{"line_number":249,"context_line":"                                             func_is_secure_boot_requested):"},{"line_number":250,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_412bad81","line":247,"updated":"2015-03-19 17:02:40.000000000","message":"nit: better if this was test__update_secure_boot_mode_passed_true, ditto for below. (may be a follow-up-patch thing if there is a follow-up patch)","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea488f395bf4786f2a2b92be5b6764b49a0b11f","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @mock.patch.object(deploy_utils, \u0027is_secure_boot_requested\u0027)"},{"line_number":246,"context_line":"    @mock.patch.object(ilo_common, \u0027set_secure_boot_mode\u0027)"},{"line_number":247,"context_line":"    def test__update_secure_boot_passed_true(self,"},{"line_number":248,"context_line":"                                             func_set_secure_boot_mode,"},{"line_number":249,"context_line":"                                             func_is_secure_boot_requested):"},{"line_number":250,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_96b58dcf","line":247,"in_reply_to":"9a80dd14_412bad81","updated":"2015-03-23 06:39:10.000000000","message":"Done","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"65eabf96a6b266ee099cf6ec910fcf069429e1a8","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            exception_mock.IloOperationNotSupported \u003d Exception"},{"line_number":314,"context_line":"            func_get_secure_boot_mode.side_effect \u003d Exception"},{"line_number":315,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":316,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":317,"context_line":"        self.assertFalse(returned_state)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_65199cd0","line":316,"updated":"2015-03-19 17:32:17.000000000","message":"nit: I think a check to make sure LOG.debug was called once would be good.  And that set_secure_mode was not called.","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea488f395bf4786f2a2b92be5b6764b49a0b11f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            exception_mock.IloOperationNotSupported \u003d Exception"},{"line_number":314,"context_line":"            func_get_secure_boot_mode.side_effect \u003d Exception"},{"line_number":315,"context_line":"            returned_state \u003d ilo_deploy._disable_secure_boot(task)"},{"line_number":316,"context_line":"            func_get_secure_boot_mode.assert_called_once_with(task)"},{"line_number":317,"context_line":"        self.assertFalse(returned_state)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_b67b6928","line":316,"in_reply_to":"9a80dd14_65199cd0","updated":"2015-03-23 06:39:10.000000000","message":"Done","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"}],"ironic/tests/drivers/test_deploy_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"65eabf96a6b266ee099cf6ec910fcf069429e1a8","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"                          utils.parse_instance_info_capabilities, self.node)"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"    def test_is_secure_boot_requested_true(self):"},{"line_number":1455,"context_line":"        self.node.instance_info \u003d {\u0027capabilities\u0027: {\"secure_boot\": \"true\"}}"},{"line_number":1456,"context_line":"        self.assertTrue(utils.is_secure_boot_requested(self.node))"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def test_is_secure_boot_requested_false(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_25e4040c","line":1455,"updated":"2015-03-19 17:32:17.000000000","message":"nit: I would have liked a test with \u0027True\u0027 or \u0027tRue\u0027, because of the .lower()","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cea488f395bf4786f2a2b92be5b6764b49a0b11f","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"                          utils.parse_instance_info_capabilities, self.node)"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"    def test_is_secure_boot_requested_true(self):"},{"line_number":1455,"context_line":"        self.node.instance_info \u003d {\u0027capabilities\u0027: {\"secure_boot\": \"true\"}}"},{"line_number":1456,"context_line":"        self.assertTrue(utils.is_secure_boot_requested(self.node))"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def test_is_secure_boot_requested_false(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_5694f536","line":1455,"in_reply_to":"9a80dd14_25e4040c","updated":"2015-03-23 06:39:10.000000000","message":"Done","commit_id":"d519a18d7c3f234d6a2c8dd066f44854d1fe3136"}]}
