)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5afeec6e9820e59c50d232e98398761a91bd171e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"#parallel_image_downloads\u003dfalse"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"[None]"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# Options defined in ironic.openstack.common.eventlet_backdoor"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a6ced46_48150df0","line":214,"updated":"2015-03-23 20:46:46.000000000","message":"Is there really a \u0027None\u0027 section?","commit_id":"e5e334b1b06571d4c1ea55d71ce5713fc01a44b8"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"0b2a769c6ca4e8d141ddd7dc05dcf4d291ee6247","unresolved":false,"context_lines":[{"line_number":211,"context_line":"#parallel_image_downloads\u003dfalse"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"[None]"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# Options defined in ironic.openstack.common.eventlet_backdoor"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a6ced46_d4ca6a4e","line":214,"in_reply_to":"1a6ced46_48150df0","updated":"2015-03-24 06:35:19.000000000","message":"Strange, is this sample generated by util?","commit_id":"e5e334b1b06571d4c1ea55d71ce5713fc01a44b8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5afeec6e9820e59c50d232e98398761a91bd171e","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":1275,"context_line":""},{"line_number":1276,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":1277,"context_line":"#qpid_hostname\u003dironic"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"# Qpid broker port. (integer value)"},{"line_number":1280,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a6ced46_48ba6ddf","line":1277,"updated":"2015-03-23 20:46:46.000000000","message":"Ghe, do you know why this shows \u0027ironic\u0027? It should be \u0027localhost\u0027. I noticed this in a previous patch you had submitted, and we changed it back to localhost.","commit_id":"e5e334b1b06571d4c1ea55d71ce5713fc01a44b8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5afeec6e9820e59c50d232e98398761a91bd171e","unresolved":false,"context_lines":[{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":1354,"context_line":"# (string value)"},{"line_number":1355,"context_line":"#rabbit_host\u003dironic"},{"line_number":1356,"context_line":""},{"line_number":1357,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":1358,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a6ced46_88cb8571","line":1355,"updated":"2015-03-23 20:46:46.000000000","message":"ditto","commit_id":"e5e334b1b06571d4c1ea55d71ce5713fc01a44b8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b8835342265eeb232276e3810177651ce5a6f3fb","unresolved":false,"context_lines":[{"line_number":211,"context_line":"#parallel_image_downloads\u003dfalse"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"[None]"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# Options defined in ironic.openstack.common.eventlet_backdoor"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1a6ced46_54a9157a","line":214,"updated":"2015-03-24 09:43:12.000000000","message":"As others pointed out on the previous review, this looks odd. Is it correct?","commit_id":"db1b84df19baf9a246780c2cc1f47f692c5afbde"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"5433e5165c471fccefa658eebca822b0a5a482de","unresolved":false,"context_lines":[{"line_number":211,"context_line":"#parallel_image_downloads\u003dfalse"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"[None]"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# Options defined in ironic.openstack.common.eventlet_backdoor"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9aa53dc9_9fe19301","line":214,"in_reply_to":"1a6ced46_54a9157a","updated":"2015-04-06 11:53:32.000000000","message":"Done","commit_id":"db1b84df19baf9a246780c2cc1f47f692c5afbde"}],"ironic/openstack/common/versionutils.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"0b2a769c6ca4e8d141ddd7dc05dcf4d291ee6247","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def list_opts():"},{"line_number":44,"context_line":"    \"\"\"Entry point for oslo.config-generator."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return [(None, copy.deepcopy(deprecated_opts))]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class deprecated(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_34ee5eb5","line":46,"updated":"2015-03-24 06:35:19.000000000","message":"Should be this line which creates the [None] section or not?","commit_id":"e5e334b1b06571d4c1ea55d71ce5713fc01a44b8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b8835342265eeb232276e3810177651ce5a6f3fb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def list_opts():"},{"line_number":44,"context_line":"    \"\"\"Entry point for oslo.config-generator."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return [(None, copy.deepcopy(deprecated_opts))]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class deprecated(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_f4ca014e","line":46,"updated":"2015-03-24 09:43:12.000000000","message":"So the None is coming from here right? I wonder whether it should be DEFAULT or something","commit_id":"db1b84df19baf9a246780c2cc1f47f692c5afbde"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"5433e5165c471fccefa658eebca822b0a5a482de","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def list_opts():"},{"line_number":44,"context_line":"    \"\"\"Entry point for oslo.config-generator."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return [(None, copy.deepcopy(deprecated_opts))]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class deprecated(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_7fe7ef12","line":46,"in_reply_to":"1a6ced46_f4ca014e","updated":"2015-04-06 11:53:32.000000000","message":"Yes, the [None] section was coming from here, but solved removing the patch in the config generator module.","commit_id":"db1b84df19baf9a246780c2cc1f47f692c5afbde"}]}
