)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c889829d85653437d2c3127f3f50445ec136ea51","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if pecan.request.version.minor \u003c 5:"},{"line_number":94,"context_line":"            return False"},{"line_number":95,"context_line":"    # ignore check if we\u0027re not in a pecan context"},{"line_number":96,"context_line":"    except AttributeError:"},{"line_number":97,"context_line":"        pass"},{"line_number":98,"context_line":"    return True"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_faa8a38d","side":"PARENT","line":96,"updated":"2015-03-20 12:17:08.000000000","message":"I wonder if this check was added for a reason...","commit_id":"f0be66f96c3bcf3d852d933cf99f56f1d55cb867"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1532d53293808321ba3d4f3769bbd13a278aca1e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if pecan.request.version.minor \u003c 5:"},{"line_number":94,"context_line":"            return False"},{"line_number":95,"context_line":"    # ignore check if we\u0027re not in a pecan context"},{"line_number":96,"context_line":"    except AttributeError:"},{"line_number":97,"context_line":"        pass"},{"line_number":98,"context_line":"    return True"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_e3d0b3f9","side":"PARENT","line":96,"in_reply_to":"9a80dd14_faa8a38d","updated":"2015-03-23 13:41:13.000000000","message":"Yes, it was needed because this was being called in Node._convert_with_links() -- which is called by Node.sample() -- which is called when generating our documentation (and no pecan request there).\n\nNow that the call is being done in Node.convert_with_links(), it isn\u0027t needed. (The alternative is to put the call to  hide_fields_in_newer_versions() in Node._convert_with_links(), but I thought it muddied things since nowhere else do we make this check, so I thought it easier to remove the check.\n\nI mentioned this in the commit but yeah, didn\u0027t specify where the code was ;)","commit_id":"f0be66f96c3bcf3d852d933cf99f56f1d55cb867"}]}
