)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"a41606aba57fd4f870b683f46a405eb9980ea1d4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable pxe_amt driver with localboot"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1436824"},{"line_number":12,"context_line":"Change-Id: I2818647b0c2518ba2645843c287b093137ea7ece"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_3303a00f","line":11,"updated":"2015-03-31 04:59:02.000000000","message":"I don\u0027t think this closes the bug, If i under stand the bug nodes deployed with net boot will be unable to reboot.","commit_id":"427219fa05367a2294fcbc44664b1d6c2e36a366"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"024865a63b05641de72b0cc82329be53e0abc44a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable pxe_amt driver with localboot"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1436824"},{"line_number":12,"context_line":"Change-Id: I2818647b0c2518ba2645843c287b093137ea7ece"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_b3e33005","line":11,"in_reply_to":"da9b358b_3303a00f","updated":"2015-03-31 06:08:15.000000000","message":"There are two cases of reboot: 1. Reboot by Ironic. 2. Reboot by users who logging into the instance. There is no problem for case one. The issue is in case two.  And this is something related to AMT firmware. So the only solution is always deploy amt_driver with localboot.","commit_id":"427219fa05367a2294fcbc44664b1d6c2e36a366"}],"ironic/drivers/modules/amt/vendor.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7041f134da88386db0081d6024e9c112499c7f55","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":27,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":28,"context_line":"    def pass_deploy_info(self, task, **kwargs):"},{"line_number":29,"context_line":"        if not iscsi_deploy.get_boot_option(task.node) \u003d\u003d \"local\":"},{"line_number":30,"context_line":"            task.driver.management.ensure_next_boot_device(task.node,"},{"line_number":31,"context_line":"                                                           boot_devices.PXE)"},{"line_number":32,"context_line":"        super(AMTPXEVendorPassthru, self).pass_deploy_info(task, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_117af824","line":29,"updated":"2015-03-30 12:28:54.000000000","message":"nit: if iscsi_deploy.get_boot_option(task.node) !\u003d \"local\":\n or better IMO \n if iscsi_deploy.get_boot_option(task.node) \u003d\u003d \"netboot\":\n https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L410","commit_id":"33af7ab6947fcc4ffb2f391aff78cdcd13767abe"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"1ab1003b40beeb3b8721450909515866106f5f73","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":27,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":28,"context_line":"    def pass_deploy_info(self, task, **kwargs):"},{"line_number":29,"context_line":"        if not iscsi_deploy.get_boot_option(task.node) \u003d\u003d \"local\":"},{"line_number":30,"context_line":"            task.driver.management.ensure_next_boot_device(task.node,"},{"line_number":31,"context_line":"                                                           boot_devices.PXE)"},{"line_number":32,"context_line":"        super(AMTPXEVendorPassthru, self).pass_deploy_info(task, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_5c1cf9c0","line":29,"in_reply_to":"da9b358b_117af824","updated":"2015-03-31 01:19:02.000000000","message":"OK, this is more explicitly","commit_id":"33af7ab6947fcc4ffb2f391aff78cdcd13767abe"}],"ironic/tests/drivers/amt/test_vendor.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"11983bf15cf02d5b56a875f8526f71e1c90436da","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            task.node.target_provision_state \u003d states.ACTIVE"},{"line_number":81,"context_line":"            task.node.instance_info[\u0027capabilities\u0027] \u003d {\"boot_option\": \"local\"}"},{"line_number":82,"context_line":"            task.driver.vendor.pass_deploy_info(task, **kwargs)"},{"line_number":83,"context_line":"            mock_ensure.assert_not_called()"},{"line_number":84,"context_line":"            mock_pxe_vendorpassthru.assert_called_once_with(task, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_4709e794","line":83,"updated":"2015-03-30 08:40:50.000000000","message":"This wrong.  It\u0027s actually not checking anything.\n\n  \u003e\u003e\u003e import mock\n  \u003e\u003e\u003e m \u003d mock.MagicMock()\n  \u003e\u003e\u003e m.assert_not_called()\n  \u003cMagicMock name\u003d\u0027mock.assert_not_called()\u0027 id\u003d\u0027139895925873360\u0027\u003e\n  \u003e\u003e\u003e\n\nIt should be\n\n  self.assertFalse(mock_ensure.called)","commit_id":"b34f9824f193e5ec1488db42836dedfec269e0a7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"b5bc4ce1ba6a363428968a85c67b8644c4409cd8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            task.node.target_provision_state \u003d states.ACTIVE"},{"line_number":81,"context_line":"            task.node.instance_info[\u0027capabilities\u0027] \u003d {\"boot_option\": \"local\"}"},{"line_number":82,"context_line":"            task.driver.vendor.pass_deploy_info(task, **kwargs)"},{"line_number":83,"context_line":"            mock_ensure.assert_not_called()"},{"line_number":84,"context_line":"            mock_pxe_vendorpassthru.assert_called_once_with(task, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_02118dac","line":83,"in_reply_to":"da9b358b_4709e794","updated":"2015-03-30 09:10:38.000000000","message":"Really Thanks. Nice catch","commit_id":"b34f9824f193e5ec1488db42836dedfec269e0a7"}]}