)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0465ac1db631c043bbb6e3b8d345143bff16a26f","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    sec_boot \u003d driver_utils.get_node_capability(node, \u0027secure_boot\u0027)"},{"line_number":377,"context_line":"    loc_boot \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    if sec_boot and loc_boot:"},{"line_number":380,"context_line":"        if sec_boot \u003d\u003d \u0027true\u0027 and loc_boot \u003d\u003d \u0027local\u0027:"},{"line_number":381,"context_line":"            LOG.error(_LE(\"Local boot is not supported in UEFI secure boot \""},{"line_number":382,"context_line":"                          \"mode.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_7aa6b4c2","line":379,"updated":"2015-03-30 15:35:58.000000000","message":"nit - this if is not needed","commit_id":"d19bbf3a549faa5d847139ee38f70bdab2ece834"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5adbae00c230f62d67b8dcba7c1b47a40d6444c6","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    sec_boot \u003d driver_utils.get_node_capability(node, \u0027secure_boot\u0027)"},{"line_number":377,"context_line":"    loc_boot \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    if sec_boot and loc_boot:"},{"line_number":380,"context_line":"        if sec_boot \u003d\u003d \u0027true\u0027 and loc_boot \u003d\u003d \u0027local\u0027:"},{"line_number":381,"context_line":"            LOG.error(_LE(\"Local boot is not supported in UEFI secure boot \""},{"line_number":382,"context_line":"                          \"mode.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_7ebb540f","line":379,"in_reply_to":"da9b358b_7aa6b4c2","updated":"2015-04-02 06:26:37.000000000","message":"Done","commit_id":"d19bbf3a549faa5d847139ee38f70bdab2ece834"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"984af9adb40836501194f307c9a30f9f2061d796","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def _validate_secure_boot_with_local_boot(node):"},{"line_number":376,"context_line":"    sec_boot \u003d driver_utils.get_node_capability(node, \u0027secure_boot\u0027)"},{"line_number":377,"context_line":"    loc_boot \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    if sec_boot \u003d\u003d \u0027true\u0027 and loc_boot \u003d\u003d \u0027local\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_eabe7bfe","line":376,"updated":"2015-04-07 08:58:05.000000000","message":"Food for thought: I wonder if you should use driver_utils.get_boot_mode_for_deploy() here instead. Because capabilities is only used when Ironic is being used with Nova and that method also looks at the boot_mode set in the instance_info field, which is common to set if you\u0027re using Ironic in standalone mode.\n\nI also see that validate() only validates the boot_mode and boot_option set on the capabilities field, so it would require some plumbing work and so on. I think we can leave as-is right now. But lemme know if the idea makes sense for u.","commit_id":"31eefae7eca824f6587293581933513c2e95e030"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"347a39c7077d3c1273e4149914efc58da3719a63","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def _validate_secure_boot_with_local_boot(node):"},{"line_number":376,"context_line":"    sec_boot \u003d driver_utils.get_node_capability(node, \u0027secure_boot\u0027)"},{"line_number":377,"context_line":"    loc_boot \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    if sec_boot \u003d\u003d \u0027true\u0027 and loc_boot \u003d\u003d \u0027local\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_fdf87e7e","line":376,"in_reply_to":"9aa53dc9_eabe7bfe","updated":"2015-04-07 11:18:53.000000000","message":"I agree. have opened a bug to track the same.\nhttps://bugs.launchpad.net/ironic/+bug/1441114","commit_id":"31eefae7eca824f6587293581933513c2e95e030"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"984af9adb40836501194f307c9a30f9f2061d796","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def _validate_secure_boot_with_local_boot(node):"},{"line_number":376,"context_line":"    sec_boot \u003d driver_utils.get_node_capability(node, \u0027secure_boot\u0027)"},{"line_number":377,"context_line":"    loc_boot \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    if sec_boot \u003d\u003d \u0027true\u0027 and loc_boot \u003d\u003d \u0027local\u0027:"},{"line_number":380,"context_line":"        LOG.error(_LE(\"Local boot is not supported in UEFI secure boot \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_aa2cf34a","line":377,"updated":"2015-04-07 08:58:05.000000000","message":"Would be nice to have something similar to boot_option","commit_id":"31eefae7eca824f6587293581933513c2e95e030"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"347a39c7077d3c1273e4149914efc58da3719a63","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def _validate_secure_boot_with_local_boot(node):"},{"line_number":376,"context_line":"    sec_boot \u003d driver_utils.get_node_capability(node, \u0027secure_boot\u0027)"},{"line_number":377,"context_line":"    loc_boot \u003d driver_utils.get_node_capability(node, \u0027boot_option\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    if sec_boot \u003d\u003d \u0027true\u0027 and loc_boot \u003d\u003d \u0027local\u0027:"},{"line_number":380,"context_line":"        LOG.error(_LE(\"Local boot is not supported in UEFI secure boot \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_9def32b0","line":377,"in_reply_to":"9aa53dc9_aa2cf34a","updated":"2015-04-07 11:18:53.000000000","message":"Done","commit_id":"31eefae7eca824f6587293581933513c2e95e030"}]}