)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76cbd270272f655369e258297127b3c6cc1853ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As part of other changes for this release, we prioritised"},{"line_number":10,"context_line":"descriptiveness over backwards compatibility.  In subsequent"},{"line_number":11,"context_line":"discussions we\u0027ve agreed this is incorrect, so this change"},{"line_number":12,"context_line":"makes some reverts."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I44bb804186733016e8bbfc67987cdd4ad17b8151"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_fc12ad61","line":12,"updated":"2015-03-31 01:31:07.000000000","message":"I actually think this is a bug -- that we broke backwards compatibility. I think there should be a bug associated with this.\n\nI also think this commit could be more specific, that with the logical names change, we were returning 406 whereas before it was 400 blah blah.","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"f08f9f722124f6c091af18da07baf116bafb5812","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As part of other changes for this release, we prioritised"},{"line_number":10,"context_line":"descriptiveness over backwards compatibility.  In subsequent"},{"line_number":11,"context_line":"discussions we\u0027ve agreed this is incorrect, so this change"},{"line_number":12,"context_line":"makes some reverts."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I44bb804186733016e8bbfc67987cdd4ad17b8151"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_3f06c7ce","line":12,"in_reply_to":"da9b358b_fc12ad61","updated":"2015-03-31 02:16:53.000000000","message":"Well, the only thing we\u0027re changing so far is the error text returned.  There\u0027s no revert for 406s into 400s.\n\nI\u0027ll update the commit tag to make it more appropriate.\n\nI\u0027ve raised bug 1438478 for this, and referenced it here","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a623cc3e11aacbe31782c40e6005c30f6c5188fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Davies \u003cmichael@the-davies.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-30 19:15:57 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve backwards compat on API behaviour"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of other changes for this release, we prioritised"},{"line_number":10,"context_line":"descriptiveness over backwards compatibility.  In subsequent"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_4d8bf8c3","line":7,"updated":"2015-03-31 22:04:05.000000000","message":"Would be nice if this was more specific, but nothing comes to mind, that is \u003c 50 chars long :)","commit_id":"a4f3c84b02a6735ff54f69273add3a6c5a43f545"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a623cc3e11aacbe31782c40e6005c30f6c5188fe","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As part of other changes for this release, we prioritised"},{"line_number":10,"context_line":"descriptiveness over backwards compatibility.  In subsequent"},{"line_number":11,"context_line":"discussions we\u0027ve agreed this is incorrect.  This change"},{"line_number":12,"context_line":"ensures that the same exception is raised on UUID not found."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1438478"},{"line_number":15,"context_line":"Change-Id: I44bb804186733016e8bbfc67987cdd4ad17b8151"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_8dffc066","line":12,"updated":"2015-03-31 22:04:05.000000000","message":"I find this commit message somewhat vague.\n\nThe same exception is raised as in Juno. When a node (not UUID) is not found, right? Because a UUID wasn\u0027t provided in the request.","commit_id":"a4f3c84b02a6735ff54f69273add3a6c5a43f545"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"8c382003fa5603aa887b2a5de01f91e63d87218f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As part of other changes for this release, we prioritised"},{"line_number":10,"context_line":"descriptiveness over backwards compatibility.  In subsequent"},{"line_number":11,"context_line":"discussions we\u0027ve agreed this is incorrect.  This change"},{"line_number":12,"context_line":"ensures that the same exception is raised on UUID not found."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1438478"},{"line_number":15,"context_line":"Change-Id: I44bb804186733016e8bbfc67987cdd4ad17b8151"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_a08b9467","line":12,"in_reply_to":"da9b358b_8dffc066","updated":"2015-04-01 12:42:36.000000000","message":"For me, the vagueness is eliminated when read after the text from the bug report. If you want to transfer some of that here, that\u0027s fine. But I\u0027m ok with this as it is, too, since the bug is linked.","commit_id":"a4f3c84b02a6735ff54f69273add3a6c5a43f545"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76cbd270272f655369e258297127b3c6cc1853ca","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    :returns: The RPC Node."},{"line_number":106,"context_line":"    :raises: InvalidUuidOrName if the name or uuid provided is not valid."},{"line_number":107,"context_line":"    :raises: NodeNotFound if the node is not found."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":"    # Check to see if the node_ident is a valid UUID.  If it is, treat it"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_1c99d11f","line":107,"updated":"2015-03-31 01:31:07.000000000","message":"also :raises: InvalidUUID","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"2693c4c38585416377a84f7a1fb086f9b780bb5f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    :returns: The RPC Node."},{"line_number":106,"context_line":"    :raises: InvalidUuidOrName if the name or uuid provided is not valid."},{"line_number":107,"context_line":"    :raises: NodeNotFound if the node is not found."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":"    # Check to see if the node_ident is a valid UUID.  If it is, treat it"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_e2b7a4f3","line":107,"in_reply_to":"da9b358b_1c99d11f","updated":"2015-03-31 02:40:59.000000000","message":"Not required anymore","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76cbd270272f655369e258297127b3c6cc1853ca","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # It\u0027s not a valid uuid or not valid name and we allow names"},{"line_number":121,"context_line":"    if allow_logical_names():"},{"line_number":122,"context_line":"        raise exception.InvalidUuidOrName(name\u003dnode_ident)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Backwards compatibility mode"},{"line_number":125,"context_line":"    raise exception.InvalidUUID(uuid\u003dnode_ident)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_9c73a1e7","line":122,"updated":"2015-03-31 01:31:07.000000000","message":"I think it might be easier to understand if the code was structured something like\n    if allow_logical_names():\n        if utils.is_hostname_safe():\n            return ...\n        else raise ...","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"f08f9f722124f6c091af18da07baf116bafb5812","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # It\u0027s not a valid uuid or not valid name and we allow names"},{"line_number":121,"context_line":"    if allow_logical_names():"},{"line_number":122,"context_line":"        raise exception.InvalidUuidOrName(name\u003dnode_ident)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Backwards compatibility mode"},{"line_number":125,"context_line":"    raise exception.InvalidUUID(uuid\u003dnode_ident)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_3f7a47f2","line":122,"in_reply_to":"da9b358b_9c73a1e7","updated":"2015-03-31 02:16:53.000000000","message":"Thanks Ruby for the review - done.","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76cbd270272f655369e258297127b3c6cc1853ca","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if allow_logical_names():"},{"line_number":122,"context_line":"        raise exception.InvalidUuidOrName(name\u003dnode_ident)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Backwards compatibility mode"},{"line_number":125,"context_line":"    raise exception.InvalidUUID(uuid\u003dnode_ident)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_bc5f8540","line":124,"updated":"2015-03-31 01:31:07.000000000","message":"I know what this means cuz we\u0027ve been discussing it. Will someone understand this comment if they are just reading the code later?","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"f08f9f722124f6c091af18da07baf116bafb5812","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    if allow_logical_names():"},{"line_number":122,"context_line":"        raise exception.InvalidUuidOrName(name\u003dnode_ident)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Backwards compatibility mode"},{"line_number":125,"context_line":"    raise exception.InvalidUUID(uuid\u003dnode_ident)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_1f7d43e7","line":124,"in_reply_to":"da9b358b_bc5f8540","updated":"2015-03-31 02:16:53.000000000","message":"Done","commit_id":"a6ae26c8cd65fa4d0f50aa549378040313cb0f60"}]}