)]}'
{"doc/source/deploy/cleaning.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"In-Band vs Out-of-Band"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"Ironic uses two main methods to perform actions on a node: in-band and"},{"line_number":37,"context_line":"out-of-band. Ironic supports using both methods to clean a node."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In-Band"},{"line_number":40,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_0e11bcac","line":37,"updated":"2015-04-07 04:02:01.000000000","message":"s/using/use of\n\ns/methods/the methods","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"43902adea79ca281ec7994f9b6d757a1318c4103","unresolved":false,"context_lines":[{"line_number":87,"context_line":"following config::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  [ilo]"},{"line_number":90,"context_line":"  clean_priority_erase_devices\u003d0"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"What clean_step is running?"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_eabb040d","line":90,"updated":"2015-04-07 16:20:11.000000000","message":"Why does iLo have a different setting for this? That seems strange and potentially broken...","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"8fa1ad1c9a12786cef1cc9b4be11dc69d989a1cf","unresolved":false,"context_lines":[{"line_number":87,"context_line":"following config::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  [ilo]"},{"line_number":90,"context_line":"  clean_priority_erase_devices\u003d0"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"What clean_step is running?"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_5913b566","line":90,"in_reply_to":"9aa53dc9_48b53c2f","updated":"2015-04-08 18:30:29.000000000","message":"I agree, I would like to see this refactored in L to be cleaner. but having said that, I think Lucas is correct here.","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"a0910f155724846f8a1668495c2d44b7c014b152","unresolved":false,"context_lines":[{"line_number":87,"context_line":"following config::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  [ilo]"},{"line_number":90,"context_line":"  clean_priority_erase_devices\u003d0"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"What clean_step is running?"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_433ee88c","line":90,"in_reply_to":"9aa53dc9_5913b566","updated":"2015-04-13 03:13:51.000000000","message":"The idea before for introducing this option was to have separate configuration for drivers and not to mix and match between drivers, so not to confuse the operators.\n\nNow, with having a separate config option \n1. For all Ilo* drivers, operator can set all the clean steps at one place.\n2. Second, giving operator to enable/disable the steps per driver.\n3. Third, even if Ilo drivers decouple from IPA and use different approach of    performing erase_devices in future, having this option will seamlessly work even if the internal implementation changes.\n\nI agree may be having different option now may be  redundant as both agent_ilo and IPA uses same approach. But i think having different option will be better instead of tight coupling between drivers.","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"018b125446b7e782d0af71ebdac837e76e351a77","unresolved":false,"context_lines":[{"line_number":87,"context_line":"following config::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  [ilo]"},{"line_number":90,"context_line":"  clean_priority_erase_devices\u003d0"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"What clean_step is running?"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_48b53c2f","line":90,"in_reply_to":"9aa53dc9_eabb040d","updated":"2015-04-08 09:18:59.000000000","message":"Yeah :-( apparently we are not being consistent with names (again).\n\nBut it looks this is the right config option to iLO anyway[1]\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L54-L57","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"}],"doc/source/drivers/ilo.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"467013e8bd2a4605ab2a21813e98bdb8effe7ec2","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Node cleaning"},{"line_number":254,"context_line":"~~~~~~~~~~~~~"},{"line_number":255,"context_line":"Refer node_cleaning_ for more information."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"agent_ilo driver"},{"line_number":258,"context_line":"^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_f5e1d0ff","line":255,"updated":"2015-04-01 20:31:16.000000000","message":"Refer to node_cleaning_","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"556dcc3801c36b3e77ce0bf727d821b8387b45f2","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Node cleaning"},{"line_number":254,"context_line":"~~~~~~~~~~~~~"},{"line_number":255,"context_line":"Refer node_cleaning_ for more information."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"agent_ilo driver"},{"line_number":258,"context_line":"^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_7c091d95","line":255,"in_reply_to":"baa041b7_f5e1d0ff","updated":"2015-04-02 09:41:00.000000000","message":"Done","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"467013e8bd2a4605ab2a21813e98bdb8effe7ec2","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"Node Cleaning"},{"line_number":432,"context_line":"~~~~~~~~~~~~~"},{"line_number":433,"context_line":"Refer node_cleaning_ for more information."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"pxe_ilo driver"},{"line_number":436,"context_line":"^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_b5e4680d","line":433,"updated":"2015-04-01 20:31:16.000000000","message":"Ditto","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"556dcc3801c36b3e77ce0bf727d821b8387b45f2","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"Node Cleaning"},{"line_number":432,"context_line":"~~~~~~~~~~~~~"},{"line_number":433,"context_line":"Refer node_cleaning_ for more information."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"pxe_ilo driver"},{"line_number":436,"context_line":"^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_5cfe596c","line":433,"in_reply_to":"baa041b7_b5e4680d","updated":"2015-04-02 09:41:00.000000000","message":"Done","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"467013e8bd2a4605ab2a21813e98bdb8effe7ec2","unresolved":false,"context_lines":[{"line_number":595,"context_line":"Supported Cleaning Operations"},{"line_number":596,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":597,"context_line":"The cleaning operations supported are:"},{"line_number":598,"context_line":"* ``reset_ilo`` :"},{"line_number":599,"context_line":"    - Resets the iLO. Enabled, by default with priority 1."},{"line_number":600,"context_line":"* ``reset_bios_to_default``:"},{"line_number":601,"context_line":"    - Resets BIOS Settings to default. Enabled, by default with priority 10."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_1599d46e","line":598,"updated":"2015-04-01 20:31:16.000000000","message":"Need a blank line before this line. Also remove the space before the :","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"556dcc3801c36b3e77ce0bf727d821b8387b45f2","unresolved":false,"context_lines":[{"line_number":595,"context_line":"Supported Cleaning Operations"},{"line_number":596,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":597,"context_line":"The cleaning operations supported are:"},{"line_number":598,"context_line":"* ``reset_ilo`` :"},{"line_number":599,"context_line":"    - Resets the iLO. Enabled, by default with priority 1."},{"line_number":600,"context_line":"* ``reset_bios_to_default``:"},{"line_number":601,"context_line":"    - Resets BIOS Settings to default. Enabled, by default with priority 10."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_1cf9f180","line":598,"in_reply_to":"baa041b7_1599d46e","updated":"2015-04-02 09:41:00.000000000","message":"Done","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"467013e8bd2a4605ab2a21813e98bdb8effe7ec2","unresolved":false,"context_lines":[{"line_number":613,"context_line":"* For agent_ilo driver, in addition to the above clean steps, in-band cleaning"},{"line_number":614,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":615,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":616,"context_line":"  secure erase is supported, else fall-back to ``shred`` unix command."},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":619,"context_line":"  In-order to disable or change the priority of the clean steps, respective"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_15e794e5","line":616,"updated":"2015-04-01 20:31:16.000000000","message":"Should we add that shred will take a long time here?","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"556dcc3801c36b3e77ce0bf727d821b8387b45f2","unresolved":false,"context_lines":[{"line_number":613,"context_line":"* For agent_ilo driver, in addition to the above clean steps, in-band cleaning"},{"line_number":614,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":615,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":616,"context_line":"  secure erase is supported, else fall-back to ``shred`` unix command."},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":619,"context_line":"  In-order to disable or change the priority of the clean steps, respective"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_dc4949d2","line":616,"in_reply_to":"baa041b7_15e794e5","updated":"2015-04-02 09:41:00.000000000","message":"Done","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"467013e8bd2a4605ab2a21813e98bdb8effe7ec2","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":619,"context_line":"  In-order to disable or change the priority of the clean steps, respective"},{"line_number":620,"context_line":"  configuration option for priority should be updated in ironic.conf"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"  Configuration Options for the clean steps are listed under [ilo] section in"},{"line_number":623,"context_line":"  ironic.conf:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_35097896","line":620,"updated":"2015-04-01 20:31:16.000000000","message":"Nit end sentence with a period.\n\nShould probably also mention that 0 means disabled.","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"556dcc3801c36b3e77ce0bf727d821b8387b45f2","unresolved":false,"context_lines":[{"line_number":617,"context_line":""},{"line_number":618,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":619,"context_line":"  In-order to disable or change the priority of the clean steps, respective"},{"line_number":620,"context_line":"  configuration option for priority should be updated in ironic.conf"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"  Configuration Options for the clean steps are listed under [ilo] section in"},{"line_number":623,"context_line":"  ironic.conf:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_c57e0cae","line":620,"in_reply_to":"baa041b7_35097896","updated":"2015-04-02 09:41:00.000000000","message":"Done","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"467013e8bd2a4605ab2a21813e98bdb8effe7ec2","unresolved":false,"context_lines":[{"line_number":627,"context_line":"  - clean_priority_reset_bios_to_default\u003d10"},{"line_number":628,"context_line":"  - clean_priority_reset_secure_boot_keys_to_default\u003d20"},{"line_number":629,"context_line":"  - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":630,"context_line":"  - clean_priority_reset_ilo_credential\u003d30"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"References"},{"line_number":633,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_d5d12cfd","line":630,"updated":"2015-04-01 20:31:16.000000000","message":"Should we mention the agent erase_devices priority config here? Or link to cleaning docs for the agent?","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"556dcc3801c36b3e77ce0bf727d821b8387b45f2","unresolved":false,"context_lines":[{"line_number":627,"context_line":"  - clean_priority_reset_bios_to_default\u003d10"},{"line_number":628,"context_line":"  - clean_priority_reset_secure_boot_keys_to_default\u003d20"},{"line_number":629,"context_line":"  - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":630,"context_line":"  - clean_priority_reset_ilo_credential\u003d30"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"References"},{"line_number":633,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa041b7_4540bc56","line":630,"in_reply_to":"baa041b7_d5d12cfd","updated":"2015-04-02 09:41:00.000000000","message":"agent erase_devices config option wont be used for agent_ilo driver, there is one more config option defined in ilo section clean_priority_erase_devices\u003d\u003cNone\u003e mentioned above.","commit_id":"201f58e8411aade8a7777200bdf50e504b9512fa"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3eb39c43d7ab39d3a00fa84f3a987f87d5f50485","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  (like PXE driver), so this driver has the  benefit of security"},{"line_number":101,"context_line":"  enhancement with the same performance. Hence it segregates management info"},{"line_number":102,"context_line":"  from data channel."},{"line_number":103,"context_line":"* Out-Of-Band cleaning support during node tear-down."},{"line_number":104,"context_line":"* Remote Console"},{"line_number":105,"context_line":"* HW Sensors"},{"line_number":106,"context_line":"* Works well for machines with resource constraints (lesser amount of memory)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_cb9ba8c8","line":103,"updated":"2015-04-02 18:22:14.000000000","message":"I don\u0027t like using the term \"during node tear-down\" here, because it\u0027s not exactly true (for instance; Nova would see the instance deleted).\n\nI\u0027d do something more like:\n\n* Support for Out-Of-Band Cleaning operations\n\nWith maybe a citation pointing to cleaning docs (http://docs.openstack.org/developer/ironic/deploy/cleaning.html) -- in fact -- it might be worth putting the link back to *here* in the out-of-band secion of that doc too.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  (like PXE driver), so this driver has the  benefit of security"},{"line_number":101,"context_line":"  enhancement with the same performance. Hence it segregates management info"},{"line_number":102,"context_line":"  from data channel."},{"line_number":103,"context_line":"* Out-Of-Band cleaning support during node tear-down."},{"line_number":104,"context_line":"* Remote Console"},{"line_number":105,"context_line":"* HW Sensors"},{"line_number":106,"context_line":"* Works well for machines with resource constraints (lesser amount of memory)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_10d3bb05","line":103,"in_reply_to":"baa041b7_cb9ba8c8","updated":"2015-04-06 09:09:00.000000000","message":"Updated the ref to cleaning doc in node cleaning section. Will update the other changes. Thanks","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3eb39c43d7ab39d3a00fa84f3a987f87d5f50485","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Features"},{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Out-Of-Band cleaning support during tear-down."},{"line_number":288,"context_line":"* In-band secure disk erase during tear-down."},{"line_number":289,"context_line":"* Remote Console"},{"line_number":290,"context_line":"* HW Sensors"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_cbe9681c","line":287,"updated":"2015-04-02 18:22:14.000000000","message":"Same comment as before;\n\nI\u0027d do something more like:\n\n* Support for Out-Of-Band Cleaning operations\n\nWith maybe a citation pointing to cleaning docs (http://docs.openstack.org/developer/ironic/deploy/cleaning.html) -- in fact -- it might be worth putting the link back to *here* in the out-of-band secion of that doc too.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3eb39c43d7ab39d3a00fa84f3a987f87d5f50485","unresolved":false,"context_lines":[{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Out-Of-Band cleaning support during tear-down."},{"line_number":288,"context_line":"* In-band secure disk erase during tear-down."},{"line_number":289,"context_line":"* Remote Console"},{"line_number":290,"context_line":"* HW Sensors"},{"line_number":291,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_4b979890","line":288,"updated":"2015-04-02 18:22:14.000000000","message":"in-band secure erase is not provided by the iLo driver; it\u0027s provided by other drivers (like the agent), right?","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Out-Of-Band cleaning support during tear-down."},{"line_number":288,"context_line":"* In-band secure disk erase during tear-down."},{"line_number":289,"context_line":"* Remote Console"},{"line_number":290,"context_line":"* HW Sensors"},{"line_number":291,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_35a35451","line":288,"in_reply_to":"baa041b7_4b979890","updated":"2015-04-06 09:09:00.000000000","message":"yes, it\u0027s provided by agent driver, but the same will be available while using agent_ilo driver also, so added as supported feature when using this driver.\n\nShould be fine right?","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3eb39c43d7ab39d3a00fa84f3a987f87d5f50485","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"  disk-image-create ubuntu baremetal iso"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":".. _node_cleaning:"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning support during tear_down:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_ebb66c3c","line":584,"updated":"2015-04-02 18:22:14.000000000","message":"This section should be linked to from the Cleaning docs that have landed (probably in the out-of-band drivers section?). This is awesome, thanks!","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":581,"context_line":""},{"line_number":582,"context_line":"  disk-image-create ubuntu baremetal iso"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":".. _node_cleaning:"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning support during tear_down:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_d0dc3314","line":584,"in_reply_to":"baa041b7_ebb66c3c","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":".. _node_cleaning:"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning support during tear_down:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support, below cleaning operations to be invoked as part"},{"line_number":589,"context_line":"of node tear_down."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_781ea964","line":586,"updated":"2015-04-02 22:02:21.000000000","message":"It isn\u0027t just in tear down, is it? And don\u0027t use \u0027tear_down\u0027 with the underscore, since this is a document, and tear_down isn\u0027t a variable or method here :-)\n\nAren\u0027t the nodes cleaned before they are first made available? The state diagram shows MANAGEABLE -\u003e CLEAN* -\u003e AVAILABLE.\n\nOH, so maybe just \u0027Node Cleaning\u0027 for the section header? (See Jay\u0027s comments above wrt \u0027tear down\u0027.)","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":".. _node_cleaning:"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning support during tear_down:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support, below cleaning operations to be invoked as part"},{"line_number":589,"context_line":"of node tear_down."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_d59428e3","line":586,"in_reply_to":"baa041b7_781ea964","updated":"2015-04-06 09:09:00.000000000","message":"yes, right. Thanks Ruby. Cleaning will be done when moving the node from \u0027Manageable\u0027 to \u0027Available\u0027 also. Will update it.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":586,"context_line":"Node Cleaning support during tear_down:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support, below cleaning operations to be invoked as part"},{"line_number":589,"context_line":"of node tear_down."},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"* ``pxe_ilo``"},{"line_number":592,"context_line":"* ``iscsi_ilo``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_d8f6d5f8","line":589,"updated":"2015-04-02 22:02:21.000000000","message":"How about just \u0027These drivers support node cleaning::\u0027","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":586,"context_line":"Node Cleaning support during tear_down:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support, below cleaning operations to be invoked as part"},{"line_number":589,"context_line":"of node tear_down."},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"* ``pxe_ilo``"},{"line_number":592,"context_line":"* ``iscsi_ilo``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_55b7f885","line":589,"in_reply_to":"baa041b7_d8f6d5f8","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":597,"context_line":"The cleaning operations supported are:"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"* ``reset_ilo``:"},{"line_number":600,"context_line":"    Resets the iLO. Enabled, by default with priority 1."},{"line_number":601,"context_line":"* ``reset_bios_to_default``:"},{"line_number":602,"context_line":"    Resets BIOS Settings to default. Enabled, by default with priority 10."},{"line_number":603,"context_line":"    This clean step is supported only on Gen9 and above servers."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_bbcb0b53","line":600,"updated":"2015-04-02 22:02:21.000000000","message":"Maybe it is just me, but I am not sure what you mean by \u0027Enabled, by default with ...\u0027\n\nI interpret it as:\n\nThe operation is always enabled, with priority 1 being the default\n\n\nBut I was wondering if you might mean:\n\nBy default, the operation is enabled with priority 1\n\nAh, ok, I read more, I think you mean the latter. So I\u0027d rephrase them all to something like \u0027By default, enabled with priority X\u0027.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":597,"context_line":"The cleaning operations supported are:"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"* ``reset_ilo``:"},{"line_number":600,"context_line":"    Resets the iLO. Enabled, by default with priority 1."},{"line_number":601,"context_line":"* ``reset_bios_to_default``:"},{"line_number":602,"context_line":"    Resets BIOS Settings to default. Enabled, by default with priority 10."},{"line_number":603,"context_line":"    This clean step is supported only on Gen9 and above servers."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_35ba346f","line":600,"in_reply_to":"baa041b7_bbcb0b53","updated":"2015-04-06 09:09:00.000000000","message":"Actually I phrased initially the same \u0027By default, enabled\u0027 , somehow changed again in last minute :-) . This actually sounds better now :P .. will update it.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    Clears all secure boot keys. This step is supported only on Gen9 and above"},{"line_number":612,"context_line":"    servers. Disabled, by default."},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"* For agent_ilo driver, in addition to the above clean steps, in-band cleaning"},{"line_number":615,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":616,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_fb5ab382","line":614,"updated":"2015-04-02 22:02:21.000000000","message":"Is this meant to be a bullet like the above? Then maybe ``disk_erase``: does in-band disk erase. Only available for agent_ilo driver. etc...? \n\n(I\u0027m not quite sure where/why the above names were derived so I don\u0027t know if \u0027disk_erase\u0027 is the right term, but I hope you know what I mean.)","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    Clears all secure boot keys. This step is supported only on Gen9 and above"},{"line_number":612,"context_line":"    servers. Disabled, by default."},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"* For agent_ilo driver, in addition to the above clean steps, in-band cleaning"},{"line_number":615,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":616,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_157970c8","line":614,"in_reply_to":"baa041b7_fb5ab382","updated":"2015-04-06 09:09:00.000000000","message":"Phrased them according to the options available as part of config file. Will update the above.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3eb39c43d7ab39d3a00fa84f3a987f87d5f50485","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"* For agent_ilo driver, in addition to the above clean steps, in-band cleaning"},{"line_number":615,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":616,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"},{"line_number":618,"context_line":"  command."},{"line_number":619,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_4b4c3842","line":616,"updated":"2015-04-02 18:22:14.000000000","message":"the `hdparm` secure erase is generally referred to as an ATA Security Erase. It just happens that hdparm is the best tool on linux for calling arbitrary ATA commands.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"* For agent_ilo driver, in addition to the above clean steps, in-band cleaning"},{"line_number":615,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":616,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"},{"line_number":618,"context_line":"  command."},{"line_number":619,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_50ff0367","line":616,"in_reply_to":"baa041b7_4b4c3842","updated":"2015-04-06 09:09:00.000000000","message":"ok, thanks. will update it","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3eb39c43d7ab39d3a00fa84f3a987f87d5f50485","unresolved":false,"context_lines":[{"line_number":615,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":616,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"},{"line_number":618,"context_line":"  command."},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"  **NOTE**:Disk erase using ``shred`` command, might take considerably long time"},{"line_number":621,"context_line":"  to complete."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_ebbb0c0d","line":618,"updated":"2015-04-02 18:22:14.000000000","message":"IMO, this should cite docs about agent in-band cleaning. If/when more cleaning steps are added by default to the agent, nobody will think to come update this doc as well.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":615,"context_line":"  operation disk erase is also supported. Default configuration used by"},{"line_number":616,"context_line":"  ironic-python-agent would be invoked for disk erase, i.e uses ``hdparm`` if"},{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"},{"line_number":618,"context_line":"  command."},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"  **NOTE**:Disk erase using ``shred`` command, might take considerably long time"},{"line_number":621,"context_line":"  to complete."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_e0bf6cf9","line":618,"in_reply_to":"baa041b7_ebbb0c0d","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"},{"line_number":618,"context_line":"  command."},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"  **NOTE**:Disk erase using ``shred`` command, might take considerably long time"},{"line_number":621,"context_line":"  to complete."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"* All the cleaning steps have an explicit configuration option for priority."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_9b228700","line":620,"updated":"2015-04-02 22:02:21.000000000","message":"s/:Disk/: Disk/\n\ns/might take considerably long time/may take a considerable amount of time/","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":617,"context_line":"  secure erase is supported for ATA disks , else fall-back to ``shred`` unix"},{"line_number":618,"context_line":"  command."},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"  **NOTE**:Disk erase using ``shred`` command, might take considerably long time"},{"line_number":621,"context_line":"  to complete."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"* All the cleaning steps have an explicit configuration option for priority."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_b502c409","line":620,"in_reply_to":"baa041b7_9b228700","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":620,"context_line":"  **NOTE**:Disk erase using ``shred`` command, might take considerably long time"},{"line_number":621,"context_line":"  to complete."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":624,"context_line":"  In-order to disable or change the priority of the clean steps, respective"},{"line_number":625,"context_line":"  configuration option for priority should be updated in ironic.conf."},{"line_number":626,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_7b9463e1","line":623,"updated":"2015-04-02 22:02:21.000000000","message":"Organizationally, I don\u0027t think the rest of these bullets should be in the same \u0027group\u0027 as the above bullets. Maybe you can add a line above it with something like \u0027The above cleaning operations (or steps) can be individually configured:\u0027\n\nOr just get rid of the bullets and make these paragraphs.","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":620,"context_line":"  **NOTE**:Disk erase using ``shred`` command, might take considerably long time"},{"line_number":621,"context_line":"  to complete."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":624,"context_line":"  In-order to disable or change the priority of the clean steps, respective"},{"line_number":625,"context_line":"  configuration option for priority should be updated in ironic.conf."},{"line_number":626,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_30023f70","line":623,"in_reply_to":"baa041b7_7b9463e1","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":621,"context_line":"  to complete."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":624,"context_line":"  In-order to disable or change the priority of the clean steps, respective"},{"line_number":625,"context_line":"  configuration option for priority should be updated in ironic.conf."},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"* Updating clean step priority to 0, will disable that particular clean step"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_7b2103fb","line":624,"updated":"2015-04-02 22:02:21.000000000","message":"s/In-order/In order/","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":621,"context_line":"  to complete."},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"* All the cleaning steps have an explicit configuration option for priority."},{"line_number":624,"context_line":"  In-order to disable or change the priority of the clean steps, respective"},{"line_number":625,"context_line":"  configuration option for priority should be updated in ironic.conf."},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"* Updating clean step priority to 0, will disable that particular clean step"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_10fa9b75","line":624,"in_reply_to":"baa041b7_7b2103fb","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4b8ebb76eb1ae4a14b9fda4adf08f342ce2ce421","unresolved":false,"context_lines":[{"line_number":637,"context_line":"  - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":638,"context_line":"  - clean_priority_reset_ilo_credential\u003d30"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"For more information on node cleaning, refer [7]_."},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"References"},{"line_number":643,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_7b07c31c","line":640,"updated":"2015-04-02 22:02:21.000000000","message":"s/refer/see/","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"e2418280b9e4f89885f71fd7ee93ebc402c485d9","unresolved":false,"context_lines":[{"line_number":637,"context_line":"  - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":638,"context_line":"  - clean_priority_reset_ilo_credential\u003d30"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"For more information on node cleaning, refer [7]_."},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"References"},{"line_number":643,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baa041b7_00c13080","line":640,"in_reply_to":"baa041b7_7b07c31c","updated":"2015-04-06 09:09:00.000000000","message":"Done","commit_id":"42c8f94910734f7b0399281c41652620ad0e9ae8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Node cleaning"},{"line_number":254,"context_line":"~~~~~~~~~~~~~"},{"line_number":255,"context_line":"Refer to ilo_node_cleaning_ for more information."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"agent_ilo driver"},{"line_number":258,"context_line":"^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_0973f6b2","line":255,"updated":"2015-04-07 04:02:01.000000000","message":"s/ilo_node_cleaning_/`Node Cleaning`_","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f8e33846752502e5b57348f38db2f8854e1caa8f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Support for Out-Of-Band cleaning operations."},{"line_number":288,"context_line":"* In-band secure disk erase during tear-down."},{"line_number":289,"context_line":"* Remote Console"},{"line_number":290,"context_line":"* HW Sensors"},{"line_number":291,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_815b7154","line":288,"updated":"2015-04-06 16:48:49.000000000","message":"I disagree that this should stay; nobody will know to update this doc when IPA behavior changes. I think you should just reference In-Band cleaning docs for in-band operations.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6b6dfccd2bf1d98212ef9b6ec1434cb2f4e0405a","unresolved":false,"context_lines":[{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Support for Out-Of-Band cleaning operations."},{"line_number":288,"context_line":"* In-band secure disk erase during tear-down."},{"line_number":289,"context_line":"* Remote Console"},{"line_number":290,"context_line":"* HW Sensors"},{"line_number":291,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_c6d182fd","line":288,"in_reply_to":"9aa53dc9_0b12d362","updated":"2015-04-06 23:09:48.000000000","message":"For cleaning, it\u0027s already done. See: http://docs.openstack.org/developer/ironic/deploy/cleaning.html#in-band-vs-out-of-band","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"1399b7695e26cb3399fad64487a718b48d36db3b","unresolved":false,"context_lines":[{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Support for Out-Of-Band cleaning operations."},{"line_number":288,"context_line":"* In-band secure disk erase during tear-down."},{"line_number":289,"context_line":"* Remote Console"},{"line_number":290,"context_line":"* HW Sensors"},{"line_number":291,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_0b12d362","line":288,"in_reply_to":"9aa53dc9_815b7154","updated":"2015-04-06 22:52:23.000000000","message":"Do we need to document \"in-band\" vs. \"out-of-band\"?    What\u0027s \"in-band\" for iLO driver in kilo may get switched to OOB in Liberty.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"Node Cleaning"},{"line_number":432,"context_line":"~~~~~~~~~~~~~"},{"line_number":433,"context_line":"Refer to ilo_node_cleaning_ for more information."},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"pxe_ilo driver"},{"line_number":436,"context_line":"^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_8e7eecac","line":433,"updated":"2015-04-07 04:02:01.000000000","message":"s/ilo_node_cleaning_/`Node Cleaning`_","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":520,"context_line":"  ironic node-create -d pxe_ilo ilo_address\u003d\u003cilo-ip-address\u003e -i ilo_username\u003d\u003cilo-username\u003e -i ilo_password\u003d\u003cilo-password\u003e -i pxe_deploy_kernel\u003d\u003cglance-uuid-of-pxe-deploy-kernel\u003e pxe_deploy_ramdisk\u003d\u003cglance-uuid-of-deploy-ramdisk\u003e"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"Boot modes"},{"line_number":523,"context_line":"~~~~~~~~~~"},{"line_number":524,"context_line":"Refer boot_mode_support_ for more information."},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"Functionalities across drivers"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_0981b64a","line":523,"updated":"2015-04-07 04:02:01.000000000","message":"Need add Node cleaning supported section for pxe_ilo here.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":".. _ilo_node_cleaning:"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support node cleaning::"},{"line_number":589,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_2e6da004","line":586,"updated":"2015-04-07 04:02:01.000000000","message":"Remove \u0027:\u0027","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"3b1b81dad7a4ecfb5f4018572c6dfb9d63c49851","unresolved":false,"context_lines":[{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support node cleaning::"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"* ``pxe_ilo``"},{"line_number":591,"context_line":"* ``iscsi_ilo``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_819371a3","line":588,"updated":"2015-04-06 16:36:13.000000000","message":"Might want to be explicit here that these support  iLO cleaning. We don\u0027t want to give someone the impression they can only clean with iLO hardware.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support node cleaning::"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"* ``pxe_ilo``"},{"line_number":591,"context_line":"* ``iscsi_ilo``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_0e409c55","line":588,"in_reply_to":"9aa53dc9_412c49ab","updated":"2015-04-07 04:02:01.000000000","message":"There are few features which are not supported across all iLO drivers, (e.g. boot mode) hence explicitly mentioning the supported drivers per feature has been norm. This will maintains the consistency of the document.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f8e33846752502e5b57348f38db2f8854e1caa8f","unresolved":false,"context_lines":[{"line_number":585,"context_line":""},{"line_number":586,"context_line":"Node Cleaning:"},{"line_number":587,"context_line":"^^^^^^^^^^^^^^"},{"line_number":588,"context_line":"The following drivers support node cleaning::"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"* ``pxe_ilo``"},{"line_number":591,"context_line":"* ``iscsi_ilo``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_412c49ab","line":588,"in_reply_to":"9aa53dc9_819371a3","updated":"2015-04-06 16:48:49.000000000","message":"+1\n\nAlso wondering if we should just specify, again, instead of the full driver, just *_ilo. Wondering if this doc will ever get updated when/if new drivers get created.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f8e33846752502e5b57348f38db2f8854e1caa8f","unresolved":false,"context_lines":[{"line_number":610,"context_line":"  -``clear_secure_boot_keys``:"},{"line_number":611,"context_line":"    Clears all secure boot keys. This step is supported only on Gen9 and above"},{"line_number":612,"context_line":"    servers. By default, this step is disabled."},{"line_number":613,"context_line":"  -``erase_devices``:"},{"line_number":614,"context_line":"    Performs in-band disk-erase. This step is only supported for **agent_ilo**"},{"line_number":615,"context_line":"    driver. Default configuration supported by ironic-python-agent would be"},{"line_number":616,"context_line":"    invoked, i.e ATA Security erase if supported, else fall-back to ``shred``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_5c1aec6f","line":613,"updated":"2015-04-06 16:48:49.000000000","message":"As this is an in-band cleaning operation, I again suggest this just reference the in-band docuemntation. Having the information spread everywhere means we\u0027re very likely to miss updating the docs as behavior changes.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c45863ab6b78bef63c6584cace1888c974cf51c4","unresolved":false,"context_lines":[{"line_number":610,"context_line":"  -``clear_secure_boot_keys``:"},{"line_number":611,"context_line":"    Clears all secure boot keys. This step is supported only on Gen9 and above"},{"line_number":612,"context_line":"    servers. By default, this step is disabled."},{"line_number":613,"context_line":"  -``erase_devices``:"},{"line_number":614,"context_line":"    Performs in-band disk-erase. This step is only supported for **agent_ilo**"},{"line_number":615,"context_line":"    driver. Default configuration supported by ironic-python-agent would be"},{"line_number":616,"context_line":"    invoked, i.e ATA Security erase if supported, else fall-back to ``shred``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_89bb860e","line":613,"in_reply_to":"9aa53dc9_5c1aec6f","updated":"2015-04-07 04:02:01.000000000","message":"+1. We need to document it only if we are providing behavior different from one provided by default","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10202,"name":"Wan-yen Hsu","email":"wanyenhsu@gmail.com"},"change_message_id":"1399b7695e26cb3399fad64487a718b48d36db3b","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    driver. Default configuration supported by ironic-python-agent would be"},{"line_number":616,"context_line":"    invoked, i.e ATA Security erase if supported, else fall-back to ``shred``"},{"line_number":617,"context_line":"    unix command."},{"line_number":618,"context_line":" "},{"line_number":619,"context_line":"    **NOTE**: Disk erase using ``shred`` command, may take considerably amount"},{"line_number":620,"context_line":"    of time to complete."},{"line_number":621,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_86625ad7","line":618,"updated":"2015-04-06 22:52:23.000000000","message":"Given that we pan to change disk erase for iLO drivers in Liberty, I suggest that we don\u0027t document how internally iLO driver implemetns disk erase for Kilo.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f8e33846752502e5b57348f38db2f8854e1caa8f","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    driver. Default configuration supported by ironic-python-agent would be"},{"line_number":616,"context_line":"    invoked, i.e ATA Security erase if supported, else fall-back to ``shred``"},{"line_number":617,"context_line":"    unix command."},{"line_number":618,"context_line":" "},{"line_number":619,"context_line":"    **NOTE**: Disk erase using ``shred`` command, may take considerably amount"},{"line_number":620,"context_line":"    of time to complete."},{"line_number":621,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_41032910","line":618,"updated":"2015-04-06 16:48:49.000000000","message":"nit: whitespace","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"3b1b81dad7a4ecfb5f4018572c6dfb9d63c49851","unresolved":false,"context_lines":[{"line_number":632,"context_line":"* Configuration Options for the clean steps are listed under [ilo] section in"},{"line_number":633,"context_line":"  ironic.conf ::"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"  - clean_priority_erase_devices\u003d\u003cNone\u003e"},{"line_number":636,"context_line":"  - clean_priority_reset_ilo\u003d1"},{"line_number":637,"context_line":"  - clean_priority_reset_bios_to_default\u003d10"},{"line_number":638,"context_line":"  - clean_priority_reset_secure_boot_keys_to_default\u003d20"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_21a145aa","line":635,"updated":"2015-04-06 16:36:13.000000000","message":"This looks confusing (though I know it actually defaults to None). I would mention that the default agent will by return 10 as the priority.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f8e33846752502e5b57348f38db2f8854e1caa8f","unresolved":false,"context_lines":[{"line_number":632,"context_line":"* Configuration Options for the clean steps are listed under [ilo] section in"},{"line_number":633,"context_line":"  ironic.conf ::"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"  - clean_priority_erase_devices\u003d\u003cNone\u003e"},{"line_number":636,"context_line":"  - clean_priority_reset_ilo\u003d1"},{"line_number":637,"context_line":"  - clean_priority_reset_bios_to_default\u003d10"},{"line_number":638,"context_line":"  - clean_priority_reset_secure_boot_keys_to_default\u003d20"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aa53dc9_5c5f8c0e","line":635,"in_reply_to":"9aa53dc9_21a145aa","updated":"2015-04-06 16:48:49.000000000","message":"I\u0027d suggest this stick to iLO configuration options. I think it\u0027s clear we need an agent cleaning document, but I\u0027d rather those in-band bits be removed from this and put into the cleaning document in the in-band section.","commit_id":"ff2cb87584d648920015776ec29b24039355c811"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29ab2b00c61a22f65cc07f3e859fedbbd0982f70","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Features"},{"line_number":285,"context_line":"~~~~~~~~"},{"line_number":286,"context_line":"* PXE-less deploy with Virtual Media using Ironic Python Agent."},{"line_number":287,"context_line":"* Support for Out-Of-Band cleaning operations."},{"line_number":288,"context_line":"* Remote Console"},{"line_number":289,"context_line":"* HW Sensors"},{"line_number":290,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_5bad9b99","line":287,"updated":"2015-04-10 15:25:26.000000000","message":"nit: out-of-band (no cap)","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29ab2b00c61a22f65cc07f3e859fedbbd0982f70","unresolved":false,"context_lines":[{"line_number":290,"context_line":"* IPA runs on the baremetal node and pulls the image directly from Swift."},{"line_number":291,"context_line":"* IPA deployed instances always boots from local disk."},{"line_number":292,"context_line":"* Segregates management info from data channel."},{"line_number":293,"context_line":"* Added support to use default in-band cleaning operations supported by"},{"line_number":294,"context_line":"  Ironic Python Agent. For more details, see :ref:`InbandvsOutOfBandCleaning`."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Requirements"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_3b8097f4","line":293,"updated":"2015-04-10 15:25:26.000000000","message":"nit: s/Added//","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29ab2b00c61a22f65cc07f3e859fedbbd0982f70","unresolved":false,"context_lines":[{"line_number":468,"context_line":"* Automatic detection of current boot mode."},{"line_number":469,"context_line":"* Automatic setting of the required boot mode if UEFI boot mode is requested"},{"line_number":470,"context_line":"  by the nova flavor\u0027s extra spec."},{"line_number":471,"context_line":"* Support for Out-Of-Band cleaning operations."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"Requirements"},{"line_number":474,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_fbac6f8d","line":471,"updated":"2015-04-10 15:25:26.000000000","message":"ditto about out-of-band","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"018b125446b7e782d0af71ebdac837e76e351a77","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"  disk-image-create ubuntu baremetal iso"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":".. _ilo_node_cleaning:"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"Node Cleaning"},{"line_number":593,"context_line":"^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_8847c41c","line":590,"updated":"2015-04-08 09:18:59.000000000","message":"I don\u0027t think you need it to, titles are also links. \n\nTo go to \"Node Cleaning\" e.g, you can just do `Node Cleaning`_ and it will link to that tile.\n\nAnyway, I see other parts are using the same mechanism, so...","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"a0910f155724846f8a1668495c2d44b7c014b152","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"  disk-image-create ubuntu baremetal iso"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":".. _ilo_node_cleaning:"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"Node Cleaning"},{"line_number":593,"context_line":"^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_235644ce","line":590,"in_reply_to":"9aa53dc9_8847c41c","updated":"2015-04-13 03:13:51.000000000","message":"yes, thanks for letting me know :)  but anyway we need a label to refer the iLO node cleaning section in general cleaning doc, so used the same here.","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29ab2b00c61a22f65cc07f3e859fedbbd0982f70","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    node\u0027s driver_info. By default, enabled with priority 30."},{"line_number":616,"context_line":"  -``clear_secure_boot_keys``:"},{"line_number":617,"context_line":"    Clears all secure boot keys. This step is supported only on Gen9 and above"},{"line_number":618,"context_line":"    servers. By default, this step is disabled."},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"},{"line_number":621,"context_line":"  :ref:`InbandvsOutOfBandCleaning`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_bbbdc7d9","line":618,"updated":"2015-04-10 15:25:26.000000000","message":"nit: it would be nice to have real list here (use *)","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"43902adea79ca281ec7994f9b6d757a1318c4103","unresolved":false,"context_lines":[{"line_number":635,"context_line":"  - clean_priority_reset_secure_boot_keys_to_default\u003d20"},{"line_number":636,"context_line":"  - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":637,"context_line":"  - clean_priority_reset_ilo_credential\u003d30"},{"line_number":638,"context_line":"  - clean_priority_erase_devices\u003d10"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"For more information on node cleaning, see [7]_."},{"line_number":641,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9aa53dc9_ca05e0c2","line":638,"updated":"2015-04-07 16:20:11.000000000","message":"Again, curious why this is a setting on *iLo* and not on agent?","commit_id":"c3ae8bf31b2524a3f6d53fec9dec98aebd63ee0c"}]}