)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"def notify_ramdisk_to_proceed(address):"},{"line_number":755,"context_line":"    \"\"\"Notifies the completion of deployment to the baremetal node."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    :param address: The IP address of the node."},{"line_number":758,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_c4ddd515","line":755,"updated":"2015-04-02 20:17:57.000000000","message":"I suppose you could elaborate on this, since you changed the method name.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"def notify_ramdisk_to_proceed(address):"},{"line_number":755,"context_line":"    \"\"\"Notifies the completion of deployment to the baremetal node."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    :param address: The IP address of the node."},{"line_number":758,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_074e0396","line":755,"in_reply_to":"baa041b7_c4ddd515","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c9ab04dfd8221060c4344df90d211279e66b955a","unresolved":false,"context_lines":[{"line_number":754,"context_line":"def notify_ramdisk_to_proceed(address):"},{"line_number":755,"context_line":"    \"\"\"Notifies the ramdisk waiting for instructions from Ironic."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    Bash ramdisk (DIB ramdisk) makes vendor passhthrus and listens"},{"line_number":758,"context_line":"    on port 10000 for Ironic to notify back the completion of the task."},{"line_number":759,"context_line":"    This method connects to port 10000 of the bare metal running the"},{"line_number":760,"context_line":"    ramdisk and then sends some data to notify the ramdisk to proceed"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_8d645822","line":757,"updated":"2015-04-06 08:55:02.000000000","message":"Bash ramdisk -\u003e Shell script. DIB ramdisk uses busybox shell.","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5d87ca08933de1764f113992f5bc0de089d6ddda","unresolved":false,"context_lines":[{"line_number":754,"context_line":"def notify_ramdisk_to_proceed(address):"},{"line_number":755,"context_line":"    \"\"\"Notifies the ramdisk waiting for instructions from Ironic."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    Bash ramdisk (DIB ramdisk) makes vendor passhthrus and listens"},{"line_number":758,"context_line":"    on port 10000 for Ironic to notify back the completion of the task."},{"line_number":759,"context_line":"    This method connects to port 10000 of the bare metal running the"},{"line_number":760,"context_line":"    ramdisk and then sends some data to notify the ramdisk to proceed"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_708c4735","line":757,"in_reply_to":"baa041b7_8d645822","updated":"2015-04-06 09:01:30.000000000","message":"Done","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"afa524efaf06c154204a744d434710a13482a401","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if method \u003d\u003d \u0027pass_deploy_info\u0027:"},{"line_number":719,"context_line":"            iscsi_deploy.get_deploy_info(task.node, **kwargs)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def _configure_vmedia_boot(self, task, root_uuid):"},{"line_number":723,"context_line":"        \"\"\"Configure vmedia boot for the node.\"\"\""},{"line_number":724,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_f8a61952","line":721,"updated":"2015-03-31 16:54:08.000000000","message":"nit: new line","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c442be7ba42decb7c47cf31b2b7bc5f0a01469d4","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        if method \u003d\u003d \u0027pass_deploy_info\u0027:"},{"line_number":719,"context_line":"            iscsi_deploy.get_deploy_info(task.node, **kwargs)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    def _configure_vmedia_boot(self, task, root_uuid):"},{"line_number":723,"context_line":"        \"\"\"Configure vmedia boot for the node.\"\"\""},{"line_number":724,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_fded4026","line":721,"in_reply_to":"da9b358b_f8a61952","updated":"2015-04-01 17:11:06.000000000","message":"Done","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"afa524efaf06c154204a744d434710a13482a401","unresolved":false,"context_lines":[{"line_number":744,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":745,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        node \u003d task.node"},{"line_number":748,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_986eedff","line":747,"updated":"2015-03-31 16:54:08.000000000","message":"Is node being used?","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c442be7ba42decb7c47cf31b2b7bc5f0a01469d4","unresolved":false,"context_lines":[{"line_number":744,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":745,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        node \u003d task.node"},{"line_number":748,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_7dda507a","line":747,"in_reply_to":"da9b358b_986eedff","updated":"2015-04-01 17:11:06.000000000","message":"Done","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"afa524efaf06c154204a744d434710a13482a401","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":796,"context_line":"                # \u0027pass_bootloader_install_info\u0027."},{"line_number":797,"context_line":"                deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":798,"context_line":"                task.process_event(\u0027wait\u0027)"},{"line_number":799,"context_line":"                return"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_1883fd99","line":798,"updated":"2015-03-31 16:54:08.000000000","message":"have unittests been added for this code path?","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c442be7ba42decb7c47cf31b2b7bc5f0a01469d4","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":796,"context_line":"                # \u0027pass_bootloader_install_info\u0027."},{"line_number":797,"context_line":"                deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":798,"context_line":"                task.process_event(\u0027wait\u0027)"},{"line_number":799,"context_line":"                return"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_fdd42048","line":798,"in_reply_to":"da9b358b_1883fd99","updated":"2015-04-01 17:11:06.000000000","message":"Done","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":748,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":749,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":750,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":751,"context_line":"        then it sets provisioning as fail and powers off the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_1187ab62","line":748,"updated":"2015-04-01 18:56:07.000000000","message":"s/bootloader/the bootloader/g","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":745,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":748,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":749,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":750,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":751,"context_line":"        then it sets provisioning as fail and powers off the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_4fe224d7","line":748,"in_reply_to":"baa041b7_1187ab62","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":748,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":749,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":750,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":751,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":752,"context_line":"        \"\"\""},{"line_number":753,"context_line":"        task.process_event(\u0027resume\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_9193bba3","line":750,"updated":"2015-04-01 18:56:07.000000000","message":"s/turns/makes/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":748,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":749,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":750,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":751,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":752,"context_line":"        \"\"\""},{"line_number":753,"context_line":"        task.process_event(\u0027resume\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_2fe7e0e5","line":750,"in_reply_to":"baa041b7_9193bba3","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":749,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":750,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":751,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":752,"context_line":"        \"\"\""},{"line_number":753,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":754,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_518d337a","line":751,"updated":"2015-04-01 18:56:07.000000000","message":"s/fail/failed/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":749,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":750,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":751,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":752,"context_line":"        \"\"\""},{"line_number":753,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":754,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_0fec1cc6","line":751,"in_reply_to":"baa041b7_518d337a","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            msg \u003d _(\u0027Failed to continue iSCSI deployment.\u0027)"},{"line_number":811,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":812,"context_line":"        else:"},{"line_number":813,"context_line":"            iscsi_deploy.finish_deploy(task, kwargs.get(\u0027address\u0027))"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":816,"context_line":"    def continue_deploy(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_d17263ad","line":813,"updated":"2015-04-01 18:56:07.000000000","message":"I don\u0027t see a unit test for the code path where this is being called.  Or at least a test to make sure it is called in that code path.","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            msg \u003d _(\u0027Failed to continue iSCSI deployment.\u0027)"},{"line_number":811,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":812,"context_line":"        else:"},{"line_number":813,"context_line":"            iscsi_deploy.finish_deploy(task, kwargs.get(\u0027address\u0027))"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":816,"context_line":"    def continue_deploy(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_0f03fc74","line":813,"in_reply_to":"baa041b7_d17263ad","updated":"2015-04-02 02:36:37.000000000","message":"This is covered in test_pass_deploy_info_good in https://review.openstack.org/#/c/169419/4/ironic/tests/drivers/ilo/test_deploy.py where we assert that the node has turned active (lines 798-799)","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"191dbff34a6792be6d60c5a723be3f44144b81d2","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":743,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":744,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":745,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        This method acts as a vendorpassthru and accepts the result of"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_253b78d3","line":744,"updated":"2015-04-02 09:04:05.000000000","message":"For avoid code duplication this method can be added via mixin class.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3837550ae5d01780c5f577d2c6398e916c08ccc9","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":743,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":744,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":745,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        This method acts as a vendorpassthru and accepts the result of"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_70b01cde","line":744,"in_reply_to":"baa041b7_253b78d3","updated":"2015-04-02 09:34:14.000000000","message":"ditto as comment in pxe.py","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5c4b659db04d9b38715d793082bc1d045e065997","unresolved":false,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"            # For iscsi_ilo driver, we boot from disk every time if the image"},{"line_number":800,"context_line":"            # deployed is a whole disk image."},{"line_number":801,"context_line":"            if iscsi_deploy.get_boot_option(node) \u003d\u003d \"local\" or iwdi:"},{"line_number":802,"context_line":"                manager_utils.node_set_boot_device(task, boot_devices.DISK,"},{"line_number":803,"context_line":"                                                   persistent\u003dTrue)"},{"line_number":804,"context_line":"                # Ask the ramdisk to install bootloader and"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_6b35d144","line":801,"updated":"2015-04-02 09:59:45.000000000","message":"Boot loader should not be installed for iwdi.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"691b7c4dfba46f6345e347f48e10c02da7fc78f6","unresolved":false,"context_lines":[{"line_number":798,"context_line":""},{"line_number":799,"context_line":"            # For iscsi_ilo driver, we boot from disk every time if the image"},{"line_number":800,"context_line":"            # deployed is a whole disk image."},{"line_number":801,"context_line":"            if iscsi_deploy.get_boot_option(node) \u003d\u003d \"local\" or iwdi:"},{"line_number":802,"context_line":"                manager_utils.node_set_boot_device(task, boot_devices.DISK,"},{"line_number":803,"context_line":"                                                   persistent\u003dTrue)"},{"line_number":804,"context_line":"                # Ask the ramdisk to install bootloader and"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_b27461fd","line":801,"in_reply_to":"baa041b7_6b35d144","updated":"2015-04-02 13:41:18.000000000","message":"Done","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ddbbeb3c64e9d35a3b6b6f867171a7105339fa12","unresolved":false,"context_lines":[{"line_number":805,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":806,"context_line":"                # \u0027pass_bootloader_install_info\u0027."},{"line_number":807,"context_line":"                deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":808,"context_line":"                task.process_event(\u0027wait\u0027)"},{"line_number":809,"context_line":"                return"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_bc767a3c","line":808,"updated":"2015-04-02 12:45:35.000000000","message":"I would if we should go back to the DEPLOYWAIT state here. I can see the value of it to indicate that we are waiting the ramdisk to signalize us back saying the bootloader is completed. But this behavior differs from the IPA which does everything (copy image \u0026 bootloader installation) when the machine is in the DEPLOYING state.\n\nIt\u0027s not a big deal tho, but I think it worth commenting to see what people think.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"691b7c4dfba46f6345e347f48e10c02da7fc78f6","unresolved":false,"context_lines":[{"line_number":805,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":806,"context_line":"                # \u0027pass_bootloader_install_info\u0027."},{"line_number":807,"context_line":"                deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":808,"context_line":"                task.process_event(\u0027wait\u0027)"},{"line_number":809,"context_line":"                return"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_d277e500","line":808,"in_reply_to":"baa041b7_bc767a3c","updated":"2015-04-02 13:41:18.000000000","message":"From IPA side, we had a confirmation of whether the bare metal the boot loader installation is happening or not.  But here, we can\u0027t confirm it - for example if someone was using an older ramdisk OR the bare metal got powered off, or something like that.  If we leave it in DEPLOYING, that would never timeout (we don\u0027t consider nodes in DEPLOYING state for timeout), and hence the node would be stuck in deploying for ever.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        bootloader installation. If the bootloader installation was"},{"line_number":762,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_4940c0a5","line":764,"updated":"2015-04-02 20:17:57.000000000","message":"nit, add a blank line after this.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        bootloader installation. If the bootloader installation was"},{"line_number":762,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_67594f5a","line":764,"in_reply_to":"baa041b7_4940c0a5","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a9174ca2","line":765,"updated":"2015-04-02 20:17:57.000000000","message":"s/TaskManage/TaskManager/","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_47540b20","line":765,"in_reply_to":"baa041b7_a9174ca2","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"23bc2403001e68c604124de2f257fc50cc9caf0b","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":769,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_e4d8d91f","line":766,"updated":"2015-04-02 19:54:39.000000000","message":"Multiple things here:\n\n1) s/passhthru/passthru/\n2) s/send/sent/ \n\n3) If you want this to render correctly in generated docs, try something like this (:: + blockquoting next lines is RST for a code block):\n\n:param thing: A dict that looks like::\n  {\n   \u0027key1\u0027: value,\n   \u0027key2\u0027: value2\n  }","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":769,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_29245c0b","line":766,"updated":"2015-04-02 20:17:57.000000000","message":"s/send/sent/\n\ns/passhthru/passthru/","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":769,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_c73edbd9","line":766,"in_reply_to":"baa041b7_29245c0b","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"},{"line_number":764,"context_line":"        then it sets provisioning as failed and powers off the node."},{"line_number":765,"context_line":"        :param task: A TaskManage object."},{"line_number":766,"context_line":"        :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":769,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_0735e3f5","line":766,"in_reply_to":"baa041b7_e4d8d91f","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":769,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"},{"line_number":770,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":773,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_c44dd573","line":770,"updated":"2015-04-02 20:17:57.000000000","message":"and \u0027address\u0027 ?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            keys are:"},{"line_number":768,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":769,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"},{"line_number":770,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":773,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a72637cc","line":770,"in_reply_to":"baa041b7_c44dd573","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":770,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":773,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":774,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @base.passthru([\u0027POST\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a4bf71cf","line":773,"updated":"2015-04-02 20:17:57.000000000","message":"if the deploy key is incorrect, the node will be in \u0027deploying\u0027 provision state. Then what? Is the node stuck in this state forever?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":770,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":773,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":774,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @base.passthru([\u0027POST\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_8a645ae5","line":773,"in_reply_to":"baa041b7_a4bf71cf","updated":"2015-04-03 15:48:46.000000000","message":"Yeah this is correct.  This is an existing problem in the pxe vendorpassthru\u0027s, probably it should be everywhere changed.  I will file a bug and change all 4 vendorpassthrus to check the key before resuming.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":773,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":774,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":777,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_04a05d9e","line":774,"updated":"2015-04-02 20:17:57.000000000","message":"what if kwargs[\u0027address\u0027] doesn\u0027t exist?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":773,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":774,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":777,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_4a5e5213","line":774,"in_reply_to":"baa041b7_04a05d9e","updated":"2015-04-03 15:48:46.000000000","message":"Done.  Should exist in all cases as it\u0027s not a human invoking this vendorpassthru.  But I will add a check anyway.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a whole"},{"line_number":821,"context_line":"                # disk image."},{"line_number":822,"context_line":"                if not iwdi:"},{"line_number":823,"context_line":"                    deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":824,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":825,"context_line":"                    return"},{"line_number":826,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_e4a7b94d","line":823,"updated":"2015-04-02 20:17:57.000000000","message":"what if kwargs[\u0027address\u0027] doesn\u0027t exist?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b1ab5d9e271e875ac5d89e1bec11f36473c8f912","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a whole"},{"line_number":821,"context_line":"                # disk image."},{"line_number":822,"context_line":"                if not iwdi:"},{"line_number":823,"context_line":"                    deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":824,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":825,"context_line":"                    return"},{"line_number":826,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_65ba6725","line":823,"in_reply_to":"baa041b7_aa971e8f","updated":"2015-04-03 16:40:22.000000000","message":"This is caught in iscsi_deploy.continue_deploy() when iscsi_deploy.get_deploy_info() is called.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a whole"},{"line_number":821,"context_line":"                # disk image."},{"line_number":822,"context_line":"                if not iwdi:"},{"line_number":823,"context_line":"                    deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":824,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":825,"context_line":"                    return"},{"line_number":826,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_aa971e8f","line":823,"in_reply_to":"baa041b7_e4a7b94d","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"a4a9e82c4cbc2f8a4cfa5d8ab08e490a282ae0e7","unresolved":false,"context_lines":[{"line_number":757,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":758,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":761,"context_line":"        bootloader installation. If the bootloader installation was"},{"line_number":762,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":763,"context_line":"        and makes the instance active. If bootloader installation failed,"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_96147f44","line":760,"updated":"2015-04-03 17:24:03.000000000","message":"s/vendorpassthru/vendor passthru/","commit_id":"3827b111a92d80b57a984af3f334886e74beed91"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"a4a9e82c4cbc2f8a4cfa5d8ab08e490a282ae0e7","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                                                   persistent\u003dTrue)"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"                # Ask the ramdisk to install bootloader and"},{"line_number":823,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":824,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a whole"},{"line_number":825,"context_line":"                # disk image."},{"line_number":826,"context_line":"                if not iwdi:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_363013e8","line":823,"updated":"2015-04-03 17:24:03.000000000","message":"s/vendor-passthru/vendor passthru/","commit_id":"3827b111a92d80b57a984af3f334886e74beed91"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c9ab04dfd8221060c4344df90d211279e66b955a","unresolved":false,"context_lines":[{"line_number":771,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":772,"context_line":"                \u0027address\u0027: The IP address of the ramdisk"},{"line_number":773,"context_line":"        \"\"\""},{"line_number":774,"context_line":"        iscsi_deploy.validate_pass_bootloader_info_input("},{"line_number":775,"context_line":"            task, kwargs)"},{"line_number":776,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":777,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_90834b56","line":774,"updated":"2015-04-06 08:55:02.000000000","message":"Ditto about validation (see pxe driver).","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5d87ca08933de1764f113992f5bc0de089d6ddda","unresolved":false,"context_lines":[{"line_number":771,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":772,"context_line":"                \u0027address\u0027: The IP address of the ramdisk"},{"line_number":773,"context_line":"        \"\"\""},{"line_number":774,"context_line":"        iscsi_deploy.validate_pass_bootloader_info_input("},{"line_number":775,"context_line":"            task, kwargs)"},{"line_number":776,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":777,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_90890b29","line":774,"in_reply_to":"baa041b7_90834b56","updated":"2015-04-06 09:01:30.000000000","message":"Done","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"afa524efaf06c154204a744d434710a13482a401","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":549,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":550,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":553,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_7810c9a8","line":550,"updated":"2015-03-31 16:54:08.000000000","message":"Should the returned and expected value be in the message?","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c442be7ba42decb7c47cf31b2b7bc5f0a01469d4","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":549,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":550,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":553,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_7d48102e","line":550,"in_reply_to":"da9b358b_7810c9a8","updated":"2015-04-01 17:11:06.000000000","message":"I think we need not as it\u0027s supposed to be an authorization mechanism. We do this already:\n\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L232","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    was successful or not."},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    :param task: A TaskManage object."},{"line_number":552,"context_line":"    :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":553,"context_line":"        keys are:"},{"line_number":554,"context_line":"            \u0027key\u0027: The deploy key for authorization"},{"line_number":555,"context_line":"            \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_b1afdfe2","line":552,"updated":"2015-04-01 18:56:07.000000000","message":"s/send/sent/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    was successful or not."},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    :param task: A TaskManage object."},{"line_number":552,"context_line":"    :param kwargs: The arguments send with vendor passhthru.  The expected"},{"line_number":553,"context_line":"        keys are:"},{"line_number":554,"context_line":"            \u0027key\u0027: The deploy key for authorization"},{"line_number":555,"context_line":"            \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_ef6d7833","line":552,"in_reply_to":"baa041b7_b1afdfe2","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"def finish_deploy(task, address):"},{"line_number":578,"context_line":"    \"\"\"Notifies the ramdisk to reboot node and makes instance active."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"},{"line_number":581,"context_line":"    turns the instance active."}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_71bef700","line":578,"updated":"2015-04-01 18:56:07.000000000","message":"s/node/the node/\n\ns/instance/the instance/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"def finish_deploy(task, address):"},{"line_number":578,"context_line":"    \"\"\"Notifies the ramdisk to reboot node and makes instance active."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"},{"line_number":581,"context_line":"    turns the instance active."}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_8f74acfd","line":578,"in_reply_to":"baa041b7_71bef700","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    \"\"\"Notifies the ramdisk to reboot node and makes instance active."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"},{"line_number":581,"context_line":"    turns the instance active."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    :param task: a TaskManage object"},{"line_number":584,"context_line":"    :param address: The IP address of the bare metal"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_f140c709","line":581,"updated":"2015-04-01 18:56:07.000000000","message":"s/turns/makes/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    \"\"\"Notifies the ramdisk to reboot node and makes instance active."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"},{"line_number":581,"context_line":"    turns the instance active."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    :param task: a TaskManage object"},{"line_number":584,"context_line":"    :param address: The IP address of the bare metal"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_6f604836","line":581,"in_reply_to":"baa041b7_f140c709","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    turns the instance active."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    :param task: a TaskManage object"},{"line_number":584,"context_line":"    :param address: The IP address of the bare metal"},{"line_number":585,"context_line":"    :raises: InstanceDeployFailure, if notifying ramdisk failed."},{"line_number":586,"context_line":"    \"\"\""},{"line_number":587,"context_line":"    node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_7155d7c4","line":584,"updated":"2015-04-01 18:56:07.000000000","message":"s/metal/metal node/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    turns the instance active."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"    :param task: a TaskManage object"},{"line_number":584,"context_line":"    :param address: The IP address of the bare metal"},{"line_number":585,"context_line":"    :raises: InstanceDeployFailure, if notifying ramdisk failed."},{"line_number":586,"context_line":"    \"\"\""},{"line_number":587,"context_line":"    node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_4f658443","line":584,"in_reply_to":"baa041b7_7155d7c4","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"191dbff34a6792be6d60c5a723be3f44144b81d2","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        LOG.error(_LE(\u0027Deploy failed for instance %(instance)s. \u0027"},{"line_number":592,"context_line":"                      \u0027Error: %(error)s\u0027),"},{"line_number":593,"context_line":"                  {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"},{"line_number":594,"context_line":"        msg \u003d _(\u0027Failed to continue iSCSI deployment.\u0027)"},{"line_number":595,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":596,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_c28de27c","line":594,"updated":"2015-04-02 09:04:05.000000000","message":"1) Maybe \u0027Failed to notify ramdisk...\u0027? 2) set_failed_state() writes msg to node.last_error, makes sense include error to msg.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3837550ae5d01780c5f577d2c6398e916c08ccc9","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        LOG.error(_LE(\u0027Deploy failed for instance %(instance)s. \u0027"},{"line_number":592,"context_line":"                      \u0027Error: %(error)s\u0027),"},{"line_number":593,"context_line":"                  {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"},{"line_number":594,"context_line":"        msg \u003d _(\u0027Failed to continue iSCSI deployment.\u0027)"},{"line_number":595,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":596,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_e5db501a","line":594,"in_reply_to":"baa041b7_c28de27c","updated":"2015-04-02 09:34:14.000000000","message":"Done","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":550,"context_line":"    was correct one, and then validates whether bootloader installation"},{"line_number":551,"context_line":"    was successful or not."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    :param task: A TaskManage object."},{"line_number":554,"context_line":"    :param kwargs: The arguments sent with vendor passhthru.  The expected"},{"line_number":555,"context_line":"        keys are:"},{"line_number":556,"context_line":"            \u0027key\u0027: The deploy key for authorization"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_c474b59d","line":553,"updated":"2015-04-02 20:17:57.000000000","message":"s/TaskManage/TaskManager/","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":550,"context_line":"    was correct one, and then validates whether bootloader installation"},{"line_number":551,"context_line":"    was successful or not."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    :param task: A TaskManage object."},{"line_number":554,"context_line":"    :param kwargs: The arguments sent with vendor passhthru.  The expected"},{"line_number":555,"context_line":"        keys are:"},{"line_number":556,"context_line":"            \u0027key\u0027: The deploy key for authorization"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_8ad9fa85","line":553,"in_reply_to":"baa041b7_c474b59d","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    was successful or not."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    :param task: A TaskManage object."},{"line_number":554,"context_line":"    :param kwargs: The arguments sent with vendor passhthru.  The expected"},{"line_number":555,"context_line":"        keys are:"},{"line_number":556,"context_line":"            \u0027key\u0027: The deploy key for authorization"},{"line_number":557,"context_line":"            \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_6473a9b2","line":554,"updated":"2015-04-02 20:17:57.000000000","message":"s/passhthru/passthru/","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":551,"context_line":"    was successful or not."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    :param task: A TaskManage object."},{"line_number":554,"context_line":"    :param kwargs: The arguments sent with vendor passhthru.  The expected"},{"line_number":555,"context_line":"        keys are:"},{"line_number":556,"context_line":"            \u0027key\u0027: The deploy key for authorization"},{"line_number":557,"context_line":"            \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_6ae8f610","line":554,"in_reply_to":"baa041b7_6473a9b2","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    \"\"\""},{"line_number":564,"context_line":"    deploy_key \u003d task.node.instance_info[\u0027deploy_key\u0027]"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a4a091f5","line":566,"updated":"2015-04-02 20:17:57.000000000","message":"Shouldn\u0027t we check if \u0027key\u0027 exists?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    \"\"\""},{"line_number":564,"context_line":"    deploy_key \u003d task.node.instance_info[\u0027deploy_key\u0027]"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_4ae3f233","line":566,"in_reply_to":"baa041b7_a4a091f5","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_c4827552","line":568,"updated":"2015-04-02 20:17:57.000000000","message":"For debugging, it might be useful to log the deploy keys.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_eacac6a0","line":568,"in_reply_to":"baa041b7_c4827552","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"85164af3b7f2d29e21bb497cdcae5548781c5b10","unresolved":false,"context_lines":[{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    if deploy_key !\u003d kwargs[\u0027key\u0027]:"},{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a0b17d91","line":568,"in_reply_to":"baa041b7_eacac6a0","updated":"2015-04-03 16:35:30.000000000","message":"hah!  That\u0027s what I said before :)","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"},{"line_number":572,"context_line":"                 \u0027Error: %(error)s.\u0027) %"},{"line_number":573,"context_line":"               {\u0027node\u0027: task.node.uuid, \u0027error\u0027: kwargs[\u0027error\u0027]})"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_04917d99","line":570,"updated":"2015-04-02 20:17:57.000000000","message":"what if kwargs[\u0027status\u0027] doesn\u0027t exist?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key does not match\"))"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"},{"line_number":572,"context_line":"                 \u0027Error: %(error)s.\u0027) %"},{"line_number":573,"context_line":"               {\u0027node\u0027: task.node.uuid, \u0027error\u0027: kwargs[\u0027error\u0027]})"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_aac5de8e","line":570,"in_reply_to":"baa041b7_04917d99","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"},{"line_number":572,"context_line":"                 \u0027Error: %(error)s.\u0027) %"},{"line_number":573,"context_line":"               {\u0027node\u0027: task.node.uuid, \u0027error\u0027: kwargs[\u0027error\u0027]})"},{"line_number":574,"context_line":"        LOG.error(msg)"},{"line_number":575,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":576,"context_line":"        raise exception.InstanceDeployFailure(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_c4e9551c","line":573,"updated":"2015-04-02 20:17:57.000000000","message":"what if kwargs[\u0027error\u0027] doesn\u0027t exist?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    if kwargs[\u0027status\u0027] !\u003d \u0027SUCCEEDED\u0027:"},{"line_number":571,"context_line":"        msg \u003d (_(\u0027Failed to install bootloader on node %(node)s. \u0027"},{"line_number":572,"context_line":"                 \u0027Error: %(error)s.\u0027) %"},{"line_number":573,"context_line":"               {\u0027node\u0027: task.node.uuid, \u0027error\u0027: kwargs[\u0027error\u0027]})"},{"line_number":574,"context_line":"        LOG.error(msg)"},{"line_number":575,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":576,"context_line":"        raise exception.InstanceDeployFailure(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_6abfd6fb","line":573,"in_reply_to":"baa041b7_c4e9551c","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"},{"line_number":583,"context_line":"    makes the instance active."},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    :param task: a TaskManage object"},{"line_number":586,"context_line":"    :param address: The IP address of the bare metal node"},{"line_number":587,"context_line":"    :raises: InstanceDeployFailure, if notifying ramdisk failed."},{"line_number":588,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a4941137","line":585,"updated":"2015-04-02 20:17:57.000000000","message":"s/TaskManage/TaskManager/","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    This method notifies the ramdisk to proceed to reboot and then"},{"line_number":583,"context_line":"    makes the instance active."},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    :param task: a TaskManage object"},{"line_number":586,"context_line":"    :param address: The IP address of the bare metal node"},{"line_number":587,"context_line":"    :raises: InstanceDeployFailure, if notifying ramdisk failed."},{"line_number":588,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_4a9bf272","line":585,"in_reply_to":"baa041b7_a4941137","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                      \u0027Error: %(error)s\u0027),"},{"line_number":595,"context_line":"                  {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"},{"line_number":596,"context_line":"        msg \u003d (_(\u0027Failed to notify ramdisk to reboot after bootloader \u0027"},{"line_number":597,"context_line":"                 \u0027installation. Error: %s\u0027) % e)"},{"line_number":598,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":599,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_a4cc1136","line":597,"updated":"2015-04-02 20:17:57.000000000","message":"Interesting. msg is going to be used for the node\u0027s last error. And I thought that the user facing stuff was meant to be more \u0027general\u0027, whereas we should log the details (like it failing to notify ramdisk...). Ie, I would have reversed these two strings.\n\nBut maybe it is a matter of different perspective. I looked at other usages, and most use the same message for logging and last_error. So I dunno.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                      \u0027Error: %(error)s\u0027),"},{"line_number":595,"context_line":"                  {\u0027instance\u0027: node.instance_uuid, \u0027error\u0027: e})"},{"line_number":596,"context_line":"        msg \u003d (_(\u0027Failed to notify ramdisk to reboot after bootloader \u0027"},{"line_number":597,"context_line":"                 \u0027installation. Error: %s\u0027) % e)"},{"line_number":598,"context_line":"        deploy_utils.set_failed_state(task, msg)"},{"line_number":599,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":600,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_4ac0922a","line":597,"in_reply_to":"baa041b7_a4cc1136","updated":"2015-04-03 15:48:46.000000000","message":"Yeah, I would prefer this getting logged in node.last_error also.  Both node.last_error and logging messages are operator facing and not user (I mean requester of node, incase of Nova) facing.  In any rate, my opinion is logging this to node.last_error is going to save the headache for operator to grep through the logs (may be after several hours) to find what was the issue.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"a4a9e82c4cbc2f8a4cfa5d8ab08e490a282ae0e7","unresolved":false,"context_lines":[{"line_number":575,"context_line":"def validate_bootloader_install_status(task, input_params):"},{"line_number":576,"context_line":"    \"\"\"Validate if bootloader was installed."},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    This method first validates if deploy key sent in vendorpassthru"},{"line_number":579,"context_line":"    was correct one, and then validates whether bootloader installation"},{"line_number":580,"context_line":"    was successful or not."},{"line_number":581,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_db3b52ea","line":578,"updated":"2015-04-03 17:24:03.000000000","message":"s/vendorpassthru/vendor passthru/","commit_id":"3827b111a92d80b57a984af3f334886e74beed91"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c9ab04dfd8221060c4344df90d211279e66b955a","unresolved":false,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    params \u003d {"},{"line_number":566,"context_line":"              \u0027address\u0027: input_params.get(\u0027address\u0027),"},{"line_number":567,"context_line":"              \u0027key\u0027: input_params.get(\u0027key\u0027),"},{"line_number":568,"context_line":"              \u0027status\u0027: input_params.get(\u0027status\u0027),"},{"line_number":569,"context_line":"             }"},{"line_number":570,"context_line":"    msg \u003d _(\"Some mandatory input missing from \u0027pass_bootloader_info\u0027 \""}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_4d3c10e2","line":567,"updated":"2015-04-06 08:55:02.000000000","message":"It key is missing we raise in l560 above.","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5d87ca08933de1764f113992f5bc0de089d6ddda","unresolved":false,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    params \u003d {"},{"line_number":566,"context_line":"              \u0027address\u0027: input_params.get(\u0027address\u0027),"},{"line_number":567,"context_line":"              \u0027key\u0027: input_params.get(\u0027key\u0027),"},{"line_number":568,"context_line":"              \u0027status\u0027: input_params.get(\u0027status\u0027),"},{"line_number":569,"context_line":"             }"},{"line_number":570,"context_line":"    msg \u003d _(\"Some mandatory input missing from \u0027pass_bootloader_info\u0027 \""}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_f0917753","line":567,"in_reply_to":"baa041b7_4d3c10e2","updated":"2015-04-06 09:01:30.000000000","message":"Done","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c9ab04dfd8221060c4344df90d211279e66b955a","unresolved":false,"context_lines":[{"line_number":567,"context_line":"              \u0027key\u0027: input_params.get(\u0027key\u0027),"},{"line_number":568,"context_line":"              \u0027status\u0027: input_params.get(\u0027status\u0027),"},{"line_number":569,"context_line":"             }"},{"line_number":570,"context_line":"    msg \u003d _(\"Some mandatory input missing from \u0027pass_bootloader_info\u0027 \""},{"line_number":571,"context_line":"            \"vendor passthru\")"},{"line_number":572,"context_line":"    deploy_utils.check_for_missing_params(params, msg)"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_f0d97784","line":570,"updated":"2015-04-06 08:55:02.000000000","message":"from ramdisk to vendor passthru?","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5d87ca08933de1764f113992f5bc0de089d6ddda","unresolved":false,"context_lines":[{"line_number":567,"context_line":"              \u0027key\u0027: input_params.get(\u0027key\u0027),"},{"line_number":568,"context_line":"              \u0027status\u0027: input_params.get(\u0027status\u0027),"},{"line_number":569,"context_line":"             }"},{"line_number":570,"context_line":"    msg \u003d _(\"Some mandatory input missing from \u0027pass_bootloader_info\u0027 \""},{"line_number":571,"context_line":"            \"vendor passthru\")"},{"line_number":572,"context_line":"    deploy_utils.check_for_missing_params(params, msg)"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_d0a0b3a1","line":570,"in_reply_to":"baa041b7_f0d97784","updated":"2015-04-06 09:01:30.000000000","message":"Done","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7985da70018af2964547fc7a47d8f1c4c7686d9e","unresolved":false,"context_lines":[{"line_number":568,"context_line":"              \"with %(expected_key)s\") %"},{"line_number":569,"context_line":"            {\u0027key_sent\u0027: input_params.get(\u0027key\u0027), \u0027expected_key\u0027: deploy_key})"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    deploy_utils.check_for_missing_params(params, msg)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"def validate_bootloader_install_status(task, input_params):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa53dc9_6a838bcd","line":571,"updated":"2015-04-07 09:07:54.000000000","message":"Better if we check all first and then compare deploy key (move this line before l564).","commit_id":"260bd7c773c067a7245aa92b5442fbbbc1a3c7d9"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"8e5b887578984fb648ffcd34cdc0c519b389b8ab","unresolved":false,"context_lines":[{"line_number":568,"context_line":"              \"with %(expected_key)s\") %"},{"line_number":569,"context_line":"            {\u0027key_sent\u0027: input_params.get(\u0027key\u0027), \u0027expected_key\u0027: deploy_key})"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    deploy_utils.check_for_missing_params(params, msg)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"def validate_bootloader_install_status(task, input_params):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aa53dc9_044cf340","line":571,"in_reply_to":"9aa53dc9_6a838bcd","updated":"2015-04-07 09:58:49.000000000","message":"Done.  Oh sorry, missed to move this up.","commit_id":"260bd7c773c067a7245aa92b5442fbbbc1a3c7d9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8dfa324389f5ce9fa76c98e124e425eddf94d2b6","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":568,"context_line":"            _(\"Deploy key %(key_sent)s does not match \""},{"line_number":569,"context_line":"              \"with %(expected_key)s\") %"},{"line_number":570,"context_line":"            {\u0027key_sent\u0027: input_params.get(\u0027key\u0027), \u0027expected_key\u0027: deploy_key})"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"def validate_bootloader_install_status(task, input_params):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aa53dc9_8d25bfac","line":570,"updated":"2015-04-07 13:09:30.000000000","message":"nit: The method get_deploy_info() (L231) has a similar test checking for the deployment key, perhaps we should refactor that out and use on both places. Right now it\u0027s a bit inconsistent because it\u0027s returning different error messages for the same error.","commit_id":"a4b8feb8527752e5c4f6d8900679aab7b67e6248"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"afa524efaf06c154204a744d434710a13482a401","unresolved":false,"context_lines":[{"line_number":527,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":528,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        node \u003d task.node"},{"line_number":531,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_58d3c504","line":530,"updated":"2015-03-31 16:54:08.000000000","message":"Is this being used?","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c442be7ba42decb7c47cf31b2b7bc5f0a01469d4","unresolved":false,"context_lines":[{"line_number":527,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":528,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        node \u003d task.node"},{"line_number":531,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_9d72b47b","line":530,"in_reply_to":"da9b358b_58d3c504","updated":"2015-04-01 17:11:06.000000000","message":"Done","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"afa524efaf06c154204a744d434710a13482a401","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":576,"context_line":"                # \u0027pass_bootloader_install_info\u0027."},{"line_number":577,"context_line":"                deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":578,"context_line":"                task.process_event(\u0027wait\u0027)"},{"line_number":579,"context_line":"                return"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"            pxe_config_path \u003d pxe_utils.get_pxe_config_file_path(node.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_d8bd9569","line":578,"updated":"2015-03-31 16:54:08.000000000","message":"Is there a unittest for this?","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"c442be7ba42decb7c47cf31b2b7bc5f0a01469d4","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":576,"context_line":"                # \u0027pass_bootloader_install_info\u0027."},{"line_number":577,"context_line":"                deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":578,"context_line":"                task.process_event(\u0027wait\u0027)"},{"line_number":579,"context_line":"                return"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"            pxe_config_path \u003d pxe_utils.get_pxe_config_file_path(node.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_bd5c58ee","line":578,"in_reply_to":"da9b358b_d8bd9569","updated":"2015-04-01 17:11:06.000000000","message":"Done","commit_id":"72cc4a44c994a03d9f05b053e2585557df08e2af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_1131eba2","line":531,"updated":"2015-04-01 18:56:07.000000000","message":"s/bootloader/the bootloader/g","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_ef545855","line":531,"in_reply_to":"baa041b7_1131eba2","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":535,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_511773ed","line":532,"updated":"2015-04-01 18:56:07.000000000","message":"s/baremetal/baremetal node/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":535,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_cf519464","line":532,"in_reply_to":"baa041b7_511773ed","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":535,"context_line":"        \"\"\""},{"line_number":536,"context_line":"        task.process_event(\u0027resume\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_b1e7df11","line":533,"updated":"2015-04-01 18:56:07.000000000","message":"s/turns/makes/\n\ns/bootloader/the bootloader/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":535,"context_line":"        \"\"\""},{"line_number":536,"context_line":"        task.process_event(\u0027resume\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_8f4b8cb0","line":533,"in_reply_to":"baa041b7_b1e7df11","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":535,"context_line":"        \"\"\""},{"line_number":536,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":537,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_31baafe2","line":534,"updated":"2015-04-01 18:56:07.000000000","message":"s/fail/failed/","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        bootloader installation. If bootloader installation was"},{"line_number":532,"context_line":"        successful, then it notifies the baremetal to proceed to reboot"},{"line_number":533,"context_line":"        and turns the instance active. If bootloader installation failed,"},{"line_number":534,"context_line":"        then it sets provisioning as fail and powers off the node."},{"line_number":535,"context_line":"        \"\"\""},{"line_number":536,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":537,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_6fc72813","line":534,"in_reply_to":"baa041b7_31baafe2","updated":"2015-04-02 02:36:37.000000000","message":"Done","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"191dbff34a6792be6d60c5a723be3f44144b81d2","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":526,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":527,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":528,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_25149842","line":527,"updated":"2015-04-02 09:04:05.000000000","message":"For avoid code duplication this method can be added via mixin class.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3837550ae5d01780c5f577d2c6398e916c08ccc9","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":526,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":527,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":528,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_50b078f4","line":527,"in_reply_to":"baa041b7_25149842","updated":"2015-04-02 09:34:14.000000000","message":"It\u0027s hard to add mixins now because of the agent ramdisk support.  VendorInterface of the driver has to inherit from AgentBaseVendor and hence it is not possible to straightaway move it to mixin.  If we need a mixin, we have to move all the methods to the same mixin which would be tough.  May be we can leave this as it is as it has only 3 lines. what do you think ?","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ddbbeb3c64e9d35a3b6b6f867171a7105339fa12","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":526,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":527,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":528,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_9c4616be","line":527,"in_reply_to":"baa041b7_36216c4e","updated":"2015-04-02 12:45:35.000000000","message":"I think it\u0027s ok to keep as-is. The code is just calling the methods which is already in a shared module (iscsi_deploy)","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b95666531bb61a44515ba667f757f47b33a08f80","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":526,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":527,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":528,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        This method acts as a vendorpassthru and accepts the result of"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_36216c4e","line":527,"in_reply_to":"baa041b7_50b078f4","updated":"2015-04-02 10:22:05.000000000","message":"Yes it is not easy because we should collect vendor metadata.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"191dbff34a6792be6d60c5a723be3f44144b81d2","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            keys are:"},{"line_number":538,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":539,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"},{"line_number":540,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":543,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_5f12cb63","line":540,"updated":"2015-04-02 09:04:05.000000000","message":"And \u0027address\u0027.","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"3837550ae5d01780c5f577d2c6398e916c08ccc9","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            keys are:"},{"line_number":538,"context_line":"                \u0027key\u0027: The deploy key for authorization"},{"line_number":539,"context_line":"                \u0027status\u0027: \u0027SUCCEEDED\u0027 or \u0027FAILED\u0027"},{"line_number":540,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":543,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa041b7_d0bb680d","line":540,"in_reply_to":"baa041b7_5f12cb63","updated":"2015-04-02 09:34:14.000000000","message":"Done","commit_id":"31da82ca519ea30650e2214afa357db9913668e0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        \"\"\""},{"line_number":573,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":574,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":575,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":578,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_7f41f20a","line":575,"updated":"2015-04-02 20:17:57.000000000","message":"Looks like this method is a copy/paste from ilo/deploy.py. Please see there for comments.\n\nToo bad we can\u0027t just push this down to agent_base_vendor.BaseAgentVendor.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        \"\"\""},{"line_number":573,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":574,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":575,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    @base.passthru([\u0027POST\u0027])"},{"line_number":578,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_aad27efe","line":575,"in_reply_to":"baa041b7_7f41f20a","updated":"2015-04-03 15:48:46.000000000","message":"I guess we can\u0027t push it down to agent_base_vendor.BaseAgentVendor because it doesn\u0027t belong there.  But with a proposed boot interface and if it is implemented, this would all be consolidated.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a"},{"line_number":618,"context_line":"                # whole disk image."},{"line_number":619,"context_line":"                if not is_whole_disk_image:"},{"line_number":620,"context_line":"                    deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":621,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":622,"context_line":"                    return"},{"line_number":623,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_1f70a671","line":620,"updated":"2015-04-02 20:17:57.000000000","message":"what if kwargs[\u0027address\u0027] doesn\u0027t exist?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a"},{"line_number":618,"context_line":"                # whole disk image."},{"line_number":619,"context_line":"                if not is_whole_disk_image:"},{"line_number":620,"context_line":"                    deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":621,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":622,"context_line":"                    return"},{"line_number":623,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_8acd7a5f","line":620,"in_reply_to":"baa041b7_1f70a671","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b1ab5d9e271e875ac5d89e1bec11f36473c8f912","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a"},{"line_number":618,"context_line":"                # whole disk image."},{"line_number":619,"context_line":"                if not is_whole_disk_image:"},{"line_number":620,"context_line":"                    deploy_utils.notify_ramdisk_to_proceed(kwargs[\u0027address\u0027])"},{"line_number":621,"context_line":"                    task.process_event(\u0027wait\u0027)"},{"line_number":622,"context_line":"                    return"},{"line_number":623,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_e5e8b77e","line":620,"in_reply_to":"baa041b7_8acd7a5f","updated":"2015-04-03 16:40:22.000000000","message":"Again this is already validated in continue_deploy() call on L594.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f2b0103ae306928ca1e3af0d0de10ad27c279802","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            msg \u003d _(\u0027Failed to continue iSCSI deployment.\u0027)"},{"line_number":635,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs.get(\u0027address\u0027))"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":640,"context_line":"    def continue_deploy(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_1f1e660c","line":637,"updated":"2015-04-02 20:17:57.000000000","message":"I\u0027m a bit confused here. If it failed above, ie got to line 635, do you want this to be called still?","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            msg \u003d _(\u0027Failed to continue iSCSI deployment.\u0027)"},{"line_number":635,"context_line":"            deploy_utils.set_failed_state(task, msg)"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs.get(\u0027address\u0027))"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":640,"context_line":"    def continue_deploy(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_aa8a7ebd","line":637,"in_reply_to":"baa041b7_1f1e660c","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"a4a9e82c4cbc2f8a4cfa5d8ab08e490a282ae0e7","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    def pass_bootloader_install_info(self, task, **kwargs):"},{"line_number":559,"context_line":"        \"\"\"Accepts the results of bootloader installation."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        This method acts as a vendorpassthru and accepts the result of"},{"line_number":562,"context_line":"        the bootloader installation. If bootloader installation was"},{"line_number":563,"context_line":"        successful, then it notifies the bare metal to proceed to reboot"},{"line_number":564,"context_line":"        and makes the instance active. If the bootloader installation failed,"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_d6a56704","line":561,"updated":"2015-04-03 17:24:03.000000000","message":"s/vendorpassthru/vendor passthru/","commit_id":"3827b111a92d80b57a984af3f334886e74beed91"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"a4a9e82c4cbc2f8a4cfa5d8ab08e490a282ae0e7","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                pxe_utils.clean_up_pxe_config(task)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"                # Ask the ramdisk to install bootloader and"},{"line_number":618,"context_line":"                # wait for the call-back through the vendor-passthru"},{"line_number":619,"context_line":"                # \u0027pass_bootloader_install_info\u0027, if it\u0027s not a"},{"line_number":620,"context_line":"                # whole disk image."},{"line_number":621,"context_line":"                if not is_whole_disk_image:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_f6850b59","line":618,"updated":"2015-04-03 17:24:03.000000000","message":"s/vendor-passthru/vendor passthru/","commit_id":"3827b111a92d80b57a984af3f334886e74beed91"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c9ab04dfd8221060c4344df90d211279e66b955a","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":572,"context_line":"                \u0027address\u0027: The IP address of the ramdisk"},{"line_number":573,"context_line":"        \"\"\""},{"line_number":574,"context_line":"        iscsi_deploy.validate_pass_bootloader_info_input(task, kwargs)"},{"line_number":575,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":576,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":577,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_f064d7e5","line":574,"updated":"2015-04-06 08:55:02.000000000","message":"We should do validate in \"validate\" method (l539), \"elif method \u003d\u003d \u0027pass_bootloader_install_info\u0027:...\".  This prevents to spawn a worker thread.","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"5d87ca08933de1764f113992f5bc0de089d6ddda","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                \u0027error\u0027: The error message if status \u003d\u003d \u0027FAILED\u0027"},{"line_number":572,"context_line":"                \u0027address\u0027: The IP address of the ramdisk"},{"line_number":573,"context_line":"        \"\"\""},{"line_number":574,"context_line":"        iscsi_deploy.validate_pass_bootloader_info_input(task, kwargs)"},{"line_number":575,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":576,"context_line":"        iscsi_deploy.validate_bootloader_install_status(task, kwargs)"},{"line_number":577,"context_line":"        iscsi_deploy.finish_deploy(task, kwargs[\u0027address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"baa041b7_10973b49","line":574,"in_reply_to":"baa041b7_f064d7e5","updated":"2015-04-06 09:01:30.000000000","message":"Done","commit_id":"13c73d8aadb63ce973c201d9a6bbcbe628a40c48"}],"ironic/tests/drivers/ilo/test_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ff9045f2709a84f5f966d791dfdfc9830f49d9d","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            vendor.validate(task, method\u003d\u0027heartbeat\u0027, foo\u003d\u0027bar\u0027)"},{"line_number":753,"context_line":"            self.assertFalse(get_deploy_info_mock.called)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027finish_deploy\u0027)"},{"line_number":756,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_bootloader_install_status\u0027)"},{"line_number":757,"context_line":"    def test_pass_bootloader_install_info(self, validate_status_mock,"},{"line_number":758,"context_line":"                                          finish_deploy_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_3612a5b5","line":755,"updated":"2015-04-01 18:56:07.000000000","message":"Optional: If you want you could try adding \u0027autospec\u003dTrue\u0027 to your mocks.  To help catch possible errors when calling the assert methods.","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f148df4a5c8268bb2b1c73365f0b9544d2d7d11d","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            vendor.validate(task, method\u003d\u0027heartbeat\u0027, foo\u003d\u0027bar\u0027)"},{"line_number":753,"context_line":"            self.assertFalse(get_deploy_info_mock.called)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027finish_deploy\u0027)"},{"line_number":756,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_bootloader_install_status\u0027)"},{"line_number":757,"context_line":"    def test_pass_bootloader_install_info(self, validate_status_mock,"},{"line_number":758,"context_line":"                                          finish_deploy_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_2fd120ce","line":755,"in_reply_to":"baa041b7_3612a5b5","updated":"2015-04-02 02:36:37.000000000","message":"Done.  Thanks will add it.  I liked your other patch very much.","commit_id":"98a9bf32b23ad8eb60d4278b54d86f9f4deda5c4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2169384fae609e3c875dcb5b1127ff41b5a33573","unresolved":false,"context_lines":[{"line_number":892,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":893,"context_line":"            self.assertFalse(finish_deploy_mock.called)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    @mock.patch.object(deploy_utils, \u0027notify_ramdisk_to_proceed\u0027)"},{"line_number":896,"context_line":"    @mock.patch.object(manager_utils, \u0027node_set_boot_device\u0027)"},{"line_number":897,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_update_secure_boot_mode\u0027)"},{"line_number":898,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_78cfd0b0","line":895,"updated":"2015-04-02 17:52:15.000000000","message":"Optional: add autospec\u003dTrue to these and all the other mocks that easily accept them.  Sometimes adding it will break a valid test, in those cases I don\u0027t use it.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":892,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":893,"context_line":"            self.assertFalse(finish_deploy_mock.called)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    @mock.patch.object(deploy_utils, \u0027notify_ramdisk_to_proceed\u0027)"},{"line_number":896,"context_line":"    @mock.patch.object(manager_utils, \u0027node_set_boot_device\u0027)"},{"line_number":897,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_update_secure_boot_mode\u0027)"},{"line_number":898,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_6a9476e1","line":895,"in_reply_to":"baa041b7_78cfd0b0","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"aa8037cb6d189dfdebf9756611ee82a5e272f1d2","unresolved":false,"context_lines":[{"line_number":921,"context_line":"                                                         persistent\u003dTrue)"},{"line_number":922,"context_line":"            func_update_boot_mode.assert_called_once_with(task)"},{"line_number":923,"context_line":"            func_update_secure_boot_mode.assert_called_once_with(task, True)"},{"line_number":924,"context_line":"            notify_ramdisk_to_proceed_mock.assert_called_once_with(\u0027123456\u0027)"},{"line_number":925,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":926,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":927,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_58976c90","line":924,"updated":"2015-04-02 17:50:06.000000000","message":"I think it would be better to mock iscsi_deploy.finish_deploy and than have this assert that notify_ramdisk is NOT called.\n\nAs it is right now it is confusing as a person has to know that iscsi_deploy.finish_deploy will call ramdisk_to_proceed.","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"860b68f1ace90eea3d09426d3d8c242a6bb79ee0","unresolved":false,"context_lines":[{"line_number":921,"context_line":"                                                         persistent\u003dTrue)"},{"line_number":922,"context_line":"            func_update_boot_mode.assert_called_once_with(task)"},{"line_number":923,"context_line":"            func_update_secure_boot_mode.assert_called_once_with(task, True)"},{"line_number":924,"context_line":"            notify_ramdisk_to_proceed_mock.assert_called_once_with(\u0027123456\u0027)"},{"line_number":925,"context_line":"            self.assertEqual(states.ACTIVE, task.node.provision_state)"},{"line_number":926,"context_line":"            self.assertEqual(states.NOSTATE, task.node.target_provision_state)"},{"line_number":927,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_eab64689","line":924,"in_reply_to":"baa041b7_58976c90","updated":"2015-04-03 15:48:46.000000000","message":"Done","commit_id":"673bcdc68bfe1760cb5f721d76ef3d96c58edc00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0aec5e5306ee05621bc0dee8e89bede886a47f4a","unresolved":false,"context_lines":[{"line_number":896,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":897,"context_line":"            self.assertFalse(finish_deploy_mock.called)"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027finish_deploy\u0027, auto_spec\u003dTrue)"},{"line_number":900,"context_line":"    @mock.patch.object(manager_utils, \u0027node_set_boot_device\u0027, auto_spec\u003dTrue)"},{"line_number":901,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_update_secure_boot_mode\u0027, auto_spec\u003dTrue)"},{"line_number":902,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode\u0027, auto_spec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa041b7_5b63c2dc","line":899,"updated":"2015-04-03 16:46:43.000000000","message":"I thought it was \u0027autospec\u0027 without an underscore.","commit_id":"eef7fb29be280d3cfe526f922d1da7122f1fe743"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"867e5ed21f2aec25ec85d230cc5efc9451c70bb5","unresolved":false,"context_lines":[{"line_number":896,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":897,"context_line":"            self.assertFalse(finish_deploy_mock.called)"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027finish_deploy\u0027, auto_spec\u003dTrue)"},{"line_number":900,"context_line":"    @mock.patch.object(manager_utils, \u0027node_set_boot_device\u0027, auto_spec\u003dTrue)"},{"line_number":901,"context_line":"    @mock.patch.object(ilo_deploy, \u0027_update_secure_boot_mode\u0027, auto_spec\u003dTrue)"},{"line_number":902,"context_line":"    @mock.patch.object(ilo_common, \u0027update_boot_mode\u0027, auto_spec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"baa041b7_bb440e1b","line":899,"in_reply_to":"baa041b7_5b63c2dc","updated":"2015-04-03 16:48:37.000000000","message":"+1 yeah it\u0027s autospec[1]\n\n[1] https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch","commit_id":"eef7fb29be280d3cfe526f922d1da7122f1fe743"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"839c9430cd95c206983687431787fa44d79ca361","unresolved":false,"context_lines":[{"line_number":744,"context_line":"            get_deploy_info_mock.assert_called_once_with(task.node,"},{"line_number":745,"context_line":"                                                         foo\u003d\u0027bar\u0027)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_pass_bootloader_info_input\u0027)"},{"line_number":748,"context_line":"    def test_validate_pass_bootloader_install_info(self,"},{"line_number":749,"context_line":"                                                          validate_mock):"},{"line_number":750,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa53dc9_a8ebffaf","line":747,"updated":"2015-04-06 13:45:04.000000000","message":"nit: autospec\u003dTrue","commit_id":"ede1e6ff4ef9a60225aa3c515c834ad95ef6662f"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"33548750b31ba4b0511ef8144f8a71c1a68113f0","unresolved":false,"context_lines":[{"line_number":744,"context_line":"            get_deploy_info_mock.assert_called_once_with(task.node,"},{"line_number":745,"context_line":"                                                         foo\u003d\u0027bar\u0027)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_pass_bootloader_info_input\u0027)"},{"line_number":748,"context_line":"    def test_validate_pass_bootloader_install_info(self,"},{"line_number":749,"context_line":"                                                          validate_mock):"},{"line_number":750,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa53dc9_a8ec1f90","line":747,"in_reply_to":"9aa53dc9_a8ebffaf","updated":"2015-04-06 13:53:50.000000000","message":"Done","commit_id":"ede1e6ff4ef9a60225aa3c515c834ad95ef6662f"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"839c9430cd95c206983687431787fa44d79ca361","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                              address\u003d\u0027123456\u0027, iqn\u003d\u0027aaa-bbb\u0027,"},{"line_number":682,"context_line":"                              key\u003d\u0027fake-12345\u0027)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_pass_bootloader_info_input\u0027)"},{"line_number":685,"context_line":"    def test_vendor_passthru_pass_bootloader_install_info(self,"},{"line_number":686,"context_line":"                                                          validate_mock):"},{"line_number":687,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa53dc9_08dd4b14","line":684,"updated":"2015-04-06 13:45:04.000000000","message":"nit: autospec\u003dTrue","commit_id":"ede1e6ff4ef9a60225aa3c515c834ad95ef6662f"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"33548750b31ba4b0511ef8144f8a71c1a68113f0","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                              address\u003d\u0027123456\u0027, iqn\u003d\u0027aaa-bbb\u0027,"},{"line_number":682,"context_line":"                              key\u003d\u0027fake-12345\u0027)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    @mock.patch.object(iscsi_deploy, \u0027validate_pass_bootloader_info_input\u0027)"},{"line_number":685,"context_line":"    def test_vendor_passthru_pass_bootloader_install_info(self,"},{"line_number":686,"context_line":"                                                          validate_mock):"},{"line_number":687,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aa53dc9_88027b3d","line":684,"in_reply_to":"9aa53dc9_08dd4b14","updated":"2015-04-06 13:53:50.000000000","message":"Done","commit_id":"ede1e6ff4ef9a60225aa3c515c834ad95ef6662f"}]}
