)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76413ae950a041d38afd9c8e945129442f2fb1b1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After IPA has completed a cleaning step such as upgrading firmware, it"},{"line_number":10,"context_line":"may require a reboot. Ironic should be the one controlling the power"},{"line_number":11,"context_line":"state and out of band reboots are preferable to in band reboots."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4e68d968674d72850a59bca7dab8c9744307ec6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7aaa499b_438638ba","line":11,"updated":"2015-04-14 17:46:24.000000000","message":"why are out of band reboots preferable?","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"fdedfe96a1272a6b61cff286965f2400df479c84","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":152,"context_line":"                \u0027cleaning_reboot\u0027) is True):"},{"line_number":153,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":154,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":155,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"},{"line_number":156,"context_line":"            task.node.save()"},{"line_number":157,"context_line":"            self._notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_a041cf3b","line":154,"updated":"2015-04-01 17:35:33.000000000","message":"Just noting there\u0027s a bad assumption here: just because the agent has not run a command does not mean a reboot actually occurred. (Think: an agent crashed and restarted after doing something).\n\nI suspect this is a problem everywhere and not just here, just explicitly calling it out.","commit_id":"d6b11406ca42e5eae6018d99ac06d4e88d0f872e"},{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"8f5f864d577767116f2b18254526ebe3f94e5ac4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":152,"context_line":"                \u0027cleaning_reboot\u0027) is True):"},{"line_number":153,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":154,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":155,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"},{"line_number":156,"context_line":"            task.node.save()"},{"line_number":157,"context_line":"            self._notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_40e203a1","line":154,"in_reply_to":"baa041b7_a041cf3b","updated":"2015-04-01 17:49:29.000000000","message":"I don\u0027t think it\u0027s a bad assumption. This flag gets set right before a reboot, and cleared after it. We bail and go to cleanfail if the reboot fails. \n\nThough this does bring up the point that the flag would be set even if the reboot fails (though it would be in cleanfail at that point). I\u0027m going to save the flag post reboot command.","commit_id":"d6b11406ca42e5eae6018d99ac06d4e88d0f872e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ae7ed93e9c3da53662a51db053634349cc2b1cbd","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":152,"context_line":"                \u0027cleaning_reboot\u0027) is True):"},{"line_number":153,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":154,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":155,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_5cb6598b","line":152,"updated":"2015-04-02 07:40:35.000000000","message":"s/ is True//","commit_id":"6d3ba5119ff0c9f7faf5ffb10689ff35a43e176a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ae7ed93e9c3da53662a51db053634349cc2b1cbd","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                \u0027cleaning_reboot\u0027) is True):"},{"line_number":153,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":154,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":155,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"},{"line_number":156,"context_line":"            task.node.save()"},{"line_number":157,"context_line":"            self._notify_conductor_resume_clean(task)"},{"line_number":158,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_1c0d713e","line":155,"updated":"2015-04-02 07:40:35.000000000","message":"you have to copy driver_internal_info before modification like on line #220","commit_id":"6d3ba5119ff0c9f7faf5ffb10689ff35a43e176a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ae7ed93e9c3da53662a51db053634349cc2b1cbd","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            self._notify_conductor_resume_clean(task)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        elif command.get(\u0027command_status\u0027) \u003d\u003d \u0027SUCCEEDED\u0027:"},{"line_number":193,"context_line":"            if task.node.clean_step.get(\u0027reboot_requested\u0027) is True:"},{"line_number":194,"context_line":"                self._cleaning_reboot(task)"},{"line_number":195,"context_line":"                return"},{"line_number":196,"context_line":"            self._notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_fcad2d32","line":193,"updated":"2015-04-02 07:40:35.000000000","message":"ditto","commit_id":"6d3ba5119ff0c9f7faf5ffb10689ff35a43e176a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ae7ed93e9c3da53662a51db053634349cc2b1cbd","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if the node cannot be rebooted."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        :param task: a TaskManager instance"},{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        try:"},{"line_number":216,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":217,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_fc22cdb8","line":214,"updated":"2015-04-02 07:40:35.000000000","message":"I suggest adding some logs here, indicating that reboot is happening due to cleaning","commit_id":"6d3ba5119ff0c9f7faf5ffb10689ff35a43e176a"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"aadc1fe79ddd9b930cacd1bb8aafa7da60c65c36","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        try:"},{"line_number":216,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":217,"context_line":"        except Exception as e:"},{"line_number":218,"context_line":"            manager.cleaning_error_handler(task, e)"},{"line_number":219,"context_line":"        # Signify that we\u0027ve rebooted"},{"line_number":220,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":221,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_3b022570","line":218,"updated":"2015-04-06 07:09:15.000000000","message":"Need a return after this.","commit_id":"6d3ba5119ff0c9f7faf5ffb10689ff35a43e176a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"56ce09c3344a7d1feca6c4345996f7b1f168bcb6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            self._notify_conductor_resume_clean(task)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        elif command.get(\u0027command_status\u0027) \u003d\u003d \u0027SUCCEEDED\u0027:"},{"line_number":195,"context_line":"            if task.node.clean_step.get(\u0027reboot_requested\u0027) is True:"},{"line_number":196,"context_line":"                self._cleaning_reboot(task)"},{"line_number":197,"context_line":"                return"},{"line_number":198,"context_line":"            self._notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_da483230","line":195,"updated":"2015-04-06 23:41:30.000000000","message":"You missed removing the is True that Dmitry commented on before","commit_id":"ff763ad27d57284e2d6140c85552f418a5d52c5d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a844334f3134f8b65b6902175ca661ff939cab0b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":152,"context_line":"                \u0027cleaning_reboot\u0027)):"},{"line_number":153,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":154,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."}],"source_content_type":"text/x-python","patch_set":5,"id":"dac4157f_d687f5d5","line":151,"updated":"2015-04-20 04:36:51.000000000","message":"I assume through agent_commands you check if the last commad i.e. reboot had any errors. If there was a error, dont you want to clear the \u0027cleanig_reboot\u0027 flag?\nIf not, when would it get clear?","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6d9eca9f1b613a264e60a39c5d6943cb0afc75b3","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":152,"context_line":"                \u0027cleaning_reboot\u0027)):"},{"line_number":153,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":154,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."}],"source_content_type":"text/x-python","patch_set":5,"id":"dac4157f_d19dbf5a","line":151,"in_reply_to":"dac4157f_d687f5d5","updated":"2015-04-20 05:25:22.000000000","message":"Just to add clarity:-\nIf the node were not to go for reboot and we are working with the same booted instance of node, then agent_commands would have commands and cleaning_reboot would also be available in driver_internal_info.\nIn such cases, we should throw error and move to cleaning failed state.","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76413ae950a041d38afd9c8e945129442f2fb1b1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            del driver_internal_info[\u0027cleaning_reboot\u0027]"},{"line_number":157,"context_line":"            task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":158,"context_line":"            task.node.save()"},{"line_number":159,"context_line":"            self._notify_conductor_resume_clean(task)"},{"line_number":160,"context_line":"            return"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_e02c1a04","line":159,"updated":"2015-04-14 17:46:24.000000000","message":"don\u0027t know if you want to do a LOG.debug() here","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76413ae950a041d38afd9c8e945129442f2fb1b1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":158,"context_line":"            task.node.save()"},{"line_number":159,"context_line":"            self._notify_conductor_resume_clean(task)"},{"line_number":160,"context_line":"            return"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"},{"line_number":163,"context_line":"        LOG.debug(\u0027Cleaning command status for node %(node)s on step %(step)s:\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_c008fe93","line":160,"updated":"2015-04-14 17:46:24.000000000","message":"I have a suggestion, which would make it easier for me to understand what is going on.\n\nIf not agent_commands:\n    # I\u0027m not quite sure what this means but I think it means that\n    # the agent is still doing something/command\n    if task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027):\n        do your stuff\n    return\n\nIt would mean though, that you won\u0027t get the LOG.debug() below. Although it seems to me that you might want to distinguish the two cases of 1. no agent command vs 2. agent command that isn\u0027t a completed cleaning command. But maybe not.","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76413ae950a041d38afd9c8e945129442f2fb1b1","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        If an agent clean step has \u0027reboot_requested\u0027: True, reboots the"},{"line_number":212,"context_line":"        node when the step is completed. Will put the node in CLEANFAIL"},{"line_number":213,"context_line":"        if the node cannot be rebooted."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        :param task: a TaskManager instance"},{"line_number":216,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_435bd854","line":213,"updated":"2015-04-14 17:46:24.000000000","message":"This description doesn\u0027t quite match what this method is doing.\n\nHow about above, after line 195, put \u0027the node has completed the clean step, but it needs to be rebooted before going on to the next clean step\u0027.\n\nAnd here, something like \u0027Reboot the node out-of-band. If it cannot be rebooted, the node will be put in CLEANFAIL state. Cleaning will resume after the agent reboots and sends a heartbeat to the conductor.\u0027","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e4a9bfbdcf03c9c8a39abe2db934445cd4ba6f6","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        try:"},{"line_number":220,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":221,"context_line":"        except Exception as e:"},{"line_number":222,"context_line":"            manager.cleaning_error_handler(task, e)"},{"line_number":223,"context_line":"            return"},{"line_number":224,"context_line":"        # Signify that we\u0027ve rebooted"},{"line_number":225,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_7d824054","line":222,"updated":"2015-04-07 00:20:13.000000000","message":"above I see code that does:\n\nreturn manager.cleaning_error_handler(task, e)\n\nDoes it make any difference?  Or is it just saving a line?","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"76413ae950a041d38afd9c8e945129442f2fb1b1","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    def _get_completed_cleaning_command(self, task, commands):"},{"line_number":347,"context_line":"        \"\"\"Returns None or a completed cleaning command from the agent.\"\"\""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if not commands:"},{"line_number":350,"context_line":"            return"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        last_command \u003d commands[-1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_80455618","line":349,"updated":"2015-04-14 17:46:24.000000000","message":"It would be nice to document what \u0027commands\u0027 is.","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"}],"ironic/tests/drivers/test_agent_base_vendor.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"aadc1fe79ddd9b930cacd1bb8aafa7da60c65c36","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":478,"context_line":"            notify_mock.assert_called_once_with(task)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":481,"context_line":"    @mock.patch.object(agent_base_vendor.BaseAgentVendor,"},{"line_number":482,"context_line":"                       \u0027_notify_conductor_resume_clean\u0027)"},{"line_number":483,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_fb227d00","line":480,"updated":"2015-04-06 07:09:15.000000000","message":"Better to add a test case where rebooting node fails and assert if we set all the states properly.","commit_id":"6d3ba5119ff0c9f7faf5ffb10689ff35a43e176a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e4a9bfbdcf03c9c8a39abe2db934445cd4ba6f6","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            self.assertEqual(states.DEPLOYFAIL, task.node.provision_state)"},{"line_number":454,"context_line":"            self.assertEqual(states.ACTIVE, task.node.target_provision_state)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.cleaning_error_handler\u0027)"},{"line_number":457,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":458,"context_line":"    def test__cleaning_reboot_fails(self, power_mock, error_mock):"},{"line_number":459,"context_line":"        # Test that a failure to reboot the node leaves the node halts cleaning"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_5d2bfc82","line":456,"updated":"2015-04-07 00:20:13.000000000","message":"Maybe add: autospec\u003dTrue to mocks","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e4a9bfbdcf03c9c8a39abe2db934445cd4ba6f6","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    @mock.patch(\u0027ironic.conductor.manager.cleaning_error_handler\u0027)"},{"line_number":457,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":458,"context_line":"    def test__cleaning_reboot_fails(self, power_mock, error_mock):"},{"line_number":459,"context_line":"        # Test that a failure to reboot the node leaves the node halts cleaning"},{"line_number":460,"context_line":"        power_mock.side_effect \u003d Exception"},{"line_number":461,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":462,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_bd4b2859","line":459,"updated":"2015-04-07 00:20:13.000000000","message":"I\u0027m not quite sure what the end of the sentence is trying to say.\n\n\"leaves the node halts cleaning\"","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"7f470695d98cef1a0f63b4ab2e5c7f26df027685","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            self.passthru._cleaning_reboot(task)"},{"line_number":464,"context_line":"            power_mock.assert_called_once_with(task, states.REBOOT)"},{"line_number":465,"context_line":"            error_mock.assert_called_once_with(task, mock.ANY)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @mock.patch.object(agent_base_vendor.BaseAgentVendor,"},{"line_number":468,"context_line":"                       \u0027_notify_conductor_resume_clean\u0027)"},{"line_number":469,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_3f8b3ec5","line":466,"updated":"2015-04-08 14:57:19.000000000","message":"May be also assert that we haven\u0027t set driver_internal_info[\u0027cleaning_reboot\u0027]","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e4a9bfbdcf03c9c8a39abe2db934445cd4ba6f6","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            self.passthru._cleaning_reboot(task)"},{"line_number":464,"context_line":"            power_mock.assert_called_once_with(task, states.REBOOT)"},{"line_number":465,"context_line":"            error_mock.assert_called_once_with(task, mock.ANY)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @mock.patch.object(agent_base_vendor.BaseAgentVendor,"},{"line_number":468,"context_line":"                       \u0027_notify_conductor_resume_clean\u0027)"},{"line_number":469,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027get_commands_status\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_dd482c30","line":466,"updated":"2015-04-07 00:20:13.000000000","message":"what about success case?  Or is that implicitly tested by the functions below?","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e4a9bfbdcf03c9c8a39abe2db934445cd4ba6f6","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            \u0027priority\u0027: 10,"},{"line_number":501,"context_line":"            \u0027interface\u0027: \u0027deploy\u0027,"},{"line_number":502,"context_line":"            \u0027step\u0027: \u0027erase_devices\u0027,"},{"line_number":503,"context_line":"            \u0027reboot_requested\u0027: True"},{"line_number":504,"context_line":"        }"},{"line_number":505,"context_line":"        self.node.save()"},{"line_number":506,"context_line":"        status_mock.return_value \u003d [{"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_9d1aa46d","line":503,"updated":"2015-04-07 00:20:13.000000000","message":"nit: add trailing comma","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e4a9bfbdcf03c9c8a39abe2db934445cd4ba6f6","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            \u0027command_name\u0027: \u0027execute_clean_step\u0027,"},{"line_number":509,"context_line":"            \u0027command_result\u0027: {"},{"line_number":510,"context_line":"                \u0027clean_step\u0027: self.node.clean_step"},{"line_number":511,"context_line":"            }"},{"line_number":512,"context_line":"        }]"},{"line_number":513,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":514,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa53dc9_dd370ce2","line":511,"updated":"2015-04-07 00:20:13.000000000","message":"nit: add trailing comma","commit_id":"d0e87e314a2777c495d31447d1340044adbd99c5"}]}
