)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"f8df35822a78449fe1b55dce098bf8268c6ac4f9","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    LOG.info(_LI(\u0027Deployment to node %s done\u0027), node.uuid)"},{"line_number":621,"context_line":"    task.process_event(\u0027done\u0027)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    if get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":624,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_71421b12","line":623,"updated":"2015-04-04 06:19:37.000000000","message":"Can we move this to before task.process_event(\u0027done\u0027)  (probably just after deploy_utils.notify_ramdisk_to_proceed) ?  \n\nJust wondering if some power driver while trying to do the reboot - first power off the node, but fails to power on the node after that.  In that case, we might just log the exception and miss it, but the node might never come up.  If manager_utils.node_power_action raises, then we can actually set the node to deploy failed state.\n\nJust to make sure we turn the node as active in the last operation (if everything went through fine) and never miss any errors.","commit_id":"23a93a519913e091a1aa2970bfb9d84ca830d2f2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3aff3ad945fa1100e015d6fb9bc2e9c94c7d096e","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    LOG.info(_LI(\u0027Deployment to node %s done\u0027), node.uuid)"},{"line_number":621,"context_line":"    task.process_event(\u0027done\u0027)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    if get_boot_option(node) \u003d\u003d \"local\":"},{"line_number":624,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_8a4fef91","line":623,"in_reply_to":"baa041b7_71421b12","updated":"2015-04-07 09:16:23.000000000","message":"+1","commit_id":"23a93a519913e091a1aa2970bfb9d84ca830d2f2"}],"ironic/tests/drivers/test_iscsi_deploy.py":[{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"e24455625c0b48ccbf143a92d24d10226be22fa0","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                              iscsi_deploy.finish_deploy, task, \u00271.2.3.4\u0027)"},{"line_number":857,"context_line":"            set_fail_state_mock.assert_called_once_with(task, mock.ANY)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027)"},{"line_number":860,"context_line":"    @mock.patch.object(deploy_utils, \u0027notify_ramdisk_to_proceed\u0027,"},{"line_number":861,"context_line":"                       autospec\u003dTrue)"},{"line_number":862,"context_line":"    def test_finish_deploy_ssh_with_local_boot(self, notify_mock,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_a473074d","line":859,"updated":"2015-04-07 10:02:06.000000000","message":"nit: autospec","commit_id":"8ccfa3047050385570e219e19b50bc9fc1826929"}]}