)]}'
{"ironic/common/dhcp_factory.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e0e1539d122d08b716853d90c9252df1963c4c4b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d\u0027DHCP provider to use. \"neutron\" uses Neutron, and \u0027"},{"line_number":26,"context_line":"               \u0027\"none\" uses a no-op provider.\u0027"},{"line_number":27,"context_line":"               ),"},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027manage_tftp\u0027,"},{"line_number":29,"context_line":"                default\u003dTrue,"},{"line_number":30,"context_line":"                help\u003d\u0027Whether Ironic will manage TFTP files for the deploy \u0027"},{"line_number":31,"context_line":"                     \u0027ramdisks. If set to False, you will need to configure \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_3b0fb289","line":28,"updated":"2015-04-09 08:42:34.000000000","message":"This option used only in agent driver. Why it is added into dhcp_factory?","commit_id":"5808232a3e94108af94a74021bc5a3d2e90138b5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c56530adb76c56855ffae2daa88edbc862414b9a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"               help\u003d\u0027DHCP provider to use. \"neutron\" uses Neutron, and \u0027"},{"line_number":26,"context_line":"               \u0027\"none\" uses a no-op provider.\u0027"},{"line_number":27,"context_line":"               ),"},{"line_number":28,"context_line":"    cfg.BoolOpt(\u0027manage_tftp\u0027,"},{"line_number":29,"context_line":"                default\u003dTrue,"},{"line_number":30,"context_line":"                help\u003d\u0027Whether Ironic will manage TFTP files for the deploy \u0027"},{"line_number":31,"context_line":"                     \u0027ramdisks. If set to False, you will need to configure \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_b1a88378","line":28,"in_reply_to":"9aa53dc9_3b0fb289","updated":"2015-04-09 09:23:34.000000000","message":"+1\n\nAlso DHCP !\u003d TFTP, looks out of place.","commit_id":"5808232a3e94108af94a74021bc5a3d2e90138b5"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3fb49fc44de0278a26161f075da7fcf0fabf3deb","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_605f3e0f","line":199,"updated":"2015-04-06 21:36:45.000000000","message":"I would think this would be more of a distinct setting instead to turn off tftp file management by Ironic since one could still run their tftp server locally when the driver is set to none.","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"765e01cc6ad01e6807d2396ab071dfcd0f4fbfa7","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_2f035544","line":199,"in_reply_to":"9aa53dc9_000f52e2","updated":"2015-04-07 08:44:05.000000000","message":"But this makes impossible to have testing environment with one conductor, manual dhcp settings and tftp file management by Ironic. Maybe separate config option for agent driver is needed.","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"52eb96d20d32f99f69d520b04076cfadc17e1f0e","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_6f170652","line":199,"in_reply_to":"9aa53dc9_07abc875","updated":"2015-04-07 16:14:04.000000000","message":"/me votes adding CONF.manage_tftp with a default of True.","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cea418c05c87c379aa9e888af5379504a8c8736c","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_552b9594","line":199,"in_reply_to":"9aa53dc9_52160bf2","updated":"2015-04-08 09:08:05.000000000","message":"yeah it seems that having a different config option is the best way to deal with this problem. So +1 for the idea","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0dfa37dd562dfd049b752d99b07c7b57beb0d952","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_52160bf2","line":199,"in_reply_to":"9aa53dc9_5da63354","updated":"2015-04-08 08:26:10.000000000","message":"Agree with Jim.","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"765e01cc6ad01e6807d2396ab071dfcd0f4fbfa7","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_cf4629bf","line":199,"in_reply_to":"9aa53dc9_605f3e0f","updated":"2015-04-07 08:44:05.000000000","message":"+1","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b80f53388f81a7847f8e986aef0f845132e75df9","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_000f52e2","line":199,"in_reply_to":"9aa53dc9_605f3e0f","updated":"2015-04-06 21:41:20.000000000","message":"I don\u0027t think having ironic run tftp while not running dhcp can make sense either because you can\u0027t know which conductor a node is assigned to in the hash ring so you can\u0027t know which conductor is running the tftp server for that node ahead of time to configure your None external DHCP provider. \n\nWhile it may work with only one conductor, at that point you are a SPOF and basically can\u0027t scale like a normal Ironic deployment","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"585e56e837fc7d958af97e8fc5a2142eb0ae5820","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_5da63354","line":199,"in_reply_to":"9aa53dc9_6f170652","updated":"2015-04-07 18:36:27.000000000","message":"+1","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"fe0a32ae06dfc417dbd6972122f4aa42751fb438","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_07abc875","line":199,"in_reply_to":"9aa53dc9_8acc8f36","updated":"2015-04-07 14:56:28.000000000","message":"+1 for separate config option, so that it can still work with the testing environment mentioned by Yuriy.","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"814d9835bb2747484cdf9a1f4200e74660f1529c","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _prepare_pxe_boot(task):"},{"line_number":198,"context_line":"    \"\"\"Prepare the files required for PXE booting the agent.\"\"\""},{"line_number":199,"context_line":"    if CONF.dhcp.dhcp_provider !\u003d \u0027none\u0027:"},{"line_number":200,"context_line":"        pxe_info \u003d _get_tftp_image_info(task.node)"},{"line_number":201,"context_line":"        pxe_options \u003d _build_pxe_config_options(task.node, pxe_info)"},{"line_number":202,"context_line":"        pxe_utils.create_pxe_config(task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_8acc8f36","line":199,"in_reply_to":"9aa53dc9_cf4629bf","updated":"2015-04-07 09:13:41.000000000","message":"I would also vote for not removing it since it can be fixed easily with config option (but I don\u0027t know if it is good this late in cycle)","commit_id":"a6e0f51ae93ea527b1091417a2d95404f16aed51"}]}
