)]}'
{"ironic/tests/dhcp/test_neutron.py":[{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"9e66a7899df16b48f8f1073c534e1156818cf078","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                \u0027network_id\u0027: \u002700000000-0000-0000-0000-000000000000\u0027,"},{"line_number":380,"context_line":"                \u0027admin_state_up\u0027: True, \u0027mac_address\u0027: self.ports[0].address}})"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":383,"context_line":"    @mock.patch.object(client.Client, \u0027create_port\u0027)"},{"line_number":384,"context_line":"    def test_create_cleaning_ports_fail(self, create_mock, mock_clean):"},{"line_number":385,"context_line":"        # Check that if creating a port fails, the ports are cleaned up"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_e61006ab","line":382,"updated":"2015-04-06 23:18:23.000000000","message":"I think the actual problem is rollback_cleaning_ports isn\u0027t being mocked: https://github.com/openstack/ironic/blob/master/ironic/dhcp/neutron.py#L312. That\u0027s my fault, sorry :(","commit_id":"74afbf842eb4c241c48ce5fb3f747b03df4c6ea8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4c75d395e6910e9b425d29db12b9321e86620303","unresolved":false,"context_lines":[{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":383,"context_line":"    @mock.patch.object(client.Client, \u0027create_port\u0027)"},{"line_number":384,"context_line":"    def test_create_cleaning_ports_fail(self, create_mock, mock_clean):"},{"line_number":385,"context_line":"        # Check that if creating a port fails, the ports are cleaned up"},{"line_number":386,"context_line":"        create_mock.side_effect \u003d neutron_client_exc.ConnectionFailed"},{"line_number":387,"context_line":"        api \u003d dhcp_factory.DHCPFactory().provider"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_1ab9fae9","line":384,"updated":"2015-04-06 23:44:59.000000000","message":"The name mock_clean for a mock of time.sleep seems confusing to me.","commit_id":"74afbf842eb4c241c48ce5fb3f747b03df4c6ea8"}]}