)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":14966,"name":"Denis Cavalcante","email":"dencaval@gmail.com","username":"denis.cavalcante"},"change_message_id":"c75ba222116d81b6dad59ccae3b16d50a2052246","unresolved":false,"context_lines":[{"line_number":451,"context_line":"    # lay down a bootloader."},{"line_number":452,"context_line":"    boot_option \u003d get_boot_option(node)"},{"line_number":453,"context_line":"    if node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":454,"context_line":"        boot_option \u003d \u0027netboot\u0027"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    deploy_options \u003d {"},{"line_number":457,"context_line":"        \u0027deployment_id\u0027: node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_eed75cbd","line":454,"updated":"2015-04-08 20:22:20.000000000","message":"It seems to resolve, but It is strange when we read this: \"Use whole disk image to achieve local boot\" at http://specs.openstack.org/openstack/ironic-specs/specs/kilo/local-boot-support-with-partition-images.html","commit_id":"a3580bad7182b3b41e123e45eee4dfb960264fcd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"00c525e1bbf19e2f2b615f1522aa6bdad75541c0","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    node.save()"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # XXX(jroll) DIB relies on boot_option\u003dlocal to decide whether or not to"},{"line_number":451,"context_line":"    # lay down a bootloader. Hack this for now; fix it for real in Liberty."},{"line_number":452,"context_line":"    boot_option \u003d get_boot_option(node)"},{"line_number":453,"context_line":"    if node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":454,"context_line":"        boot_option \u003d \u0027netboot\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_3d3c54e1","line":451,"updated":"2015-04-08 23:14:33.000000000","message":"Should the bug number be here also?  Or only in the unit test","commit_id":"13012867079cbb37b3333b4fec847e0b807201ba"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6f84b93402ccc1b63edfba06d3596914efe7f75b","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    node.save()"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # XXX(jroll) DIB relies on boot_option\u003dlocal to decide whether or not to"},{"line_number":451,"context_line":"    # lay down a bootloader. Hack this for now; fix it for real in Liberty."},{"line_number":452,"context_line":"    boot_option \u003d get_boot_option(node)"},{"line_number":453,"context_line":"    if node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":454,"context_line":"        boot_option \u003d \u0027netboot\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_f64714ba","line":451,"in_reply_to":"9aa53dc9_108960c9","updated":"2015-04-09 14:20:35.000000000","message":"+1","commit_id":"13012867079cbb37b3333b4fec847e0b807201ba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ea2eec33d26588b47532fe6c1b1cc411ca74fc80","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    node.save()"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # XXX(jroll) DIB relies on boot_option\u003dlocal to decide whether or not to"},{"line_number":451,"context_line":"    # lay down a bootloader. Hack this for now; fix it for real in Liberty."},{"line_number":452,"context_line":"    boot_option \u003d get_boot_option(node)"},{"line_number":453,"context_line":"    if node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):"},{"line_number":454,"context_line":"        boot_option \u003d \u0027netboot\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_108960c9","line":451,"in_reply_to":"9aa53dc9_3d3c54e1","updated":"2015-04-09 13:42:16.000000000","message":"++ for having bug number here too, but that\u0027s rather a nit","commit_id":"13012867079cbb37b3333b4fec847e0b807201ba"}],"ironic/tests/drivers/test_iscsi_deploy.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"00c525e1bbf19e2f2b615f1522aa6bdad75541c0","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        self._test_build_deploy_ramdisk_options(mock_alnum, fake_api_url,"},{"line_number":488,"context_line":"                                                expected_boot_option\u003dexpected)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @mock.patch.object(keystone, \u0027get_service_url\u0027)"},{"line_number":491,"context_line":"    @mock.patch.object(utils, \u0027random_alnum\u0027)"},{"line_number":492,"context_line":"    def test_build_deploy_ramdisk_options_whole_disk_image(self, mock_alnum,"},{"line_number":493,"context_line":"                                                           mock_get_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_1d487086","line":490,"updated":"2015-04-08 23:14:33.000000000","message":"could add autospec\u003dTrue if desired to the mocks","commit_id":"13012867079cbb37b3333b4fec847e0b807201ba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ea2eec33d26588b47532fe6c1b1cc411ca74fc80","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        self._test_build_deploy_ramdisk_options(mock_alnum, fake_api_url,"},{"line_number":488,"context_line":"                                                expected_boot_option\u003dexpected)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @mock.patch.object(keystone, \u0027get_service_url\u0027)"},{"line_number":491,"context_line":"    @mock.patch.object(utils, \u0027random_alnum\u0027)"},{"line_number":492,"context_line":"    def test_build_deploy_ramdisk_options_whole_disk_image(self, mock_alnum,"},{"line_number":493,"context_line":"                                                           mock_get_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_f0a83c22","line":490,"in_reply_to":"9aa53dc9_1d487086","updated":"2015-04-09 13:42:16.000000000","message":"++","commit_id":"13012867079cbb37b3333b4fec847e0b807201ba"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4330005c109be9d52eb68ab1911c50cf2b0b861a","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        self.node.instance_info \u003d {\u0027capabilities\u0027: \u0027{\"boot_option\": \"local\"}\u0027}"},{"line_number":499,"context_line":"        dii \u003d self.node.driver_internal_info"},{"line_number":500,"context_line":"        dii[\u0027is_whole_disk_image\u0027] \u003d True"},{"line_number":501,"context_line":"        self.node.driver_internal_info \u003d dii"},{"line_number":502,"context_line":"        expected \u003d \u0027netboot\u0027"},{"line_number":503,"context_line":"        fake_api_url \u003d \u0027http://127.0.0.1:6385\u0027"},{"line_number":504,"context_line":"        self.config(api_url\u003dfake_api_url, group\u003d\u0027conductor\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_9ba231fc","line":501,"updated":"2015-04-09 13:48:45.000000000","message":"If you are throwing a new patch, better to self.node.save() here as if we ever changed implementation of _test_build_deploy_ramdisk_options() (for example to create a task object and use it), it might save wondering time of the implementer. :)","commit_id":"13012867079cbb37b3333b4fec847e0b807201ba"}]}