)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3d0e6ce938c5e8657f3773a729357fff52d0547","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-27 17:39:34 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1572529"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie357dfb68e663880d9806853f8f4a1954c50a877"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3aaa91ec_14aee684","line":8,"updated":"2016-06-29 09:37:14.000000000","message":"Please expand a little bit the commit message here [0], something like:\n\nImplement RAID in the drac driver using the generic interface abstraction. Prior to this patch drac used the vendor passthru methods ...\n\n\n[0] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"adb6b2a44ce62e1da20d6787c086791f9282ae6e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-27 17:39:34 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRAC RAID configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1572529"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie357dfb68e663880d9806853f8f4a1954c50a877"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3aaa91ec_9aa0f543","line":8,"in_reply_to":"3aaa91ec_14aee684","updated":"2016-07-04 08:32:05.000000000","message":"Done.\n\nBtw, the DRAC RAID methods on vendor-passthru was never merged upstream.","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"}],"ironic/conf/opts.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5cb87860e477221fbd8d9ca0dbdb33224ceadeb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    (\u0027database\u0027, ironic.conf.database.opts),"},{"line_number":46,"context_line":"    (\u0027deploy\u0027, ironic.conf.deploy.opts),"},{"line_number":47,"context_line":"    (\u0027dhcp\u0027, ironic.conf.dhcp.opts),"},{"line_number":48,"context_line":"    (\u0027drac\u0027, ironic.drivers.modules.drac.raid.opts),"},{"line_number":49,"context_line":"    (\u0027glance\u0027, ironic.conf.glance.list_opts()),"},{"line_number":50,"context_line":"    (\u0027iboot\u0027, ironic.conf.iboot.opts),"},{"line_number":51,"context_line":"    (\u0027ilo\u0027, ironic.conf.ilo.opts),"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ad45d7e_e215be9b","line":48,"updated":"2016-08-12 14:04:13.000000000","message":"Heh, nope, it\u0027s not all you need :) Here is an example of how it should look like - https://review.openstack.org/309615","commit_id":"1d50e64203e5d96b5bd57a3a1bb1f648d63531a1"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"e02757e6acacc83d2db211e7cdd51d6878ee9407","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    (\u0027database\u0027, ironic.conf.database.opts),"},{"line_number":46,"context_line":"    (\u0027deploy\u0027, ironic.conf.deploy.opts),"},{"line_number":47,"context_line":"    (\u0027dhcp\u0027, ironic.conf.dhcp.opts),"},{"line_number":48,"context_line":"    (\u0027drac\u0027, ironic.drivers.modules.drac.raid.opts),"},{"line_number":49,"context_line":"    (\u0027glance\u0027, ironic.conf.glance.list_opts()),"},{"line_number":50,"context_line":"    (\u0027iboot\u0027, ironic.conf.iboot.opts),"},{"line_number":51,"context_line":"    (\u0027ilo\u0027, ironic.conf.ilo.opts),"}],"source_content_type":"text/x-python","patch_set":33,"id":"3ac371cc_97af8f93","line":48,"in_reply_to":"9ad45d7e_e215be9b","updated":"2016-08-16 14:48:58.000000000","message":"Done","commit_id":"1d50e64203e5d96b5bd57a3a1bb1f648d63531a1"}],"ironic/drivers/drac.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3d0e6ce938c5e8657f3773a729357fff52d0547","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                  node.uuid)"},{"line_number":163,"context_line":"        rpc \u003d rpcapi.ConductorAPI()"},{"line_number":164,"context_line":"        topic \u003d rpc.get_topic_for(node)"},{"line_number":165,"context_line":"        rpc.continue_node_clean(context, node.uuid, topic\u003dtopic)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_b4d6f2c0","line":165,"updated":"2016-06-29 09:37:14.000000000","message":"In the driver/ directory we just have the assembly of the driver, all the logic of the the speific drivers lives in their module page.\n\nCan we move this methods here to ironic/drivers/modules/drac/raid ?","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"adb6b2a44ce62e1da20d6787c086791f9282ae6e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                  node.uuid)"},{"line_number":163,"context_line":"        rpc \u003d rpcapi.ConductorAPI()"},{"line_number":164,"context_line":"        topic \u003d rpc.get_topic_for(node)"},{"line_number":165,"context_line":"        rpc.continue_node_clean(context, node.uuid, topic\u003dtopic)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_1a4885b2","line":165,"in_reply_to":"3aaa91ec_b070b073","updated":"2016-07-04 08:32:05.000000000","message":"Yeah, I checked again, and defining the periodic task in the module doesn\u0027t work. :-(","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9d0add7da96ac5ce697612fe95e72e76e6c1be41","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                  node.uuid)"},{"line_number":163,"context_line":"        rpc \u003d rpcapi.ConductorAPI()"},{"line_number":164,"context_line":"        topic \u003d rpc.get_topic_for(node)"},{"line_number":165,"context_line":"        rpc.continue_node_clean(context, node.uuid, topic\u003dtopic)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_b070b073","line":165,"in_reply_to":"3aaa91ec_b4d6f2c0","updated":"2016-06-29 13:12:07.000000000","message":"That would be great but driver periodic tasks must be defined here in order to work. At least that was the case last time, but will double-check.","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    \u0027card, it continues to check for status update on the \u0027"},{"line_number":46,"context_line":"                    \u0027config job to determine whether the RAID configuration \u0027"},{"line_number":47,"context_line":"                    \u0027was successfully finished or not at this interval, in \u0027"},{"line_number":48,"context_line":"                    \u0027seconds\u0027)"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_48d2a901","line":48,"updated":"2016-07-19 11:06:29.000000000","message":"I\u0027d rephrase it to put the value description in the beginning and simplify: \"Interval (in seconds) between periodic RAID configuration job status checks\"","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                    \u0027card, it continues to check for status update on the \u0027"},{"line_number":46,"context_line":"                    \u0027config job to determine whether the RAID configuration \u0027"},{"line_number":47,"context_line":"                    \u0027was successfully finished or not at this interval, in \u0027"},{"line_number":48,"context_line":"                    \u0027seconds\u0027)"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_86733215","line":48,"in_reply_to":"dada55a8_48d2a901","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @periodics.periodic("},{"line_number":87,"context_line":"        spacing\u003dCONF.drac.query_raid_config_job_status_interval)"},{"line_number":88,"context_line":"    def _query_raid_config_job_status(self, manager, context):"},{"line_number":89,"context_line":"        \"\"\"Periodic task to check the progress of running RAID config jobs.\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        filters \u003d {\u0027reserved\u0027: False, \u0027maintenance\u0027: False}"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_28cdb55d","line":88,"updated":"2016-07-19 11:06:29.000000000","message":"maybe I\u0027ve asked already, but forgot. Why not put this task on the DracRAID class? It seems to belong there. After driver composition reform putting tasks directly on driver will be impossible.","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @periodics.periodic("},{"line_number":87,"context_line":"        spacing\u003dCONF.drac.query_raid_config_job_status_interval)"},{"line_number":88,"context_line":"    def _query_raid_config_job_status(self, manager, context):"},{"line_number":89,"context_line":"        \"\"\"Periodic task to check the progress of running RAID config jobs.\"\"\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        filters \u003d {\u0027reserved\u0027: False, \u0027maintenance\u0027: False}"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_e6930eff","line":88,"in_reply_to":"dada55a8_28cdb55d","updated":"2016-07-25 17:04:45.000000000","message":"Periodic tasks are not registered on the interfaces, only on the driver. I will add a note.","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        node_list \u003d manager.iter_nodes(fields\u003dfields, filters\u003dfilters)"},{"line_number":95,"context_line":"        for (node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":96,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_88dca113","line":96,"updated":"2016-07-19 11:06:29.000000000","message":"I wonder if it\u0027s better to use isinstance(task.driver.raid, DracRaid) later on","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        node_list \u003d manager.iter_nodes(fields\u003dfields, filters\u003dfilters)"},{"line_number":95,"context_line":"        for (node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":96,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_513616e8","line":96,"in_reply_to":"dada55a8_88dca113","updated":"2016-07-25 17:04:45.000000000","message":"we don\u0027t have a task object yet. requesting a shared lock at this point on all nodes would be a bit heavy, not?","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"},{"line_number":100,"context_line":"            if not job_ids:"},{"line_number":101,"context_line":"                continue"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_68d7aded","line":99,"updated":"2016-07-19 11:06:29.000000000","message":"this check essentially makes the check above redundant btw","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":97,"context_line":"                continue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"},{"line_number":100,"context_line":"            if not job_ids:"},{"line_number":101,"context_line":"                continue"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_213b02d3","line":99,"in_reply_to":"dada55a8_68d7aded","updated":"2016-07-25 17:04:45.000000000","message":"For now yes, but once another driver will start using dirver_internal_info[\u0027raid_config_job_ids\u0027] we would be screwed.","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                continue"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                with task_manager.acquire(context, node_uuid) as task:"},{"line_number":105,"context_line":"                    self._check_node_raid_jobs(task)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            except exception.NodeNotFound:"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_c804d97f","line":104,"updated":"2016-07-19 11:06:29.000000000","message":"1. please provide \"purpose\" argument\n\n2. do you always need an exclusive lock? I\u0027d prefer to take a shared lock first, and then upgrade it if we need to apply any changes to the node.","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                continue"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                with task_manager.acquire(context, node_uuid) as task:"},{"line_number":105,"context_line":"                    self._check_node_raid_jobs(task)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            except exception.NodeNotFound:"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_4172764a","line":104,"in_reply_to":"dada55a8_c804d97f","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                self._notify_conductor_resume_clean(task)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":138,"context_line":"                node.maintenance \u003d True"},{"line_number":139,"context_line":"                node.last_error \u003d config_job.message"},{"line_number":140,"context_line":"                node.save()"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a807e57f","line":138,"updated":"2016-07-19 11:06:29.000000000","message":"please don\u0027t change maintenance","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                self._notify_conductor_resume_clean(task)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":138,"context_line":"                node.maintenance \u003d True"},{"line_number":139,"context_line":"                node.last_error \u003d config_job.message"},{"line_number":140,"context_line":"                node.save()"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_e73bbae9","line":138,"in_reply_to":"dada55a8_a807e57f","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                 self.driver_passthru_mapping)"},{"line_number":82,"context_line":"        self.inspect \u003d inspector.Inspector.create_if_enabled(\u0027PXEDracDriver\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(ifarkas): This is specific to the RAID interface but periodic tasks"},{"line_number":85,"context_line":"    #                defined on the interfaces are not registered. Once the"},{"line_number":86,"context_line":"    #                driver composition reform is done, this can be moved to"},{"line_number":87,"context_line":"    #                its proper place."},{"line_number":88,"context_line":"    @periodics.periodic("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_aabd1dd9","line":85,"range":{"start_line":84,"start_character":65,"end_line":85,"end_character":65},"updated":"2016-08-09 15:10:38.000000000","message":"I doubt it\u0027s correct (see ironic.drivers.modules.inspector for an example), and what you\u0027re doing is already deprecated by a change currently in the gate.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                 self.driver_passthru_mapping)"},{"line_number":82,"context_line":"        self.inspect \u003d inspector.Inspector.create_if_enabled(\u0027PXEDracDriver\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(ifarkas): This is specific to the RAID interface but periodic tasks"},{"line_number":85,"context_line":"    #                defined on the interfaces are not registered. Once the"},{"line_number":86,"context_line":"    #                driver composition reform is done, this can be moved to"},{"line_number":87,"context_line":"    #                its proper place."},{"line_number":88,"context_line":"    @periodics.periodic("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_9df833c5","line":85,"range":{"start_line":84,"start_character":65,"end_line":85,"end_character":65},"in_reply_to":"9ad45d7e_aabd1dd9","updated":"2016-08-10 14:57:57.000000000","message":"Yes, I was wrong. I figured when I tried previously, I put it on the module, not the actual class - that caused it not to register.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"224b7fe44cfe0daed95a9c4caa5fb686e37540d3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    # NOTE(ifarkas): This is specific to the RAID interface but periodic tasks"},{"line_number":85,"context_line":"    #                defined on the interfaces are not registered. Once the"},{"line_number":86,"context_line":"    #                driver composition reform is done, this can be moved to"},{"line_number":87,"context_line":"    #                its proper place."},{"line_number":88,"context_line":"    @periodics.periodic("},{"line_number":89,"context_line":"        spacing\u003dCONF.drac.query_raid_config_job_status_interval)"},{"line_number":90,"context_line":"    def _query_raid_config_job_status(self, manager, context):"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_60574f26","line":87,"updated":"2016-07-27 09:10:46.000000000","message":"++ to move it later, I really would like to have all the \"code\" under modules/ instead of here at the driver definition file.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        node_list \u003d manager.iter_nodes(fields\u003dfields, filters\u003dfilters)"},{"line_number":97,"context_line":"        for (node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":98,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":99,"context_line":"                continue"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_ea3ef5d8","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":36},"updated":"2016-08-09 15:10:38.000000000","message":"cont. re isinstance(task.driver.raid, DracRaid): a shared lock is equivalent for fetching a node from database, so dunno.. I don\u0027t like hardcoded strings, but I can live with it for now (will probably break with driver composition though)","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        node_list \u003d manager.iter_nodes(fields\u003dfields, filters\u003dfilters)"},{"line_number":97,"context_line":"        for (node_uuid, driver, driver_internal_info) in node_list:"},{"line_number":98,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":99,"context_line":"                continue"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_3dd5c71b","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":36},"in_reply_to":"9ad45d7e_ea3ef5d8","updated":"2016-08-10 14:57:57.000000000","message":"OK, changing it.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":99,"context_line":"                continue"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"},{"line_number":102,"context_line":"            if not job_ids:"},{"line_number":103,"context_line":"                continue"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_b5261eb8","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":69},"updated":"2016-08-09 15:10:38.000000000","message":"\u003e but once another driver will start using dirver_internal_info[\u0027raid_config_job_ids\u0027] we would be screwed.\n\nWell, if another drier starts using \"drac\" in it\u0027s name, we also have problems :) I\u0027d feel much more comfortable relying on this field rather than \"drac\" in driver.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if \u0027drac\u0027 not in driver:"},{"line_number":99,"context_line":"                continue"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            job_ids \u003d driver_internal_info.get(\u0027raid_config_job_ids\u0027)"},{"line_number":102,"context_line":"            if not job_ids:"},{"line_number":103,"context_line":"                continue"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_1dda834c","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":69},"in_reply_to":"9ad45d7e_b5261eb8","updated":"2016-08-10 14:57:57.000000000","message":"Done","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        \u0027get_bios_config\u0027: self.drac_vendor,"},{"line_number":49,"context_line":"                        \u0027set_bios_config\u0027: self.drac_vendor,"},{"line_number":50,"context_line":"                        \u0027commit_bios_config\u0027: self.drac_vendor,"},{"line_number":51,"context_line":"                        \u0027abandon_bios_config\u0027: self.drac_vendor,"},{"line_number":52,"context_line":"                        }"},{"line_number":53,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":54,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_a0c81e56","side":"PARENT","line":51,"updated":"2016-08-11 18:35:51.000000000","message":"This is a super-nit, but I\u0027d prefer to leave this as is :)","commit_id":"3d027a46333ef727dcd3272de944fa692f716dc9"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        \u0027get_bios_config\u0027: self.drac_vendor,"},{"line_number":49,"context_line":"                        \u0027set_bios_config\u0027: self.drac_vendor,"},{"line_number":50,"context_line":"                        \u0027commit_bios_config\u0027: self.drac_vendor,"},{"line_number":51,"context_line":"                        \u0027abandon_bios_config\u0027: self.drac_vendor,"},{"line_number":52,"context_line":"                        }"},{"line_number":53,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":54,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_7ac0582b","side":"PARENT","line":51,"in_reply_to":"9ad45d7e_a0c81e56","updated":"2016-08-12 13:59:19.000000000","message":"Alright, I hope no one will -1 asking otherwise :D","commit_id":"3d027a46333ef727dcd3272de944fa692f716dc9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5cb87860e477221fbd8d9ca0dbdb33224ceadeb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        \u0027get_bios_config\u0027: self.drac_vendor,"},{"line_number":56,"context_line":"                        \u0027set_bios_config\u0027: self.drac_vendor,"},{"line_number":57,"context_line":"                        \u0027commit_bios_config\u0027: self.drac_vendor,"},{"line_number":58,"context_line":"                        \u0027abandon_bios_config\u0027: self.drac_vendor"},{"line_number":59,"context_line":"                        }"},{"line_number":60,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":61,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ad45d7e_62d70ec0","line":58,"updated":"2016-08-12 14:04:13.000000000","message":"Leave the comma please :D","commit_id":"1d50e64203e5d96b5bd57a3a1bb1f648d63531a1"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"e02757e6acacc83d2db211e7cdd51d6878ee9407","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        \u0027get_bios_config\u0027: self.drac_vendor,"},{"line_number":56,"context_line":"                        \u0027set_bios_config\u0027: self.drac_vendor,"},{"line_number":57,"context_line":"                        \u0027commit_bios_config\u0027: self.drac_vendor,"},{"line_number":58,"context_line":"                        \u0027abandon_bios_config\u0027: self.drac_vendor"},{"line_number":59,"context_line":"                        }"},{"line_number":60,"context_line":"        self.driver_passthru_mapping \u003d {\u0027lookup\u0027: self.iscsi_vendor}"},{"line_number":61,"context_line":"        self.vendor \u003d utils.MixinVendorInterface(self.mapping,"}],"source_content_type":"text/x-python","patch_set":33,"id":"3ac371cc_ea21bfa0","line":58,"in_reply_to":"9ad45d7e_62d70ec0","updated":"2016-08-16 14:48:58.000000000","message":"Done :D","commit_id":"1d50e64203e5d96b5bd57a3a1bb1f648d63531a1"}],"ironic/drivers/modules/drac/deploy.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3d0e6ce938c5e8657f3773a729357fff52d0547","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return []"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def prepare_cleaning(self, task):"},{"line_number":28,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_0f0413be","line":28,"updated":"2016-06-29 09:37:14.000000000","message":"Can\u0027t we just use ISCSIDeploy?\n\nCause we are disabling the erasing device cleaning steps by doing this, right?","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"9d0add7da96ac5ce697612fe95e72e76e6c1be41","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return []"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def prepare_cleaning(self, task):"},{"line_number":28,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_30a7a0be","line":28,"in_reply_to":"3aaa91ec_0f0413be","updated":"2016-06-29 13:12:07.000000000","message":"The issue with ISCSIDeploy is that it requires the ramdisk even for OOB manual clean steps. But you are right, losing erase would be bad. I will investigate further.","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"adb6b2a44ce62e1da20d6787c086791f9282ae6e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return []"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def prepare_cleaning(self, task):"},{"line_number":28,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_d877c5d2","line":28,"in_reply_to":"3aaa91ec_30a7a0be","updated":"2016-07-04 08:32:05.000000000","message":"Done. We need the ramdisk anyway for deploy.","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                            \u0027step\u0027: step[\u0027step\u0027]} not in _OOB_CLEAN_STEPS]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if (\u0027agent_cached_clean_steps\u0027 not in node.driver_internal_info or"},{"line_number":43,"context_line":"            len(inband_steps) \u003e 0):"},{"line_number":44,"context_line":"                return deploy_utils.prepare_inband_cleaning(task,"},{"line_number":45,"context_line":"                                                            manage_boot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_08ff1168","line":43,"updated":"2016-07-19 11:06:29.000000000","message":"`if len(x) \u003e 0` is roughly equivalent to `if x`","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                            \u0027step\u0027: step[\u0027step\u0027]} not in _OOB_CLEAN_STEPS]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if (\u0027agent_cached_clean_steps\u0027 not in node.driver_internal_info or"},{"line_number":43,"context_line":"            len(inband_steps) \u003e 0):"},{"line_number":44,"context_line":"                return deploy_utils.prepare_inband_cleaning(task,"},{"line_number":45,"context_line":"                                                            manage_boot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_270dd23e","line":43,"in_reply_to":"dada55a8_08ff1168","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"224b7fe44cfe0daed95a9c4caa5fb686e37540d3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Prepare environment for cleaning"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Boot into the agent to prepare for cleaning if in-band cleaning step"},{"line_number":33,"context_line":"        is requested."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        node \u003d task.node"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_a3bcb1dc","line":33,"updated":"2016-07-27 09:10:46.000000000","message":"nit: \n\n:returns: states.CLEANWAIT to signify an asynchronous prepare.\n\nWould be good to say what it returns, I had to look at the prepare_inband_cleaning to figure that out.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Prepare environment for cleaning"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Boot into the agent to prepare for cleaning if in-band cleaning step"},{"line_number":33,"context_line":"        is requested."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        node \u003d task.node"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_564cd59d","line":33,"in_reply_to":"9ad45d7e_553082e8","updated":"2016-08-10 14:57:57.000000000","message":"Done","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Prepare environment for cleaning"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Boot into the agent to prepare for cleaning if in-band cleaning step"},{"line_number":33,"context_line":"        is requested."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        node \u003d task.node"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_553082e8","line":33,"in_reply_to":"dada55a8_a3bcb1dc","updated":"2016-08-09 15:10:38.000000000","message":"+1","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"52bbda2844e2280e2fd61a12dd854f6b4938a4f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Prepare environment for cleaning"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Boot into the agent to prepare for cleaning if in-band cleaning step"},{"line_number":33,"context_line":"        is requested."},{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        node \u003d task.node"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_6f361752","line":33,"in_reply_to":"dada55a8_a3bcb1dc","updated":"2016-07-27 10:50:00.000000000","message":"Good point! I will fix it if the patch needs to be updated, or will do a follow-up.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5b2bc84aa5dccf6d96be351d81b46809d639581e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                        if {\u0027interface\u0027: step[\u0027interface\u0027],"},{"line_number":44,"context_line":"                            \u0027step\u0027: step[\u0027step\u0027]} not in _OOB_CLEAN_STEPS]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if (\u0027agent_cached_clean_steps\u0027 not in node.driver_internal_info or"},{"line_number":47,"context_line":"            inband_steps):"},{"line_number":48,"context_line":"                return deploy_utils.prepare_inband_cleaning(task,"},{"line_number":49,"context_line":"                                                            manage_boot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_85885de9","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":37},"updated":"2016-08-26 13:31:06.000000000","message":"So if the requested clean steps are only the ones that are out-of-band, and agent_cached_clean_steps is not in driver_internal_info, you\u0027ll still be booting the ramdisk? Why do you care about agent_cached_clean_steps? IIUC this is just a list of steps that can be executed by agent ramdisk.","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d2e6b0c2d3b472a89ab9e0b48c0b6ba1936e64cf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                        if {\u0027interface\u0027: step[\u0027interface\u0027],"},{"line_number":44,"context_line":"                            \u0027step\u0027: step[\u0027step\u0027]} not in _OOB_CLEAN_STEPS]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if (\u0027agent_cached_clean_steps\u0027 not in node.driver_internal_info or"},{"line_number":47,"context_line":"            inband_steps):"},{"line_number":48,"context_line":"                return deploy_utils.prepare_inband_cleaning(task,"},{"line_number":49,"context_line":"                                                            manage_boot\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_4d061a87","line":46,"range":{"start_line":46,"start_character":13,"end_line":46,"end_character":37},"in_reply_to":"fa7ab95a_85885de9","updated":"2016-08-29 14:11:26.000000000","message":"Yes, otherwise it will fail with \u0027cleaning steps are not yet available for node\u0027\n\nSee https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L507","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b29e3b238173e26f0bc3042c691a9ba4d6a17868","unresolved":false,"context_lines":[{"line_number":35,"context_line":"RAID_LEVELS \u003d {"},{"line_number":36,"context_line":"    \u00270\u0027: {"},{"line_number":37,"context_line":"        \u0027min_disks\u0027: 1,"},{"line_number":38,"context_line":"        \u0027max_disks\u0027: 1000,"},{"line_number":39,"context_line":"        \u0027type\u0027: \u0027simple\u0027,"},{"line_number":40,"context_line":"        \u0027overhead\u0027: 0"},{"line_number":41,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_ba6a1fb1","line":38,"updated":"2016-07-06 17:46:03.000000000","message":"Where does this number come from?","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"de8463e3c7810897e35c59719957d7c33a7efdb5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"RAID_LEVELS \u003d {"},{"line_number":36,"context_line":"    \u00270\u0027: {"},{"line_number":37,"context_line":"        \u0027min_disks\u0027: 1,"},{"line_number":38,"context_line":"        \u0027max_disks\u0027: 1000,"},{"line_number":39,"context_line":"        \u0027type\u0027: \u0027simple\u0027,"},{"line_number":40,"context_line":"        \u0027overhead\u0027: 0"},{"line_number":41,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_533add99","line":38,"in_reply_to":"1aa78d24_39b9fdcc","updated":"2016-07-07 13:14:50.000000000","message":"Do we need to set a `max_disks` at all, then? AFAICT there\u0027s no general limit to how many disks can be used in RAID 0 (etc), though some RAID systems may impose limits.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"862bc6e6ed77a6bddab1bb97002f6229ff7841a4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"RAID_LEVELS \u003d {"},{"line_number":36,"context_line":"    \u00270\u0027: {"},{"line_number":37,"context_line":"        \u0027min_disks\u0027: 1,"},{"line_number":38,"context_line":"        \u0027max_disks\u0027: 1000,"},{"line_number":39,"context_line":"        \u0027type\u0027: \u0027simple\u0027,"},{"line_number":40,"context_line":"        \u0027overhead\u0027: 0"},{"line_number":41,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_6cc9c55a","line":38,"in_reply_to":"1aa78d24_533add99","updated":"2016-07-08 09:08:59.000000000","message":"It\u0027s only really needed for RAID-1, for the rest it\u0027s just a placeholder. I can remove it and introduce a few conditionals in the code, if you think it would be better. WDYT?","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5a93ac1b59361f0dcd5828a22cb6ff403045dd7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"RAID_LEVELS \u003d {"},{"line_number":36,"context_line":"    \u00270\u0027: {"},{"line_number":37,"context_line":"        \u0027min_disks\u0027: 1,"},{"line_number":38,"context_line":"        \u0027max_disks\u0027: 1000,"},{"line_number":39,"context_line":"        \u0027type\u0027: \u0027simple\u0027,"},{"line_number":40,"context_line":"        \u0027overhead\u0027: 0"},{"line_number":41,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_39b9fdcc","line":38,"in_reply_to":"1aa78d24_ba6a1fb1","updated":"2016-07-07 08:53:14.000000000","message":"it\u0027s just an arbitrarily large number that no-one would exceed in the foreseeable future.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b29e3b238173e26f0bc3042c691a9ba4d6a17868","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"def _calculate_spans(raid_level, disks_count):"},{"line_number":247,"context_line":"    \"\"\"Calculates number of spans for a RAID level given a physical disk count"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param raid_level: RAID level of the virtual disk."},{"line_number":250,"context_line":"    :param disk_count: number of physical disks used for the virtual disk."}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_3ad58f1b","line":247,"updated":"2016-07-06 17:46:03.000000000","message":"My Google-fu is weak today: what is a \"span\"?","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5a93ac1b59361f0dcd5828a22cb6ff403045dd7c","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"def _calculate_spans(raid_level, disks_count):"},{"line_number":247,"context_line":"    \"\"\"Calculates number of spans for a RAID level given a physical disk count"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param raid_level: RAID level of the virtual disk."},{"line_number":250,"context_line":"    :param disk_count: number of physical disks used for the virtual disk."}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_59f5e9ea","line":247,"in_reply_to":"1aa78d24_3ad58f1b","updated":"2016-07-07 08:53:14.000000000","message":"It makes sense in terms of nested RAID levels: https://en.wikipedia.org/wiki/Nested_RAID_levels \n\nEg. \u00275+0\u0027 has 2 levels: on the lower level it has multiple RAID \u00275\u0027 volumes (or spans), put together into a single volume using striping (hence the \u0027+0\u0027).","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"de8463e3c7810897e35c59719957d7c33a7efdb5","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"def _calculate_spans(raid_level, disks_count):"},{"line_number":247,"context_line":"    \"\"\"Calculates number of spans for a RAID level given a physical disk count"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param raid_level: RAID level of the virtual disk."},{"line_number":250,"context_line":"    :param disk_count: number of physical disks used for the virtual disk."}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_b3f7c1d1","line":247,"in_reply_to":"1aa78d24_59f5e9ea","updated":"2016-07-07 13:14:50.000000000","message":"Aha, thanks (and I now see that \"span\" is used, but not defined, on that page, which I\u0027d been looking at). Is that a standard/widely-used term? If not, it would be good to define it.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"862bc6e6ed77a6bddab1bb97002f6229ff7841a4","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"def _calculate_spans(raid_level, disks_count):"},{"line_number":247,"context_line":"    \"\"\"Calculates number of spans for a RAID level given a physical disk count"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    :param raid_level: RAID level of the virtual disk."},{"line_number":250,"context_line":"    :param disk_count: number of physical disks used for the virtual disk."}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_2c34dd48","line":247,"in_reply_to":"1aa78d24_b3f7c1d1","updated":"2016-07-08 09:08:59.000000000","message":"AFAICT it\u0027s pretty standard term.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b29e3b238173e26f0bc3042c691a9ba4d6a17868","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    if raid_level in [\u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027]:"},{"line_number":275,"context_line":"        return disks_count"},{"line_number":276,"context_line":"    elif raid_level in [\u00275+0\u0027, \u00276+0\u0027, \u00271+0\u0027]:"},{"line_number":277,"context_line":"        return (disks_count \u003e\u003e 1) \u003c\u003c 1"},{"line_number":278,"context_line":"    else:"},{"line_number":279,"context_line":"        reason \u003d (_(\u0027Cannot number of disks for RAID level \"%s\"\u0027) %"},{"line_number":280,"context_line":"                  raid_level)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_da71eb45","line":277,"updated":"2016-07-06 17:46:03.000000000","message":"Largest power of 2 less than disks_count, yes? It might be worth adding a comment to that effect.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5a93ac1b59361f0dcd5828a22cb6ff403045dd7c","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    if raid_level in [\u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027]:"},{"line_number":275,"context_line":"        return disks_count"},{"line_number":276,"context_line":"    elif raid_level in [\u00275+0\u0027, \u00276+0\u0027, \u00271+0\u0027]:"},{"line_number":277,"context_line":"        return (disks_count \u003e\u003e 1) \u003c\u003c 1"},{"line_number":278,"context_line":"    else:"},{"line_number":279,"context_line":"        reason \u003d (_(\u0027Cannot number of disks for RAID level \"%s\"\u0027) %"},{"line_number":280,"context_line":"                  raid_level)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_8b341b4a","line":277,"in_reply_to":"1aa78d24_da71eb45","updated":"2016-07-07 08:53:14.000000000","message":"it\u0027s the largest even number less than disk_count.\n\nyou are right, a comment would be useful.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b29e3b238173e26f0bc3042c691a9ba4d6a17868","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    elif raid_level in [\u00275+0\u0027, \u00276+0\u0027, \u00271+0\u0027]:"},{"line_number":277,"context_line":"        return (disks_count \u003e\u003e 1) \u003c\u003c 1"},{"line_number":278,"context_line":"    else:"},{"line_number":279,"context_line":"        reason \u003d (_(\u0027Cannot number of disks for RAID level \"%s\"\u0027) %"},{"line_number":280,"context_line":"                  raid_level)"},{"line_number":281,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_9aa2c397","line":279,"updated":"2016-07-06 17:46:03.000000000","message":"You need a verb. \"Cannot calculate number of disks...\"","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5a93ac1b59361f0dcd5828a22cb6ff403045dd7c","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    elif raid_level in [\u00275+0\u0027, \u00276+0\u0027, \u00271+0\u0027]:"},{"line_number":277,"context_line":"        return (disks_count \u003e\u003e 1) \u003c\u003c 1"},{"line_number":278,"context_line":"    else:"},{"line_number":279,"context_line":"        reason \u003d (_(\u0027Cannot number of disks for RAID level \"%s\"\u0027) %"},{"line_number":280,"context_line":"                  raid_level)"},{"line_number":281,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_eb995f7a","line":279,"in_reply_to":"1aa78d24_9aa2c397","updated":"2016-07-07 08:53:14.000000000","message":"Done","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        return RAID_LEVELS[span_type][\u0027min_disks\u0027] * spans_count"},{"line_number":297,"context_line":"    else:"},{"line_number":298,"context_line":"        reason \u003d (_(\u0027Cannot calculate min disks for RAID level \"%s\"\u0027) %"},{"line_number":299,"context_line":"                  raid_level)"},{"line_number":300,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_48f90980","line":299,"updated":"2016-07-19 11:06:29.000000000","message":"I\u0027d like some more details in this error message. e.g. it\u0027s unclear to me without digging into source code why it happened. The message should give hints how a user fixes the problem.","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        return RAID_LEVELS[span_type][\u0027min_disks\u0027] * spans_count"},{"line_number":297,"context_line":"    else:"},{"line_number":298,"context_line":"        reason \u003d (_(\u0027Cannot calculate min disks for RAID level \"%s\"\u0027) %"},{"line_number":299,"context_line":"                  raid_level)"},{"line_number":300,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_4ce0e6cc","line":299,"in_reply_to":"dada55a8_48f90980","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        return RAID_LEVELS[span_type][\u0027max_disks\u0027]"},{"line_number":315,"context_line":"    else:"},{"line_number":316,"context_line":"        reason \u003d (_(\u0027Cannot calculate max disks for RAID level \"%s\"\u0027) %"},{"line_number":317,"context_line":"                  raid_level)"},{"line_number":318,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_28f49585","line":317,"updated":"2016-07-19 11:06:29.000000000","message":"ditto","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        return RAID_LEVELS[span_type][\u0027max_disks\u0027]"},{"line_number":315,"context_line":"    else:"},{"line_number":316,"context_line":"        reason \u003d (_(\u0027Cannot calculate max disks for RAID level \"%s\"\u0027) %"},{"line_number":317,"context_line":"                  raid_level)"},{"line_number":318,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_ace7e2e2","line":317,"in_reply_to":"dada55a8_28f49585","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":607,"context_line":"                                   reboot\u003dFalse)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        LOG.debug(\u0027Change has been commited to RAID controller %(controller)s \u0027"},{"line_number":610,"context_line":"                  \u0027on node %(node)s. DRAC job id: %(job_id)s\u0027 %"},{"line_number":611,"context_line":"                  {\u0027controller\u0027: controller,"},{"line_number":612,"context_line":"                   \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_88f3019e","line":609,"updated":"2016-07-19 11:06:29.000000000","message":"I wonder if it should be LOG.info, as it designates a finished user-visible task","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":607,"context_line":"                                   reboot\u003dFalse)"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        LOG.debug(\u0027Change has been commited to RAID controller %(controller)s \u0027"},{"line_number":610,"context_line":"                  \u0027on node %(node)s. DRAC job id: %(job_id)s\u0027 %"},{"line_number":611,"context_line":"                  {\u0027controller\u0027: controller,"},{"line_number":612,"context_line":"                   \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_4c074681","line":609,"in_reply_to":"dada55a8_88f3019e","updated":"2016-07-25 17:04:45.000000000","message":"Done","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        reason \u003d (_(\u0027RAID level %(raid_level)s is not supported by the \u0027"},{"line_number":281,"context_line":"                    \u0027driver. Supported RAID levels: %(supported_raid_levels)s\u0027)"},{"line_number":282,"context_line":"                  % {\u0027raid_level\u0027: raid_level,"},{"line_number":283,"context_line":"                     \u0027supported_raid_levels\u0027: RAID_LEVELS.keys()})"},{"line_number":284,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_35b06e43","line":283,"range":{"start_line":283,"start_character":46,"end_line":283,"end_character":64},"updated":"2016-08-09 15:10:38.000000000","message":"see below about keys and python 3","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        reason \u003d (_(\u0027RAID level %(raid_level)s is not supported by the \u0027"},{"line_number":281,"context_line":"                    \u0027driver. Supported RAID levels: %(supported_raid_levels)s\u0027)"},{"line_number":282,"context_line":"                  % {\u0027raid_level\u0027: raid_level,"},{"line_number":283,"context_line":"                     \u0027supported_raid_levels\u0027: RAID_LEVELS.keys()})"},{"line_number":284,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_191f2eb8","line":283,"range":{"start_line":283,"start_character":46,"end_line":283,"end_character":64},"in_reply_to":"9ad45d7e_35b06e43","updated":"2016-08-10 14:57:57.000000000","message":"Done","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        reason \u003d (_(\u0027RAID level %(raid_level)s is not supported by the \u0027"},{"line_number":292,"context_line":"                    \u0027driver. Supported RAID levels: %(supported_raid_levels)s\u0027)"},{"line_number":293,"context_line":"                  % {\u0027raid_level\u0027: raid_level,"},{"line_number":294,"context_line":"                     \u0027supported_raid_levels\u0027: RAID_LEVELS.keys()})"},{"line_number":295,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027simple\u0027:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_b59bbec8","line":294,"range":{"start_line":294,"start_character":46,"end_line":294,"end_character":64},"updated":"2016-08-09 15:10:38.000000000","message":".keys() is not needed, but you have to convert it to a list in Python 3, so list(RAID_LEVELS)","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        reason \u003d (_(\u0027RAID level %(raid_level)s is not supported by the \u0027"},{"line_number":292,"context_line":"                    \u0027driver. Supported RAID levels: %(supported_raid_levels)s\u0027)"},{"line_number":293,"context_line":"                  % {\u0027raid_level\u0027: raid_level,"},{"line_number":294,"context_line":"                     \u0027supported_raid_levels\u0027: RAID_LEVELS.keys()})"},{"line_number":295,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027simple\u0027:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_99815ec6","line":294,"range":{"start_line":294,"start_character":46,"end_line":294,"end_character":64},"in_reply_to":"9ad45d7e_b59bbec8","updated":"2016-08-10 14:57:57.000000000","message":"Done","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        reason \u003d (_(\u0027RAID level %(raid_level)s is not supported by the \u0027"},{"line_number":313,"context_line":"                    \u0027driver. Supported RAID levels: %(supported_raid_levels)s\u0027)"},{"line_number":314,"context_line":"                  % {\u0027raid_level\u0027: raid_level,"},{"line_number":315,"context_line":"                     \u0027supported_raid_levels\u0027: RAID_LEVELS.keys()})"},{"line_number":316,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027simple\u0027:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_15abaad7","line":315,"range":{"start_line":315,"start_character":46,"end_line":315,"end_character":64},"updated":"2016-08-09 15:10:38.000000000","message":"ditto","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        reason \u003d (_(\u0027RAID level %(raid_level)s is not supported by the \u0027"},{"line_number":313,"context_line":"                    \u0027driver. Supported RAID levels: %(supported_raid_levels)s\u0027)"},{"line_number":314,"context_line":"                  % {\u0027raid_level\u0027: raid_level,"},{"line_number":315,"context_line":"                     \u0027supported_raid_levels\u0027: RAID_LEVELS.keys()})"},{"line_number":316,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027simple\u0027:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_d96f5629","line":315,"range":{"start_line":315,"start_character":46,"end_line":315,"end_character":64},"in_reply_to":"9ad45d7e_15abaad7","updated":"2016-08-10 14:57:57.000000000","message":"Done","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36fb6cd9d4f5f2a9561f12e7f1790f993bd247f6","unresolved":false,"context_lines":[{"line_number":614,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":615,"context_line":"                                   reboot\u003dFalse)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        LOG.info(\u0027Change has been commited to RAID controller %(controller)s \u0027"},{"line_number":618,"context_line":"                 \u0027on node %(node)s. DRAC job id: %(job_id)s\u0027 %"},{"line_number":619,"context_line":"                 {\u0027controller\u0027: controller,"},{"line_number":620,"context_line":"                  \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_3597ce91","line":617,"updated":"2016-08-09 15:10:38.000000000","message":"this needs _LI","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"5fb18438ad2fe6ec73a995760669a57424aad19c","unresolved":false,"context_lines":[{"line_number":614,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":615,"context_line":"                                   reboot\u003dFalse)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        LOG.info(\u0027Change has been commited to RAID controller %(controller)s \u0027"},{"line_number":618,"context_line":"                 \u0027on node %(node)s. DRAC job id: %(job_id)s\u0027 %"},{"line_number":619,"context_line":"                 {\u0027controller\u0027: controller,"},{"line_number":620,"context_line":"                  \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_0fe07b28","line":617,"in_reply_to":"9ad45d7e_3597ce91","updated":"2016-08-10 14:57:57.000000000","message":"Done","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"224b7fe44cfe0daed95a9c4caa5fb686e37540d3","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        logical_disks_to_create \u003d _filter_logical_disks("},{"line_number":716,"context_line":"            logical_disks, create_root_volume, create_nonroot_volumes)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        controllers \u003d set()"},{"line_number":719,"context_line":"        for logical_disk in logical_disks_to_create:"},{"line_number":720,"context_line":"            controllers.add(logical_disk[\u0027controller\u0027])"},{"line_number":721,"context_line":"            create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_a3b831c9","line":718,"updated":"2016-07-27 09:10:46.000000000","message":"(Nothing to do here)\n\nDo we need a set here ? Is it possible to have the same logical_disk added twice in this loop?\n\nIt\u0027s not a big deal, I just found it a bit odd to start with a set and then convert it to a list (L731)","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"52bbda2844e2280e2fd61a12dd854f6b4938a4f0","unresolved":false,"context_lines":[{"line_number":715,"context_line":"        logical_disks_to_create \u003d _filter_logical_disks("},{"line_number":716,"context_line":"            logical_disks, create_root_volume, create_nonroot_volumes)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        controllers \u003d set()"},{"line_number":719,"context_line":"        for logical_disk in logical_disks_to_create:"},{"line_number":720,"context_line":"            controllers.add(logical_disk[\u0027controller\u0027])"},{"line_number":721,"context_line":"            create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_6fff3766","line":718,"in_reply_to":"dada55a8_a3b831c9","updated":"2016-07-27 10:50:00.000000000","message":"It\u0027s because we can have multiple RAID volumes (eg. RAID-0 for os, RAID-5 for storage) on the same controller. It\u0027s a set because we need a unique list of controllers to which we need to commit the changes.","commit_id":"171dc7543c756c25ee2d2ba717807b008f1642d3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":35,"context_line":"drac_exceptions \u003d importutils.try_import(\u0027dracclient.exceptions\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"opts \u003d ["},{"line_number":39,"context_line":"    cfg.IntOpt(\u0027query_raid_config_job_status_interval\u0027,"},{"line_number":40,"context_line":"               default\u003d120,"},{"line_number":41,"context_line":"               help\u003d\u0027Interval (in seconds) between periodic RAID job status \u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_eb2e778a","line":38,"updated":"2016-08-11 18:35:51.000000000","message":"this should go to the ironic.conf.drac nowadays","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":35,"context_line":"drac_exceptions \u003d importutils.try_import(\u0027dracclient.exceptions\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"opts \u003d ["},{"line_number":39,"context_line":"    cfg.IntOpt(\u0027query_raid_config_job_status_interval\u0027,"},{"line_number":40,"context_line":"               default\u003d120,"},{"line_number":41,"context_line":"               help\u003d\u0027Interval (in seconds) between periodic RAID job status \u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_49403836","line":38,"in_reply_to":"9ad45d7e_eb2e778a","updated":"2016-08-12 13:59:19.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027type\u0027: \u0027simple\u0027,"},{"line_number":77,"context_line":"        \u0027overhead\u0027: 2"},{"line_number":78,"context_line":"    },"},{"line_number":79,"context_line":"    \u00270+0\u0027: {"},{"line_number":80,"context_line":"        \u0027type\u0027: \u0027spanned\u0027,"},{"line_number":81,"context_line":"        \u0027span_type\u0027: \u00270\u0027"},{"line_number":82,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_fb7e3be2","line":79,"updated":"2016-08-11 18:35:51.000000000","message":"It\u0027s never used and I\u0027m not sure what it means...","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        \u0027type\u0027: \u0027simple\u0027,"},{"line_number":77,"context_line":"        \u0027overhead\u0027: 2"},{"line_number":78,"context_line":"    },"},{"line_number":79,"context_line":"    \u00270+0\u0027: {"},{"line_number":80,"context_line":"        \u0027type\u0027: \u0027spanned\u0027,"},{"line_number":81,"context_line":"        \u0027span_type\u0027: \u00270\u0027"},{"line_number":82,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_e9712caa","line":79,"in_reply_to":"9ad45d7e_fb7e3be2","updated":"2016-08-12 13:59:19.000000000","message":"Good point, deleting it","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    if raid_level in [\u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027]:"},{"line_number":273,"context_line":"        return 1"},{"line_number":274,"context_line":"    elif raid_level in [\u00275+0\u0027, \u00276+0\u0027]:"},{"line_number":275,"context_line":"        return 2"},{"line_number":276,"context_line":"    elif raid_level in [\u00271+0\u0027]:"},{"line_number":277,"context_line":"        return disks_count \u003e\u003e 1"},{"line_number":278,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_93d3add4","line":275,"range":{"start_line":275,"start_character":15,"end_line":275,"end_character":16},"updated":"2016-08-11 18:35:51.000000000","message":"Is it a hardware limitation?","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    if raid_level in [\u00270\u0027, \u00271\u0027, \u00275\u0027, \u00276\u0027]:"},{"line_number":273,"context_line":"        return 1"},{"line_number":274,"context_line":"    elif raid_level in [\u00275+0\u0027, \u00276+0\u0027]:"},{"line_number":275,"context_line":"        return 2"},{"line_number":276,"context_line":"    elif raid_level in [\u00271+0\u0027]:"},{"line_number":277,"context_line":"        return disks_count \u003e\u003e 1"},{"line_number":278,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_a985745a","line":275,"range":{"start_line":275,"start_character":15,"end_line":275,"end_character":16},"in_reply_to":"9ad45d7e_93d3add4","updated":"2016-08-12 13:59:19.000000000","message":"No, it\u0027s not a hw limitation. I used what the logic was in eg. opencrowbar in this case but I am open to other suggestions.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            raise exception.DracOperationError(error\u003dreason)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        span_type \u003d raid_level_info[\u0027span_type\u0027]"},{"line_number":345,"context_line":"        return RAID_LEVELS[span_type][\u0027max_disks\u0027]"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"def _raid_level_overhead(raid_level, spans_count\u003d1):"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_8e7ee467","line":345,"updated":"2016-08-11 18:35:51.000000000","message":"spans_count does not matter here?","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            raise exception.DracOperationError(error\u003dreason)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        span_type \u003d raid_level_info[\u0027span_type\u0027]"},{"line_number":345,"context_line":"        return RAID_LEVELS[span_type][\u0027max_disks\u0027]"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"def _raid_level_overhead(raid_level, spans_count\u003d1):"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_44781f2c","line":345,"in_reply_to":"9ad45d7e_8e7ee467","updated":"2016-08-12 13:59:19.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    raid_level_info \u003d RAID_LEVELS[raid_level]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027spanned\u0027:"},{"line_number":352,"context_line":"        span_type \u003d raid_level_info[\u0027span_type\u0027]"},{"line_number":353,"context_line":"        raid_level_info \u003d RAID_LEVELS[span_type][\u0027min_disks\u0027]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    return raid_level_info[\u0027overhead\u0027] * spans_count"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_4ebcecba","line":352,"updated":"2016-08-11 18:35:51.000000000","message":"no check for spans_count?","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    raid_level_info \u003d RAID_LEVELS[raid_level]"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027spanned\u0027:"},{"line_number":352,"context_line":"        span_type \u003d raid_level_info[\u0027span_type\u0027]"},{"line_number":353,"context_line":"        raid_level_info \u003d RAID_LEVELS[span_type][\u0027min_disks\u0027]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    return raid_level_info[\u0027overhead\u0027] * spans_count"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_ff443a1c","line":352,"in_reply_to":"9ad45d7e_4ebcecba","updated":"2016-08-12 13:59:19.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027spanned\u0027:"},{"line_number":352,"context_line":"        span_type \u003d raid_level_info[\u0027span_type\u0027]"},{"line_number":353,"context_line":"        raid_level_info \u003d RAID_LEVELS[span_type][\u0027min_disks\u0027]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    return raid_level_info[\u0027overhead\u0027] * spans_count"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_6e92904d","line":353,"range":{"start_line":353,"start_character":48,"end_line":353,"end_character":61},"updated":"2016-08-11 18:35:51.000000000","message":"seems like min_disks should not be here.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027spanned\u0027:"},{"line_number":352,"context_line":"        span_type \u003d raid_level_info[\u0027span_type\u0027]"},{"line_number":353,"context_line":"        raid_level_info \u003d RAID_LEVELS[span_type][\u0027min_disks\u0027]"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    return raid_level_info[\u0027overhead\u0027] * spans_count"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_c4e08fcf","line":353,"range":{"start_line":353,"start_character":48,"end_line":353,"end_character":61},"in_reply_to":"9ad45d7e_6e92904d","updated":"2016-08-12 13:59:19.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                        spans_count\u003d1, stripe_size_kb\u003d65536):"},{"line_number":360,"context_line":"    # restrict the size to the smallest available space"},{"line_number":361,"context_line":"    free_spaces \u003d [free_space_mb[disk] for disk in physical_disks]"},{"line_number":362,"context_line":"    size_kb \u003d min(free_spaces) * (2 ** 10)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    stripes_per_disk \u003d int(math.floor(float(size_kb) / stripe_size_kb))"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_8e5c247e","line":362,"range":{"start_line":362,"start_character":33,"end_line":362,"end_character":42},"updated":"2016-08-11 18:35:51.000000000","message":"there is a units module in oslo_utils for such stuff","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                        spans_count\u003d1, stripe_size_kb\u003d65536):"},{"line_number":360,"context_line":"    # restrict the size to the smallest available space"},{"line_number":361,"context_line":"    free_spaces \u003d [free_space_mb[disk] for disk in physical_disks]"},{"line_number":362,"context_line":"    size_kb \u003d min(free_spaces) * (2 ** 10)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    stripes_per_disk \u003d int(math.floor(float(size_kb) / stripe_size_kb))"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_ffb39ae7","line":362,"range":{"start_line":362,"start_character":33,"end_line":362,"end_character":42},"in_reply_to":"9ad45d7e_8e5c247e","updated":"2016-08-12 13:59:19.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    overhead_disks_count \u003d _raid_level_overhead(logical_disk[\u0027raid_level\u0027],"},{"line_number":377,"context_line":"                                                spans_count)"},{"line_number":378,"context_line":"    volume_size_kb \u003d logical_disk[\u0027size_mb\u0027] * (2 ** 10)"},{"line_number":379,"context_line":"    stripes_per_volume \u003d math.ceil(float(volume_size_kb) / stripe_size_kb)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    stripes_per_disk \u003d math.ceil("},{"line_number":382,"context_line":"        float(stripes_per_volume) / (disks_count - overhead_disks_count))"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_89e9beb9","line":379,"range":{"start_line":379,"start_character":30,"end_line":379,"end_character":34},"updated":"2016-08-11 18:35:51.000000000","message":"not sure why it\u0027s ceil here, not floor.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    overhead_disks_count \u003d _raid_level_overhead(logical_disk[\u0027raid_level\u0027],"},{"line_number":377,"context_line":"                                                spans_count)"},{"line_number":378,"context_line":"    volume_size_kb \u003d logical_disk[\u0027size_mb\u0027] * (2 ** 10)"},{"line_number":379,"context_line":"    stripes_per_volume \u003d math.ceil(float(volume_size_kb) / stripe_size_kb)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    stripes_per_disk \u003d math.ceil("},{"line_number":382,"context_line":"        float(stripes_per_volume) / (disks_count - overhead_disks_count))"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_dfc5f60a","line":379,"range":{"start_line":379,"start_character":30,"end_line":379,"end_character":34},"in_reply_to":"9ad45d7e_89e9beb9","updated":"2016-08-12 13:59:19.000000000","message":"because we don\u0027t want to underestimate the volume usage and end up in a situation where we overcommit disk space\n\nwill add a note","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    volume_size_kb \u003d logical_disk[\u0027size_mb\u0027] * (2 ** 10)"},{"line_number":379,"context_line":"    stripes_per_volume \u003d math.ceil(float(volume_size_kb) / stripe_size_kb)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    stripes_per_disk \u003d math.ceil("},{"line_number":382,"context_line":"        float(stripes_per_volume) / (disks_count - overhead_disks_count))"},{"line_number":383,"context_line":"    return int(stripes_per_disk * stripe_size_kb / (2 ** 10))"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_e9d4baec","line":381,"range":{"start_line":381,"start_character":28,"end_line":381,"end_character":32},"updated":"2016-08-11 18:35:51.000000000","message":"ditto","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    volume_size_kb \u003d logical_disk[\u0027size_mb\u0027] * (2 ** 10)"},{"line_number":379,"context_line":"    stripes_per_volume \u003d math.ceil(float(volume_size_kb) / stripe_size_kb)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    stripes_per_disk \u003d math.ceil("},{"line_number":382,"context_line":"        float(stripes_per_volume) / (disks_count - overhead_disks_count))"},{"line_number":383,"context_line":"    return int(stripes_per_disk * stripe_size_kb / (2 ** 10))"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_ffd43abe","line":381,"range":{"start_line":381,"start_character":28,"end_line":381,"end_character":32},"in_reply_to":"9ad45d7e_e9d4baec","updated":"2016-08-12 13:59:19.000000000","message":"same","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c7b7962ad65c4b5c32d180bbfdf938f9ef55c935","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    volumes_with_reserved_physical_disks \u003d ["},{"line_number":399,"context_line":"        volume for volume in logical_disks"},{"line_number":400,"context_line":"        if (\u0027physical_disks\u0027 in volume and volume[\u0027size_mb\u0027] \u003d\u003d \u0027MAX\u0027"},{"line_number":401,"context_line":"            and volume.get(\u0027share_physical_disks\u0027, False))]"},{"line_number":402,"context_line":"    reserved_physical_disks \u003d ["},{"line_number":403,"context_line":"        disk for disk in physical_disks"},{"line_number":404,"context_line":"        for volume in volumes_with_reserved_physical_disks"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_bfc83056","line":401,"range":{"start_line":401,"start_character":28,"end_line":401,"end_character":48},"updated":"2016-08-11 18:35:51.000000000","message":"Not sure I get this logic - if share_physical_disks is False, does not it mean that it is reserved? Or here (reserved !\u003d not shared)?","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    volumes_with_reserved_physical_disks \u003d ["},{"line_number":399,"context_line":"        volume for volume in logical_disks"},{"line_number":400,"context_line":"        if (\u0027physical_disks\u0027 in volume and volume[\u0027size_mb\u0027] \u003d\u003d \u0027MAX\u0027"},{"line_number":401,"context_line":"            and volume.get(\u0027share_physical_disks\u0027, False))]"},{"line_number":402,"context_line":"    reserved_physical_disks \u003d ["},{"line_number":403,"context_line":"        disk for disk in physical_disks"},{"line_number":404,"context_line":"        for volume in volumes_with_reserved_physical_disks"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_26cd335e","line":401,"range":{"start_line":401,"start_character":28,"end_line":401,"end_character":48},"in_reply_to":"9ad45d7e_bfc83056","updated":"2016-08-12 13:31:55.000000000","message":"I guess I get it now, nevermind.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"2ce2f4c8529a888e20afb2ecfaaed458e3cd0281","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    volumes_with_reserved_physical_disks \u003d ["},{"line_number":399,"context_line":"        volume for volume in logical_disks"},{"line_number":400,"context_line":"        if (\u0027physical_disks\u0027 in volume and volume[\u0027size_mb\u0027] \u003d\u003d \u0027MAX\u0027"},{"line_number":401,"context_line":"            and volume.get(\u0027share_physical_disks\u0027, False))]"},{"line_number":402,"context_line":"    reserved_physical_disks \u003d ["},{"line_number":403,"context_line":"        disk for disk in physical_disks"},{"line_number":404,"context_line":"        for volume in volumes_with_reserved_physical_disks"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_fae0c8fc","line":401,"range":{"start_line":401,"start_character":28,"end_line":401,"end_character":48},"in_reply_to":"9ad45d7e_bfc83056","updated":"2016-08-12 13:59:19.000000000","message":"reserved here means it won\u0027t be used during matching","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                if disk.id in volume[\u0027physical_disks\u0027]:"},{"line_number":435,"context_line":"                    disk_type \u003d (disk.controller, disk.media_type,"},{"line_number":436,"context_line":"                                 disk.interface_type, disk.size_mb)"},{"line_number":437,"context_line":"                    physical_disks_by_type[disk_type].remove(disk)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    processed_volumes \u003d []"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_c9fd480a","line":437,"range":{"start_line":437,"start_character":54,"end_line":437,"end_character":60},"updated":"2016-08-12 13:31:55.000000000","message":"Why not exclude them in the beginning of this function so that we don\u0027t have to remove it afterwards.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                if disk.id in volume[\u0027physical_disks\u0027]:"},{"line_number":435,"context_line":"                    disk_type \u003d (disk.controller, disk.media_type,"},{"line_number":436,"context_line":"                                 disk.interface_type, disk.size_mb)"},{"line_number":437,"context_line":"                    physical_disks_by_type[disk_type].remove(disk)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    processed_volumes \u003d []"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_2af59eca","line":437,"range":{"start_line":437,"start_character":54,"end_line":437,"end_character":60},"in_reply_to":"9ad45d7e_c9fd480a","updated":"2016-08-16 14:48:38.000000000","message":"I was considering that but it would make it way less readable. If you still think it would be better I can merge them.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    if len(selected_disks) % spans_count !\u003d 0:"},{"line_number":489,"context_line":"        error_msg \u003d _(\u0027invalid number of physical disks was provided\u0027)"},{"line_number":490,"context_line":"        raise exception.DracOperationError(error\u003derror_msg)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    disks_per_span \u003d len(selected_disks) / spans_count"},{"line_number":493,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_89c7d063","line":490,"range":{"start_line":490,"start_character":24,"end_line":490,"end_character":42},"updated":"2016-08-12 13:31:55.000000000","message":"Is it really an exception in this case, maybe just a warning? What if some of the disks were used in _find_configuration step 2, now we\u0027re in step 3? This question is not only about this place, but for the whole function, as it seems that the case if some of the disks were used on step 2 is not anyhow tracked on step 3.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    if len(selected_disks) % spans_count !\u003d 0:"},{"line_number":489,"context_line":"        error_msg \u003d _(\u0027invalid number of physical disks was provided\u0027)"},{"line_number":490,"context_line":"        raise exception.DracOperationError(error\u003derror_msg)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    disks_per_span \u003d len(selected_disks) / spans_count"},{"line_number":493,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_eaa2664a","line":490,"range":{"start_line":490,"start_character":24,"end_line":490,"end_character":42},"in_reply_to":"9ad45d7e_89c7d063","updated":"2016-08-16 14:48:38.000000000","message":"In step 2, the exception is catched at L583. \nIn step 3, this should raise an exception because that means we couldn\u0027t find a matching based on the spec.\n\nThe usage should be tracked via free_space_mb which needs a fix as you pointed out correctly.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":537,"context_line":"         interface_type, size_mb), disks in physical_disks_by_type.items():"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        if (\u0027disk_type\u0027 in logical_disk and"},{"line_number":540,"context_line":"            not logical_disk[\u0027disk_type\u0027] \u003d\u003d disk_type):"},{"line_number":541,"context_line":"            continue"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if (\u0027interface_type\u0027 in logical_disk and"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_ffb9da7a","line":540,"range":{"start_line":540,"start_character":42,"end_line":540,"end_character":44},"updated":"2016-08-12 13:31:55.000000000","message":"!\u003d instead of not \u003d\u003d :)","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":537,"context_line":"         interface_type, size_mb), disks in physical_disks_by_type.items():"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        if (\u0027disk_type\u0027 in logical_disk and"},{"line_number":540,"context_line":"            not logical_disk[\u0027disk_type\u0027] \u003d\u003d disk_type):"},{"line_number":541,"context_line":"            continue"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if (\u0027interface_type\u0027 in logical_disk and"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_87ae5683","line":540,"range":{"start_line":540,"start_character":42,"end_line":540,"end_character":44},"in_reply_to":"9ad45d7e_ffb9da7a","updated":"2016-08-16 14:48:38.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            continue"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if (\u0027interface_type\u0027 in logical_disk and"},{"line_number":544,"context_line":"            not logical_disk[\u0027interface_type\u0027] \u003d\u003d interface_type):"},{"line_number":545,"context_line":"            continue"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        # filter out disks without free disk space"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_9fa9be27","line":544,"range":{"start_line":544,"start_character":47,"end_line":544,"end_character":49},"updated":"2016-08-12 13:31:55.000000000","message":"ditto","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            continue"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if (\u0027interface_type\u0027 in logical_disk and"},{"line_number":544,"context_line":"            not logical_disk[\u0027interface_type\u0027] \u003d\u003d interface_type):"},{"line_number":545,"context_line":"            continue"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        # filter out disks without free disk space"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_47cbbe53","line":544,"range":{"start_line":544,"start_character":47,"end_line":544,"end_character":49},"in_reply_to":"9ad45d7e_9fa9be27","updated":"2016-08-16 14:48:38.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        # on a volume"},{"line_number":552,"context_line":"        disks \u003d sorted("},{"line_number":553,"context_line":"            disks,"},{"line_number":554,"context_line":"            key\u003dlambda disk, free_space_mb\u003dfree_space_mb: free_space_mb[disk])"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        # filter out disks already in use if sharing is disabled"},{"line_number":557,"context_line":"        if (\u0027share_physical_disks\u0027 not in logical_disk"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_1af2fc06","line":554,"range":{"start_line":554,"start_character":29,"end_line":554,"end_character":56},"updated":"2016-08-12 13:31:55.000000000","message":"I think it\u0027s not needed, python should get it from closure.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        # on a volume"},{"line_number":552,"context_line":"        disks \u003d sorted("},{"line_number":553,"context_line":"            disks,"},{"line_number":554,"context_line":"            key\u003dlambda disk, free_space_mb\u003dfree_space_mb: free_space_mb[disk])"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        # filter out disks already in use if sharing is disabled"},{"line_number":557,"context_line":"        if (\u0027share_physical_disks\u0027 not in logical_disk"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_c7c7ae10","line":554,"range":{"start_line":554,"start_character":29,"end_line":554,"end_character":56},"in_reply_to":"9ad45d7e_1af2fc06","updated":"2016-08-16 14:48:38.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                _assign_disks_to_volume(logical_disks, physical_disks_by_type,"},{"line_number":588,"context_line":"                                        candidate_free_space_mb)):"},{"line_number":589,"context_line":"                    logical_disks.append(candidate_volume)"},{"line_number":590,"context_line":"                    free_space_mb \u003d candidate_free_space_mb"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"                    return True"},{"line_number":593,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_b534a3fb","line":590,"range":{"start_line":590,"start_character":20,"end_line":590,"end_character":59},"updated":"2016-08-12 13:31:55.000000000","message":"We will not update the free_space_mb value that way for higher recursion layers, you need to do the items reassignment.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                _assign_disks_to_volume(logical_disks, physical_disks_by_type,"},{"line_number":588,"context_line":"                                        candidate_free_space_mb)):"},{"line_number":589,"context_line":"                    logical_disks.append(candidate_volume)"},{"line_number":590,"context_line":"                    free_space_mb \u003d candidate_free_space_mb"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"                    return True"},{"line_number":593,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_df3c83e4","line":590,"range":{"start_line":590,"start_character":20,"end_line":590,"end_character":59},"in_reply_to":"9ad45d7e_b534a3fb","updated":"2016-08-16 14:48:38.000000000","message":"Nice catch!","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                    free_space_mb \u003d candidate_free_space_mb"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"                    return True"},{"line_number":593,"context_line":"            else:"},{"line_number":594,"context_line":"                break"},{"line_number":595,"context_line":"    else:"},{"line_number":596,"context_line":"        # put back the logical_disk to queue"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_353b933a","line":593,"range":{"start_line":593,"start_character":12,"end_line":593,"end_character":17},"updated":"2016-08-12 13:31:55.000000000","message":"nit - no need for else here.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":590,"context_line":"                    free_space_mb \u003d candidate_free_space_mb"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"                    return True"},{"line_number":593,"context_line":"            else:"},{"line_number":594,"context_line":"                break"},{"line_number":595,"context_line":"    else:"},{"line_number":596,"context_line":"        # put back the logical_disk to queue"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_47b1fe8e","line":593,"range":{"start_line":593,"start_character":12,"end_line":593,"end_character":17},"in_reply_to":"9ad45d7e_353b933a","updated":"2016-08-16 14:48:38.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        \"\"\"Return the properties of the interface.\"\"\""},{"line_number":654,"context_line":"        return drac_common.COMMON_PROPERTIES"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def validate(self, task):"},{"line_number":657,"context_line":"        \"\"\"Validate the RAID interface."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":660,"context_line":"        :raises: InvalidParameterValue, if RAID configuration is invalid."},{"line_number":661,"context_line":"        :raises: MissingParameterValue, if RAID configuration has some"},{"line_number":662,"context_line":"                 missing parameters."},{"line_number":663,"context_line":"        \"\"\""},{"line_number":664,"context_line":"        node \u003d task.node"},{"line_number":665,"context_line":"        self.validate_raid_config(task, node.target_raid_config)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def validate_raid_config(self, task, raid_config):"},{"line_number":668,"context_line":"        \"\"\"Validate a given RAID configuration."},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":671,"context_line":"        :param raid_config: The target RAID config to validate."},{"line_number":672,"context_line":"        :raises: InvalidParameterValue, if RAID configuration is invalid."},{"line_number":673,"context_line":"        \"\"\""},{"line_number":674,"context_line":"        raid_common.validate_configuration(raid_config, self.raid_schema)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":677,"context_line":"        \u0027create_root_volume\u0027: {"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_79d065f8","line":674,"range":{"start_line":656,"start_character":4,"end_line":674,"end_character":73},"updated":"2016-08-12 13:31:55.000000000","message":"It seems to do exactly the same things as base interface does, is there any reason to add it?","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        \"\"\"Return the properties of the interface.\"\"\""},{"line_number":654,"context_line":"        return drac_common.COMMON_PROPERTIES"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"    def validate(self, task):"},{"line_number":657,"context_line":"        \"\"\"Validate the RAID interface."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":660,"context_line":"        :raises: InvalidParameterValue, if RAID configuration is invalid."},{"line_number":661,"context_line":"        :raises: MissingParameterValue, if RAID configuration has some"},{"line_number":662,"context_line":"                 missing parameters."},{"line_number":663,"context_line":"        \"\"\""},{"line_number":664,"context_line":"        node \u003d task.node"},{"line_number":665,"context_line":"        self.validate_raid_config(task, node.target_raid_config)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def validate_raid_config(self, task, raid_config):"},{"line_number":668,"context_line":"        \"\"\"Validate a given RAID configuration."},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":671,"context_line":"        :param raid_config: The target RAID config to validate."},{"line_number":672,"context_line":"        :raises: InvalidParameterValue, if RAID configuration is invalid."},{"line_number":673,"context_line":"        \"\"\""},{"line_number":674,"context_line":"        raid_common.validate_configuration(raid_config, self.raid_schema)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":677,"context_line":"        \u0027create_root_volume\u0027: {"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_d2b76af3","line":674,"range":{"start_line":656,"start_character":4,"end_line":674,"end_character":73},"in_reply_to":"9ad45d7e_79d065f8","updated":"2016-08-16 14:48:38.000000000","message":"no reason for that, going to delete them","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        \u0027create_nonroot_volumes\u0027: {"},{"line_number":685,"context_line":"            \u0027description\u0027: ("},{"line_number":686,"context_line":"                \u0027This specifies whether to create the non-root volumes. \u0027"},{"line_number":687,"context_line":"                \u0027Defaults to `True`.\u0027"},{"line_number":688,"context_line":"            ),"},{"line_number":689,"context_line":"            \u0027required\u0027: True"},{"line_number":690,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_5c92afa0","line":687,"range":{"start_line":687,"start_character":17,"end_line":687,"end_character":36},"updated":"2016-08-12 13:31:55.000000000","message":"Why is it required then?","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        \u0027create_nonroot_volumes\u0027: {"},{"line_number":685,"context_line":"            \u0027description\u0027: ("},{"line_number":686,"context_line":"                \u0027This specifies whether to create the non-root volumes. \u0027"},{"line_number":687,"context_line":"                \u0027Defaults to `True`.\u0027"},{"line_number":688,"context_line":"            ),"},{"line_number":689,"context_line":"            \u0027required\u0027: True"},{"line_number":690,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_923a1297","line":687,"range":{"start_line":687,"start_character":17,"end_line":687,"end_character":36},"in_reply_to":"9ad45d7e_5c92afa0","updated":"2016-08-16 14:48:38.000000000","message":"good point, it shouldn\u0027t be","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        \"\"\"Delete the RAID configuration."},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":757,"context_line":"        :returns: states.CLEANWAIT if deletion is in progress asynchronously"},{"line_number":758,"context_line":"                  or None if it is completed."},{"line_number":759,"context_line":"        \"\"\""},{"line_number":760,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_fc7283af","line":757,"updated":"2016-08-12 13:31:55.000000000","message":"Missing raises here and in the next method.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        \"\"\"Delete the RAID configuration."},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":757,"context_line":"        :returns: states.CLEANWAIT if deletion is in progress asynchronously"},{"line_number":758,"context_line":"                  or None if it is completed."},{"line_number":759,"context_line":"        \"\"\""},{"line_number":760,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_080d5237","line":757,"in_reply_to":"9ad45d7e_fc7283af","updated":"2016-08-16 14:48:38.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        node \u003d task.node"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        raid_common.update_raid_info("},{"line_number":863,"context_line":"            node, task.driver.raid.get_logical_disk_properties(task))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        LOG.debug(\u0027Sending RPC to Conductor to resume cleaning for node %s\u0027,"},{"line_number":866,"context_line":"                  node.uuid)"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_59f48186","line":863,"range":{"start_line":863,"start_character":18,"end_line":863,"end_character":34},"updated":"2016-08-12 13:31:55.000000000","message":"can be self here :)","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        node \u003d task.node"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        raid_common.update_raid_info("},{"line_number":863,"context_line":"            node, task.driver.raid.get_logical_disk_properties(task))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        LOG.debug(\u0027Sending RPC to Conductor to resume cleaning for node %s\u0027,"},{"line_number":866,"context_line":"                  node.uuid)"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_8819427c","line":863,"range":{"start_line":863,"start_character":18,"end_line":863,"end_character":34},"in_reply_to":"9ad45d7e_59f48186","updated":"2016-08-16 14:48:38.000000000","message":"Done","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"66822585c7b6102d834c1ddb02e54120019c3b32","unresolved":false,"context_lines":[{"line_number":862,"context_line":"        raid_common.update_raid_info("},{"line_number":863,"context_line":"            node, task.driver.raid.get_logical_disk_properties(task))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        LOG.debug(\u0027Sending RPC to Conductor to resume cleaning for node %s\u0027,"},{"line_number":866,"context_line":"                  node.uuid)"},{"line_number":867,"context_line":"        rpc \u003d rpcapi.ConductorAPI()"},{"line_number":868,"context_line":"        topic \u003d rpc.get_topic_for(node)"},{"line_number":869,"context_line":"        rpc.continue_node_clean(task.context, node.uuid, topic\u003dtopic)"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_5950015f","line":869,"range":{"start_line":865,"start_character":8,"end_line":869,"end_character":69},"updated":"2016-08-12 13:31:55.000000000","message":"there is a method doing this in agent_base_vendor, maybe reuse it? also there is no release_resources here.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"a319f0f1a73b4e31040f9beb3a935226d29554e3","unresolved":false,"context_lines":[{"line_number":862,"context_line":"        raid_common.update_raid_info("},{"line_number":863,"context_line":"            node, task.driver.raid.get_logical_disk_properties(task))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        LOG.debug(\u0027Sending RPC to Conductor to resume cleaning for node %s\u0027,"},{"line_number":866,"context_line":"                  node.uuid)"},{"line_number":867,"context_line":"        rpc \u003d rpcapi.ConductorAPI()"},{"line_number":868,"context_line":"        topic \u003d rpc.get_topic_for(node)"},{"line_number":869,"context_line":"        rpc.continue_node_clean(task.context, node.uuid, topic\u003dtopic)"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac371cc_68c5e68c","line":869,"range":{"start_line":865,"start_character":8,"end_line":869,"end_character":69},"in_reply_to":"9ad45d7e_5950015f","updated":"2016-08-16 14:48:38.000000000","message":"looks a bit weird to depend on agent_base_vendor but probably makes more sense in this case.","commit_id":"8eb01545675c0b88e9676cea1824c97d8c364913"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e6b80a23a9e20feb1d4a1db85543fc33880d728","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                     \u0027supported_raid_levels\u0027: list(RAID_LEVELS)})"},{"line_number":296,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027spanned\u0027:"},{"line_number":299,"context_line":"        if spans_count \u003c\u003d 1:"},{"line_number":300,"context_line":"            reason \u003d _(\u0027Spanned RAID volumes cannot contain a single span\u0027)"},{"line_number":301,"context_line":"            raise exception.DracOperationError(error\u003dreason)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_ddac8237","line":298,"updated":"2016-08-22 15:08:27.000000000","message":"Hm, I\u0027d leave the \u0027simple\u0027 path as before just in case, same for next 3 functions, but that\u0027s private function so dunno, maybe it\u0027s fine.","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"3930334976ef9fed396f3d1e6771e2b93659e134","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                     \u0027supported_raid_levels\u0027: list(RAID_LEVELS)})"},{"line_number":296,"context_line":"        raise exception.DracOperationError(error\u003dreason)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    if raid_level_info[\u0027type\u0027] \u003d\u003d \u0027spanned\u0027:"},{"line_number":299,"context_line":"        if spans_count \u003c\u003d 1:"},{"line_number":300,"context_line":"            reason \u003d _(\u0027Spanned RAID volumes cannot contain a single span\u0027)"},{"line_number":301,"context_line":"            raise exception.DracOperationError(error\u003dreason)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_1878512b","line":298,"in_reply_to":"1ac06dbe_ddac8237","updated":"2016-08-24 13:47:44.000000000","message":"The \u0027simple\u0027 path is still there at L290+L306. Just made it a bit more compact.","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e6b80a23a9e20feb1d4a1db85543fc33880d728","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"def _max_volume_size_mb(raid_level, physical_disks, free_space_mb,"},{"line_number":352,"context_line":"                        spans_count\u003d1, stripe_size_kb\u003d65536):"},{"line_number":353,"context_line":"    # restrict the size to the smallest available space"},{"line_number":354,"context_line":"    free_spaces \u003d [free_space_mb[disk] for disk in physical_disks]"},{"line_number":355,"context_line":"    size_kb \u003d min(free_spaces) * units.Ki"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_7d190e88","line":352,"range":{"start_line":352,"start_character":54,"end_line":352,"end_character":59},"updated":"2016-08-22 15:08:27.000000000","message":"same here, can be 64 * units.Ki","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"3930334976ef9fed396f3d1e6771e2b93659e134","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"def _max_volume_size_mb(raid_level, physical_disks, free_space_mb,"},{"line_number":352,"context_line":"                        spans_count\u003d1, stripe_size_kb\u003d65536):"},{"line_number":353,"context_line":"    # restrict the size to the smallest available space"},{"line_number":354,"context_line":"    free_spaces \u003d [free_space_mb[disk] for disk in physical_disks]"},{"line_number":355,"context_line":"    size_kb \u003d min(free_spaces) * units.Ki"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_7757d826","line":352,"range":{"start_line":352,"start_character":54,"end_line":352,"end_character":59},"in_reply_to":"1ac06dbe_7d190e88","updated":"2016-08-24 13:47:44.000000000","message":"Done","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e6b80a23a9e20feb1d4a1db85543fc33880d728","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"def _volume_usage_per_disk_mb(logical_disk, physical_disks, spans_count\u003d1,"},{"line_number":369,"context_line":"                              stripe_size_kb\u003d65536):"},{"line_number":370,"context_line":"    disks_count \u003d len(physical_disks)"},{"line_number":371,"context_line":"    overhead_disks_count \u003d _raid_level_overhead(logical_disk[\u0027raid_level\u0027],"},{"line_number":372,"context_line":"                                                spans_count)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_a4e892b5","line":369,"range":{"start_line":369,"start_character":45,"end_line":369,"end_character":50},"updated":"2016-08-22 15:08:27.000000000","message":"ditto","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"3930334976ef9fed396f3d1e6771e2b93659e134","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"def _volume_usage_per_disk_mb(logical_disk, physical_disks, spans_count\u003d1,"},{"line_number":369,"context_line":"                              stripe_size_kb\u003d65536):"},{"line_number":370,"context_line":"    disks_count \u003d len(physical_disks)"},{"line_number":371,"context_line":"    overhead_disks_count \u003d _raid_level_overhead(logical_disk[\u0027raid_level\u0027],"},{"line_number":372,"context_line":"                                                spans_count)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_57545c20","line":369,"range":{"start_line":369,"start_character":45,"end_line":369,"end_character":50},"in_reply_to":"1ac06dbe_a4e892b5","updated":"2016-08-24 13:47:44.000000000","message":"Done","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e6b80a23a9e20feb1d4a1db85543fc33880d728","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                             if \u0027physical_disks\u0027 not in disk]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    if volumes_without_disks:"},{"line_number":451,"context_line":"        result, free_size_mb \u003d ("},{"line_number":452,"context_line":"            _assign_disks_to_volume(volumes_without_disks,"},{"line_number":453,"context_line":"                                    physical_disks_by_type, free_space_mb))"},{"line_number":454,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_64385aa1","line":451,"range":{"start_line":451,"start_character":16,"end_line":451,"end_character":28},"updated":"2016-08-22 15:08:27.000000000","message":"Shouldn\u0027t it be either free_space_mb here or free_size_mb on L478? Also, could you please add a test that goes sequentially through all the 3 steps here to be sure that the result is as expected?","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"3930334976ef9fed396f3d1e6771e2b93659e134","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                             if \u0027physical_disks\u0027 not in disk]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    if volumes_without_disks:"},{"line_number":451,"context_line":"        result, free_size_mb \u003d ("},{"line_number":452,"context_line":"            _assign_disks_to_volume(volumes_without_disks,"},{"line_number":453,"context_line":"                                    physical_disks_by_type, free_space_mb))"},{"line_number":454,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_18d97184","line":451,"range":{"start_line":451,"start_character":16,"end_line":451,"end_character":28},"in_reply_to":"1ac06dbe_64385aa1","updated":"2016-08-24 13:47:44.000000000","message":"Nice catch, it should be free_space_mb.","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5b2bc84aa5dccf6d96be351d81b46809d639581e","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        return _commit_to_controllers(node, list(controllers))"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def get_logical_disk_properties(self, task):"},{"line_number":762,"context_line":"        \"\"\"Get the RAID configuration of the node."},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_9949a88e","line":761,"range":{"start_line":761,"start_character":42,"end_line":761,"end_character":46},"updated":"2016-08-26 13:31:06.000000000","message":"there is no task argument in the base class, and this method is called without arguments by conductor/manager. It seems that this method should be just renamed.","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d2e6b0c2d3b472a89ab9e0b48c0b6ba1936e64cf","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        return _commit_to_controllers(node, list(controllers))"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def get_logical_disk_properties(self, task):"},{"line_number":762,"context_line":"        \"\"\"Get the RAID configuration of the node."},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_7e0d46e7","line":761,"range":{"start_line":761,"start_character":42,"end_line":761,"end_character":46},"in_reply_to":"fa7ab95a_9949a88e","updated":"2016-08-29 14:11:26.000000000","message":"Done","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5b2bc84aa5dccf6d96be351d81b46809d639581e","unresolved":false,"context_lines":[{"line_number":828,"context_line":"            if config_job.state \u003d\u003d \u0027Completed\u0027:"},{"line_number":829,"context_line":"                task.upgrade_lock()"},{"line_number":830,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"},{"line_number":831,"context_line":"                self._resume_cleaning(task)"},{"line_number":832,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":833,"context_line":"                task.upgrade_lock()"},{"line_number":834,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_0f32a6f1","line":831,"range":{"start_line":831,"start_character":16,"end_line":831,"end_character":43},"updated":"2016-08-26 13:31:06.000000000","message":"Hmm, shouldn\u0027t we wait for all raid jobs to finish before we proceed with other clean steps?","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d2e6b0c2d3b472a89ab9e0b48c0b6ba1936e64cf","unresolved":false,"context_lines":[{"line_number":828,"context_line":"            if config_job.state \u003d\u003d \u0027Completed\u0027:"},{"line_number":829,"context_line":"                task.upgrade_lock()"},{"line_number":830,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"},{"line_number":831,"context_line":"                self._resume_cleaning(task)"},{"line_number":832,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":833,"context_line":"                task.upgrade_lock()"},{"line_number":834,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_071cf4bf","line":831,"range":{"start_line":831,"start_character":16,"end_line":831,"end_character":43},"in_reply_to":"fa7ab95a_0f32a6f1","updated":"2016-08-29 14:11:26.000000000","message":"Good point, we should.","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2d59e435048829e8a8310411753afa96f2fea5b4","unresolved":false,"context_lines":[{"line_number":832,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":833,"context_line":"                task.upgrade_lock()"},{"line_number":834,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"},{"line_number":835,"context_line":"                self._set_clean_failed(task, config_job)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def _delete_cached_config_job_id(self, node, config_job_id):"},{"line_number":838,"context_line":"        driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_ca3c2c32","line":835,"updated":"2016-08-26 13:36:02.000000000","message":"One more thing - on failure we\u0027ll set the cleanfail state but will still continue polling for all the jobs? What if we fail, wait for other jobs, and in the meantime a user restarts cleaning, will there be twice as more jobs to track? Is there a way to abort the remaining jobs here?","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"d2e6b0c2d3b472a89ab9e0b48c0b6ba1936e64cf","unresolved":false,"context_lines":[{"line_number":832,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":833,"context_line":"                task.upgrade_lock()"},{"line_number":834,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"},{"line_number":835,"context_line":"                self._set_clean_failed(task, config_job)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def _delete_cached_config_job_id(self, node, config_job_id):"},{"line_number":838,"context_line":"        driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa7ab95a_07eeb4b3","line":835,"in_reply_to":"fa7ab95a_ca3c2c32","updated":"2016-08-29 14:11:26.000000000","message":"There\u0027s no way to abort the remote jobs on the DRAC card but we should wait for all jobs before failing as you pointed out.","commit_id":"fdefcca5d817ab522bac475274febb184d01fd43"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d3f779dd1e3fe38406a431f1d3425422289c5c3c","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        node \u003d task.node"},{"line_number":823,"context_line":"        config_job_ids \u003d [job_id for job_id"},{"line_number":824,"context_line":"                          in node.driver_internal_info[\u0027raid_config_job_ids\u0027]]"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        for config_job_id in config_job_ids:"},{"line_number":827,"context_line":"            config_job \u003d drac_job.get_job(node, job_id\u003dconfig_job_id)"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa7ab95a_1480968a","line":824,"updated":"2016-08-29 15:15:53.000000000","message":"nit - why iterate through this list twice? It should be OK to leave as before.","commit_id":"5cbd86972412ac00681c98ececa2a8d71fac8da9"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"4fd9ffd993ca05df61830b338c5eaf2674c60b91","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        node \u003d task.node"},{"line_number":823,"context_line":"        config_job_ids \u003d [job_id for job_id"},{"line_number":824,"context_line":"                          in node.driver_internal_info[\u0027raid_config_job_ids\u0027]]"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        for config_job_id in config_job_ids:"},{"line_number":827,"context_line":"            config_job \u003d drac_job.get_job(node, job_id\u003dconfig_job_id)"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa7ab95a_f91e9b0a","line":824,"in_reply_to":"fa7ab95a_1480968a","updated":"2016-08-30 08:25:41.000000000","message":"Done","commit_id":"5cbd86972412ac00681c98ececa2a8d71fac8da9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d3f779dd1e3fe38406a431f1d3425422289c5c3c","unresolved":false,"context_lines":[{"line_number":832,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":833,"context_line":"                task.upgrade_lock()"},{"line_number":834,"context_line":"                self._set_raid_config_job_failure(node)"},{"line_number":835,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        if not node.driver_internal_info[\u0027raid_config_job_ids\u0027]:"},{"line_number":838,"context_line":"            if not node.driver_internal_info.get(\u0027raid_config_job_failure\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa7ab95a_6f3e6b8d","line":835,"updated":"2016-08-29 15:15:53.000000000","message":"Let\u0027s accumulate the job ids and do the deletion once per this function call to avoid too often saves.","commit_id":"5cbd86972412ac00681c98ececa2a8d71fac8da9"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"4fd9ffd993ca05df61830b338c5eaf2674c60b91","unresolved":false,"context_lines":[{"line_number":832,"context_line":"            elif config_job.state \u003d\u003d \u0027Failed\u0027:"},{"line_number":833,"context_line":"                task.upgrade_lock()"},{"line_number":834,"context_line":"                self._set_raid_config_job_failure(node)"},{"line_number":835,"context_line":"                self._delete_cached_config_job_id(node, config_job_id)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        if not node.driver_internal_info[\u0027raid_config_job_ids\u0027]:"},{"line_number":838,"context_line":"            if not node.driver_internal_info.get(\u0027raid_config_job_failure\u0027,"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa7ab95a_191a5f17","line":835,"in_reply_to":"fa7ab95a_6f3e6b8d","updated":"2016-08-30 08:25:41.000000000","message":"Done","commit_id":"5cbd86972412ac00681c98ececa2a8d71fac8da9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b1592680353b06e32fe3ecb3c520d12b7b44e7df","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    return int(stripes_per_disk * stripe_size_kb / units.Ki)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"def _find_configuration(logical_disks, physical_disks):"},{"line_number":384,"context_line":"    \"\"\"Find RAID configuration."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    This method transforms the RAID configuration defined in Ironic to a format"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa7ab95a_6ce9d9b6","line":383,"range":{"start_line":383,"start_character":4,"end_line":383,"end_character":23},"updated":"2016-08-30 12:09:04.000000000","message":"nit: I\u0027d split this function into several smaller","commit_id":"f358c7d85dd65d7a198cb740f4d254038957ad74"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"c21f87be94f79b0a6eb8020b4db7dd20496cf352","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    return int(stripes_per_disk * stripe_size_kb / units.Ki)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"def _find_configuration(logical_disks, physical_disks):"},{"line_number":384,"context_line":"    \"\"\"Find RAID configuration."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    This method transforms the RAID configuration defined in Ironic to a format"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa7ab95a_1f506ed3","line":383,"range":{"start_line":383,"start_character":4,"end_line":383,"end_character":23},"in_reply_to":"fa7ab95a_6ce9d9b6","updated":"2016-08-30 12:49:17.000000000","message":"how about doing it as a follow-up?","commit_id":"f358c7d85dd65d7a198cb740f4d254038957ad74"}],"ironic/drivers/modules/drac/vendor_passthru.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"de8463e3c7810897e35c59719957d7c33a7efdb5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        :raises: DracOperationError on an error from python-dracclient."},{"line_number":93,"context_line":"        :returns: A dictionary containing the job_id key with the id of the"},{"line_number":94,"context_line":"                  newly created config job, and the reboot_required key"},{"line_number":95,"context_line":"                  indicating whether to node needs to be rebooted to start the"},{"line_number":96,"context_line":"                  config job."},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        job_id \u003d bios.commit_config(task, reboot\u003dreboot)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_5de787ab","side":"PARENT","line":95,"updated":"2016-07-07 13:14:50.000000000","message":"\"to node\" -\u003e \"the node\"","commit_id":"3d027a46333ef727dcd3272de944fa692f716dc9"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"862bc6e6ed77a6bddab1bb97002f6229ff7841a4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        :raises: DracOperationError on an error from python-dracclient."},{"line_number":93,"context_line":"        :returns: A dictionary containing the job_id key with the id of the"},{"line_number":94,"context_line":"                  newly created config job, and the reboot_required key"},{"line_number":95,"context_line":"                  indicating whether to node needs to be rebooted to start the"},{"line_number":96,"context_line":"                  config job."},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        job_id \u003d bios.commit_config(task, reboot\u003dreboot)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_2c821dc9","side":"PARENT","line":95,"in_reply_to":"1aa78d24_5de787ab","updated":"2016-07-08 09:08:59.000000000","message":"Done","commit_id":"3d027a46333ef727dcd3272de944fa692f716dc9"}],"ironic/tests/unit/drivers/modules/drac/test_management.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"de8463e3c7810897e35c59719957d7c33a7efdb5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        mock_get_drac_client.return_value \u003d mock_client"},{"line_number":70,"context_line":"        mock_client.list_boot_modes.return_value \u003d ["},{"line_number":71,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_ipl),"},{"line_number":72,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_one_time)]"},{"line_number":73,"context_line":"        mock_client.list_boot_devices.return_value \u003d {"},{"line_number":74,"context_line":"            \u0027IPL\u0027: [test_utils.dict_to_namedtuple(values\u003dself.boot_device_pxe),"},{"line_number":75,"context_line":"                    test_utils.dict_to_namedtuple("}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_803fc8b2","line":72,"updated":"2016-07-07 13:14:50.000000000","message":"It\u0027s returning one_time data under the \u0027IPL\u0027 key, and vice-versa? This surprises me.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"862bc6e6ed77a6bddab1bb97002f6229ff7841a4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        mock_get_drac_client.return_value \u003d mock_client"},{"line_number":70,"context_line":"        mock_client.list_boot_modes.return_value \u003d ["},{"line_number":71,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_ipl),"},{"line_number":72,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_one_time)]"},{"line_number":73,"context_line":"        mock_client.list_boot_devices.return_value \u003d {"},{"line_number":74,"context_line":"            \u0027IPL\u0027: [test_utils.dict_to_namedtuple(values\u003dself.boot_device_pxe),"},{"line_number":75,"context_line":"                    test_utils.dict_to_namedtuple("}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_6cda65eb","line":72,"in_reply_to":"1aa78d24_803fc8b2","updated":"2016-07-08 09:08:59.000000000","message":"No, it\u0027s an array of the supported boot modes, not a dict of boot devies.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"de8463e3c7810897e35c59719957d7c33a7efdb5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        mock_client.list_boot_modes.return_value \u003d ["},{"line_number":71,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_ipl),"},{"line_number":72,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_one_time)]"},{"line_number":73,"context_line":"        mock_client.list_boot_devices.return_value \u003d {"},{"line_number":74,"context_line":"            \u0027IPL\u0027: [test_utils.dict_to_namedtuple(values\u003dself.boot_device_pxe),"},{"line_number":75,"context_line":"                    test_utils.dict_to_namedtuple("},{"line_number":76,"context_line":"                        values\u003dself.boot_device_disk)]}"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_e0b84c2c","line":73,"updated":"2016-07-07 13:14:50.000000000","message":"You appear to set these return values with only the key varying several times: you could factor out a helper function.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"862bc6e6ed77a6bddab1bb97002f6229ff7841a4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        mock_client.list_boot_modes.return_value \u003d ["},{"line_number":71,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_ipl),"},{"line_number":72,"context_line":"            test_utils.dict_to_namedtuple(values\u003dself.boot_mode_one_time)]"},{"line_number":73,"context_line":"        mock_client.list_boot_devices.return_value \u003d {"},{"line_number":74,"context_line":"            \u0027IPL\u0027: [test_utils.dict_to_namedtuple(values\u003dself.boot_device_pxe),"},{"line_number":75,"context_line":"                    test_utils.dict_to_namedtuple("},{"line_number":76,"context_line":"                        values\u003dself.boot_device_disk)]}"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_ac056d15","line":73,"in_reply_to":"1aa78d24_e0b84c2c","updated":"2016-07-08 09:08:59.000000000","message":"The unittests of the DRAC management interface isn\u0027t really the scope of this patch. It\u0027s already quite big, so I would rather not expand it. How about doing it separately?","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"}],"ironic/tests/unit/drivers/modules/drac/test_raid.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e6b80a23a9e20feb1d4a1db85543fc33880d728","unresolved":false,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        return physical_disks"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def test_validate(self):"},{"line_number":539,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":540,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":541,"context_line":"            task.driver.raid.validate(task)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def test_validate_raid_config(self):"},{"line_number":544,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":545,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":546,"context_line":"            task.driver.raid.validate_raid_config("},{"line_number":547,"context_line":"                task, self.target_raid_configuration)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test_validate_raid_config_missing_size_gb(self):"},{"line_number":550,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":551,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":552,"context_line":"            self.assertRaises("},{"line_number":553,"context_line":"                exception.InvalidParameterValue,"},{"line_number":554,"context_line":"                task.driver.raid.validate_raid_config, task,"},{"line_number":555,"context_line":"                {\u0027logical_disks\u0027: [{\u0027raid_level\u0027: \u00275\u0027}]})"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def test_validate_raid_config_missing_raid_level(self):"},{"line_number":558,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":559,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":560,"context_line":"            self.assertRaises("},{"line_number":561,"context_line":"                exception.InvalidParameterValue,"},{"line_number":562,"context_line":"                task.driver.raid.validate_raid_config, task,"},{"line_number":563,"context_line":"                {\u0027logical_disks\u0027: [{\u0027size_gb\u0027: \u0027500\u0027}]})"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":566,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_87f758f4","line":563,"range":{"start_line":538,"start_character":4,"end_line":563,"end_character":56},"updated":"2016-08-22 15:08:27.000000000","message":"this is tested elsewhere and can be removed now I think","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"3930334976ef9fed396f3d1e6771e2b93659e134","unresolved":false,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        return physical_disks"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def test_validate(self):"},{"line_number":539,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":540,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":541,"context_line":"            task.driver.raid.validate(task)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def test_validate_raid_config(self):"},{"line_number":544,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":545,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":546,"context_line":"            task.driver.raid.validate_raid_config("},{"line_number":547,"context_line":"                task, self.target_raid_configuration)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test_validate_raid_config_missing_size_gb(self):"},{"line_number":550,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":551,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":552,"context_line":"            self.assertRaises("},{"line_number":553,"context_line":"                exception.InvalidParameterValue,"},{"line_number":554,"context_line":"                task.driver.raid.validate_raid_config, task,"},{"line_number":555,"context_line":"                {\u0027logical_disks\u0027: [{\u0027raid_level\u0027: \u00275\u0027}]})"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def test_validate_raid_config_missing_raid_level(self):"},{"line_number":558,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":559,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":560,"context_line":"            self.assertRaises("},{"line_number":561,"context_line":"                exception.InvalidParameterValue,"},{"line_number":562,"context_line":"                task.driver.raid.validate_raid_config, task,"},{"line_number":563,"context_line":"                {\u0027logical_disks\u0027: [{\u0027size_gb\u0027: \u0027500\u0027}]})"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":566,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1ac06dbe_17d784c0","line":563,"range":{"start_line":538,"start_character":4,"end_line":563,"end_character":56},"in_reply_to":"1ac06dbe_87f758f4","updated":"2016-08-24 13:47:44.000000000","message":"Done","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"}],"ironic/tests/unit/drivers/modules/drac/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3d0e6ce938c5e8657f3773a729357fff52d0547","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    if values is None:"},{"line_number":21,"context_line":"        values \u003d {}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    return collections.namedtuple(name, values.keys())(**values)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_0f77f33a","line":23,"updated":"2016-06-29 09:37:14.000000000","message":"Why do we need it for the tests?","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"adb6b2a44ce62e1da20d6787c086791f9282ae6e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    if values is None:"},{"line_number":21,"context_line":"        values \u003d {}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    return collections.namedtuple(name, values.keys())(**values)"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_1a71a50c","line":23,"in_reply_to":"3aaa91ec_0f77f33a","updated":"2016-07-04 08:32:05.000000000","message":"dracclient methods return namedtuples. this is a helper method to convert dictionaries to namedtuples and mostly used for mocks.","commit_id":"06bf0a3c6fa84deec7d32479b60dc36a18654a8b"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"de8463e3c7810897e35c59719957d7c33a7efdb5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import collections"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def dict_to_namedtuple(name\u003d\u0027GenericNamedTuple\u0027, values\u003dNone):"},{"line_number":18,"context_line":"    \"\"\"Converts a dict to a collections.namedtuple\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    if values is None:"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_dda9b725","line":17,"updated":"2016-07-07 13:14:50.000000000","message":"This function isn\u0027t at all drac-specific: is there a more general utils module it can be added to?","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"862bc6e6ed77a6bddab1bb97002f6229ff7841a4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import collections"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def dict_to_namedtuple(name\u003d\u0027GenericNamedTuple\u0027, values\u003dNone):"},{"line_number":18,"context_line":"    \"\"\"Converts a dict to a collections.namedtuple\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    if values is None:"}],"source_content_type":"text/x-python","patch_set":25,"id":"1aa78d24_f7b8deea","line":17,"in_reply_to":"1aa78d24_dda9b725","updated":"2016-07-08 09:08:59.000000000","message":"Good point, though I didn\u0027t find any other suitable place for that.","commit_id":"2b69ba41adc3be0b4396cfa5cd7f990cc8beafab"}],"releasenotes/notes/drac-raid-interface-f4c02b1c4fb37e2d.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"163d2f10f56a8edaa6f49cb1fdd2175fd4a4480c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds out-of-band RAID management to DRAC driver using the generic RAID"},{"line_number":4,"context_line":"    interface which makes the functionality available via manual cleaning"},{"line_number":5,"context_line":"    steps."},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dada55a8_e801dd6b","line":3,"updated":"2016-07-19 11:06:29.000000000","message":"s/Adds/Add/","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"35866c445b433f502082fa8c60485353e249a350","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds out-of-band RAID management to DRAC driver using the generic RAID"},{"line_number":4,"context_line":"    interface which makes the functionality available via manual cleaning"},{"line_number":5,"context_line":"    steps."},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dada55a8_12fe176b","line":3,"in_reply_to":"dada55a8_e801dd6b","updated":"2016-07-25 17:04:45.000000000","message":"Why?\n\nhttps://github.com/openstack/ironic/blob/master/releasenotes/notes/add-agent-iboot-0a4b5471c6ace461.yaml","commit_id":"67791947e90915e463f176e7cfb7b87b0c784327"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7e6b80a23a9e20feb1d4a1db85543fc33880d728","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    is added. After Ironic has created the RAID config job on the DRAC card,"},{"line_number":9,"context_line":"    it continues to check for status update on the config job to determine"},{"line_number":10,"context_line":"    whether the RAID configuration was successfully finished at this interval."},{"line_number":11,"context_line":"    Default is 180 seconds."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1ac06dbe_ca7315e6","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":18},"updated":"2016-08-22 15:08:27.000000000","message":"120","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"3930334976ef9fed396f3d1e6771e2b93659e134","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    is added. After Ironic has created the RAID config job on the DRAC card,"},{"line_number":9,"context_line":"    it continues to check for status update on the config job to determine"},{"line_number":10,"context_line":"    whether the RAID configuration was successfully finished at this interval."},{"line_number":11,"context_line":"    Default is 180 seconds."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1ac06dbe_d70fac86","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":18},"in_reply_to":"1ac06dbe_ca7315e6","updated":"2016-08-24 13:47:44.000000000","message":"Done","commit_id":"2b016a5e108a3f4a399704678ffb9b707d6230e2"}]}
