)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b9a6a3721006ff7e5bb3fef621cfc26b1411f599","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync with oslo.incubator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update config generator to use new style list_opts discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I397504bf0604a86082f26e46952720117611f3a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3acd31a7_c6724049","line":9,"updated":"2015-05-04 14:26:37.000000000","message":"This isn\u0027t sync\u0027ing with oslo.incubator. Or maybe it is, by removing the files...\n\nI think we should update the commit message to reflect that oslo config generator was removed from oslo incubator and we don\u0027t want to use the new mechanism (I forgot what it was, but it was unwieldy, maybe put a link to that review or something?) so we\u0027re going to stick with the config generator and this moves it to ironic/common.\n\nOr something like the above. So people will know what happened :-)","commit_id":"6dec8fe44b73754911359f4a65bbeb6d6f88c1de"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"24df516e311398093cc497bd1368e736db9ee7da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync with oslo.incubator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update config generator to use new style list_opts discovery"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I397504bf0604a86082f26e46952720117611f3a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3acd31a7_a1004e02","line":9,"in_reply_to":"3acd31a7_c6724049","updated":"2015-05-04 14:39:18.000000000","message":"Note it.","commit_id":"6dec8fe44b73754911359f4a65bbeb6d6f88c1de"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"33234118c59ac3a17c825aadb0d2598e3a749618","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adopt config generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.config.generator has been removed from olso-incubator so"},{"line_number":10,"context_line":"we need to adopt it in order to generated uptodate config"},{"line_number":11,"context_line":"files."},{"line_number":12,"context_line":"Changes introduced:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3acd31a7_af54b420","line":9,"updated":"2015-05-04 17:09:04.000000000","message":"s/olso-incubator/oslo-incubator","commit_id":"8fe82a9055a1f0210be6cf718c12c1c277ff3964"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"33234118c59ac3a17c825aadb0d2598e3a749618","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adopt config generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.config.generator has been removed from olso-incubator so"},{"line_number":10,"context_line":"we need to adopt it in order to generated uptodate config"},{"line_number":11,"context_line":"files."},{"line_number":12,"context_line":"Changes introduced:"},{"line_number":13,"context_line":"- Move config/generator.py from openstack.common to ironic.common"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3acd31a7_6f357cf5","line":10,"updated":"2015-05-04 17:09:04.000000000","message":"s/uptodate/up-to-date","commit_id":"8fe82a9055a1f0210be6cf718c12c1c277ff3964"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e596adc0e9af09d96656384704966331f12d0459","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adopt config generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.config.generator has been removed from olso-incubator so"},{"line_number":10,"context_line":"we need to adopt it in order to generated up-to-date config"},{"line_number":11,"context_line":"files."},{"line_number":12,"context_line":"Changes introduced:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3acd31a7_4d0c01ed","line":9,"updated":"2015-05-04 21:23:24.000000000","message":"olso-incubator should be oslo-incubator","commit_id":"338c1f2d017ef449211dac9ec6937aee401f71e9"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"92cf22e08464590219c5b3a162b5e0c26ebe40ff","unresolved":false,"context_lines":[{"line_number":211,"context_line":"#parallel_image_downloads\u003dfalse"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"[None]"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"#"},{"line_number":217,"context_line":"# Options defined in ironic.openstack.common.eventlet_backdoor"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bab921fb_7673734e","line":214,"updated":"2015-04-23 10:23:46.000000000","message":"Is this \"None\" really a correct group?","commit_id":"d6ddac0b92b0e7cdbcb8d18499102f0f12979987"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"daecf656a87cd0a1a9690144e50b57007aeafa45","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"#rpc_conn_pool_size\u003d30"},{"line_number":1296,"context_line":""},{"line_number":1297,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":1298,"context_line":"#qpid_hostname\u003dironic"},{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":"# Qpid broker port. (integer value)"},{"line_number":1301,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bab921fb_adee4420","line":1298,"updated":"2015-04-23 18:35:23.000000000","message":"this should be localhost still","commit_id":"d6ddac0b92b0e7cdbcb8d18499102f0f12979987"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"daecf656a87cd0a1a9690144e50b57007aeafa45","unresolved":false,"context_lines":[{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":1375,"context_line":"# (string value)"},{"line_number":1376,"context_line":"#rabbit_host\u003dironic"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":1379,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bab921fb_4dde886e","line":1376,"updated":"2015-04-23 18:35:23.000000000","message":"this should be localhost still","commit_id":"d6ddac0b92b0e7cdbcb8d18499102f0f12979987"}],"ironic/openstack/common/config/generator.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3d46d20fd6e3f998007981c5967f31cc035d028","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import socket"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import textwrap"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo.config import cfg"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":"import stevedore.named"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_3f6dc404","line":29,"updated":"2015-04-30 11:37:01.000000000","message":"as this file is no longer managed in incubator, please change oslo.config -\u003e oslo_config here manualy","commit_id":"f8b504bf3eb929985edc807170eb74ff50f06acd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7fec68cef97425b979002aa2157c5be04a967a0b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import socket"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import textwrap"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo.config import cfg"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":"import stevedore.named"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_b3aa2b6f","line":29,"in_reply_to":"3acd31a7_3f6dc404","updated":"2015-04-30 13:09:28.000000000","message":"If this file isn\u0027t in oslo-incubator any more, shouldn\u0027t we move it to ironic/common/... and add a comment about that to this file?","commit_id":"f8b504bf3eb929985edc807170eb74ff50f06acd"}],"tox.ini":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b9a6a3721006ff7e5bb3fef621cfc26b1411f599","unresolved":false,"context_lines":[{"line_number":61,"context_line":"[flake8]"},{"line_number":62,"context_line":"# E711: ignored because it is normal to use \"column \u003d\u003d None\" in sqlalchemy"},{"line_number":63,"context_line":"ignore \u003d E123,E126,E127,E128,E129,E711"},{"line_number":64,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*,*ironic/common/config_generator/generator.py"},{"line_number":65,"context_line":"max-complexity\u003d17"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[hacking]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3acd31a7_8609e8df","line":64,"updated":"2015-05-04 14:26:37.000000000","message":"now that we\u0027ve moved this to ironic/common, do we want to exclude it? I\u0027m guessing that we need to maintain this file now? Or do we want to exclude it just to minimize the changes? Or do we want to exclude it for now, so that we can see it was just renamed from incubator. And maybe in a future patch, not exclude it?","commit_id":"6dec8fe44b73754911359f4a65bbeb6d6f88c1de"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"24df516e311398093cc497bd1368e736db9ee7da","unresolved":false,"context_lines":[{"line_number":61,"context_line":"[flake8]"},{"line_number":62,"context_line":"# E711: ignored because it is normal to use \"column \u003d\u003d None\" in sqlalchemy"},{"line_number":63,"context_line":"ignore \u003d E123,E126,E127,E128,E129,E711"},{"line_number":64,"context_line":"exclude \u003d  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*,*ironic/common/config_generator/generator.py"},{"line_number":65,"context_line":"max-complexity\u003d17"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[hacking]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3acd31a7_a1272eb5","line":64,"in_reply_to":"3acd31a7_8609e8df","updated":"2015-05-04 14:39:18.000000000","message":"Will fix the pep8 errors and remove it from here. Now that we have to maintain it, should be the way to proceed","commit_id":"6dec8fe44b73754911359f4a65bbeb6d6f88c1de"}]}