)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2f34ed0bf793e44e7269513f2168f0ab366aaaa8","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"    @periodic_task.periodic_task("},{"line_number":1094,"context_line":"            spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1095,"context_line":"    def _check_deploy_timeouts(self, context):"},{"line_number":1096,"context_line":"        \"\"\"Periodically checks whether a deploy RPC call has timed out.\"\"\""},{"line_number":1097,"context_line":"        callback_timeout \u003d CONF.conductor.deploy_callback_timeout"},{"line_number":1098,"context_line":"        if not callback_timeout:"},{"line_number":1099,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_0ec71c97","line":1096,"updated":"2015-05-05 02:00:53.000000000","message":"Is it worth mentioning what happens if the call has timed out?","commit_id":"a3a6bb654af79525b5f13a4e406957e2ecd1342f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"841f587002042c173e6252cc591cfcb00f465de4","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"    @periodic_task.periodic_task("},{"line_number":1094,"context_line":"            spacing\u003dCONF.conductor.check_provision_state_interval)"},{"line_number":1095,"context_line":"    def _check_deploy_timeouts(self, context):"},{"line_number":1096,"context_line":"        \"\"\"Periodically checks whether a deploy RPC call has timed out.\"\"\""},{"line_number":1097,"context_line":"        callback_timeout \u003d CONF.conductor.deploy_callback_timeout"},{"line_number":1098,"context_line":"        if not callback_timeout:"},{"line_number":1099,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_ece2962e","line":1096,"in_reply_to":"3acd31a7_0ec71c97","updated":"2015-05-05 14:49:59.000000000","message":"Yes. It\u0027s unclear what the method does once it finishes (it cleans up). Change coming in next patch set.","commit_id":"a3a6bb654af79525b5f13a4e406957e2ecd1342f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2f34ed0bf793e44e7269513f2168f0ab366aaaa8","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"                               sort_key, callback_method, err_handler)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def _do_takeover(self, task):"},{"line_number":1112,"context_line":"        \"\"\"Executes task for conductor taking over a node and saves to DB.\"\"\""},{"line_number":1113,"context_line":"        LOG.debug((\u0027Conductor %(cdr)s taking over node %(node)s\u0027),"},{"line_number":1114,"context_line":"                  {\u0027cdr\u0027: self.host, \u0027node\u0027: task.node.uuid})"},{"line_number":1115,"context_line":"        task.driver.deploy.prepare(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_8b4c3e9f","line":1112,"updated":"2015-05-05 02:00:53.000000000","message":"I\u0027m not sure I understand this. What is saved to the DB?\n\nI think this might be the first time I\u0027ve seen \u0027Executes task\u0027 for the task argument. Or is the \u0027task\u0027 here not meant to refer to the \u0027task\u0027 argument?\n\nThis is basically setting things up on the new conductor so that it can take over the node and continue (from the previous conductor) to \u0027manage\u0027 (not sure what the correct word is) the node.","commit_id":"a3a6bb654af79525b5f13a4e406957e2ecd1342f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"841f587002042c173e6252cc591cfcb00f465de4","unresolved":false,"context_lines":[{"line_number":1109,"context_line":"                               sort_key, callback_method, err_handler)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"    def _do_takeover(self, task):"},{"line_number":1112,"context_line":"        \"\"\"Executes task for conductor taking over a node and saves to DB.\"\"\""},{"line_number":1113,"context_line":"        LOG.debug((\u0027Conductor %(cdr)s taking over node %(node)s\u0027),"},{"line_number":1114,"context_line":"                  {\u0027cdr\u0027: self.host, \u0027node\u0027: task.node.uuid})"},{"line_number":1115,"context_line":"        task.driver.deploy.prepare(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_cc07dac8","line":1112,"in_reply_to":"3acd31a7_8b4c3e9f","updated":"2015-05-05 14:49:59.000000000","message":"The node is saved to the DB after changing its conductor affinity.\n\nYep, \u0027task\u0027 is the \u0027task\u0027 argument. It might not be worth saying that.\n\nI think this actually performs the takeover as well by calling task.driver.deploy.take_over, in addition to preparing for it.\n\nI\u0027ll make the first line more concise and add additional detail.","commit_id":"a3a6bb654af79525b5f13a4e406957e2ecd1342f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2f34ed0bf793e44e7269513f2168f0ab366aaaa8","unresolved":false,"context_lines":[{"line_number":1933,"context_line":""},{"line_number":1934,"context_line":"    :param task: a TaskManager instance with an exclusive lock"},{"line_number":1935,"context_line":"    :param actual_power_state: string describing the actual power state of the"},{"line_number":1936,"context_line":"           node"},{"line_number":1937,"context_line":"    \"\"\""},{"line_number":1938,"context_line":"    node \u003d task.node"},{"line_number":1939,"context_line":"    msg \u003d (_(\"During sync_power_state, max retries exceeded \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_6ef0d0fe","line":1936,"updated":"2015-05-05 02:00:53.000000000","message":"Interesting; I hadn\u0027t thought of it like that. Although this is somewhat true, it might be misleading because it could be interpreted as any descriptor/string, but only a certain set are valid. We represent our power state values as strings (see ironic/common/states.py). A more accurate description might be something like \u0027the actual power state of the node; a power state from ironic.common.states\u0027.","commit_id":"a3a6bb654af79525b5f13a4e406957e2ecd1342f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"841f587002042c173e6252cc591cfcb00f465de4","unresolved":false,"context_lines":[{"line_number":1933,"context_line":""},{"line_number":1934,"context_line":"    :param task: a TaskManager instance with an exclusive lock"},{"line_number":1935,"context_line":"    :param actual_power_state: string describing the actual power state of the"},{"line_number":1936,"context_line":"           node"},{"line_number":1937,"context_line":"    \"\"\""},{"line_number":1938,"context_line":"    node \u003d task.node"},{"line_number":1939,"context_line":"    msg \u003d (_(\"During sync_power_state, max retries exceeded \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_2cf9aec7","line":1936,"in_reply_to":"3acd31a7_6ef0d0fe","updated":"2015-05-05 14:49:59.000000000","message":"+1, change coming in next patch set.","commit_id":"a3a6bb654af79525b5f13a4e406957e2ecd1342f"}]}
