)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"d42ace3363566dc8ad6216f91b9eb681a1e0f3ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-05 17:22:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up instance specific informantion on tear down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After sucessfully tearing down a node some information about the previous"},{"line_number":10,"context_line":"instance are still shown to the user. Things like the root UUID of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9af37de9_62e75b41","line":7,"updated":"2015-05-11 06:12:56.000000000","message":"s/informantion/information/","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"d42ace3363566dc8ad6216f91b9eb681a1e0f3ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up instance specific informantion on tear down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After sucessfully tearing down a node some information about the previous"},{"line_number":10,"context_line":"instance are still shown to the user. Things like the root UUID of the"},{"line_number":11,"context_line":"last image\u0027s filesystem and whether it was a full disk image or not. Those"},{"line_number":12,"context_line":"information should be cleaned up."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9af37de9_02d52f42","line":9,"updated":"2015-05-11 06:12:56.000000000","message":"s/sucessfully/successfully/","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"339ab3840aa225cd04ef2e24306ee2644a9f0570","unresolved":false,"context_lines":[{"line_number":11,"context_line":"last image\u0027s filesystem and whether it was a full disk image or not. Those"},{"line_number":12,"context_line":"information should be cleaned up."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Apparently only the PXE driver was leaving such informations."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1451885"},{"line_number":17,"context_line":"Change-Id: Ice9926bbbb93d2ecf8ac1c70fcd78b7e8b76bf22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aca2d91_df5ee175","line":14,"updated":"2015-05-06 13:00:22.000000000","message":"Agent leaves things like agent_url, hardware_manager_version, is_whole_disk_image in driver_internal_info.","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"65d32246b6becc23976f83579132f57e218a0e9a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"last image\u0027s filesystem and whether it was a full disk image or not. Those"},{"line_number":12,"context_line":"information should be cleaned up."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Apparently only the PXE driver was leaving such informations."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1451885"},{"line_number":17,"context_line":"Change-Id: Ice9926bbbb93d2ecf8ac1c70fcd78b7e8b76bf22"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_12268ece","line":14,"in_reply_to":"1aca2d91_df5ee175","updated":"2015-05-12 18:23:09.000000000","message":"Doesn\u0027t ilo driver also leave is_whole_disk_image (and maybe other things)?\n\nI\u0027m fine if this patch is a Partial-Bug fix :-)","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"ae18bd475c82014df781d5195dd89d100ecb5fd8","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # Remove instance specific information"},{"line_number":435,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":436,"context_line":"        driver_internal_info.pop(\u0027is_whole_disk_image\u0027, None)"},{"line_number":437,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":438,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_12e5f8a6","line":435,"updated":"2015-07-31 19:12:07.000000000","message":"Hmm. So, it seems that in many cases, individual drivers are responsible for setting/storing data here during certain phases (prepare, deploy, or even when setting boot mode). So, I would say, it should be the responsibility of each driver to clean up after each of those in the right places.\n\nOn the other hand, is_whole_disk_image is set by the conductor -- so yea, it should be erased by the conductor, too. This is a bit odd, honestly .... why is the conductor setting a parameter in driver_internal_info?","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"4398ac2a5d9b176ee50b71edefc4f4e21207b583","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # Remove instance specific information"},{"line_number":435,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":436,"context_line":"        driver_internal_info.pop(\u0027is_whole_disk_image\u0027, None)"},{"line_number":437,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":438,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_0ba16ca3","line":435,"updated":"2015-05-08 06:37:25.000000000","message":"This removes only for pxe driver.  Can we remove this here please:\n\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L812-L817","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"90fbed812527a09cacc0b86fe554118d14e238a1","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # Remove instance specific information"},{"line_number":435,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":436,"context_line":"        driver_internal_info.pop(\u0027is_whole_disk_image\u0027, None)"},{"line_number":437,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":438,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_729d6d58","line":435,"in_reply_to":"1aca2d91_0ba16ca3","updated":"2015-05-08 09:54:29.000000000","message":"Ramakrishnan, does this in manager is not good because 1) instance-related info in driver_internal_info can be driver specific 2) we should not clean all in driver_internal_info, hardware-related parameters can be stored there. Maybe new field like \"driver_instance_info\" is required?","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"65d32246b6becc23976f83579132f57e218a0e9a","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # Remove instance specific information"},{"line_number":435,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":436,"context_line":"        driver_internal_info.pop(\u0027is_whole_disk_image\u0027, None)"},{"line_number":437,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":438,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_728dca30","line":435,"in_reply_to":"1aca2d91_7271eddf","updated":"2015-05-12 18:23:09.000000000","message":"Just to throw something else out there -- I encountered at least one developer that didn\u0027t want to use driver_internal_info because they thought the info there was driver-specific. My want (at the time) was to have some internal_foo field that could be used internally, I didn\u0027t care about the name, but I guess I should have :-)\n\nAnother way to do it is to eg add a new function or variable that returns/is a list of the fields that should be removed from driver_internal_info. Then in conductor._do_node_tear_down() (where Ramesh indicated), the conductor could remove those fields. The adv (or not?) is that if driver.deploy.clean_up() or driver.deploy_tear_down() fail, the fields will still be removed (which I guess is consistent with instance_info being cleared out).","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":9315,"name":"ramesh","email":"rameshg87@gmail.com","username":"rameshg87"},"change_message_id":"b63fd025aa96829b87fbe0ddf569e8929a5014b6","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # Remove instance specific information"},{"line_number":435,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":436,"context_line":"        driver_internal_info.pop(\u0027is_whole_disk_image\u0027, None)"},{"line_number":437,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":438,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_b22f85f5","line":435,"in_reply_to":"1aca2d91_729d6d58","updated":"2015-05-08 09:58:15.000000000","message":"Yeah I agree. \n\nInstead of a new field, a low cost alternative might be driver_internal_info[\u0027instance\u0027] which can be a JSON where drivers may store internal instance information and expect conductor the clear it on tear down.","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"bdd31ed183917e93bd7e8b0a1b9d5f8cd92b8566","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # Remove instance specific information"},{"line_number":435,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":436,"context_line":"        driver_internal_info.pop(\u0027is_whole_disk_image\u0027, None)"},{"line_number":437,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":438,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_7271eddf","line":435,"in_reply_to":"1aca2d91_b22f85f5","updated":"2015-05-08 10:07:09.000000000","message":"+1","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"}],"ironic/tests/drivers/test_pxe.py":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"d42ace3363566dc8ad6216f91b9eb681a1e0f3ca","unresolved":false,"context_lines":[{"line_number":897,"context_line":"            state \u003d task.driver.deploy.tear_down(task)"},{"line_number":898,"context_line":"            self.assertEqual(states.DELETED, state)"},{"line_number":899,"context_line":"            node_power_mock.assert_called_once_with(task, states.POWER_OFF)"},{"line_number":900,"context_line":"            # Assert instance spefic information is not present"},{"line_number":901,"context_line":"            self.assertNotIn(\u0027is_whole_disk_image\u0027,"},{"line_number":902,"context_line":"                             task.node.driver_internal_info)"},{"line_number":903,"context_line":"            self.assertNotIn(\u0027root_uuid_or_disk_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9af37de9_e240eb09","line":900,"updated":"2015-05-11 06:12:56.000000000","message":"s/spefic/specific/","commit_id":"bae53deae210f0a285363bb56d79764cb888270d"}]}